Hello, On 26/12/18 05:05, Kangjie Lu wrote: > efx_mcdi_rpc() could fail. The fix checks its status and issues an error > message if it fails. > > Signed-off-by: Kangjie Lu <k...@umn.edu> > --- > drivers/net/ethernet/sfc/mcdi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/sfc/mcdi.c b/drivers/net/ethernet/sfc/mcdi.c > index dfad93fca0a6..9486e6534dea 100644 > --- a/drivers/net/ethernet/sfc/mcdi.c > +++ b/drivers/net/ethernet/sfc/mcdi.c > @@ -1819,6 +1819,9 @@ void efx_mcdi_set_id_led(struct efx_nic *efx, enum > efx_led_mode mode) > > rc = efx_mcdi_rpc(efx, MC_CMD_SET_ID_LED, inbuf, sizeof(inbuf), > NULL, 0, NULL); > + if (rc) > + netif_err(efx, hw, efx->net_dev, "%s: failed rc=%d\n", > + __func__, rc); > }
efx_mcdi_rpc() already issues an error message on failure, so this doesn't add anything beyond that. Are you trying to address a particular issue with this patch? Thanks, Bert.
