Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-04 Thread Bastien Nocera
On Sun, 2020-10-04 at 15:18 +0200, Greg Kroah-Hartman wrote: > On Sun, Oct 04, 2020 at 02:17:06PM +0200, Bastien Nocera wrote: > > On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote: > > > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrot

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-04 Thread Bastien Nocera
On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote: > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrote: > > Hi Greg, > > > > > > > This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 > > > > > as it > > > > > breaks all bluetooth connections on my machine. > > > >

Re: [PATCH 00/22] staging: rtl87232bs: Fix errors and warnings detected by Smatch

2017-04-09 Thread Bastien Nocera
> > Signed-off-by: Larry Finger Feel free to add: Reviewed-by: Bastien Nocera for all the patches I didn't directly comment on. Cheers

Re: [PATCH 20/22] staging rtl8723bs: Fix indenting errors and an off-by-one mistake in core/rtw_mlme_ext.c

2017-04-09 Thread Bastien Nocera
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote: > } else { > -   for (pstat->aid = 1; pstat->aid <= NUM_STA; pstat->aid++) > +   for (pstat->aid = 1; pstat->aid < NUM_STA; pstat->aid++) > if (pstapriv->sta_aid[pstat->aid - 1] == NULL) >

Re: [PATCH 16/22] staging: rtl8723bs: Fix some indenting problems and a potential data overrun

2017-04-09 Thread Bastien Nocera
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote: > +   if (cam_id >= 0 && cam_id < 32) Isn't there a constant we could use instead of hard-coding this?

Re: [PATCH 13/22] staging: rtl8723bs: Fix indenting mistake in core/rtw_ap.c

2017-04-09 Thread Bastien Nocera
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote: > Fixing this requires changing the indentatikon of a long for loop. Typo here.

Re: [PATCH 06/22] staging: rtl8723bs: Fix various errors in os_dep/ioctl_cfg80211.c

2017-04-09 Thread Bastien Nocera
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote: > Smatch lists the following: > >   CHECK   drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:470 > rtw_cfg80211_ibss_indicate_connect() error: we previously assumed > 'scanned' could be null

Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

2015-07-14 Thread Bastien Nocera
On Tue, 2015-07-14 at 15:21 +0200, Johannes Berg wrote: > On Tue, 2015-07-14 at 08:20 -0500, Larry Finger wrote: > > On 07/13/2015 05:11 PM, Bastien Nocera wrote: > > > http://thread.gmane.org/gmane.linux.kernel.wireless.general/12770 > > > 6/ > > > focu >

Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

2015-07-14 Thread Bastien Nocera
On Tue, 2015-07-14 at 08:20 -0500, Larry Finger wrote: > On 07/13/2015 05:11 PM, Bastien Nocera wrote: > > http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/ > > focu > > s=127896 > > > > Signed-off-by: Bastien Nocera > > Bastien, > &g

Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

2015-07-14 Thread Bastien Nocera
On Tue, 2015-07-14 at 17:29 +0200, Marcel Holtmann wrote: > Hi Bastien, > > > http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/ > > focu > > s=127896 > > > > Signed-off-by: Bastien Nocera > > > > --- > > net/rfki

[PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

2015-07-13 Thread Bastien Nocera
http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/focu s=127896 Signed-off-by: Bastien Nocera --- net/rfkill/rfkill-gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c index d5d58d9..9471024 100644 --- a/net/rfkill