Re: [RESEND PATCH v8 net-next 03/15] net: mvpp2: add CM3 SRAM memory map

2021-02-07 Thread Baruch Siach
Hi Stefan, On Sun, Feb 07 2021, stef...@marvell.com wrote: > From: Stefan Chulski > > This patch adds CM3 memory map and CM3 read/write callbacks. > No functionality changes. > > Signed-off-by: Stefan Chulski > --- > drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 7 +++ > drivers/net/ethern

Re: [PATCH v2 2/2] docs: networking: packet_mmap: fix old config reference

2020-12-30 Thread Baruch Siach
requires two if you want to get packet's timestamp (like libpcap always does). I think libpcap still reads packets timestamps, though it most likely uses the newer interface for that. Maybe we should just drop the libpcap reference here? Thanks for reviewing the patch, baruch > On

[PATCH v2 1/2] docs: networking: packet_mmap: fix formatting for C macros

2020-12-29 Thread Baruch Siach
The citation of macro definitions should appear in a code block. Signed-off-by: Baruch Siach --- Documentation/networking/packet_mmap.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/packet_mmap.rst b/Documentation/networking/packet_mmap.rst

[PATCH v2 2/2] docs: networking: packet_mmap: fix old config reference

2020-12-29 Thread Baruch Siach
reference to broken link to information for pre 2.6.5 kernels. Make a slight working improvement (s/In/On/) while at it. Signed-off-by: Baruch Siach --- v2: Address comments from Jakub Kicinski and Willem de Bruijn * Don't change PACKET_MMAP * Remove mention of specific kernel vers

[PATCH v2] docs: netdev-FAQ: fix question headers formatting

2020-12-20 Thread Baruch Siach
Join adjacent questions to a single question line. This fixes the formatting of questions that were not part of the heading. Also, drop Q: and A: prefixes. We don't need them now that questions and answers are visually separated. Signed-off-by: Baruch Siach --- v2: Address comments from

Re: [PATCH net] docs: netdev-FAQ: add missing underlines to questions

2020-12-20 Thread Baruch Siach
Hi Jakub, On Thu, Dec 17 2020, Jakub Kicinski wrote: > On Tue, 15 Dec 2020 19:18:19 +0200 Baruch Siach wrote: >> Signed-off-by: Baruch Siach >> --- >> Documentation/networking/netdev-FAQ.rst | 18 +++--- >> 1 file changed, 11 insertions(+), 7 delet

Re: [PATCH net 2/2] docs: networking: packet_mmap: don't mention PACKET_MMAP

2020-12-20 Thread Baruch Siach
Hi Willem, On Thu, Dec 17 2020, Willem de Bruijn wrote: > On Thu, Dec 17, 2020 at 2:48 PM Jakub Kicinski wrote: >> >> On Tue, 15 Dec 2020 18:51:17 +0200 Baruch Siach wrote: >> > Before commit 889b8f964f2f ("packet: Kill CONFIG_PACKET_MMAP.") there >>

Re: [PATCH net 2/2] docs: networking: packet_mmap: don't mention PACKET_MMAP

2020-12-19 Thread Baruch Siach
Hi Jakub, On Thu, Dec 17 2020, Jakub Kicinski wrote: > On Tue, 15 Dec 2020 18:51:17 +0200 Baruch Siach wrote: >> Before commit 889b8f964f2f ("packet: Kill CONFIG_PACKET_MMAP.") there >> used to be a CONFIG_PACKET_MMAP config symbol that depended on >> CONFIG_P

[PATCH net] net: af_packet: fix procfs header for 64-bit pointers

2020-12-15 Thread Baruch Siach
16250 be62127d 3 3fbcd 8 1 0 0 16254 ... Signed-off-by: Baruch Siach --- net/packet/af_packet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 7a188551..99de3bbe437f 100644 --- a/

[PATCH net] docs: netdev-FAQ: add missing underlines to questions

2020-12-15 Thread Baruch Siach
Signed-off-by: Baruch Siach --- Documentation/networking/netdev-FAQ.rst | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/Documentation/networking/netdev-FAQ.rst b/Documentation/networking/netdev-FAQ.rst index 4b9ed5874d5a..4ef90fe26640 100644 --- a

[PATCH net 2/2] docs: networking: packet_mmap: don't mention PACKET_MMAP

2020-12-15 Thread Baruch Siach
ket MMAP". Use "PACKET mmap()" everywhere to unify the terminology. Rephrase the text the implied mmap() feature disable option. Also, drop reference to broken link to information for pre 2.6.5 kernels. Signed-off-by: Baruch Siach --- Documentation/networking/packet_mmap.rst | 73 ++

[PATCH net 1/2] docs: networking: packet_mmap: fix formatting for C macros

2020-12-15 Thread Baruch Siach
The citation of macro definitions should appear in a code block. Signed-off-by: Baruch Siach --- Documentation/networking/packet_mmap.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/packet_mmap.rst b/Documentation/networking/packet_mmap.rst

[PATCH ethtool v2] Improve error message when SFP module is missing

2020-12-02 Thread Baruch Siach
ETHTOOL_GMODULEINFO request success indicates that SFP cage is present. Failure of ETHTOOL_GMODULEEEPROM is most likely because SFP module is not plugged in. Add an indication to the user as to what might be the reason for the failure. Signed-off-by: Baruch Siach --- v2: Limit message to likely

[PATCH ethtool] Improve error message when SFP module is missing

2020-11-30 Thread Baruch Siach
ETHTOOL_GMODULEINFO request success indicates that SFP cage is present. Failure of ETHTOOL_GMODULEEEPROM is most likely because SFP module is not plugged in. Add an indication to the user as to what might be the reason for the failure. Signed-off-by: Baruch Siach --- ethtool.c | 1 + 1 file

Re: Get MAC supported link modes for SFP port

2020-11-26 Thread Baruch Siach
Hi Andrew, On Thu, Nov 26 2020, Andrew Lunn wrote: > On Thu, Nov 26, 2020 at 05:37:22PM +0200, Baruch Siach wrote: >> I am trying to retrieve all MAC supported link modes >> (ETHTOOL_LINK_MODE_*) for network interfaces with SFP port. The >> 'supported' bit mask that

Get MAC supported link modes for SFP port

2020-11-26 Thread Baruch Siach
Hi netdev list, I am trying to retrieve all MAC supported link modes (ETHTOOL_LINK_MODE_*) for network interfaces with SFP port. The 'supported' bit mask that ETHTOOL_GLINKSETTINGS provides in link_mode_masks[] changes to match the SFP module that happens to be plugged in. When no SFP module is pl

Re: [PATCH v2] net: phy: marvell10g: support XFI rate matching mode

2020-07-01 Thread Baruch Siach
Hi Russell, On Mon, Jun 29 2020, Russell King - ARM Linux admin wrote: > On Sun, Jun 28, 2020 at 10:04:51AM +0300, Baruch Siach wrote: >> When the hardware MACTYPE hardware configuration pins are set to "XFI >> with Rate Matching" the PHY interface operate at fixed 10Gbps

[PATCH v2] net: phy: marvell10g: support XFI rate matching mode

2020-06-28 Thread Baruch Siach
face speed accordingly. Signed-off-by: Baruch Siach --- v2: Move rate matching state read to config_init (RMK) --- drivers/net/phy/marvell10g.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c index d4

[PATCH] net: phy: marvell10g: support XFI rate matching mode

2020-06-25 Thread Baruch Siach
face speed accordingly. Signed-off-by: Baruch Siach --- drivers/net/phy/marvell10g.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c index d4c2e62b2439..0f157c338c55 100644 --- a/drive

Re: [RFC PATCH] drivers: net: mdio_bus: try indirect clause 45 regs access

2020-05-17 Thread Baruch Siach
Hi Andrew, On Sun, May 17 2020, Andrew Lunn wrote: >> > I don't think this should be done at mdiobus level; I think this is a >> > layering violation. It needs to happen at the PHY level because the >> > indirect C45 access via C22 registers is specific to PHYs. >> > >> > It also needs to check i

Re: [RFC PATCH] drivers: net: mdio_bus: try indirect clause 45 regs access

2020-05-17 Thread Baruch Siach
Hi Russell, On Sun, May 17 2020, Russell King - ARM Linux admin wrote: > On Sun, May 17, 2020 at 01:20:56PM +0300, Baruch Siach wrote: >> When the MDIO bus does not support directly clause 45 access, fallback >> to indirect registers access method to read/write clause 45 registers

[RFC PATCH] drivers: net: mdio_bus: try indirect clause 45 regs access

2020-05-17 Thread Baruch Siach
When the MDIO bus does not support directly clause 45 access, fallback to indirect registers access method to read/write clause 45 registers using clause 22 registers. Signed-off-by: Baruch Siach --- Is that the right course? Currently, this does not really work on the my target machine, which

[PATCH v3] bpf: fix uapi bpf_prog_info fields alignment

2019-06-27 Thread Baruch Siach
nn Cc: Geert Uytterhoeven Cc: Linus Torvalds Signed-off-by: Baruch Siach --- v3: Use alignment pad as Alexei Starovoitov suggested v2: Use anonymous union with pad to make it less likely to break again in the future. --- include/uapi/linux/bpf.h | 1 + tools/include/uapi/linux/bpf.h | 1 +

[PATCH iproute2 v2 2/2] devlink: fix libc and kernel headers collision

2019-06-27 Thread Baruch Siach
/sysinfo.h. Cc: Aya Levin Cc: Moshe Shemesh Signed-off-by: Baruch Siach --- v2: Shorten comment --- devlink/devlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index b6e68f9a4d65..039225df7cbf 100644 --- a/devlink/devlink.c +++

[PATCH iproute2 v2 1/2] devlink: fix format string warning for 32bit targets

2019-06-27 Thread Baruch Siach
=] pr_out("%s %lu", name, val); ^ devlink.c:59:21: note: in definition of macro ‘pr_out’ fprintf(stdout, ##args); \ ^~~~ Use uint64_t specific conversion specifiers in the format string to fix that. Cc: Aya Levin Cc: Moshe Shemesh Signed-off-

[PATCH v2] net: dsa: mv88e6xxx: wait after reset deactivation

2019-06-27 Thread Baruch Siach
Add a 1ms delay after reset deactivation. Otherwise the chip returns bogus ID value. This is observed with 88E6390 (Peridot) chip. Signed-off-by: Baruch Siach --- v2: Address Andrew Lunn's comments: Use usleep_range. Delay only when reset line is valid. --- drivers/net/dsa/mv88e6xxx/c

[PATCH] net: dsa: mv88e6xxx: wait after reset deactivation

2019-06-26 Thread Baruch Siach
Add a 1ms delay after reset deactivation. Otherwise the chip returns bogus ID value. This is observed with 88E6390 (Peridot) chip. Signed-off-by: Baruch Siach --- drivers/net/dsa/mv88e6xxx/chip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net

Re: [PATCH iproute2 1/2] devlink: fix format string warning for 32bit targets

2019-06-25 Thread Baruch Siach
Hi Stephen, On Tue, Jun 25, 2019 at 11:58:06AM -0700, Stephen Hemminger wrote: > On Tue, 25 Jun 2019 14:49:04 +0300 > Baruch Siach wrote: > > > diff --git a/devlink/devlink.c b/devlink/devlink.c > > index 436935f88bda..b400fab17578 100644 > > --- a/devlink/devlink.c

[PATCH iproute2 2/2] devlink: fix libc and kernel headers collision

2019-06-25 Thread Baruch Siach
/sysinfo.h. Cc: Aya Levin Cc: Moshe Shemesh Signed-off-by: Baruch Siach --- devlink/devlink.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index b400fab17578..2ea60d3556da 100644 --- a/devlink/devlink.c +++ b/devlink/devlin

[PATCH iproute2 1/2] devlink: fix format string warning for 32bit targets

2019-06-25 Thread Baruch Siach
=] pr_out("%s %lu", name, val); ^ devlink.c:59:21: note: in definition of macro ‘pr_out’ fprintf(stdout, ##args); \ ^~~~ Use 'll' length modifier in the format string to fix that. Cc: Aya Levin Cc: Moshe Shemesh Signed-off-by: Baruch

[PATCH v2] bpf: fix uapi bpf_prog_info fields alignment

2019-06-25 Thread Baruch Siach
Jiri Olsa Cc: Daniel Borkmann Cc: Geert Uytterhoeven Cc: Linus Torvalds Signed-off-by: Baruch Siach --- v2: Use anonymous union with pad to make it less likely to break again in the future. --- include/uapi/linux/bpf.h | 5 - tools/include/uapi/linux/bpf.h | 5 - 2 files changed

Re: [PATCH] bpf: fix uapi bpf_prog_info fields alignment

2019-06-04 Thread Baruch Siach
Hi Alexei, (Adding Arnd and linux-arch to Cc) On Tue, Jun 04, 2019 at 08:30:29AM -0700, Alexei Starovoitov wrote: > On Tue, Jun 04, 2019 at 05:23:46PM +0200, Geert Uytterhoeven wrote: > > On Tue, Jun 4, 2019 at 5:17 PM Alexei Starovoitov > > wrote: > > > On Tue, Jun 4

Re: [PATCH] devlink: fix libc and kernel headers collision

2019-06-04 Thread Baruch Siach
Hi Stephen, On Tue, Jun 04 2019, Stephen Hemminger wrote: > On Thu, 30 May 2019 18:32:27 +0300 > Baruch Siach wrote: > >> Since commit 2f1242efe9d ("devlink: Add devlink health show command") we >> use the sys/sysinfo.h header for the sysinfo(2) system call. But si

Re: [PATCH] bpf: fix uapi bpf_prog_info fields alignment

2019-06-04 Thread Baruch Siach
Hi Geert, On Tue, Jun 04 2019, Geert Uytterhoeven wrote: > On Tue, Jun 4, 2019 at 1:40 PM Baruch Siach wrote: >> Merge commit 1c8c5a9d38f60 ("Merge >> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next") undid the >> fix from commit 36f9814a494 ("

[PATCH] bpf: fix uapi bpf_prog_info fields alignment

2019-06-04 Thread Baruch Siach
nn Cc: Geert Uytterhoeven Cc: Linus Torvalds Signed-off-by: Baruch Siach --- include/uapi/linux/bpf.h | 2 +- tools/include/uapi/linux/bpf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index 63e0cf66f01a..fe73829b

[PATCH] devlink: fix libc and kernel headers collision

2019-05-30 Thread Baruch Siach
. Cc: Aya Levin Cc: Moshe Shemesh Signed-off-by: Baruch Siach --- devlink/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index 436935f88bda..d7a6ce94f0e6 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -22,7 +22,7 @@

Re: [PATCH net,stable 1/1] net: fec: fix the clk mismatch in failed_reset path

2019-05-23 Thread Baruch Siach
to call runtime resume callback. > > Reported-by: Baruch Siach > Signed-off-by: Fugang Duan Tested-by: Baruch Siach Tested on SolidRun Hummingboard Pulse. Thanks. But please avoid sending patched in base64 encoded emails. Plaintext is much easier when dealing with 'git am'

i.MX8MQ clk: enet1_root_clk already disabled

2019-05-22 Thread Baruch Siach
Hi Abel, I'm testing kernel v5.2-rc1 on my i.MX8MQ system, SolidRun Hummingboard Pulse. The fec driver happens to probe before the gpio driver that we need for the PHY reset. So fec_reset_phy() returns -EPROBE_DEFER. This triggers the splat below when clk_ahb is disabled somewhere below the 'fai

[PATCH] net: fec: remove redundant ipg clock disable

2019-05-22 Thread Baruch Siach
Don't disable the ipg clock in the regulator error path. The clock is disable unconditionally two lines below the failed_regulator label. Signed-off-by: Baruch Siach --- drivers/net/ethernet/freescale/fec_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/free

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-12 Thread Baruch Siach
Hi Antoine, On Wed, Dec 12, 2018 at 03:14:51PM +0100, Antoine Tenart wrote: > On Wed, Dec 12, 2018 at 10:30:33AM +0100, Antoine Tenart wrote: > > On Tue, Dec 11, 2018 at 06:51:56PM +, Russell King - ARM Linux wrote: > > > On Tue, Dec 11, 2018 at 07:53:42PM +0200,

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-11 Thread Baruch Siach
support 10G modes in certain cases. This is not true, >> as only the port #0 can do so. This patch fixes it. >> >> Fixes: 01b3fd5ac97c ("net: mvpp2: fix detection of 10G SFP modules") >> Cc: Baruch Siach >> Signed-off-by: Antoine Tenart >> --- >>

[PATCH v2 1/2] net: mvpp2: fix detection of 10G SFP modules

2018-12-04 Thread Baruch Siach
correctly to be configured at max rate of 2.5G. Catch the uninitialized PHY mode case, and allow 10G rates. Fixes: d97c9f4ab000b ("net: mvpp2: 1000baseX support") Cc: Maxime Chevallier Cc: Antoine Tenart Acked-by: Russell King Signed-off-by: Baruch Siach --- v2: Add ack and

[PATCH v2 2/2] net: mvpp2: fix phylink handling of invalid PHY modes

2018-12-04 Thread Baruch Siach
The .validate phylink callback should empty the supported bitmap when the interface mode is invalid. Cc: Maxime Chevallier Cc: Antoine Tenart Reported-by: Russell King Signed-off-by: Baruch Siach --- v2: New patch in this series --- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 33

Re: [RFC PATCH] net: mvpp2: fix detection of 10G SFP modules

2018-12-04 Thread Baruch Siach
Hi Russell, On Tue, Dec 04, 2018 at 10:27:01AM +, Russell King - ARM Linux wrote: > On Tue, Dec 04, 2018 at 12:19:54PM +0200, Baruch Siach wrote: > > On Thu, Nov 29, 2018 at 10:00:43PM +, Russell King - ARM Linux wrote: > > > On Thu, Nov 29, 2018 at 11:31:23AM -0800

Re: [RFC PATCH] net: mvpp2: fix detection of 10G SFP modules

2018-12-04 Thread Baruch Siach
Hi Russell, On Thu, Nov 29, 2018 at 10:00:43PM +, Russell King - ARM Linux wrote: > On Thu, Nov 29, 2018 at 11:31:23AM -0800, Florian Fainelli wrote: > > On 11/29/2018 4:49 AM, Baruch Siach wrote: > > > The mvpp2_phylink_validate() relies on the interface field of > >

Re: [RFC PATCH] net: mvpp2: fix detection of 10G SFP modules

2018-11-29 Thread Baruch Siach
Hi Florian, Florian Fainelli writes: > On 11/29/2018 4:49 AM, Baruch Siach wrote: >> The mvpp2_phylink_validate() relies on the interface field of >> phylink_link_state to determine valid link modes. However, when called >> from phylink_sfp_module_insert() this field in

[RFC PATCH] net: mvpp2: fix detection of 10G SFP modules

2018-11-29 Thread Baruch Siach
correctly to be configured at max rate of 2.5G. Catch the uninitialized PHY mode case, and allow 10G rates. Cc: Maxime Chevallier Cc: Antoine Tenart Signed-off-by: Baruch Siach --- Is that the right fix? --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 1 + 1 file changed, 1 insertion

Re: [PATCH] net: phy: sfp: correct store of detected link modes

2018-11-29 Thread Baruch Siach
Hi Russell, Russell King - ARM Linux writes: > On Thu, Nov 29, 2018 at 12:40:11PM +0200, Baruch Siach wrote: >> The link modes that sfp_parse_support() detects are stored in the >> 'modes' bitmap. There is no reason to make an exception for 1000Base-PX >> or 1000Ba

[PATCH] net: phy: sfp: correct store of detected link modes

2018-11-29 Thread Baruch Siach
The link modes that sfp_parse_support() detects are stored in the 'modes' bitmap. There is no reason to make an exception for 1000Base-PX or 1000Base-BX10. Signed-off-by: Baruch Siach --- drivers/net/phy/sfp-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH] net: phy: sfp: correct location of SFP standards

2018-11-29 Thread Baruch Siach
SFP standards are now available from the SNIA (Storage Networking Industry Association) website. Cc: Andrew Lunn Cc: Florian Fainelli Signed-off-by: Baruch Siach --- include/linux/sfp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/sfp.h b/include/linux

[PATCH 1/2] arm64: dts: clearfog-gt-8k: fix USB regulator gpio polarity

2018-10-16 Thread Baruch Siach
The fixed regulator driver ignores the gpio flags, so this change has no practical effect in the current implementation. Fix it anyway to correct the hardware description. Signed-off-by: Baruch Siach --- arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 2 +- 1 file changed, 1

[PATCH 2/2] arm64: dts: clearfog-gt-8k: 1G eth PHY reset signal

2018-10-16 Thread Baruch Siach
relies on the bootloader to deassert the reset signal. Signed-off-by: Baruch Siach --- arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada

[PATCH v2] net: phy: phylink: fix SFP interface autodetection

2018-10-03 Thread Baruch Siach
ested-by: Russell King Signed-off-by: Baruch Siach --- v2: Leave the phylink_connect_phy() functionality unchanged. Only phylink_sfp_connect_phy() calls __phylink_connect_phy() with the detected interface (Russell King) --- drivers/net/phy/phylink.c | 48 +++--

[PATCH] net: phy: phylink: fix SFP interface autodetection

2018-09-22 Thread Baruch Siach
ot; phy-mode. Fixes: 9525ae83959b6 ("phylink: add phylink infrastructure") Suggested-by: Russell King Signed-off-by: Baruch Siach --- drivers/net/phy/phylink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c in

Re: [PATCH] net: phy: phylink: fix SFP interface autodetection

2018-09-17 Thread Baruch Siach
Hi Russell, Russell King - ARM Linux writes: > On Mon, Sep 17, 2018 at 05:19:57PM +0300, Baruch Siach wrote: >> When the switching to the SFP detected link mode update the main >> link_interface field as well. Otherwise, the link fails to come up when >> the configured '

[PATCH] net: phy: phylink: fix SFP interface autodetection

2018-09-17 Thread Baruch Siach
the DT to "2500base-x" phy-mode. Signed-off-by: Baruch Siach --- drivers/net/phy/phylink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 3ba5cf2a8a5f..3ece48c86841 100644 --- a/drivers/net/phy/phylink.c +++ b/drive

[PATCH v2] net: mvpp2: initialize port of_node pointer

2018-08-28 Thread Baruch Siach
label = "cpu"; ethernet = <&cp1_eth2>; }; }; }; }; Without this patch, dsa_register_switch() returns -EPROBE_DEFER because of_find_net_device_by_node() can't find the device_node of the &cp1_eth2 device. Rev

Re: [PATCH] net: mvpp2: initialize port of_node pointer

2018-08-27 Thread Baruch Siach
Hi Andrew, Thanks for reviewing. On Mon, Aug 27, 2018 at 03:47:23PM +0200, Andrew Lunn wrote: > On Mon, Aug 27, 2018 at 03:12:53PM +0300, Baruch Siach wrote: > > Without a valid of_node in struct device we can't find the mvpp2 port > > device by its DT node. Speci

[PATCH] net: mvpp2: initialize port of_node pointer

2018-08-27 Thread Baruch Siach
Without a valid of_node in struct device we can't find the mvpp2 port device by its DT node. Specifically, this breaks of_find_net_device_by_node(). Signed-off-by: Baruch Siach --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/driver

[PATCH iproute2 2/2] arpd: remove pthread dependency

2018-05-01 Thread Baruch Siach
link command. This change allows arpd build with toolchains that do not provide threads support. Signed-off-by: Baruch Siach --- misc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/Makefile b/misc/Makefile index 34ef6b21b4ed..b2dd6b26e2dc 100644 --- a/misc

[PATCH iproute2 1/2] README: update libdb build dependency information

2018-05-01 Thread Baruch Siach
Debian does not distribute libdb4.x-dev for quite some time now. Current stable carries libdb5.3-dev. Update the wording accordingly. Signed-off-by: Baruch Siach --- README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README b/README index f66fd5faf4cf..bc82187cf018

Re: [PATCH net-next 05/10] phy: cp110-comphy: 2.5G SGMII mode

2018-03-17 Thread Baruch Siach
Hi Antoine, On Fri, Mar 16, 2018 at 11:33:46AM +0100, Antoine Tenart wrote: > This patch allow the CP100 comphy to configure some lanes in the Should be 'CP110'. > 2.5G SGMII mode. This mode is quite close to SGMII and uses nearly the > same code path. > > Signed-off-by: Antoine Tenart baruch

[PATCH v3] lib: fix multiple strlcpy definition

2017-10-08 Thread Baruch Siach
`strlcpy': strlcpy.c:(.text+0x0): multiple definition of `strlcpy' ../lib/libutil.a(utils.o):utils.c:(.text+0x1ddc): first defined here collect2: error: ld returned 1 exit status Acked-by: Phil Sutter Signed-off-by: Baruch Siach --- v3: Set CFLAGS directly in config.mk v2: Fix the order

Re: [PATCH v2] lib: fix multiple strlcpy definition

2017-09-30 Thread Baruch Siach
Hi Stephen, On Fri, Sep 29, 2017 at 11:58:58AM -0700, Stephen Hemminger wrote: > On Thu, 28 Sep 2017 21:02:11 +0300 > Baruch Siach wrote: > > > Some C libraries, like uClibc and musl, provide BSD compatible > > strlcpy(). Add check_strlcpy() to configure, and avoid def

[PATCH v2] lib: fix multiple strlcpy definition

2017-09-28 Thread Baruch Siach
`strlcpy': strlcpy.c:(.text+0x0): multiple definition of `strlcpy' ../lib/libutil.a(utils.o):utils.c:(.text+0x1ddc): first defined here collect2: error: ld returned 1 exit status Acked-by: Phil Sutter Signed-off-by: Baruch Siach --- v2: Fix the order of strlcpy parameters --- configu

Re: [PATCH] lib: fix multiple strlcpy definition

2017-09-26 Thread Baruch Siach
Hi Phil, On Tue, Sep 26, 2017 at 05:55:24PM +0200, Phil Sutter wrote: > On Tue, Sep 26, 2017 at 02:08:49PM +0300, Baruch Siach wrote: > [...] > > diff --git a/configure b/configure > > index 7be8fb113cc9..787b2e061af9 100755 > > --- a/configure > > +++ b/configur

[PATCH] lib: fix multiple strlcpy definition

2017-09-26 Thread Baruch Siach
`strlcpy': strlcpy.c:(.text+0x0): multiple definition of `strlcpy' ../lib/libutil.a(utils.o):utils.c:(.text+0x1ddc): first defined here collect2: error: ld returned 1 exit status Cc: Phil Sutter Signed-off-by: Baruch Siach --- configure| 24 lib/Makefile | 4

[PATCH net v4 3/3] net: phy: sfp: rename dt properties to match the binding

2017-09-07 Thread Baruch Siach
Make the Rx rate select control gpio property name match the documented binding. This would make the addition of 'rate-select1-gpios' for SFP+ support more natural. Also, make the MOD-DEF0 gpio property name match the documentation. Signed-off-by: Baruch Siach --- v4: Rename also MO

[PATCH net v4 1/3] dt-bindings: add SFF vendor prefix

2017-09-07 Thread Baruch Siach
Acked-by: Rob Herring Signed-off-by: Baruch Siach --- v4: No change v3: Add Rob's ack v2: New patch in this series --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.t

[PATCH net v4 2/3] dt-binding: net: sfp binding documentation

2017-09-07 Thread Baruch Siach
Add device-tree binding documentation SFP transceivers. Support for SFP transceivers has been recently introduced (drivers/net/phy/sfp.c). Signed-off-by: Baruch Siach --- v4: Remove redundant 'single' from the gpio specifier Rename 'moddef0-gpios' property to 'mod-

[PATCH] dt-bindings: net: don't confuse with generic PHY property

2017-09-07 Thread Baruch Siach
This complements commit 9a94b3a4bd (dt-binding: phy: don't confuse with Ethernet phy properties). The generic PHY 'phys' property sometime appears in the same node with the Ethernet PHY 'phy' or 'phy-handle' properties. Add a warning in ethernet.txt to reduc

Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation

2017-09-04 Thread Baruch Siach
Hi Florian, On Mon, Sep 04, 2017 at 01:16:26PM -0700, Florian Fainelli wrote: > Le 09/03/17 à 05:31, Baruch Siach a écrit : [...] > > diff --git a/Documentation/devicetree/bindings/net/sff,sfp.txt > > b/Documentation/devicetree/bindings/net/sff,sfp.txt > > new file

Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation

2017-09-03 Thread Baruch Siach
Hi Russell, On Sun, Sep 03, 2017 at 09:46:35PM +0100, Russell King - ARM Linux wrote: > On Sun, Sep 03, 2017 at 03:31:13PM +0300, Baruch Siach wrote: > > Add device-tree binding documentation SFP transceivers. Support for SFP > > transceivers has been recently introduced (driver

[PATCH] dt-binding: phy: don't confuse with Ethernet phy properties

2017-09-03 Thread Baruch Siach
The generic PHY 'phys' property sometime appears in the same node with the Ethernet PHY 'phy' or 'phy-handle' properties. Add a warning in phy-bindings.txt to reduce confusion. Signed-off-by: Baruch Siach --- Documentation/devicetree/bindings/phy/phy-bindings.t

[PATCH v3 1/3] dt-bindings: add SFF vendor prefix

2017-09-03 Thread Baruch Siach
Acked-by: Rob Herring Signed-off-by: Baruch Siach --- v3: Add Rob's ack v2: New patch in this series --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devic

[PATCH v3 3/3] net: phy: sfp: rename the rate-select property

2017-09-03 Thread Baruch Siach
Make the Rx rate select control gpio property name match the documented binding. This would make the addition of 'rate-select1-gpios' for SFP+ support more natural. Signed-off-by: Baruch Siach --- v3: No change v2: New patch in this series --- drivers/net/phy/sfp.c | 2 +- 1 file

[PATCH v3 2/3] dt-binding: net: sfp binding documentation

2017-09-03 Thread Baruch Siach
Add device-tree binding documentation SFP transceivers. Support for SFP transceivers has been recently introduced (drivers/net/phy/sfp.c). Signed-off-by: Baruch Siach --- v3: Mention gpios phandle and specifier Mention the polarity of each gpio Fix example property names v2: Rename

Re: [PATCH v2 2/3] dt-binding: net: sfp binding documentation

2017-08-30 Thread Baruch Siach
Hi Sergei, On Wed, Aug 30, 2017 at 02:15:32PM +0300, Sergei Shtylyov wrote: > On 8/30/2017 2:11 PM, Baruch Siach wrote: > > > On Wed, Aug 30, 2017 at 02:04:11PM +0300, Sergei Shtylyov wrote: > > > On 8/30/2017 12:51 PM, Baruch Siach wrote: > > > > > > >

Re: [PATCH v2 2/3] dt-binding: net: sfp binding documentation

2017-08-30 Thread Baruch Siach
Hi Sergei, Thanks for reviewing. On Wed, Aug 30, 2017 at 02:04:11PM +0300, Sergei Shtylyov wrote: > On 8/30/2017 12:51 PM, Baruch Siach wrote: > > > Add device-tree binding documentation SFP transceivers. Support for SFP > > transceivers has been recently introduced (dri

[PATCH v2 3/3] net: phy: sfp: rename the rate-select property

2017-08-30 Thread Baruch Siach
Make the Rx rate select control gpio property name match the documented binding. This would make the addition of 'rate-select1-gpios' for SFP+ support more natural. Signed-off-by: Baruch Siach --- v2: New patch in this series --- drivers/net/phy/sfp.c | 2 +- 1 file changed, 1 inser

[PATCH v2 1/3] dt-bindings: add SFF vendor prefix

2017-08-30 Thread Baruch Siach
Signed-off-by: Baruch Siach --- v2: New patch in this series --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index

[PATCH v2 2/3] dt-binding: net: sfp binding documentation

2017-08-30 Thread Baruch Siach
Add device-tree binding documentation SFP transceivers. Support for SFP transceivers has been recently introduced (drivers/net/phy/sfp.c). Signed-off-by: Baruch Siach --- v2: Rename -gpio properties to -gpios Rename the rate-select-gpio property to rate-select0-gpios Add the rate-select1

Re: [PATCH] dt-binding: net/phy: fix interrupts description

2017-08-28 Thread Baruch Siach
Hi Dave, On Wed, Aug 23, 2017 at 09:11:00AM +0300, Baruch Siach wrote: > Commit b053dc5a722ea (powerpc: Refactor device tree binding) split the > Ethernet PHY binding documentation out of the big booting-without-of.txt > file, leaving a dangling reference to "section 2"

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-23 Thread Baruch Siach
Hi Rob, On Mon, Aug 21, 2017 at 02:10:33PM -0500, Rob Herring wrote: > On Sun, Aug 20, 2017 at 5:28 AM, Baruch Siach wrote: > > Add device-tree binding documentation SFP transceivers. Support for SFP > > transceivers has been recently introduced (drivers/net/phy/sfp.c). > &

Re: [PATCH net-next v2 10/10] arm64: dts: marvell: mcbin: enable more networking ports

2017-08-23 Thread Baruch Siach
Hi Antoine, On Tue, Aug 22, 2017 at 07:08:30PM +0200, Antoine Tenart wrote: > This patch enables the two GE/SFP ports. They are configured in 10GKR > mode by default. To do this the cpm_xdmio is enabled as well, and two > phy descriptions are added. > > Signed-off-by: Antoine Tenart > Tested-by:

[PATCH] dt-binding: net/phy: fix interrupts description

2017-08-22 Thread Baruch Siach
ption look more like the rest. While at it, make the example interrupt-parent phandle look more like a real world phandle, and use an IRQ_TYPE_ macro for the 'interrupts' type. Signed-off-by: Baruch Siach --- Documentation/devicetree/bindings/net/phy.txt | 10 +++--- 1 file changed

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-21 Thread Baruch Siach
Hi Rob, On Mon, Aug 21, 2017 at 02:10:33PM -0500, Rob Herring wrote: > On Sun, Aug 20, 2017 at 5:28 AM, Baruch Siach wrote: > > Add device-tree binding documentation SFP transceivers. Support for SFP > > transceivers has been recently introduced (drivers/net/phy/sfp.c). > &

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-21 Thread Baruch Siach
Hi Russell, On Mon, Aug 21, 2017 at 01:53:17PM +0100, Russell King - ARM Linux wrote: > On Sun, Aug 20, 2017 at 01:28:06PM +0300, Baruch Siach wrote: > > Add device-tree binding documentation SFP transceivers. Support for SFP > > transceivers has been recently introduced (driver

[RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-20 Thread Baruch Siach
Add device-tree binding documentation SFP transceivers. Support for SFP transceivers has been recently introduced (drivers/net/phy/sfp.c). Signed-off-by: Baruch Siach --- The SFP driver is on net-next. Not sure about the rate-select-gpio property name. The SFP+ standard (not supported yet

Re: [PATCH 1/2] ip: include libc headers first

2017-05-31 Thread Baruch Siach
Hi Stephen, On Tue, May 30, 2017 at 05:31:51PM -0700, Stephen Hemminger wrote: > On Mon, 22 May 2017 16:27:53 +0300 > Baruch Siach wrote: > > > Including libc headers first helps as a workaround to redefinition of struct > > ethhdr with a suitably patched musl libc that

Re: [PATCH 2/2] Add missing include

2017-05-22 Thread Baruch Siach
Hi Stephen, On Mon, May 22, 2017 at 10:24:42AM -0700, Stephen Hemminger wrote: > On Mon, 22 May 2017 16:27:54 +0300 > Baruch Siach wrote: > > > From: Thomas Petazzoni > > > > The u_intXX_t types are defined in , so it should be > > included before using those

[PATCH 2/2] Add missing include

2017-05-22 Thread Baruch Siach
: unknown type name ‘u_int32_t’ #define __le32 u_int32_t Signed-off-by: Thomas Petazzoni Signed-off-by: Baruch Siach --- include/iptables_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/iptables_common.h b/include/iptables_common.h index 9099667ffa6d..2c27a4b61fcd 100644

[PATCH 1/2] ip: include libc headers first

2017-05-22 Thread Baruch Siach
Including libc headers first helps as a workaround to redefinition of struct ethhdr with a suitably patched musl libc that suppresses the kernel if_ether.h. Signed-off-by: Baruch Siach --- ip/iplink_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iplink_bridge.c

Re: [PATCH 0/4] TI Bluetooth serdev support

2017-05-08 Thread Baruch Siach
Hi Rob, On Mon, May 08, 2017 at 04:12:16PM -0500, Rob Herring wrote: > On Fri, May 5, 2017 at 9:51 AM, Adam Ford wrote: > > On Sun, Apr 30, 2017 at 11:04 AM, Sebastian Reichel wrote: > >> On Sun, Apr 30, 2017 at 10:14:20AM -0500, Adam Ford wrote: > >>> On Wed, Apr 5, 2017 at 1:30 PM, Rob Herring

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

2017-03-01 Thread Baruch Siach
Hi Stefan, On Tue, Feb 28, 2017 at 07:32:09PM +0100, Stefan Wahren wrote: > > Baruch Siach hat am 28. Februar 2017 um 19:07 > > geschrieben: > > On Tue, Feb 28, 2017 at 05:21:18PM +0100, Stefan Wahren wrote: > > > Am 28.02.2017 um 13:01 schrieb Baruch Siach: > &g

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

2017-02-28 Thread Baruch Siach
Hi Stefan, On Tue, Feb 28, 2017 at 05:21:18PM +0100, Stefan Wahren wrote: > Am 28.02.2017 um 13:01 schrieb Baruch Siach: > > On Tue, Feb 28, 2017 at 10:28:10AM +0200, Baruch Siach wrote: > > > I'm hitting this warning consistently on my Raspberry Pi 3 running > > >

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

2017-02-28 Thread Baruch Siach
Hi linux-usb list, (Dropped Jan's bouncing address, added Rpi3 platform lists) On Tue, Feb 28, 2017 at 10:28:10AM +0200, Baruch Siach wrote: > Hi linux-usb list, > > I'm hitting this warning consistently on my Raspberry Pi 3 running kernel > v4.10.1 with some unrelated de

[PATCH] MAINTAINERS: Orphan usb/net/hso driver

2017-02-28 Thread Baruch Siach
The email address of Jan Dumon bounces, and there is not relevant information in the linked website. Signed-off-by: Baruch Siach --- MAINTAINERS | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 056f157122c9..e65f709cb795 100644 --- a

usb/net/hso: WARNING: ungligned urb->setup_dma

2017-02-28 Thread Baruch Siach
Hi Jan, linux-usb list, I'm hitting this warning consistently on my Raspberry Pi 3 running kernel v4.10.1 with some unrelated device tree changes, and a debug print (below). The device identifies as "GlobeTrotter HSDPA Modem", VID: 0af0, PID: 6971. The warning triggers consistently on first writ

[PATCH] tc: add missing limits.h header

2016-12-22 Thread Baruch Siach
for each function it appears in f_matchall.c:48:29: error: ‘LONG_MAX’ undeclared (first use in this function) if (h == LONG_MIN || h == LONG_MAX) { ^ Signed-off-by: Baruch Siach --- tc/tc_util.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tc/tc_util.h b/tc

  1   2   >