[PATCH] vxlan: avoid double unlikely() notation when using IS_ERR()

2020-12-10 Thread Antonio Quartulli
The definition of IS_ERR() already applies the unlikely() notation when checking the error status of the passed pointer. For this reason there is no need to have the same notation outside of IS_ERR() itself. Clean up code by removing redundant notation. Signed-off-by: Antonio Quartulli

[PATCH] wireguard: avoid double unlikely() notation when using IS_ERR()

2020-12-10 Thread Antonio Quartulli
The definition of IS_ERR() already applies the unlikely() notation when checking the error status of the passed pointer. For this reason there is no need to have the same notation outside of IS_ERR() itself. Clean up code by removing redundant notation. Signed-off-by: Antonio Quartulli

[PATCH] can: avoid double unlikely() notation when using IS_ERR()

2020-12-10 Thread Antonio Quartulli
The definition of IS_ERR() already applies the unlikely() notation when checking the error status of the passed pointer. For this reason there is no need to have the same notation outside of IS_ERR() itself. Clean up code by removing redundant notation. Signed-off-by: Antonio Quartulli

Re: [PATCH cryptodev] crypto: lib/chacha20poly1305 - allow users to specify 96bit nonce

2020-11-17 Thread Antonio Quartulli
Hi, On 17/11/2020 10:52, Ard Biesheuvel wrote: > On Tue, 17 Nov 2020 at 10:47, Antonio Quartulli wrote: >> >> Hi, >> >> >> On 17/11/2020 09:31, Ard Biesheuvel wrote: >>> If you are going back to the drawing board with in-kernel acceleration >>>

Re: [PATCH cryptodev] crypto: lib/chacha20poly1305 - allow users to specify 96bit nonce

2020-11-17 Thread Antonio Quartulli
a library interface for Aegis128 if that is preferable. Thanks for the pointer! I guess we will consider supporting Aegis128 once it gets standardized (AFAIK it is not yet). Best Regards, -- Antonio Quartulli

Re: [PATCH cryptodev] crypto: lib/chacha20poly1305 - allow users to specify 96bit nonce

2020-11-17 Thread Antonio Quartulli
more than 4GB in one go, as there are no users doing that right now. -- Antonio Quartulli

[PATCH cryptodev] crypto: lib/chacha20poly1305 - allow users to specify 96bit nonce

2020-11-16 Thread Antonio Quartulli
From: Antonio Quartulli The current interface limits the nonce 64bit, however, new users may want to specify a 96bit nonce, as dictated by the AEAD_CHACHA20_POLY1305 construction in RFC7539 Section 2.8. This patch changes the interface from accepting the nonce as single u64 variable to an array

Re: [PATCH] net/sch_generic.h: use sizeof_member() and get rid of unused variable

2020-05-20 Thread Antonio Quartulli
On 20/05/2020 20:17, David Miller wrote: > From: Antonio Quartulli > Date: Wed, 20 May 2020 10:39:33 +0200 > >> I don't think it's BUILD_BUG_ON()'s fault, because qcb->data is passed >> to sizeof() first. >> >> My best guess is that gcc is so

Re: [PATCH] net/sch_generic.h: use sizeof_member() and get rid of unused variable

2020-05-20 Thread Antonio Quartulli
Hi David, On 20/05/2020 00:40, David Miller wrote: > From: Antonio Quartulli > Date: Tue, 19 May 2020 11:13:33 +0200 > >> Compiling with -Wunused triggers the following warning: >> >> ./include/net/sch_generic.h: In function ‘qdisc_cb_private_validate’: >> .

[PATCH] net/sch_generic.h: use sizeof_member() and get rid of unused variable

2020-05-19 Thread Antonio Quartulli
skb argument at all. Cc: Toke Høiland-Jørgensen Cc: Jamal Hadi Salim Cc: Cong Wang Cc: Jiri Pirko Cc: Stephen Hemminger Signed-off-by: Antonio Quartulli --- Affected code has been compile-tested on x86_64 include/net/codel_qdisc.h | 2 +- include/net/pie.h | 2 +- include/

Re: [iproute2 2/2] ss: fix NULL pointer access when parsing unix sockets with oldformat

2018-01-06 Thread Antonio Quartulli
Hi, On 07/01/18 03:28, Stefano Brivio wrote: > On Sun, 7 Jan 2018 02:31:50 +0800 > Antonio Quartulli wrote: > >> When parsing and printing the unix sockets in unix_show(), >> if the oldformat is detected, the peer_name member of the sockstat >> object is left uniniti

[iproute2 2/2] ss: fix NULL pointer access when parsing unix sockets with oldformat

2018-01-06 Thread Antonio Quartulli
checking that peer_name is not NULL before passing it to strcmp(). Cc: Stefano Brivio Cc: Stephen Hemminger Signed-off-by: Antonio Quartulli --- To crash ss, simply execute the following on a system using the old socket format: ss -x dst 192.168.1.1 or ss dst 192.168.1.1 (crash reproduced on

[iproute2 1/2] ss: fix crash when skipping disabled header field

2018-01-06 Thread Antonio Quartulli
to note that this bug appears only when the code is compiled with -O0, because the compiler is smart enough to immediately jump to the return statement if optimizations are enabled and skip the faulty instruction. Cc: Stefano Brivio Cc: Stephen Hemminger Signed-off-by: Antonio Quartulli ---

[PATCH v4] skbedit: allow the user to specify bitmask for mark

2016-10-24 Thread Antonio Quartulli
ted by the latter are altered really changed by the actor, while the rest is left untouched. Signed-off-by: Antonio Quartulli Signed-off-by: Jamal Hadi Salim --- This patch has been sleeping for a while although it was basically ready for being merged. I hope it can still be merged. Checkpa

[PATCH 6/8] batman-adv: Fix integer overflow in batadv_iv_ogm_calc_tq

2016-05-17 Thread Antonio Quartulli
enalty and inv_asym_penalty can just be changed to unsigned int because they are not expected to become negative. Fixes: c039876892e3 ("batman-adv: add WiFi penalty") Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_i

[PATCH 1/8] batman-adv: fix skb deref after free

2016-05-17 Thread Antonio Quartulli
ner Signed-off-by: Antonio Quartulli --- net/batman-adv/routing.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c index ae850f2d11cb..e3857ed4057f 100644 --- a/net/batman-adv/routing.c +++ b/net/batman-adv/routing.

[PATCH 8/8] batman-adv: initialize ELP orig address on secondary interfaces

2016-05-17 Thread Antonio Quartulli
From: Marek Lindner This fix prevents nodes to wrongly create a 00:00:00:00:00:00 originator which can potentially interfere with the rest of the neighbor statistics. Fixes: d6f94d91f766 ("batman-adv: ELP - adding basic infrastructure") Signed-off-by: Marek Lindner Signed-off-b

[PATCH 5/8] batman-adv: make sure ELP/OGM orig MAC is updated on address change

2016-05-17 Thread Antonio Quartulli
When the MAC address of the primary interface is changed, update the originator address in the ELP and OGM skb buffers as well in order to reflect the change. Fixes: d6f94d91f766 ("batman-adv: ELP - adding basic infrastructure") Reported-by: Marek Lindner Signed-off-by: Antonio

[PATCH 4/8] batman-adv: Fix unexpected free of bcast_own on add_if error

2016-05-17 Thread Antonio Quartulli
only increased and therefore no user of the buffer will try to access bytes outside of the new buffer. Fixes: d0015fdd3d2c ("batman-adv: provide orig_node routing API") Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_iv_og

[PATCH 3/8] batman-adv: Fix refcnt leak in batadv_v_neigh_*

2016-05-17 Thread Antonio Quartulli
ghbor comparison API calls") Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_v.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat

[PATCH 2/8] batman-adv: Avoid nullptr derefence in batadv_v_neigh_is_sob

2016-05-17 Thread Antonio Quartulli
ann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_v.c | 4 1 file changed, 4 insertions(+) diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c index 3ff8bd1b7bdc..50bfcf87f569 100644 --- a/net/batman-adv/bat_v.c +++ b/net/batman-adv/bat_

[PATCH 7/8] batman-adv: Avoid duplicate neigh_node additions

2016-05-17 Thread Antonio Quartulli
locks") Reported-by: Martin Weinelt Signed-off-by: Linus Lüssing Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/originator.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/originator.c b/net/batman-adv/originat

pull request: batman-adv 20160518

2016-05-17 Thread Antonio Quartulli
ce is added, by Sven Eckelmann - ensure originator address is updated in OMG/ELP packet content upon primary interface address change, by Antonio Quartulli - fix integer overflow when computing TQ metric (B.A.T.M.A.N. IV), by Sven Eckelmann - avoid race condition while adding new neigh_node which wo

[PATCH 4/4] batman-adv: Fix refcnt leak in batadv_v_neigh_*

2016-05-15 Thread Antonio Quartulli
ghbor comparison API calls") Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_v.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat

[PATCH 3/4] batman-adv: Fix double neigh_node_put in batadv_v_ogm_route_update

2016-05-15 Thread Antonio Quartulli
early at 0. Fixes: 9323158ef9f4 ("batman-adv: OGMv2 - implement originators logic") Signed-off-by: Sven Eckelmann Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_v_ogm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/batman-adv/bat_v_ogm.c b/net/

[PATCH 2/4] batman-adv: Avoid nullptr derefence in batadv_v_neigh_is_sob

2016-05-15 Thread Antonio Quartulli
ann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_v.c | 4 1 file changed, 4 insertions(+) diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c index 4026f198a734..e81ad4b8e5c8 100644 --- a/net/batman-adv/bat_v.c +++ b/net/batman-adv/bat_

pull request [net]: batman-adv 20160515

2016-05-15 Thread Antonio Quartulli
Hello David, although we are extremely late in the release cycle we have 4 fixes which would really be worth merging before releasing linux-4.6. As you can read in the git tag below, each of them can lead to a kernel crash or to an unstable system. We came up with several fixes after having test

[PATCH 1/4] batman-adv: fix skb deref after free

2016-05-15 Thread Antonio Quartulli
ner Signed-off-by: Antonio Quartulli --- net/batman-adv/routing.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c index b781bf753250..0c0c30e101a1 100644 --- a/net/batman-adv/routing.c +++ b/net/batman-adv/routing.

[PATCH 14/17] batman-adv: Use kref_get for _batadv_update_route

2016-05-10 Thread Antonio Quartulli
reference counter would still be 0. This makes a bug in batman-adv better visible because kref_get_unless_zero would have ignored this problem. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/routing.c | 8 1 file changed, 4

[PATCH 15/17] batman-adv: Use bool as return type for boolean functions

2016-05-10 Thread Antonio Quartulli
n the error code. Reported-by: Nicholas Krause Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_iv_ogm.c| 23 ++--- net/batman-adv/bitarray.c | 16 +-- net/batman-adv/bitarray.h | 15 +--

[PATCH 10/17] batman-adv: Use kref_get for batadv_nc_get_nc_node

2016-05-10 Thread Antonio Quartulli
reference counter would still be 0. This makes a bug in batman-adv better visible because kref_get_unless_zero would have ignored this problem. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/network-coding.c | 7 +-- 1 file

[PATCH 13/17] batman-adv: Use kref_get for hard_iface subfunctions

2016-05-10 Thread Antonio Quartulli
Ns (with debug information) when the reference counter would still be 0. This makes a bug in batman-adv better visible because kref_get_unless_zero would have ignored this problem. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_

[PATCH 17/17] batman-adv: use batadv_compare_eth when possible

2016-05-10 Thread Antonio Quartulli
When comparing Ethernet address it is better to use the more generic batadv_compare_eth. The latter is also optimised for architectures having a fast unaligned access. Signed-off-by: Antonio Quartulli [s...@narfation.org: fix conflicts with current version] Signed-off-by: Sven Eckelmann Signed

[PATCH 16/17] batman-adv: replace ethertype variable with ETH_P_BATMAN for readability

2016-05-10 Thread Antonio Quartulli
From: Marek Lindner Signed-off-by: Marek Lindner Reviewed-by: Sven Eckelmann Signed-off-by: Antonio Quartulli --- net/batman-adv/soft-interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c

[PATCH 12/17] batman-adv: Use kref_get for batadv_gw_node_add

2016-05-10 Thread Antonio Quartulli
counter would still be 0. This makes a bug in batman-adv better visible because kref_get_unless_zero would have ignored this problem. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/gateway_client.c | 8 ++-- 1 file changed, 2

[PATCH 11/17] batman-adv: Use kref_get for batadv_gw_select

2016-05-10 Thread Antonio Quartulli
counter would still be 0. This makes a bug in batman-adv better visible because kref_get_unless_zero would have ignored this problem. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/gateway_client.c | 4 ++-- 1 file changed, 2

[PATCH 05/17] batman-adv: add detection for complex bridge loops

2016-05-10 Thread Antonio Quartulli
let others handle that problem. Signed-off-by: Simon Wunderlich [s...@narfation.org: fix conflicts with current version] Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bridge_loop_avoidance.c | 139 +

[PATCH 06/17] batman-adv: Check hard_iface refcnt before calling function

2016-05-10 Thread Antonio Quartulli
tly before calling a subfunction with a pointer from the batadv_hardif_list avoids this problem. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_iv_ogm.c | 11 +++ net/batman-adv/bat_v_ogm.c | 14 +- net/bat

[PATCH 07/17] batman-adv: Check hard_iface refcnt when receiving skb

2016-05-10 Thread Antonio Quartulli
> 0. This is rather error-prone because this check can be forgotten easily. Instead check the reference counter when receiving the object to make sure that all called functions have a valid reference. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartu

[PATCH 04/17] batman-adv: Create batman soft interfaces within correct netns.

2016-05-10 Thread Antonio Quartulli
From: Andrew Lunn When creating a soft interface, create it in the same netns as the hard interface. Replace all references to init_net with the correct name space for the interface being manipulated. Suggested-by: Daniel Ehlers Signed-off-by: Andrew Lunn Acked-by: Antonio Quartulli Signed

[PATCH 09/17] batman-adv: Use kref_get for batadv_tvlv_container_get

2016-05-10 Thread Antonio Quartulli
the reference counter would still be 0. This makes a bug in batman-adv better visible because kref_get_unless_zero would have ignored this problem. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/main.c | 4 +--- 1 file changed, 1

[PATCH 02/17] batman-adv: Remove hdr_size skb size check in batadv_interface_rx

2016-05-10 Thread Antonio Quartulli
batadv_check_unicast_packet (batadv_recv_unicast_packet). Reported-by: Marek Lindner Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/soft-interface.c | 4 1 file changed, 4 deletions(-) diff --git a/net/batman-adv/soft-interface.c b

[PATCH 08/17] batman-adv: Increase hard_iface refcnt for ptype

2016-05-10 Thread Antonio Quartulli
-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/hard-interface.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c index f0e1899e5b6b..d3d37f3f99cf 100644 --- a/net/batman

[PATCH 03/17] batman-adv: NETIF_F_NETNS_LOCAL feature to prevent netns moves

2016-05-10 Thread Antonio Quartulli
From: Andrew Lunn The batX soft interface should not be moved between network name spaces. This is similar to bridges, bonds, tunnels, which are not allowed to move between network namespaces. Suggested-by: Daniel Ehlers Signed-off-by: Andrew Lunn Acked-by: Antonio Quartulli Reviewed-by

[PATCH 01/17] batman-adv: Remove unused parameter recv_if of batadv_interface_rx

2016-05-10 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/routing.c| 5 ++--- net/batman-adv/soft-interface.c | 5 ++--- net/batman-adv/soft-interface.h | 4 ++-- 3 files changed, 6 insertions(+), 8 deletions

pull request: batman-adv 20160511

2016-05-10 Thread Antonio Quartulli
n possible instead of plain memcmp() - minor code cleanup and style adjustments Andrew Lunn (2): batman-adv: NETIF_F_NETNS_LOCAL feature to prevent netns moves batman-adv: Create batman soft interfaces within correct netns

Re: pull request [net]: batman-adv 20160430

2016-05-04 Thread Antonio Quartulli
On Wed, May 04, 2016 at 02:13:50PM -0400, David Miller wrote: > > Just FYI I did this last night. Thanks a lot for letting me know David. Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-04 Thread Antonio Quartulli
gt; > - soft_iface->trans_start = jiffies; > + netif_trans_update(soft_iface); > vid = batadv_get_vid(skb, 0); > ethhdr = eth_hdr(skb); > Acked-by: Antonio Quartulli -- Antonio Quartulli signature.asc Description: Digital signature

[PATCH 14/15] batman-adv: Merge batadv_v_ogm_orig_update into batadv_v_ogm_route_update

2016-05-03 Thread Antonio Quartulli
: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_v_ogm.c | 117 ++--- 1 file changed, 46 insertions(+), 71 deletions(-) diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c index 07c999734fba..4155fa57cf6d 100644 --- a/net

[PATCH 12/15] batman-adv: fix debuginfo macro style issue

2016-05-03 Thread Antonio Quartulli
From: Simon Wunderlich Structure initialization within the macros should follow the general coding style used in the kernel: put the initialization of the first variable and the closing brace on a separate line. Reported-by: Antonio Quartulli Signed-off-by: Simon Wunderlich [s

[PATCH 11/15] batman-adv: Fix function names on new line starting with '*'

2016-05-03 Thread Antonio Quartulli
Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bridge_loop_avoidance.c | 6 +++--- net/batman-adv/main.c | 8 net/batman-adv/network-coding.c| 18 +- 3 files changed, 16 insertions(+), 16 deletions

[PATCH 10/15] batman-adv: Add kernel-doc for batadv_interface_rx

2016-05-03 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/soft-interface.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index

[PATCH 13/15] batman-adv: move and restructure batadv_v_ogm_forward

2016-05-03 Thread Antonio Quartulli
Wunderlich Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_v_ogm.c | 110 ++--- 1 file changed, 63 insertions(+), 47 deletions(-) diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c index d9bcbe6e7d65

[PATCH 15/15] batman-adv: Split batadv_iv_ogm_orig_del_if function

2016-05-03 Thread Antonio Quartulli
. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_iv_ogm.c | 131 1 file changed, 84 insertions(+), 47 deletions(-) diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv

[PATCH 08/15] batman-adv: Fix checkpatch warning about 'unsigned' type

2016-05-03 Thread Antonio Quartulli
From: Sven Eckelmann checkpatch.pl warns about the use of 'unsigned' as a short form for 'unsigned int'. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/fragmentation.c | 12 ++-- 1 file changed

[PATCH 05/15] batman-adv: use list_for_each_entry_safe

2016-05-03 Thread Antonio Quartulli
From: Geliang Tang Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: Geliang Tang Acked-by: Antonio Quartulli Reviewed-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/icmp_socket.c | 22

[PATCH 07/15] batman-adv: fix wrong names in kerneldoc

2016-05-03 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli [s...@narfation.org: Fix additional names] Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner --- net/batman-adv/bridge_loop_avoidance.c | 2 +- net/batman-adv/distributed-arp-table.c | 2 +- net/batman-adv/icmp_socket.c | 2 +- net/batman

[PATCH 09/15] batman-adv: Fix kerneldoc for batadv_compare_claim

2016-05-03 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bridge_loop_avoidance.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv

[PATCH 06/15] batman-adv: use to_delayed_work

2016-05-03 Thread Antonio Quartulli
From: Geliang Tang Use to_delayed_work() instead of open-coding it. Signed-off-by: Geliang Tang Reviewed-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bridge_loop_avoidance.c | 2 +- net/batman-adv/distributed-arp-table.c | 2 +- net

[PATCH 01/15] MAINTAINERS: Mark BATMAN ADVANCED mailing list as moderated

2016-05-03 Thread Antonio Quartulli
From: Sven Eckelmann The mailing list of b.a.t.m@lists.open-mesh.org is moderated for non-subscribers and non-whitelisted addresses. Such mails will be delayed but the sender will not be informed about the moderation. Signed-off-by: Sven Eckelmann Signed-off-by: Antonio Quartulli

[PATCH 03/15] batman-adv: Start new development cycle

2016-05-03 Thread Antonio Quartulli
From: Simon Wunderlich Signed-off-by: Simon Wunderlich Signed-off-by: Antonio Quartulli --- net/batman-adv/main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index db4533631834..38e5587675cc 100644 --- a/net/batman-adv

pull request: batman-adv 20160504

2016-05-03 Thread Antonio Quartulli
anups Antonio Quartulli (2): batman-adv: use static string for table headers batman-adv: fix wrong names in kerneldoc Geliang Tang (2): batman-adv: use list_for_each_entry_safe batman-adv: use to_delayed_work Simon Wunderlich (4): batman-adv:

[PATCH 04/15] batman-adv: use static string for table headers

2016-05-03 Thread Antonio Quartulli
Use a static string when showing table headers rather then a nonsense parametric one with fixed arguments. It is easier to grep and it does not need to be recomputed at runtime each time. Reported-by: Joe Perches Signed-off-by: Antonio Quartulli [s...@narfation.org: fix conflicts with current

[PATCH 02/15] MAINTAINERS: Add BATMAN ADVANCED documentation files

2016-05-03 Thread Antonio Quartulli
From: Sven Eckelmann The sysfs ABI documentation files and the batman-adv.txt are maintained by the BATMAN ADVANCED maintainers and patches for them should therefore be sent to them. Signed-off-by: Sven Eckelmann Signed-off-by: Antonio Quartulli --- MAINTAINERS | 3 +++ 1 file changed, 3

Re: pull request [net]: batman-adv 20160430

2016-05-03 Thread Antonio Quartulli
ing because I'd prefer to avoid you the hassle of dealing with the conflicts. Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

[PATCH 1/4] batman-adv: fix DAT candidate selection (must use vid)

2016-04-30 Thread Antonio Quartulli
Now that DAT is VLAN aware, it must use the VID when computing the DHT address of the candidate nodes where an entry is going to be stored/retrieved. Fixes: be1db4f6615b ("batman-adv: make the Distributed ARP Table vlan aware") Signed-off-by: Antonio Quartulli [s...@narfation.org: fix

[PATCH 4/4] batman-adv: Fix reference counting of hardif_neigh_node object for neigh_node

2016-04-30 Thread Antonio Quartulli
of batadv_neigh_node. Fixes: cef63419f7db ("batman-adv: add list of unique single hop neighbors per hard-interface") Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/originator.c | 16 +--- net/batman-adv/type

[PATCH 2/4] batman-adv: B.A.T.M.A.N V - make sure iface is reactivated upon NETDEV_UP event

2016-04-30 Thread Antonio Quartulli
. Such API is optional and is implemented by B.A.T.M.A.N. V only and it just takes care of setting the iface status to ACTIVE Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner --- net/batman-adv/bat_v.c | 12 net/batman-adv/hard-interface.c | 3 +++ net/batman

pull request [net]: batman-adv 20160430

2016-04-30 Thread Antonio Quartulli
In this small batch of patches you have: - a fix for our Distributed ARP Table that makes sure that the input provided to the hash function during a query is the same as the one provided during an insert (so to prevent false negatives), by Antonio Quartulli - a fix for o

[PATCH 3/4] batman-adv: Fix reference counting of vlan object for tt_local_entry

2016-04-30 Thread Antonio Quartulli
the reference counter decremented on release of batadv_tt_local_entry. Fixes: 35df3b298fc8 ("batman-adv: fix TT VLAN inconsistency on VLAN re-add") Signed-off-by: Sven Eckelmann Acked-by: Antonio Quartulli Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/transl

Re: pull request [net]: batman-adv-0160426

2016-04-28 Thread Antonio Quartulli
provide a > Fixes: tag that indicates the commit that merged batman-adv into the > upstream tree initially. makes sense. Thanks for the suggestion! -- Antonio Quartulli signature.asc Description: Digital signature

[PATCH 5/5] batman-adv: Fix broadcast/ogm queue limit on a removed interface

2016-04-25 Thread Antonio Quartulli
ef in forw_packet_free") Signed-off-by: Linus Lüssing [s...@narfation.org: fix conflicts with current version] Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/send.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/

[PATCH 4/5] batman-adv: Reduce refcnt of removed router when updating route

2016-04-25 Thread Antonio Quartulli
enough to get the correct old router object. Fixes: e1a5382f978b ("batman-adv: Make orig_node->router an rcu protected pointer") Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/routing.c | 9 + 1 file changed,

[PATCH 2/5] batman-adv: init neigh node last seen field

2016-04-25 Thread Antonio Quartulli
From: Marek Lindner Signed-off-by: Marek Lindner [s...@narfation.org: fix conflicts with current version] Signed-off-by: Sven Eckelmann Signed-off-by: Antonio Quartulli --- net/batman-adv/originator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/originator.c b/net

[PATCH 3/5] batman-adv: Deactivate TO_BE_ACTIVATED hardif on shutdown

2016-04-25 Thread Antonio Quartulli
batadv $ ip link set dummy0 master bat0 $ ip link set dummy0 up $ ip link del bat0 unregister_netdevice: waiting for bat0 to become free. Usage count = 3 Reported-by: Matthias Schiffer Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli

[PATCH 1/5] batman-adv: Check skb size before using encapsulated ETH+VLAN header

2016-04-25 Thread Antonio Quartulli
dance") Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/soft-interface.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index 07

pull request [net]: batman-adv-0160426

2016-04-25 Thread Antonio Quartulli
Hi David, this is a batch intended for net. Changes are quite small, therefore I hope it is not a big deal to include them at this point of the release cycle. In this patchset you can find the following fixes: 1) check skb size to avoid reading beyond its border when delivering payloads, by S

Re: [PATCH] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection

2016-03-14 Thread Antonio Quartulli
these variables at the beginning then. > > > > Signed-off-by: Markus Elfring > > I am assuming Antonio will take this in via his tree. > Yeah, it will go through our tree. Still under review right now. Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

Re: [PATCH] batman-adv: clarify CFG80211 dependency

2016-03-02 Thread Antonio Quartulli
27;: > (text+0x5c62c): undefined reference to `cfg80211_get_station' > > This clarifies the dependency to cover all combinations. > > Signed-off-by: Arnd Bergmann > Fixes: c833484e5f38 ("batman-adv: ELP - compute the metric based on the > estimated throughput")

[PATCH 11/15] batman-adv: B.A.T.M.A.N. V - implement neighbor comparison API calls

2016-02-29 Thread Antonio Quartulli
From: Antonio Quartulli Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner --- net/batman-adv/bat_v.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c index ff31f2af9cfe..953c0d150231 100644

[PATCH 12/15] batman-adv: B.A.T.M.A.N. V - implement bat_orig_print API

2016-02-29 Thread Antonio Quartulli
From: Antonio Quartulli Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner --- net/batman-adv/bat_v.c | 105 + 1 file changed, 105 insertions(+) diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c index 953c0d150231

[PATCH 10/15] batman-adv: ELP - send unicast ELP packets for throughput sampling

2016-02-29 Thread Antonio Quartulli
From: Antonio Quartulli In case of an unused wireless link, the mac80211 throughput estimation won't get updated further. Consequently, the reported throughput metric will become obsolete. With this patch unicast sampling is introduced by periodically sending unicast ELP packets to

[PATCH 14/15] batman-adv: Start new development cycle

2016-02-29 Thread Antonio Quartulli
From: Simon Wunderlich Signed-off-by: Simon Wunderlich Signed-off-by: Antonio Quartulli --- net/batman-adv/main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index 878c35974845..db4533631834 100644 --- a/net/batman-adv

[PATCH 15/15] MAINTAINERS: Add patchwork URL for BATMAN ADVANCED

2016-02-29 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Antonio Quartulli --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 27393cff1707..4fe223aa154d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2152,6 +2152,7 @@ M:Simon

[PATCH 13/15] batman-adv: B.A.T.M.A.N. V - implement bat_neigh_print API

2016-02-29 Thread Antonio Quartulli
From: Linus Luessing Lists all neighbours detected by the Echo Locating Protocol (ELP) and their throughput metric. Initially Developed by Linus during a 6 months trainee study period in Ascom (Switzerland) AG. Signed-off-by: Linus Luessing Signed-off-by: Marek Lindner Signed-off-by: Antonio

[PATCH 04/15] batman-adv: ELP - adding sysfs parameter for elp interval

2016-02-29 Thread Antonio Quartulli
: Antonio Quartulli --- Documentation/ABI/testing/sysfs-class-net-batman-adv | 8 +++- net/batman-adv/sysfs.c | 7 +++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-class-net-batman-adv b/Documentation/ABI/testing

[PATCH 05/15] batman-adv: OGMv2 - add basic infrastructure

2016-02-29 Thread Antonio Quartulli
From: Antonio Quartulli This is the initial implementation of the new OGM protocol (version 2). It has been designed to work on top of the newly added ELP. In the previous version the OGM protocol was used to both measure link qualities and flood the network with the metric information. In this

[PATCH 08/15] batman-adv: keep track of when unicast packets are sent

2016-02-29 Thread Antonio Quartulli
From: Antonio Quartulli To enable ELP to send probing packets over wireless links only if needed, batman-adv must keep track of the last time it sent a unicast packet towards every neighbour. For this purpose a 2 main changes are introduced: 1) a new member of the elp_neigh_node structure

[PATCH 03/15] batman-adv: ELP - creating neighbor structures

2016-02-29 Thread Antonio Quartulli
From: Linus Luessing Initially developed by Linus during a 6 months trainee study period in Ascom (Switzerland) AG. Signed-off-by: Linus Luessing Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_v.c | 23 ++- net/batman-adv/bat_v_elp.c | 152

[PATCH 02/15] batman-adv: ELP - adding basic infrastructure

2016-02-29 Thread Antonio Quartulli
nsmit qualities. Developed by Linus during a 6 months trainee study period in Ascom (Switzerland) AG. Signed-off-by: Linus Luessing Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/Kconfig | 14 net/batman-adv/Makefile| 2 + net/batman-adv/bat_a

[PATCH 06/15] batman-adv: OGMv2 - implement originators logic

2016-02-29 Thread Antonio Quartulli
From: Antonio Quartulli Add the support for recognising new originators in the network and rebroadcast their OGMs. Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner --- net/batman-adv/bat_v_elp.c | 41 +--- net/batman-adv/bat_v_ogm.c | 556

[PATCH 09/15] batman-adv: ELP - compute the metric based on the estimated throughput

2016-02-29 Thread Antonio Quartulli
From: Antonio Quartulli In case of wireless interface retrieve the throughput by querying cfg80211. To perform this call a separate work must be scheduled because the function may sleep and this is not allowed within an RCU protected context (RCU in this case is used to iterate over all the

[PATCH 01/15] batman-adv: Add hard_iface specific sysfs wrapper macros for UINT

2016-02-29 Thread Antonio Quartulli
). Developed by Linus during a 6 months trainee study period in Ascom (Switzerland) AG. Signed-off-by: Linus Luessing Signed-off-by: Marek Lindner [anto...@open-mesh.com: rename functions and move macros] Signed-off-by: Antonio Quartulli --- net/batman-adv/sysfs.c | 49

[PATCH 07/15] batman-adv: add throughput override attribute to hard_ifaces

2016-02-29 Thread Antonio Quartulli
From: Antonio Quartulli This attribute is exported to user space to disable the link throughput auto-detection by setting a fixed value. The throughput override value is used when batman-adv is computing the link throughput towards a neighbour. If the value is set to 0 then batman-adv will try

pull request [net-next]: batman-adv 20160229

2016-02-29 Thread Antonio Quartulli
he default values unless they know what they are doing. The last patch is about advertising our own patchwork platform (thanks to Sven Eckelmann for having set that up!) in the MAINTAINERS file. -------- Antonio Quartulli (8): batman-adv: O

[PATCH 19/20] batman-adv: Rename batadv_tt_global_entry *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/translation-table.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index de3e731542e3

[PATCH 15/20] batman-adv: Rename batadv_nc_node *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/network-coding.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c index 9180ff114a26..6105cfb0574c 100644 --- a/net

[PATCH 10/20] batman-adv: Rename batadv_dat_entry *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/distributed-arp-table.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c index 919f3445fff3

[PATCH 13/20] batman-adv: Rename batadv_tvlv_container *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index 95aaff371966..bf8a01b8f026 100644 --- a/net/batman-adv/main.c +++ b/net/batman

[PATCH 14/20] batman-adv: Rename batadv_softif_vlan *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/main.c | 2 +- net/batman-adv/soft-interface.c| 14 +++--- net/batman-adv/soft-interface.h| 2 +- net/batman-adv/sysfs.c | 4 ++-- net/batman-adv/translation-table.c | 20

  1   2   3   >