; - echo -e "$(basename $0): PASS=${num_pass} SKIP=${num_skip}
> FAIL=${num_err}"
> -
> - if [[ $num_err -ne 0 ]]; then
> - echo -e "$(basename $0): ${RED}FAIL${NC}"
> - exit ${KSFT_FAIL}
> - fi
> -
> - if [[ $num_skip -ne 0 ]]; then
> - echo -e "$(basename $0): ${YELLOW}SKIP${NC}"
> - exit ${KSFT_SKIP}
> - fi
> -
> - echo -e "$(basename $0): ${GREEN}PASS${NC}"
> - exit ${KSFT_PASS}
> -}
> +source "$(dirname $0)/../kselftest.sh"
>
> wake_children() {
> local -r jobs="$(jobs -p)"
> --
> 2.29.2.454.gaff20da3a2-goog
>
Reviewed-by: Antonio Cardace
Add scripts to test ring and coalesce settings
of netdevsim.
Signed-off-by: Antonio Cardace
---
.../drivers/net/netdevsim/ethtool-coalesce.sh | 132 ++
.../drivers/net/netdevsim/ethtool-ring.sh | 85 +++
2 files changed, 217 insertions(+)
create mode 100755
tools
Add ethtool ring and coalesce settings support for testing.
Signed-off-by: Antonio Cardace
Reviewed-by: Michal Kubecek
---
drivers/net/netdevsim/ethtool.c | 66 +--
drivers/net/netdevsim/netdevsim.h | 3 ++
2 files changed, 66 insertions(+), 3 deletions(-)
diff
Factor out some useful functions so that they can be reused
by other ethtool-netdevsim scripts.
Signed-off-by: Antonio Cardace
---
.../drivers/net/netdevsim/ethtool-common.sh | 69 +++
.../drivers/net/netdevsim/ethtool-pause.sh| 63 +
2 files changed, 71
As pointed out by Michal Kubecek, getting the name
with the previous approach was racy, it's better
and easier to get the name of the device with this
patch's approach.
Essentialy the function doesn't need to exist
anymore as it's a simple 'ls' command.
This will help the refactoring in the next commit
when coalesce and ring settings are added.
Signed-off-by: Antonio Cardace
Reviewed-by: Michal Kubecek
---
drivers/net/netdevsim/ethtool.c | 16
drivers/net/netdevsim/netdevsim.h | 6 +-
2 files changed, 13 insertions
Output of ethtool-ring.sh and ethtool-coalesce.sh selftests:
# ./ethtool-ring.sh
PASSED all 4 checks
# ./ethtool-coalesce.sh
PASSED all 22 checks
# ./ethtool-pause.sh
PASSED all 7 checks
Changelog v5 -> v6
- moved some bits from patch 3, they
were part of a refactoring made in patch 2
Anto
This bitmask represents all existing coalesce parameters.
Signed-off-by: Antonio Cardace
Reviewed-by: Michal Kubecek
---
include/linux/ethtool.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index 6408b446051f..e3da25b51ae4 100644
--- a
Add scripts to test ring and coalesce settings
of netdevsim.
Signed-off-by: Antonio Cardace
---
.../drivers/net/netdevsim/ethtool-coalesce.sh | 132 ++
.../drivers/net/netdevsim/ethtool-ring.sh | 85 +++
2 files changed, 217 insertions(+)
create mode 100755
tools
As pointed out by Michal Kubecek, getting the name
with the previous approach was racy, it's better
and easier to get the name of the device with this
patch's approach.
Essentialy the function doesn't need to exist
anymore as it's a simple 'ls' command.
Signed-of
This will help the refactoring in the next commit
when coalesce and ring settings are added.
Signed-off-by: Antonio Cardace
Reviewed-by: Michal Kubecek
---
drivers/net/netdevsim/ethtool.c | 14 +++---
drivers/net/netdevsim/netdevsim.h | 6 +-
2 files changed, 12 insertions(+), 8
This bitmask represents all existing coalesce parameters.
Signed-off-by: Antonio Cardace
Reviewed-by: Michal Kubecek
---
include/linux/ethtool.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index 6408b446051f..e3da25b51ae4 100644
--- a
Factor out some useful functions so that they can be reused
by other ethtool-netdevsim scripts.
Signed-off-by: Antonio Cardace
---
.../drivers/net/netdevsim/ethtool-common.sh | 69 +++
.../drivers/net/netdevsim/ethtool-pause.sh| 63 +
2 files changed, 71
Add ethtool ring and coalesce settings support for testing.
Signed-off-by: Antonio Cardace
Reviewed-by: Michal Kubecek
---
drivers/net/netdevsim/ethtool.c | 68 +--
drivers/net/netdevsim/netdevsim.h | 3 ++
2 files changed, 67 insertions(+), 4 deletions(-)
diff
etdevsim${NSIM_ID}/net/)'
to just 'ls /sys/bus/netdevsim/devices/netdevsim${NSIM_ID}/net/'
Antonio Cardace (6):
ethtool: add ETHTOOL_COALESCE_ALL_PARAMS define
netdevsim: move ethtool pause params in separate struct
netdevsim: support ethtool ring and coalesce settings
se
On Wed, Nov 18, 2020 at 08:56:10AM -0800, Jakub Kicinski wrote:
> On Wed, 18 Nov 2020 10:03:20 +0100 Antonio Cardace wrote:
> > Do I have to resend the whole serie as a new version or is there a
> > quicker way to just resend a single patch?
>
> Just repost the series
On Tue, Nov 17, 2020 at 06:35:20PM +0100, Michal Kubecek wrote:
> On Tue, Nov 17, 2020 at 04:20:14PM +0100, Antonio Cardace wrote:
> > As pointed out by Michal Kubecek, getting the name
> > with the previous approach was racy, it's better
> > and easier to get the na
Factor out some useful functions so that they can be reused
by other ethtool-netdevsim scripts.
Signed-off-by: Antonio Cardace
---
.../drivers/net/netdevsim/ethtool-common.sh | 69 +++
.../drivers/net/netdevsim/ethtool-pause.sh| 63 +
2 files changed, 71
Add ethtool ring and coalesce settings support for testing.
Signed-off-by: Antonio Cardace
Reviewed-by: Michal Kubecek
---
v3 -> v4:
- move supported_coalesce_params struct field as first field
- extracted pauseparam refactoring in a different patch
---
drivers/net/netdevsim/ethtool.c |
This will help the refactoring in the next commit
when coalesce and ring settings are added.
Signed-off-by: Antonio Cardace
Reviewed-by: Michal Kubecek
---
drivers/net/netdevsim/ethtool.c | 14 +++---
drivers/net/netdevsim/netdevsim.h | 6 +-
2 files changed, 12 insertions(+), 8
Add scripts to test ring and coalesce settings
of netdevsim.
Signed-off-by: Antonio Cardace
---
.../drivers/net/netdevsim/ethtool-coalesce.sh | 132 ++
.../drivers/net/netdevsim/ethtool-ring.sh | 85 +++
2 files changed, 217 insertions(+)
create mode 100755
tools
This bitmask represents all existing coalesce parameters.
Signed-off-by: Antonio Cardace
Reviewed-by: Michal Kubecek
---
include/linux/ethtool.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index 6408b446051f..e3da25b51ae4 100644
--- a
Output of ethtool-ring.sh and ethtool-coalesce.sh selftests:
# ./ethtool-ring.sh
PASSED all 4 checks
# ./ethtool-coalesce.sh
PASSED all 22 checks
Antonio Cardace (6):
ethtool: add ETHTOOL_COALESCE_ALL_PARAMS define
netdevsim: move ethtool pause params in separate struct
netdevsim: support
As pointed out by Michal Kubecek, getting the name
with the previous approach was racy, it's better
and easier to get the name of the device with this
patch's approach.
Essentialy the function doesn't need to exist
anymore as it's a simple 'ls' command.
On Mon, Nov 16, 2020 at 04:45:03PM -0800, Jakub Kicinski wrote:
> On Sat, 14 Nov 2020 00:16:55 +0100 Antonio Cardace wrote:
> > Add scripts to test ring and coalesce settings
> > of netdevsim.
> >
> > Signed-off-by: Antonio Cardace
>
> > @@ -0,0 +1,68 @@
On Mon, Nov 16, 2020 at 05:17:02PM +0100, Michal Kubecek wrote:
> On Sat, Nov 14, 2020 at 12:16:54AM +0100, Antonio Cardace wrote:
> > Factor out some useful functions so that they can be reused
> > by other ethtool-netdevsim scripts.
> >
> > Signed-off-by: Antoni
Add scripts to test ring and coalesce settings
of netdevsim.
Signed-off-by: Antonio Cardace
---
.../drivers/net/netdevsim/ethtool-coalesce.sh | 68 +++
.../drivers/net/netdevsim/ethtool-ring.sh | 53 +++
2 files changed, 121 insertions(+)
create mode 100755
Add ethtool ring and coalesce settings support for testing.
Signed-off-by: Antonio Cardace
---
drivers/net/netdevsim/ethtool.c | 82 ++-
drivers/net/netdevsim/netdevsim.h | 9 +++-
2 files changed, 79 insertions(+), 12 deletions(-)
diff --git a/drivers/net
Factor out some useful functions so that they can be reused
by other ethtool-netdevsim scripts.
Signed-off-by: Antonio Cardace
---
.../drivers/net/netdevsim/ethtool-common.sh | 69 +++
.../drivers/net/netdevsim/ethtool-pause.sh| 63 +
2 files changed, 71
This bitmask represents all existing coalesce parameters.
Signed-off-by: Antonio Cardace
---
include/linux/ethtool.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index 6408b446051f..e3da25b51ae4 100644
--- a/include/linux/ethtool.h
+++ b
Add scripts to test ring and coalesce settings
of netdevsim.
Signed-off-by: Antonio Cardace
---
.../drivers/net/netdevsim/ethtool-coalesce.sh | 68 +++
.../drivers/net/netdevsim/ethtool-ring.sh | 53 +++
2 files changed, 121 insertions(+)
create mode 100755
Add ethtool ring and coalesce settings support for testing.
Signed-off-by: Antonio Cardace
---
drivers/net/netdevsim/ethtool.c | 78 ++-
drivers/net/netdevsim/netdevsim.h | 9 +++-
2 files changed, 75 insertions(+), 12 deletions(-)
diff --git a/drivers/net
This bitmask represents all existing coalesce parameters.
Signed-off-by: Antonio Cardace
---
include/linux/ethtool.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index 6408b446051f..e3da25b51ae4 100644
--- a/include/linux/ethtool.h
+++ b
Factor out some useful functions so that they can be reused
by other ethtool-netdevsim scripts.
Signed-off-by: Antonio Cardace
---
.../drivers/net/netdevsim/ethtool-common.sh | 69 +++
.../drivers/net/netdevsim/ethtool-pause.sh| 63 +
2 files changed, 71
On Fri, Nov 13, 2020 at 12:45:22PM +0100, Michal Kubecek wrote:
> On Thu, Nov 12, 2020 at 04:12:29PM +0100, Antonio Cardace wrote:
> > Add ethtool ring and coalesce settings support for testing.
> >
> > Signed-off-by: Antonio Cardace
> > ---
> > drive
Add ethtool ring and coalesce settings support for testing.
Signed-off-by: Antonio Cardace
---
drivers/net/netdevsim/ethtool.c | 65 +++
drivers/net/netdevsim/netdevsim.h | 9 -
2 files changed, 65 insertions(+), 9 deletions(-)
diff --git a/drivers/net
36 matches
Mail list logo
