ers have
something to call/listen for. In the meantime, I can probably
integrate a private flag and go that route, but that feels hacky and
won't foster driver developers to follow suit. My goal is to empower
more open source alternatives to otherwise expensive commercials
solutions.
Best wishes,
Anton Hvornum
&vp->tx_poll, vector_tx_poll, (unsigned long)vp);
+ tasklet_setup(&vp->tx_poll, vector_tx_poll);
INIT_WORK(&vp->reset_tx, vector_reset_tx);
timer_setup(&vp->tl, vector_timer_expire, 0);
Acked-By: Anton Ivanov
--
Anton R. Ivanov
Cambridgegreys Limite
nds forces display
only relevant records.
Signed-off-by: Anton Danilov
---
bridge/fdb.c | 17 +
man/man8/bridge.8 | 30 ++
2 files changed, 31 insertions(+), 16 deletions(-)
diff --git a/bridge/fdb.c b/bridge/fdb.c
index 710dfc99..785a 1006
To improve the usability better use case-insensitive pattern-matching
in ifstat, nstat and ss tools.
Signed-off-by: Anton Danilov
---
man/man8/rtacct.8 | 7 +++
misc/ifstat.c | 2 +-
misc/nstat.c | 2 +-
misc/ss.c | 2 +-
4 files changed, 10 insertions(+), 3 deletions
To improve the usability better use case-insensitive pattern-matching
in ifstat, nstat and ss tools.
Signed-off-by: Anton Danilov
---
man/man8/rtacct.8 | 7 +++
misc/ifstat.c | 2 +-
misc/nstat.c | 2 +-
misc/ss.c | 2 +-
4 files changed, 10 insertions(+), 3 deletions
Hello, Stephen.
Thanks for feedback.
> Why not just make it the default?
> I can't imagine a scenario where user would want to match on icmp different
> than ICMP
Yes, I'm agreed. I'll make it the default in the v2 patch.
> Perhaps it should also be applied to ifstat and ss.
I'll prepare the
The option 'nocase' allows ignore case in the pattern matching.
Examples:
nstat --nocase *drop*
nstat -azi icmp*
Signed-off-by: Anton Danilov
---
man/man8/rtacct.8 | 8 +++-
misc/nstat.c | 14 ++
2 files changed, 17 insertions(+), 5 deletions(-)
diff -
ax of the qdisc show command:
tc qdisc { show | list } [ dev STRING ] [ QDISC_ID ] [ invisible ]
QDISC_ID := { root | ingress | handle QHANDLE | parent CLASSID }
This change doesn't require any changes in the kernel.
Signed-off-by: Anton Danilov
---
v2:
- Fix the coding style
v3:
of the one more alias is unnecessary.
What do you think about this?
--
Anton Danilov.
rent CLASSID }
This change doesn't require any changes in the kernel.
Signed-off-by: Anton Danilov
---
changes since v1:
coding style fixes
---
man/man8/tc.8 | 8 +++-
tc/tc_qdisc.c | 111 +++---
2 files changed, 84 insertions(+), 35 delet
rent CLASSID }
This change doesn't require any changes in the kernel.
Signed-off-by: Anton Danilov
---
man/man8/tc.8 | 8 +++-
tc/tc_qdisc.c | 109 +++---
2 files changed, 82 insertions(+), 35 deletions(-)
diff --git a/man/man8/tc.8 b/man
en_file(filename, of_read(OPENFLAGS()), 0);
if (ffd < 0) {
printk(KERN_ERR "Error %d opening bpf file", -errno);
Acked-By: Anton Ivanov
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
The test_map_rdonly and test_map_wronly tests should close file descriptors
which they open.
Signed-off-by: Anton Protopopov
---
tools/testing/selftests/bpf/test_maps.c | 4
1 file changed, 4 insertions(+)
diff --git a/tools/testing/selftests/bpf/test_maps.c
b/tools/testing/selftests/bpf
Trivial fix to a typo in the test_map_wronly test: "read" -> "write"
Signed-off-by: Anton Protopopov
---
tools/testing/selftests/bpf/test_maps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_maps.c
b/tools/testing/se
Make comments inside the test_map_rdonly and test_map_wronly tests
consistent with logic.
Signed-off-by: Anton Protopopov
---
tools/testing/selftests/bpf/test_maps.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_maps.c
b/tools
The map_lookup_and_delete_elem() function should check for both FMODE_CAN_WRITE
and FMODE_CAN_READ permissions because it returns a map element to user space.
Fixes: bd513cd08f10 ("bpf: add MAP_LOOKUP_AND_DELETE_ELEM syscall")
Signed-off-by: Anton Protopopov
---
kernel/bpf/syscall.c
For write-only stacks and queues bpf_map_update_elem should be allowed, but
bpf_map_lookup_elem and bpf_map_lookup_and_delete_elem should fail with EPERM.
Signed-off-by: Anton Protopopov
---
tools/testing/selftests/bpf/test_maps.c | 40 -
1 file changed, 39 insertions
BPF_MAP_TYPE_STACK and
BPF_MAP_TYPE_QUEUE map types.
Anton Protopopov (5):
selftests/bpf: fix a typo in test_maps
selftests/bpf: cleanup some file descriptors in test_maps
selftests/bpf: cleanup comments in test_maps
bpf: fix map permissions check
selftests/bpf: add tests for write-only stacks/queues
Signed-off-by: Anton Ivanov
---
net/core/xdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/xdp.c b/net/core/xdp.c
index d7bf62ffbb5e..20781ad5f9c3 100644
--- a/net/core/xdp.c
+++ b/net/core/xdp.c
@@ -386,7 +386,7 @@ EXPORT_SYMBOL_GPL(xdp_rxq_info_reg_mem_model
Signed-off-by: Anton Ivanov
---
samples/bpf/xdpsock_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c
index d08ee1ab7bb4..eb78159376eb 100644
--- a/samples/bpf/xdpsock_user.c
+++ b/samples/bpf/xdpsock_user.c
ON (4)
---
This does not quite work because in some of the drivers you get extra
added on top of this constant.
I am going to see what can be done to fix the old net* drivers, imho we
should start phasing them out in favor of the vector ones.
--
Anton R. Ivanov
Cambridgegreys Limited. Register
On 12/07/2019 10:22, Anton Ivanov wrote:
On 02/07/2019 15:40, Richard Weinberger wrote:
CC'ing um folks.
On Tue, Jul 2, 2019 at 3:01 PM Алексей wrote:
Hello, the parameter ETH_MAX_PACKET limited to 1500 bytes is the not
support jumbo frames.
This patch change ETH_MAX_PACKET the
ON (4)
---
The vector version for tap already allows mtu > 1500. It does not have a
check to limit it to 65535 max though and it should.
I will add this one to the queue of stuff for the network drivers. IMHO
we should start migrating some of the older ones to vector IO.
--
Anton R. Ivan
ample VLAN tagging and
> > IP options. What's more, it is not easy for user-space to learn the offset
> > for different packets as it requires to parse into each packets.
> >
> > I don't know whether we can fix this either, VLAN call path probably
> > already makes assumptions on the current skb->data position, if
> > we "fix" it for u32, it would probably break other things.
--
Anton.
er
[1] https://www.google.com/intl/en/ipv6/statistics.html
Signed-off-by: Anton Gary Ceph
---
drivers/net/bonding/bond_main.c| 2 +-
drivers/net/ipvlan/ipvlan_core.c | 2 +-
drivers/net/vxlan.c| 6 +++---
include/linux/netdevice.h | 2 +-
include/net/ip_tunnels.h
t tap
has an unfair advantage over raw by allowing the user to specify buffers
from userspace. I am happy to port that, test it and contribute it.
--
Anton R. Ivanov
Cambridge Greys Limited, England and Wales company No 10273661
http://www.cambridgegreys.com/
t;msg_namelen < (saddr->sll_halen +
> offsetof(struct sockaddr_ll, sll_addr)))
> goto out;
> proto = saddr->sll_protocol;
> addr= saddr->sll_addr;
> dev = dev_get_by_index(sock_net(sk), saddr->sll_ifindex);
> }
>
> followed later by
>
> skb->protocol = proto;
> skb->dev = dev;
>
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
On 10/12/17 18:25, Willem de Bruijn wrote:
On Thu, Oct 12, 2017 at 12:30 PM, Willem de Bruijn
wrote:
On Thu, Oct 12, 2017 at 11:44 AM, Anton Ivanov
wrote:
Found it.
Two bugs canceling each other.
The bind sequence in: psock_txring_vnet.c is wrong.
It does the following addr.sll_protocol
/12/17 16:44, Anton Ivanov wrote:
Found it.
Two bugs canceling each other.
The bind sequence in: psock_txring_vnet.c is wrong.
It does the following addr.sll_protocol = htons(ETH_P_IP);
before calling bind.
If you set addr.sll_protocol to ETH_P_ALL where it should have been in
the first place
other test cases like setting it to ETH_P_IP and
giving it IPv6 traffic or the opposite, but my guess is that these will
fail too if they need GSO to be applied.
A.
On 10/12/17 15:12, Anton Ivanov wrote:
On 10/12/17 14:39, Willem de Bruijn wrote:
If I produce a real vnet frame out of a l
to finish fighting with it.
A.
--
Anton R. Ivanov
Cambridge Greys Limited, England and Wales company No 10273661
http://www.cambridgegreys.com/
mantics as my code so I have something to compare to.
A.
On 10/12/17 07:11, Anton Ivanov wrote:
On 12/10/17 01:19, Willem de Bruijn wrote:
On Wed, Oct 11, 2017 at 6:01 PM, Anton Ivanov
wrote:
[snip]
This will be tomorrow though, it is late here.
The only obvious difference I can see at thi
On 12/10/17 01:19, Willem de Bruijn wrote:
> On Wed, Oct 11, 2017 at 6:01 PM, Anton Ivanov
> wrote:
>> [snip]
>>
>>> This will be tomorrow though, it is late here.
>>>
>>> The only obvious difference I can see at this point is that I am using
>>&
> not make any difference though - it all ends up as an iov internally in
> the kernel.
Spoke too soon. It is not reporting any errors, but there is nothing
coming out on the actual Ethernet.
Leaving it till tomorrow.
A.
>
> A.
>
>
--
Anton R. Ivanov
Cambridgegreys Limite
[snip]
> The test can be run both with and without ring:
>
> psock_txring_vnet -l 8000 -s $src_ip -d $dst_ip -v
> psock_txring_vnet -l 8000 -s $src_ip -d $dst_ip -v -N
>
> both with and without qdisc bypass ('-q').
Thanks, apologies, I was being inpatient. Started reading the source,
saw the
On 11/10/17 19:57, Willem de Bruijn wrote:
> On Wed, Oct 11, 2017 at 2:39 PM, Anton Ivanov
> wrote:
>> The check as now insists that the actual driver supports GSO_ROBUST, because
>> we have marked the skb dodgy.
>>
>> The specific bit which does this check is in
; -exec grep -H
GSO_ROBUST {} \;
That returns nothing in 4.x
IMHO - af_packet allocates the skb, does all checks (and extra may be
added) on the gso, why is this set dodgy in the first place?
A.
On 11/10/17 17:26, Willem de Bruijn wrote:
On Wed, Oct 11, 2017 at 11:54 AM, Anton Ivanov
wrote:
I
:
On Wed, Oct 11, 2017 at 11:54 AM, Anton Ivanov
wrote:
It is that patch.
I rolled it back and immediately got it to work correctly on a Broadcom
Tigon. I can test on all other scenarios, I have tried, I suspect it will
come back alive on all of them.
I am going to try to trace it through and see
no issues in accepting.
A.
On 10/11/17 14:50, Anton Ivanov wrote:
On 10/11/17 14:39, Willem de Bruijn wrote:
On Wed, Oct 11, 2017 at 4:39 AM, Anton Ivanov
wrote:
Hi all,
I am having an issue with af_packet.c
It fails to transmit any TSO frame submitted via raw socket + vnet
headers.
An
On 10/11/17 14:39, Willem de Bruijn wrote:
On Wed, Oct 11, 2017 at 4:39 AM, Anton Ivanov
wrote:
Hi all,
I am having an issue with af_packet.c
It fails to transmit any TSO frame submitted via raw socket + vnet headers.
An identical frame is considered valid for tap.
This may be due to
so it falls under his
umbrella remit.
--
Anton R. Ivanov
Cambridge Greys Limited, England and Wales company No 10273661
http://www.cambridgegreys.com/
e dongle with id 0 exists). Is
this case feasible from your point of view?
Thank you for your time.
-- Anton Volkov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: avol...@ispras.ru
hem changes the ks->cmd_reg_cache it is possible
that both will use the same value though it should be different. Is this
race feasible from your point of view?
Thank you for your time.
-- Anton Volkov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: avol...@ispras.ru
tion feasible from
your point of view? If it is feasible, is it a benign race or something
serious?
Thank you for your time.
-- Anton Volkov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: avol...@ispras.ru
may then be
assigned an undesirable value and wrong controller may handle messages.
Is this case feasible from your point of view?
Thank you for your time.
-- Anton Volkov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: avol...@ispras.ru
If mISDN_FsmNew() fails to allocate memory for jumpmatrix
then null pointer dereference will occur on any write to
jumpmatrix.
The patch adds check on successful allocation and
corresponding error handling.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton
tion feasible from
your point of view? If it is feasible, is it a benign race or something
serious?
Thank you for your time.
-- Anton Volkov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: avol...@ispras.ru
won't be feasible in
the future.
Found by by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Volkov
---
v2: Fixed coding style issues
drivers/isdn/hysdn/hysdn_proclog.c | 28 +---
1 file changed, 13 insertions(+), 15 deletions(-)
diff --
won't be feasible in
the future.
Found by by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Volkov
---
drivers/isdn/hysdn/hysdn_proclog.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/isdn/hysdn/hysdn_proc
gx->bgx_id could achieve value 3 + 3 * 4 = 15,
which lead to buffer overwrite on
bgx_vnic[bgx->bgx_id] = bgx;
Question: is it enough for fix to change bgx_vnic's size?
Found by Linux Driver Verification project (linuxtesting.org).
--
Anton Vasilyev
Linux Verification Center, I
cases won't be feasible in
the future.
Found by by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Volkov
---
drivers/isdn/hysdn/hysdn_proclog.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/isdn/
Hello.
While searching for races in the Linux kernel I've come across
"drivers/isdn/hysdn/hysdn.ko" module. Here is a question that I came up
with while analysing results. Lines are given using the info from Linux
v4.12.
In hysdn_proclog.c file in put_log_buffer function a non-standard type
of s
On 11/05/17 03:43, Jason Wang wrote:
>
>
> On 2017年05月10日 17:42, Anton Ivanov wrote:
>> On 10/05/17 09:56, Jason Wang wrote:
>>>
>>>
>>> On 2017年05月10日 13:28, Anton Ivanov wrote:
>>>> On 10/05/17 03:18, Jason Wang wrote:
>>>>>
On 10/05/17 09:56, Jason Wang wrote:
On 2017年05月10日 13:28, Anton Ivanov wrote:
On 10/05/17 03:18, Jason Wang wrote:
On 2017年05月09日 23:11, Stefan Hajnoczi wrote:
On Tue, May 09, 2017 at 08:46:46AM +0100, Anton Ivanov wrote:
I have figured it out. Two issues.
1) skb->xmit_more is har
;, the impact is quite significant. If
your transport does not support bulking, the fact there was bulking
earlier in the chain has little impact.
There is some, but not a lot.
[snip]
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
On 10/05/17 03:18, Jason Wang wrote:
>
>
> On 2017年05月09日 23:11, Stefan Hajnoczi wrote:
>> On Tue, May 09, 2017 at 08:46:46AM +0100, Anton Ivanov wrote:
>>> I have figured it out. Two issues.
>>>
>>> 1) skb->xmit_more is hardly ever set under virtua
qdisc" + "always xmit_more
allowed"
A.
P.S. Cc-ing virtio maintainer
A.
On 08/05/17 08:15, Anton Ivanov wrote:
Hi all,
I was revising some of my old work for UML to prepare it for
submission and I noticed that skb->xmit_more does not seem to be set
any mor
Hi all,
I was revising some of my old work for UML to prepare it for submission
and I noticed that skb->xmit_more does not seem to be set any more.
I traced the issue as far as net/sched/sched_generic.c
try_bulk_dequeue_skb() is never invoked (the drivers I am working on are
dql enabled so t
:
time seq 1 1000 | xargs -n 1 ip netns add
real0m16.832s
user0m1.350s
sys0m15.029s
patched:
time seq 1 1000 | xargs -n 1 ip netns add
real0m3.859s
user0m0.132s
sys0m3.205s
Signed-off-by: Anton Aksola
---
ip/ip_common.h| 1 +
ip/ipmonitor.c
he initialization to different functions and call the
socket init in the beginning of do_netns() as before? What do you think?
I made a quick patch and it seems to work in batch mode now.
BR,
Anton
On Fri, Sep 16, 2016 at 02:25:40PM +0300, Vadim Kochan wrote:
> Anton, I just looked into tests after when I did post here. I am not
> sure it will be trivial,
> currently tests are running within separated network namespace by
> default (which I did) via
> 'unshare' tool,
:
time seq 1 1000 | xargs -n 1 ip netns add
real0m16.832s
user0m1.350s
sys0m15.029s
patched:
time seq 1 1000 | xargs -n 1 ip netns add
real0m3.859s
user0m0.132s
sys0m3.205s
Signed-off-by: Anton Aksola
---
ip/ipnetns.c | 14 +-
1 file changed, 9 insertions
On Thu, Sep 15, 2016 at 03:26:18PM +0200, Nicolas Dichtel wrote:
[snip]
> 'ip netns' (ip netns list) also need it.
Thanks, I missed your other commit that introduced it. Sending an updated patch.
:
time seq 1 1000 | xargs -n 1 ip netns add
real0m16.832s
user0m1.350s
sys0m15.029s
patched:
time seq 1 1000 | xargs -n 1 ip netns add
real0m3.859s
user0m0.132s
sys0m3.205s
Signed-off-by: Anton Aksola
---
ip/ipnetns.c | 6 +++---
1 file changed, 3 insertions(+), 3
kernel config or use the kernel cmd line boot options like
processor.max_cstate = 0 and intel_idle.max_cstate = 0?
4. Hyper-threading usage. I've disabled it in the bios to avoid a unefficient
cache usage. But maybe someone have opposite view on this feature.
Thanks for your attention an
nce.
Signed-off-by: Anton Protopopov
---
drivers/isdn/hardware/mISDN/netjet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/mISDN/netjet.c
b/drivers/isdn/hardware/mISDN/netjet.c
index 8e29447..afde4ed 100644
--- a/drivers/isdn/hardware/mISDN/netje
The cfrfml_receive() function might return positive value EPROTO
Signed-off-by: Anton Protopopov
---
net/caif/cfrfml.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c
index 61d7617..b82440e 100644
--- a/net/caif/cfrfml.c
+++ b/net/caif
The atalk_sendmsg() function might return wrong value ENETUNREACH
instead of -ENETUNREACH.
Signed-off-by: Anton Protopopov
---
net/appletalk/ddp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index d5871ac..f066781 100644
--- a
An error response from a RTM_GETNETCONF request can return the positive
error value EINVAL in the struct nlmsgerr that can mislead userspace.
Signed-off-by: Anton Protopopov
---
net/ipv4/devinet.c | 2 +-
net/ipv6/addrconf.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
The iwl_trans_pcie_start_fw() function may return the positive value EIO
instead of -EIO in case of error.
Signed-off-by: Anton Protopopov
---
drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi
The ath10k_pci_hif_exchange_bmi_msg() function may return the positive
value EIO instead of -EIO in case of error.
Signed-off-by: Anton Protopopov
---
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c
The nft_counter_init() and nft_counter_clone() functions should return
negative error value -ENOMEM instead of positive ENOMEM.
Signed-off-by: Anton Protopopov
---
net/netfilter/nft_counter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/nft_counter.c b
Hi Scott,
> I wonder why it was 64-bit specific in the first place.
I think it was part of a series where I added my 64bit assembly checksum
routines, and I didn't step back and think that the wrapper code would
be useful on 32 bit.
Anton
--
To unsubscribe from this list: send
This patch fixes a warning in clk_enable by calling
clk_prepare_enable instead.
Signed-off-by: Heiko Schocher
Signed-off-by: Anton Glukhov
---
drivers/net/can/ti_hecc.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can
On Fri, Feb 22, 2008 at 11:40:04AM -0600, Andy Fleming wrote:
>
> On Feb 22, 2008, at 09:55, Anton Vorontsov wrote:
>
> >When user disabled autonegotiation via ethtool, and no link is
> >detected,
> >phylib will place phy into forcing mode, and then will start cal
g disabled, phylib will not try
other link setups.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
This is of course post-2.6.25 material and highly RFC, as it changes
current behaviour. Please review carefully.
Thanks.
drivers/net/phy/phy.c | 19 ---
include
rst opportunity, and will name that register and its bits correctly.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
drivers/net/phy/broadcom.c | 54
1 files changed, 54 insertions(+), 0 deletions(-)
diff --git a/drivers/net/phy/broadcom
truct fixed_phy *fp, *tmp;
>
> mdiobus_unregister(&fmb->mii_bus);
> platform_device_unregister(pdev);
>
> - list_for_each_entry(fp, &fmb->phys, node) {
> + list_for_each_entry_safe(fp, tmp, &fmb->phys, node) {
> list_del(&fp->node);
On Fri, Feb 01, 2008 at 09:32:38AM -0600, Kumar Gala wrote:
> On Feb 1, 2008, at 9:01 AM, Anton Vorontsov wrote:
>
> >It isn't used anywhere, so remove it. If we'll ever need something
> >like this, we'll use compatible property instead.
> >
> >Sig
This patch adds netpoll support for the QE UCC Gigabit Ethernet
driver. Tested using netconsole and KGDBoE.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
Just resending this.
drivers/net/ucc_geth.c | 20
1 files changed, 20 insertions(+), 0 deletions(-)
hX up';
- add unregister_netdev();
- reorder geth_remove() steps.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
Hi Li,
You kinda promised that these two patches would hit 2.6.25... ;-)
I've rebased the patches so they apply cleanly on the current tree.
Thanks,
drivers/
On Thu, Jan 24, 2008 at 10:33:47AM -0600, Timur Tabi wrote:
> Anton Vorontsov wrote:
>
> >Are you saying that TDM is sharing same pins with the other QE device,
> >and we can choose to use/not use some device depending on which driver
> >is loaded?
>
> No. I
On Thu, Jan 24, 2008 at 09:55:31AM -0600, Timur Tabi wrote:
> Anton Vorontsov wrote:
>
> >Can we not introduce new pio-maps in the device trees? There
> >were debates regarding this, and if I understood everything
> >correctly, pio-maps considered as a bad tast
Can we not introduce new pio-maps in the device trees? There
were debates regarding this, and if I understood everything
correctly, pio-maps considered as a bad taste. Better
do bunch of par_io_config_pin() in the board file. Better
yet fixup the firmware (u-boot) to set up dedicated pins
correctly.
T
On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote:
> Anton,
>
> it looks like the "TI AR7 CPMAC Ethernet support" uses FIXED_PHY and
> was selecting FIXED_MII_100_FDX which is gone.
>
> Can you look into this. I get the following warning now:
>
> sc
device_type property is bogus, thus use proper compatible.
Also change compatible property to "fsl,ucc-mdio".
Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc832x_mds.dts
device_type property is bogus, thus use proper compatible.
Also change compatible property to "fsl,ucc-mdio".
Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc832x_mds.dts
[c000d4c0] ret_from_syscall+0x0/0x3c
Instruction dump:
8163 800b0030 2f80 419e0010 7c0803a6 4e800021 7c691b78 80010014
7d234b78 38210010 7c0803a6 4e800020 <8003014c> 7c6b1b78 3860 90040004
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
drivers/net/fs_enet
device_type property is bogus, better use proper compatible property.
Also change compatible to "fsl,ucc-mdio".
Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc832x_mds.dts
ually fixing section mismatch by removing __exit from
the header file.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
drivers/net/ucc_geth_mii.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ucc_geth_mii.h b/drivers/net/ucc_geth_mii.h
index d83
or necessary to export the
> phy_device_free symbol, though.
Makes sense, I think. Here is the newer patch, the only difference is
removed EXPORT_SYMBOL(). Because of trivial change, I dared to keep
Andy's Acked-by intact.
- - - -
From: Anton Vorontsov <[EMAIL PROTECTED]>
Subject: [
ut the PHY lib supports it.
> Even if fixed PHYs doesn't support it directly I think the OF interface
> should have it.
>
> - fixed-link : where a is emulated phy id - choose any,
> but unique to the all specified fixed-links, b is duplex - 0 half,
> 1 full
- - -
And remove fixed_phy_add() from the fs_enet. This should work
nicely and also should be ideologically correct. ;-)
> How is this supposed to work for modules or for the
> PPC_CPM_NEW_BINDING mode where the device tree is no longer scanned
> during fs_soc initialization but durin
On Tue, Nov 27, 2007 at 02:17:11PM +0100, Joakim Tjernlund wrote:
>
> On Tue, 2007-11-27 at 14:39 +0300, Anton Vorontsov wrote:
> > On Mon, Nov 26, 2007 at 04:04:08PM +0100, Joakim Tjernlund wrote:
> > > On Mon, 2007-11-26 at 17:29 +0300, Vitaly Bordug wrote:
> > > &
f-by: Vitaly Bordug <[EMAIL PROTECTED]>
> > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
> >
> > ---
> >
> > Documentation/powerpc/booting-without-of.txt |3 +
> > arch/powerpc/sysdev/fsl_soc.c| 56
> > ++
s them up to go through netdev or the
> other way around; either way is fine with me). I'm hoping they're
> trivial enough to go in 2.6.24.
All five patches are
Tested-by: Anton Vorontsov <[EMAIL PROTECTED]>
Let's hope they'll hit 2.6.24.
Thanks,
--
Anton
c MII ()
read wrong value : mii_id 1,mii_reg 1, base e0103120
read wrong value : mii_id 1,mii_reg 1, base e0103120
read wrong value : mii_id 1,mii_reg 5, base e0103120
FSL UEC1: Full Duplex
switching to rgmii 100
FSL UEC1: Speed 100BT
FSL UEC1: Link is up
FSL UEC0, FSL UEC1
- - - -
And
On Thu, Nov 08, 2007 at 12:15:08PM -0600, Kim Phillips wrote:
> On Thu, 8 Nov 2007 17:16:11 +0300
> Anton Vorontsov <[EMAIL PROTECTED]> wrote:
>
> > On Mon, Nov 05, 2007 at 12:15:30PM -0600, Kim Phillips wrote:
> > > Hello all,
> > >
> > > the fo
ing
> with Rev Pilot MDS for proper RGMII operation:
>
> IMMR_BASE + 0x14A8[4:5] = 11 (clk delay for UCC 2)
> IMMR_BASE + 0x14A8[18:19] = 11 (clk delay for UCC 1)
> IMMR_BASE + 0x14AC[20:27] = 10101010 (data delay for both UCC's)
>
> The Phy (Marvell 88e) should be con
On Thu, Nov 01, 2007 at 10:33:24AM +0800, Li Yang-r58472 wrote:
> > -Original Message-
> > From: Anton Vorontsov [mailto:[EMAIL PROTECTED]
> > Sent: Thursday, November 01, 2007 5:59 AM
> > To: Li Yang-r58472
> > Cc: netdev@vger.kernel.org; [EMAIL PRO
1 - 100 of 146 matches
Mail list logo
