RE: [PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes

+++- > drivers/net/ethernet/ti/cpsw.h | 1 + > 3 files changed, 23 insertions(+), 23 deletions(-) > > -- > 2.5.5 Tested on hardware with 2 PHYs but not dual_emac mode, DT has phy-handle entries. Tested-by: Andrew Goodbody

[PATCH v2 1/1] Revert "Prevent NUll pointer dereference with two PHYs on cpsw"

This reverts commit cfe255600154f0072d4a8695590dbd194dfd1aeb This can result in a "Unable to handle kernel paging request" during boot. This was due to using an uninitialised struct member, data->slaves. Signed-off-by: Andrew Goodbody Tested-by: Tony Lindgren --- v2 No code

[PATCH v2 0/1] Revert "Prevent NUll pointer dereference with two PHYs"

Revert this patch as not only did it use an unitialised member of a struct but there is also a pre-existing patch that does it better. V2 add signoff Andrew Goodbody (1): Revert "Prevent NUll pointer dereference with two PHYs on cpsw" drivers/net/ethernet/ti/c

[PATCH 1/1] Revert "Prevent NUll pointer dereference with two PHYs on cpsw"

This reverts commit cfe255600154f0072d4a8695590dbd194dfd1aeb This can result in a "Unable to handle kernel paging request" during boot. This was due to using an uninitialised struct member, data->slaves. --- drivers/net/ethernet/ti/cpsw.c | 31 +++ 1 file changed, 15 i

[PATCH 0/1] Revert "Prevent NUll pointer dereference with two PHYs"

Revert this patch as not only did it use an unitialised member of a struct but there is also a pre-existing patch that does it better. Andrew Goodbody (1): Revert "Prevent NUll pointer dereference with two PHYs on cpsw" drivers/net/ethernet/ti/cpsw.c | 31 +++-

RE: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs

> -Original Message- > From: Andrew Goodbody > Date: Mon, 18 Apr 2016 14:53:25 +0100 > > > This is a fix for a NULL pointer dereference from cpsw which is > > triggered by having two slave PHYs attached to a cpsw network device. > > The problem is du

[PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

r7:0036 r6:0002 r5:0011 r4: [ 18.380960] Code: e92dd810 e24cb010 e24dd010 e59b4004 (e5902180) [ 18.387580] ---[ end trace c80529466223f3f3 ]--- Signed-off-by: Andrew Goodbody --- v2 - Move allocation of memory for priv->slaves to inside cpsw_probe_dt so it has d

[PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs

gets overwritten by the second PHY probe. So move the PHY node reference to the individual slave data so that there is now one per slave. v1 had a problem that data->slaves was used before it had been filled in Andrew Goodbody (1): Prevent NUll pointer dereference with two PHYs on cpsw driv

[PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

r7:0036 r6:0002 r5:0011 r4: [ 18.380960] Code: e92dd810 e24cb010 e24dd010 e59b4004 (e5902180) [ 18.387580] ---[ end trace c80529466223f3f3 ]--- Signed-off-by: Andrew Goodbody --- v2 - Move allocation of memory for priv->slaves to inside cpsw_probe_dt so it has d

[PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs

reference to the individual slave data so that there is now one per slave. v1 had a problem that data->slaves was used before it had been filled in Andrew Goodbody (1): Prevent NUll pointer dereference with two PHYs on cpsw drivers/net/ethernet/ti/cpsw.c | 30 +++--- 1 f

[PATCH] Fix NULL pointer dereference in cpsw with two slave PHYs

reference to the individual slave data so that there is now one per slave. Andrew Goodbody (1): Prevent NUll pointer dereference with two PHYs on cpsw drivers/net/ethernet/ti/cpsw.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) -- 2.5.0

[PATCH] Prevent NUll pointer dereference with two PHYs on cpsw

r7:0036 r6:0002 r5:0011 r4: [ 18.380960] Code: e92dd810 e24cb010 e24dd010 e59b4004 (e5902180) [ 18.387580] ---[ end trace c80529466223f3f3 ]--- Signed-off-by: Andrew Goodbody --- drivers/net/ethernet/ti/cpsw.c | 31 --- 1 file changed, 16