Re: [RFC net-next 4/5] net: phy: Fixup GPLv2 SPDX tags based on license text

2019-01-15 Thread Andrew F. Davis
, use it as the definitive source of the > licence, and fixup with others when there are contradictions. > > Cc: Russell King > Cc: Maxime Ripard > Cc: Jonas Jensen > Cc: Laurent Pinchart > Cc: Paulius Zaleckas > Cc: Scott Wood > Cc: Andrew F. Davis Acked-by: Andrew F.

Re: [PATCH v5 1/2] net: phy: DP83822 initial driver submission

2017-10-10 Thread Andrew F. Davis
river > as the WoL support is added here for this device. > > Datasheet: > http://www.ti.com/product/DP83822I/datasheet > > Signed-off-by: Dan Murphy > --- Looks much nicer now, thanks for dealing with my nitpicking :) Acked-by: Andrew F. Davis > > v5 - Fixed bit mas

Re: [PATCH v4 1/2] net: phy: DP83822 initial driver submission

2017-10-09 Thread Andrew F. Davis
On 10/09/2017 11:59 AM, Dan Murphy wrote: > Add support for the TI DP83822 10/100Mbit ethernet phy. > > The DP83822 provides flexibility to connect to a MAC through a > standard MII, RMII or RGMII interface. > > In addition the DP83822 needs to be removed from the DP83848 driver > as the WoL sup

[PATCH] net: usb: asix88179_178a: Add support for the Belkin B2B128

2017-06-26 Thread Andrew F. Davis
someone more familiar with the upstreaming process. Signed-off-by: Andrew F. Davis --- drivers/net/usb/ax88179_178a.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 51cf60092a18..4037ab27734a 100644 --- a

Re: [PATCH] net: phy: dp83848: Support ethernet pause frames

2016-12-02 Thread Andrew F. Davis
On 12/02/2016 08:22 AM, Jesper Nilsson wrote: > According to the documentation, the PHYs supported by this driver > can also support pause frames. Announce this to be so. > Tested with a TI83822I. > Looks like all PHYs supported by this driver do, so: Acked-by: Andrew F. Davis >

Re: [PATCH v2 0/2] net: ethernet: ti: cpsw: delete rx_descs property

2016-06-13 Thread Andrew F. Davis
On 06/13/2016 03:22 AM, Mugunthan V N wrote: > On Saturday 11 June 2016 04:34 AM, Schuyler Patton wrote: >> >> >> On 06/08/2016 07:03 PM, Ivan Khoronzhuk wrote: >>> >>> >>> On 09.06.16 02:11, Schuyler Patton wrote: On 06/08/2016 09:06 AM, Ivan Khoronzhuk wrote: > > > On 0

Re: [PATCH v2 net-next] net: ethernet: enc28j60: add device tree support

2016-04-25 Thread Andrew F. Davis
On 04/25/2016 12:46 PM, Michael Heimpold wrote: > Hi, > > Am Monday 25 April 2016, 10:39:41 schrieben Sie: >> On 04/24/2016 04:28 PM, Michael Heimpold wrote: >>> - eth_hw_addr_random(dev); >>> + >>> + macaddr = of_get_mac_address(spi->dev.of_node); >>> + if (macaddr) >> >> You should also ch

Re: [PATCH v2 net-next] net: ethernet: enc28j60: add device tree support

2016-04-25 Thread Andrew F. Davis
On 04/24/2016 04:28 PM, Michael Heimpold wrote: > The following patch adds the required match table for device tree support > (and while at, fix the indent). It's also possible to specify the > MAC address in the DT blob. > > Also add the corresponding binding documentation file. > > Signed-off-b

[PATCH] net: phy: dp83848: Fix sysfs naming collision warning

2016-02-17 Thread Andrew F. Davis
Files in sysfs are created using the name from the phy_driver struct, when two names are the same we may get a duplicate filename warning, fix this. Reported-by: kernel test robot Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH v2 2/5] net: phy: dp83848: Add PHY ID for TI version of DP83848C

2016-02-17 Thread Andrew F. Davis
On 02/07/2016 11:47 AM, Andrew F. Davis wrote: After acquiring National Semiconductor, TI appears to have changed the Vendor Model Number for the DP83848C PHYs, add this new ID to supported IDs. Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 9 ++--- 1 file changed, 6

[PATCH v2 2/5] net: phy: dp83848: Add PHY ID for TI version of DP83848C

2016-02-07 Thread Andrew F. Davis
After acquiring National Semiconductor, TI appears to have changed the Vendor Model Number for the DP83848C PHYs, add this new ID to supported IDs. Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v2 0/5] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs

2016-02-07 Thread Andrew F. Davis
Hello all, This series is [0] split into its logical components. Thanks, Andrew [0] http://www.spinics.net/lists/netdev/msg363106.html Andrew F. Davis (5): net: phy: dp83848: Add macro for dp83848 compatible devices net: phy: dp83848: Add PHY ID for TI version of DP83848C net: phy

[PATCH v2 5/5] net: phy: dp83848: Add comments for register definitions

2016-02-07 Thread Andrew F. Davis
Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c index f897989..556904f 100644 --- a/drivers/net/phy/dp83848.c +++ b/drivers/net/phy/dp83848.c @@ -21,8 +21,8

[PATCH v2 4/5] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs

2016-02-07 Thread Andrew F. Davis
The TI TLK10x Ethernet PHYs are similar in the interrupt relevant registers and so are compatible with the DP83848x devices already supported. Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/dp83848.c b/drivers

[PATCH v2 3/5] net: phy: dp83848: Reorganize code for readability and safety

2016-02-07 Thread Andrew F. Davis
Reorganize code by moving the desired interrupt mask definition out of function. Also rearrange the enable/disable interrupt function to prevent accidental over-writing of values in registers. Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 33 - 1

[PATCH v2 1/5] net: phy: dp83848: Add macro for dp83848 compatible devices

2016-02-07 Thread Andrew F. Davis
Add a helper macro for defining dp83848 compatible phy devices. Update copyright info. Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 41 ++--- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/drivers/net/phy/dp83848.c b/drivers

Re: [PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs

2016-02-07 Thread Andrew F. Davis
On 02/06/2016 03:25 PM, Florian Fainelli wrote: Le 05/02/2016 15:13, Andrew F. Davis a écrit : The TI TLK10x Ethernet PHYs are similar in the interrupt relevant registers and so are compatible with the DP83848x devices already supported. Add these and re-order code to support additional PHYs

[PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs

2016-02-05 Thread Andrew F. Davis
The TI TLK10x Ethernet PHYs are similar in the interrupt relevant registers and so are compatible with the DP83848x devices already supported. Add these and re-order code to support additional PHYs. Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 89

Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY

2015-10-20 Thread Andrew F. Davis
On 10/20/2015 04:37 PM, Florian Fainelli wrote: On 20/10/15 14:28, Andrew F. Davis wrote: Add support for the TI DP83848 Ethernet PHY device. The DP83848 is a highly reliable, feature rich, IEEE 802.3 compliant single port 10/100 Mb/s Ethernet Physical Layer Transceiver supporting the MII and

[PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY

2015-10-20 Thread Andrew F. Davis
Add support for the TI DP83848 Ethernet PHY device. The DP83848 is a highly reliable, feature rich, IEEE 802.3 compliant single port 10/100 Mb/s Ethernet Physical Layer Transceiver supporting the MII and RMII interfaces. Signed-off-by: Andrew F. Davis Signed-off-by: Dan Murphy --- drivers/net