Re: [PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy

2020-11-14 Thread Andreas Färber
Hi Russell, On 15.11.20 02:02, Russell King - ARM Linux admin wrote: > On Sun, Nov 15, 2020 at 01:41:51AM +0100, Andreas Färber wrote: >> Commit 1a642ca7f38992b086101fe204a1ae3c90ed8016 (net: ethernet: mvneta: >> Add 2500BaseX support for SoCs without comphy) added support for 2500

[PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy

2020-11-14 Thread Andreas Färber
Sascha Hauer Cc: David S. Miller Cc: Marek Behún Cc: Andrew Lunn Cc: Uwe Kleine-König Cc: Jason Cooper Cc: Gregory CLEMENT Signed-off-by: Andreas Färber --- drivers/net/ethernet/marvell/mvneta.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/m

[PATCH 1/2] rtw88: Fix probe error handling race with firmware loading

2020-09-20 Thread Andreas Färber
firmware if wowlan is supported"), so backports to earlier branches may need to inline wait_for_completion(&rtwdev->fw.completion) instead. Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver") Fixes: c8e5695eae99 ("rtw88: load wowlan firmware if wowlan is supported&q

[PATCH 2/2] rtw88: Fix potential probe error handling race with wow firmware loading

2020-09-20 Thread Andreas Färber
the loaded firmware. Fixes: c8e5695eae99 ("rtw88: load wowlan firmware if wowlan is supported") Cc: Chin-Yen Lee Cc: Yan-Hsuan Chuang Signed-off-by: Andreas Färber --- drivers/net/wireless/realtek/rtw88/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wirele

[PATCH 0/2] net: wireless: rtw88: Fix oops on probe errors

2020-09-20 Thread Andreas Färber
ead32() returning 0x values and causing rtw_mac_power_on() to fail. Cheers, Andreas Andreas Färber (2): rtw88: Fix probe error handling race with firmware loading rtw88: Fix potential probe error handling race with wow firmware loading drivers/net/wireless/realtek/rtw88/main.

Re: [RFC PATCH v2 0/5] net: lorawan: Refine the lorawan protocol module

2019-03-11 Thread Andreas Färber
Hi Jian-Hong, Am 31.01.19 um 17:21 schrieb Jian-Hong Pan: > This series refines the commit 48e5bb6cec79 ("net: Prepare LoRaWAN > socket module") for coding style. > Besides, sperates LoRaWAN related skb definitions from > lora/lorawan_netdev.h into another header lora/lorawan/skb.h. Sorry for the

Re: [RFC net-next 1/4] net: Reserve protocol identifiers for EnOcean

2019-02-17 Thread Andreas Färber
Hi Alex, Am 01.02.19 um 01:58 schrieb Alexander Aring: > On Wed, Jan 30, 2019 at 02:42:29AM +0100, Andreas Färber wrote: >> Am 29.01.19 um 13:57 schrieb Alexander Aring: >>> On Tue, Jan 29, 2019 at 06:01:27AM +0100, Andreas Färber wrote: >>>> EnOcean wireless technol

Re: [RFC net-next 1/4] net: Reserve protocol identifiers for EnOcean

2019-01-29 Thread Andreas Färber
Hi Alex, Am 29.01.19 um 13:57 schrieb Alexander Aring: > On Tue, Jan 29, 2019 at 06:01:27AM +0100, Andreas Färber wrote: >> EnOcean wireless technology is based on ASK (ERP1) and FSK (ERP2) modulations >> for sub-GHz and on IEEE 802.15.4 for 2.4 GHz. >> > > I am not s

[RFC net-next 2/4] net: Prepare EnOcean device drivers

2019-01-28 Thread Andreas Färber
Add net_device helpers for EnOcean. Signed-off-by: Andreas Färber --- drivers/net/enocean/Makefile | 2 + drivers/net/enocean/enocean.c | 124 ++ include/linux/enocean/dev.h | 23 3 files changed, 149 insertions(+) create mode 100644

[RFC net-next 1/4] net: Reserve protocol identifiers for EnOcean

2019-01-28 Thread Andreas Färber
EnOcean wireless technology is based on ASK (ERP1) and FSK (ERP2) modulations for sub-GHz and on IEEE 802.15.4 for 2.4 GHz. ARPHRD_ENOCEAN ETH_P_ERP{1,2} Signed-off-by: Andreas Färber --- include/uapi/linux/if_arp.h | 1 + include/uapi/linux/if_ether.h | 2 ++ 2 files changed, 3 insertions

[RFC net-next 4/4] net: enocean: Prepare ESP2 support

2019-01-28 Thread Andreas Färber
The EnOcean Serial Protocol 2 used subtelegram frames different from ESP3. It also uses ORG identifiers differing from RORG identifiers in ERP. Only checksumming has been tested. Signed-off-by: Andreas Färber --- drivers/net/enocean/Makefile | 1 + drivers/net/enocean/enocean_esp.c

[RFC net-next 3/4] net: enocean: Add ESP3 driver

2019-01-28 Thread Andreas Färber
This implements the EnOcean Serial Protocol 3. Rudimentary sending is prepared. Error handling is lacking and reception handling is missing. Tested with EnOcean TCM310 gateway module. Signed-off-by: Andreas Färber --- drivers/net/enocean/Makefile | 4 + drivers/net/enocean

[RFC net-next 0/4] net: EnOcean prototype driver

2019-01-28 Thread Andreas Färber
ml Only downside was that for lack of an include/uapi/linux/enocean.h header file I had to resort to a patch not included here to define ETH_P_ERP2 etc. for lack of obvious ways to prepend my own if_{ether,arp}.h files. Andreas Färber (4): net: Reserve protocol identifiers for EnOcean net:

Re: [RFC net-next] net: Z-Wave driver prototype

2019-01-21 Thread Andreas Färber
Hi, Am 20.01.19 um 19:56 schrieb Randy Dunlap: > On 1/20/19 10:33 AM, Andreas Färber wrote: >> Tested as external kernel module, so Kconfig/Makefile integration missing. [...] >> diff --git a/drivers/net/zwave/Makefile b/drivers/net/zwave/Makefile >> new file mode 100644

[RFC net-next] net: Z-Wave driver prototype

2019-01-20 Thread Andreas Färber
serial protocol, and it would not work with any tty based userspace applications. Cc: TL Lim Signed-off-by: Andreas Färber --- drivers/net/zwave/Makefile | 1 + drivers/net/zwave/zwave.c | 236 + 2 files changed, 237 insertions(+) create mode 100644 dr

Re: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

2019-01-17 Thread Andreas Färber
ters, so placement in file and tab-indentation is fine, too. > sifive SiFive, Inc. > sigmaSigma Designs, Inc. > sii Seiko Instruments, Inc. Personally I would drop the full stop at the end of the subject, but anyway: Reviewed-by: Andreas Färber Thanks, Andreas P.S. Plea

Re: [RFC PATCH 1/5] net: lorawan: Refine the coding style

2019-01-16 Thread Andreas Färber
Am 16.01.19 um 15:33 schrieb Jiri Pirko: > Wed, Jan 16, 2019 at 03:24:54PM CET, starni...@g.ncu.edu.tw wrote: >> Signed-off-by: Jian-Hong Pan >> --- > > Patches like this are in general frowned upon. Do one change in one > patch. Put some patch description. This patch simply shouldn't have gone

Re: [RFC PATCH 5/5] net: lorawan: Split skb definitions into another header

2019-01-16 Thread Andreas Färber
Am 16.01.19 um 15:36 schrieb Jiri Pirko: > Wed, Jan 16, 2019 at 03:25:02PM CET, starni...@g.ncu.edu.tw wrote: >> Split LoRaWAN related skb definitions from lora/lorawan_netdev.h into >> another header lora/lorawan_skb.h. > > What is the motivation for this change? I suggested it because skbs coul

Re: [PATCH lora-next 4/4] dt-bindings: lora: sx130x: add clock bindings

2019-01-11 Thread Andreas Färber
Am 08.01.19 um 09:41 schrieb Ben Whitten: > The sx130x family consumes two clocks, a 32MHz clock provided by a > connected IQ transceiver, and a 133MHz high speed clock. > > In the example we connect the concentrator to output 0 of a fixed clock > providing the 133MHz high speed clock, and we conn

Re: [PATCH lora-next 3/4] dt-bindings: lora: sx125x: add clock bindings

2019-01-11 Thread Andreas Färber
Am 08.01.19 um 09:41 schrieb Ben Whitten: > The sx125x consumes a 32MHz clock and if it is coupled with a sx130x > concentrator may also provide a gated version of this 32MHz for the > concentrator. "SX125x", "SX130x", "32 MHz" > > In the example we connect to output 0 of "txco" clock source. Th

Re: [PATCH lora-next 2/4] dt-bindings: lora: sx125x: add basic documentation

2019-01-11 Thread Andreas Färber
cetree/bindings/lora/semtech,sx125x.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/lora/semtech,sx125x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Semtech IQ modulator/de-m

Re: [PATCH lora-next 1/4] dt-bindings: lora: sx130x: add basic documentation

2019-01-11 Thread Andreas Färber
gt; @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/lora/semtech,sx130x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Semtech LoRa concentrator > + > +maintainers: &

Re: [RFC net-next 11/15] net: lora: Add IMST WiMOD

2019-01-07 Thread Andreas Färber
Hello Heinrich, + linux-lpwan, - other vendors Am 06.01.19 um 15:57 schrieb Heinrich Schuchardt: > On 7/1/18 1:08 PM, Andreas Färber wrote: >> The IMST WiMOD uses a SLIP based binary UART protocol. Two separate >> firmwares are available. By default it ships with a LoRaWAN f

[PATCH lora-next 00/11] net: lora: sx130x: Fixes for enabling regcache

2019-01-06 Thread Andreas Färber
ed to revert that commit from [1] again. Have a lot of fun! Cheers, Andreas [1] https://patchwork.ozlabs.org/cover/983168/ [2] https://patchwork.ozlabs.org/patch/983170/ Cc: Ben Whitten Cc: Mark Brown Cc: linux-lp...@lists.infradead.org Cc: netdev@vger.kernel.org Andreas Färber (11): net:

[PATCH lora-next 01/11] net: lora: sx125x: Abort on wrong version

2019-01-06 Thread Andreas Färber
This helps detect issues such as the concentrator being in reset. Enhance error output while at it. Signed-off-by: Andreas Färber --- drivers/net/lora/sx125x.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/lora/sx125x.c b/drivers/net/lora/sx125x.c index

[PATCH lora-next 03/11] net: lora: sx130x: Revert drop of sx1301_soft_reset()

2019-01-06 Thread Andreas Färber
Ben's regmap field conversion patch silently dropped my sx1301_soft_reset() helper. Soft reset is a special operation, so restore this function as sx130x_soft_reset(). To be squashed. Cc: Ben Whitten Signed-off-by: Andreas Färber --- drivers/net/lora/sx130x.c | 7 ++- 1 file chang

[PATCH lora-next 08/11] net: lora: sx130x: Force regmap field write before reading status

2019-01-06 Thread Andreas Färber
Ensure that the F_FORCE_HOST_RADIO_CTRL field gets written before we read the AGC status register. Otherwise it returns status 01 instead of 87. Cc: Ben Whitten Signed-off-by: Andreas Färber --- drivers/net/lora/sx130x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH lora-next 04/11] net: lora: sx130x: Fix soft reset

2019-01-06 Thread Andreas Färber
x27;t have a cache configured, this may return -EINVAL, so guard it appropriately to aid in testing. Cc: Ben Whitten Signed-off-by: Andreas Färber --- drivers/net/lora/sx130x.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/lora/sx130x.c b/driver

[PATCH lora-next 02/11] net: lora: sx130x: Fix error codes

2019-01-06 Thread Andreas Färber
Use of -ENXIO results in a misleading error message from ip command: RTNETLINK answers: No such device or address Switch to -EIO for more accurate description: RTNETLINK answers: Input/output error Signed-off-by: Andreas Färber --- drivers/net/lora/sx130x.c | 10 +- 1 file

[PATCH lora-next 09/11] net: lora: sx130x: Mark AGCSTS register as volatile

2019-01-06 Thread Andreas Färber
AGC status register reads should not be cached. Sort the volatile registers by number while at it. Cc: Ben Whitten Signed-off-by: Andreas Färber --- drivers/net/lora/sx130x.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/lora/sx130x.c b/drivers/net/lora

[PATCH lora-next 06/11] net: lora: sx130x: Force regmap field write before sleep

2019-01-06 Thread Andreas Färber
Ensure timing is as expected by forcing a register write before waiting on its outcome. Cc: Ben Whitten Signed-off-by: Andreas Färber --- drivers/net/lora/sx130x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/lora/sx130x.c b/drivers/net/lora/sx130x.c index

[PATCH lora-next 07/11] net: lora: sx130x: Force regmap field writes before function boundaries

2019-01-06 Thread Andreas Färber
As a cautionary step, force writing out registers before calling helpers or returning. Cc: Ben Whitten Signed-off-by: Andreas Färber --- drivers/net/lora/sx130x.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/lora/sx130x.c b/drivers/net/lora

[PATCH lora-next 05/11] net: lora: sx130x: Fix regmap field toggles

2019-01-06 Thread Andreas Färber
sx130x_field_write() static inline, too. Cc: Ben Whitten Signed-off-by: Andreas Färber --- drivers/net/lora/sx130x.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/lora/sx130x.c b/drivers/net/lora/sx130x.c index 4ba02836a35d..457f2396d9ee 100644 --- a

[PATCH lora-next 11/11] net: lora: sx130x: Enable regmap caching

2019-01-06 Thread Andreas Färber
To fix performance penalties compared to pre-regmap field code, enable caching. Note: This has been tested to not regress on spi-gpio, with no improvement on spi-sun6i for clk_prepare() locking issue. Cc: Ben Whitten Signed-off-by: Andreas Färber --- drivers/net/lora/sx130x.c | 2 +- 1 file

[PATCH lora-next 10/11] net: lora: sx130x: Mark MCU_CTRL register as volatile

2019-01-06 Thread Andreas Färber
For reasons as of yet unknown, this is necessary to unbreak ARB firmware version check. Cc: Ben Whitten Signed-off-by: Andreas Färber --- drivers/net/lora/sx130x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/lora/sx130x.c b/drivers/net/lora/sx130x.c index 8bdd343a273f

Re: [PATCH lora-next 3/5] net: lora: sx130x: Add PicoCell serdev driver

2019-01-04 Thread Andreas Färber
Am 04.01.19 um 12:21 schrieb Andreas Färber: > Currently there's still some bugs to be investigated, with communication > stalling on one device and another reading the radio versions wrong > (07 / 1f instead of 21, also observed on spi once). Reproducable 100% on SPI by setting R

Re: [PATCH lora-next 3/5] net: lora: sx130x: Add PicoCell serdev driver

2019-01-04 Thread Andreas Färber
Am 04.01.19 um 12:21 schrieb Andreas Färber: > diff --git a/drivers/net/lora/sx130x_picogw.c > b/drivers/net/lora/sx130x_picogw.c > new file mode 100644 > index ..577f9fb71d46 > --- /dev/null > +++ b/drivers/net/lora/sx130x_picogw.c [...] > + serdev_dev

Re: [RFC lora-next 5/5] HACK: net: lora: sx130x: Add PicoCell gateway shim for cdc-acm

2019-01-04 Thread Andreas Färber
Hi Rob, Am 04.01.19 um 18:07 schrieb Rob Herring: > On Fri, Jan 4, 2019 at 5:21 AM Andreas Färber wrote: >> >> Ignore our device in cdc-acm probing and add a new driver for it, >> dispatching to cdc-acm for the actual implementation. >> >> WARNING: It is likel

[PATCH lora-next 2/5] net: lora: sx130x: Prepare storing driver-specific data

2019-01-04 Thread Andreas Färber
s. Signed-off-by: Andreas Färber --- drivers/net/lora/sx130x.c | 19 +++ include/linux/lora/sx130x.h | 2 ++ 2 files changed, 21 insertions(+) diff --git a/drivers/net/lora/sx130x.c b/drivers/net/lora/sx130x.c index 840052955874..978c921ca5ec 100644 --- a/drivers/net/lora/sx13

[PATCH RFC lora-next 0/5] net: lora: sx130x: USB CDC Picocell Gateway serdev driver via fake DT nodes

2019-01-04 Thread Andreas Färber
el.org Cc: netdev@vger.kernel.org Andreas Färber (5): net: lora: sx130x: Factor out SPI specific parts net: lora: sx130x: Prepare storing driver-specific data net: lora: sx130x: Add PicoCell serdev driver usb: cdc-acm: Enable serdev support HACK: net: lora: sx130x: Add PicoCell gateway sh

[RFC lora-next 5/5] HACK: net: lora: sx130x: Add PicoCell gateway shim for cdc-acm

2019-01-04 Thread Andreas Färber
not have a parent yet. This results in two "Error -2 creating of_node link" warnings on probe. Cc: Johan Hovold Cc: Rob Herring Signed-off-by: Andreas Färber --- drivers/net/lora/Makefile | 2 + drivers/net/lora/picogw.c | 337 d

[PATCH lora-next 3/5] net: lora: sx130x: Add PicoCell serdev driver

2019-01-04 Thread Andreas Färber
"semtech,sx1257". Currently there's still some bugs to be investigated, with communication stalling on one device and another reading the radio versions wrong (07 / 1f instead of 21, also observed on spi once). Signed-off-by: Andreas Färber --- drivers/net/lora/Makefile| 2

[PATCH lora-next 1/5] net: lora: sx130x: Factor out SPI specific parts

2019-01-04 Thread Andreas Färber
-by: Andreas Färber --- drivers/net/lora/sx130x.c | 139 +++- include/linux/lora/sx130x.h | 7 +++ 2 files changed, 92 insertions(+), 54 deletions(-) diff --git a/drivers/net/lora/sx130x.c b/drivers/net/lora/sx130x.c index 9cae9cea195f..840052955874

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2019-01-01 Thread Andreas Färber
Am 31.12.18 um 23:56 schrieb Andreas Färber: > Am 31.12.18 um 18:50 schrieb Mark Brown: >> On Sun, Dec 30, 2018 at 11:55:46AM +0100, Andreas Färber wrote: >>> Given that observed symptoms were CPU stalls, workqueue hangs and RCU >>> problems, requiring a power-cycle to r

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2018-12-31 Thread Andreas Färber
Am 31.12.18 um 18:50 schrieb Mark Brown: > On Sun, Dec 30, 2018 at 11:55:46AM +0100, Andreas Färber wrote: >> Given that observed symptoms were CPU stalls, workqueue hangs and RCU >> problems, requiring a power-cycle to recover, I wonder whether we are >> running into some

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2018-12-31 Thread Andreas Färber
Am 30.12.18 um 11:55 schrieb Andreas Färber: > Am 29.12.18 um 21:16 schrieb Andreas Färber: >> `sudo ip link set lora2 up` froze my system, with both >> lora1 and lora2 being sx1301. [...] >> >> Investigating... > > I've bisected and confirmed that it was

Re: [PATCH RFC lora-next 4/4] net: lora: sx1301: introduce a lora frame for packet metadata

2018-12-30 Thread Andreas Färber
Hi Ben, Am 19.12.18 um 16:56 schrieb Ben Whitten: > Information such as spreading factor, coding rate and power are on a per > transmission basis so it makes sence to include this in a header much "sense" (even in British English! :)) > like CAN frames do. Any pointer for that? My understanding

Re: [PATCH RFC lora-next 3/4] net: lora: sx1301: add minimal to get transmission out

2018-12-30 Thread Andreas Färber
Am 19.12.18 um 16:56 schrieb Ben Whitten: > diff --git a/drivers/net/lora/sx1301.c b/drivers/net/lora/sx1301.c > index 0c7b6d0b31af..9bcbb967f307 100644 > --- a/drivers/net/lora/sx1301.c > +++ b/drivers/net/lora/sx1301.c > @@ -24,6 +24,44 @@ > > #include "sx1301.h" > > +struct sx1301_tx_header

[PATCH lora-next] net: lora: sx125x: Clean up clock provider

2018-12-30 Thread Andreas Färber
Use devm_ variant to have the clock provider deleted again. Signed-off-by: Andreas Färber --- drivers/net/lora/sx125x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/lora/sx125x.c b/drivers/net/lora/sx125x.c index 2c48301a12ab..68d8afed48ba 100644 --- a/drivers

[PATCH lora-next] net: lora: sx1301: Fix clk32m handling

2018-12-30 Thread Andreas Färber
We can't get the clk32m during probe because the radio is not yet probed then. When doing it during netdev open we also need to undo that during netdev stop. Revamp the error handling for open and tidy our debug output while at it. Signed-off-by: Andreas Färber --- drivers/net/lora/sx1

[PATCH lora-next] net: lora: sx125x: Add error handling for clock-output-names

2018-12-30 Thread Andreas Färber
From: Ben Whitten Split off from style changes. Signed-off-by: Ben Whitten Signed-off-by: Andreas Färber --- drivers/net/lora/sx125x.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/lora/sx125x.c b/drivers/net/lora/sx125x.c index b7ca782b9386

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2018-12-30 Thread Andreas Färber
+ linux-spi, LAKML Am 29.12.18 um 21:16 schrieb Andreas Färber: > Am 29.12.18 um 20:25 schrieb Andreas Färber: >> Am 12.10.18 um 18:26 schrieb Ben Whitten: >>> +static int sx125x_register_clock_provider(struct sx125x_priv *priv) >>> +{ >>> + struct dev

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2018-12-29 Thread Andreas Färber
Am 29.12.18 um 20:25 schrieb Andreas Färber: > Am 12.10.18 um 18:26 schrieb Ben Whitten: >> +static int sx125x_register_clock_provider(struct sx125x_priv *priv) >> +{ >> +struct device *dev = priv->dev; >> +struct clk_init_data init; >> +

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2018-12-29 Thread Andreas Färber
Hi Ben, + linux-lpwan, linux-clk, devicetree Am 12.10.18 um 18:26 schrieb Ben Whitten: > From: Ben Whitten > > The 32M is run from the radio, before we just enabled it based on > the radio number but now we can use the clk framework to request the > clk is started when we need it. > > The 32M

Re: [PATCH v5 1/6] net: lorawan: Add LoRaWAN socket module

2018-12-28 Thread Andreas Färber
Hi Jian-Hong, Am 16.12.18 um 11:18 schrieb Jian-Hong Pan: > This patch adds a new address/protocol family for LoRaWAN network. > It also implements the the functions and maps to Datagram socket for > LoRaWAN unconfirmed data messages. > > Signed-off-by: Jian-Hong Pan [...] > include/linux/lora/

Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig

2018-12-28 Thread Andreas Färber
Am 28.12.18 um 16:43 schrieb Alexander Aring: > On Fri, Dec 28, 2018 at 05:57:53AM +0100, Andreas Färber wrote: >> Am 24.12.18 um 16:32 schrieb Alexander Aring: >>> On Tue, Dec 18, 2018 at 02:50:58PM +0100, Xue Liu wrote: >>>> On Mon, 17 Dec 2018 at 15:19, Andreas Fä

Re: [PATCH RFC lora-next 2/4] net: lora: sx1301: add minimal to get AGC working prior to tx work

2018-12-28 Thread Andreas Färber
Hi Ben, Am 19.12.18 um 16:56 schrieb Ben Whitten: > As part of initialisation when opening the lora device after loading > the AGC firmware we need to satisfy its startup procedure which involves > a few steps; > > Loading a 16 entry lookup table. > For this I have hard coded the laird ETSI certi

Re: [PATCH RFC lora-next 1/4] net: lora: sx125x sx1301: correct style warnings

2018-12-28 Thread Andreas Färber
Hi Ben, Am 19.12.18 um 16:56 schrieb Ben Whitten: > Checkpatch highlights some style issues which need to be addressed. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx125x.c | 20 +-- > drivers/net/lora/sx1301.c | 52 ++- > drivers/net/

Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig

2018-12-27 Thread Andreas Färber
Hi Alexander and Xue Liu, Am 24.12.18 um 16:32 schrieb Alexander Aring: > On Tue, Dec 18, 2018 at 02:50:58PM +0100, Xue Liu wrote: >> On Mon, 17 Dec 2018 at 15:19, Andreas Färber wrote: >>> Am 17.12.18 um 09:50 schrieb Xue Liu: >>>> I have a question about the arch

Re: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module

2018-12-20 Thread Andreas Färber
Am 20.12.18 um 11:19 schrieb Ben Whitten: The hard-MAC implementations will be on my plate mostly, as both SX1276 and SX1301 need the soft-MAC. >>> >>> On the SX1301 side of things, the ability to send messages as a LoRaWAN >>> node device is a niche use case, the majority if not all peop

Re: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module

2018-12-18 Thread Andreas Färber
Am 18.12.18 um 15:27 schrieb Jian-Hong Pan: >> Sun, Dec 16, 2018 at 11:18:59AM CET, starni...@g.ncu.edu.tw wrote: >>> LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa devices. >>> >>> This patch implements part of Class A end-devices SoftMAC defined in >>> LoRaWAN(TM) Specification V

Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig

2018-12-17 Thread Andreas Färber
Hello Xue Liu, Am 17.12.18 um 09:50 schrieb Xue Liu: > I have a question about the architecture of your module. AFAIK LoRaWAN > is already the MAC Layer above the LoRa technology. Why do you want to > make a new layer called "maclorawan" ? I had asked Jian-Hong to separate between his soft-MAC im

Re: [PATCH v2 lora-next 1/4] net: lora: sx1301: convert burst spi functions to regmap raw

2018-10-10 Thread Andreas Färber
Hi Ben and Mark, Am 09.10.18 um 14:52 schrieb Ben Whitten: > As we have caching disabled we can access the regmap using raw for our > firmware reading and writing bursts. > We also remove the now defunct spi element from the structure as this > completes the move to regmap. > > Signed-off-by: Ben

Re: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-10 Thread Andreas Färber
Am 09.08.2018 um 15:23 schrieb Ben Whitten: >> BTW we'll need this regmap conversion for the picoGW_hal, >> so once we >> have a working SPI regmap driver, we'll need to split out the >> SPI bits, >> similar to sx125x. > > I am unfamiliar with the picoGW_hal, do they expose the sx1301 > as a devic

Re: [PATCH lora-next v2 8/8] net: lora: sx1301: convert driver over to regmap reads and writes

2018-08-09 Thread Andreas Färber
Am 10.08.2018 um 00:47 schrieb Ben Whitten: > On Thu, 9 Aug 2018 at 23:34, Andreas Färber wrote: >> Applying so that we can continue based on regmap. > > Thanks! Rebased onto latest linux-next, tested on RAK831 and pushed: https://git.kernel.org/pub/scm/linux/kernel/git/afaerber

Re: [PATCH lora-next v2 8/8] net: lora: sx1301: convert driver over to regmap reads and writes

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > The reads and writes are replaced with regmap versions and unneeded > functions, variable, and defines removed. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx1301.c | 204 > +++--- > drivers/net/lo

Re: [PATCH lora-next v2 7/8] net: lora: sx1301: add initial registration for regmap

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > The register and bit-field definitions are taken from the SX1301 > datasheet version 2.01 dated June 2014 with the revision information > 'First released version'. > > The reset state and RW capability of each field is not reflected in this > patch how

Re: [PATCH lora-next v2 3/8] net: lora: sx1301: convert to passing priv data throughout

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 23:06 schrieb Ben Whitten: > On Thu, 9 Aug 2018 at 21:43, Andreas Färber wrote: >> Am 09.08.2018 um 14:33 schrieb Ben Whitten: >>> @@ -654,22 +646,35 @@ static int sx1301_probe(struct spi_device *spi) >>> priv->rst_gpio = rst; &

Re: [PATCH lora-next v2 6/8] net: lora: sx1301: replace version and size magic numbers with defines

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > We replace the hard coded numbers for size and version with meaningful > names. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx1301.c | 21 + > drivers/net/lora/sx1301.h | 18 ++ > 2 files changed, 31 in

Re: [PATCH lora-next v2 5/8] net: lora: sx1301: remove duplicate firmware size checks

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > No need to check the size of the firmware multiple times, just do it once > in the function responsible for loading as the firmwares are the same size. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx1301.c | 21 +++-- > 1 f

Re: [PATCH lora-next v2 4/8] net: lora: sx1301: convert load_firmware to take firmware directly

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > We just pass the pointer to firmware down to the function that loads > it. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx1301.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Applied. Thanks, Andreas -- SUS

Re: [PATCH lora-next v2 3/8] net: lora: sx1301: convert to passing priv data throughout

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > Instead of passing around the spi device we instead pass around our > driver data directly. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx1301.c | 305 > +++--- > 1 file changed, 155 insertions(+),

Re: [PATCH lora-next v2 2/8] net: lora: sx1301: convert to devm registration of netdev

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > We allow the devres framework handle the clean removal of resources on > teardown of the device, in this case the SPI device, saving lengthy > unwind code and improving clarity. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx1301.c | 87 >

Re: [PATCH lora-next v2 1/8] net: lora: add methods for devm registration

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > Follow the devm model so that we can avoid lengthy unwind code. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/dev.c | 28 > include/linux/lora/dev.h | 1 + > 2 files changed, 29 insertions(+) > > diff --git

Re: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-08 Thread Andreas Färber
+ Xue Liu + Sebastian Am 08.08.2018 um 17:52 schrieb Ben Whitten: >> Subject: Re: [PATCH lora-next 01/10] net: lora: sx1301: add >> register, bit-fields, and helpers for regmap >> >> Am 08.08.2018 um 14:32 schrieb Ben Whitten: > drivers/net/lora/Kconfig | 1 + > drivers/net/lora/sx1301

Re: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-08 Thread Andreas Färber
Am 08.08.2018 um 14:32 schrieb Ben Whitten: >>> drivers/net/lora/Kconfig | 1 + >>> drivers/net/lora/sx1301.c | 282 >> +++--- >>> drivers/net/lora/sx1301.h | 169 >> +++ >>> 3 files changed, 439 insertions(+), 13 deletions(-) >>>

Re: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-08 Thread Andreas Färber
Am 07.08.2018 um 19:32 schrieb Ben Whitten: > diff --git a/drivers/net/lora/sx1301.c b/drivers/net/lora/sx1301.c > index 5342b61..49958f0 100644 > --- a/drivers/net/lora/sx1301.c > +++ b/drivers/net/lora/sx1301.c [...] > @@ -76,8 +287,29 @@ struct sx1301_priv { > struct gpio_desc *rst_gpio; >

Re: [PATCH lora-next 03/10] net: lora: sx1301: convert to devm registration of netdev

2018-08-08 Thread Andreas Färber
Am 07.08.2018 um 19:32 schrieb Ben Whitten: > diff --git a/drivers/net/lora/sx1301.c b/drivers/net/lora/sx1301.c > index 49958f0..54bfc31 100644 > --- a/drivers/net/lora/sx1301.c > +++ b/drivers/net/lora/sx1301.c [...] > @@ -885,7 +889,7 @@ static int sx1301_probe(struct spi_device *spi) > if

Re: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-08 Thread Andreas Färber
Am 07.08.2018 um 19:32 schrieb Ben Whitten: > From: Ben Whitten > > The register and bit-field definitions are taken from the SX1301 > datasheet version 2.01 dated June 2014 with the revision information > 'First released version'. > > The reset state and RW capability of each field is not refle

Re: [PATCH lora-next 02/10] net: lora: add methods for devm registration

2018-08-07 Thread Andreas Färber
Am 07.08.2018 um 19:32 schrieb Ben Whitten: > From: Ben Whitten > > Follow the devm model so that we can avoid lengthy unwind code. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/dev.c | 20 > include/linux/lora/dev.h | 1 + > 2 files changed, 21 insertions(+)

Re: [RFC] spi: add spi multiplexing functions for dt

2018-08-07 Thread Andreas Färber
Hi Ben, Am 07.08.2018 um 19:32 schrieb Ben Whitten: > Like I2C busses SPI devices can also sit behind multiplexers. > This patch adds is based off the I2C implementation and allows > description in the devicetree. > > Signed-off-by: Ben Whitten > --- > drivers/spi/Kconfig | 10 +++ > drive

brcmfmac firmware issue on NanoPi K2

2017-05-21 Thread Andreas Färber
Hello, The NanoPi K2 has an Ampak AP6212 SDIO module. brcmfmac driver loads brcmfmac43430-sdio.bin. When using the firmware file from linux-firmware.git that openSUSE ships I get the following errors on 4.11.0 and next-20170519: [ 2103.618716] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (10

Re: [PATCH 1/1] dt-binding: net: wireless: fix node name in the BCM43xx example

2017-05-21 Thread Andreas Färber
Am 15.05.2017 um 22:13 schrieb Martin Blumenstingl: > The example in the BCM43xx documentation uses "brcmf" as node name. No, it doesn't, it uses "bcrmf". This typo has spread to all ARM device trees: $ git grep bcrmf -- arch/arm/boot/dts/ arch/arm/boot/dts/imx6sx-nitrogen6sx.dts: brcmf: b

Re: [PATCH 1/1] dt-binding: net: wireless: fix node name in the BCM43xx example

2017-05-21 Thread Andreas Färber
Hi, Am 16.05.2017 um 21:56 schrieb Martin Blumenstingl: > On Tue, May 16, 2017 at 12:05 AM, Arend Van Spriel > wrote: >> On 15-5-2017 22:13, Martin Blumenstingl wrote: >>> The example in the BCM43xx documentation uses "brcmf" as node name. >>> However, wireless devices should be named "wifi" inst

Re: [PATCH v3 6/6] net: smmac: allow configuring lower pbl values

2016-12-08 Thread Andreas Färber
Hi, In subject: s/smmac/stmmac/ Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)

Re: [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable advertisement EEE for GbE.

2016-11-28 Thread Andreas Färber
Am 28.11.2016 um 10:46 schrieb Jerome Brunet: > Signed-off-by: Jerome Brunet > --- > arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 16 > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > b/arch/arm64/boot/dts/amlogic

Re: [PATCH net-next v3 1/4] net: phy: add an option to disable EEE advertisement

2016-11-28 Thread Andreas Färber
; drivers/net/phy/phy_device.c | 80 > +++- > include/linux/phy.h | 3 ++ > 3 files changed, 77 insertions(+), 9 deletions(-) Tested-by: Andreas Färber With this and the corresponding .dts change, Odroid-C2 survived a 317-package zypper update for me. Thanks

Re: [PATCH net-next v3 2/4] dt-bindings: net: add EEE capability constants

2016-11-28 Thread Andreas Färber
Am 28.11.2016 um 10:46 schrieb Jerome Brunet: > Signed-off-by: Jerome Brunet > --- > include/dt-bindings/net/mdio.h | 19 +++ > 1 file changed, 19 insertions(+) > create mode 100644 include/dt-bindings/net/mdio.h Tested-by: Andreas Färber Regards, Andreas --

Re: [PATCH net-next v3 3/4] dt: bindings: add ethernet phy eee-broken-modes option documentation

2016-11-28 Thread Andreas Färber
Am 28.11.2016 um 10:46 schrieb Jerome Brunet: > Signed-off-by: Jerome Brunet > --- > Documentation/devicetree/bindings/net/phy.txt | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Andreas Färber Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germa

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support

2016-11-27 Thread Andreas Färber
Andrew, Am 27.11.2016 um 23:08 schrieb Andrew Lunn: >>> This driver already supports nearly 30 different Marvell switch >>> models. Please document why the marvell,mv88e6176 is special and why >>> it needs its own compatible string when the others don't. >> >> I don't understand. > > Think about

[PATCH net-next] net: dsa: mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count

2016-11-27 Thread Andreas Färber
mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, so free the same amount. This will be 8 or 9 in practice, less than 16. Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.") Cc: Andrew Lunn Signed-off-by: Andreas Färber --- drivers/net/

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support

2016-11-27 Thread Andreas Färber
Am 27.11.2016 um 22:27 schrieb Andrew Lunn: > On Sun, Nov 27, 2016 at 09:57:59PM +0100, Andreas Färber wrote: >> This model is found on the Turris Omnia. > > This driver already supports nearly 30 different Marvell switch > models. Please document why the marvell,mv88e6176 is sp

Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count

2016-11-27 Thread Andreas Färber
Hi Andrew, Am 27.11.2016 um 22:22 schrieb Andrew Lunn: > On Sun, Nov 27, 2016 at 09:43:44PM +0100, Andreas Färber wrote: >> mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, >> so free the same amount. This will be 8 or 9 in practice, less than 16. >

[PATCH v2] MAINTAINERS: Add device tree bindings to mv88e6xx section

2016-11-27 Thread Andreas Färber
Also include the netdev list for convenience, as done elsewhere. Cc: Andrew Lunn Cc: Vivien Didelot Signed-off-by: Andreas Färber --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f73e19277a70..677d73cfedc7 100644 --- a/MAINTAINERS +++ b

[PATCH] MAINTAINERS: Add device tree bindings to mv88e6xx section

2016-11-27 Thread Andreas Färber
Also include the netdev list for convenience, as done elsewhere. Cc: Andrew Lunn Cc: Vivien Didelot Signed-off-by: Andreas Färber --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f73e19277a70..46ccf6eadcc9 100644 --- a/MAINTAINERS +++ b

[PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support

2016-11-27 Thread Andreas Färber
This model is found on the Turris Omnia. Signed-off-by: Andreas Färber --- drivers/net/dsa/mv88e6xxx/chip.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 77f13ada2612..95b9efb33ec7 100644 --- a/drivers/net/dsa

[PATCH 1/2] Documentation: net: dsa: marvell: Add 88E6176

2016-11-27 Thread Andreas Färber
Signed-off-by: Andreas Färber --- Documentation/devicetree/bindings/net/dsa/marvell.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt index b3dd6b40e0de..000bc3b16edd 100644 --- a

[PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count

2016-11-27 Thread Andreas Färber
mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, so free the same amount. This will be 8 or 9 in practice, less than 16. Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.") Cc: Andrew Lunn Signed-off-by: Andreas Färber --- drivers/net/

Re: stmmac/RTL8211F/Meson GXBB: TX throughput problems

2016-11-14 Thread Andreas Färber
Hi, Am 07.11.2016 um 18:37 schrieb Martin Blumenstingl: > The same problem still appears on my Tronsmart Vega S95 Meta even with > the patched PHY driver. > > Unfortunately I don't have a second device to rule out that my > Tronsmart Vega S95 Meta could be broken (not unlikely, I get DDR > errors

Re: [PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.

2016-03-19 Thread Andreas Färber
Hi, Am 11.03.2016 um 18:53 schrieb David Daney: > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > index 40faec9..075a4cc 100644 > --- a/drivers/net/phy/Kconfig > +++ b/drivers/net/phy/Kconfig > @@ -196,6 +196,17 @@ config MDIO_OCTEON > buses. It is required by the Octeon a

  1   2   >