#x27;t
> immediately see that problem here.
>
> Fixes: 71d0ed7079df ("net/act_pedit: Support using offset relative to the
> conventional network headers")
> Signed-off-by: Dan Carpenter
>
You are right, it was intended to be -EINVAL. Thanks.
Acked-by: Amir Vadai
Do not allow using eth and udp header types if non-extended pedit kABI
is being used. Other protocol parsers already have this check.
Signed-off-by: Amir Vadai
---
tc/p_eth.c | 3 +++
tc/p_udp.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/tc/p_eth.c b/tc/p_eth.c
index ad3e28f80eb6
Using retain for fields longer than 32 bits is not supported.
Do not allow user to do it.
Signed-off-by: Amir Vadai
---
man/man8/tc-pedit.8 | 3 ++-
tc/m_pedit.c| 6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/man/man8/tc-pedit.8 b/man/man8/tc-pedit.8
index
'ex' attribute should be placed after 'action pedit' and not after
'munge'.
Signed-off-by: Amir Vadai
---
tc/m_pedit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/m_pedit.c b/tc/m_pedit.c
index 6498dd91b471..7ef2acc52bce 100644
--- a/t
Add support for modifying IPv6 headers using pedit.
Signed-off-by: Amir Vadai
---
man/man8/tc-pedit.8 | 30 ++
tc/Makefile | 1 +
tc/m_pedit.c| 43 +++--
tc/p_ip.c | 17 +-
tc/p_ip6.c | 91
nly) that are out of the scope of this patchset. So I
added a
patch to prevent the user from using retain on those fields.
Thanks,
Amir
Amir Vadai (4):
pedit: Fix a typo in warning
pedit: Do not allow using retain for too big fields
pedit: Check for extended capability in p
On Mon, May 01, 2017 at 09:26:25AM -0700, Stephen Hemminger wrote:
> On Sun, 23 Apr 2017 15:53:48 +0300
> Amir Vadai wrote:
>
> > Hi Stephen,
> >
> > This patchset extends pedit to support modifying a field in an offset
> > relative
> > to the conventio
On Sun, Apr 23, 2017 at 01:44:51PM -0400, Jamal Hadi Salim wrote:
>
> Thanks for the excellent work.
>
> On 17-04-23 08:53 AM, Amir Vadai wrote:
> > This command could be useful to increase/decrease fields value.
> >
>
> Does this contradict the "retain&quo
\
redirect dev veth0
Signed-off-by: Or Gerlitz
Signed-off-by: Amir Vadai
---
man/man8/tc-pedit.8 | 18 ++
tc/p_udp.c | 27 +++
2 files changed, 45 insertions(+)
diff --git a/man/man8/tc-pedit.8 b/man/man8/tc-pedit.8
index ad1929592660
veth0
Signed-off-by: Amir Vadai
---
man/man8/tc-pedit.8 | 23 +++
tc/p_tcp.c | 37 +
2 files changed, 60 insertions(+)
diff --git a/man/man8/tc-pedit.8 b/man/man8/tc-pedit.8
index 8febdfe23f6e..ad1929592660 100644
--- a/man/man8/tc
Make parse_val() accept fields up to 128 bits long, this should be
enough for current use cases and involves a minimal change to code.
Signed-off-by: Amir Vadai
---
tc/m_pedit.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/tc/m_pedit.c b/tc/m_pedit.c
index
veth0
Signed-off-by: Amir Vadai
---
man/man8/tc-pedit.8 | 24 ++
tc/Makefile | 1 +
tc/m_pedit.c| 46 ++
tc/m_pedit.h| 1 +
tc/p_eth.c | 72 +
5 files changed, 144
ntional network headers")
Amir Vadai (7):
tc/pedit: Fix a typo in pedit usage message
tc/pedit: Extend pedit to specify offset relative to mac/transport
headers
tc/pedit: Introduce 'add' operation
tc/pedit: p_ip: introduce editing ttl header
tc/pedit: Support fields
dev veth0
Signed-off-by: Amir Vadai
---
man/man8/tc-pedit.8 | 17 +
tc/p_ip.c | 6 ++
2 files changed, 23 insertions(+)
diff --git a/man/man8/tc-pedit.8 b/man/man8/tc-pedit.8
index 6bba741956f1..c98d95cb0021 100644
--- a/man/man8/tc-pedit.8
+++ b/man/man8/tc-pedit.8
This command could be useful to increase/decrease fields value.
Signed-off-by: Amir Vadai
---
man/man8/tc-pedit.8 | 13 -
tc/m_pedit.c| 18 +++---
2 files changed, 27 insertions(+), 4 deletions(-)
diff --git a/man/man8/tc-pedit.8 b/man/man8/tc-pedit.8
index
;munge'.
e.g:
$ tc filter add dev ens9 protocol ip parent : \
flower \
ip_proto udp \
dst_port 80 \
action pedit ex munge \
ip dst set 1.1.1.1 \
pipe \
action mirred egress redirect dev veth0
Signed-off-by: Amir Vadai
---
man/man8/tc-pedit.8
Signed-off-by: Amir Vadai
---
tc/m_pedit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/m_pedit.c b/tc/m_pedit.c
index 8e9bf0720dfe..939a6a1455a5 100644
--- a/tc/m_pedit.c
+++ b/tc/m_pedit.c
@@ -40,7 +40,7 @@ static void explain(void)
"\t:= [ATC]
Introduce skb_mac_offset() that could be used to get mac header offset.
Signed-off-by: Amir Vadai
Reviewed-by: Or Gerlitz
---
include/linux/skbuff.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index c6a78e1892b6..a1b73b794a38 100644
modifying
the destination port to 8080.
Signed-off-by: Amir Vadai
Reviewed-by: Or Gerlitz
---
include/net/tc_act/tc_pedit.h| 5 +
include/uapi/linux/tc_act/tc_pedit.h | 23
net/sched/act_pedit.c| 196 ---
3 files changed, 208 in
planned to be used by hardware drivers to offload the action.
Amir Vadai (3):
net/skbuff: Introduce skb_mac_offset()
net/act_pedit: Support using offset relative to the conventional
network headers
net/act_pedit: Introduce 'add' operation
include/linux/skbuff.h
above, adding 0xff to this u8 field is actually
decreasing it by one, since the operation is masked.
Signed-off-by: Amir Vadai
Reviewed-by: Or Gerlitz
---
include/net/tc_act/tc_pedit.h| 1 +
include/uapi/linux/tc_act/tc_pedit.h | 8
net/sched/act_pedit.c| 30
On Fri, Jan 06, 2017 at 08:51:09PM -0500, David Miller wrote:
> From: Amir Vadai
> Date: Thu, 5 Jan 2017 11:54:51 +0200
>
> > Enhancing the UAPI to allow for specifying that would allow the same
> > flows to be set into both SW and HW.
>
> This is actually not bac
On Thu, Jan 05, 2017 at 12:54:14PM +0100, Jiri Benc wrote:
> On Thu, 5 Jan 2017 11:54:51 +0200, Amir Vadai wrote:
> > You asked me [1] why did I use specific header names instead of layers (L2,
> > L3...),
> > and I explained that it is on purpose, this extra information
: \
flower ip_proto tcp \
action pedit munge ip ttl add 0xff pipe \
action mirred egress redirect dev veth0
In the example above, adding 0xff to this u8 field is actually
decreasing it by one, since the operation is masked.
Signed-off-by: Amir Vadai
Reviewed-by: Or Gerlitz
---
include/uapi
t.org/av42/iproute2.git
branch: pedit
Patchset was tested and applied on top of upstream commit 57ea884b0dcf
("packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode")
Thanks,
Amir
Amir Vadai (3):
net/skbuff: Introduce skb_mac_offset()
net/act_pedit: Support using of
tcp dport set 8080 pipe \
action mirred egress redirect dev veth0
Will forward tcp port whose original dest port is 80, while modifying
the destination port to 8080.
Signed-off-by: Amir Vadai
Reviewed-by: Or Gerlitz
---
include/uapi/linux/tc_act/tc_pedit.h | 17 ++
net/sched/act_pedi
Introduce skb_mac_offset() that could be used to get mac header offset.
Signed-off-by: Amir Vadai
Reviewed-by: Or Gerlitz
---
include/linux/skbuff.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index b53c0cfd417e..3d8f81f39c2b 100644
ct_tunnel: Introduce ip tunnel action") commit log
and the man page tc-tunnel_key to reflect the fact that 'unset'
operation is
no mandatory.
And describe when it might be needed.
- Rename the 'release' operation to 'unset'
Amir Vadai (3):
libnet
id 11 \
action mirred egress redirect dev vxlan0
Signed-off-by: Amir Vadai
---
include/linux/tc_act/tc_tunnel_key.h | 42 ++
man/man8/tc-tunnel_key.8 | 112 +++
tc/Makefile | 1 +
tc/m_tunnel_key.c| 258 +
11.11.1 \
action mirred egress redirect dev vnet0
Signed-off-by: Amir Vadai
---
man/man8/tc-flower.8 | 17 ++-
tc/f_flower.c| 82 ++--
2 files changed, 95 insertions(+), 4 deletions(-)
diff --git a/man/man8/tc-flower.8 b/man/ma
Add the utility functions rta_getattr_be16() and rta_getattr_be32(), and
change existing code to use it.
Signed-off-by: Amir Vadai
---
bridge/fdb.c | 4 ++--
include/libnetlink.h | 9 +
ip/iplink_geneve.c | 2 +-
ip/iplink_vxlan.c| 2 +-
tc/f_flower.c| 2 +-
5
On Thu, Dec 01, 2016 at 02:41:14PM -0500, David Miller wrote:
> From: Amir Vadai
> Date: Wed, 30 Nov 2016 11:09:27 +0200
>
> > @@ -119,18 +119,45 @@ static bool offset_valid(struct sk_buff *skb, int
> > offset)
> > return true;
> > }
> >
>
11.11.1 \
action mirred egress redirect dev vnet0
Signed-off-by: Amir Vadai
---
man/man8/tc-flower.8 | 17 ++-
tc/f_flower.c| 84 +---
2 files changed, 96 insertions(+), 5 deletions(-)
diff --git a/man/man8/tc-flower.8 b/man/ma
he fact that 'unset'
operation is
no mandatory.
And describe when it might be needed.
- Rename the 'release' operation to 'unset'
Amir Vadai (3):
libnetlink: Introduce rta_getattr_be*()
tc/cls_flower: Classify packet in ip tunnels
tc/act_tunnel
Add the utility functions rta_getattr_be16() and rta_getattr_be32(), and
change existing code to use it.
Signed-off-by: Amir Vadai
---
bridge/fdb.c | 4 ++--
include/libnetlink.h | 9 +
ip/iplink_geneve.c | 2 +-
ip/iplink_vxlan.c| 2 +-
4 files changed, 13 insertions
id 11 \
action mirred egress redirect dev vxlan0
Signed-off-by: Amir Vadai
---
include/linux/tc_act/tc_tunnel_key.h | 42 ++
man/man8/tc-tunnel_key.8 | 112 +++
tc/Makefile | 1 +
tc/m_tunnel_key.c| 258 +
On Wed, Nov 30, 2016 at 03:44:53PM +0100, Jiri Benc wrote:
> On Wed, 30 Nov 2016 09:38:40 +0200, Amir Vadai wrote:
> > +The
> > +.I UNSET
> > +mode is optional - even without using it, the metadata information will be
> > +released automatically when packet processing
dit munge tcp dport set 8080 pipe \
action mirred egress redirect dev veth0
Will forward traffic to tcp port 80, and modify the destination port to
8080.
hange-Id: Ibd7bbbe0b8c2f6adae0591868bb6892c55e75732
Signed-off-by: Amir Vadai
---
include/uapi/linux/tc_act/tc_pedit.h | 17 ++
above, adding 0xff to this u8 field is actually
decreasing it by one, since the operation is masked.
Signed-off-by: Amir Vadai
---
include/uapi/linux/tc_act/tc_pedit.h | 10 ++
net/sched/act_pedit.c| 16 +++-
2 files changed, 25 insertions(+), 1 deletion(-)
diff
] on top of commit 93ba5504 ("hv_netvsc:
remove excessive logging on MTU change").
[1] - 95c2027bfeda ("net/sched: pedit: make sure that offset is valid")
[2] - git: https://bitbucket.org/av42/iproute2.git
branch: pedit
Thanks,
Amir
Amir Vadai (3):
net/skbuff: Intro
Introduce skb_mac_offset() that could be used to get mac header offset.
Signed-off-by: Amir Vadai
---
include/linux/skbuff.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 9c535fbccf2c..395eb5111df0 100644
--- a/include/linux
11.11.1 \
action mirred egress redirect dev vnet0
Signed-off-by: Amir Vadai
---
man/man8/tc-flower.8 | 17 ++-
tc/f_flower.c| 84 +---
2 files changed, 96 insertions(+), 5 deletions(-)
diff --git a/man/man8/tc-flower.8 b/man/ma
id 11 \
action mirred egress redirect dev vxlan0
Signed-off-by: Amir Vadai
---
include/linux/tc_act/tc_tunnel_key.h | 42 ++
man/man8/tc-tunnel_key.8 | 113 +++
tc/Makefile | 1 +
tc/m_tunnel_key.c| 258 +
t be needed.
- Rename the 'release' operation to 'unset'
Amir Vadai (3):
libnetlink: Introduce rta_getattr_be*()
tc/cls_flower: Classify packet in ip tunnels
tc/act_tunnel: Introduce ip tunnel action
bridge/fdb.c | 4 +-
include/libnetlink.h
Add the utility functions rta_getattr_be16() and rta_getattr_be32(), and
change existing code to use it.
Signed-off-by: Amir Vadai
---
bridge/fdb.c | 4 ++--
include/libnetlink.h | 9 +
ip/iplink_geneve.c | 2 +-
ip/iplink_vxlan.c| 2 +-
4 files changed, 13 insertions
On Wed, Nov 30, 2016 at 9:17 AM, Amir Vadai wrote:
> On Tue, Nov 29, 2016 at 07:26:58PM -0800, Stephen Hemminger wrote:
(Sending again since I just discovered that Google Inbox is adding an
HTML part...)
>> The overall design is fine, just a couple nits with the code.
>>
>&
On Tue, Nov 29, 2016 at 07:26:58PM -0800, Stephen Hemminger wrote:
> The overall design is fine, just a couple nits with the code.
>
> > diff --git a/tc/f_flower.c b/tc/f_flower.c
> > index 2d31d1aa832d..1cf0750b5b83 100644
> > --- a/tc/f_flower.c
> > +++ b/tc/f_flower.c
>
> >
> > +static int f
field.
Please use bottom posting when replying to mails...
>
> On Tue, Nov 29, 2016 at 3:14 PM, Amir Vadai wrote:
> > On Tue, Nov 29, 2016 at 10:32:05AM +0800, zhuyj wrote:
> >> + if (offset > 0 && offset > skb->len)
> >>
> >> off
ff...>10
>
> On Mon, Nov 28, 2016 at 6:56 PM, Amir Vadai wrote:
> > Add a validation function to make sure offset is valid:
> > 1. Not below skb head (could happen when offset is negative).
> > 2. Validate both 'offset' and 'at'.
> >
gt; flag")
> Signed-off-by: Jiri Pirko
> ---
Reviewed-by: Amir Vadai
id 11 \
action mirred egress redirect dev vxlan0
Signed-off-by: Amir Vadai
---
include/linux/tc_act/tc_tunnel_key.h | 42 ++
man/man8/tc-tunnel_key.8 | 113 +++
tc/Makefile | 1 +
tc/m_tunnel_key.c| 259 +
11.11.1 \
action mirred egress redirect dev vnet0
Signed-off-by: Amir Vadai
---
man/man8/tc-flower.8 | 17 ++-
tc/f_flower.c| 85 ++--
2 files changed, 98 insertions(+), 4 deletions(-)
diff --git a/man/man8/tc-flower.8 b/man/ma
on") commit log
and the man page tc-tunnel_key to reflect the fact that 'unset'
operation is
no mandatory.
And describe when it might be needed.
- Rename the 'release' operation to 'unset'
Amir Vadai (2):
tc/cls_flower: Classify packet in
Add a validation function to make sure offset is valid:
1. Not below skb head (could happen when offset is negative).
2. Validate both 'offset' and 'at'.
Signed-off-by: Amir Vadai
---
Hi Dave,
Please pull to -stable branches.
Changes from V0:
- Add a validation to the
On Mon, Nov 28, 2016 at 12:49:36AM -0500, David Miller wrote:
> From: Cong Wang
> Date: Sun, 27 Nov 2016 21:39:33 -0800
>
> > On Sun, Nov 27, 2016 at 7:58 AM, Amir Vadai wrote:
> >> Should not allow setting a negative offset that goes below the skb head.
> > .
Should not allow setting a negative offset that goes below the skb head.
Signed-off-by: Amir Vadai
---
Hi Dave,
Please pull to -stable branches.
Thanks,
Amir
net/sched/act_pedit.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/sched/act_pedit.c b/net/sched
On Thu, Nov 24, 2016 at 04:33:55PM +0100, Jiri Benc wrote:
> On Thu, 24 Nov 2016 17:06:33 +0200, Amir Vadai wrote:
> > So you mean to just unconditionally call skb_dst_drop() from
> > act_mirred()?
>
> That's one option. Or just leave the dst there, it shouldn't m
On Thu, Nov 24, 2016 at 02:38:56PM +0100, Jiri Benc wrote:
> On Mon, 21 Nov 2016 12:20:54 +0200, Amir Vadai wrote:
> > $ tc filter add dev vxlan0 protocol ip parent : \
> > flower \
> > enc_src_ip 11.11.0.2 \
> > enc_dst_ip 11.11.0.1 \
> >
On Mon, Nov 21, 2016 at 11:50:03PM +, Rosen, Rami wrote:
> Hi, Amir,
>
> Following are three minor comments:
>
> Seems that TCA_TUNNEL_KEY_PAD used anywhere:
I assume you ment that it is _NOT_ used anywhere:
This attribute type is used in the kernel side only - for padding 64bit
attributes. T
enc_key_id 11 \
dst_ip 11.11.11.1 \
action tunnel_key release \
action mirred egress redirect dev vnet0
The action tunnel_key, will be introduced in the next patch in this
series.
Signed-off-by: Amir Vadai
---
man/man8/tc-flower.8 | 17 ++-
tc/f_
f: \
flower \
ip_proto 1 \
dst_ip 11.11.11.2 \
action tunnel_key set \
src_ip 11.11.0.1 \
dst_ip 11.11.0.2 \
id 11 \
action mirred egress redirect dev vxlan0
Signed-off-by: Amir Vadai
---
include/linux/tc_act/tc_tunnel_key.h | 42 ++
man/man8/
dst_ip 11.11.11.2 \
action tunnel_key set \
src_ip 11.11.0.1 \
dst_ip 11.11.0.2 \
id 11 \
action mirred egress redirect dev vxlan0
[1] - d1ba24feb466 ("Merge branch 'act_tunnel_key'")
Thanks,
Amir
Amir Vadai (2):
tc/cls_flower: Classify packet
t; skb->vlan_tci")
>> Signed-off-by: Eric Garver
>
> Dave,
>
> Hadar is OOO and I have asked Amir to look on the fix, will appreciate
> if we can have 24 hours to respond
>
> Or.
Reviewed and tested.
Acked-by: Amir Vadai
#x27;)
> Signed-off-by: Hadar Hen Zion
> ---
Acked-by: Amir Vadai
On Tue, Aug 30, 2016 at 08:05:03AM -0400, Jamal Hadi Salim wrote:
> On 16-08-30 07:03 AM, Amir Vadai wrote:
> > On Sun, Aug 28, 2016 at 10:04:21PM -0700, Cong Wang wrote:
> > > On Fri, Aug 26, 2016 at 12:16 PM, Eric Dumazet
> > > wrote:
> > > > On Fri, 201
On Tue, Aug 30, 2016 at 02:03:08PM +0300, Amir Vadai wrote:
> On Sun, Aug 28, 2016 at 10:04:21PM -0700, Cong Wang wrote:
> > On Fri, Aug 26, 2016 at 12:16 PM, Eric Dumazet
> > wrote:
> > > On Fri, 2016-08-26 at 11:26 -0700, Cong Wang wrote:
> > >> 1) Currentl
On Sun, Aug 28, 2016 at 10:04:21PM -0700, Cong Wang wrote:
> On Fri, Aug 26, 2016 at 12:16 PM, Eric Dumazet wrote:
> > On Fri, 2016-08-26 at 11:26 -0700, Cong Wang wrote:
> >> 1) Currently there are only a few actions using lockless, and they are
> >> questionable, as we already discussed before,
id 11 \
dst_ip 11.11.11.1 \
action tunnel_key release \
action mirred egress redirect dev vnet0
The action tunnel_key, will be introduced in the next patch in this series.
Signed-off-by: Amir Vadai
---
include/uapi/linux/pkt_cls.h | 11 ++
net/sched/cls
Extract _ip_tun_rx_dst() and _ipv6_tun_rx_dst() out of ip_tun_rx_dst()
and ipv6_tun_rx_dst(), to be used without supplying an skb.
Signed-off-by: Amir Vadai
---
include/net/dst_metadata.h | 45 -
1 file changed, 32 insertions(+), 13 deletions(-)
diff
f: \
flower \
ip_proto 1 \
dst_ip 11.11.11.2 \
action tunnel_key set\
src_ip 11.11.0.1 \
dst_ip 11.11.0.2 \
id 11 \
action mirred egress redirect dev vxlan0
Signed-off-by: Amir Vadai
---
include/net/tc_act/tc_tunnel_key.h| 25 +++
include/ua
rove grep-ability of code
- Reuse code from ip_tun_rx_dst() and ipv6_tun_rx_dst()
Changes from RFC:
- Add a new action instead of making mirred too complex
- No need to specify UDP port in action - it is already in the tunnel device
configuration
- Added a decap operation to drop tunnel metad
Add utility functions to convert a 32 bits key into a 64 bits tunnel and
vice versa.
These functions will be used instead of cloning code in GRE and VXLAN,
and in tc act_iptunnel which will be introduced in a following patch in
this patchset.
Signed-off-by: Amir Vadai
---
drivers/net/vxlan.c
On Tue, Aug 23, 2016 at 08:37:07AM -0400, Jamal Hadi Salim wrote:
> On 16-08-22 10:38 AM, Amir Vadai wrote:
> > This action could be used before redirecting packets to a shared tunnel
> > device, or when redirecting packets arriving from a such a device
> >
> >
On Tue, Aug 23, 2016 at 05:33:49PM +0200, Jiri Benc wrote:
> On Tue, 23 Aug 2016 18:28:05 +0300, Amir Vadai wrote:
> > On Mon, Aug 22, 2016 at 08:51:37PM +0200, Jiri Benc wrote:
> > > 2. We may run into problems like tx path seeing the metadata_dst that
> > >it
On Mon, Aug 22, 2016 at 08:51:37PM +0200, Jiri Benc wrote:
> On Mon, 22 Aug 2016 21:15:41 +0300, Or Gerlitz wrote:
> > Jiri B > I understand the motivation for the decap action. However, what
> > would
> > Jiri B > happen if someone does not include it?
> >
> > The MD set by the (say) vxlan devic
On Mon, Aug 22, 2016 at 03:23:45PM -0700, Tom Herbert wrote:
> On Mon, Aug 22, 2016 at 7:38 AM, Amir Vadai wrote:
> > Hi,
> >
> > This patchset introduces iptunnel support using the TC subsystem.
> >
> > In the decap flow, it enables the user to redirect
On Mon, Aug 22, 2016 at 08:57:06PM +0300, Shmulik Ladkani wrote:
> Hi,
>
> On Mon, 22 Aug 2016 17:38:34 +0300 Amir Vadai wrote:
> > +static struct metadata_dst *iptunnel_alloc(struct tcf_iptunnel *t,
> > + __be3
On Mon, Aug 22, 2016 at 07:00:27PM +0200, Jiri Benc wrote:
> While cleaning this up, you may as well take the best of both
> implementations.
>
> On Mon, 22 Aug 2016 17:38:32 +0300, Amir Vadai wrote:
> > +static inline __be64 key32_to_tunnel_id(__be32 key)
> > +{
f: \
flower \
ip_proto 1 \
dst_ip 11.11.11.2 \
action iptunnel encap \
src_ip 11.11.0.1 \
dst_ip 11.11.0.2 \
id 11 \
action mirred egress redirect dev vxlan0
Signed-off-by: Amir Vadai
---
include/net/tc_act/tc_iptunnel.h| 24 +++
include/uapi/linux/tc_ac
.
Amir
Changes from RFC:
- Add a new action instead of making mirred too complex
- No need to specify UDP port in action - it is already in the tunnel device
configuration
- Added a decap operation to drop tunnel metadata
Amir Vadai (3):
net/ip_tunnels: Introduce tunnel_id_to_key32() and
Add utility functions to convert a 32 bits key into a 64 bits tunnel and
vice versa.
These functions will be used instead of cloning code in GRE and VXLAN,
and in tc act_iptunnel which will be introduced in a following patch in
this patchset.
Signed-off-by: Amir Vadai
---
drivers/net/vxlan.c
id 11 \
dst_ip 11.11.11.1 \
action iptunnel decap \
action mirred egress redirect dev vnet0
The action iptunnel, will be introduced in the next patch in this
series.
Signed-off-by: Amir Vadai
---
include/uapi/linux/pkt_cls.h | 11 +
net/sched/cls
On Mon, Aug 15, 2016 at 02:34:00PM +0200, Jiri Pirko wrote:
> Mon, Aug 15, 2016 at 12:08:10PM CEST, j...@mojatatu.com wrote:
> >On 16-08-15 05:08 AM, Amir Vadai wrote:
> >> On Mon, Aug 15, 2016 at 11:17:40AM +0300, Amir Vadai wrote:
> >> > On Mon, Aug 15, 2016 at 09:1
On Mon, Aug 15, 2016 at 06:41:14AM -0400, Jamal Hadi Salim wrote:
> On 16-08-15 06:24 AM, Shmulik Ladkani wrote:
> > On Mon, 15 Aug 2016 06:08:10 -0400, j...@mojatatu.com wrote:
>
> > > Assuming $VXLAN is actually not a linux netdev of type vxlan?
> > > then the action does vxlan encap redirect se
On Mon, Aug 15, 2016 at 12:50:39PM +0300, Shmulik Ladkani wrote:
> On Mon, 15 Aug 2016 12:08:04 +0300, a...@vadai.me wrote:
> >
> > Any objection to the following?
> >
> > # ENCAP rule
> > tc filter add dev $ETH protocol ip parent : prio 10 \
> > flower ip_proto 1 \
> >
On Mon, Aug 15, 2016 at 11:17:40AM +0300, Amir Vadai wrote:
> On Mon, Aug 15, 2016 at 09:11:22AM +0200, Jiri Pirko wrote:
> > Sun, Aug 14, 2016 at 07:53:30PM CEST, xiyou.wangc...@gmail.com wrote:
> > >On Sun, Aug 14, 2016 at 7:06 AM, Amir Vadai wrote:
> > >>
On Mon, Aug 15, 2016 at 09:11:22AM +0200, Jiri Pirko wrote:
> Sun, Aug 14, 2016 at 07:53:30PM CEST, xiyou.wangc...@gmail.com wrote:
> >On Sun, Aug 14, 2016 at 7:06 AM, Amir Vadai wrote:
> >> tc qdisc add dev $ETH ingress
> >>
> >> # ENCAP rule for ARP
> &
From: Amir Vadai >
Signed-off-by: Amir Vadai >
---
include/net/tc_act/tc_mirred.h| 5 +++
include/uapi/linux/tc_act/tc_mirred.h | 7
net/sched/act_mirred.c| 79 +++
3 files changed, 91 insertions(+)
diff --git a/include/net/
From: Amir Vadai >
Signed-off-by: Amir Vadai >
---
include/uapi/linux/pkt_cls.h | 11 +
net/sched/cls_flower.c | 53
2 files changed, 64 insertions(+)
diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h
From: Amir Vadai >
Hi,
I would like to make it possible to manage VXLAN encap/decap using the flower
classifier, mirred action and vxlan device.
In order to make the solution scaleable, I'm using a shared vxlan device, with
encapsulation information packed in the metadata - by the mirre
On Mon, Aug 8, 2016 at 11:46 PM, Cong Wang wrote:
> As pointed out by Jamal, an action could be shared by
> multiple filters, so we can't use list to chain them
> any more after we get rid of the original tc_action.
> Instead, we could just save pointers to these actions
> in tcf_exts, since they
On Mon, Aug 08, 2016 at 01:46:47PM -0700, Cong Wang wrote:
> It is harmless because all users pass 'a' to this macro.
>
> Fixes: 00175aec941e ("net/sched: Macro instead of CONFIG_NET_CLS_ACT ifdef")
> Cc: Amir Vadai
> Signed-off-by: Cong Wang
> ---
Acked-by: Amir Vadai
Thanks Cong.
From: Amir Vadai
On devices that support TC flower offloads, these flags enable a filter to be
added only to HW or only to SW. skip_sw and skip_hw are mutually exclusive
flags. By default without any flags, the filter is added to both HW and SW,
but no error checks are done in case of failure to
From: Amir Vadai
When skip_sw is set and hardware fails to apply filter, return error to
user. This will make error propagation logic similar to the one
currently used in u32 classifier.
Also, changed code to use tc_skip_sw() utility function.
Signed-off-by: Amir Vadai
---
net/sched
On Mon, Jun 13, 2016 at 11:58:12AM +0300, Amir Vadai wrote:
> From: Amir Vadai
>
> In order to make a filter processed only by hardware, skip_sw flag
> should be supplied. This is an addition to the already existing skip_hw
> flag (filter will be processed by software only)
From: Amir Vadai
In order to make a filter processed only by hardware, skip_sw flag
should be supplied. This is an addition to the already existing skip_hw
flag (filter will be processed by software only). If no flag is
specified, filter will be processed by both software and hardware.
If only
On Tue, Jun 07, 2016 at 08:37:40AM -0700, John Fastabend wrote:
> On 16-06-05 07:11 AM, Amir Vadai wrote:
> > From: Amir Vadai
> >
> > In order to make a filter processed only by hardware, skip_sw flag
> > should be supplied. This is an addition to the already existi
From: Amir Vadai
In order to make a filter processed only by hardware, skip_sw flag
should be supplied. This is an addition to the already existing skip_hw
flag (filter will be processed by software only). If no flag is
specified, filter will be processed by both software and hardware.
If only
t; intentionally declared but not used here. I could not come up
> with a nicer workaround, but this seems to do the trick.
>
> Signed-off-by: Arnd Bergmann
> Fixes: aad7e08d39bd ("net/mlx5e: Hardware offloaded flower filter statistics
> support")
> Fixes: 00175aec941e
From: Amir Vadai
When adding a flow steering rule with a counter, need to supply a
destination of type MLX5_FLOW_DESTINATION_TYPE_COUNTER, with a pointer
to a struct mlx5_fc.
Also, MLX5_FLOW_CONTEXT_ACTION_COUNT bit should be set in the action.
Signed-off-by: Amir Vadai
---
drivers/net
1 - 100 of 245 matches
Mail list logo
