On Mon, May 01, 2017 at 09:26:25AM -0700, Stephen Hemminger wrote:
> On Sun, 23 Apr 2017 15:53:48 +0300
> Amir Vadai <a...@vadai.me> wrote:
>
> > Hi Stephen,
> >
> > This patchset extends pedit to support modifying a field in an offset
> > relative
> > to the conventional network headers (kenrel support was added [1] in 4.11
> > rc1).
> > Without the extended pedit, user could specify fields in TCP and ICMP
> > headers,
> > but the kernel code was using an offset relative to the begining of the IP
> > header. This will break if IP header length is greater than the minimal
> > value
> > of 20, or if L3 is not IPv4.
> >
> > It also introduces support in manipulating ETH, TCP, UDP and IP.ttl fields
> > and
> > a new command to increase/decrease the value of a field (current use case
> > is IP.ttl).
> >
> > Since there might be deployments already using pedit, special consideration
> > was
> > taken, not to break those scripts - only by specifying the special keyword
> > 'ex', the extended capabilities are available, thus there should be no
> > impact
> > on existing scripts.
> > Also, the new code can live together with rules added by the old code. It
> > supports both the old netlink and the new one.
> >
> > This patchset is against the master and not net-next as the functionality
> > was
> > added in 4.11
> >
> > Thanks,
> > Amir
> >
> > [1] - 71d0ed7079df ("net/act_pedit: Support using offset relative to the
> > conventional network headers")
[...]
>
> Applied. Then I cleaned up long lines
Thanks. Will make sure to clean up long lines in future patches.
