On 4/5/21 11:01 AM, Tom Talpey wrote:
> On 4/5/2021 1:23 AM, Leon Romanovsky wrote:
>> From: Avihai Horon
>>
>> Enable Relaxed Ordering in __ib_alloc_pd() allocation of the
>> local_dma_lkey.
>>
>> This will take effect only for devices that don't pre-allocate the lkey
>> but allocate it per PD al
/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> @@ -509,9 +509,10 @@ void pvrdma_dealloc_pd(struct ib_pd *pd, struct ib_udata
> *udata)
> *
> * @return: 0 on success, otherwise errno.
> */
> -int pvrdma_create_ah(struct ib_a
On Tue, Sep 27, 2016 at 09:21:27AM +, David Laight wrote:
> From: Adit Ranadive
> > Sent: 26 September 2016 19:15
> > On Mon, Sep 26, 2016 at 00:27:40AM -0700, Yuval Shaia wrote:
> > > On Sat, Sep 24, 2016 at 04:21:37PM -0700, Adit Ranadive wrote:
> > > >
On Mon, Sep 26, 2016 at 14:07:24PM -0700, Jason Gunthorpe wrote:
> On Mon, Sep 26, 2016 at 01:40:10PM -0700, Adit Ranadive wrote:
>
> > Wouldnt they be some overlap between the user-space and kernel driver? Or is
> > it expected that the common structures (even device speci
On Mon, Sep 26, 2016 at 10:51:04AM -0600, Jason Gunthorpe wrote:
> On Sun, Sep 25, 2016 at 10:25:12PM -0700, Adit Ranadive wrote:
> > > As Jason said, you need a very good reason to split and create number of
> > > files per-driver in UAPI folder.
> >
> > I can m
On Mon, Sep 26, 2016 at 00:27:40AM -0700, Yuval Shaia wrote:
> On Sat, Sep 24, 2016 at 04:21:37PM -0700, Adit Ranadive wrote:
> > +
> > + /* Currently, the driver only supports RoCE mode. */
> > + if (dev->dsr->caps.mode != PVRDMA_DEVICE_MODE_ROCE) {
> &g
On Mon, Sep 26, 2016 at 00:16:01AM -0700, Yuval Shaia wrote:
> Minor question/suggestion inline.
> (sorry for missing it till now).
>
> Yuval
<...>
> > +int
> > +pvrdma_cmd_post(struct pvrdma_dev *dev, union pvrdma_cmd_req *req,
> > + union pvrdma_cmd_resp *resp, unsigned resp_code)
>
On Sun, Sep 25, 2016 at 23:13:38PM -0700, Leon Romanovsky wrote:
> On Sun, Sep 25, 2016 at 09:22:11PM -0700, Adit Ranadive wrote:
>> On Sun, Sep 25 2016 at 10:26:24AM +0300, Leon Romanovsky wrote:
> > > > On Sat, Sep 24, 2016 at 04:21:26PM -0700, Adit Ranadive wrote:
> &g
On Sun, Sep 25 2016 at 10:03:52AM +0300, Leon Romanovsky wrote:
> On Sat, Sep 24, 2016 at 04:21:24PM -0700, Adit Ranadive wrote:
>
> <...>
>
> > include/uapi/rdma/pvrdma-abi.h | 99 ++
> > include/uapi/rdma/pvrdma-uapi.h| 255
On Sun, Sep 25 2016 at 10:30:10AM +0300, Leon Romanovsky wrote:
> On Sat, Sep 24, 2016 at 04:21:40PM -0700, Adit Ranadive wrote:
> > Add maintainer info for the PVRDMA driver.
> >
> > Reviewed-by: Jorgen Hansen
> > Reviewed-by: George Zhang
> > Reviewed-by: Adity
On sun, Sep 25 2016 at 10:57:03AM +0300, Leon Romanovsky wrote:
> On Sat, Sep 24, 2016 at 04:21:37PM -0700, Adit Ranadive wrote:
> > This patch adds the support to register a RDMA device with the kernel RDMA
> > stack as well as a kernel module. This also initializes the underlying
On Sun, Sep 25 2016 at 10:26:24AM +0300, Leon Romanovsky wrote:
> > On Sat, Sep 24, 2016 at 04:21:26PM -0700, Adit Ranadive wrote:
> > We share some common structures with the user-level driver. This patch adds
> > those structures and shared functions to traver
stack address handles from/to PVRDMA ones.
Reviewed-by: Yuval Shaia
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v4->v5:
- Correct var type passed to dma_alloc_coherent.
Changes v3-
: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Removed an unnecessary comment.
Changes v2->v3:
- Used is_power_of_2 function.
- Simplify pvrdma_uar_alloc function.
---
drivers/infiniband/hw/pvrdma/pvrdma_doorbell.c | 127 +
This patch adds the support for creating and destroying completion queues
on the paravirtual RDMA device.
Reviewed-by: Yuval Shaia
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v4->
Tan
Signed-off-by: Adit Ranadive
---
Changes v4->v5:
- Removed two unnecessary lines.
- Updated include for headers in UAPI folder.
- Update to pvrdma_cmd_post for add/delete GIDs.
- Add error code in dev_warn if pvrdma_cmd_post failed.
Changes v3->v4:
- Fixed some checkpatch wa
This patch implements the remaining Verbs functions registered with the
core RDMA stack.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v4->v5:
- Update include for headers in UAPI fol
Signed-off-by: Adit Ranadive
---
Changes v4->v5:
- Check the access flags correctly for DMA MR.
- Update to pvrdma_cmd_post for creating/destroying MRs.
Changes v3->v4:
- Changed access flag check for DMA MR to using bit operation.
- Removed some local variables.
Changes v2->v3:
: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v4->v5:
- Removed __ prefix for unsigned vars.
Changes v3->v4:
- Moved the pvrdma_sge struct to pvrdma_uapi.h.
---
drivers/infiniband/hw/pvrdma/pvrdma_ib_verbs.h | 444 +
1 file changed, 444 insertions(+)
creat
: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v4->v5:
- pvrdma_cmd_post takes the response code.
Changes v3->v4:
- Renamed pvrdma_flush_cqe to _pvrdma_flush_cqe since we hold a lock
to call it.
- Added wrapper functions for writing to UARs for CQ/QP.
Add maintainer info for the PVRDMA driver.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v4->v5:
- Added pvrdma files to common UAPI folder.
---
MAINTAINERS | 9 +
1 file changed
This patch adds the ability to create, modify, query and destroy QPs. The
PVRDMA device supports RC, UD and GSI QPs.
Reviewed-by: Yuval Shaia
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v4
This patch updates the InfiniBand subsystem to build the PVRDMA driver.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
drivers/infiniband/Kconfig | 1 +
drivers/infiniband/hw/Makefile | 1 +
2
This patch enables posting Verb requests and receiving responses to/from
the backend PVRDMA emulation layer.
Reviewed-by: Yuval Shaia
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v4->
This patch adds a Kconfig and Makefile for the PVRDMA driver.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Enforced dependency on VMXNet3
---
drivers/infiniband/hw/pvrdma/Kcon
(suggested
by Leon Romanovsky).
Changes v1->v2:
- Patch [07/15] - Addressed Yuval Shaia's comments and 32-bit build errors.
---
Adit Ranadive (16):
vmxnet3: Move PCI Id to pci_ids.h
IB/pvrdma: Add user-level shared functions
IB/pvrdma: Add virtual device RDMA structures
IB/pvrdm
The VMXNet3 PCI Id will be shared with our paravirtual RDMA driver.
Moved it to the shared location in pci_ids.h.
Suggested-by: Leon Romanovsky
Acked-by: Bjorn Helgaas
Reviewed-by: Yuval Shaia
Signed-off-by: Adit Ranadive
---
drivers/net/vmxnet3/vmxnet3_int.h | 3 +--
include/linux/pci_ids.h
We share some common structures with the user-level driver. This patch adds
those structures and shared functions to traverse the QP/CQ rings.
Reviewed-by: Yuval Shaia
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit
: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v4->v5:
- Update include for headers moved to UAPI.
- Removed __ prefix for unsigned vars.
Changes v3->v4:
- Removed explicit enum values.
Changes v2->v3:
- Defined 9 and 18 for page directory.
-
val Shaia
> >
> > Yuval
> >
> > On Thu, Sep 15, 2016 at 12:07:29AM +, Adit Ranadive wrote:
> > > On Wed, Sep 14, 2016 at 05:43:37 -0700, Yuval Shaia wrote:
> > > > On Sun, Sep 11, 2016 at 09:49:19PM -0700, Adit Ranadive wrote:
> > > > &
On Wed, Sep 14, 2016 at 05:49:50 -0700 Christoph Hellwig wrote:
> > + props->max_fmr = dev->dsr->caps.max_fmr;
> > + props->max_map_per_fmr = dev->dsr->caps.max_map_per_fmr;
>
> Please don't add FMR support to any new drivers.
We don't and our device reports these as 0. If you want me to more
On Wed, Sep 14, 2016 at 05:43:37 -0700, Yuval Shaia wrote:
> On Sun, Sep 11, 2016 at 09:49:19PM -0700, Adit Ranadive wrote:
> > +
> > +static int pvrdma_poll_one(struct pvrdma_cq *cq, struct pvrdma_qp
> **cur_qp,
> > + struct ib_wc *wc)
> > +{
On Wed, Sep 14, 2016 at 10:37:00 -0700, Jason Gunthorpe wrote:
> We desire to use this as the vehical for the userspace included with the 4.9
> kernel.
>
> I anticipate the tree will be running by Oct 1.
Thanks. So does this mean that the libraries distributed via OFED
(openfabrics.org)
will be
On Wed, Sep 14, 2016 at 09:25:18 -0700, Yuval Shaia wrote:
> On Wed, Sep 14, 2016 at 04:00:25PM +0000, Adit Ranadive wrote:
> > On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote:
> > > Please update vmxnet3_drv.c accordingly.
> >
> > Any reason why? I don'
On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote:
> Please update vmxnet3_drv.c accordingly.
Any reason why? I don't think we need to. Vmxnet3 should just pick up the moved
PCI device id from pci_ids.h file.
- Adit
On Mon, Sep 12, 2016 at 11:03:39 -0700, Jason Gunthorpe wrote:
> On Sun, Sep 11, 2016 at 09:49:10PM -0700, Adit Ranadive wrote:
> > [2] Libpvrdma User-level library -
> > http://git.openfabrics.org/?p=~aditr/libpvrdma.git;a=summary
>
> You will probably find that rdma-plum
On Mon, Sep 12, 2016 at 10:52:26 -0700, Jason Gunthorpe wrote:
> On Sun, Sep 11, 2016 at 09:49:26PM -0700, Adit Ranadive wrote:
> > Add maintainer info for the PVRDMA driver.
>
> You can probably squash the last three patches.
Thanks for taking a look.
Since Doug mentioned that
This patch implements the remaining Verbs functions registered with the
core RDMA stack.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Renamed priviledged -> privileged.
-
We share some common structures with the user-level driver. This patch
adds those structures and shared functions to traverse the QP/CQ rings.
Reviewed-by: Yuval Shaia
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit
Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Fixed some checkpatch warnings.
- Added support for new get_dev_fw_str API.
- Added event workqueue for netdevice events.
- Restructured the pvrdma_pci_remove function a little bit.
Changes v2->v3:
- Removed boolean in pvrdma_cm
-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Renamed pvrdma_flush_cqe to _pvrdma_flush_cqe since we hold a lock
to call it.
- Added wrapper functions for writing to UARs for CQ/QP.
- The conversion functions are updated as func_name(dst, src) format.
- Renamed max_gs
This patch adds support for creating and destroying memory regions. The
PVRDMA device supports User MRs, DMA MRs (no Remote Read/Write support),
Fast Register MRs.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit
This patch adds the ability to create, modify, query and destroy QPs. The
PVRDMA device supports RC, UD and GSI QPs.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Removed
: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Removed explicit enum values.
Changes v2->v3:
- Defined 9 and 18 for page directory.
- Stripped spaces in some comments.
---
drivers/infiniband/hw/pvrdma/pvrdma_defs.h
This patch updates the InfiniBand subsystem to build the PVRDMA driver.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
drivers/infiniband/Kconfig | 1 +
drivers/infiniband/hw/Makefile | 1 +
2
Add maintainer info for the PVRDMA driver.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 87e23cd
: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Moved the pvrdma_sge struct to pvrdma_uapi.h
---
drivers/infiniband/hw/pvrdma/pvrdma_ib_verbs.h | 444 +
1 file changed, 444 insertions(+)
create mode 100644 drivers/infiniband/hw/pvrdma/pvrdma_ib_verb
: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Removed an unnecessary comment.
Changes v2->v3:
- Used is_power_of_2 function.
- Simplify pvrdma_uar_alloc function.
---
drivers/infiniband/hw/pvrdma/pvrdma_doorbell.c | 127 +
This patch enables posting Verb requests and receiving responses to/from
the backend PVRDMA emulation layer.
Reviewed-by: Yuval Shaia
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->
This patch adds a Kconfig and Makefile for the PVRDMA driver.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Enforced dependency on VMXNet3
---
drivers/infiniband/hw/pvrdma/Kcon
This patch adds the support for creating and destroying completion queues
on the paravirtual RDMA device.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Added a pvrdma_destroy_cq
stack address handles from/to PVRDMA ones.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Updated conversion functions to func_name(dst, src) format.
- Removed unneeded local variab
The VMXNet3 PCI Id will be shared with our paravirtual RDMA driver.
Moved it to the shared location in pci_ids.h.
Suggested-by: Leon Romanovsky
Signed-off-by: Adit Ranadive
---
---
drivers/net/vmxnet3/vmxnet3_int.h | 3 +--
include/linux/pci_ids.h | 1 +
2 files changed, 2 insertions
asier to review.
- Removed an unneccesary bool in pvrdma_cmd_post (suggested by Yuval Shaia).
- Made the use of comma at end of enums consistent across files (suggested
by Leon Romanovsky).
Changes v1->v2:
- Patch [07/15] - Addressed Yuval Shaia's comments and 32-bit build errors.
On Fri, Aug 05, 2016 11:23:41AM -0700, Bjorn Helgaas wrote:
> On Fri, Aug 05, 2016 at 11:00:39AM -0700, Adit Ranadive wrote:
> > The VMXNet3 PCI Id will be shared with our upcoming paravirtual RDMA
> > driver. Moved it to the shared location in pci_ids.h and updated the
>
The VMXNet3 PCI Id will be shared with our upcoming paravirtual RDMA
driver. Moved it to the shared location in pci_ids.h and updated the
driver version.
Suggested-by: Leon Romanovsky
Signed-off-by: Adit Ranadive
---
drivers/net/vmxnet3/vmxnet3_int.h | 7 +++
include/linux/pci_ids.h
AIL PROTECTED]>
*
+ * Fixed src_mac command to set source mac of packet to value specified in
+ * command by Adit Ranadive <[EMAIL PROTECTED]>
+ *
*/
#include
#include
@@ -1415,7 +1418,9 @@ static ssize_t pktgen_if_write(struct fi
}
if (!strcmp(na
57 matches
Mail list logo
