On Mon, Sep 26, 2016 at 00:27:40AM -0700, Yuval Shaia wrote:
> On Sat, Sep 24, 2016 at 04:21:37PM -0700, Adit Ranadive wrote:
> > +
> > +   /* Currently, the driver only supports RoCE mode. */
> > +   if (dev->dsr->caps.mode != PVRDMA_DEVICE_MODE_ROCE) {
> > +           dev_err(&pdev->dev, "unsupported transport %d\n",
> > +                   dev->dsr->caps.mode);
> > +           ret = -EINVAL;
> 
> This is some fatal error with the device, not that something wrong with the
> function's argument.
> Suggesting to replace with -EFAULT.
> 

Thanks, will fix this one and the others here.

Reply via email to