RE: [PATCH mlx5-next] IB/mlx5: Prevent allocating UMEM and UCTX as some general object

2018-12-21 Thread Achiad Shochat
Great, thanks -Original Message- From: Jason Gunthorpe Sent: Thursday, December 20, 2018 11:02 PM To: Leon Romanovsky Cc: Doug Ledford ; Yishai Hadas ; RDMA mailing list ; Achiad Shochat ; Saeed Mahameed ; linux-netdev ; Leon Romanovsky Subject: Re: [PATCH mlx5-next] IB/mlx5

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-06 Thread achiad shochat
On 5 December 2017 at 21:20, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 11:59:17AM +0200, achiad shochat wrote: >> Then we'll have a single solution for both netvsc and virtio (and any >> other PV device). >> And we could handle the VF DMA dirt issue agnostica

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-05 Thread achiad shochat
On 4 December 2017 at 18:30, Alexander Duyck wrote: > On Mon, Dec 4, 2017 at 1:51 AM, achiad shochat > wrote: >> On 3 December 2017 at 19:35, Stephen Hemminger >> wrote: >>> On Sun, 3 Dec 2017 11:14:37 +0200 >>> achiad shochat wrote: >>> >>

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-04 Thread achiad shochat
On 3 December 2017 at 19:35, Stephen Hemminger wrote: > On Sun, 3 Dec 2017 11:14:37 +0200 > achiad shochat wrote: > >> On 3 December 2017 at 07:05, Michael S. Tsirkin wrote: >> > On Fri, Dec 01, 2017 at 12:08:59PM -0800, Shannon Nelson wrote: >> >> On 11

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-03 Thread achiad shochat
On 3 December 2017 at 07:05, Michael S. Tsirkin wrote: > On Fri, Dec 01, 2017 at 12:08:59PM -0800, Shannon Nelson wrote: >> On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: >> > On Thu, Nov 30, 2017 at 10:08:45AM +0200, achiad shochat wrote: >> > > Re. problem #2:

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-11-30 Thread achiad shochat
On 30 November 2017 at 05:29, Jason Wang wrote: > > > On 2017年11月29日 03:27, Jesse Brandeburg wrote: >> >> Hi, I'd like to get some feedback on a proposal to enhance virtio-net >> to ease configuration of a VM and that would enable live migration of >> passthrough network SR-IOV devices. >> >> Toda

Re: [PATCH net-next 08/13] net/mlx5e: Add fragmented memory support for RX multi packet WQE

2016-03-14 Thread achiad shochat
On 14 March 2016 at 20:16, Saeed Mahameed wrote: > On Fri, Mar 11, 2016 at 9:58 PM, Eric Dumazet wrote: > >>> I totally agree with this, we should have reported skb->truesize += >>> (consumed strides)*(stride size). >>> but again this is not as critical as you think, in the worst case >>> skb->t

Re: [PATCH net-next 08/13] net/mlx5e: Add fragmented memory support for RX multi packet WQE

2016-03-13 Thread achiad shochat
On 11 March 2016 at 21:58, Eric Dumazet wrote: > On ven., 2016-03-11 at 21:25 +0200, Saeed Mahameed wrote: >> >> -void mlx5e_handle_rx_cqe_mpwrq(struct mlx5e_rq *rq, struct mlx5_cqe64 >> >> *cqe) >> >> +static void mlx5e_add_skb_frag(struct sk_buff *skb, int len, struct page >> >> *page, >> >> +

[PATCH net-next 4/4] net/mlx5_core: Remove redundant "err" variable usage

2015-08-25 Thread Achiad Shochat
Cosmetic change. Do not use the an err variable just to assign and return it. Signed-off-by: Achiad Shochat --- drivers/net/ethernet/mellanox/mlx5/core/port.c | 35 -- 1 file changed, 11 insertions(+), 24 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core

[PATCH net-next 2/4] net/mlx5e: Priv state flag not rolled-back upon netdev open error

2015-08-25 Thread Achiad Shochat
The private mlx5 state flag that indicates that the netdev is opened is set at the beginning of the netdev open flow. In case an error occured later in the mlx5 netdev open flow, this flag was not cleared, remaining set although the actual set is closed. Signed-off-by: Achiad Shochat

[PATCH net-next 3/4] net/mlx5_core: Fix struct type in the DESTROY_TIR/TIS device commands

2015-08-25 Thread Achiad Shochat
From: Saeed Mahameed Used the output mailbox format for input mailbox. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/transobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/transobj.c b/drivers/net/

[PATCH net-next 1/4] net/mlx5_core: Expose transobj APIs from mlx5 core

2015-08-25 Thread Achiad Shochat
From: Yishai Hadas Move transobj.h from the core library to include/linux/mlx5 and expose its APIs. It enables using its functionality outside of mlx5 core. Signed-off-by: Yishai Hadas --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/srq.c

[PATCH net-next 0/4] net/mlx5e: Driver updates 25-Aug-2015

2015-08-25 Thread Achiad Shochat
inter at ndo_select_queue" that I sent lately to the mailing list. Thanks, Achiad Achiad Shochat (2): net/mlx5e: Priv state flag not rolled-back upon netdev open error net/mlx5_core: Remove redundant "err" variable usage Saeed Mahameed (1): net/mlx5_core: Fix struct type i

[PATCH net-next] net/mlx5e: Avoid accessing NULL pointer at ndo_select_queue

2015-08-23 Thread Achiad Shochat
From: Rana Shahout To avoid multiply/division operations on the data path, we hold a {channel, tc}==>txq mapping table. We held this mapping table inside the channel object that is being destroyed upon some configuration operations (e.g MTU change). So in case ndo_select_queue occurs during such

[PATCH net-next 0/8] Driver updates 16-Aug-2015

2015-08-16 Thread Achiad Shochat
Hi Dave, This patchset contains bug fixes, new RSS and pause parameters ethtool options, and support for RX CHECKSUM_COMPLETE. Patchset was applied and tested over commit adc6310 ("Merge branch 'mv88e6xxx-switchdev-fdb'"). Thanks, Achiad Achiad Shochat (8): net/mlx5

[PATCH net-next 2/8] net/mlx5e: Make RSS indirection table size a constant

2015-08-16 Thread Achiad Shochat
rings. Signed-off-by: Achiad Shochat --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 5 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 60 ++- 2 files changed, 30 insertions(+), 35 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b

[PATCH net-next 5/8] net/mlx5e: HW LRO changes/fixes

2015-08-16 Thread Achiad Shochat
gned-off-by: Achiad Shochat --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 +-- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 4 +++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/me

[PATCH net-next 3/8] net/mlx5e: Add ethtool RSS configuration options

2015-08-16 Thread Achiad Shochat
- get_rxfh_key_size - get_rxfh_indir_size - get/set_rxfh indirection table and RSS Toeplitz hash key - get_rxnfc Signed-off-by: Achiad Shochat --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 7 ++- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 71 +++--- drivers

[PATCH net-next 6/8] net/mlx5e: Ethtool link speed setting fixes

2015-08-16 Thread Achiad Shochat
/DOWN device interface enum - Set the local_port bit in the device PAOS register - EXPORT the PAOS (Port Administrative and Operational Status) register set/query access functions. Signed-off-by: Achiad Shochat --- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 25 ++ dr

[PATCH net-next 4/8] net/mlx5e: Support smaller RX/TX ring sizes

2015-08-16 Thread Achiad Shochat
We un-intentionally limited the minimum rings size too much. TX minimum ring size reduced from 128 to 64. RX minimum ring size reduced from 128 to 2. Signed-off-by: Achiad Shochat --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH net-next 1/8] net/mlx5e: Have a single RSS Toeplitz hash key

2015-08-16 Thread Achiad Shochat
No need to generate a unique key per TIR. Generating a single key per netdev and copying it to all its TIRs. Signed-off-by: Achiad Shochat --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 5 - 2 files changed, 5 insertions

[PATCH net-next 7/8] net/mlx5e: Support ethtool get/set_pauseparam

2015-08-16 Thread Achiad Shochat
Only rx/tx pause settings. Autoneg setting is currently not supported. Signed-off-by: Achiad Shochat --- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 38 drivers/net/ethernet/mellanox/mlx5/core/port.c | 42 ++ include/linux/mlx5/driver.h

[PATCH net-next 8/8] net/mlx5e: Support RX CHECKSUM_COMPLETE

2015-08-16 Thread Achiad Shochat
Only for packets with first ethertype set to IPv4/6 for now. Signed-off-by: Achiad Shochat --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 8 +++-- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 5 ++- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 42

Re: [PATCH net-next 05/12] net/mlx5e: Poll rx cq before tx cq to improve round-trip latency

2015-06-21 Thread achiad shochat
20:21, David Miller wrote: > From: Or Gerlitz > Date: Wed, 17 Jun 2015 18:26:22 +0300 > >> From: Achiad Shochat >> >> For better round trip latency, handle rx completions before >> tx completions. >> >> Signed-off-by: Achiad Shochat >> Signed-o