Re: [PATCH iproute2] lib: move get_task_name() from rdma

2021-04-19 Thread Leon Romanovsky
On Mon, Apr 19, 2021 at 03:34:58PM +0200, Andrea Claudi wrote: > The function get_task_name() is used to get the name of a process from > its pid, and its implementation is similar to ip/iptuntap.c:pid_name(). > > Move it to lib/fs.c to use a single implementation and make it easily > reusable. >

Re: [PATCH net-next] net: xdp: Update pkt_type if generic XDP changes unicast MAC

2021-04-19 Thread Martin Willi
Hi, Thanks for your comments. > > eth = (struct ethhdr *)xdp->data; > > + orig_host = ether_addr_equal_64bits(eth->h_dest, skb->dev->dev_addr); > > ether_addr_equal_64bits() seems to assume that the addresses passed to > it are padded to be 8 bytes long, which is not the case for eth->h_d

[syzbot] KASAN: use-after-free Read in sctp_do_8_2_transport_strike

2021-04-19 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:bf05bf16 Linux 5.12-rc8 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16a00dfed0 kernel config: https://syzkaller.appspot.com/x/.config?x=9404cfa686df2c05 dashboard link: https://syzkaller.appspo

Re: [PATCH] bonding: 3ad: update slave arr after initialize

2021-04-19 Thread Jay Vosburgh
jin yiting wrote: [...] >> The described issue is a race condition (in that >> ad_agg_selection_logic clears agg->is_active under mode_lock, but >> bond_open -> bond_update_slave_arr is inspecting agg->is_active outside >> the lock). I don't see how the above change will reliably manage this

Re: [net-next 07/15] net/mlx5: mlx5_ifc updates for flex parser

2021-04-19 Thread Samudrala, Sridhar
On 4/19/2021 8:20 PM, Saeed Mahameed wrote: From: Yevgeny Kliteynik Added the required definitions for supporting more protocols by flex parsers (GTP-U, Geneve TLV options), and for using the right flex parser that was configured for this protocol. Are you planning to support adding flow rules

Re: [PATCH] bpf: Fix backport of "bpf: restrict unknown scalars of mixed signed bounds for unprivileged"

2021-04-19 Thread Balbir Singh
On Mon, Apr 19, 2021 at 04:56:41PM -0700, Samuel Mendoza-Jonas wrote: > The 4.14 backport of 9d7eceede ("bpf: restrict unknown scalars of mixed > signed bounds for unprivileged") adds the PTR_TO_MAP_VALUE check to the > wrong location in adjust_ptr_min_max_vals(), most likely because 4.14 > doesn't

Re: [PATCHv2 RFC bpf-next 0/7] bpf: Add support for ftrace probe

2021-04-19 Thread Andrii Nakryiko
On Fri, Apr 16, 2021 at 8:03 AM Masami Hiramatsu wrote: > > Hi, > > On Thu, 15 Apr 2021 17:00:07 -0400 > Steven Rostedt wrote: > > > > > [ > > Added Masami, as I didn't realize he wasn't on Cc. He's the maintainer of > > kretprobes. > > > > Masami, you may want to use lore.kernel.org to rea

Re: [net-next, v2] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

2021-04-19 Thread Guenter Roeck
[] __sys_sendto+0xa4/0x170 [] sys_sendto+0x24/0x40 [] sys_bind+0x20/0x40 [] entSys+0xa4/0xc0 Bisect log attached. Guenter --- # bad: [50b8b1d699ac313c0a07a3c185ffb23aecab8abb] Add linux-next specific files for 20210419 # good: [bf05bf16c76bb44ab5156223e1e58e26dfe30a88] Linux 5.12-rc8 git bisect

RE: [net-next] enetc: fix locking for one-step timestamping packet transfer

2021-04-19 Thread Y.b. Lu
Hi, I think this patch was reviewed and no objection now, right? (I see status is " Changes Requested ".) Thanks. > -Original Message- > From: Yangbo Lu > Sent: 2021年4月13日 11:48 > To: netdev@vger.kernel.org > Cc: Y.b. Lu ; David S . Miller ; > Richard Cochran ; Claudiu Manoil > ; Jakub

Re: [PATCH bpf-next v2 4/4] libbpf: add selftests for TC-BPF API

2021-04-19 Thread Andrii Nakryiko
On Mon, Apr 19, 2021 at 5:18 AM Kumar Kartikeya Dwivedi wrote: > > This adds some basic tests for the low level bpf_tc_cls_* API. > > Reviewed-by: Toke Høiland-Jørgensen > Signed-off-by: Kumar Kartikeya Dwivedi > --- > .../selftests/bpf/prog_tests/test_tc_bpf.c| 112 ++ > ..

Re: [PATCH 2/2] neighbour: allow NUD_NOARP entries to be forced GCed

2021-04-19 Thread David Ahern
On 4/19/21 10:52 AM, Kasper Dupont wrote: > On 19/04/21 10.10, David Ahern wrote: >> On 4/19/21 9:44 AM, Kasper Dupont wrote: >>> >>> Is there any update regarding this change? >>> >>> I noticed this regression when it was used in a DoS attack on one of >>> my servers which I had upgraded from Ubun

linux-next: manual merge of the ftrace tree with the bpf-next tree

2021-04-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the ftrace tree got a conflict in: kernel/trace/bpf_trace.c between commit: d9c9e4db186a ("bpf: Factorize bpf_trace_printk and bpf_seq_printf") from the bpf-next tree and commit: f2cc020d7876 ("tracing: Fix various typos in comments") from the ftrace

Re: [PATCH 0/2] Change struct page layout for page_pool

2021-04-19 Thread Michael Ellerman
"Matthew Wilcox (Oracle)" writes: > The first patch here fixes two bugs on ppc32, and mips32. It fixes one > bug on arc and arm32 (in certain configurations). It probably makes > sense to get it in ASAP through the networking tree. I'd like to see > testing on those four architectures if possib

Re: [PATCH] net: ethernet: ravb: Fix release of refclk

2021-04-19 Thread Adam Ford
On Mon, Apr 19, 2021 at 5:45 PM David Miller wrote: > > From: Adam Ford > Date: Sat, 17 Apr 2021 08:23:29 -0500 > > > The call to clk_disable_unprepare() can happen before priv is > > initialized. This means moving clk_disable_unprepare out of > > out_release into a new label. > > > > Fixes: 8ef7

Re: [PATCH bpf-next 1/2] bpf: Remove bpf_jit_enable=2 debugging mode

2021-04-19 Thread Alexei Starovoitov
On Sat, Apr 17, 2021 at 1:16 AM Christophe Leroy wrote: > > > > Le 16/04/2021 à 01:49, Alexei Starovoitov a écrit : > > On Thu, Apr 15, 2021 at 8:41 AM Quentin Monnet > > wrote: > >> > >> 2021-04-15 16:37 UTC+0200 ~ Daniel Borkmann > >>> On 4/15/21 11:32 AM, Jianlin Lv wrote: > For debuggi

Re: [PATCH] bonding: 3ad: update slave arr after initialize

2021-04-19 Thread jin yiting
在 2021/4/16 12:28, Jay Vosburgh 写道: jinyiting wrote: From: jin yiting The bond works in mode 4, and performs down/up operations on the bond that is normally negotiated. The probability of bond-> slave_arr is NULL Test commands: ifconfig bond1 down ifconfig bond1 up The conflict

[net-next 14/15] net/mlx5: DR, Add support for force-loopback QP

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik When supported by the device, SW steering RoCE RC QP that is used to write/read to/from ICM will be created with force-loopback attribute. Such QP doesn't require GID index upon creation. Signed-off-by: Erez Shitrit Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed

[net-next 15/15] net/mlx5: DR, Add support for isolate_vl_tc QP

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik When using SW steering, rule insertion rate depends on the RDMA RC QP performance used for writing to the ICM. During stress this QP is competing on the HW resources with all the other QPs that are used to send data. To protect SW steering QP's performance in such cases, w

[net-next 12/15] net/mlx5: DR, Set flex parser for TNL_MPLS dynamically

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Query the flex_parser id that's intended for TNL_MPLS and use an appropriate flex parser for MPLS over UDP/GRE. Signed-off-by: Muhammad Sammar Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/steering/dr_cmd.c | 8 ++ ...

[net-next 11/15] net/mlx5: DR, Add support for matching on geneve TLV option

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Enable matching on tunnel geneve TLV option using the flex parser. Signed-off-by: Muhammad Sammar Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/steering/dr_cmd.c | 4 +++ .../mellanox/mlx5/core/steering/dr_matcher.c |

[net-next 13/15] net/mlx5: DR, Add support for matching tunnel GTP-U

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Enable matching on tunnel GTP-U and GTP-U first extension header using dynamic flex parser. Signed-off-by: Muhammad Sammar Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/steering/dr_cmd.c | 16 +++ .../mellanox/mlx5/cor

[net-next 10/15] net/mlx5: DR, Set STEv0 ICMP flex parser dynamically

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Set the flex parser ID dynamicly for ICMP instead of relying on hardcoded values. Signed-off-by: Muhammad Sammar Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/steering/dr_matcher.c | 12 ++--- .../mellanox/mlx5/core/steerin

[net-next 09/15] net/mlx5: DR, Add support for dynamic flex parser

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Flex parser is a HW parser that can support protocols that are not natively supported by the HCA, such as Geneve (TLV options) and GTP-U. There are 8 such parsers, and each of them can be assigned to parse a specific set of protocols. This patch adds misc4 match params whi

[net-next 08/15] net/mlx5: DR, Remove protocol-specific flex_parser_3 definitions

2021-04-19 Thread Saeed Mahameed
From: Muhammad Sammar Remove MPLS specific fields from flex parser 3 layout. Flex parser can be used for multiple protocols and should not be hardcoded to a specific type. Signed-off-by: Muhammad Sammar Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core

[net-next 07/15] net/mlx5: mlx5_ifc updates for flex parser

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Added the required definitions for supporting more protocols by flex parsers (GTP-U, Geneve TLV options), and for using the right flex parser that was configured for this protocol. Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- include/linux/mlx5/ml

[net-next 04/15] net/mlx5: DR, Rename an argument in dr_rdma_segments

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Rename the argument to better reflect that the meaning is not number of records, but wheather or not we should ring the dorbell. Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/steering/dr_send.c| 8 1

[net-next 05/15] net/mlx5: DR, Fix SQ/RQ in doorbell bitmask

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik QP doorbell size is 16 bits. Fixing sw steering's QP doorbel bitmask, which had 20 bits. Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[net-next 06/15] net/mlx5: E-Switch, Improve error messages in term table creation

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Add error code to the error messages and removed duplicated message: if termination table creation failed, we already get an error message in mlx5_eswitch_termtbl_create, so no need for the additional error print in the calling function. Signed-off-by: Yevgeny Kliteynik

[net-next 03/15] net/mlx5e: RX, Add checks for calculated Striding RQ attributes

2021-04-19 Thread Saeed Mahameed
From: Tariq Toukan Striding RQ attributes below are mutually dependent. An unaware change to one might take the others out of the valid range derived by the HW caps: - The MPWQE size in bytes - The number of strides in a MPWQE - The stride size Add checks to verify they are valid and comply to t

[pull request][net-next 00/15] mlx5 updates 2021-04-19

2021-04-19 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, This series provides updates for mlx5, mostly around mlx5 software steering For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit e9377a911d772d27ef2810c24

[net-next 01/15] net/mlx5e: Fix lost changes during code movements

2021-04-19 Thread Saeed Mahameed
From: Tariq Toukan The changes done in commit [1] were missed by the code movements done in [2], as they were developed in ~parallel. Here we re-apply them. [1] commit e4484d9df500 ("net/mlx5e: Enable striding RQ for Connect-X IPsec capable devices") [2] commit b3a131c2a160 ("net/mlx5e: Move pa

[net-next 02/15] net/mlx5e: Fix possible non-initialized struct usage

2021-04-19 Thread Saeed Mahameed
From: Vladyslav Tarasiuk If mlx5e_devlink_port_register() fails, driver may try to register devlink health TX and RX reporters on non-registered devlink port. Instead, create health reporters only if mlx5e_devlink_port_register() does not fail. And destroy reporters only if devlink_port is regis

Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-19 Thread Matthew Wilcox
On Tue, Apr 20, 2021 at 02:48:17AM +, Vineet Gupta wrote: > > 32-bit architectures which expect 8-byte alignment for 8-byte integers > > and need 64-bit DMA addresses (arc, arm, mips, ppc) had their struct > > page inadvertently expanded in 2019. > > FWIW, ARC doesn't require 8 byte alignment

RE: [EXT] Re: [net-next] net: dsa: felix: disable always guard band bit for TAS config

2021-04-19 Thread Xiaoliang Yang
Hi Vladimir. On Mon, Apr 19, 2021 at 20:38PM +0800, Vladimir Oltean wrote: > >What is a scheduled queue? When time-aware scheduling is enabled on the port, >why are some queues scheduled and some not? The felix vsc9959 device can set SCH_TRAFFIC_QUEUES field bits to define which queue is schedu

Re: [PATCH V4 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-19 Thread Jason Wang
在 2021/4/19 下午2:33, Zhu Lingshan 写道: This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id() can simply return the ID. ifcvf_vdpa_get_features() and ifcvf_vdpa_get_config_size() can work properly based on the device ID. Signed-off-by: Zhu Lingshan Ac

Re: [PATCH net-next v3] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

2021-04-19 Thread Jason Wang
在 2021/4/20 上午12:48, David Ahern 写道: On 4/16/21 2:16 AM, Xuan Zhuo wrote: In page_to_skb(), if we have enough tailroom to save skb_shared_info, we can use build_skb to create skb directly. No need to alloc for additional space. And it can save a 'frags slot', which is very friendly to GRO. He

Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-19 Thread Vineet Gupta
Hi Matthew, On 4/16/21 7:45 PM, Matthew Wilcox wrote: > Replacement patch to fix compiler warning. > > From: "Matthew Wilcox (Oracle)" > Date: Fri, 16 Apr 2021 16:34:55 -0400 > Subject: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems > To: bro...@redhat.com > Cc: linux-ker...@vger.kernel

Re: [PATCH] dt-bindings: net: mediatek: support MT7621 SoC

2021-04-19 Thread Ilya Lipnitskiy
On Sun, Apr 18, 2021 at 11:24 PM Bjørn Mork wrote: > > Ilya Lipnitskiy writes: > > > Add missing binding documentation for SoC support that has been in place > > since v5.1 > > > > Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet > > hardware") > > Cc: Bjørn Mork > > S

[PATCH] dt-bindings: net: mediatek/ralink: remove unused bindings

2021-04-19 Thread Ilya Lipnitskiy
Revert commit 663148e48a66 ("Documentation: DT: net: add docs for ralink/mediatek SoC ethernet binding") No in-tree drivers use the compatible strings present in these bindings, and some have been superseded by DSA-capable mtk_eth_soc driver, so remove these obsolete bindings. Cc: John Crispin S

Re: [PATCH net-next v3] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

2021-04-19 Thread Jason Wang
在 2021/4/20 上午10:38, Jason Wang 写道: : +    /* hdr_valid means no XDP, so we can copy the vnet header */ +    if (hdr_valid) { +    hdr = skb_vnet_hdr(skb); +    memcpy(hdr, hdr_p, hdr_len); and hdr_p is dereferenced here. Right, I tend to recover the way to copy hdr and set meta ju

Re: [PATCH net] net/mlx5e: Fix uninitialised struct field moder.comps

2021-04-19 Thread Saeed Mahameed
On Mon, 2021-04-19 at 20:17 +0800, wangyunjian wrote: > From: Yunjian Wang > > The 'comps' struct field in 'moder' is not being initialized > in mlx5e_get_def_rx_moderation(). So initialize 'moder' to > zero to avoid the issue. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 3

Re: [PATCH net-next v3] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

2021-04-19 Thread Jason Wang
在 2021/4/20 上午7:29, Mat Martineau 写道: On Fri, 16 Apr 2021, Xuan Zhuo wrote: In page_to_skb(), if we have enough tailroom to save skb_shared_info, we can use build_skb to create skb directly. No need to alloc for additional space. And it can save a 'frags slot', which is very friendly to GRO.

Re: [PATCH net v4 1/2] net: sched: fix packet stuck problem for lockless qdisc

2021-04-19 Thread Yunsheng Lin
On 2021/4/20 7:55, Michal Kubecek wrote: > On Mon, Apr 19, 2021 at 05:29:46PM +0200, Michal Kubecek wrote: >> >> As pointed out in the discussion on v3, this patch may result in >> significantly higher CPU consumption with multiple threads competing on >> a saturated outgoing device. I missed this

RE: [RFC net-next] net: stmmac: should not modify RX descriptor when STMMAC resume

2021-04-19 Thread Joakim Zhang
Hi Jon, > -Original Message- > From: Jon Hunter > Sent: 2021年4月19日 23:12 > To: Joakim Zhang ; peppe.cavall...@st.com; > alexandre.tor...@foss.st.com; joab...@synopsys.com; > da...@davemloft.net; k...@kernel.org; mcoquelin.st...@gmail.com; > and...@lunn.ch; f.faine...@gmail.com > Cc: dl-l

Re: [PATCH 3/3] net: ethernet: ixp4xx: Use OF MDIO bus registration

2021-04-19 Thread Andrew Lunn
> @@ -1381,25 +1382,12 @@ static struct eth_plat_info > *ixp4xx_of_get_platdata(struct device *dev) > /* NPE ID 0x00, 0x10, 0x20... */ > plat->npe = (val << 4); > > - phy_np = of_parse_phandle(np, "phy-handle", 0); > - if (phy_np) { > - ret = of_property_read_u32(

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-19 Thread Yunsheng Lin
On 2021/4/19 22:57, Michal Kubecek wrote: > On Mon, Apr 19, 2021 at 10:04:27AM +0800, Yunsheng Lin wrote: >>> >>> I tried this patch o top of 5.12-rc7 with real devices. I used two >>> machines with 10Gb/s Intel ixgbe NICs, sender has 16 CPUs (2 8-core CPUs >>> with HT disabled) and 16 Rx/Tx queues

Re: [PATCH 2/3] net: ethernet: ixp4xx: Support device tree probing

2021-04-19 Thread Andrew Lunn
> + phy_np = of_parse_phandle(np, "phy-handle", 0); > + if (phy_np) { > + ret = of_property_read_u32(phy_np, "reg", &val); > + if (ret) { > + dev_err(dev, "cannot find phy reg\n"); > + return NULL; > + } > +

Re: [PATCH 1/3] net: ethernet: ixp4xx: Add DT bindings

2021-04-19 Thread Andrew Lunn
> + mdio { > +#address-cells = <1>; > +#size-cells = <0>; > +phy1: phy@1 { > + #phy-cells = <0>; Hi Linus phy-cells is not part of the Ethernet PHY binding. Andrew

Re: [PATCH net-next v2 2/2] net: ethernet: mediatek: support custom GMAC label

2021-04-19 Thread Andrew Lunn
On Mon, Apr 19, 2021 at 08:46:59AM -0700, Ilya Lipnitskiy wrote: > The MAC device name can now be set within DTS file instead of always > being "ethX". This is helpful for DSA to clearly label the DSA master > device and distinguish it from DSA slave ports. > > For example, some devices, such as t

Re: [PATCH bpf-next v4 2/3] bpf: selftests: remove percpu macros from bpf_util.h

2021-04-19 Thread Alexei Starovoitov
On Thu, Apr 15, 2021 at 10:47 AM Pedro Tammela wrote: > > Andrii suggested to remove this abstraction layer and have the percpu > handling more explicit[1]. > > This patch also updates the tests that relied on the macros. > > [1] > https://lore.kernel.org/bpf/caef4bzymj_zpdq8zi4dbntbojkrpu2tvopys

Re: [PATCH] bpf: Fix backport of "bpf: restrict unknown scalars of mixed signed bounds for unprivileged"

2021-04-19 Thread Yonghong Song
On 4/19/21 4:56 PM, Samuel Mendoza-Jonas wrote: The 4.14 backport of 9d7eceede ("bpf: restrict unknown scalars of mixed signed bounds for unprivileged") adds the PTR_TO_MAP_VALUE check to the wrong location in adjust_ptr_min_max_vals(), most likely because 4.14 doesn't include the commit that

[PATCH ethtool-next 6/7] netlink: add support for standard stats

2021-04-19 Thread Jakub Kicinski
Add support for standard-based stats. Unlike ethtool -S eth0 the new stats should be allow cross-vendor compatibility. The interface depends on bitsets and is rather simple. # ethtool -S eth0 --groups eth-phy eth-mac rmon Stats for eth0: eth-phy-SymbolErrorDuringCarrier: 1 eth-mac-FramesTransmit

[PATCH ethtool-next 7/7] netlink: stats: add on --all-groups option

2021-04-19 Thread Jakub Kicinski
Add a switch for querying all statistic groups available in the kernel. To reject --groups and --all-groups being specified for one request add a concept of "parameter equivalency" in the parser. Alternative of having a special group type like "--groups all" seems less clean. Suggested-by: Ido Sc

[PATCH ethtool-next 5/7] ethtool: add nlchk for redirecting to netlink

2021-04-19 Thread Jakub Kicinski
To support commands which differ from the ioctl implementation add a new callback which can check if the arguments on the command line indicate that the request should be sent over netlink. The decision should be inferred from the arguments, rather than an explicit --netlink argument. Signed-off-b

[PATCH ethtool-next 3/7] netlink: add FEC support

2021-04-19 Thread Jakub Kicinski
Add support for FEC get/set over netlink. Output should be identical but for ordering of RS vs BaseR. Since the new output is based on link modes RS comes before BaseR in "Configured FEC encodings". Seems pretty unlikely someone depends on the ordering there. Since old API was case insensitive we

[PATCH ethtool-next 2/7] json: improve array print API

2021-04-19 Thread Jakub Kicinski
In ethtool when we print an array we usually have a label (non-JSON) and a key (JSON), because arrays are most often printed entry-per-line (unlike iproute2 where the output has multiple params on a line to cater well to multi-interface dumps). Use this knowledge in the json array API to make it s

[PATCH ethtool-next 4/7] netlink: fec: support displaying statistics

2021-04-19 Thread Jakub Kicinski
Similar implementation-wise to pause stats. The difference is that stats are reported as arrays (first entry being total, and remaining ones per-lane). # ethtool -I --show-fec eth0 FEC parameters for eth0: Configured FEC encodings: None Active FEC encoding: None Statistics: corrected_blocks: 2

[PATCH ethtool-next 1/7] update UAPI header copies

2021-04-19 Thread Jakub Kicinski
Update to kernel commit 6ecaf81d4ac6. Signed-off-by: Jakub Kicinski --- uapi/linux/ethtool.h | 111 +++-- uapi/linux/ethtool_netlink.h | 188 +++ uapi/linux/if_link.h | 9 +- uapi/linux/netlink.h | 2 +- uapi/linux/rtnet

[PATCH ethtool-next 0/7] ethtool: support FEC and standard stats

2021-04-19 Thread Jakub Kicinski
This series adds support for FEC requests via netlink and new "standard" stats. Changes compared to RFC: - improve commit messages - fix Rx vs Tx histogram in JSON - make histograms less hardcoded to RMON - expand man page entry for -S a little - add --all-groups (last patch) Jakub Kicinski

[PATCH] bpf: Fix backport of "bpf: restrict unknown scalars of mixed signed bounds for unprivileged"

2021-04-19 Thread Samuel Mendoza-Jonas
The 4.14 backport of 9d7eceede ("bpf: restrict unknown scalars of mixed signed bounds for unprivileged") adds the PTR_TO_MAP_VALUE check to the wrong location in adjust_ptr_min_max_vals(), most likely because 4.14 doesn't include the commit that updates the if-statement to a switch-statement (aad2e

Re: [PATCH net v4 1/2] net: sched: fix packet stuck problem for lockless qdisc

2021-04-19 Thread Michal Kubecek
On Mon, Apr 19, 2021 at 05:29:46PM +0200, Michal Kubecek wrote: > > As pointed out in the discussion on v3, this patch may result in > significantly higher CPU consumption with multiple threads competing on > a saturated outgoing device. I missed this submission so that I haven't > checked it yet

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-19 Thread Dominique MARTINET
Arnd Bergmann wrote on Mon, Apr 19, 2021 at 02:16:36PM +0200: > In some cases, you can use the device_link infrastructure to deal > with dependencies between devices. Not sure if this would help > in your case, but have a look at device_link_add() etc in drivers/base/core.c I'll need to actually t

Re: [PATCH net-next v2] ethtool: add missing EEPROM to list of messages

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 19 Apr 2021 14:52:35 -0700 you wrote: > ETHTOOL_MSG_MODULE_EEPROM_GET is missing from the list of messages. > ETHTOOL_MSG_MODULE_EEPROM_GET_REPLY is sadly a rather long name > so we need to adjust column length. >

Re: [PATCH net] MAINTAINERS: update

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 19 Apr 2021 16:25:25 -0500 you wrote: > I am making this change again since I received the following instruction. > > "As an IBM employee, you are not allowed to use your gmail account to work > in any way on VNIC. You

Re: [PATCH v3 0/2] TJA1103 driver

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 19 Apr 2021 19:13:58 +0300 you wrote: > Hi, > > This small series adds the TJA1103 PHY driver. > > Changes in v3: > - use phy_read_mmd_poll_timeout instead of spin_until_cond > - changed the phy name from a gen

Re: [PATCH net-next] ethtool: stats: clarify the initialization to ETHTOOL_STAT_NOT_SET

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 19 Apr 2021 13:03:45 -0700 you wrote: > Ido suggests we add a comment about the init of stats to -1. > This is unlikely to be clear to first time readers. > > Suggested-by: Ido Schimmel > Signed-off-by: Jakub Kici

Re: [PATCH net-next] bnxt: add more ethtool standard stats

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 19 Apr 2021 13:02:42 -0700 you wrote: > Michael suggest a few more stats we can expose. > > $ ethtool -S eth0 --groups eth-mac > Standard stats for eth0: > eth-mac-FramesTransmittedOK: 902623288966 > eth-mac-Frames

Re: [PATCH net-next v3] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

2021-04-19 Thread Mat Martineau
On Fri, 16 Apr 2021, Xuan Zhuo wrote: In page_to_skb(), if we have enough tailroom to save skb_shared_info, we can use build_skb to create skb directly. No need to alloc for additional space. And it can save a 'frags slot', which is very friendly to GRO. Here, if the payload of the received p

Re: [PATCH RESEND net-next] net: marvell: prestera: add support for AC3X 98DX3265 device

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 17 Apr 2021 02:17:51 +0300 you wrote: > From: Vadym Kochan > > Add PCI match for AC3X 98DX3265 device which is supported by the current > driver and firmware. > > Signed-off-by: Vadym Kochan > > [...] Here is

Re: [PATCH v6 net-next 00/10] net: Korina improvements

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 19 Apr 2021 00:19:38 +0200 you wrote: > While converting Mikrotik RB532 support to use device tree I stumbled > over the korina ethernet driver, which used way too many MIPS specific > hacks. This series cleans thi

Re: [PATCH net-next 1/1] net: stmmac: fix memory leak during driver probe

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 19 Apr 2021 19:25:30 +0800 you wrote: > On driver probe, kmemleak reported the following memory leak which was > due to allocated bitmap that was not being freed in stmmac_dvr_probe(). > > unreferenced object 0xfff

Re: [PATCH net-next] netlink: simplify nl_set_extack_cookie_u64(), nl_set_extack_cookie_u32()

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 17 Apr 2021 14:38:07 +0300 you wrote: > Taking address of a function argument directly works just fine. > > Signed-off-by: Alexey Dobriyan > --- > > include/linux/netlink.h | 12 > 1 file changed,

Re: [PATCH net-next 0/3] mtk_ppe_offload fixes

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sun, 18 Apr 2021 23:11:42 +0200 you wrote: > Hi, > > A few incremental fixes for the initial flowtable offload support > and this driver: > > 1) Fix undefined reference to `dsa_port_from_netdev' due to missing >de

Re: [PATCH net-next 01/14] netfilter: flowtable: add vlan match offload support

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sun, 18 Apr 2021 23:04:02 +0200 you wrote: > From: wenxu > > This patch adds support for vlan_id, vlan_priority and vlan_proto match > for flowtable offload. > > Signed-off-by: wenxu > Signed-off-by: Pablo Neira Ayu

Re: [PATCH v2] net: fix a data race when get vlan device

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 19 Apr 2021 21:56:41 +0800 you wrote: > From: Di Zhu > > We encountered a crash: in the packet receiving process, we got an > illegal VLAN device address, but the VLAN device address saved in vmcore > is correct. After

Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang

2021-04-19 Thread Gustavo A. R. Silva
On 4/17/21 12:52, Kalle Valo wrote: > "Gustavo A. R. Silva" wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix >> multiple warnings by replacing /* fall through */ comments with >> the new pseudo-keyword macro fallthrough; instead of letting the >> code fall through to

Re: [PATCH 3/3] net: ethernet: ixp4xx: Use OF MDIO bus registration

2021-04-19 Thread Linus Walleij
On Tue, Apr 20, 2021 at 12:51 AM Linus Walleij wrote: > This augments the IXP4xx to use the OF MDIO bus code when > registering the MDIO bus and when looking up the PHY > for the ethernet network device. > > Cc: Zoltan HERPAI > Cc: Raylynn Knight > Signed-off-by: Linus Walleij > --- > ChangeLo

[PATCH 3/3] net: ethernet: ixp4xx: Use OF MDIO bus registration

2021-04-19 Thread Linus Walleij
This augments the IXP4xx to use the OF MDIO bus code when registering the MDIO bus and when looking up the PHY for the ethernet network device. Cc: Zoltan HERPAI Cc: Raylynn Knight Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - New patch making use of more OF infrastructure. --- drivers/

[PATCH 2/3] net: ethernet: ixp4xx: Support device tree probing

2021-04-19 Thread Linus Walleij
This adds device tree probing to the IXP4xx ethernet driver. Add a platform data bool to tell us whether to register an MDIO bus for the device or not, as well as the corresponding NPE. We need to drop the memory region request as part of this since the OF core will request the memory for the dev

[PATCH 1/3] net: ethernet: ixp4xx: Add DT bindings

2021-04-19 Thread Linus Walleij
This adds device tree bindings for the IXP4xx ethernet controller with optional MDIO bridge. Cc: Zoltan HERPAI Cc: Raylynn Knight Cc: devicet...@vger.kernel.org Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Add schema for the (optional) embedded MDIO bus inside the ethernet controller

Re: [PATCH v2 net-next] net: ethernet: mediatek: fix a typo bug in flow offloading

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 17 Apr 2021 15:29:04 +0800 you wrote: > Issue was traffic problems after a while with increased ping times if > flow offload is active. It turns out that key_offset with cookie is > needed in rhashtable_params but w

Re: [PATCH net-next 0/3] net: hns3: misc updates for -next

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 17 Apr 2021 15:09:21 +0800 you wrote: > This series includes some misc updates for the HNS3 ethernet driver. > > Huazhong Tan (3): > net: hns3: remove a duplicate pf reset counting > net: hns3: cleanup inappro

Re: [PATCH] net: ethernet: ixp4xx: Set the DMA masks explicitly

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 18 Apr 2021 20:28:53 +0200 you wrote: > The former fix only papered over the actual problem: the > ethernet core expects the netdev .dev member to have the > proper DMA masks set, or there will be BUG_ON() triggered > in

Re: [PATCHv5 bpf-next 1/7] bpf: Allow trampoline re-attach for tracing and lsm programs

2021-04-19 Thread KP Singh
On Fri, Apr 16, 2021 at 1:22 AM Andrii Nakryiko wrote: > > On Wed, Apr 14, 2021 at 5:44 PM Jiri Olsa wrote: > > > > Currently we don't allow re-attaching of trampolines. Once > > it's detached, it can't be re-attach even when the program > > is still loaded. > > > > Adding the possibility to re-a

Re: [PATCH] net: ethernet: ravb: Fix release of refclk

2021-04-19 Thread David Miller
From: Adam Ford Date: Sat, 17 Apr 2021 08:23:29 -0500 > The call to clk_disable_unprepare() can happen before priv is > initialized. This means moving clk_disable_unprepare out of > out_release into a new label. > > Fixes: 8ef7adc6beb2("net: ethernet: ravb: Enable optional refclk") > Signed-off-

Re: [PATCH net-next 0/5] Flow control for NXP ENETC

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 17 Apr 2021 02:42:20 +0300 you wrote: > From: Vladimir Oltean > > This patch series contains logic for enabling the lossless mode on the > RX rings of the ENETC, and the PAUSE thresholds on the internal FIFO > me

Re: [PATCH net-next] net: xilinx: drivers need/depend on HAS_IOMEM

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 16 Apr 2021 23:55:54 -0700 you wrote: > kernel test robot reports build errors in 3 Xilinx ethernet drivers. > They all use ioremap functions that are only available when HAS_IOMEM > is set/enabled. If it is not ena

Re: [PATCH v4] net: sched: tapr: prevent cycle_time == 0 in parse_taprio_schedule

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sat, 17 Apr 2021 07:30:46 +0800 you wrote: > There is a reproducible sequence from the userland that will trigger a > WARN_ON() > condition in taprio_get_start_time, which causes kernel to panic if configured > as "panic_on_

Re: [PATCH][next] sctp: Fix out-of-bounds warning in sctp_process_asconf_param()

2021-04-19 Thread Gustavo A. R. Silva
On 4/19/21 17:34, David Miller wrote: >> Thanks for this. Can you take these other two, as well, please? >> >> https://lore.kernel.org/linux-hardening/20210416201540.GA593906@embeddedor/ >> https://lore.kernel.org/linux-hardening/20210416193151.GA591935@embeddedor/ >> > > Done. Thanks, Dave!

Re: [PATCH][next] sctp: Fix out-of-bounds warning in sctp_process_asconf_param()

2021-04-19 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 16 Apr 2021 19:07:05 -0500 > Dave, > > On 4/16/21 19:00, patchwork-bot+netdev...@kernel.org wrote: >> Hello: >> >> This patch was applied to netdev/net-next.git (refs/heads/master): >> >> On Fri, 16 Apr 2021 14:12:36 -0500 you wrote: >>> Fix the following

Re: [PATCHv7 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-19 Thread Paul E. McKenney
On Tue, Apr 20, 2021 at 12:16:40AM +0200, Toke Høiland-Jørgensen wrote: > "Paul E. McKenney" writes: > > > On Mon, Apr 19, 2021 at 11:21:41PM +0200, Toke Høiland-Jørgensen wrote: > >> "Paul E. McKenney" writes: > >> > >> > On Mon, Apr 19, 2021 at 08:12:27PM +0200, Toke Høiland-Jørgensen wrote:

Re: pull-request: wireless-drivers-next-2021-04-18

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Sun, 18 Apr 2021 08:26:14 + (UTC) you wrote: > Hi, > > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. > > Kalle > > [...] Here is the summary with

Re: [PATCH net-next 0/2] nexthop: Support large scale nexthop flushing

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 16 Apr 2021 18:55:33 +0300 you wrote: > From: Ido Schimmel > > Patch #1 fixes a day-one bug in the nexthop code and allows "ip nexthop > flush" to work correctly with large number of nexthops that do not fit > in

Re: [PATCH net-next] mld: remove unnecessary prototypes

2021-04-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 16 Apr 2021 17:41:48 + you wrote: > Some prototypes are unnecessary, so delete it. > > Signed-off-by: Taehee Yoo > --- > net/ipv6/mcast.c | 3 --- > 1 file changed, 3 deletions(-) Here is the summary with li

Re: [PATCHv7 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-19 Thread Toke Høiland-Jørgensen
"Paul E. McKenney" writes: > On Mon, Apr 19, 2021 at 11:21:41PM +0200, Toke Høiland-Jørgensen wrote: >> "Paul E. McKenney" writes: >> >> > On Mon, Apr 19, 2021 at 08:12:27PM +0200, Toke Høiland-Jørgensen wrote: >> >> "Paul E. McKenney" writes: >> >> >> >> > On Sat, Apr 17, 2021 at 02:27:19PM

Re: [PATCH] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-19 Thread Al Viro
On Tue, Apr 06, 2021 at 07:09:12PM -0500, Aditya Pakki wrote: > --- a/net/rds/send.c > +++ b/net/rds/send.c > @@ -665,7 +665,7 @@ static void rds_send_remove_from_sock(struct list_head > *messages, int status) > unlock_and_drop: > spin_unlock_irqrestore(&rm->m_rs_lock, flags); >

Re: [PATCHv2 RFC bpf-next 0/7] bpf: Add support for ftrace probe

2021-04-19 Thread Steven Rostedt
On Mon, 19 Apr 2021 22:51:46 +0200 Jiri Olsa wrote: > now, it looks like the fgraph_ops entry callback does not have access > to registers.. once we have that, we could store arguments for the exit > callback and have all in place.. could this be added? ;-) Sure. The only problem is that we need

Re: [PATCH bpf-next v2 3/4] libbpf: add low level TC-BPF API

2021-04-19 Thread Daniel Borkmann
On 4/19/21 11:43 PM, Toke Høiland-Jørgensen wrote: Daniel Borkmann writes: On 4/19/21 2:18 PM, Kumar Kartikeya Dwivedi wrote: This adds functions that wrap the netlink API used for adding, manipulating, and removing traffic control filters. These functions operate directly on the loaded prog's

Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

2021-04-19 Thread Jakub Kicinski
On Mon, 19 Apr 2021 23:54:32 +0200 Pablo Neira Ayuso wrote: > On Mon, Apr 19, 2021 at 02:43:41PM -0700, Jakub Kicinski wrote: > > On Mon, 19 Apr 2021 23:40:19 +0200 Pablo Neira Ayuso wrote: > > > No rtnl lock is held from the netfilter side, see: > > > > > > 42f1c2712090 ("netfilter: nftables: c

Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

2021-04-19 Thread Pablo Neira Ayuso
On Mon, Apr 19, 2021 at 02:43:41PM -0700, Jakub Kicinski wrote: > On Mon, 19 Apr 2021 23:40:19 +0200 Pablo Neira Ayuso wrote: > > On Mon, Apr 19, 2021 at 02:16:01PM -0700, Jakub Kicinski wrote: > > > On Sun, 18 Apr 2021 23:11:44 +0200 Pablo Neira Ayuso wrote: > > > > Patch 2ed37183abb7 ("netfilte

  1   2   3   >