On Mon, Apr 19, 2021 at 02:43:41PM -0700, Jakub Kicinski wrote:
> On Mon, 19 Apr 2021 23:40:19 +0200 Pablo Neira Ayuso wrote:
> > On Mon, Apr 19, 2021 at 02:16:01PM -0700, Jakub Kicinski wrote:
> > > On Sun, 18 Apr 2021 23:11:44 +0200 Pablo Neira Ayuso wrote:
> > > > Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy and
> > > > stats to different workqueues") splits the workqueue per event type. Add
> > > > a mutex to serialize updates.
> > > >
> > > > Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading
> > > > support")
> > > > Reported-by: Frank Wunderlich <fran...@public-files.de>
> > > > Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org>
> > >
> > > This driver doesn't set unlocked_driver_cb, why is it expected to take
> > > any locks? I thought the contract is that caller should hold rtnl.
> >
> > No rtnl lock is held from the netfilter side, see:
> >
> > 42f1c2712090 ("netfilter: nftables: comment indirect serialization of
> > commit_mutex with rtnl_mutex")
>
> All the tc-centric drivers but mlx5 depend on rtnl_lock, is there
> something preventing them from binding to netfilter blocks?
Only mlx5 and this driver support for TC_SETUP_FT.
This fix is targetting at the TC_SETUP_FT flow block type.
