Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Jason Wang
On 2021/3/8 3:16 下午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 3:02 PM Jason Wang wrote: On 2021/3/8 12:50 下午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:04 AM Jason Wang wrote: On 2021/3/5 4:12 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: On 2021/3/5 3:27 下午,

Re: mlx5 sub function issue

2021-03-07 Thread ze wang
Hi Parav, Thanks for the answer. There are more than two hundred CPUs on our machine, we're planning to put SFs into the containers, This may requires allocate one SF per CPU,so we want to know the upper limit of creating SFs. By the way, the latest version of the MFT download center is 4.16.1-9,

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Yongji Xie
On Mon, Mar 8, 2021 at 3:02 PM Jason Wang wrote: > > > On 2021/3/8 12:50 下午, Yongji Xie wrote: > > On Mon, Mar 8, 2021 at 11:04 AM Jason Wang wrote: > >> > >> On 2021/3/5 4:12 下午, Yongji Xie wrote: > >>> On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: > On 2021/3/5 3:27 下午, Yongji Xie wrot

Re: [PATCH v6 net-next] virtio-net: support XDP when not more queues

2021-03-07 Thread Jason Wang
On 2021/3/8 1:43 下午, Xuan Zhuo wrote: On Mon, 8 Mar 2021 11:41:03 +0800, Jason Wang wrote: On 2021/3/5 6:29 下午, Xuan Zhuo wrote: The number of queues implemented by many virtio backends is limited, especially some machines have a large number of CPUs. In this case, it is often impossible to

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Yongji Xie
On Mon, Mar 8, 2021 at 3:04 PM Jason Wang wrote: > > > On 2021/3/8 1:05 下午, Yongji Xie wrote: > > On Mon, Mar 8, 2021 at 11:52 AM Jason Wang wrote: > >> > >> On 2021/3/8 11:45 上午, Yongji Xie wrote: > >>> On Mon, Mar 8, 2021 at 11:17 AM Jason Wang wrote: > On 2021/3/5 3:59 下午, Yongji Xie wro

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Jason Wang
On 2021/3/8 1:05 下午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:52 AM Jason Wang wrote: On 2021/3/8 11:45 上午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:17 AM Jason Wang wrote: On 2021/3/5 3:59 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: On 2021/3/5 3:13 下午

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Jason Wang
On 2021/3/8 12:50 下午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:04 AM Jason Wang wrote: On 2021/3/5 4:12 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: On 2021/3/5 3:27 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: On 2021/3/5 2:36 下午,

Re: [BUG] Thunderbolt network package forward speed problem.

2021-03-07 Thread Mika Westerberg
Hi, On Sat, Mar 06, 2021 at 11:33:57PM +0800, Jax Jiang wrote: > Hi! > Authors of Linux thunderbolt-network driver: > > Problem: > > Thunderbolt network <- Software Router(NUC 11) <- 10G NIC Speed is normal= > about 9-10Gbps > Thunderbolt network -> Software Router(NUC 11) -> 10G NIC Speed

Re: [Intel-wired-lan] [PATCH] e1000e: Fix error handling in e1000_set_d0_lplu_state_82571

2021-03-07 Thread Neftin, Sasha
On 2/28/2021 11:44, Dinghao Liu wrote: There is one e1e_wphy() call in e1000_set_d0_lplu_state_82571 that we have caught its return value but lack further handling. Check and terminate the execution flow just like other e1e_wphy() in this function. Signed-off-by: Dinghao Liu --- drivers/net/e

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Yongji Xie
On Mon, Mar 8, 2021 at 11:52 AM Jason Wang wrote: > > > On 2021/3/8 11:45 上午, Yongji Xie wrote: > > On Mon, Mar 8, 2021 at 11:17 AM Jason Wang wrote: > >> > >> On 2021/3/5 3:59 下午, Yongji Xie wrote: > >>> On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: > On 2021/3/5 3:13 下午, Yongji Xie wro

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Yongji Xie
On Mon, Mar 8, 2021 at 11:04 AM Jason Wang wrote: > > > On 2021/3/5 4:12 下午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: > >> > >> On 2021/3/5 3:27 下午, Yongji Xie wrote: > >>> On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: > On 2021/3/5 2:36 下午, Yongji Xie wrote

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Jason Wang
On 2021/3/8 11:45 上午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:17 AM Jason Wang wrote: On 2021/3/5 3:59 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: On 2021/3/5 3:13 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: On 2021/3/5 2:15 下午,

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Yongji Xie
On Mon, Mar 8, 2021 at 11:17 AM Jason Wang wrote: > > > On 2021/3/5 3:59 下午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: > >> > >> On 2021/3/5 3:13 下午, Yongji Xie wrote: > >>> On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: > On 2021/3/5 2:15 下午, Yongji Xie wrote

Re: [PATCH v6 net-next] virtio-net: support XDP when not more queues

2021-03-07 Thread Jason Wang
On 2021/3/5 6:29 下午, Xuan Zhuo wrote: The number of queues implemented by many virtio backends is limited, especially some machines have a large number of CPUs. In this case, it is often impossible to allocate a separate queue for XDP_TX/XDP_REDIRECT, then xdp cannot be loaded to work, even xdp

mlx5 sub function issue

2021-03-07 Thread avis.wang
Hi all,   I have some confusion with mlx5 sub function feature. I tested it with Mellanox ConnectX-6 Dx recently, then I found the maximum amount of SF in each PF is just 128, I‘m not sure if there is a problem with my configuration, or there are some limits of SF in ConnectX-6. Here is the

Re: [PATCH v2 net] net: dsa: fix switchdev objects on bridge master mistakenly being applied on ports

2021-03-07 Thread Florian Fainelli
On 3/7/2021 2:49 PM, Tobias Waldekranz wrote: > On Sun, Mar 07, 2021 at 21:02, Tobias Waldekranz > wrote: >> On Sun, Mar 07, 2021 at 17:48, Vladimir Oltean wrote: >>> On Sun, Mar 07, 2021 at 04:17:14PM +0100, Tobias Waldekranz wrote: Please wait before applying. I need to do so

[PATCH 2/3] atm: uPD98402: fix incorrect allocation

2021-03-07 Thread Tong Zhang
dev->dev_data is set in zatm.c, calling zatm_start() will overwrite this dev->dev_data in uPD98402_start() and a subsequent PRIV(dev)->lock (i.e dev->phy_data->lock) will result in a null-ptr-dereference. I believe this is a typo and what it actually want to do is to allocate phy_data instead of d

[PATCH 3/3] atm: idt77252: fix null-ptr-dereference

2021-03-07 Thread Tong Zhang
this one is similar to the phy_data allocation fix in uPD98402, the driver allocate the idt77105_priv and store to dev_data but later dereference using dev->dev_data, which will cause null-ptr-dereference. fix this issue by changing dev_data to phy_data so that PRIV(dev) can work correctly. Signe

[PATCH 1/3] atm: fix a typo in the struct description

2021-03-07 Thread Tong Zhang
phy_data means private PHY data not date Signed-off-by: Tong Zhang --- include/linux/atmdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/atmdev.h b/include/linux/atmdev.h index 60cd25c0461b..9b02961d65ee 100644 --- a/include/linux/atmdev.h +++ b/include/lin

[PATCH 0/3] fix a couple of atm->phy_data related issues

2021-03-07 Thread Tong Zhang
there are two drivers(zatm and idt77252) using PRIV() (i.e. atm->phy_data) to store private data, but the driver happens to populate wrong pointers: atm->dev_data. which actually cause null-ptr-dereference in following PRIV(dev). This patch series attemps to fix those two issues along with a typo

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Jason Wang
On 2021/3/5 3:59 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: On 2021/3/5 3:13 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: On 2021/3/5 2:15 下午, Yongji Xie wrote: Sorry if I've asked this before. But what's the reason for maintaing a d

[PATCH] net: bonding: fix error return code of bond_neigh_init()

2021-03-07 Thread Jia-Ju Bai
When slave is NULL or slave_ops->ndo_neigh_setup is NULL, no error return code of bond_neigh_init() is assigned. To fix this bug, ret is assigned with -EINVAL in these cases. Fixes: 9e99bfefdbce ("bonding: fix bond_neigh_init()") Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Jason Wang
On 2021/3/5 4:12 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: On 2021/3/5 3:27 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: On 2021/3/5 2:36 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: On 2021/3/5 11:30 上午,

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-07 Thread Jason Wang
On 2021/3/5 10:19 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA. C5000X-PL vendor id 0x1AF4, device id 0x1000, subvendor id 0x8086, sub device id 0x0001 To distinguish C5000X-PL from other ifcvf driven devices, the original ifcvf device is named

Re: [PATCH 1/3] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-07 Thread Jason Wang
On 2021/3/5 10:19 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [PATCH 3/3] vDPA/ifcvf: bump version string to 1.0

2021-03-07 Thread Zhu, Lingshan
Hi Leon, Thanks for point this out, will send a V2 patchset delete it. Thanks Zhu Lingshan On 3/7/2021 5:01 PM, Leon Romanovsky wrote: On Fri, Mar 05, 2021 at 10:20:00PM +0800, Zhu Lingshan wrote: This commit bumps ifcvf driver version string to 1.0 Signed-off-by: Zhu Lingshan --- drivers

Re: [PATCH] bonding: 3ad: fix a use-after-free in bond_3ad_state_machine_handle

2021-03-07 Thread zhudi (J)
> >From: Di Zhu > > > >I use the similar test method described in link below with KASAN enabled: > >https://lore.kernel.org/netdev/4c5e467e07fb410ab4135b391d663ec1@hua > wei. > >com/ > >soon after, KASAN reports: > >[ 9041.977110] > >= >

[syzbot] WARNING: ODEBUG bug in net_dm_cmd_trace

2021-03-07 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:d310ec03 Merge tag 'perf-core-2021-02-17' of git://git.ker.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=108adb32d0 kernel config: https://syzkaller.appspot.com/x/.config?x=2b8307379601586a das

Re: [PATCH v2 net] net: dsa: fix switchdev objects on bridge master mistakenly being applied on ports

2021-03-07 Thread Tobias Waldekranz
On Sun, Mar 07, 2021 at 21:02, Tobias Waldekranz wrote: > On Sun, Mar 07, 2021 at 17:48, Vladimir Oltean wrote: >> On Sun, Mar 07, 2021 at 04:17:14PM +0100, Tobias Waldekranz wrote: >>> Please wait before applying. >>> >>> I need to do some more testing later (possibly tomorrow). But I am >>> pr

Re: [PATCH] wireguard: netlink: add multicast notification for peer changes

2021-03-07 Thread Jason A. Donenfeld
Hey Linus, Thanks for the patch and sorry for the delay in reviewing it. Seeing the basic scaffolding for getting netlink notifiers working with WireGuard is enlightening; it looks surprisingly straightforward. There are three classes of things that are interesting to receive notifications for:

[syzbot] general protection fault in btf_type_id_size

2021-03-07 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:6185266c selftests/bpf: Mask bpf_csum_diff() return value .. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=14fd4ff2d0 kernel config: https://syzkaller.appspot.com/x/.config?x=e2d5ba72abae4f14 dashboar

Re: [PATCH] gianfar: fix jumbo packets+napi+rx overrun crash

2021-03-07 Thread michael-dev
Hi, sorry I missed the mail. Am 04.03.2021 11:05, schrieb Claudiu Manoil: Could you help provide some context, e.g.: On what board/soc were you able to trigger this issue? I have an OpenWRT running on P1020WLAN boards and have IPsec for some gretap tunnel configured. I run iperf3 -s on the A

Re: [PATCHv2] gianfar: fix jumbo packets+napi+rx overrun crash

2021-03-07 Thread michael-dev
Am 04.03.2021 21:17, schrieb Vladimir Oltean: Just for my understanding, do you have a reproducer for the issue? I notice you haven't answered Claudiu's questions posted on v1. On LS1021A I cannot trigger this apparent hardware issue even if I force RX overruns (by reducing the ring size). Judgi

Re: [PATCH v2 net] net: dsa: fix switchdev objects on bridge master mistakenly being applied on ports

2021-03-07 Thread Tobias Waldekranz
On Sun, Mar 07, 2021 at 17:48, Vladimir Oltean wrote: > On Sun, Mar 07, 2021 at 04:17:14PM +0100, Tobias Waldekranz wrote: >> Please wait before applying. >> >> I need to do some more testing later (possibly tomorrow). But I am >> pretty sure that this patch does not work with the (admittedly som

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-07 Thread Leon Romanovsky
On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > On Sun, Feb 28, 2021 at 11:55 PM Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > @Alexander Duyck, please update me if I can add your ROB tag again > > to the series, because you liked v6 more. > > > > Thanks > > > >

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-07 Thread Alexander Duyck
On Sun, Feb 28, 2021 at 11:55 PM Leon Romanovsky wrote: > > From: Leon Romanovsky > > @Alexander Duyck, please update me if I can add your ROB tag again > to the series, because you liked v6 more. > > Thanks > > - > C

[RFC PATCH v6 22/22] virtio/vsock: update trace event for SEQPACKET

2021-03-07 Thread Arseny Krasnov
This updates current implementation for trace event of virtio vsock: SEQPACKET socket's type, SEQPACKET specific ops and SEQPACKET 'msg_len' and 'msg_id' fields are added. Signed-off-by: Arseny Krasnov --- .../events/vsock_virtio_transport_common.h| 48 ++- net/vmw_vsock/virt

[RFC PATCH v6 21/22] vsock_test: add SOCK_SEQPACKET tests

2021-03-07 Thread Arseny Krasnov
This adds two tests of SOCK_SEQPACKET socket: both transfer data and then test MSG_EOR and MSG_TRUNC flags. Cases for connect(), bind(), etc. are not tested, because it is same as for stream socket. Signed-off-by: Arseny Krasnov --- tools/testing/vsock/util.c | 32 ++-- tools/testing/

[RFC PATCH v6 20/22] vsock/loopback: setup SEQPACKET ops for transport

2021-03-07 Thread Arseny Krasnov
This adds SEQPACKET ops for loopback transport and 'seqpacket_allow()' callback. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/vsock_loopback.c | 13 + 1 file changed, 13 insertions(+) diff --git a/net/vmw_vsock/vsock_loopback.c b/net/vmw_vsock/vsock_loopback.c index a45f7ffca8c5.

[RFC PATCH v6 19/22] vhost/vsock: setup SEQPACKET ops for transport

2021-03-07 Thread Arseny Krasnov
This also removes ignore of non-stream type of packets and adds 'seqpacket_allow()' callback. Signed-off-by: Arseny Krasnov --- drivers/vhost/vsock.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index 3b0a50e6

[RFC PATCH v6 18/22] virtio/vsock: setup SEQPACKET ops for transport

2021-03-07 Thread Arseny Krasnov
This adds SEQPACKET ops for virtio transport and 'seqpacket_allow()' callback. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/virtio_transport.c | 13 + 1 file changed, 13 insertions(+) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index 41c5d0a31

[RFC PATCH v6 17/22] virtio/vsock: SEQPACKET feature bit support

2021-03-07 Thread Arseny Krasnov
This adds handling of SEQPACKET bit: guest tries to negotiate it with vhost. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/virtio_transport.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index 2700a63ab095..41c5d0a

[RFC PATCH v6 15/22] virtio/vsock: SEQPACKET support feature bit

2021-03-07 Thread Arseny Krasnov
This adds new virtio vsock specific feature bit which means SOCK_SEQPACKET support. Guest negotiates this bit with vhost, thus checking that vhost side supports SEQPACKET. Signed-off-by: Arseny Krasnov --- include/uapi/linux/virtio_vsock.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/i

[RFC PATCH v6 16/22] vhost/vsock: SEQPACKET feature bit support

2021-03-07 Thread Arseny Krasnov
This adds handling of SEQPACKET bit: if guest sets features with this bit cleared, then SOCK_SEQPACKET support will be disabled. Signed-off-by: Arseny Krasnov --- drivers/vhost/vsock.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/

[RFC PATCH v6 13/22] virtio/vsock: add SEQPACKET receive logic

2021-03-07 Thread Arseny Krasnov
This modifies current receive logic for SEQPACKET support: 1) Inserts 'SEQ_BEGIN' packet to socket's rx queue. 2) Inserts 'RW' packet to socket's rx queue, but without merging with buffer of last packet in queue. 3) Performs check for packet and socket types on receive(if mismatch, then reset

[RFC PATCH v6 14/22] virtio/vsock: rest of SOCK_SEQPACKET support

2021-03-07 Thread Arseny Krasnov
This adds rest of logic for SEQPACKET: 1) SEQPACKET specific functions which send SEQ_BEGIN/SEQ_END. Note that both functions may sleep to wait enough space for SEQPACKET header. 2) SEQ_BEGIN/SEQ_END in TAP packet capture. 3) Send SHUTDOWN on socket close for SEQPACKET type. 4) Set SEQPACKET

[RFC PATCH v6 12/22] virtio/vsock: fetch length for SEQPACKET record

2021-03-07 Thread Arseny Krasnov
This adds transport callback which tries to fetch record begin marker from socket's rx queue. It is called from af_vsock.c before reading data packets of record. Signed-off-by: Arseny Krasnov --- include/linux/virtio_vsock.h| 1 + net/vmw_vsock/virtio_transport_common.c | 53 +++

[RFC PATCH v6 11/22] virtio/vsock: dequeue callback for SOCK_SEQPACKET

2021-03-07 Thread Arseny Krasnov
This adds transport callback and it's logic for SEQPACKET dequeue. Callback fetches RW packets from rx queue of socket until whole record is copied(if user's buffer is full, user is not woken up). This is done to not stall sender, because if we wake up user and it leaves syscall, nobody will send c

[RFC PATCH v6 10/22] virtio/vsock: simplify credit update function API

2021-03-07 Thread Arseny Krasnov
This function is static and 'hdr' arg was always NULL. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/virtio_transport_common.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c index f69

[RFC PATCH v6 08/22] af_vsock: update comments for stream sockets

2021-03-07 Thread Arseny Krasnov
This replaces 'stream' to 'connection oriented' in comments as SEQPACKET is also connection oriented. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/af_vsock.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vm

[RFC PATCH v6 09/22] virtio/vsock: set packet's type in virtio_transport_send_pkt_info()

2021-03-07 Thread Arseny Krasnov
This moves passing type of packet from 'info' structure to 'virtio_ transport_send_pkt_info()' function. There is no need to set type of packet which differs from type of socket. Since at current time only stream type is supported, set it directly in 'virtio_transport_send_ pkt_info()', so callers

[RFC PATCH v6 07/22] af_vsock: rest of SEQPACKET support

2021-03-07 Thread Arseny Krasnov
This does rest of SOCK_SEQPACKET support: 1) Adds socket ops for SEQPACKET type. 2) Allows to create socket with SEQPACKET type. Signed-off-by: Arseny Krasnov --- include/net/af_vsock.h | 1 + net/vmw_vsock/af_vsock.c | 36 +++- 2 files changed, 36 insertions(+

[RFC PATCH v6 06/22] af_vsock: implement send logic for SEQPACKET

2021-03-07 Thread Arseny Krasnov
This adds some logic to current stream enqueue function for SEQPACKET support: 1) Use transport's seqpacket enqueue callback. 2) Return value from enqueue function is whole record length or error for SOCK_SEQPACKET. Signed-off-by: Arseny Krasnov --- include/net/af_vsock.h | 2 ++ net/vmw_v

[RFC PATCH v6 05/22] af_vsock: separate wait space loop

2021-03-07 Thread Arseny Krasnov
This moves loop that waits for space on send to separate function, because it will be used for SEQ_BEGIN/SEQ_END sending before and after data transmission. Waiting for SEQ_BEGIN/SEQ_END is needed because such packets carries SEQPACKET header that couldn't be fragmented by credit mechanism, so to a

[RFC PATCH v6 04/22] af_vsock: implement SEQPACKET receive loop

2021-03-07 Thread Arseny Krasnov
This adds receive loop for SEQPACKET. It looks like receive loop for STREAM, but there is a little bit difference: 1) It doesn't call notify callbacks. 2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because there is no sense for these values in SEQPACKET case. 3) It waits until

[RFC PATCH v6 03/22] af_vsock: separate receive data loop

2021-03-07 Thread Arseny Krasnov
Move STREAM specific data receive logic to '__vsock_stream_recvmsg()' dedicated function, while checks, that will be same for both STREAM and SEQPACKET sockets, stays in 'vsock_connectible_recvmsg()' shared functions. Signed-off-by: Arseny Krasnov Reviewed-by: Stefano Garzarella --- net/vmw_vso

[RFC PATCH v6 02/22] af_vsock: separate wait data loop

2021-03-07 Thread Arseny Krasnov
This moves wait loop for data to dedicated function, because later it will be used by SEQPACKET data receive loop. While moving the code around, let's update an old comment. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/af_vsock.c | 156 +-- 1 file changed,

[RFC PATCH v6 01/22] af_vsock: update functions for connectible socket

2021-03-07 Thread Arseny Krasnov
This prepares af_vsock.c for SEQPACKET support: some functions such as setsockopt(), getsockopt(), connect(), recvmsg(), sendmsg() are shared between both types of sockets, so rename them in general manner. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/af_vsock.c | 64 +

[RFC PATCH v6 00/22] virtio/vsock: introduce SOCK_SEQPACKET support

2021-03-07 Thread Arseny Krasnov
This patchset implements support of SOCK_SEQPACKET for virtio transport. As SOCK_SEQPACKET guarantees to save record boundaries, so to do it, two new packet operations were added: first for start of record and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also, both op

Re: [RFC] devlink: health: add remediation type

2021-03-07 Thread Eran Ben Elisha
On 3/6/2021 4:42 AM, Jakub Kicinski wrote: Currently devlink health does not give user any clear information of what kind of remediation ->recover callback will perform. This makes it difficult to understand the impact of enabling auto- -remediation, and the severity of the error itself. To a

Re: [PATCH v2 net] net: dsa: fix switchdev objects on bridge master mistakenly being applied on ports

2021-03-07 Thread Vladimir Oltean
On Sun, Mar 07, 2021 at 04:17:14PM +0100, Tobias Waldekranz wrote: > Please wait before applying. > > I need to do some more testing later (possibly tomorrow). But I am > pretty sure that this patch does not work with the (admittedly somewhat > exotic) combination of: > > - Non-offloaded LAG > -

Re: [PATCH v2 net] net: dsa: fix switchdev objects on bridge master mistakenly being applied on ports

2021-03-07 Thread Tobias Waldekranz
On Sun, Mar 07, 2021 at 12:21, Vladimir Oltean wrote: > From: Vladimir Oltean > > Tobias reports that after the blamed patch, VLAN objects being added to > a bridge device are being added to all slave ports instead (swp2, swp3). > > ip link add br0 type bridge vlan_filtering 1 > ip link set swp2

RE: [PATCH v10 01/20] dlb: add skeleton for DLB driver

2021-03-07 Thread Chen, Mike Ximing
> -Original Message- > From: gre...@linuxfoundation.org > Sent: Thursday, February 18, 2021 2:53 AM > To: Chen, Mike Ximing > Cc: netdev@vger.kernel.org; Linux Kernel Mailing List ker...@vger.kernel.org>; da...@davemloft.net; k...@kernel.org; a...@arndb.de; > Williams, Dan J ; > pier

[PATCH net 2/2] net: enetc: allow hardware timestamping on TX queues with tc-etf enabled

2021-03-07 Thread Vladimir Oltean
From: Vladimir Oltean The txtime is passed to the driver in skb->skb_mstamp_ns, which is actually in a union with skb->tstamp (the place where software timestamps are kept). Since commit b50a5c70ffa4 ("net: allow simultaneous SW and HW transmit timestamping"), __sock_recv_timestamp has some logi

[PATCH net 1/2] net: enetc: set MAC RX FIFO to recommended value

2021-03-07 Thread Vladimir Oltean
From: Alex Marginean On LS1028A, the MAC RX FIFO defaults to the value 2, which is too high and may lead to RX lock-up under traffic at a rate higher than 6 Gbps. Set it to 1 instead, as recommended by the hardware design team and by later versions of the ENETC block guide. Signed-off-by: Alex M

[PATCH 3/3] net: davicom: Use platform_get_irq_optional()

2021-03-07 Thread Paul Cercueil
The second IRQ line really is optional, so use platform_get_irq_optional() to obtain it. Signed-off-by: Paul Cercueil --- drivers/net/ethernet/davicom/dm9000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davico

[PATCH 2/3] net: davicom: Fix regulator not turned off on driver removal

2021-03-07 Thread Paul Cercueil
We must disable the regulator that was enabled in the probe function. Fixes: 7994fe55a4a2 ("dm9000: Add regulator and reset support to dm9000") Signed-off-by: Paul Cercueil --- drivers/net/ethernet/davicom/dm9000.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH 1/3] net: davicom: Fix regulator not turned off on failed probe

2021-03-07 Thread Paul Cercueil
When the probe fails or requests to be defered, we must disable the regulator that was previously enabled. Fixes: 7994fe55a4a2 ("dm9000: Add regulator and reset support to dm9000") Signed-off-by: Paul Cercueil --- drivers/net/ethernet/davicom/dm9000.c | 12 +--- 1 file changed, 9 inserti

Re: [PATCH] ath: ath6kl: fix error return code of ath6kl_htc_rx_bundle()

2021-03-07 Thread Leon Romanovsky
On Sun, Mar 07, 2021 at 05:31:01PM +0800, Jia-Ju Bai wrote: > Hi Leon, > > I am quite sorry for my incorrect patches... > My static analysis tool reports some possible bugs about error handling > code, and thus I write some patches for the bugs that seem to be true in my > opinion. > Because I am n

[PATCH] brcmfmac: Add support for BCM43596 PCIe Wi-Fi

2021-03-07 Thread Konrad Dybcio
Add support for BCM43596 dual-band AC chip, found in SONY Xperia X Performance, XZ and XZs smartphones (and *possibly* other devices from other manufacturers). The chip doesn't require any special handling and seems to work just fine OOTB. PCIe IDs taken from: https://github.com/sonyxperiadev/ker

[PATCH net] net: lapbether: Remove netif_start_queue / netif_stop_queue

2021-03-07 Thread Xie He
For the devices in this driver, the default qdisc is "noqueue", because their "tx_queue_len" is 0. In function "__dev_queue_xmit" in "net/core/dev.c", devices with the "noqueue" qdisc are specially handled. Packets are transmitted without being queued after a "dev->flags & IFF_UP" check. However,

Re: [PATCHv2 bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-07 Thread Jiri Olsa
On Sat, Mar 06, 2021 at 07:13:17PM -0800, Andrii Nakryiko wrote: > On Fri, Mar 5, 2021 at 5:42 AM Jiri Olsa wrote: > > > > When testing uprobes we the test gets GEP (Global Entry Point) > > address from kallsyms, but then the function is called locally > > so the uprobe is not triggered. > > > > F

Re: [PATCH] ath: ath6kl: fix error return code of ath6kl_htc_rx_bundle()

2021-03-07 Thread Heiner Kallweit
On 07.03.2021 10:31, Jia-Ju Bai wrote: > Hi Leon, > > I am quite sorry for my incorrect patches... > My static analysis tool reports some possible bugs about error handling code, > and thus I write some patches for the bugs that seem to be true in my opinion. > Because I am not familiar with many

[PATCH v2 net] net: dsa: fix switchdev objects on bridge master mistakenly being applied on ports

2021-03-07 Thread Vladimir Oltean
From: Vladimir Oltean Tobias reports that after the blamed patch, VLAN objects being added to a bridge device are being added to all slave ports instead (swp2, swp3). ip link add br0 type bridge vlan_filtering 1 ip link set swp2 master br0 ip link set swp3 master br0 bridge vlan add dev br0 vid

Re: [PATCH net 2/2] net: dsa: Always react to global bridge attribute changes

2021-03-07 Thread Vladimir Oltean
On Sun, Mar 07, 2021 at 10:51:18AM +0100, Tobias Waldekranz wrote: > On Sun, Mar 07, 2021 at 02:58, Vladimir Oltean wrote: > > On Sat, Mar 06, 2021 at 07:17:09PM +0100, Tobias Waldekranz wrote: > >> On Sat, Mar 06, 2021 at 16:04, Vladimir Oltean wrote: > >> > On Sat, Mar 06, 2021 at 04:00:33PM +0

Re: [PATCH net 2/2] net: dsa: Always react to global bridge attribute changes

2021-03-07 Thread Tobias Waldekranz
On Sun, Mar 07, 2021 at 02:58, Vladimir Oltean wrote: > On Sat, Mar 06, 2021 at 07:17:09PM +0100, Tobias Waldekranz wrote: >> On Sat, Mar 06, 2021 at 16:04, Vladimir Oltean wrote: >> > On Sat, Mar 06, 2021 at 04:00:33PM +0200, Vladimir Oltean wrote: >> >> Hi Tobias, >> >> >> >> On Sat, Mar 06, 20

Re: [PATCH] ath: ath6kl: fix error return code of ath6kl_htc_rx_bundle()

2021-03-07 Thread Jia-Ju Bai
Hi Leon, I am quite sorry for my incorrect patches... My static analysis tool reports some possible bugs about error handling code, and thus I write some patches for the bugs that seem to be true in my opinion. Because I am not familiar with many device drivers, some of my reported bugs can be

Re: seqlock lockdep false positives?

2021-03-07 Thread Ahmed S. Darwish
Hi Jakub, On Wed, Mar 03, 2021 at 04:40:35PM -0800, Jakub Kicinski wrote: > Hi Ahmed! > > Erhard is reporting a lockdep splat in drivers/net/ethernet/realtek/8139too.c > > https://bugzilla.kernel.org/show_bug.cgi?id=211575 > > I can't quite grasp how that happens it looks like it's the Rx > lock/s

Re: [PATCH] ath: ath6kl: fix error return code of ath6kl_htc_rx_bundle()

2021-03-07 Thread Leon Romanovsky
On Sun, Mar 07, 2021 at 01:07:57AM -0800, Jia-Ju Bai wrote: > When hif_scatter_req_get() returns NULL to scat_req, no error return > code of ath6kl_htc_rx_bundle() is assigned. > To fix this bug, status is assigned with -EINVAL in this case. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai

[PATCH] net: wan: fix error return code of uhdlc_init()

2021-03-07 Thread Jia-Ju Bai
When priv->rx_skbuff or priv->tx_skbuff is NULL, no error return code of uhdlc_init() is assigned. To fix this bug, ret is assigned with -ENOMEM in these cases. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net/wan/fsl_ucc_hdlc.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH] ath: ath6kl: fix error return code of ath6kl_htc_rx_bundle()

2021-03-07 Thread Jia-Ju Bai
When hif_scatter_req_get() returns NULL to scat_req, no error return code of ath6kl_htc_rx_bundle() is assigned. To fix this bug, status is assigned with -EINVAL in this case. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net/wireless/ath/ath6kl/htc_mbox.c | 4 +++- 1 file chang

Re: [PATCH 3/3] vDPA/ifcvf: bump version string to 1.0

2021-03-07 Thread Leon Romanovsky
On Fri, Mar 05, 2021 at 10:20:00PM +0800, Zhu Lingshan wrote: > This commit bumps ifcvf driver version string to 1.0 > > Signed-off-by: Zhu Lingshan > --- > drivers/vdpa/ifcvf/ifcvf_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/d

Re: [PATCH] net: mellanox: mlx5: fix error return code in mlx5_fpga_device_start()

2021-03-07 Thread Leon Romanovsky
On Thu, Mar 04, 2021 at 06:18:14AM -0800, Jia-Ju Bai wrote: > When mlx5_is_fpga_lookaside() returns a non-zero value, no error > return code is assigned. > To fix this bug, err is assigned with -EINVAL as error return code. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai > --- > drivers/

[PATCH] net: hisilicon: hns: fix error return code of hns_nic_clear_all_rx_fetch()

2021-03-07 Thread Jia-Ju Bai
When hns_assemble_skb() returns NULL to skb, no error return code of hns_nic_clear_all_rx_fetch() is assigned. To fix this bug, ret is assigned with -ENOMEM in this case. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 +++- 1 file changed

[PATCH] rsi: fix error return code of rsi_load_9116_firmware()

2021-03-07 Thread Jia-Ju Bai
When kmemdup() returns NULL to ta_firmware, no error return code of rsi_load_9116_firmware() is assigned. To fix this bug, status is assigned with -ENOMEM in this case. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net/wireless/rsi/rsi_91x_hal.c | 4 +++- 1 file changed, 3 inser

[PATCH] ti: wlcore: fix error return code of wl1271_cmd_build_ps_poll()

2021-03-07 Thread Jia-Ju Bai
When ieee80211_pspoll_get() returns NULL to skb, no error return code of wl1271_cmd_build_ps_poll() is assigned. To fix this bug, ret is assigned with -ENOMEM in this case. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net/wireless/ti/wlcore/cmd.c | 4 +++- 1 file changed, 3 ins

Re: [PATCH] net: mellanox: mlxsw: fix error return code of mlxsw_sp_router_nve_promote_decap()

2021-03-07 Thread Ido Schimmel
On Sat, Mar 06, 2021 at 03:32:39PM +0100, Heiner Kallweit wrote: > On 06.03.2021 15:07, Jia-Ju Bai wrote: > > When fib_entry is NULL, no error return code of > > mlxsw_sp_router_nve_promote_decap() is assigned. > > To fix this bug, err is assigned with -EINVAL in this case. > > > Again, are you su

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-07 Thread Leon Romanovsky
On Mon, Mar 01, 2021 at 09:55:20AM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > @Alexander Duyck, please update me if I can add your ROB tag again > to the series, because you liked v6 more. > > Thanks > > ---