[PATCH] ethernet/broadcom:remove unneeded variable: "ret"

2021-02-21 Thread dingsenjie
From: dingsenjie remove unneeded variable: "ret". Signed-off-by: dingsenjie --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_m

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-21 Thread Michael S. Tsirkin
On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason Wang wrote: > > On 2021/2/19 7:54 下午, Si-Wei Liu wrote: > > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked > > for legacy") made an exception for legacy guests to reset > > features to 0, when config space is accessed before features >

Re: [PATCH] Revert "ath9k: fix ath_tx_process_buffer() potential null ptr dereference"

2021-02-21 Thread Kalle Valo
Shuah Khan wrote: > This reverts commit a56c14bb21b296fb6d395164ab62ef2e419e5069. > > ath_tx_process_buffer() doesn't dereference or check sta and passes it > to ath_tx_complete_aggr() and ath_tx_complete_buf(). > > ath_tx_complete_aggr() checks the pointer before use. No problem here. > > ath

Re: [PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

2021-02-21 Thread Kalle Valo
陈浩 writes: > By git blame command, I know that the assignment of .driver.pm = > RTW_PM_OPS > > was in commit 44bc17f7f5b3b("rtw88: support wowlan feature for > 8822c"), > > and another commit 7dc7c41607d19("avoid unused function warnings") > > pointed out rtw_pci_resume() and rtw_pci_suspend() ar

Re: [PATCH bpf-next v3 1/2] bpf, xdp: per-map bpf_redirect_map functions for XDP

2021-02-21 Thread Jesper Dangaard Brouer
On Sun, 21 Feb 2021 21:09:53 +0100 Björn Töpel wrote: > From: Björn Töpel > > Currently the bpf_redirect_map() implementation dispatches to the > correct map-lookup function via a switch-statement. To avoid the > dispatching, this change adds one bpf_redirect_map() implementation per > map. Cor

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-21 Thread Martin Schiller
On 2021-02-19 21:28, Xie He wrote: On Fri, Feb 19, 2021 at 10:39 AM Jakub Kicinski wrote: Not entirely sure what the argument is about but adding constants would certainly help. Leon wants me to replace this: dev->needed_headroom = 3 - 1; with this: /* 2 is the result of 3 - 1 */ dev->n

[RFC PATCH 1/4] i40e: use minimal tx and rx pairs for kdump

2021-02-21 Thread Coiby Xu
Set the number of the MSI-X vectors to 1. When MSI-X is enabled, it's not allowed to use more TC queue pairs than MSI-X vectors (pf->num_lan_msix) exist. Thus the number of tx and rx pairs (vsi->num_queue_pairs) will be equal to the number of MSI-X vectors, i.e., 1. Signed-off-by: Coiby Xu --- d

[RFC PATCH 4/4] i40e: don't open i40iw client for kdump

2021-02-21 Thread Coiby Xu
i40iw consumes huge amounts of memory. For example, on a x86_64 machine, i40iw consumed 1.5GB for Intel Corporation Ethernet Connection X722 for for 1GbE while "craskernel=auto" only reserved 160M. With the module parameter "resource_profile=2", we can reduce the memory usage of i40iw to ~300M whic

[RFC PATCH 2/4] i40e: use minimal rx and tx ring buffers for kdump

2021-02-21 Thread Coiby Xu
Use the minimum of the number of descriptors thus we will allocate the minimal ring buffers for kdump. Signed-off-by: Coiby Xu --- drivers/net/ethernet/intel/i40e/i40e_main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ether

[RFC PATCH 3/4] i40e: use minimal admin queue for kdump

2021-02-21 Thread Coiby Xu
The minimum size of admin send/receive queue is 1 and 2 respectively. The admin send queue can't be set to 1 because in that case, the firmware would fail to init. Signed-off-by: Coiby Xu --- drivers/net/ethernet/intel/i40e/i40e.h | 2 ++ drivers/net/ethernet/intel/i40e/i40e_main.c | 9

[RFC PATCH 0/4] Reducing memory usage of i40e for kdump

2021-02-21 Thread Coiby Xu
Currently, i40e consumes lots of memory and causes the failure of kdump. After reducing the allocation of tx/rx/arg/asq ring buffers to the minimum, the memory consumption is significantly reduced, - x86_64: 85.1MB to 1.2MB - POWER9: 15368.5MB to 20.8MB i40iw consumes even much more memo

Reply back

2021-02-21 Thread Adrien Saif
-- Hello, This is attorney Adrien Saif, the legal practitioner to Qatif Oil And Gas Group of Companies. Did you receive the proposal we sent to you via email days ago? Best Regards, Adrien Saif

RE: [PATCH net] r8152: move r8153_mac_clk_spd

2021-02-21 Thread Hayes Wang
Jakub Kicinski > Sent: Saturday, February 20, 2021 2:23 AM [...] > Any word on what user-visible misbehavior this causes? I think it influences the power saving for suspending. I am checking it with our engineers. > Can you provide a Fixes tag? Yes. I will add it when I updating this patch. Bes

[PATCH net-next] net/sched: cls_flower: validate ct_state for invalid and reply flags

2021-02-21 Thread wenxu
From: wenxu Add invalid and reply flags validate in the fl_validate_ct_state. Signed-off-by: wenxu --- net/sched/cls_flower.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index 2409e52..18430db 100644 --- a/net/sched/cls_f

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-21 Thread Eli Cohen
On Sun, Feb 21, 2021 at 04:52:05PM -0500, Michael S. Tsirkin wrote: > On Sun, Feb 21, 2021 at 04:44:37PM +0200, Eli Cohen wrote: > > On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote: > > > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked > > > for legacy") made an exception f

Re: [RFC PATCH net-next 12/12] Documentation: networking: switchdev: fix command for static FDB entries

2021-02-21 Thread Florian Fainelli
On 2/21/2021 13:33, Vladimir Oltean wrote: From: Vladimir Oltean The "bridge fdb add" command provided in the switchdev documentation is junk now, not only because it is syntactically incorrect and rejected by the iproute2 bridge program, but also because it was not updated in light of Arkad

Re: [RFC PATCH net-next 10/12] Documentation: networking: dsa: add paragraph for the HSR/PRP offload

2021-02-21 Thread Florian Fainelli
On 2/21/2021 13:33, Vladimir Oltean wrote: From: Vladimir Oltean Add a short summary of the methods that a driver writer must implement for offloading a HSR/PRP network interface. Cc: George McCollister Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next 09/12] Documentation: networking: dsa: add paragraph for the MRP offload

2021-02-21 Thread Florian Fainelli
On 2/21/2021 13:33, Vladimir Oltean wrote: From: Vladimir Oltean Add a short summary of the methods that a driver writer must implement for getting an MRP instance to work on top of a DSA switch. Cc: Horatiu Vultur Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next 08/12] Documentation: networking: dsa: add paragraph for the LAG offload

2021-02-21 Thread Florian Fainelli
On 2/21/2021 13:33, Vladimir Oltean wrote: From: Vladimir Oltean Add a short summary of the methods that a driver writer must implement for offloading a link aggregation group, and what is still missing. Cc: Tobias Waldekranz Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli

Re: [RFC PATCH net-next 07/12] Documentation: networking: dsa: mention integration with devlink

2021-02-21 Thread Florian Fainelli
On 2/21/2021 13:33, Vladimir Oltean wrote: From: Vladimir Oltean Add a short summary of the devlink features supported by the DSA core. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next 05/12] Documentation: networking: dsa: remove TODO about porting more vendor drivers

2021-02-21 Thread Florian Fainelli
On 2/21/2021 13:33, Vladimir Oltean wrote: From: Vladimir Oltean On one hand, the link is dead and therefore useless. On the other hand, there are always more drivers to port, but at this stage, DSA does not need to affirm itself as the driver model to use for Ethernet-connected switches (s

Re: [RFC PATCH net-next 04/12] Documentation: networking: dsa: remove references to switchdev prepare/commit

2021-02-21 Thread Florian Fainelli
On 2/21/2021 13:33, Vladimir Oltean wrote: From: Vladimir Oltean After the recent series containing commit bae33f2b5afe ("net: switchdev: remove the transaction structure from port attributes"), there aren't prepare/commit transactional phases anymore in most of the switchdev objects/attribu

Re: [RFC PATCH net-next 06/12] Documentation: networking: dsa: document the port_bridge_flags method

2021-02-21 Thread Florian Fainelli
On 2/21/2021 13:33, Vladimir Oltean wrote: From: Vladimir Oltean The documentation was already lagging behind by not mentioning the old version of port_bridge_flags (port_set_egress_floods). So now we are skipping one step and just explaining how a DSA driver should configure address learnin

Re: [RFC PATCH net-next 03/12] Documentation: networking: dsa: remove static port count from limitations

2021-02-21 Thread Florian Fainelli
On 2/21/2021 13:33, Vladimir Oltean wrote: From: Vladimir Oltean After Vivien's series from 2019 containing commits 27d4d19d7c82 ("net: dsa: remove limitation of switch index value") and ab8ccae122a4 ("net: dsa: add ports list in the switch fabric"), this is basically no longer true. Signed

Re: [RFC PATCH net-next 02/12] Documentation: networking: dsa: rewrite chapter about tagging protocol

2021-02-21 Thread Florian Fainelli
On 2/21/2021 13:33, Vladimir Oltean wrote: From: Vladimir Oltean The chapter about tagging protocols is out of date because it doesn't mention all taggers that have been added since last documentation update. But judging based on that, it will always tend to lag behind, and there's no good r

Re: [RFC PATCH net-next 01/12] Documentation: networking: update the graphical representation

2021-02-21 Thread Florian Fainelli
On 2/21/2021 13:33, Vladimir Oltean wrote: From: Vladimir Oltean While preparing some slides for a customer presentation, I found the existing high-level view to be a bit confusing, so I modified it a little bit. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net] bcm63xx_enet: fix sporadic kernel panic

2021-02-21 Thread Florian Fainelli
On 2/21/2021 17:35, Sieng Piaw Liew wrote: In ndo_stop functions, netdev_completed_queue() is called during forced tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if there is any tx skb left. This patch moves netdev_reset_queue() to after tx reclaim, so BQL can complete

Re: [PATCH V3 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-02-21 Thread Willem de Bruijn
On Wed, Feb 17, 2021 at 1:14 PM Andreas Roeseler wrote: > > Modify the icmp_rcv function to check for PROBE messages and call > icmp_echo if a PROBE request is detected. > > Modify the existing icmp_echo function to respond to both ping and PROBE > requests. > > This was tested using a custom modi

Re: [PATCH V3 net-next 1/5] icmp: add support for RFC 8335 PROBE

2021-02-21 Thread Willem de Bruijn
On Wed, Feb 17, 2021 at 1:10 PM Andreas Roeseler wrote: > > Add definitions for PROBE ICMP types and codes. > > Add AFI definitions for IP and IPV6 as specified by IANA > > Add a struct to represent the additional header when probing by IP > address (ctype == 3) for use in parsing incoming PROBE m

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-21 Thread Jason Wang
On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception for legacy guests to reset features to 0, when config space is accessed before features are set. We should relieve the verify_min_features() check and allow featu

[PATCH net 2/2] igb: Fix duplicate include guard

2021-02-21 Thread Tom Seewald
The include guard "_E1000_HW_H_" is used by two separate header files in two different drivers (e1000/e1000_hw.h and igb/e1000_hw.h). Using the same include guard macro in more than one header file may cause unexpected behavior from the compiler. Fix this by renaming the duplicate guard in the igb

[PATCH net 1/2] e1000e: Fix duplicate include guard

2021-02-21 Thread Tom Seewald
The include guard "_E1000_HW_H_" is used by header files in three different drivers (e1000/e1000_hw.h, e1000e/hw.h, and igb/e1000_hw.h). Using the same include guard macro in more than one header file may cause unexpected behavior from the compiler. Fix the duplicate include guard in the e1000e dri

Re: [PATCH] net: check if protocol extracted by virtio_net_hdr_set_proto is correct

2021-02-21 Thread Jason Wang
On 2021/2/19 10:55 下午, Willem de Bruijn wrote: On Fri, Feb 19, 2021 at 3:53 AM Jason Wang wrote: On 2021/2/18 11:50 下午, Willem de Bruijn wrote: On Thu, Feb 18, 2021 at 10:01 AM Balazs Nemeth wrote: For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't set) based on the

[PATCH] arp: Remove the arp_hh_ops structure

2021-02-21 Thread Yejune Deng
The arp_hh_ops structure is similar to the arp_generic_ops structure. but the latter is more general,so remove the arp_hh_ops structure. Fix when took out the neigh->ops assignment: 8.973653] #PF: supervisor read access in kernel mode [8.975027] #PF: error_code(0x) - not-present page [

[PATCH] ethernet/microchip:remove unneeded variable: "ret"

2021-02-21 Thread dingsenjie
From: dingsenjie remove unneeded variable: "ret". Signed-off-by: dingsenjie --- drivers/net/ethernet/microchip/encx24j600.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microchip/encx24j600.c b/drivers/net/ethernet/microchip/encx24j600.c index 2c0

[PATCH net] atl1c: switch to napi_gro_receive

2021-02-21 Thread Sieng Piaw Liew
Changing to napi_gro_receive() improves efficiency significantly. Tested on Intel Core2-based motherboards and iperf3. Signed-off-by: Sieng Piaw Liew --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ather

[PATCH net] bcm63xx_enet: fix sporadic kernel panic

2021-02-21 Thread Sieng Piaw Liew
In ndo_stop functions, netdev_completed_queue() is called during forced tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if there is any tx skb left. This patch moves netdev_reset_queue() to after tx reclaim, so BQL can complete successfully then reset. Signed-off-by: Sieng P

Re: [PATCH] tcp: avoid unnecessary loop if even ports are used up

2021-02-21 Thread Honglei Wang
On Sun, Feb 21, 2021 at 6:06 AM Jeremy Sowden wrote: > > On 2021-02-20, at 13:44:02 -0800, David Miller wrote: > > From: Honglei Wang > > Date: Sat, 20 Feb 2021 19:03:56 +0800 > > > > > We are getting port for connect() from even ports firstly now. This > > > makes bind() users have more availabl

[PATCH v2] PCI: Convert enum pci_dev_flags to bit fields in struct pci_dev

2021-02-21 Thread Krzysztof Wilczyński
All the flags defined in the enum pci_dev_flags are used to determine whether a particular feature of an underlying PCI device should be used or not - features are also often disabled via a device-specific quirk. These flags are tightly coupled with a PCI device and primarily used in simple binary

[PATCH ethtool] ioctl: less confusing error message for master-slave parameter

2021-02-21 Thread Michal Kubecek
The fallback code issues a reasonable error message when a subcommand implemented only via netlink would end up being processed by ioctl code, e.g. because a new ethtool runs on an older kernel without netlink support. But when a netlink only parameter is passed to subcommand which is recognized by

[PATCH net] net: qrtr: Fix memory leak in qrtr_tun_open

2021-02-21 Thread Takeshi Misawa
If qrtr_endpoint_register() failed, tun is leaked. Fix this, by freeing tun in error path. syzbot report: BUG: memory leak unreferenced object 0x88811848d680 (size 64): comm "syz-executor684", pid 10171, jiffies 4294951561 (age 26.070s) hex dump (first 32 bytes): 80 dd 0a 84 ff ff ff f

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-21 Thread Michael S. Tsirkin
On Sun, Feb 21, 2021 at 04:44:37PM +0200, Eli Cohen wrote: > On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote: > > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked > > for legacy") made an exception for legacy guests to reset > > features to 0, when config space is accessed b

Re: [PATCH net] octeontx2-af: Fix an off by one in rvu_dbg_qsize_write()

2021-02-21 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 19 Feb 2021 12:56:32 +0300 you wrote: > This code does not allocate enough memory for the NUL terminator so it > ends up putting it one character beyond the end of the buffer. > > Fixes: 8756828a8148 ("octeontx2-af: Add

[RFC PATCH net-next 10/12] Documentation: networking: dsa: add paragraph for the HSR/PRP offload

2021-02-21 Thread Vladimir Oltean
From: Vladimir Oltean Add a short summary of the methods that a driver writer must implement for offloading a HSR/PRP network interface. Cc: George McCollister Signed-off-by: Vladimir Oltean --- Documentation/networking/dsa/dsa.rst | 32 1 file changed, 32 inserti

[RFC PATCH net-next 08/12] Documentation: networking: dsa: add paragraph for the LAG offload

2021-02-21 Thread Vladimir Oltean
From: Vladimir Oltean Add a short summary of the methods that a driver writer must implement for offloading a link aggregation group, and what is still missing. Cc: Tobias Waldekranz Signed-off-by: Vladimir Oltean --- Documentation/networking/dsa/dsa.rst | 32 1 f

[RFC PATCH net-next 12/12] Documentation: networking: switchdev: fix command for static FDB entries

2021-02-21 Thread Vladimir Oltean
From: Vladimir Oltean The "bridge fdb add" command provided in the switchdev documentation is junk now, not only because it is syntactically incorrect and rejected by the iproute2 bridge program, but also because it was not updated in light of Arkadi Sharshevsky's radical switchdev refactoring in

[RFC PATCH net-next 09/12] Documentation: networking: dsa: add paragraph for the MRP offload

2021-02-21 Thread Vladimir Oltean
From: Vladimir Oltean Add a short summary of the methods that a driver writer must implement for getting an MRP instance to work on top of a DSA switch. Cc: Horatiu Vultur Signed-off-by: Vladimir Oltean Horatiu: - Why does ocelot support a single MRP ring if all it does is trap the MRP PDUs

[RFC PATCH net-next 11/12] Documentation: networking: switchdev: clarify device driver behavior

2021-02-21 Thread Vladimir Oltean
From: Florian Fainelli This patch provides details on the expected behavior of switchdev enabled network devices when operating in a "stand alone" mode, as well as when being bridge members. This clarifies a number of things that recently came up during a bug fixing session on the b53 DSA switch

[RFC PATCH net-next 06/12] Documentation: networking: dsa: document the port_bridge_flags method

2021-02-21 Thread Vladimir Oltean
From: Vladimir Oltean The documentation was already lagging behind by not mentioning the old version of port_bridge_flags (port_set_egress_floods). So now we are skipping one step and just explaining how a DSA driver should configure address learning and flooding settings. Signed-off-by: Vladimi

[RFC PATCH net-next 07/12] Documentation: networking: dsa: mention integration with devlink

2021-02-21 Thread Vladimir Oltean
From: Vladimir Oltean Add a short summary of the devlink features supported by the DSA core. Signed-off-by: Vladimir Oltean --- Documentation/networking/dsa/dsa.rst | 27 +++ 1 file changed, 27 insertions(+) diff --git a/Documentation/networking/dsa/dsa.rst b/Document

[RFC PATCH net-next 05/12] Documentation: networking: dsa: remove TODO about porting more vendor drivers

2021-02-21 Thread Vladimir Oltean
From: Vladimir Oltean On one hand, the link is dead and therefore useless. On the other hand, there are always more drivers to port, but at this stage, DSA does not need to affirm itself as the driver model to use for Ethernet-connected switches (since we already have 15 tagging protocols suppor

[RFC PATCH net-next 02/12] Documentation: networking: dsa: rewrite chapter about tagging protocol

2021-02-21 Thread Vladimir Oltean
From: Vladimir Oltean The chapter about tagging protocols is out of date because it doesn't mention all taggers that have been added since last documentation update. But judging based on that, it will always tend to lag behind, and there's no good reason why we would enumerate the supported hardw

[RFC PATCH net-next 04/12] Documentation: networking: dsa: remove references to switchdev prepare/commit

2021-02-21 Thread Vladimir Oltean
From: Vladimir Oltean After the recent series containing commit bae33f2b5afe ("net: switchdev: remove the transaction structure from port attributes"), there aren't prepare/commit transactional phases anymore in most of the switchdev objects/attributes, and as a result, there aren't any in the DS

[RFC PATCH net-next 03/12] Documentation: networking: dsa: remove static port count from limitations

2021-02-21 Thread Vladimir Oltean
From: Vladimir Oltean After Vivien's series from 2019 containing commits 27d4d19d7c82 ("net: dsa: remove limitation of switch index value") and ab8ccae122a4 ("net: dsa: add ports list in the switch fabric"), this is basically no longer true. Signed-off-by: Vladimir Oltean --- Documentation/net

[RFC PATCH net-next 01/12] Documentation: networking: update the graphical representation

2021-02-21 Thread Vladimir Oltean
From: Vladimir Oltean While preparing some slides for a customer presentation, I found the existing high-level view to be a bit confusing, so I modified it a little bit. Signed-off-by: Vladimir Oltean --- Documentation/networking/dsa/dsa.rst | 45 +--- 1 file changed, 2

[RFC PATCH net-next 00/12] Documentation updates for switchdev and DSA

2021-02-21 Thread Vladimir Oltean
From: Vladimir Oltean Many changes were made to the code but of course the documentation was not kept up to date. This is an attempt to update some of the verbiage. Suggestions for improvement would be very much appreciated. Florian Fainelli (1): Documentation: networking: switchdev: clarify d

[PATCH bpf-next v3 2/2] bpf, xdp: restructure redirect actions

2021-02-21 Thread Björn Töpel
From: Björn Töpel The XDP_REDIRECT implementations for maps and non-maps are fairly similar, but obviously need to take different code paths depending on if the target is using a map or not. Today, the redirect targets for XDP either uses a map, or is based on ifindex. Here, an explicit redirect

[PATCH bpf-next v3 1/2] bpf, xdp: per-map bpf_redirect_map functions for XDP

2021-02-21 Thread Björn Töpel
From: Björn Töpel Currently the bpf_redirect_map() implementation dispatches to the correct map-lookup function via a switch-statement. To avoid the dispatching, this change adds one bpf_redirect_map() implementation per map. Correct function is automatically selected by the BPF verifier. v2->v3

[PATCH bpf-next v3 0/2] Optimize bpf_redirect_map()/xdp_do_redirect()

2021-02-21 Thread Björn Töpel
Hi XDP-folks, This two patch series contain two optimizations for the bpf_redirect_map() helper and the xdp_do_redirect() function. The bpf_redirect_map() optimization is about avoiding the map lookup dispatching. Instead of having a switch-statement and selecting the correct lookup function, we

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-21 Thread Xie He
On Sat, Feb 20, 2021 at 10:39 PM Leon Romanovsky wrote: > > > Yes, this patch will break backward compatibility. Users with old > > scripts will find them no longer working. > > Did you search in debian/fedora code repositories to see if such scripts exist > as part of any distro package? I just

[PATCH] ath11k: qmi: use %pad to format dma_addr_t

2021-02-21 Thread Geert Uytterhoeven
If CONFIG_ARCH_DMA_ADDR_T_64BIT=n: drivers/net/wireless/ath/ath11k/qmi.c: In function ‘ath11k_qmi_respond_fw_mem_request’: drivers/net/wireless/ath/ath11k/qmi.c:1690:8: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘dma_addr_t’ {aka ‘u

[PATCH wpan 3/4] net: ieee802154: fix nl802154 add llsec key

2021-02-21 Thread Alexander Aring
This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_KEY is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+ce4e062c2d51977dd...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 ++- 1 file changed, 2

[PATCH wpan 2/4] net: ieee802154: fix nl802154 del llsec dev

2021-02-21 Thread Alexander Aring
This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVICE is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+d946223c2e751d136...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 ++- 1 file changed

[PATCH wpan 1/4] net: ieee802154: fix nl802154 del llsec key

2021-02-21 Thread Alexander Aring
This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_KEY is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+ac5c11d2959a8b3c4...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 ++- 1 file changed, 2

[PATCH wpan 4/4] net: ieee802154: fix nl802154 del llsec devkey

2021-02-21 Thread Alexander Aring
This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVKEY is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+368672e0da240db53...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 ++- 1 file changed

[PATCH net] vxlan: move debug check after netdev unregister

2021-02-21 Thread Taehee Yoo
The debug check must be done after unregister_netdevice_many() call -- the hlist_del_rcu() for this is done inside .ndo_stop. This is the same with commit 0fda7600c2e1 ("geneve: move debug check after netdev unregister") Test commands: ip netns del A ip netns add A ip netns add B

Re: [PATCH bpf-next v2 1/2] bpf, xdp: per-map bpf_redirect_map functions for XDP

2021-02-21 Thread Björn Töpel
33623 base: 7b1e385c9a488de9291eaaa412146d3972e9dec5 config: s390-randconfig-m031-20210221 (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross

Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-02-21 Thread Leon Romanovsky
On Sun, Feb 21, 2021 at 04:01:32PM +0100, Greg Kroah-Hartman wrote: > On Sun, Feb 21, 2021 at 03:55:18PM +0200, Leon Romanovsky wrote: > > On Sun, Feb 21, 2021 at 02:00:41PM +0100, Greg Kroah-Hartman wrote: > > > On Sat, Feb 20, 2021 at 01:06:00PM -0600, Bjorn Helgaas wrote: > > > > On Fri, Feb 19,

Re: [PATCH] net/mlx4_core: Add missed mlx4_free_cmd_mailbox()

2021-02-21 Thread Tariq Toukan
On 2/21/2021 4:35 PM, Chuhong Yuan wrote: mlx4_do_mirror_rule() forgets to call mlx4_free_cmd_mailbox() to free the memory region allocated by mlx4_alloc_cmd_mailbox() before an exit. Add the missed call to fix it. Fixes: 78efed275117 ("net/mlx4_core: Support mirroring VF DMFS rules on both

Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-02-21 Thread Greg Kroah-Hartman
On Sun, Feb 21, 2021 at 03:55:18PM +0200, Leon Romanovsky wrote: > On Sun, Feb 21, 2021 at 02:00:41PM +0100, Greg Kroah-Hartman wrote: > > On Sat, Feb 20, 2021 at 01:06:00PM -0600, Bjorn Helgaas wrote: > > > On Fri, Feb 19, 2021 at 09:20:18AM +0100, Greg Kroah-Hartman wrote: > > > > > > > Ok, can y

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-21 Thread Eli Cohen
On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote: > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked > for legacy") made an exception for legacy guests to reset > features to 0, when config space is accessed before features > are set. We should relieve the verify_min_features

[PATCH] net/mlx4_core: Add missed mlx4_free_cmd_mailbox()

2021-02-21 Thread Chuhong Yuan
mlx4_do_mirror_rule() forgets to call mlx4_free_cmd_mailbox() to free the memory region allocated by mlx4_alloc_cmd_mailbox() before an exit. Add the missed call to fix it. Fixes: 78efed275117 ("net/mlx4_core: Support mirroring VF DMFS rules on both ports") Signed-off-by: Chuhong Yuan --- drive

Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-02-21 Thread Leon Romanovsky
On Sun, Feb 21, 2021 at 02:00:41PM +0100, Greg Kroah-Hartman wrote: > On Sat, Feb 20, 2021 at 01:06:00PM -0600, Bjorn Helgaas wrote: > > On Fri, Feb 19, 2021 at 09:20:18AM +0100, Greg Kroah-Hartman wrote: > > > > > Ok, can you step back and try to explain what problem you are trying to > > > solve

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-21 Thread Serge Semin
On Sat, Feb 20, 2021 at 04:49:22PM +0100, Andrew Lunn wrote: > > If in doubt, leaving the patch as is would be fine with me. > > The patch is O.K. as is, no need to export something so simple for a > single users. When the next user come along, we can reconsider. Ok. Thanks for clarification. I p

Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-02-21 Thread Greg Kroah-Hartman
On Sat, Feb 20, 2021 at 01:06:00PM -0600, Bjorn Helgaas wrote: > On Fri, Feb 19, 2021 at 09:20:18AM +0100, Greg Kroah-Hartman wrote: > > > Ok, can you step back and try to explain what problem you are trying to > > solve first, before getting bogged down in odd details? I find it > > highly unlik

Re: [PATCH] net/qrtr: restrict length in qrtr_tun_write_iter()

2021-02-21 Thread Sabyrzhan Tasbolatov
> Do we really expect to accept huge lengths here ? Sorry for late response but I couldnt find any reference to the max length of incoming data for qrtr TUN interface. > qrtr_endpoint_post() will later attempt a netdev_alloc_skb() which will need > some extra space (for struct skb_shared_info) T

Re: [PATCH v4 net-next 07/21] nvme-tcp: Add DDP data-path

2021-02-21 Thread Boris Pismenny
On 17/02/2021 19:00, David Ahern wrote: > On 2/17/21 7:01 AM, Or Gerlitz wrote: @@ -1136,6 +1265,10 @@ static int nvme_tcp_try_send_cmd_pdu(struct nvme_tcp_request *req) else flags |= MSG_EOR; + if (test_bit(NVME_TCP_Q_OFF_DDP, &queue->flags) &

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-21 Thread Michael S. Tsirkin
On Thu, Feb 18, 2021 at 01:39:19PM +0800, Jason Wang wrote: > > On 2021/2/10 下午5:14, Michael S. Tsirkin wrote: > > On Tue, Feb 09, 2021 at 10:00:22AM -0800, Wei Wang wrote: > > > On Tue, Feb 9, 2021 at 6:58 AM Willem de Bruijn > > > wrote: > > > > > > > > I have no preference. Just curious, espec

Re: [PATCH v4 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-21 Thread Boris Pismenny
On 17/02/2021 15:55, Or Gerlitz wrote: > On Sun, Feb 14, 2021 at 8:20 PM David Ahern wrote: >> On 2/11/21 2:10 PM, Boris Pismenny wrote: >>> @@ -223,6 +229,164 @@ static inline size_t nvme_tcp_pdu_last_send(struct >>> nvme_tcp_request *req, >>> return nvme_tcp_pdu_data_left(req) <= len; >>>

Re: [PATCH] usbnet: ipheth: fix connectivity with iOS 14

2021-02-21 Thread Sam Bingner
There seems to be a problem with this patch: Whenever the iPhone sends a packet to the tethered device that is 1500 bytes long, it gets the error "ipheth 1-1:4.2: ipheth_rcvbulk_callback: urb status: -79" on the connected device and stops passing traffic. I am able to bring it back up by shutt

Re: [PATCH v4 net-next 00/21] nvme-tcp receive offloads

2021-02-21 Thread Or Gerlitz
On Thu, Feb 11, 2021 at 11:15 PM Boris Pismenny wrote: > Changes since v3: > = > * Use DDP_TCP ifdefs in iov_iter and skb iterators to minimize impact > when compiled out (Christoph) > * Simplify netdev references and reduce the use of > get_netdev_for_sock