From: Vladimir Oltean <vladimir.olt...@nxp.com> Add a short summary of the methods that a driver writer must implement for getting an MRP instance to work on top of a DSA switch.
Cc: Horatiu Vultur <horatiu.vul...@microchip.com> Signed-off-by: Vladimir Oltean <vladimir.olt...@nxp.com> Horatiu: - Why does ocelot support a single MRP ring if all it does is trap the MRP PDUs to the CPU? What is stopping it from supporting more than one ring? - Why is listening for SWITCHDEV_OBJ_ID_MRP necessary at all, since it does nothing related to hardware configuration? - Why is ocelot_mrp_del_vcap called from both ocelot_mrp_del and from ocelot_mrp_del_ring_role? - Why does ocelot not look at the MRM/MRC ring role at all, and it traps all MRP PDUs to the CPU, even those which it could forward as an MRC? I understood from your commit d8ea7ff3995e ("net: mscc: ocelot: Add support for MRP") description that the hardware should be able of forwarding the Test PDUs as a client, however it is obviously not doing that. --- Documentation/networking/dsa/dsa.rst | 30 ++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/Documentation/networking/dsa/dsa.rst b/Documentation/networking/dsa/dsa.rst index 0a5b06cf4d45..bf82f2aed29a 100644 --- a/Documentation/networking/dsa/dsa.rst +++ b/Documentation/networking/dsa/dsa.rst @@ -730,6 +730,36 @@ can optionally populate ``ds->num_lag_ids`` from the ``dsa_switch_ops::setup`` method. The LAG ID associated with a bonding/team interface can then be retrieved by a DSA switch driver using the ``dsa_lag_id`` function. +IEC 62439-2 (MRP) +----------------- + +The Media Redundancy Protocol is a topology management protocol optimized for +fast fault recovery time for ring networks, which has some components +implemented as a function of the bridge driver. MRP uses management PDUs +(Test, Topology, LinkDown/Up, Option) sent at a multicast destination MAC +address range of 01:15:4e:00:00:0x and with an EtherType of 0x88e3. +Depending on the node's role in the ring (MRM: Media Redundancy Manager, +MRC: Media Redundancy Client, MRA: Media Redundancy Automanager), certain MRP +PDUs might need to be terminated locally and others might need to be forwarded. +An MRM might also benefit from offloading to hardware the creation and +transmission of certain MRP PDUs (Test). + +Normally an MRP instance can be created on top of any network interface, +however in the case of a device with an offloaded data path such as DSA, it is +necessary for the hardware, even if it is not MRP-aware, to be able to extract +the MRP PDUs from the fabric before the driver can proceed with the software +implementation. DSA today has no driver which is MRP-aware, therefore it only +listens for the bare minimum switchdev objects required for the software assist +to work properly. The operations are detailed below. + +- ``port_mrp_add`` and ``port_mrp_del``: notifies driver when an MRP instance + with a certain ring ID, priority, primary port and secondary port is + created/deleted. +- ``port_mrp_add_ring_role`` and ``port_mrp_del_ring_role``: function invoked + when an MRP instance changes ring roles between MRM or MRC. This affects + which MRP PDUs should be trapped to software and which should be autonomously + forwarded. + TODO ==== -- 2.25.1