Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-25 Thread Nikolay Aleksandrov
On 26/01/2021 06:09, Hangbin Liu wrote: > After adding bridge as upper layer of bond/team, we usually clean up the > IP address on bond/team and set it on bridge. When there is a failover, > bond/team will not send gratuitous ARP since it has no IP address. > Then the down layer(e.g. VM tap dev) of

[PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-25 Thread Cindy Lu
In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. this cb.private will finally use in vhost_vdpa_config_cb as vhost_vdpa. Fix this issue. Cc: sta...@vger.kernel.org Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa") Signed-off-by: Cindy Lu --- drivers/vhost/v

Re: [PATCH v2 0/3] isa: Make the remove callback for isa drivers return void

2021-01-25 Thread Takashi Iwai
On Fri, 22 Jan 2021 10:24:46 +0100, Uwe Kleine-König wrote: > > Hello, > > changes since v1 > (https://lore.kernel.org/r/20210121204812.402589-1-...@kleine-koenig.org): > - fix build failure, found by the kernel test robot >(my grep missed the struct isa_driver embedded in struct >radio_

[PATCH bpf-next] selftests/bpf: don't exit on failed bpf_testmod unload

2021-01-25 Thread Andrii Nakryiko
Fix bug in handling bpf_testmod unloading that will cause test_progs exiting prematurely if bpf_testmod unloading failed. This is especially problematic when running a subset of test_progs that doesn't require root permissions and doesn't rely on bpf_testmod, yet will fail immediately due to exit(1

Re: [PATCH v3 net-next] Remove buf_info from device accessible structures

2021-01-25 Thread Leon Romanovsky
On Mon, Jan 25, 2021 at 02:34:56PM -0800, Ronak Doshi wrote: > vmxnet3: Remove buf_info from device accessible structures This line should be part of the "Subject: ..." and not as separated line. Thanks > > buf_info structures in RX & TX queues are private driver data that > do not need to be vi

[PATCH net-next] bnxt_en: Convert to use netif_level() helpers.

2021-01-25 Thread Michael Chan
Use the various netif_level() helpers to simplify the C code. This was suggested by Joe Perches. Cc: Joe Perches Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 34 ++- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/net/e

Re: [PATCH iproute2-next 2/2] vdpa: Add vdpa tool

2021-01-25 Thread David Ahern
Looks fine. A few comments below around code re-use. On 1/22/21 4:26 AM, Parav Pandit wrote: > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c > new file mode 100644 > index ..942524b7 > --- /dev/null > +++ b/vdpa/vdpa.c > @@ -0,0 +1,828 @@ > +// SPDX-License-Identifier: GPL-2.0+ > + > +#include >

Re: [PATCH] nfc/ftp: fix typo issue

2021-01-25 Thread Jakub Kicinski
On Sat, 23 Jan 2021 15:48:35 +0800 samirweng1979 wrote: > From: wengjianfeng > > change 'paquet' to 'packet' > > Signed-off-by: wengjianfeng s/ftp/fdp/ Applied, thanks.

Re: [PATCH net-next v2] selftests: add IPv4 unicast extensions tests

2021-01-25 Thread Jakub Kicinski
On Mon, 25 Jan 2021 15:38:47 -0800 Seth David Schoen wrote: > Add selftests for kernel behavior with regard to various classes of > unallocated/reserved IPv4 addresses, checking whether or not these > addresses can be assigned as unicast addresses on links and used in > routing. > > Expect the cur

Re: [PATCH] bridge: Use PTR_ERR_OR_ZERO instead if(IS_ERR(...)) + PTR_ERR

2021-01-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 25 Jan 2021 10:39:41 +0800 you wrote: > coccicheck suggested using PTR_ERR_OR_ZERO() and looking at the code. > > Fix the following coccicheck warnings: > > ./net/bridge/br_multicast.c:1295:7-13: WARNING: PTR_ERR_

Re: [PATCH net-next v2] net: ethernet: mediatek: support setting MTU

2021-01-25 Thread Jakub Kicinski
On Mon, 25 Jan 2021 14:01:05 +0100 Andrew Lunn wrote: > On Mon, Jan 25, 2021 at 12:20:46PM +0800, DENG Qingfang wrote: > > MT762x HW, except for MT7628, supports frame length up to 2048 > > (maximum length on GDM), so allow setting MTU up to 2030. > > > > Also set the default frame length to the h

Re: [PATCH net-next v2 0/2] dsa: add MT7530 GPIO support

2021-01-25 Thread Jakub Kicinski
On Mon, 25 Jan 2021 12:43:20 +0800 DENG Qingfang wrote: > MT7530's LED controller can be used as GPIO controller. Add support for > it. I added back Rob's tag and all the missing tags which patchwork did not register. Damn thing is really flaky right now. Anyway.. Applied, thanks everyone!

Re: [net-next PATCH] octeontx2-af: Support ESP/AH RSS hashing

2021-01-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 23 Jan 2021 10:39:12 +0530 you wrote: > From: Subbaraya Sundeep > > Support SPI and sequence number fields of > ESP/AH header to be hashed for RSS. By default > ESP/AH fields are not considered for RSS and > needs

Re: [PATCH bpf 1/2] bpf: allow empty module BTFs

2021-01-25 Thread Christopher William Snowhill
Aha, that was just released. Nice. I'll report this to the issue tracker where I had lodged the bpf patches for QoL use when testing rc4 and older. On Mon, Jan 25, 2021, at 5:26 PM, Andrii Nakryiko wrote: > On Sun, Jan 24, 2021 at 2:28 AM Christopher William Snowhill > wrote: > > > > When is thi

Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs

2021-01-25 Thread Jason Gunthorpe
On Mon, Jan 25, 2021 at 05:01:40PM -0800, Jacob Keller wrote: > > > On 1/25/2021 4:39 PM, Saleem, Shiraz wrote: > >> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and > >> implement private channel OPs > >> > >> On Sun, Jan 24, 2021 at 03:45:51PM +0200, Leon Romanovsky wrote

Re: [PATCH net-next 4/4] rtnetlink: promote IFLA_VF_STATS to same level as IFLA_VF_INFO

2021-01-25 Thread Jakub Kicinski
On Fri, 22 Jan 2021 20:53:21 -0800 Edwin Peer wrote: > Separating the VF stats out of IFLA_VF_INFO appears to be the least > impact way of resolving the nlattr overflow bug in IFLA_VFINFO_LIST. > > Since changing the hierarchy does constitute an ABI change, it must > be explicitly requested via RT

Re: [PATCH net-next 2/4] rtnetlink: extend RTEXT_FILTER_SKIP_STATS to IFLA_VF_INFO

2021-01-25 Thread Jakub Kicinski
On Fri, 22 Jan 2021 20:53:19 -0800 Edwin Peer wrote: > This filter already exists for excluding IPv6 SNMP stats. Extend its > definition to also exclude IFLA_VF_INFO stats in RTM_GETLINK. > > This patch constitutes a partial fix for a netlink attribute nesting > overflow bug in IFLA_VFINFO_LIST. B

Re: [PATCH net-next 1/4] netlink: truncate overlength attribute list in nla_nest_end()

2021-01-25 Thread Jakub Kicinski
On Fri, 22 Jan 2021 20:53:18 -0800 Edwin Peer wrote: > If a nested list of attributes is too long, then the length will > exceed the 16-bit nla_len of the parent nlattr. In such cases, > determine how many whole attributes can fit and truncate the > message to this length. This properly maintains t

Re: [PATCH net-next 00/15] bnxt_en: Error recovery improvements.

2021-01-25 Thread Willem de Bruijn
On Mon, Jan 25, 2021 at 3:36 AM Michael Chan wrote: > > This series contains a number of improvements in the area of error > recovery. Most error recovery scenarios are tightly coordinated with > the firmware. A number of patches add retry logic to establish > connection with the firmware if the

Re: [PATCH bpf 1/2] bpf: allow empty module BTFs

2021-01-25 Thread Andrii Nakryiko
On Sun, Jan 24, 2021 at 2:28 AM Christopher William Snowhill wrote: > > When is this being applied to an actual kernel? 5.11 is still quite broken > without these two patches. Unless you're not using a vfat EFI partition, I > guess. > It's in v5.11-rc5. > On Tue, Jan 12, 2021, at 12:20 PM, pat

Re: [pull request][net-next V10 00/14] Add mlx5 subfunction support

2021-01-25 Thread Edwin Peer
On Mon, Jan 25, 2021 at 5:22 AM Jason Gunthorpe wrote: > SRIOV and SF's require a simple linear lookup to learn the "function" > because the BAR space is required to be linear. Isn't this still true even for NumVF's > 256? Wouldn't there still be a contiguous VF BAR space? Don't the routing IDs

[PATCH net-next 5/5] selftests: increase timeout to 10 min

2021-01-25 Thread Mat Martineau
From: Matthieu Baerts On slow systems with kernel debug settings, we can reach the current timeout when all tests are executed. Likely some tests need be improved to remove some 'sleep' and wait (less) for a specific action. This can also improve stability. Signed-off-by: Matthieu Baerts Signe

Re: [PATCH net-next v2] net: qmi_wwan: Add pass through mode

2021-01-25 Thread Dan Williams
On Mon, 2021-01-25 at 17:00 +0100, Bjørn Mork wrote: > Dan Williams writes: > > On Mon, 2021-01-25 at 00:33 -0700, Subash Abhinov Kasiviswanathan > > wrote: > > > Pass through mode is to allow packets in MAP format to be passed > > > on to the stack. rmnet driver can be used to process and > > > d

Re: [PATCH mlx5-next v4 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-01-25 Thread Leon Romanovsky
On Mon, Jan 25, 2021 at 10:50:53AM -0800, Alexander Duyck wrote: > On Mon, Jan 25, 2021 at 10:47 AM Leon Romanovsky wrote: > > > > On Sun, Jan 24, 2021 at 09:00:32PM +0200, Leon Romanovsky wrote: > > > On Sun, Jan 24, 2021 at 08:47:44AM -0800, Alexander Duyck wrote: > > > > On Sun, Jan 24, 2021 at

Re: [PATCH mlx5-next v4 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-01-25 Thread Alexander Duyck
On Mon, Jan 25, 2021 at 10:47 AM Leon Romanovsky wrote: > > On Sun, Jan 24, 2021 at 09:00:32PM +0200, Leon Romanovsky wrote: > > On Sun, Jan 24, 2021 at 08:47:44AM -0800, Alexander Duyck wrote: > > > On Sun, Jan 24, 2021 at 5:11 AM Leon Romanovsky wrote: > > > > > > > > From: Leon Romanovsky > >

Re: [PATCH v6 net-next 07/10] net: dsa: allow changing the tag protocol via the "tagging" device attribute

2021-01-25 Thread Jakub Kicinski
On Sun, 24 Jan 2021 10:20:39 +0200 Vladimir Oltean wrote: > On Fri, Jan 22, 2021 at 08:52:16PM -0800, Jakub Kicinski wrote: > > On Thu, 21 Jan 2021 18:01:28 +0200 Vladimir Oltean wrote: > > > + list_for_each_entry(dp, &dst->ports, list) { > > > > What protects this iteration? All sysfs guarante

[PATCH v3 RFC net-next 05/19] net: mvpp2: add PPv23 version definition

2021-01-25 Thread stefanc
From: Stefan Chulski This patch add PPv23 version definition. PPv23 is new packet processor in CP115. Everything that supported by PPv22, also supported by PPv23. No functional changes in this stage. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 24 +++

[PATCH v3 RFC net-next 03/19] net: mvpp2: add CM3 SRAM memory map

2021-01-25 Thread stefanc
From: Stefan Chulski This patch adds CM3 memory map and CM3 read/write callbacks. No functionality changes. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 7 ++ drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 73 +++- 2 files changed, 77

[PATCH bpf-next V13 3/7] bpf: bpf_fib_lookup return MTU value as output when looked up

2021-01-25 Thread Jesper Dangaard Brouer
The BPF-helpers for FIB lookup (bpf_xdp_fib_lookup and bpf_skb_fib_lookup) can perform MTU check and return BPF_FIB_LKUP_RET_FRAG_NEEDED. The BPF-prog don't know the MTU value that caused this rejection. If the BPF-prog wants to implement PMTU (Path MTU Discovery) (rfc1191) it need to know this MT

[PATCH bpf-next V13 2/7] bpf: fix bpf_fib_lookup helper MTU check for SKB ctx

2021-01-25 Thread Jesper Dangaard Brouer
BPF end-user on Cilium slack-channel (Carlo Carraro) wants to use bpf_fib_lookup for doing MTU-check, but *prior* to extending packet size, by adjusting fib_params 'tot_len' with the packet length plus the expected encap size. (Just like the bpf_check_mtu helper supports). He discovered that for SK

Re: [PATCH iproute2-next] Add description section to rdma man page

2021-01-25 Thread David Ahern
On 1/24/21 11:25 PM, Leon Romanovsky wrote: > On Sun, Jan 24, 2021 at 12:00:27PM -0800, Alan Perry wrote: >> Add a description section with basic info about the rdma command for users >> unfamiliar with it. >> >> Signed-off-by: Alan Perry >> Acked-by: Leon Romanovsky >> >> --- >> man/man8/rdma.8

Re: [PATCH net-next v2] net: qmi_wwan: Add pass through mode

2021-01-25 Thread Dan Williams
On Mon, 2021-01-25 at 00:33 -0700, Subash Abhinov Kasiviswanathan wrote: > Pass through mode is to allow packets in MAP format to be passed > on to the stack. rmnet driver can be used to process and demultiplex > these packets. > > Pass through mode can be enabled when the device is in raw ip mode

RE: [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI with lanes

2021-01-25 Thread Danielle Ratson
> -Original Message- > From: Jakub Kicinski > Sent: Friday, January 22, 2021 5:45 AM > To: Danielle Ratson > Cc: netdev@vger.kernel.org; da...@davemloft.net; Jiri Pirko > ; and...@lunn.ch; f.faine...@gmail.com; > mkube...@suse.cz; mlxsw ; Ido Schimmel > Subject: Re: [PATCH net-next v

Re: [PATCH v3] Bluetooth: Keep MSFT ext info throughout ahci_dev's life cycle

2021-01-25 Thread Marcel Holtmann
Hi Miao-chen, > This moves msft_do_close() from hci_dev_do_close() to > hci_unregister_dev() to avoid clearing MSFT extension info. This also > avoids retrieving MSFT info upon every msft_do_open() if MSFT extension > has been initialized. > > The following test steps were performed. > (1) boot t

[PATCH net] iwlwifi: provide gso_type to GSO packets

2021-01-25 Thread Eric Dumazet
From: Eric Dumazet net/core/tso.c got recent support for USO, and this broke iwlfifi because the driver implemented a limited form of GSO. Providing ->gso_type allows for skb_is_gso_tcp() to provide a correct result. Fixes: 3d5b459ba0e3 ("net: tso: add UDP segmentation support") Signed-off-by:

[PATCH net-next 2/2] net: qmi_wwan: document qmap/mux_id sysfs file

2021-01-25 Thread Daniele Palmas
Document qmap/mux_id sysfs file showing qmimux interface id Signed-off-by: Daniele Palmas --- Documentation/ABI/testing/sysfs-class-net-qmi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-class-net-qmi b/Documentation/ABI/testing/sysfs-class-net-q

[PATCH net-next 1/2] net: usb: qmi_wwan: add qmap id sysfs file for qmimux interfaces

2021-01-25 Thread Daniele Palmas
Add qmimux interface sysfs file qmap/mux_id to show qmap id set during the interface creation, in order to provide a method for userspace to associate QMI control channels to network interfaces. Signed-off-by: Daniele Palmas --- drivers/net/usb/qmi_wwan.c | 27 +++ 1 file

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-25 Thread Arnd Bergmann
On Mon, Jan 25, 2021 at 4:04 PM Krzysztof Kozlowski wrote: > On Mon, 25 Jan 2021 at 15:38, Arnd Bergmann wrote: > > On Mon, Jan 25, 2021 at 2:27 PM Krzysztof Kozlowski wrote: > > I meant that having MAC80211_LEDS selected causes the ath9k driver to > toggle on/off the WiFi LED. Every second, reg

Re: [PATCH] net/bluetooth: Fix the follow coccicheck warnings

2021-01-25 Thread Marcel Holtmann
Hi Jiapeng, > ./net/bluetooth/hci_debugfs.c: WARNING: sniff_min_interval_fops > should be defined with DEFINE_DEBUGFS_ATTRIBUTE > > Signed-off-by: Jiapeng Zhong > Reported-by: Abaci Robot > --- > net/bluetooth/hci_debugfs.c | 38 +++--- > 1 file changed, 19 inserti

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-25 Thread Arnd Bergmann
On Mon, Jan 25, 2021 at 2:27 PM Krzysztof Kozlowski wrote: > On Mon, 25 Jan 2021 at 14:09, Arnd Bergmann wrote: > > On Mon, Jan 25, 2021 at 12:40 PM Krzysztof Kozlowski > > wrote: > > > On Mon, 25 Jan 2021 at 12:36, Arnd Bergmann wrote: > > > But we do not want to have this dependency (selecti

Re: [PATCH wireless v2] scsi: megaraid: Remove unnecessary memset

2021-01-25 Thread Kalle Valo
Zheng Yongjun wrote: > memcpy operation is next to memset code, and the size to copy > is equals to the size to memset, so the memset operation is > unnecessary, remove it. > > Signed-off-by: Zheng Yongjun Wrong title. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/

Re: [PATCH 1/5] rtlwifi: rtl_pci: fix bool comparison in expressions

2021-01-25 Thread Kalle Valo
Aditya Srivastava wrote: > There are certain conditional expressions in rtl_pci, where a boolean > variable is compared with true/false, in forms such as (foo == true) or > (false != bar), which does not comply with checkpatch.pl (CHECK: > BOOL_COMPARISON), according to which boolean variables sh

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-25 Thread Russell King - ARM Linux admin
On Mon, Jan 25, 2021 at 03:09:57PM +0100, Pali Rohár wrote: > On Monday 18 January 2021 10:34:35 Pali Rohár wrote: > > On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > > > This is a third version of patches which add workarounds for > > > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-25 Thread Pali Rohár
On Monday 18 January 2021 10:34:35 Pali Rohár wrote: > On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > > This is a third version of patches which add workarounds for > > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > > > Russel's PATCH v2 2/3 was dropped from this patch seri

Re: [PATCH] bridge: Use PTR_ERR_OR_ZERO instead if(IS_ERR(...)) + PTR_ERR

2021-01-25 Thread Nikolay Aleksandrov
On 25/01/2021 04:39, Jiapeng Zhong wrote: > coccicheck suggested using PTR_ERR_OR_ZERO() and looking at the code. > > Fix the following coccicheck warnings: > > ./net/bridge/br_multicast.c:1295:7-13: WARNING: PTR_ERR_OR_ZERO can be > used. > > Reported-by: Abaci > Signed-off-by: Jiapeng Zhong

[RFC PATCH v3 04/13] af_vsock: implement send logic for SOCK_SEQPACKET

2021-01-25 Thread Arseny Krasnov
This adds some logic to current stream enqueue function for SEQPACKET support: 1) Send record begin marker with length of record. 2) Return value from enqueue function is wholevrecord length or error for SOCK_SEQPACKET. Signed-off-by: Arseny Krasnov --- include/net/af_vsock.h | 1 + net/vmw_v

[RFC PATCH v3 05/13] af_vsock: rest of SEQPACKET support

2021-01-25 Thread Arseny Krasnov
This does rest of SOCK_SEQPACKET support: 1) Adds socket ops for SEQPACKET type. 2) Allows to create socket with SEQPACKET type. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/af_vsock.c | 71 1 file changed, 71 insertions(+) diff --git a/net/vmw_vsock/

Re: [RFC PATCH v3 03/13] af_vsock: implement SEQPACKET rx loop

2021-01-25 Thread stsp
25.01.2021 14:12, Arseny Krasnov пишет: This adds receive loop for SEQPACKET. It looks like receive loop for SEQPACKET,     ^^^ You meant "STREAM"?

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-25 Thread Krzysztof Kozlowski
On Mon, 25 Jan 2021 at 14:09, Arnd Bergmann wrote: > > On Mon, Jan 25, 2021 at 12:40 PM Krzysztof Kozlowski wrote: > > On Mon, 25 Jan 2021 at 12:36, Arnd Bergmann wrote: > > > > > > From: Arnd Bergmann > > > > > > When CONFIG_ATH9K is built-in but LED support is in a loadable > > > module, both

Re: [PATCH bpf-next v3 3/3] xsk: build skb by page

2021-01-25 Thread Alexander Lobakin
From: Xuan Zhuo Date: Mon, 25 Jan 2021 11:10:43 +0800 > On Fri, 22 Jan 2021 16:24:17 +, Alexander Lobakin wrote: > > From: Xuan Zhuo > > Date: Fri, 22 Jan 2021 23:36:29 +0800 > > > > > On Fri, 22 Jan 2021 12:08:00 +, Alexander Lobakin > > > wrote: > > > > From: Alexander Lobakin > >

Re: [PATCH] [5.8 regression] net: ks8851: fix link error

2021-01-25 Thread Andrew Lunn
On Mon, Jan 25, 2021 at 01:19:20PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > An object file cannot be built for both loadable module and built-in > use at the same time: > > arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common.o: in > function `ks8851_probe_common': > ks8

Re: [PATCH] dsa: vsc73xx: add support for vlan filtering

2021-01-25 Thread Linus Walleij
On Mon, Jan 25, 2021 at 12:45 AM Vladimir Oltean wrote: > Anyhow, you did not approve or disprove the tag_8021q idea. I just don't understand it well enough so I didn't know what to say about that... > With VLAN trunking on the CPU port, how would per-port traffic be > managed? Would it be comp

[PATCH v2 2/2 net-next] net: mscc: ocelot: fix error code in mscc_ocelot_probe()

2021-01-25 Thread Dan Carpenter
Probe should return an error code if platform_get_irq_byname() fails but it returns success instead. Fixes: 6c30384eb1de ("net: mscc: ocelot: register devlink ports") Signed-off-by: Dan Carpenter --- v2: no change drivers/net/ethernet/mscc/ocelot_vsc7514.c | 4 +++- 1 file changed, 3 insertions

Re: [PATCH v2 bpf-next 2/4] bpf: allow bpf_d_path in sleepable bpf_iter program

2021-01-25 Thread Jiri Olsa
On Tue, Dec 15, 2020 at 03:37:00PM -0800, Song Liu wrote: > task_file and task_vma iter programs have access to file->f_path. Enable > bpf_d_path to print paths of these file. > > bpf_iter programs are generally called in sleepable context. However, it > is still necessary to diffientiate sleepabl

KASAN: slab-out-of-bounds Write in record_print_text

2021-01-25 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e6806137 Merge tag 'irq_urgent_for_v5.11_rc5' of git://git.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10c59c6f50 kernel config: https://syzkaller.appspot.com/x/.config?x=be33d8015c9de024 das

[PATCH v2 net-next] net: core: devlink: add 'dropped' stats field for DROP trap action

2021-01-25 Thread Oleksandr Mazur
Whenever query statistics is issued for trap with DROP action, devlink subsystem would also fill-in statistics 'dropped' field. In case if device driver did't register callback for hard drop statistics querying, 'dropped' field will be omitted and not filled. Add trap_drop_counter_get callback impl

[PATCH -next] net/mlx5: Remove unused including

2021-01-25 Thread Zou Wei
Fix the following versioncheck warning: drivers/net/ethernet/mellanox/mlx5/core/main.c:53:1: unused including Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx

[RFC PATCH v3 09/13] virtio/vsock: add SEQPACKET receive logic

2021-01-25 Thread Arseny Krasnov
This modifies current receive logic for SEQPACKET support: 1) Inserts 'SEQ_BEGIN' packet to socket's rx queue. 2) Inserts 'RW' packet to socket's rx queue, but without merging with buffer of last packet in queue. 3) Performs check for packet and socket types on receive(if mismatch, then reset

[PATCH v2 net] net: switchdev: don't set port_obj_info->handled true when -EOPNOTSUPP

2021-01-25 Thread Rasmus Villemoes
It's not true that switchdev_port_obj_notify() only inspects the ->handled field of "struct switchdev_notifier_port_obj_info" if call_switchdev_blocking_notifiers() returns 0 - there's a WARN_ON() triggering for a non-zero return combined with ->handled not being true. But the real problem here is

Re: pull-request: mac80211 2021-01-18.2

2021-01-25 Thread Johannes Berg
Hi, > > I don't have that much sympathy for a staging driver that's clearly > > doing things differently than it was intended (the documentation states > > that the function should be called only before wiphy_register(), not > > during ndo_open). :-) > > I completely understand and I already was

Re: [PATCH v2] cfg80211: avoid holding the RTNL when calling the driver

2021-01-25 Thread Marek Szyprowski
Hi Johannes, On 22.01.2021 13:27, Johannes Berg wrote: >> This patch landed in today's (20210122) linux-next as commit >> 791daf8fc49a ("cfg80211: avoid holding the RTNL when calling the >> driver"). Sadly, it causes deadlock with mwifiex driver. I think that >> lockdep report describes it enough:

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-25 Thread Krzysztof Kozlowski
On Mon, 25 Jan 2021 at 12:36, Arnd Bergmann wrote: > > From: Arnd Bergmann > > When CONFIG_ATH9K is built-in but LED support is in a loadable > module, both ath9k drivers fails to link: > > x86_64-linux-ld: drivers/net/wireless/ath/ath9k/gpio.o: in function > `ath_deinit_leds': > gpio.c:(.text+0

Re: [PATCH net-next v2] net: qmi_wwan: Add pass through mode

2021-01-25 Thread Bjørn Mork
Subash Abhinov Kasiviswanathan writes: > Pass through mode is to allow packets in MAP format to be passed > on to the stack. rmnet driver can be used to process and demultiplex > these packets. > > Pass through mode can be enabled when the device is in raw ip mode only. > Conversely, raw ip mode

[PATCH 3/4] cxgb4: remove redundant NULL check

2021-01-25 Thread Yang Li
Fix below warnings reported by coccicheck: ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c:161:2-7: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c | 3 +-- 1 file changed, 1

Re: [PATCH 1/2 net-next] net: mscc: ocelot: fix error handling bugs in mscc_ocelot_init_ports()

2021-01-25 Thread Dan Carpenter
Oops. Please ignore this patch. Part of it is missing. regards, dan carpenter

[PATCH bpf-next 0/6] AF_XDP Packet Drop Tracing

2021-01-25 Thread Ciara Loftus
This series introduces tracing infrastructure for AF_XDP sockets (xsks). A trace event 'xsk_packet_drop' is created which can be enabled by toggling /sys/kernel/debug/tracing/events/xsk/xsk_packet_drop/enable When enabled and packets are dropped in the kernel, traces are generated which describe

[PATCH bpf-next 1/6] xsk: add tracepoints for packet drops

2021-01-25 Thread Ciara Loftus
This commit introduces static perf tracepoints for AF_XDP which report information about packet drops, such as the netdev, qid and high level reason for the drop. The tracepoint can be enabled/disabled by toggling /sys/kernel/debug/tracing/events/xsk/xsk_packet_drop/enable Signed-off-by: Ciara Lof

Re: [RFC PATCH 14/16] gtp: add support for flow based tunneling

2021-01-25 Thread Jonas Bonn
Hi Pravin, On 23/01/2021 20:59, Jonas Bonn wrote: From: Pravin B Shelar @@ -617,29 +686,84 @@ static void gtp_push_header(struct sk_buff *skb, struct pdp_ctx *pctx, static int gtp_xmit_ip4(struct sk_buff *skb, struct net_device *dev) { struct gtp_dev *gtp = netdev_priv(dev); +

[PATCH bpf-next 2/6] selftests/bpf: restructure setting the packet count

2021-01-25 Thread Ciara Loftus
Prior to this, the packet count was fixed at 1 for every test. Future tracing tests need to modify the count, so make it possible to set the count from test_xsk.h using the -C opt. Signed-off-by: Ciara Loftus --- tools/testing/selftests/bpf/test_xsk.sh| 17 + tools/testin

[PATCH v2 net 0/1] net: fec: Fix temporary RMII clock reset on link up

2021-01-25 Thread Laurent Badel
v2: fixed a compilation warning The FEC drivers performs a "hardware reset" of the MAC module when the link is reported to be up. This causes a short glitch in the RMII clock due to the hardware reset clearing the receive control register which controls the MII mode. It seems that some link pa

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-25 Thread Jiri Pirko
Thu, Jan 21, 2021 at 06:36:05PM CET, k...@kernel.org wrote: >On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote: >> On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote: >> > Add new trap action HARD_DROP, which can be used by the >> > drivers to register traps, where it's impossible

RE: [pull request][net-next V10 00/14] Add mlx5 subfunction support

2021-01-25 Thread Parav Pandit
Hi Edwin, > From: Edwin Peer > Sent: Monday, January 25, 2021 2:17 AM > > On Fri, Jan 22, 2021 at 11:37 AM Saeed Mahameed > wrote: > > > For more detailed information about subfunctions please see detailed tag > > log below. > > Apologies for the tardy question out of left field, but I've bee

[PATCH] [5.8 regression] net: ks8851: fix link error

2021-01-25 Thread Arnd Bergmann
From: Arnd Bergmann An object file cannot be built for both loadable module and built-in use at the same time: arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common.o: in function `ks8851_probe_common': ks8851_common.c:(.text+0xf80): undefined reference to `__this_module' Change the

Re: [pull request][net-next V10 00/14] Add mlx5 subfunction support

2021-01-25 Thread Jason Gunthorpe
On Mon, Jan 25, 2021 at 10:57:14AM +, Parav Pandit wrote: > Hi Edwin, > > > From: Edwin Peer > > Sent: Monday, January 25, 2021 2:17 AM > > > > On Fri, Jan 22, 2021 at 11:37 AM Saeed Mahameed > > wrote: > > > > > For more detailed information about subfunctions please see detailed tag > >

[RFC PATCH v3 10/13] virtio/vsock: rest of SOCK_SEQPACKET support

2021-01-25 Thread Arseny Krasnov
This adds rest of logic for SEQPACKET: 1) Shared functions for packet sending now set valid type of packet according socket type. 2) SEQPACKET specific function like SEQ_BEGIN send and data dequeue. 3) TAP support for SEQPACKET is not so easy if it is necessary to send whole record to TAP interf

[RFC PATCH v3 11/13] virtio/vsock: setup SEQPACKET ops for transport

2021-01-25 Thread Arseny Krasnov
This adds SEQPACKET ops for virtio transport Signed-off-by: Arseny Krasnov --- net/vmw_vsock/virtio_transport.c | 4 1 file changed, 4 insertions(+) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index 2700a63ab095..5a7ab1befee8 100644 --- a/net/vmw_vsock/

[RFC PATCH v3 12/13] vhost/vsock: setup SEQPACKET ops for transport

2021-01-25 Thread Arseny Krasnov
This also removes ignore of non-stream type of packets. Signed-off-by: Arseny Krasnov --- drivers/vhost/vsock.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index 5e78fb719602..4d60a99aed14 100644 --- a/drivers/vhost/vso

Re: [RFC PATCH net-next 2/3] net: hsr: add DSA offloading support

2021-01-25 Thread George McCollister
On Sun, Jan 24, 2021 at 11:29 AM Vladimir Oltean wrote: > > On Fri, Jan 22, 2021 at 09:59:47AM -0600, George McCollister wrote: > > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > > index f2fb433f3828..fc7e3ff11c5c 100644 > > --- a/net/dsa/slave.c > > +++ b/net/dsa/slave.c > > @@ -1924,6 +1924,19

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-25 Thread Pali Rohár
On Monday 25 January 2021 14:42:21 Russell King - ARM Linux admin wrote: > On Mon, Jan 25, 2021 at 03:23:01PM +0100, Pali Rohár wrote: > > On Monday 25 January 2021 14:16:44 Russell King - ARM Linux admin wrote: > > > On Mon, Jan 25, 2021 at 03:09:57PM +0100, Pali Rohár wrote: > > > > On Monday 18

Re: [PATCH] Bluetooth: Put HCI device if inquiry procedure interrupts

2021-01-25 Thread Marcel Holtmann
Hi Pan, > Jump to the label done to decrement the reference count of HCI device > hdev on path that the Inquiry procedure is interrupted. > > Fixes: 3e13fa1e1fab ("Bluetooth: Fix hci_inquiry ioctl usage") > Signed-off-by: Pan Bian > --- > net/bluetooth/hci_core.c | 6 -- > 1 file changed, 4 i

Re: [PATCH v6 0/7] MSFT offloading support for advertisement monitor

2021-01-25 Thread Marcel Holtmann
Hi Archie, > This series of patches manages the hardware offloading part of MSFT > extension API. The full documentation can be accessed by this link: > https://docs.microsoft.com/en-us/windows-hardware/drivers/bluetooth/microsoft-defined-bluetooth-hci-commands-and-events > > Only four of the HCI

[PATCH] net: phy: remove h from printk format specifier

2021-01-25 Thread trix
From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xud

[PATCH net-next 2/3] net: constify page_is_pfmemalloc() argument at call sites

2021-01-25 Thread Alexander Lobakin
Constify "page" argument for page_is_pfmemalloc() users where applicable. Signed-off-by: Alexander Lobakin --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +- drivers/net

[PATCH net-next 3/3] net: page_pool: simplify page recycling condition tests

2021-01-25 Thread Alexander Lobakin
pool_page_reusable() is a leftover from pre-NUMA-aware times. For now, this function is just a redundant wrapper over page_is_pfmemalloc(), so Inline it into its sole call site. Signed-off-by: Alexander Lobakin --- net/core/page_pool.c | 14 -- 1 file changed, 4 insertions(+), 10 del

[PATCH net-next 1/5] mptcp: support MPJoin with IPv4 mapped in v6 sk

2021-01-25 Thread Mat Martineau
From: Matthieu Baerts With an IPv4 mapped in v6 socket, we were trying to call inet6_bind() with an IPv4 address resulting in a -EINVAL error because the given addr_len -- size of the address structure -- was too short. We now make sure to use address structures for the same family as the MPTCP

Re: [pull request][net-next V10 00/14] Add mlx5 subfunction support

2021-01-25 Thread Edwin Peer
On Mon, Jan 25, 2021 at 10:35 AM Edwin Peer wrote: > > Several weeks back, Jason already answered this VF scaling question from > > you at discussion [1]. > > > > [1] https://lore.kernel.org/netdev/20201216023928.gg552...@nvidia.com/ Regarding these costs: > A lot of the trappings that PCI-SIG

Re: [PATCH 18/22] RDMA/irdma: Add miscellaneous utility definitions

2021-01-25 Thread Jason Gunthorpe
On Fri, Jan 22, 2021 at 05:48:23PM -0600, Shiraz Saleem wrote: > From: Mustafa Ismail > > Add miscellaneous utility functions and headers. > > Signed-off-by: Mustafa Ismail > Signed-off-by: Shiraz Saleem > drivers/infiniband/hw/irdma/osdep.h | 99 ++ > drivers/infiniband/hw/irdma/protos.h

Re: [PATCHv16 bpf-next 3/6] xdp: add a new helper for dev map multicast support

2021-01-25 Thread Hangbin Liu
On Mon, Jan 25, 2021 at 01:27:24PM +0100, Maciej Fijalkowski wrote: > Hangbin, > > before you submit next revision, could you try to apply imperative mood to > your commit messages? > > From Documentation/process/submitting-patches.rst: > > > Describe your changes in imperative mood, e.g. "make

RE: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs

2021-01-25 Thread Saleem, Shiraz
> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and > implement private channel OPs > > > > +static int irdma_devlink_rsrc_limits_validate(struct devlink *dl, u32 id, > > + union devlink_param_value val, > > +

Re: [PATCH nf-next v4 1/5] net: sched: Micro-optimize egress handling

2021-01-25 Thread Jakub Kicinski
On Sun, 24 Jan 2021 11:33:01 +0100 Lukas Wunner wrote: > On Fri, Jan 22, 2021 at 10:40:05AM +0100, Eric Dumazet wrote: > > On Fri, Jan 22, 2021 at 9:55 AM Lukas Wunner wrote: > > > sch_handle_egress() returns either the skb or NULL to signal to its > > > caller __dev_queue_xmit() whether a packe

Re: [PATCH net-next 3/4] bridge: mrp: Extend br_mrp_switchdev to detect better the errors

2021-01-25 Thread Willem de Bruijn
On Sat, Jan 23, 2021 at 11:23 AM Horatiu Vultur wrote: > > This patch extends the br_mrp_switchdev functions to be able to have a > better understanding what cause the issue and if the SW needs to be used > as a backup. > > There are the following cases: > - when the code is compiled without CONFI

Re: [PATCH net-next v3 5/8] igc: Avoid TX Hangs because long cycles

2021-01-25 Thread Vladimir Oltean
On Fri, Jan 22, 2021 at 02:44:50PM -0800, Vinicius Costa Gomes wrote: > Avoid possible TX Hangs caused by using long Qbv cycles. In some > cases, using long cycles (more than 1 second) can cause transmissions > to be blocked for that time. As the TX Hang timeout is close to 1 > second, we may need

[net] net: decnet: fix netdev refcount leaking on error path

2021-01-25 Thread Vadim Fedorenko
On building the route there is an assumption that the destination could be local. In this case loopback_dev is used to get the address. If the address is still cannot be retrieved dn_route_output_slow returns EADDRNOTAVAIL with loopback_dev reference taken. Cannot find hash for the fixes tag becau

Re: [PATCH bpf-next v2 1/2] bpf: allow rewriting to ports under ip_unprivileged_port_start

2021-01-25 Thread Martin KaFai Lau
On Mon, Jan 25, 2021 at 03:32:53PM -0800, Stanislav Fomichev wrote: > On Mon, Jan 25, 2021 at 3:25 PM Martin KaFai Lau wrote: > > > > On Mon, Jan 25, 2021 at 09:26:40AM -0800, Stanislav Fomichev wrote: > > > At the moment, BPF_CGROUP_INET{4,6}_BIND hooks can rewrite user_port > > > to the privileg

Re: [Patch net] net: fix dev_ifsioc_locked() race condition

2021-01-25 Thread Gong, Sishuai
Hi, We also found another pair of writer and reader that may suffer the same problem. A data race may also happen on the variable netdev->dev_addr when functions e1000_set_mac() and packet_getname() run in parallel, eventually it could return a partially updated MAC address to the user, as sho

Re: [PATCH 2/2] bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values

2021-01-25 Thread Andrii Nakryiko
On Sun, Jan 24, 2021 at 2:18 PM Jiri Olsa wrote: > > For very large ELF objects (with many sections), we could > get special value SHN_XINDEX (65535) for symbol's st_shndx. > > This patch is adding code to detect the optional extended > section index table and use it to resolve symbol's section >

Re: [PATCH net 1/1] uapi: fix big endian definition of ipv6_rpl_sr_hdr

2021-01-25 Thread Justin Iurman
> Le 25 janv. 2021 à 20:32, Jakub Kicinski a écrit : > >> On Sun, 24 Jan 2021 11:57:03 -0700 David Ahern wrote: >> On 1/24/21 2:57 AM, Justin Iurman wrote: De: "Jakub Kicinski" À: "Justin Iurman" Cc: netdev@vger.kernel.org, da...@davemloft.net, "alex aring" Envoyé:

Re: [PATCH] neighbour: Prevent a dead entry from updating gc_list

2021-01-25 Thread Cong Wang
On Mon, Jan 25, 2021 at 11:59 AM Chinmay Agarwal wrote: > > Following race condition was detected: > - neigh_flush_dev() is under execution and calls > neigh_mark_dead(n), > marking the neighbour entry 'n' as dead. > > - Executing: __netif_receive_skb() -> __netif_receive_skb_core() > -> arp_rc

Re: WARNING in pskb_expand_head

2021-01-25 Thread Jakub Kicinski
CC Willem just in case On Sun, 24 Jan 2021 12:51:20 -0800 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:7d68e382 bpf: Permit size-0 datasec > git tree: bpf-next > console output: https://syzkaller.appspot.com/x/log.txt?x=132567e750 > kernel config:

KASAN: global-out-of-bounds Write in record_print_text

2021-01-25 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:bc085f8f Add linux-next specific files for 20210121 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=17a726a4d0 kernel config: https://syzkaller.appspot.com/x/.config?x=1224bbf217b0bec8 dashboard

  1   2   3   >