On Thu, Jan 21, 2021 at 01:32:42PM -0800, Alan Perry wrote:
>
>
> On 12/23/20 12:19 AM, Leon Romanovsky wrote:
> > On Tue, Dec 22, 2020 at 08:47:51PM -0800, Alan Perry wrote:
> > > Add a description section with basic info about the rdma command for users
> > > unfamiliar with it.
> > >
> > > Signe
On Sat, Jan 23, 2021 at 1:23 PM Jiri Olsa wrote:
>
> On Thu, Jan 21, 2021 at 03:32:40PM -0800, Andrii Nakryiko wrote:
>
> SNIP
>
> > But the current variant looks broken. Oh, and
> > elf_symtab__for_each_symbol() is similarly broken, can you please fix
> > that as well?
>
> we'll have to change it
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 23 Jan 2021 11:56:32 +0100 you wrote:
> Hi,
>
> The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic
> schedules may be configured individually on each front port. Each port has
> eight
> egres
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Fri, 22 Jan 2021 18:19:36 + you wrote:
> This series allows to form UDP GRO packets in cases without sockets
> (for forwarding). To not change the current datapath, this is
> performed only when the new correspondin
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 22 Jan 2021 16:15:54 +0100 you wrote:
> The 'wwan' devtype is meant for devices that require additional
> configuration to be used, like WWAN specific APN setup over AT/QMI
> commands, rmnet link creation, etc. This
Upon receiving a cumulative ACK that changes the congestion state from
Disorder to Open, the TLP timer is not set. If the sender is app-limited,
it can only wait for the RTO timer to expire and retransmit.
The reason for this is that the TLP timer is set before the congestion
state changes in tcp_
On Thu, 21 Jan 2021 00:17:09 -0600 Lijun Pan wrote:
> rmb() was introduced to load rx_scrq->msgs after calling
> pending_scrq(). Now since pending_scrq() itself already
> has dma_rmb() at the end of the function, rmb() is
> duplicated and can be removed.
>
> Fixes: ec20f36bb41a ("ibmvnic: Correctl
On Thu, 21 Jan 2021 00:17:08 -0600 Lijun Pan wrote:
> Move the dma_rmb() between pending_scrq() and ibmvnic_next_scrq()
> into the end of pending_scrq(), and explain why.
> Explain in detail why the dma_rmb() is placed at the end of
> ibmvnic_next_scrq().
>
> Fixes: b71ec9522346 ("ibmvnic: Ensure
On Thu, 21 Jan 2021 23:00:44 +0100 Justin Iurman wrote:
> Following RFC 6554 [1], the current order of fields is wrong for big
> endian definition. Indeed, here is how the header looks like:
>
> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> | Next Header | Hdr Ext Len | R
On Fri, 22 Jan 2021 10:07:05 +0100 Martin Schiller wrote:
> On 2021-01-21 01:21, Xie He wrote:
> > In the lapb module, the timers may run concurrently with other code in
> > this module, and there is currently no locking to prevent the code from
> > racing on "struct lapb_cb". This patch adds locki
On Sat, Jan 23, 2021 at 12:52:21PM -0800, Jakub Kicinski wrote:
> On Sat, 23 Jan 2021 19:59:00 +0800 Kevin Hao wrote:
> > +void *page_frag_alloc(struct page_frag_cache *nc,
> > + unsigned int fragsz, gfp_t gfp_mask)
> > +{
> > + return page_frag_alloc_align(nc, fragsz, gfp_mask, 0
On Fri, 22 Jan 2021 15:57:31 -0800 Tony Nguyen wrote:
> From: Piotr Raczynski
>
> XDP queue number for XDP_TX action is used inconsistently
> and may result with no packets transmitted. Fix queue number
> used by the driver when doing XDP_TX, i.e. use receive queue
> number as in ice_finalize_xdp
On Sat, 23 Jan 2021 16:56:43 -0800 Enke Chen wrote:
> On Sat, Jan 23, 2021 at 07:19:13PM -0500, Neal Cardwell wrote:
> > On Fri, Jan 22, 2021 at 9:45 PM Enke Chen wrote:
> > > On Fri, Jan 22, 2021 at 06:34:24PM -0800, Jakub Kicinski wrote:
> > > > On Fri, 22 Jan 2021 18:28:23 -0800 Enke Chen w
On Fri, 22 Jan 2021 09:47:01 +0100 Lukas Wunner wrote:
> sch_handle_egress() returns either the skb or NULL to signal to its
> caller __dev_queue_xmit() whether a packet should continue to be
> processed.
>
> The skb is always non-NULL, otherwise __dev_queue_xmit() would hit a
> NULL pointer deref
On 1/23/2021 7:06 PM, Jakub Kicinski wrote:
> On Sat, 23 Jan 2021 21:51:48 +0100 Andrew Lunn wrote:
>> Early generations of the mv88e6xxx did not have the global 2
>> registers. In order to keep the driver slim, it was decided to make
>> the code for these registers optional. Over time, more gen
On Sat, 23 Jan 2021 21:51:48 +0100 Andrew Lunn wrote:
> Early generations of the mv88e6xxx did not have the global 2
> registers. In order to keep the driver slim, it was decided to make
> the code for these registers optional. Over time, more generations of
> switches have been added, always suppo
From: Cong Wang
dev_ifsioc_locked() is called with only RCU read lock, so when
there is a parallel writer changing the mac address, it could
get a partially updated mac address, as shown below:
Thread 1Thread 2
// eth_commit_mac_addr_change()
memcpy(dev->dev_addr, addr->s
On 1/23/21 1:00 PM, Jakub Kicinski wrote:
> On Fri, 22 Jan 2021 22:16:41 -0700 David Ahern wrote:
>> On 1/22/21 9:02 PM, Maciej Żenczykowski wrote:
>>> Why can't we get rid of the special case for 0 and simply make 1024 the
>>> default value?
>>
>> That would work too.
>
> Should we drop it then
Hi Seth:
Tests look fine. Some nits below about coding style - and checkpatch.
On 1/20/21 12:05 PM, Seth David Schoen wrote:
> diff --git a/tools/testing/selftests/net/unicast_extensions.sh
> b/tools/testing/selftests/net/unicast_extensions.sh
> new file mode 100755
> index ..9ca99d5
Hi, Neal:
What you described is more accurate, and is correct.
Thanks. -- Enke
On Sat, Jan 23, 2021 at 07:19:13PM -0500, Neal Cardwell wrote:
> On Fri, Jan 22, 2021 at 9:45 PM Enke Chen wrote:
> >
> > Hi, Jakub:
> >
> > On Fri, Jan 22, 2021 at 06:34:24PM -0800, Jakub Kicinski wrote:
> > > On F
+Vivien who added the optional support in the first place
From: Andrew Lunn
Sent: Sat, Jan 23, 2021 at 09:51:48PM +0100
To: Jakub Kicinski
Cc: netdev , Vladimir Oltean ,
Florian Fainelli , tob...@waldekranz.com, Andrew Lunn
Subject: [PATCH] dsa: mv88e6xxx: Make
On Sat, 2021-01-23 at 22:31 +0100, Hans de Goede wrote:
>
> So I'm afraid that I have some bad news about this patch, it fixes
> the RCU warning which I reported:
>
> https://lore.kernel.org/linux-wireless/20210104170713.66956-1-hdego...@redhat.com/
>
> But it introduces a deadlock. See:
>
> ht
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 21 Jan 2021 07:37:45 -0800 you wrote:
> Put the device to avoid resource leak on path that the polling flag is
> invalid.
>
> Fixes: a831b9132065 ("NFC: Do not return EBUSY when stopping a poll that's
> already stopped
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 21 Jan 2021 16:02:44 +0100 you wrote:
> This patch adds documentation for sysctl conf/all/disable_ipv6 and
> conf/default/disable_ipv6 settings which is currently missing.
>
> Signed-off-by: Pali Rohár
> ---
> Documen
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 21 Jan 2021 07:27:48 -0800 you wrote:
> Goto to the label put_dev instead of the label error to fix potential
> resource leak on path that the target index is invalid.
>
> Fixes: c4fbb6515a4d ("NFC: The core part should
On Sat, 23 Jan 2021 13:14:00 -0800 Richard Cochran wrote:
> On Sat, Jan 23, 2021 at 12:12:27PM -0800, Jakub Kicinski wrote:
> > I see. The only thing I'm worried about then is the churn in patch 3.
> > This would land in Linus's tree shortly before rc6, kinda late to be
> > taking chances in the na
On 1/18/21 9:47 PM, Johannes Berg wrote:
> Hi,
>
> New try, dropped the 160 MHz CSA patch for now that has the sparse
> issue since people are waiting for the kernel-doc fixes.
>
> Please pull and let me know if there's any problem.
>
> Thanks,
> johannes
>
>
>
> The following changes sinc
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 21 Jan 2021 04:33:43 -0800 you wrote:
> Put the device node dn before return error code on failure path.
>
> Fixes: 461cd1b03e32 ("net: dsa: bcm_sf2: Register our slave MDIO bus")
> Signed-off-by: Pan Bian
> ---
> dri
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 21 Jan 2021 06:57:38 -0800 you wrote:
> The dst entry should be released if no neighbour is found. Goto label
> free_dst to fix the issue. Besides, the check of ndev against NULL is
> redundant.
>
> Signed-off-by: Pan B
On Thu, Jan 21, 2021 at 03:32:40PM -0800, Andrii Nakryiko wrote:
SNIP
> But the current variant looks broken. Oh, and
> elf_symtab__for_each_symbol() is similarly broken, can you please fix
> that as well?
we'll have to change its callers a bit, because of hanging 'else'
I'll send this separatel
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 21 Jan 2021 05:48:16 -0600 you wrote:
> Version 1 of this series inadvertently dropped the "static" that
> limits the scope of gsi_channel_update(). Version 2 fixes this
> (in patch 3).
>
> While reviewing the IP
On Sat, Jan 23, 2021 at 12:12:27PM -0800, Jakub Kicinski wrote:
> I see. The only thing I'm worried about then is the churn in patch 3.
> This would land in Linus's tree shortly before rc6, kinda late to be
> taking chances in the name of minor optimizations :S
;^)
Yeah, by all means, avoid ARM c
On Sat, Jan 23, 2021 at 12:42 PM Edwin Peer wrote:
> Then, if nla_put() can detect nesting errors, there's the issue of
> what to do in the case of errors. Case in point, the IFLA_VFINFO_LIST
> scenario would now require explicit error handling in the generator
> logic, because we can't fail hard
On Sat, 23 Jan 2021 19:59:00 +0800 Kevin Hao wrote:
> +void *page_frag_alloc(struct page_frag_cache *nc,
> + unsigned int fragsz, gfp_t gfp_mask)
> +{
> + return page_frag_alloc_align(nc, fragsz, gfp_mask, 0);
> +}
> EXPORT_SYMBOL(page_frag_alloc);
Isn't it better to make th
Early generations of the mv88e6xxx did not have the global 2
registers. In order to keep the driver slim, it was decided to make
the code for these registers optional. Over time, more generations of
switches have been added, always supporting global 2 and adding more
and more registers. No effort h
On Fri, 22 Jan 2021 14:36:08 +0100 Rasmus Villemoes wrote:
> On 22/01/2021 10.05, Horatiu Vultur wrote:
> > The 01/22/2021 00:43, Rasmus Villemoes wrote:
> >>
> >> It's not true that switchdev_port_obj_notify() only inspects the
> >> ->handled field of "struct switchdev_notifier_port_obj_info"
On Sat, Jan 23, 2021 at 11:14 AM David Ahern wrote:
> > Marking truncated attributes, such that user space can determine
> > the precise attribute truncated, by means of an additional bit in
> > the nla_type was considered and rejected. The NLA_F_NESTED and
> > NLA_F_NET_BYTEORDER flags are suppo
On Thu, 21 Jan 2021 21:40:35 +0100 Rasmus Villemoes wrote:
> v2: update commit log of the patch to include comments on 32 bit
> alignment; include second patch moving the structs out of uapi.
Applied, thanks!
On Sat, 23 Jan 2021 13:25:23 -0500 Neal Cardwell wrote:
> On Sat, Jan 23, 2021 at 9:15 AM Pengcheng Yang wrote:
> >
> > On Sat, Jan 23, 2021 at 9:27 AM "Jakub Kicinski" wrote:
> > >
> > > On Fri, 22 Jan 2021 11:53:46 +0100 Eric Dumazet wrote:
> > > > On Fri, Jan 22, 2021 at 11:28 AM Pengcheng
This patch series extends MRP switchdev to allow the SW to have a better
understanding if the HW can implment the MRP functionality or it needs to
help the HW to run it. There are 3 cases:
- when HW can't implement at all the functionality.
- when HW can implement a part of the functionality but ne
Add the member sw_backup to the structures switchdev_obj_ring_role_mrp
and switchdev_obj_in_role_mrp. In this way the SW can call the driver in
2 ways, once when sw_backup is set to false, meaning that the driver
should implement this completely in HW. And if that is not supported the
SW will call
Check the return values of the br_mrp_switchdev function.
In case of:
- BR_MRP_NONE, return the error to userspace,
- BR_MRP_SW, continue with SW implemtation
- BR_MRP_HW, continue without SW implemtation.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp.c | 43 +++
This patch extends the br_mrp_switchdev functions to be able to have a
better understanding what cause the issue and if the SW needs to be used
as a backup.
There are the following cases:
- when the code is compiled without CONFIG_NET_SWITCHDEV. In this case
return success so the SW can continue
Add the enum br_mrp_hw_support that is used by the br_mrp_switchdev
functions to allow the SW to detect better the cases where the HW can't
implement this or when the SW is used as a backup.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_private_mrp.h | 14 ++
1 file changed, 14 ins
Hi,
On Sat, 2021-01-23 at 12:07 -0800, Andrii Nakryiko wrote:
> > the latest upstream code seems to set it always,
> > but I agree we should be careful
>
> oh, then maybe it's not necessary. I honestly don't even know where
> the authoritative source code of libelf is, so I just found some
> rand
According to my "git send-email" history, I have CCed jasow...@redhat.com. Not
sure why Jason is not on the list.
CCed Jason. Thank you very much!
Dongli Zhang
On 1/23/21 12:08 AM, Dongli Zhang wrote:
> The size of 'struct vhost_scsi' is order-10 (~2.3MB). It may take long time
> delay by kzallo
Hi Jiri,
On Sat, 2021-01-23 at 19:51 +0100, Jiri Olsa wrote:
> On Fri, Jan 22, 2021 at 02:55:51PM -0800, Andrii Nakryiko wrote:
> >
> > > I don't understand this.. gelf_getsymshndx will return both
> > > symbol and proper index, no? also sym_sec_idx is already
> > > assigned from previou call
>
On Sat, Jan 23, 2021 at 09:08:15PM +0100, Mark Wielaard wrote:
> Hi Jiri,
>
> On Sat, 2021-01-23 at 19:51 +0100, Jiri Olsa wrote:
> > On Fri, Jan 22, 2021 at 02:55:51PM -0800, Andrii Nakryiko wrote:
> > >
> > > > I don't understand this.. gelf_getsymshndx will return both
> > > > symbol and prop
On Sat, 23 Jan 2021 18:03:48 +0200 Ido Schimmel wrote:
> [DEVLINK_ATTR_STATS_RX_DROPPED]
nit: maybe discarded? dropped sounds like may have been due to an
overflow or something
On Sat, 23 Jan 2021 05:26:26 -0800 Richard Cochran wrote:
> On Fri, Jan 22, 2021 at 06:14:44PM -0800, Jakub Kicinski wrote:
>
> > (I would put it in net-next tho, given the above this at most a space
> > optimization.)
>
> It isn't just about space but also time. The reason why I targeted
> ne
On 1/21/2021 4:11 PM, Jason Gunthorpe wrote:
On Thu, Jan 21, 2021 at 12:59:55PM -0800, Samudrala, Sridhar wrote:
+ mlx5_core.sf.4
+ (subfunction auxiliary device)
+ /\
+ / \
+ /\
+/
On Sat, Jan 23, 2021 at 10:51 AM Jiri Olsa wrote:
>
> On Fri, Jan 22, 2021 at 02:55:51PM -0800, Andrii Nakryiko wrote:
> > On Fri, Jan 22, 2021 at 12:47 PM Jiri Olsa wrote:
> > >
> > > On Thu, Jan 21, 2021 at 03:32:40PM -0800, Andrii Nakryiko wrote:
> > >
> > > SNIP
> > >
> > > > > @@ -598,9 +599
Blindly assuming that packet transmission crosses namespaces results in
skb marks being lost in the single namespace case.
Signed-off-by: Jonas Bonn
Acked-by: Harald Welte
---
drivers/net/gtp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/gtp.c b/drivers/ne
Set the devtype to 'gtp' when setting up the link.
Signed-off-by: Jonas Bonn
Acked-by: Harald Welte
---
drivers/net/gtp.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index 04d9de385549..a1bb02818977 100644
--- a/drivers/net/gtp.c
+++ b/drivers/
Signed-off-by: Jonas Bonn
---
drivers/net/gtp.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index 4a3a52970856..df2f227680eb 100644
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@ -532,7 +532,11 @@ static int gtp_xmit_ip4(str
This is preparatory work for adding flow based tunneling work by Pravin
Shelar.
Signed-off-by: Jonas Bonn
---
drivers/net/gtp.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index b20e17988bfa..c42092bb505f 100644
This series begins by reverting the recently added patch adding support
for GTP with lightweight tunnels. That patch was added without getting
any ACK from the maintainers and has several issues, as discussed on the
mailing list.
In order to try to make this as painless as possible, I have rework
The GTP link is brought up with a default MTU of zero. This can lead to
some rather unexpected behaviour for users who are more accustomed to
interfaces coming online with reasonable defaults.
This patch sets an initial MTU for the GTP link of 1500 less worst-case
tunnel overhead.
Signed-off-by:
This reverts commit 9ab7e76aefc97a9aa664accb59d6e8dc5e52514a.
This patch was committed without maintainer approval and despite a number
of unaddressed concerns from review. There are several issues that
impede the acceptance of this patch and that make a reversion of this
particular instance of t
Querying link info for the GTP interface doesn't reveal in which "role" the
device is set to operate. Include this information in the info query
result.
Signed-off-by: Jonas Bonn
Acked-by: Harald Welte
---
drivers/net/gtp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
Based on work by Pravin Shelar.
Update appropriate stats when packet transmission isn't possible.
Signed-off-by: Jonas Bonn
---
drivers/net/gtp.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index 023d38b1098d..7ab8540e46d2
From: Pravin B Shelar
This adds the Netlink interface necessary to set up flow based tunnels.
Signed-off-by: Jonas Bonn
---
drivers/net/gtp.c| 139 +++
include/uapi/linux/if_link.h | 1 +
2 files changed, 111 insertions(+), 29 deletions(-)
diff --
From: Pravin B Shelar
Please explain how this patch actually works... creation of the control
header makes sense, but I don't understand how sending of a
control header is actually triggered.
Signed-off-by: Jonas Bonn
---
drivers/net/gtp.c | 43 ++-
1 fi
This assignment is already done a few line earlier.
Signed-off-by: Jonas Bonn
---
drivers/net/gtp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index c42092bb505f..023d38b1098d 100644
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@ -268,8 +268,6
From: Pravin B Shelar
This patch adds support for flow based tunneling, allowing to send and
receive GTP tunneled packets via the (lightweight) tunnel metadata
mechanism. This would allow integration with OVS and eBPF using flow
based tunneling APIs.
The mechanism used here is to get the requir
On Fri, 22 Jan 2021 22:16:41 -0700 David Ahern wrote:
> On 1/22/21 9:02 PM, Maciej Żenczykowski wrote:
> > Why can't we get rid of the special case for 0 and simply make 1024 the
> > default value?
>
> That would work too.
Should we drop it then? Easier to bring it back than to change the
inter
This patch does some cleanup work in the IPv4 functionality to lay the
groundwork for adding support for IPv6. The form of these changes is
largely borrowed from the bareudp and geneve drivers, so there shouldn't
be anything here that looks unnecessarily unfamiliar.
Signed-off-by: Jonas Bonn
---
The call to skb_dst_drop() is already done as part of udp_tunnel_xmit().
Signed-off-by: Jonas Bonn
---
drivers/net/gtp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index e4e57c0552ee..04d9de385549 100644
--- a/drivers/net/gtp.c
+++ b/drivers/net/gt
This patch implements GRO callbacks for UDP-tunneled GTP traffic.
iperf3 numbers
Without GRO for GTP tunnels:
Accepted connection from 172.99.2.1, port 48783
[ 5] local 172.99.0.1 port 5201 connected to 172.99.2.1 port 46095
[ ID] Interval Transfer Bitrate
[ 5] 0.00-1.00 sec
Based on work by Pravin Shelar.
Once the GTP headers have been the removed, the SKB protocol should be
set to that of the inner packet.
Signed-off-by: Jonas Bonn
---
drivers/net/gtp.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index
On Sat, 23 Jan 2021 17:28:02 +0200 Ido Schimmel wrote:
> > Thanks for the explanation. I feel more and more convinced now that
> > we should have TC_ACT_TRAP_MIRROR and the devlink trap should only
> > be on/off :S Current model of "if ACT_TRAP consult devlink for trap
> > configuration" is imposs
I can reproduce the issue with C reproducer. This is an old known issue
though and the failure is due to memory allocation failure in
tracepoint_probe_unregister().
[ 40.807849][ T8287] Call Trace:
[ 40.808201][ T8287] dump_stack+0x77/0x97
[ 40.808695][ T8287] should_fail.cold.6+0x32
On 1/22/21 9:53 PM, Edwin Peer wrote:
> If a nested list of attributes is too long, then the length will
> exceed the 16-bit nla_len of the parent nlattr. In such cases,
> determine how many whole attributes can fit and truncate the
> message to this length. This properly maintains the nesting
> hi
Update struct bpf_perf_event_data with the addr field to match the
tools headers with the kernel headers.
Signed-off-by: Florian Lehner
---
tools/include/uapi/linux/bpf_perf_event.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/include/uapi/linux/bpf_perf_event.h
b/tools/include/uap
On Fri, Jan 22, 2021 at 02:55:51PM -0800, Andrii Nakryiko wrote:
> On Fri, Jan 22, 2021 at 12:47 PM Jiri Olsa wrote:
> >
> > On Thu, Jan 21, 2021 at 03:32:40PM -0800, Andrii Nakryiko wrote:
> >
> > SNIP
> >
> > > > @@ -598,9 +599,36 @@ static void collect_symbol(GElf_Sym *sym, struct
> > > > func
On 1/15/21 12:21 PM, Jarod Wilson wrote:
> There's a new transmit hash policy being added to the bonding driver that
> is a simple XOR of vlan ID and source MAC, xmit_hash_policy vlan+srcmac.
> This trivial patch makes it configurable and queryable via iproute2.
>
> $ sudo modprobe bonding mode=2
On 1/19/21 7:52 PM, we...@ucloud.cn wrote:
> From: wenxu
>
> Matches on conntrack inv ct_state.
>
> Signed-off-by: wenxu
> ---
> v2: change the description
>
> include/uapi/linux/pkt_cls.h | 1 +
> man/man8/tc-flower.8 | 2 ++
> tc/f_flower.c| 1 +
> 3 files changed, 4
On 11/23/20 2:58 PM, Marcel Holtmann wrote:
hci_phy_link_complete_evt() has several duplicate error paths --
consolidate
them, using the *goto* statements.
Signed-off-by: Sergey Shtylyov
---
net/bluetooth/hci_event.c | 16 ++--
1 file cha
From: Emil Renner Berthing
Initialize tasklet using tasklet_init() rather than open-coding it.
Signed-off-by: Emil Renner Berthing
---
drivers/net/usb/usbnet.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 1447da
From: Emil Renner Berthing
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/net/usb/usbnet.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --
From: Emil Renner Berthing
This converts the usbnet driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
It is split into two commits for ease of reviewing.
Emil Renner Berthing (2):
net: usbnet: use tasklet_init
net: usbnet: use
Vincent MAILHOL 于2021年1月22日周五 下午4:51写道：
>
> Hi,
>
> In addition to Marc’s comment, I also have security concerns.
>
> On Fri. 22 Jan 2021 at 15:22, Su Yanjun wrote:
> > When i debug mcp2518fd, some method to track registers is
> > needed. This easy debug interface will be ok.
> >
> > For example,
On Fri, Jan 22, 2021 at 08:36:01AM +, Oleksandr Mazur wrote:
> On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote:
> > On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote:
> > > Add new trap action HARD_DROP, which can be used by the
> > > drivers to register traps, where it's im
On Thu, Jan 21, 2021 at 09:19:40AM -0800, Jakub Kicinski wrote:
> On Thu, 21 Jan 2021 12:23:18 +0200 Ido Schimmel wrote:
> > On Wed, Jan 20, 2021 at 04:45:08PM -0800, Jakub Kicinski wrote:
> > > On Wed, 20 Jan 2021 11:14:37 +0200 Ido Schimmel wrote:
> > > > On Tue, Jan 19, 2021 at 02:22:55PM -080
On Sat, Jan 23, 2021 at 9:27 AM "Jakub Kicinski" wrote:
>
> On Fri, 22 Jan 2021 11:53:46 +0100 Eric Dumazet wrote:
> > On Fri, Jan 22, 2021 at 11:28 AM Pengcheng Yang wrote:
> > >
> > > When CA_STATE is in DISORDER, the TLP timer is not set when receiving
> > > an ACK (a cumulative ACK covered o
Greeting, I'm Anders Pedersen, from Norway. I want to know if this
email is working?. Thanks
On Fri, Jan 22, 2021 at 06:14:44PM -0800, Jakub Kicinski wrote:
> (I would put it in net-next tho, given the above this at most a space
> optimization.)
It isn't just about space but also time. The reason why I targeted
net and not net-next was that NETWORK_PHY_TIMESTAMPING activates a
function
On Sat, Jan 23, 2021 at 5:02 AM "Yuchung Cheng" wrote:
>
> On Fri, Jan 22, 2021 at 6:37 AM Neal Cardwell wrote:
> >
> > On Fri, Jan 22, 2021 at 5:53 AM Eric Dumazet wrote:
> > >
> > > On Fri, Jan 22, 2021 at 11:28 AM Pengcheng Yang wrote:
> > > >
> > > > When CA_STATE is in DISORDER, the TLP ti
In the current implementation of page_frag_alloc(), it doesn't have
any align guarantee for the returned buffer address. But for some
hardwares they do require the DMA buffer to be aligned correctly,
so we would have to use some workarounds like below if the buffers
allocated by the page_frag_alloc
The napi_alloc_frag_align() will guarantee that a correctly align
buffer address is returned. So use this function to simplify the buffer
alloc and avoid the unnecessary memory waste.
Signed-off-by: Kevin Hao
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 3 +--
1 file changed, 1
The napi_alloc_frag_align() will guarantee that a correctly align
buffer address is returned. So use this function to simplify the buffer
alloc and avoid the unnecessary memory waste.
Signed-off-by: Kevin Hao
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 3 +--
1 file changed, 1 inserti
In the current implementation of {netdev,napi}_alloc_frag(), it doesn't
have any align guarantee for the returned buffer address, But for some
hardwares they do require the DMA buffer to be aligned correctly,
so we would have to use some workarounds like below if the buffers
allocated by the {netde
Hi,
In the current implementation of napi_alloc_frag(), it doesn't have any
align guarantee for the returned buffer address. We would have to use
some ugly workarounds to make sure that we can get a align buffer
address for some Ethernet drivers. This patch series tries to introduce
some helper fu
The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic
schedules may be configured individually on each front port. Each port has eight
egress queues. The traffic is mapped to a traffic class respectively via the PCP
field of a VLAN tagged frame.
The TAPRIO Qdisc already implemen
Hi,
The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic
schedules may be configured individually on each front port. Each port has eight
egress queues. The traffic is mapped to a traffic class respectively via the PCP
field of a VLAN tagged frame.
Previous attempts:
* https
Stop calling ql_release_all in qlge_init_device and free things one step
at a time.
struct qlge_adapter *qdev is now a private structure of struct devlink
and memset is not necessary.
Link: https://lore.kernel.org/patchwork/patch/1321092/#1516928
Suggested-by: Dan Carpenter
Signed-off-by: Coiby
$ devlink health dump show DEVICE reporter coredump -p -j
{
"Core Registers": {
"segment": 1,
"values": [
0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,
Instructions and examples on kernel data structures dumping and
coredump.
Signed-off-by: Coiby Xu
---
.../networking/device_drivers/index.rst | 1 +
.../device_drivers/qlogic/index.rst | 18 +++
.../networking/device_drivers/qlogic/qlge.rst | 118 ++
MAINTAINER
The debugging code in the following ifdef land
- QL_ALL_DUMP
- QL_REG_DUMP
- QL_DEV_DUMP
- QL_CB_DUMP
- QL_IB_DUMP
- QL_OB_DUMP
becomes unnecessary because,
- Device status and general registers can be obtained by ethtool.
- Coredump can be done via devlink health reporter.
- Structure re
devlink health could be used to get coredump. No need to send so much
data to the kernel ring buffer.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/TODO | 2 --
drivers/staging/qlge/qlge.h | 3 ---
drivers/staging/qlge/qlge_dbg.c | 11 ---
drivers/staging/qlge/
1 - 100 of 112 matches
Mail list logo
