On Thu, 21 Jan 2021 00:17:09 -0600 Lijun Pan wrote: > rmb() was introduced to load rx_scrq->msgs after calling > pending_scrq(). Now since pending_scrq() itself already > has dma_rmb() at the end of the function, rmb() is > duplicated and can be removed. > > Fixes: ec20f36bb41a ("ibmvnic: Correctly re-enable interrupts in NAPI polling > routine") > Signed-off-by: Lijun Pan <l...@linux.ibm.com>
rmb() is a stronger barrier than dma_rmb() also again, I don't see how this fixes any bugs