Re: [PATCH] can: mcp251xfd: fix wrong check in mcp251xfd_handle_rxif_one

On 1/13/21 8:31 AM, Qinglang Miao wrote: > If alloc_canfd_skb returns NULL, 'cfg' is an uninitialized > variable, so we should check 'skb' rather than 'cfd' after > calling alloc_canfd_skb(priv->ndev, &cfd). > > Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI > CAN")

Re: mlx5 error when the skb linear space is empty

On Tue, Jan 12, 2021 at 9:35 PM Saeed Mahameed wrote: > > On Mon, 2021-01-11 at 09:02 +0100, Magnus Karlsson wrote: > > On Tue, Jan 5, 2021 at 9:51 PM Saeed Mahameed > > wrote: > > > On Mon, 2021-01-04 at 18:59 +0800, Xuan Zhuo wrote: > > > > hi > > > > > > > > In the process of developing xdp so

[PATCH] can: mcp251xfd: fix wrong check in mcp251xfd_handle_rxif_one

If alloc_canfd_skb returns NULL, 'cfg' is an uninitialized variable, so we should check 'skb' rather than 'cfd' after calling alloc_canfd_skb(priv->ndev, &cfd). Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN") Signed-off-by: Qinglang Miao --- drivers/net/can/sp

Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254)

Takashi Iwai writes: > On Tue, 12 Jan 2021 16:46:21 +0100, > Kalle Valo wrote: >> >> Takashi Iwai writes: >> >> > On Tue, 12 Jan 2021 13:45:33 +0100, >> > Kalle Valo wrote: >> >> >> >> Takashi Iwai writes: >> >> >> >> > On Tue, 12 Jan 2021 12:33:14 +0100, >> >> > Kalle Valo wrote: >> >> >>

Re: [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

"Coelho, Luciano" writes: > On Tue, 2021-01-12 at 17:05 +0100, Takashi Iwai wrote: >> On Tue, 12 Jan 2021 16:50:54 +0100, >> Kalle Valo wrote: >> > >> > Takashi Iwai writes: >> > >> > > The ucode TLV data may be read-only and should be treated as const >> > > pointers, but currently a few code

Re: [PATCH mlx5-next v1 2/5] PCI: Add SR-IOV sysfs entry to read number of MSI-X vectors

On Tue, Jan 12, 2021 at 01:34:50PM -0800, Alexander Duyck wrote: > On Mon, Jan 11, 2021 at 10:56 PM Leon Romanovsky wrote: > > > > On Mon, Jan 11, 2021 at 11:30:39AM -0800, Alexander Duyck wrote: > > > On Sun, Jan 10, 2021 at 7:10 AM Leon Romanovsky wrote: > > > > > > > > From: Leon Romanovsky >

Re: [PATCH mlx5-next v1 1/5] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

On Tue, Jan 12, 2021 at 01:59:51PM -0800, Alexander Duyck wrote: > On Mon, Jan 11, 2021 at 10:39 PM Leon Romanovsky wrote: > > > > On Mon, Jan 11, 2021 at 11:30:33AM -0800, Alexander Duyck wrote: > > > On Sun, Jan 10, 2021 at 7:12 AM Leon Romanovsky wrote: > > > > > > > > From: Leon Romanovsky >

Re: [kbuild-all] Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

On 1/13/21 11:13 AM, Vincent MAILHOL wrote: On Tue 13 Jan 2021 at 00:29, kernel test robot wrote: Hi Vincent, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.11-rc3 next-20210111] [If your patch is applied to the wrong

Re: [PATCH net-next 0/7] a set of fixes of coding style

On Tue, Jan 12, 2021 at 5:54 PM Jakub Kicinski wrote: > > On Tue, 12 Jan 2021 00:42:58 -0600 Lijun Pan wrote: > > This series address several coding style problems. > > Erm, are you sure this series will not conflict with the fixes > Sukadev is sending? Maybe one or two if the fixes go to net. An

[PATCH bpf v2 1/2] bpf: support PTR_TO_MEM{,_OR_NULL} register spilling

Add support for pointer to mem register spilling, to allow the verifier to track pointers to valid memory addresses. Such pointers are returned for example by a successful call of the bpf_ringbuf_reserve helper. The patch was partially contributed by CyberArk Software, Inc. Fixes: 457f44363a88 ("

[PATCH bpf v2 2/2] selftests/bpf: add verifier test for PTR_TO_MEM spill

Add a test to check that the verifier is able to recognize spilling of PTR_TO_MEM registers, by reserving a ringbuf buffer, forcing the spill of a pointer holding the buffer address to the stack, filling it back in from the stack and writing to the memory area pointed by it. The patch was partial

Re: [PATCH] scsi: qedf: style: Simplify bool comparison

Yang, > Fix the following coccicheck warning: > ./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH bpf-next] bpf: reject too big ctx_size_in for raw_tp test run

On 1/12/21 3:42 PM, Song Liu wrote: syzbot reported a WARNING for allocating too big memory: WARNING: CPU: 1 PID: 8484 at mm/page_alloc.c:4976 __alloc_pages_nodemask+0x5f8/0x730 mm/page_alloc.c:5011 Modules linked in: CPU: 1 PID: 8484 Comm: syz-executor862 Not tainted 5.11.0-rc2-syzkaller #0

[PATCH net] Revert "virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()"

From: Eric Dumazet This reverts commit c67f5db82027ba6d2ea4ac9176bc45996a03ae6a. While using page fragments instead of a kmalloc backed skb->head might give a small performance improvement in some cases, there is a huge risk of memory use under estimation. GOOD_COPY_LEN is 128 bytes. This means

[PATCH net] ch_ipsec: Remove initialization of rxq related data

Removing initialization of nrxq and rxq_size in uld_info. As ipsec uses nic queues only, there is no need to create uld rx queues for ipsec. Fixes: 1b77be463929e ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net") Signed-off-by: Ayush Sawal --- .../net/ethernet/chelsio/

Re: [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking

Jakub Kicinski [k...@kernel.org] wrote: > On Tue, 12 Jan 2021 10:14:34 -0800 Sukadev Bhattiprolu wrote: > > Use more consistent locking when reading/writing the adapter->state > > field. This patch set fixes a race condition during ibmvnic_open() > > where the adapter could be left in the PROBED st

Re: [PATCH net-next] net: ipa: add config dependency on QCOM_SMEM

Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 12 Jan 2021 13:21:34 -0600 you wrote: > The IPA driver depends on some SMEM functionality (qcom_smem_init(), > qcom_smem_alloc(), and qcom_smem_virt_to_phys()), but this is not > reflected in the configuration depen

Re: [PATCH] hci: llc_shdlc: style: Simplify bool comparison

Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 11 Jan 2021 17:24:23 +0800 you wrote: > Fix the following coccicheck warning: > ./net/nfc/hci/llc_shdlc.c:239:5-21: WARNING: Comparison to bool > > Signed-off-by: YANG LI > Reported-by: Abaci Robot > --- > net/nf

Re: [PATCH net-next v8 0/2] net: dsa: add stats64 support

Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 11 Jan 2021 11:46:56 +0100 you wrote: > changes v8: > - stats.no_handler should not be assigned from HW stats > > changes v7: > - move raw.filtered from rx_errors to rx_dropped counter > > changes v6: > - move st

Re: [PATCH net 0/2] net/smc: fix out of bound access in netlink interface

Hello: This series was applied to netdev/net.git (refs/heads/master): On Tue, 12 Jan 2021 17:21:20 +0100 you wrote: > Please apply the following patch for smc to netdev's net tree. > > Both patches fix possible out-of-bounds reads. The original code expected > that snprintf() reads len-1 bytes f

Re: [PATCH net 0/3] Netfilter fixes for net

On Tue, 12 Jan 2021 23:20:30 +0100 Pablo Neira Ayuso wrote: > The following patchset contains Netfilter fixes for net: > > 1) Pass conntrack -f to specify family in netfilter conntrack helper >selftests, from Chen Yi. > > 2) Honor hashsize modparam from nf_conntrack_buckets sysctl, >from

Re: mv88e6xxx: 2500base-x inband AN is broken on Amethyst? what to do?

It seems this problem can manifest somehow with Peridot as well, at least when in combination with 88X3310 PHY. I will do some more experiments and try to come up with a solution. Marek

Re: [PATCH net-next 1/2] mlxsw: Register physical ports as a devlink resource

On Tue, 12 Jan 2021 10:39:30 +0200 Ido Schimmel wrote: > From: Danielle Ratson > > The switch ASIC has a limited capacity of physical ('flavour physical' > in devlink terminology) ports that it can support. While each system is > brought up with a different number of ports, this number can be > i

Re: [PATCH net 0/2] mptcp: a couple of fixes

Hello: This series was applied to netdev/net.git (refs/heads/master): On Tue, 12 Jan 2021 18:25:22 +0100 you wrote: > This series includes two related fixes addressing potential divide by 0 > bugs in the MPTCP datapath. > > Paolo Abeni (2): > mptcp: more strict state checking for acks > mptc

Re: [PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

On Tue, Jan 12, 2021 at 3:53 PM Greg KH wrote: > > On Tue, Jan 12, 2021 at 01:36:29PM +0800, Cindy Lu wrote: > > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > > this cb.private will finally use in vhost_vdpa_config_cb as > > vhost_vdpa. Fix this issue. > > > > Fixes: 776f39

Re: [PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

On Wed, Jan 13, 2021 at 11:38 AM Jason Wang wrote: > > > On 2021/1/12 下午1:36, Cindy Lu wrote: > > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > > this cb.private will finally use in vhost_vdpa_config_cb as > > vhost_vdpa. Fix this issue. > > > > Fixes: 776f395004d82 ("vhost

Re: [PATCH RESEND net-next] net: sfp: add debugfs support

Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 10 Jan 2021 10:59:38 + you wrote: > Add debugfs support to SFP so that the internal state of the SFP state > machines and hardware signal state can be viewed from userspace, rather > than having to compile a deb

Re: [PATCH v2 0/3] hv_netvsc: Prevent packet loss during VF add/remove

Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 8 Jan 2021 16:53:40 -0800 you wrote: > From: Long Li > > This patch set fixes issues with packet loss on VF add/remove. > > Long Li (3): > hv_netvsc: Check VF datapath when sending traffic to VF > hv_netvsc

Re: [PATCH net-next] fsl/fman: Add MII mode support.

Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 11 Jan 2021 07:39:03 +0300 you wrote: > Set proper value to IF_MODE register for MII mode. > > Signed-off-by: Maxim Kochetkov > --- > drivers/net/ethernet/freescale/fman/fman_memac.c | 4 > 1 file changed, 4

Re: [PATCH net 0/2] bnxt_en: Bug fixes.

Hello: This series was applied to netdev/net.git (refs/heads/master): On Mon, 11 Jan 2021 04:26:38 -0500 you wrote: > This series has 2 fixes. The first one fixes a resource accounting error > with the RDMA driver loaded and the second one fixes the firmware > flashing sequence after defragmenta

Re: [PATCH 1/2] r8152: Add Lenovo Powered USB-C Travel Hub

Hello: This series was applied to netdev/net.git (refs/heads/master): On Mon, 11 Jan 2021 20:03:13 +0100 you wrote: > This USB-C Hub (17ef:721e) based on the Realtek RTL8153B chip used to > use the cdc_ether driver. However, using this driver, with the system > suspended the device constantly sen

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

On 2021/1/13 上午7:47, Willem de Bruijn wrote: On Tue, Jan 12, 2021 at 3:29 PM Yuri Benditovich wrote: On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich wrote: On Tue, Jan 12, 2021 at 9:41 PM Yuri Benditovich wrote: Existing TUN module is able to use provided "steering eBPF" to calculate per

[PATCH net-next v3 12/13] selftests: Remove exraneous newline in nettest

Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/net/nettest.c b/tools/testing/selftests/net/nettest.c index 8865cc00e93a..3568ec80785b 100644 --- a/tools/testing/selftests/net/nettest.c +++ b/tools/te

[PATCH net-next v3 07/13] selftests: Add missing newline in nettest error messages

From: David Ahern A few logging lines are missing the newline, or need it moved up for cleaner logging. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/net/nettest.c

[PATCH net-next v3 10/13] selftests: Add new option for client-side passwords

From: David Ahern Add new option to nettest to specify MD5 password to use for client side. Update fcnal-test script. This is needed for a single instance running both server and client modes to test password mismatches. Signed-off-by: David Ahern --- tools/testing/selftests/net/fcnal-test.sh

[PATCH net-next v3 13/13] selftests: Add separate option to nettest for address binding

Add separate option to nettest to specify local address binding in client mode. Signed-off-by: David Ahern --- tools/testing/selftests/net/fcnal-test.sh | 12 ++-- tools/testing/selftests/net/nettest.c | 11 +-- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/

[PATCH net-next v3 11/13] selftests: Add separate options for server device bindings

From: David Ahern Add new options to nettest to specify device binding and expected device binding for server mode, and update fcnal-test script. This is needed to allow a single instance of nettest running both server and client modes to use different device bindings. Signed-off-by: David Ahern

[PATCH net-next v3 09/13] selftests: Consistently specify address for MD5 protection

From: David Ahern nettest started with -r as the remote address for MD5 passwords. The -m argument was added to use prefixes with a length when that feature was added to the kernel. Since -r is used to specify remote address for client mode, change nettest to only use -m for MD5 passwords and upd

[PATCH net-next v3 08/13] selftests: Make address validation apply only to client mode

From: David Ahern When a single instance of nettest is used for client and server make sure address validation is only done for client mode. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/ne

[PATCH net-next v3 06/13] selftests: Use separate stdout and stderr buffers in nettest

From: David Ahern When a single instance of nettest is doing both client and server modes, stdout and stderr messages can get interlaced and become unreadable. Allocate a new set of buffers for the child process handling server mode. Signed-off-by: David Ahern --- tools/testing/selftests/net/n

[PATCH net-next v3 05/13] selftests: Add support to nettest to run both client and server

From: David Ahern Add option to nettest to run both client and server within a single instance. Client forks a child process to run the server code. A pipe is used for the server to tell the client it has initialized and is ready or had an error. This avoid unnecessary sleeps to handle such race

[PATCH net-next v3 04/13] selftests: Add options to set network namespace to nettest

From: David Ahern Add options to specify server and client network namespace to use before running respective functions. Signed-off-by: Seth David Schoen Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 56 ++- 1 file changed, 55 insertions(+), 1

[PATCH net-next v3 02/13] selftests: Move convert_addr up in nettest

From: David Ahern convert_addr needs to be invoked in a different location. Move the code up to avoid a forward declaration. Code move only. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 252 +- 1 file changed, 126 insertions(+), 126 deletions(

[PATCH net-next v3 03/13] selftests: Move address validation in nettest

From: David Ahern IPv6 addresses can have a device name to declare a scope (e.g., fe80::5054:ff:fe12:3456%eth0). The next patch adds support to switch network namespace before running client or server code (or both), so move the address validation to the server and client functions. IPv4 multica

[PATCH net-next v3 01/13] selftests: Move device validation in nettest

From: David Ahern Later patch adds support for switching network namespaces before running client, server or both. Device validations need to be done after the network namespace switch, so add a helper to do it and invoke in server and client code versus inline with argument parsing. Move related

[PATCH net-next v3 00/13] selftests: Updates to allow single instance of nettest for client and server

Update nettest to handle namespace change internally to allow a single instance to run both client and server modes. Device validation needs to be moved after the namespace change and a few run time options need to be split to allow values for client and server. v3 - send proper status in do_serve

RE: [PATCH net-next] udp: allow forwarding of plain (non-fraglisted) UDP GRO packets

On 2021-01-13 12:10, Alexander Duyck wrote: > On 1/12/21 1:16 PM, Alexander Lobakin wrote: > > Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") actually > > not only added a support for fraglisted UDP GRO, but also tweaked > > some logics the way that non-fraglisted UDP GRO started to wor

Re: [PATCH net-next v14 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

On Tue, 12 Jan 2021 23:58:24 +0200 Vladimir Oltean wrote: > On Tue, Jan 12, 2021 at 07:06:29PM +0100, Marek Behún wrote: > > On Tue, 12 Jan 2021 16:29:09 + > > Russell King - ARM Linux admin wrote: > > > > > I'm seriously thinking about changing the phylink_validate() interface > > > such

[PATCH] net: stmmac: Fixed mtu channged by cache aligned

Since the original mtu is not used when the mtu is updated, the mtu is aligned with cache, this will get an incorrect. For example, if you want to configure the mtu to be 1500, but mtu 1536 is configured in fact. Fixed: eaf4fac478077 ("net: stmmac: Do not accept invalid MTU values") Signed-off-by:

Re: [PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

On 2021/1/12 下午1:36, Cindy Lu wrote: In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. this cb.private will finally use in vhost_vdpa_config_cb as vhost_vdpa. Fix this issue. Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa") Acked-by: Jason Wang Signed-of

Re: [net] net: feature check mandating HW_CSUM is wrong

On Tue, Jan 12, 2021 at 6:43 PM rohit maheshwari wrote: > > > On 07/01/21 12:47 AM, Jakub Kicinski wrote: > > On Wed, 6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote: > >> Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong. > >> And it broke tls offload feature for the drivers, whi

Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

On Tue 13 Jan 2021 at 00:29, kernel test robot wrote: > > Hi Vincent, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v5.11-rc3 next-20210111] > [If your patch is applied to the wrong git tree, kindly drop us a note. >

Re: [PATCH net-next] udp: allow forwarding of plain (non-fraglisted) UDP GRO packets

On 1/12/21 1:16 PM, Alexander Lobakin wrote: Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") actually not only added a support for fraglisted UDP GRO, but also tweaked some logics the way that non-fraglisted UDP GRO started to work for forwarding too. Tests showed that currently forwar

Re: [PATCH net-next 0/3] r8169: further improvements

On Tue, 12 Jan 2021 12:21:48 -0800 Saeed Mahameed wrote: > On Tue, 2021-01-12 at 09:27 +0100, Heiner Kallweit wrote: > > Series includes further smaller improvements. > > > > Heiner Kallweit (3): > > r8169: align rtl_wol_suspend_quirk with vendor driver and rename it > > r8169: improve rtl8169

Re: [PATCH net] net: dsa: clear devlink port type before unregistering slave netdevs

On Tue, 12 Jan 2021 10:49:21 -0800 Florian Fainelli wrote: > On 1/11/21 4:48 PM, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > Florian reported a use-after-free bug in devlink_nl_port_fill found with > > KASAN: > > > > (devlink_nl_port_fill) > > (devlink_port_notify) > > (devlink_port

Re: [PATCH net] net: dsa: unbind all switches from tree when DSA master unbinds

On Tue, 12 Jan 2021 10:51:39 -0800 Florian Fainelli wrote: > On 1/11/21 3:09 PM, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > Currently the following happens when a DSA master driver unbinds while > > there are DSA switches attached to it: > > > > $ echo :00:00.5 > /sys/bus/pci/d

Re: [PATCH net-next] net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig

On Mon, 11 Jan 2021 15:49:33 +0100 Andrew Lunn wrote: > On Mon, Jan 11, 2021 at 01:50:46PM +0100, Marek Vasut wrote: > > The PHYLIB must be selected to provide mdiobus_*() functions, and the > > MICREL_PHY is necessary too, as that is the only possible PHY attached > > to the KS8851 (it is the inte

Re: [PATCH net-next 2/4] dt-bindings: net: remove modem-remoteproc property

On Tue, Jan 12, 2021 at 01:28:29PM -0600, Alex Elder wrote: > The IPA driver uses the remoteproc SSR notifier now, rather than the > temporary IPA notification system used initially. As a result it no > longer needs a property identifying the modem subsystem DT node. > > Use GIC_SPI rather than 0

Re: [PATCH] net: phy: smsc: fix clk error handling

On Mon, 11 Jan 2021 15:17:05 +0100 Andrew Lunn wrote: > On Mon, Jan 11, 2021 at 09:59:32AM +0100, Marco Felsch wrote: > > Commit bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in > > support") added the phy clk support. The commit already checks if > > clk_get_optional() throw an error b

Re: [PATCH net-next 2/4] dt-bindings: net: remove modem-remoteproc property

On Tue, 12 Jan 2021 13:28:29 -0600, Alex Elder wrote: > The IPA driver uses the remoteproc SSR notifier now, rather than the > temporary IPA notification system used initially. As a result it no > longer needs a property identifying the modem subsystem DT node. > > Use GIC_SPI rather than 0 in th

Re: [PATCH net v2] net: macb: Add default usrio config to default gem config

On Tue, 2021-01-12 at 18:11 -0800, Jakub Kicinski wrote: > On Mon, 11 Jan 2021 17:47:28 -0800 Atish Patra wrote: > > There is no usrio config defined for default gem config leading to > > a kernel panic devices that don't define a data. This issue can be > > reprdouced with microchip polar fire soc

Re: [PATCH net 1/2] net: stmmac: fix taprio schedule configuration

On Tue, 12 Jan 2021 18:24:56 +0100 Yannick Vignon wrote: > From: Yannick Vignon > > When configuring a 802.1Qbv schedule through the tc taprio qdisc on an NXP > i.MX8MPlus device, the effective cycle time differed from the requested one > by N*96ns, with N number of entries in the Qbv Gate Contro

Re: [PATCH net] rxrpc: Call state should be read with READ_ONCE() under some circumstances

On Tue, 12 Jan 2021 15:59:15 + David Howells wrote: > From: Baptiste Lepers > > The call state may be changed at any time by the data-ready routine in > response to received packets, so if the call state is to be read and acted > upon several times in a function, READ_ONCE() must be used unle

Re: [Patch net] cls_flower: call nla_ok() before nla_next()

On Wed, Jan 13, 2021 at 1:43 AM Cong Wang wrote: > > On Tue, Jan 12, 2021 at 3:52 AM Xin Long wrote: > > > > On Tue, Jan 12, 2021 at 10:56 AM Cong Wang wrote: > > > > > > From: Cong Wang > > > > > > fl_set_enc_opt() simply checks if there are still bytes left to parse, > > > but this is not suf

Re: [PATCH v1] net/ipv4: add IPv4_is_multicast() check in ip_mc_leave_group().

On Tue, 12 Jan 2021 00:47:09 -0800 wangyingji...@126.com wrote: > From: Yingjie Wang > > There is no IPv4_is_multicast() check added to ip_mc_leave_group() > to determine whether imr->imr_multiaddr.s_addr is a multicast address. > If not a multicast address, it may result in an error. > In some c

RE: [PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

Thanks for the hint, Yeah I missed the call to rt6_add_dflt_router while applying patch to master branch. I am developer of SONiC OS (https://azure.github.io/SONiC/) in LinkedIn. We are planning to move to IPv6 only network and I realise that IPv6 needs capability to let administrator configure

Re: [PATCH v2] af/rvu_cgx: Fix missing check bugs in rvu_cgx.c

On Mon, 11 Jan 2021 18:09:49 -0800 wangyingji...@126.com wrote: > From: Yingjie Wang > > In rvu_mbox_handler_cgx_mac_addr_get() > and rvu_mbox_handler_cgx_mac_addr_set(), > the msg is expected only from PFs that are mapped to CGX LMACs. > It should be checked before mapping, > so we add the is_cg

Re: [PATCHv2 net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

On Mon, Jan 11, 2021 at 9:14 PM Xin Long wrote: > > On Tue, Jan 12, 2021 at 12:48 AM Alexander Duyck > wrote: > > > > On Mon, Jan 11, 2021 at 5:22 AM Xin Long wrote: > > > > > > This patch is to let it always do CRC checksum in sctp_gso_segment() > > > by removing CRC flag from the dev features

Re: [PATCH net v2] net: macb: Add default usrio config to default gem config

On Mon, 11 Jan 2021 17:47:28 -0800 Atish Patra wrote: > There is no usrio config defined for default gem config leading to > a kernel panic devices that don't define a data. This issue can be > reprdouced with microchip polar fire soc where compatible string > is defined as "cdns,macb". > > Fixes:

Re: [PATCH v6 net-next 14/15] net: bonding: ensure .ndo_get_stats64 can sleep

Saeed Mahameed wrote: >On Tue, 2021-01-12 at 16:37 +0200, Vladimir Oltean wrote: >> On Mon, Jan 11, 2021 at 03:38:49PM -0800, Saeed Mahameed wrote: >> > GFP_ATOMIC is a little bit aggressive especially when user daemons >> > are >> > periodically reading stats. This can be avoided. >> > >> > You

Re: [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking

On Tue, 12 Jan 2021 10:14:34 -0800 Sukadev Bhattiprolu wrote: > Use more consistent locking when reading/writing the adapter->state > field. This patch set fixes a race condition during ibmvnic_open() > where the adapter could be left in the PROBED state if a reset occurs > at the wrong time. This

Re: [PATCH net-next v2 5/7] ibmvnic: serialize access to work queue

On Tue, 12 Jan 2021 16:40:49 -0800 Sukadev Bhattiprolu wrote: > Saeed Mahameed [sa...@kernel.org] wrote: > > On Tue, 2021-01-12 at 10:14 -0800, Sukadev Bhattiprolu wrote: > > > > > @@ -5467,7 +5472,15 @@ static int ibmvnic_remove(struct vio_dev *dev) > > > return -EBUSY; > > > } > >

[PATCH v1 net-next 0/1] Allow user to set metric on default route learned via Router Advertisement.

Allow user to set metric on default route learned via Router Advertisement. Note: RFC 4191 does not say anything for metric for IPv6 default route. Fix: For IPv4, default route is learned via DHCPv4 and user is allowed to change metric using config in etc/network/interfaces. But for IPv6, default

[PATCH v1 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

For IPv4, default route is learned via DHCPv4 and user is allowed to change metric using config etc/network/interfaces. But for IPv6, default route can be learned via RA, for which, currently a fixed metric value 1024 is used. Ideally, user should be able to configure metric on default route for I

Re: [PATCH v4 1/1] can: dev: add software tx timestamps

On Tue, 12 Jan 2021 17:46:25 -0800 Jakub Kicinski wrote: > On Tue, 12 Jan 2021 11:03:00 +0100 Marc Kleine-Budde wrote: > > On 1/12/21 10:54 AM, Vincent Mailhol wrote: > > > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > > > tx timestamp gets attached on the skb. > > > > >

Re: [PATCH v4 1/1] can: dev: add software tx timestamps

On Tue, 12 Jan 2021 11:03:00 +0100 Marc Kleine-Budde wrote: > On 1/12/21 10:54 AM, Vincent Mailhol wrote: > > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > > tx timestamp gets attached on the skb. > > > > There two main reasons to include this call in can_put_echo_skb(): >

Re: [Patch net] cls_flower: call nla_ok() before nla_next()

On Mon, 11 Jan 2021 18:55:48 -0800 Cong Wang wrote: > From: Cong Wang > > fl_set_enc_opt() simply checks if there are still bytes left to parse, > but this is not sufficent as syzbot seems to be able to generate > malformatted netlink messages. nla_ok() is more strict so should be > used to valid

RE: [PATCH] igb: avoid premature Rx buffer reuse

> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Wednesday, January 13, 2021 5:23 AM > To: Li,Rongqing > Cc: Netdev ; intel-wired-lan > ; Björn Töpel > Subject: Re: [PATCH] igb: avoid premature Rx buffer r > Okay, this explanation makes much more

Re: [PATCH v3 bpf-next 7/7] selftests/bpf: test kernel module ksym externs

On Tue, Jan 12, 2021 at 3:41 AM Andrii Nakryiko wrote: > > Add per-CPU variable to bpf_testmod.ko and use those from new selftest to > validate it works end-to-end. > > Acked-by: Yonghong Song > Acked-by: Hao Luo > Signed-off-by: Andrii Nakryiko Applied. FYI for everyone. This test needs the

Re: [PATCH bpf-next v2 1/2] bpf: allow to retrieve sol_socket opts from sock_addr progs

On Mon, Jan 11, 2021 at 3:09 PM Daniel Borkmann wrote: > > The _bpf_setsockopt() is able to set some of the SOL_SOCKET level options, > however, _bpf_getsockopt() has little support to actually retrieve them. > This small patch adds few misc options such as SO_MARK, SO_PRIORITY and > SO_BINDTOIFIN

RE: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

> > I think it's possible to return a Master/Slave configuration. > > Great. It would be good to add it. OK. I think it will take some time to implement this feature, as we prioritize investigating comments from Russell. > > By the way, do you need the cable test function as implementedin > > nx

Re: [PATCH net-next v2 3/7] ibmvnic: avoid allocating rwi entries

Saeed Mahameed [sa...@kernel.org] wrote: > > -struct ibmvnic_rwi { > > - enum ibmvnic_reset_reason reset_reason; > > - struct list_head list; > > -}; > > + VNIC_RESET_CHANGE_PARAM, > > + VNIC_RESET_MAX}; // must be last >this is not the pref

Re: [PATCH net-next 0/5] skbuff: introduce skbuff_heads bulking and reusing

On Tue, 12 Jan 2021 13:23:16 +0100 Eric Dumazet wrote: > On Tue, Jan 12, 2021 at 12:08 PM Alexander Lobakin wrote: > > > > From: Edward Cree > > Date: Tue, 12 Jan 2021 09:54:04 + > > > > > Without wishing to weigh in on whether this caching is a good idea... > > > > Well, we already have

[PATCH bpf-next] bpf: reject too big ctx_size_in for raw_tp test run

syzbot reported a WARNING for allocating too big memory: WARNING: CPU: 1 PID: 8484 at mm/page_alloc.c:4976 __alloc_pages_nodemask+0x5f8/0x730 mm/page_alloc.c:5011 Modules linked in: CPU: 1 PID: 8484 Comm: syz-executor862 Not tainted 5.11.0-rc2-syzkaller #0 Hardware name: Google Google Compute Eng

Re: [PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

On Tue, 12 Jan 2021 11:55:11 -0800 Praveen Chaudhary wrote: > Hi Jakub > > Thanks for the review, > > Sure, I will reraise the patch (again v0i, sonce no code changes) after > adding space before '<'. > > This patch adds lines in 'include/uapi/', that requires ABI version changes > for debian

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

On Mon, Jan 11, 2021 at 7:06 PM Nathan Chancellor wrote: > > After commit da5fb18225b4 ("bpf: Support pre-2.25-binutils objcopy for > vmlinux BTF"), having CONFIG_DEBUG_INFO_BTF enabled but lacking a valid > copy of pahole results in a kernel that will fully compile but fail to > link. The user th

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

On Tue, Jan 12, 2021 at 3:29 PM Yuri Benditovich wrote: > > On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich > wrote: > > > > On Tue, Jan 12, 2021 at 9:41 PM Yuri Benditovich > > wrote: > > > > > > Existing TUN module is able to use provided "steering eBPF" to > > > calculate per-packet hash and

Re: [PATCH] mm: net: memcg accounting for TCP rx zerocopy

On Tue, Jan 12, 2021 at 03:36:18PM -0800, Arjun Roy wrote: > On Tue, Jan 12, 2021 at 3:31 PM Roman Gushchin wrote: > > > > On Tue, Jan 12, 2021 at 01:41:05PM -0800, Shakeel Butt wrote: > > > From: Arjun Roy > > > > > > TCP zerocopy receive is used by high performance network applications to > > >

Re: [PATCH net-next 0/7] a set of fixes of coding style

On Tue, 12 Jan 2021 00:42:58 -0600 Lijun Pan wrote: > This series address several coding style problems. Erm, are you sure this series will not conflict with the fixes Sukadev is sending?

Re: [PATCH net] net: dcb: Accept RTM_GETDCB messages carrying set-like DCB commands

Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 11 Jan 2021 18:07:07 +0100 you wrote: > In commit 826f328e2b7e ("net: dcb: Validate netlink message in DCB > handler"), Linux started rejecting RTM_GETDCB netlink messages if they > contained a set-like DCB_CMD_ command.

Re: [PATCH net-next v2 5/7] ibmvnic: serialize access to work queue

Saeed Mahameed [sa...@kernel.org] wrote: > On Tue, 2021-01-12 at 10:14 -0800, Sukadev Bhattiprolu wrote: > > @@ -5467,7 +5472,15 @@ static int ibmvnic_remove(struct vio_dev *dev) > > return -EBUSY; > > } > > > > + /* If ibmvnic_reset() is scheduling a reset, wait for it to > >

mv88e6xxx: 2500base-x inband AN is broken on Amethyst? what to do?

Hello, it seems that inband AN is broken on Amethyst when on 2500base-x mode. Even SERDES scripts for Amethyst from Marvell has autonegotiation disabled for 2500base-x mode. For all the other supported Serdes modes autonegotiation is enabled in these scripts. The current implementation in mv88e6

Re: [PATCH] kernel: trace: uprobe: Fix word to the correct spelling

On 1/11/21 8:50 PM, Bhaskar Chowdhury wrote: > s/controling/controlling/p > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap Thanks. > --- > kernel/trace/trace_uprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/tra

Re: [PATCH] tcp: keepalive fixes

Hi, Yuchung: I have attached the python script that reproduces the keepalive issues. The script is a slight modification of the one written by Marek Majkowski: https://github.com/cloudflare/cloudflare-blog/blob/master/2019-09-tcp-keepalives/test-zero.py Please note that only the TCP keepalive is

Re: (subset) [PATCH 00/10] Remove support for TX49xx

On Tue, 5 Jan 2021 15:02:45 +0100, Thomas Bogendoerfer wrote: > I couldn't find any buyable product other than reference boards using > TX49xx CPUs. And since nobody showed interest in keeping support for > it, it's time to remove it. > > I've split up the removal into seperate parts for different

Re: [PATCH] mm: net: memcg accounting for TCP rx zerocopy

On Tue, Jan 12, 2021 at 01:41:05PM -0800, Shakeel Butt wrote: > From: Arjun Roy > > TCP zerocopy receive is used by high performance network applications to > further scale. For RX zerocopy, the memory containing the network data > filled by network driver is directly mapped into the address spac

Re: [PATCH v3 bpf-next 5/7] bpf: support BPF ksym variables in kernel modules

On Tue, Jan 12, 2021 at 8:30 AM Daniel Borkmann wrote: > > On 1/12/21 8:55 AM, Andrii Nakryiko wrote: > > Add support for directly accessing kernel module variables from BPF programs > > using special ldimm64 instructions. This functionality builds upon vmlinux > > ksym support, but extends ldimm6

Re: [PATCv4 net-next] octeontx2-pf: Add RSS multi group support

On Tue, 2021-01-12 at 15:16 -0800, Saeed Mahameed wrote: > On Mon, 2021-01-04 at 12:50 +0530, Geetha sowjanya wrote: > > Hardware supports 8 RSS groups per interface. Currently we are > > using > > only group '0'. This patch allows user to create new RSS > > groups/contexts > > and use the same as

Re: [PATCv4 net-next] octeontx2-pf: Add RSS multi group support

On Mon, 2021-01-04 at 12:50 +0530, Geetha sowjanya wrote: > Hardware supports 8 RSS groups per interface. Currently we are using > only group '0'. This patch allows user to create new RSS > groups/contexts > and use the same as destination for flow steering rules. > > usage: > To steer the traffic

Re: [PATCH net-next 0/7] a set of fixes of coding style

On Tue, 2021-01-12 at 00:42 -0600, Lijun Pan wrote: > This series address several coding style problems. > > Lijun Pan (7): > ibmvnic: prefer 'unsigned long' over 'unsigned long int' > ibmvnic: fix block comments > ibmvnic: fix braces > ibmvnic: avoid multiple line dereference > ibmvnic:

  1   2   3   4   5   >