Re: [RESEND PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

2021-01-07 Thread Greg KH
On Fri, Jan 08, 2021 at 10:05:26AM +0800, Xu Yilun wrote: > On Thu, Jan 07, 2021 at 10:26:12AM +0100, Greg KH wrote: > > On Thu, Jan 07, 2021 at 02:07:08PM +0800, Xu Yilun wrote: > > > This driver supports the ethernet retimers (C827) for the Intel PAC > > > (Programmable Acceleration Card) N3000,

Re: [PATCH] neighbour: Disregard DEAD dst in neigh_update

2021-01-07 Thread Greg KH
On Thu, Jan 07, 2021 at 09:36:37PM -0500, Your Real Name wrote: > On Tue, Jan 05, 2021 at 04:05:21PM -0800, David Miller wrote: > > > > > > From: Tong Zhu > > Date: Wed, 30 Dec 2020 17:54:23 -0500 > > > > > In 4.x kernel a dst in DST_OBSOLETE_DEAD state is associated > > > with loopback net_de

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-07 Thread Leon Romanovsky
On Thu, Jan 07, 2021 at 10:54:38PM -0500, Don Dutile wrote: > On 1/7/21 7:57 PM, Bjorn Helgaas wrote: > > [+cc Alex, Don] <...> > > Help me connect the dots here. Is this required because of something > > peculiar to mlx5, or is something like this required for all SR-IOV > > devices because of

[net v2] tipc: fix NULL deref in tipc_link_xmit()

2021-01-07 Thread Hoang Huu Le
From: Hoang Le The buffer list can have zero skb as following path: tipc_named_node_up()->tipc_node_xmit()->tipc_link_xmit(), so we need to check the list before casting an &sk_buff. Fault report: [] tipc: Bulk publication failure [] general protection fault, probably for non-canonical [#1] PR

[PATCH 1/7] ibmvnic: restore state in change-param reset

2021-01-07 Thread Sukadev Bhattiprolu
Restore adapter state before returning from change-param reset. In case of errors, caller will try a hard-reset anyway. Fixes: 0cb4bc66ba5e ("ibmvnic: restore adapter state on failed reset") Signed-off-by: Sukadev Bhattiprolu --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 inse

[PATCH 4/7] ibmvnic: switch order of checks in ibmvnic_reset

2021-01-07 Thread Sukadev Bhattiprolu
We check separately for REMOVING and PROBING in ibmvnic_reset(). Switch the order of checks to facilitate better locking when checking for REMOVING/REMOVED state. Fixes: 6a2fb0e99f9c ("ibmvnic: driver initialization for kdump/kexec") Signed-off-by: Sukadev Bhattiprolu --- drivers/net/ethernet/

[PATCH 2/7] ibmvnic: update reset function prototypes

2021-01-07 Thread Sukadev Bhattiprolu
The reset functions need just the 'reset reason' parameter and not the ibmvnic_rwi list element. Update the functions so we can simplify the handling of the ->rwi_list in a follow-on patch. Fixes: 2770a7984db5 ("ibmvnic: Introduce hard reset recovery") Signed-off-by: Sukadev Bhattiprolu --- dri

[PATCH 6/7] ibmvnic: check adapter->state under state_lock

2021-01-07 Thread Sukadev Bhattiprolu
Consider following code from __ibmvnic_reset() spin_lock_irqsave(&adapter->state_lock, flags); if (adapter->state == VNIC_REMOVING || adapter->state == VNIC_REMOVED) { spin_unlock_irqrestore(&adapter->state_lock, flags);

[PATCH 7/7] ibmvnic: add comments about adapter->state_lock

2021-01-07 Thread Sukadev Bhattiprolu
Add some comments, notes and TODOs about ->state_lock and RTNL. Signed-off-by: Sukadev Bhattiprolu --- Note: This is fixing lot of comments so not identifying fixes. It "seems" to fit this patch set but can send to net-next if necessary. drivers/net/ethernet/ibm/ibmvnic.c | 58

[PATCH 5/7] ibmvnic: use a lock to serialize remove/reset

2021-01-07 Thread Sukadev Bhattiprolu
Use a separate lock to serialze ibmvnic_reset() and ibmvnic_remove() functions. ibmvnic_reset() schedules work for the worker thread and ibmvnic_remove() flushes the work before removing the adapter. We don't want any work to be scheduled once we start removing the adapter (i.e after we have alread

[PATCH 0/7] ibmvnic: Use more consistent locking

2021-01-07 Thread Sukadev Bhattiprolu
Use more consistent locking when reading/writing the adapter->state field. This patch set fixes a race condition during ibmvnic_open() where the adapter could be left in the PROBED state if a reset occurs at the wrong time. This can cause networking to not come up during boot and potentially requir

[PATCH 3/7] ibmvnic: avoid allocating rwi entries

2021-01-07 Thread Sukadev Bhattiprolu
Whenever we need to schedule a reset, we allocate an rwi (reset work item?) entry and add to the list of pending resets. Since we only add one rwi for a given reason type to the list (no duplicates). we will only have a handful of reset types in the list - even in the worst case. In the common cas

Re: 5.10.4+ hang with 'rmmod nf_conntrack'

2021-01-07 Thread Florian Westphal
Ben Greear wrote: > I noticed my system has a hung process trying to 'rmmod nf_conntrack'. > > I've generally been doing the script that calls rmmod forever, > but only extensively tested on 5.4 kernel and earlier. > > If anyone has any ideas, please let me know. This is from 'sysrq t'. I > d

Re: [PATCH v7 net-next 2/2] net: dsa: qca: ar9331: export stats64

2021-01-07 Thread Oleksij Rempel
On Thu, Jan 07, 2021 at 03:36:45PM +0100, Andrew Lunn wrote: > > +static void ar9331_get_stats64(struct dsa_switch *ds, int port, > > + struct rtnl_link_stats64 *s) > > +{ > > + struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv; > > + struct ar9331_sw_port

[net-next 04/15] net/mlx5e: E-Switch, Offload all chain 0 priorities when modify header and forward action is not supported

2021-01-07 Thread Saeed Mahameed
From: Jianbo Liu Miss path handling of tc multi chain filters (i.e. filters that are defined on chain > 0) requires the hardware to communicate to the driver the last chain that was processed. This is possible only when the hardware is capable of performing the combination of modify header and fo

[net-next 15/15] net/mlx5e: IPsec, Remove unnecessary config flag usage

2021-01-07 Thread Saeed Mahameed
From: Tariq Toukan MLX5_IPSEC_DEV() is always defined, no need to protect it under config flag CONFIG_MLX5_EN_IPSEC, especially in slow path. Signed-off-by: Tariq Toukan Reviewed-by: Raed Salem Reviewed-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core

[net-next 06/15] net/mlx5e: Remove redundant initialization to null

2021-01-07 Thread Saeed Mahameed
From: Roi Dayan miss_rule and prio_s args are not being referenced before assigned so there is no need to init them. Signed-off-by: Roi Dayan Reviewed-by: Oz Shlomo Reviewed-by: Paul Blakey Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c | 4 ++-- 1

[net-next 10/15] net/mlx5e: CT: Add support for mirroring

2021-01-07 Thread Saeed Mahameed
From: Paul Blakey Add support for mirroring before the CT action by splitting the pre ct rule. Mirror outputs are done first on the tc chain,prio table rule (the fwd rule), which will then forward to a per port fwd table. On this fwd table, we insert the original pre ct rule that forwards to ct/c

[net-next 11/15] net/mlx5e: CT, Avoid false lock depenency warning

2021-01-07 Thread Saeed Mahameed
From: Roi Dayan To avoid false lock dependency warning set the ct_entries_ht lock class different than the lock class of the ht being used when deleting last flow from a group and then deleting a group, we get into del_sw_flow_group() which call rhashtable_destroy on fg->ftes_hash which will tak

[net-next 08/15] net/mlx5e: CT: Preparation for offloading +trk+new ct rules

2021-01-07 Thread Saeed Mahameed
From: Roi Dayan Connection tracking associates the connection state per packet. The first packet of a connection is assigned with the +trk+new state. The connection enters the established state once a packet is seen on the other direction. Currently we offload only the established flows. However

[net-next 13/15] net/mlx5e: IPsec, Avoid unreachable return

2021-01-07 Thread Saeed Mahameed
From: Tariq Toukan Simple code improvement, move default return operation under the #else block. Signed-off-by: Tariq Toukan Reviewed-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[net-next 14/15] net/mlx5e: IPsec, Inline feature_check fast-path function

2021-01-07 Thread Saeed Mahameed
From: Tariq Toukan Feature check functions are in the TX fast-path of all SKBs, not only IPsec traffic. Move the IPsec feature check function into a header and turn it inline. Use a stub and clean the config flag condition in Eth main driver file. Signed-off-by: Tariq Toukan Reviewed-by: Raed S

[net-next 12/15] net/mlx5e: IPsec, Enclose csum logic under ipsec config

2021-01-07 Thread Saeed Mahameed
From: Tariq Toukan All IPsec logic should be wrapped under the compile flag, including its checksum logic. Introduce an inline function in ipsec datapath header, with a corresponding stub. Signed-off-by: Tariq Toukan Reviewed-by: Raed Salem Reviewed-by: Huy Nguyen Signed-off-by: Saeed Mahamee

[net-next 09/15] net/mlx5e: CT: Support offload of +trk+new ct rules

2021-01-07 Thread Saeed Mahameed
From: Roi Dayan Add support to offload +trk+new rules for terminating flows for udp protocols using source port entropy. This kind of traffic will never be considered connect in conntrack and thus never set as established so no need to keep track of them in SW conntrack and offload this traffic b

[net-next 01/15] net/mlx5: Add HW definition of reg_c_preserve

2021-01-07 Thread Saeed Mahameed
From: Paul Blakey Add capability bit to test whether reg_c value is preserved on recirculation. Signed-off-by: Paul Blakey Signed-off-by: Maor Dickman Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- include/linux/mlx5/mlx5_ifc.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[net-next 05/15] net/mlx5e: CT: Pass null instead of zero spec

2021-01-07 Thread Saeed Mahameed
From: Roi Dayan No need to pass zero spec to mlx5_add_flow_rules() as the function can handle null spec. Signed-off-by: Roi Dayan Reviewed-by: Oz Shlomo Reviewed-by: Paul Blakey Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 3 +-- 1 file changed, 1 i

[net-next 07/15] net/mlx5e: CT: Remove redundant usage of zone mask

2021-01-07 Thread Saeed Mahameed
From: Roi Dayan The zone member is of type u16 so there is no reason to apply the zone mask on it. This is also matching the call to set a match in other places which don't need and don't apply the mask. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey Signed-off-by: Saeed Mahameed --- driv

[net-next 03/15] net/mlx5: E-Switch, use new cap as condition for mpls over udp

2021-01-07 Thread Saeed Mahameed
From: Eli Cohen Use tunnel_stateless_mpls_over_udp instead of MLX5_FLEX_PROTO_CW_MPLS_UDP since new devices have native support for mpls over udp and do not rely on flex parser. Signed-off-by: Eli Cohen Reviewed-by: Roi Dayan Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- drivers

[net-next 02/15] net/mlx5e: Simplify condition on esw_vport_enable_qos()

2021-01-07 Thread Saeed Mahameed
From: Eli Cohen esw->qos.enabled will only be true if both MLX5_CAP_GEN(dev, qos) and MLX5_CAP_QOS(dev, esw_scheduling) are true. Therefore, remove them from the condition in and rely only on esw->qos.enabled. Fixes: 1bd27b11c1df ("net/mlx5: Introduce E-switch QoS management") Signed-off-by: Eli

[pull request][net-next 00/15] mlx5 updates 2021-01-07

2021-01-07 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub This series provides misc updates to mlx5 plus the +trk+new TC connection tracking rules support for UDP. For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since co

[GIT PULL] Networking for 5.11-rc3

2021-01-07 Thread Jakub Kicinski
cumentation on .ndo_get_stats net: bareudp: add missing error handling for bareudp_link_config() Merge tag 'linux-can-fixes-for-5.11-20210107' of git://git.kernel.org/.../mkl/linux-can Merge branch 'net-fix-netfilter-defrag-ip-tunnel-pmtu-blackhole' Merge

Re: [net 04/11] net/mlx5e: CT: Use per flow counter when CT flow accounting is enabled

2021-01-07 Thread Saeed Mahameed
On Thu, 2021-01-07 at 20:40 -0800, Jakub Kicinski wrote: > On Thu, 07 Jan 2021 20:18:36 -0800 Saeed Mahameed wrote: > > On Thu, 2021-01-07 at 20:06 -0800, Saeed Mahameed wrote: > > > On Thu, 2021-01-07 at 19:07 -0800, Jakub Kicinski wrote: > > > > On Thu, 7 Jan 2021 12:28:38 -0800 Saeed Mahameed

Re: [net 04/11] net/mlx5e: CT: Use per flow counter when CT flow accounting is enabled

2021-01-07 Thread Jakub Kicinski
On Thu, 07 Jan 2021 20:18:36 -0800 Saeed Mahameed wrote: > On Thu, 2021-01-07 at 20:06 -0800, Saeed Mahameed wrote: > > On Thu, 2021-01-07 at 19:07 -0800, Jakub Kicinski wrote: > > > On Thu, 7 Jan 2021 12:28:38 -0800 Saeed Mahameed wrote: > > > > + int ret; > > > > + > > > > + coun

Re: [net 04/11] net/mlx5e: CT: Use per flow counter when CT flow accounting is enabled

2021-01-07 Thread Saeed Mahameed
On Thu, 2021-01-07 at 20:06 -0800, Saeed Mahameed wrote: > On Thu, 2021-01-07 at 19:07 -0800, Jakub Kicinski wrote: > > On Thu, 7 Jan 2021 12:28:38 -0800 Saeed Mahameed wrote: > > > + int ret; > > > + > > > + counter = kzalloc(sizeof(*counter), GFP_KERNEL); > > > + if (!counter) > > > + re

Re: [net 05/11] net/mlx5e: Fix SWP offsets when vlan inserted by driver

2021-01-07 Thread Saeed Mahameed
On Thu, 2021-01-07 at 19:08 -0800, Jakub Kicinski wrote: > On Thu, 7 Jan 2021 12:28:39 -0800 Saeed Mahameed wrote: > > + if (skb_vlan_tag_present(skb) && ihs) > > Double space. Will address this in a net-next patch. thanks!

Re: [net 04/11] net/mlx5e: CT: Use per flow counter when CT flow accounting is enabled

2021-01-07 Thread Saeed Mahameed
On Thu, 2021-01-07 at 19:07 -0800, Jakub Kicinski wrote: > On Thu, 7 Jan 2021 12:28:38 -0800 Saeed Mahameed wrote: > > + int ret; > > + > > + counter = kzalloc(sizeof(*counter), GFP_KERNEL); > > + if (!counter) > > + return ERR_PTR(-ENOMEM); > > + > > + counter->is_shared = false

Re: [PATCH net-next] net/bridge: fix misspellings using codespell tool

2021-01-07 Thread Randy Dunlap
On 1/7/21 6:53 PM, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > Some typos are found out by codespell tool: > > $ codespell ./net/bridge/ > ./net/bridge/br_stp.c:604: permanant ==> permanent > ./net/bridge/br_stp.c:605: persistance ==> persistence > ./net/bridge/br.c:125: underlay

Re: [PATCH v3 net-next 10/12] net: bonding: ensure .ndo_get_stats64 can sleep

2021-01-07 Thread Saeed Mahameed
On Thu, 2021-01-07 at 13:58 +0100, Eric Dumazet wrote: > On Thu, Jan 7, 2021 at 12:33 PM Vladimir Oltean > wrote: > > On Thu, Jan 07, 2021 at 12:18:28PM +0100, Eric Dumazet wrote: > > > What a mess really. > > > > Thanks, that's at least _some_ feedback :) > > Yeah, I was on PTO for the last two

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-07 Thread Don Dutile
On 1/7/21 7:57 PM, Bjorn Helgaas wrote: [+cc Alex, Don] This patch does not actually *configure* the number of vectors, so the subject is not quite accurate. IIUC, this patch adds a sysfs file that can be used to configure the number of vectors. The subject should mention the sysfs connection.

Re: [PATCH 1/5] dt-bindings: net: renesas,etheravb: Add r8a779a0 support

2021-01-07 Thread Rob Herring
On Sun, 27 Dec 2020 14:04:02 +0100, Wolfram Sang wrote: > Document the compatible value for the RAVB block in the Renesas R-Car > V3U (R8A779A0) SoC. This variant has no stream buffer, so we only need > to add the new compatible. > > Signed-off-by: Wolfram Sang > --- > Documentation/devicetree/b

Re: [pull request][net 00/11] mlx5 fixes 2021-01-07

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 12:28:34 -0800 Saeed Mahameed wrote: > From: Saeed Mahameed > > Hi Dave, Jakub, > > This series provides some fixes to mlx5 driver. > Please pull and let me know if there is any problem. Pulled, thanks!

Re: [PATCH v5 10/11] dt-bindings: usb: convert mediatek, mtu3.txt to YAML schema

2021-01-07 Thread Rob Herring
On Fri, 25 Dec 2020 15:52:57 +0800, Chunfeng Yun wrote: > Convert mediatek,mtu3.txt to YAML schema mediatek,mtu3.yaml > > Signed-off-by: Chunfeng Yun > --- > v5: changes suggested by Rob > 1. remove unnecessary maxItems > 2. define all phys supported > > v4: > 1. refer to usb-drd.yaml inss

Re: [net 05/11] net/mlx5e: Fix SWP offsets when vlan inserted by driver

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 12:28:39 -0800 Saeed Mahameed wrote: > + if (skb_vlan_tag_present(skb) && ihs) Double space.

Re: [net 04/11] net/mlx5e: CT: Use per flow counter when CT flow accounting is enabled

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 12:28:38 -0800 Saeed Mahameed wrote: > + int ret; > + > + counter = kzalloc(sizeof(*counter), GFP_KERNEL); > + if (!counter) > + return ERR_PTR(-ENOMEM); > + > + counter->is_shared = false; > + counter->counter = mlx5_fc_create(ct_priv->dev, true)

Re: [PATCH v5 09/11] dt-bindings: usb: convert mediatek, mtk-xhci.txt to YAML schema

2021-01-07 Thread Rob Herring
On Fri, 25 Dec 2020 15:52:56 +0800, Chunfeng Yun wrote: > Convert mediatek,mtk-xhci.txt to YAML schema mediatek,mtk-xhci.yaml > > Signed-off-by: Chunfeng Yun > --- > v5: changes suggested by Rob > 1. refer to usb-xhci.yaml instead of usb-hcd.yaml > 2. remove unnecessary maxItems > 3. add it

Re: [PATCH v5 01/11] dt-bindings: usb: convert usb-device.txt to YAML schema

2021-01-07 Thread Rob Herring
On Fri, 25 Dec 2020 15:52:48 +0800, Chunfeng Yun wrote: > Convert usb-device.txt to YAML schema usb-device.yaml > > Signed-off-by: Chunfeng Yun > --- > v5: changes suggested by Rob: > 1. limit the pattern length > 2. remove properties description for hard wired USB devices in usb-hcd.yaml >

Re: MDIO over I2C driver driver probe dependency issue

2021-01-07 Thread Florian Fainelli
On 1/7/2021 6:22 PM, Brian Silverman wrote: > I've written a very small generic MDIO driver that uses the existing > mdio-i2c.c library in drivers/net/phy.  The driver allows > communication to the PHY's MDIO interface as using I2C, as supported by > PHYs like the BCM54616S.  This is working on

Re: [PATCH] net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 12:00:44 -0800 Florian Fainelli wrote: > On 1/7/21 11:58 AM, Aleksander Jan Bajkowski wrote: > > Exclude RMII from modes that report 1 GbE support. Reduced MII supports > > up to 100 MbE. > > > > Fixes: 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") Please make

Re: [PATCH net 0/3] s390/qeth: fixes 2021-01-07

2021-01-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 7 Jan 2021 18:24:39 +0100 you wrote: > Hi Dave & Jakub, > > please apply the following patch series to netdev's net tree. > > This brings two locking fixes for the device control path. > Also one fix for a path where

[PATCH net-next] net/bridge: fix misspellings using codespell tool

2021-01-07 Thread menglong8 . dong
From: Menglong Dong Some typos are found out by codespell tool: $ codespell ./net/bridge/ ./net/bridge/br_stp.c:604: permanant ==> permanent ./net/bridge/br_stp.c:605: persistance ==> persistence ./net/bridge/br.c:125: underlaying ==> underlying ./net/bridge/br_input.c:43: modue ==> mode ./n

Re: [PATCH net-next v4] GTP: add support for flow based tunneling API

2021-01-07 Thread Jakub Kicinski
On Tue, 5 Jan 2021 20:45:05 -0800 Pravin B Shelar wrote: > Following patch add support for LWT flow based tunneling API > to send and recv GTP tunnel packet over tunnel metadata API. > This would allow this device integration with OVS or eBPF using > flow based tunneling APIs. > > Signed-off-by:

Re: [PATCH net 0/4] nexthop: Various fixes

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 16:48:20 +0200 Ido Schimmel wrote: > From: Ido Schimmel > > This series contains various fixes for the nexthop code. The bugs were > uncovered during the development of resilient nexthop groups. > > Patches #1-#2 fix the error path of nexthop_create_group(). I was not > able

Re: [PATCH net] net: ipa: modem: add missing SET_NETDEV_DEV() for proper sysfs links

2021-01-07 Thread Jakub Kicinski
On Wed, 6 Jan 2021 11:07:55 +0100 Stephan Gerhold wrote: > At the moment it is quite hard to identify the network interface > provided by IPA in userspace components: The network interface is > created as virtual device, without any link to the IPA device. > The interface name ("rmnet_ipa%d") is t

Re: [PATCH] octeontx2-af: fix memory leak of lmac and lmac->name

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 22:31:30 +0530 Sunil Kovvuri wrote: > On Thu, Jan 7, 2021 at 6:11 PM Colin King wrote: > > > > From: Colin Ian King > > > > Currently the error return paths don't kfree lmac and lmac->name > > leading to some memory leaks. Fix this by adding two error return > > paths that kfr

[PATCH net v3] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-07 Thread Dongseok Yi
skbs in fraglist could be shared by a BPF filter loaded at TC. If TC writes, it will call skb_ensure_writable -> pskb_expand_head to create a private linear section for the head_skb. And then call skb_clone_fraglist -> skb_get on each skb in the fraglist. skb_segment_list overwrites part of the sk

Re: [PATCH net 2/2] net: ipa: re-enable NAPI before enabling interrupt

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 15:43:25 -0600 Alex Elder wrote: > @@ -743,21 +743,21 @@ static void gsi_channel_freeze(struct gsi_channel > *channel) > set_bit(GSI_CHANNEL_FLAG_STOPPING, channel->flags); > smp_mb__after_atomic(); /* Ensure gsi_channel_poll() sees new value */ > > - napi_dis

Re: [PATCH] neighbour: Disregard DEAD dst in neigh_update

2021-01-07 Thread Your Real Name
On Tue, Jan 05, 2021 at 04:05:21PM -0800, David Miller wrote: > > > From: Tong Zhu > Date: Wed, 30 Dec 2020 17:54:23 -0500 > > > In 4.x kernel a dst in DST_OBSOLETE_DEAD state is associated > > with loopback net_device and leads to loopback neighbour. It > > leads to an ethernet header with al

Re: [PATCH v4 02/24] dt-bindings: introduce silabs,wfx.yaml

2021-01-07 Thread Rob Herring
On Wed, Dec 23, 2020 at 04:39:03PM +0100, Jerome Pouiller wrote: > From: Jérôme Pouiller Commit message? checkpatch.pl reports trailing whitespace errors. > > Signed-off-by: Jérôme Pouiller > --- > .../bindings/net/wireless/silabs,wfx.yaml | 133 ++ > 1 file changed, 133

Re: [RESEND PATCH net-next v1 00/13] Generic zcopy_* functions

2021-01-07 Thread Jakub Kicinski
On Wed, 6 Jan 2021 14:18:28 -0800 Jonathan Lemon wrote: > This is set of cleanup patches for zerocopy which are intended > to allow a introduction of a different zerocopy implementation. > > The top level API will use the skb_zcopy_*() functions, while > the current TCP specific zerocopy ends up u

Re: [RESEND PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

2021-01-07 Thread Xu Yilun
On Thu, Jan 07, 2021 at 03:51:38PM +0100, Andrew Lunn wrote: > On Thu, Jan 07, 2021 at 10:26:12AM +0100, Greg KH wrote: > > On Thu, Jan 07, 2021 at 02:07:08PM +0800, Xu Yilun wrote: > > > This driver supports the ethernet retimers (C827) for the Intel PAC > > > (Programmable Acceleration Card) N300

Re: [RESEND PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

2021-01-07 Thread Xu Yilun
On Thu, Jan 07, 2021 at 10:26:12AM +0100, Greg KH wrote: > On Thu, Jan 07, 2021 at 02:07:08PM +0800, Xu Yilun wrote: > > This driver supports the ethernet retimers (C827) for the Intel PAC > > (Programmable Acceleration Card) N3000, which is a FPGA based Smart NIC. > > > > C827 is an Intel(R) Ethe

Re: [PATCH net 0/7] Bug fixes for chtls driver

2021-01-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Wed, 6 Jan 2021 09:59:05 +0530 you wrote: > patch 1: Fix hardware tid leak. > patch 2: Remove invalid set_tcb call. > patch 3: Fix panic when route to peer not configured. > patch 4: Avoid unnecessary freeing of oreq pointe

Re: [PATCH net-next repost v2 2/7] ethtool: Get link mode in use instead of speed and duplex parameters

2021-01-07 Thread Andrew Lunn
> > diff --git a/Documentation/networking/ethtool-netlink.rst > > b/Documentation/networking/ethtool-netlink.rst > > index 05073482db05..c21e71e0c0e8 100644 > > --- a/Documentation/networking/ethtool-netlink.rst > > +++ b/Documentation/networking/ethtool-netlink.rst > > @@ -406,6 +406,7 @@ Kernel

Re: [PATCH bpf-next v4 3/3] bpf: remove extra lock_sock for TCP_ZEROCOPY_RECEIVE

2021-01-07 Thread Martin KaFai Lau
On Thu, Jan 07, 2021 at 10:43:05AM -0800, Stanislav Fomichev wrote: > Add custom implementation of getsockopt hook for TCP_ZEROCOPY_RECEIVE. > We skip generic hooks for TCP_ZEROCOPY_RECEIVE and have a custom > call in do_tcp_getsockopt using the on-stack data. This removes > 2% overhead for locking

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-07 Thread Bjorn Helgaas
[+cc Alex, Don] This patch does not actually *configure* the number of vectors, so the subject is not quite accurate. IIUC, this patch adds a sysfs file that can be used to configure the number of vectors. The subject should mention the sysfs connection. On Sun, Jan 03, 2021 at 10:24:37AM +0200

Re: [PATCH v6] vhost_net: avoid tx queue stuck when sendmsg fails

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 17:49:45 +0800 wangyunjian wrote: > From: Yunjian Wang > > Currently the driver doesn't drop a packet which can't be sent by tun > (e.g bad packet). In this case, the driver will always process the > same packet lead to the tx queue stuck. > > To fix this issue: > 1. in the ca

Re: [PATCH v3 net-next 08/12] net: make dev_get_stats return void

2021-01-07 Thread Rong Chen
/0day-ci/linux/commits/Vladimir-Oltean/Make-ndo_get_stats64-sleepable/20210107-175746 base:https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3db1a3fa98808aa90f95ec3e0fa2fc7abf28f5c9 config: x86_64-randconfig-a005-20210107 (attached as .config) Best Regards, Rong Chen

Re: [PATCH net-next v1 1/2] net: core: count drops from GRO

2021-01-07 Thread Shannon Nelson
On 1/6/21 1:55 PM, Jesse Brandeburg wrote: When drivers call the various receive upcalls to receive an skb to the stack, sometimes that stack can drop the packet. The good news is that the return code is given to all the drivers of NET_RX_DROP or GRO_DROP. The bad news is that no drivers except t

Re: [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-07 Thread Pali Rohár
On Thursday 07 January 2021 21:21:16 Marek Behún wrote: > On Thu, 7 Jan 2021 19:45:49 + > Russell King - ARM Linux admin wrote: > > > I think you're not reading the code very well. It checks for bytes at > > offset 1..blocksize-1, blocksize+1..2*blocksize-1, etc are zero. It > > does _not_ ch

Re: [PATCH net-next repost v2 7/7] net: selftests: Add lanes setting test

2021-01-07 Thread Jakub Kicinski
On Wed, 6 Jan 2021 15:06:22 +0200 Danielle Ratson wrote: > .../selftests/net/forwarding/ethtool_lanes.sh | 186 ++ > .../selftests/net/forwarding/ethtool_lib.sh | 34 > tools/testing/selftests/net/forwarding/lib.sh | 28 +++ Why is ethtool_lanes test getting added to net/

Re: [PATCH net-next repost v2 2/7] ethtool: Get link mode in use instead of speed and duplex parameters

2021-01-07 Thread Jakub Kicinski
On Wed, 6 Jan 2021 15:06:17 +0200 Danielle Ratson wrote: > From: Danielle Ratson > > Currently, when user space queries the link's parameters, as speed and > duplex, each parameter is passed from the driver to ethtool. > > Instead, get the link mode bit in use, and derive each of the parameters

Re: [PATCH net-next repost v2 1/7] ethtool: Extend link modes settings uAPI with lanes

2021-01-07 Thread Jakub Kicinski
On Wed, 6 Jan 2021 15:06:16 +0200 Danielle Ratson wrote: > From: Danielle Ratson > > Currently, when auto negotiation is on, the user can advertise all the > linkmodes which correspond to a specific speed, but does not have a > similar selector for the number of lanes. This is significant when a

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-07 Thread Corey Costello
Get me off this fucking list ffs. > On Jan 7, 2021, at 2:06 PM, Jeffrey Walton wrote: > > On Thu, Jan 7, 2021 at 2:03 PM Jason A. Donenfeld wrote: >> >> On Thu, Jan 7, 2021 at 1:22 PM Dmitry Vyukov wrote: >>> >>> On Mon, Dec 21, 2020 at 12:23 PM Jason A. Donenfeld wrote: ... >>

linux-next: manual merge of the net-next tree with the net tree

2021-01-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/can/m_can/tcan4x5x-core.c between commit: aee2b3ccc8a6 ("can: tcan4x5x: fix bittiming const, use common bittiming from m_can driver") from the net tree and commit: 7813887ea972 ("can: tcan4x5x: rename

Re: [PATCH net-next 4/4] net: ipa: support COMPILE_TEST

2021-01-07 Thread Bjorn Andersson
On Thu 07 Jan 17:34 CST 2021, Alex Elder wrote: > Arrange for the IPA driver to be built when COMPILE_TEST is enabled. > > Update the help text to reflect that we support two Qualcomm SoCs. > > Suggested-by: Jakub Kicinski > Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson Regards, Bj

[PATCH v4 net-next 06/18] parisc/led: reindent the code that gathers device statistics

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean The standard in the Linux kernel is to use one tab character per indentation level. Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-par...@vger.kernel.org Signed-off-by: Vladimir Oltean --- Changes in v4: None. Changes in v3: None. Changes in v2: None. drivers/

[PATCH v4 net-next 15/18] net: net_failover: ensure .ndo_get_stats64 can sleep

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean The failover framework sets up a virtio_net interface [ when it has the VIRTIO_NET_F_STANDBY feature ] and a VF interface, having the same MAC address, in a standby/active relationship. When the active VF is unplugged, the standby virtio_net temporarily kicks in. The failov

[PATCH v4 net-next 18/18] net: remove obsolete comments about ndo_get_stats64 context from eth drivers

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean Now that we have a good summary in Documentation/networking/netdevices.rst, these comments serve no purpose and are actually distracting/confusing. Signed-off-by: Vladimir Oltean --- Changes in v4: None. Changes in v3: None. Changes in v2: None. drivers/net/ethernet/ci

[PATCH v4 net-next 16/18] net: bonding: ensure .ndo_get_stats64 can sleep

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean There is an effort to convert .ndo_get_stats64 to sleepable context, and for that to work, we need to prevent callers of dev_get_stats from using atomic locking. The bonding driver retrieves its statistics recursively from its lower interfaces, with additional care to only

[PATCH v4 net-next 07/18] parisc/led: hold the netdev lists lock when retrieving device statistics

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean In the effort of making .ndo_get_stats64 be able to sleep, we need to ensure the callers of dev_get_stats do not use atomic context. The LED driver for HP-PARISC workstations uses a workqueue to periodically check for updates in network interface statistics, and flicker whe

[PATCH v4 net-next 17/18] net: mark ndo_get_stats64 as being able to sleep

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean Now that all callers have been converted to not use atomic context when calling dev_get_stats, it is time to update the documentation and put a notice in the function that it expects process context. Signed-off-by: Vladimir Oltean --- Changes in v4: None. Changes in v3: N

[PATCH v4 net-next 11/18] net: openvswitch: propagate errors from dev_get_stats

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean The dev_get_stats function can now return an error code, so the code that retrieves vport statistics and sends them through netlink needs to propagate that error code. Remove the drastic BUG_ON checks. Signed-off-by: Vladimir Oltean --- Changes in v4: Patch is new (Eric's

[PATCH v4 net-next 13/18] net: terminate errors from dev_get_stats

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean dev_get_stats can now return errors. Some call sites are coming from a context that returns void (ethtool stats, workqueue context). So since we can't report to the upper layer, do the next best thing: shout. Signed-off-by: Vladimir Oltean --- Changes in v4: Patch is new (

[PATCH v4 net-next 12/18] net: propagate errors from dev_get_stats

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean dev_get_stats can now return error codes. Take the remaining call sites where those errors can be propagated, which are all trivial, and convert them to look at that error code and stop processing. The effects of simulating a kernel error (returning -EOPNOTSUPP) upon existi

[PATCH v4 net-next 09/18] net: allow ndo_get_stats64 to return an int error code

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean Some drivers need to do special tricks to comply with the new policy of ndo_get_stats64 being sleepable. For example, the bonding driver, which derives its stats from its lower interfaces, must recurse with dev_get_stats into its lowers with no locks held. But for that to wo

[PATCH v4 net-next 10/18] scsi: fcoe: propagate errors from dev_get_stats

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean The FCoE callback for the Link Error Status Block retrieves the FCS error count using dev_get_stats. This function can now return errors. Propagate these all the way to the sysfs device attributes. Signed-off-by: Vladimir Oltean --- Changes in v4: Patch is new (Eric's sugg

[PATCH v4 net-next 14/18] net: openvswitch: ensure dev_get_stats can sleep

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean There is an effort to convert .ndo_get_stats64 to sleepable context, and for that to work, we need to prevent callers of dev_get_stats from using atomic locking. The OVS vport driver calls ovs_vport_get_stats from ovs_vport_cmd_fill_info, a function with 7 callers: 5 under

[PATCH v4 net-next 08/18] net: make dev_get_stats return void

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean After commit 28172739f0a2 ("net: fix 64 bit counters on 32 bit arches"), dev_get_stats got an additional argument for storage of statistics. At this point, dev_get_stats could return either the passed "storage" argument, or the output of .ndo_get_stats64. Then commit caf586

[PATCH v4 net-next 02/18] net: introduce a mutex for the netns interface lists

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean Currently, any writer that wants to alter the lists of network interfaces (either the plain list net->dev_base_head, or the hash tables net->dev_index_head and net->dev_name_head) can keep other writers at bay using the RTNL mutex. However, the RTNL mutex has become a very

[PATCH v4 net-next 05/18] s390/appldata_net_sum: hold the netdev lists lock when retrieving device statistics

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean In the effort of making .ndo_get_stats64 be able to sleep, we need to ensure the callers of dev_get_stats do not use atomic context. In the case of the appldata driver, an RCU read-side critical section is used to ensure the integrity of the list of network interfaces, beca

[PATCH v4 net-next 03/18] net: procfs: hold netif_lists_lock when retrieving device statistics

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean In the effort of making .ndo_get_stats64 be able to sleep, we need to ensure the callers of dev_get_stats do not use atomic context. The /proc/net/dev file uses an RCU read-side critical section to ensure the integrity of the list of network interfaces, because it iterates

[PATCH v4 net-next 04/18] net: sysfs: don't hold dev_base_lock while retrieving device statistics

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean In the effort of making .ndo_get_stats64 be able to sleep, we need to ensure the callers of dev_get_stats do not use atomic context. I need to preface this by saying that I have no idea why netstat_show takes the dev_base_lock rwlock. Two things can be observed: (a) it does

[PATCH v4 net-next 01/18] net: mark dev_base_lock for deprecation

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean There is a movement to eliminate the usage of dev_base_lock, which exists since as far as I could track the kernel history down (the "7a2deb329241 Import changeset" commit from the bitkeeper branch). The dev_base_lock approach has multiple issues: - It is global and not per

[PATCH v4 net-next 00/18] Make .ndo_get_stats64 sleepable

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean There is a desire to standardize the counters that have previously been reported through ethtool statistics into something that can be more uniformly queried from user space. The ndo_get_stats64 are a good candidate to keep standardized counters, as well as add new ones (lik

5.10.4+ hang with 'rmmod nf_conntrack'

2021-01-07 Thread Ben Greear
I noticed my system has a hung process trying to 'rmmod nf_conntrack'. I've generally been doing the script that calls rmmod forever, but only extensively tested on 5.4 kernel and earlier. If anyone has any ideas, please let me know. This is from 'sysrq t'. I don't see any hung-task splats in

Re: [PATCH v4 0/5] dwmac-meson8b: picosecond precision RX delay support

2021-01-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 6 Jan 2021 14:42:46 +0100 you wrote: > Hello, > > with the help of Jianxin Pan (many thanks!) the meaning of the "new" > PRG_ETH1[19:16] register bits on Amlogic Meson G12A, G12B and SM1 SoCs > are finally known.

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-07 Thread Jarod Wilson
On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >This comes from an end-user request, where they're running multiple VMs on > >hosts with bonded interfaces connected to some interest switch topologies, > >where 802.3ad isn't an option. They're currently run

Re: pull-request: bpf 2021-01-07

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 14:15:55 -0800 Alexei Starovoitov wrote: > Hi David, hi Jakub, > > The following pull-request contains BPF updates for your *net* tree. > > We've added 4 non-merge commits during the last 10 day(s) which contain > a total of 4 files changed, 14 insertions(+), 7 deletions(-). >

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-07 Thread Jarod Wilson
On Mon, Dec 28, 2020 at 11:11:45AM +0100, Jiri Pirko wrote: > Fri, Dec 18, 2020 at 08:30:33PM CET, ja...@redhat.com wrote: > >This comes from an end-user request, where they're running multiple VMs on > >hosts with bonded interfaces connected to some interest switch topologies, > >where 802.3ad isn

Re: [PATCH v2 net-next 0/4] Reduce coupling between DSA and Broadcom SYSTEMPORT driver

2021-01-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 7 Jan 2021 03:23:59 +0200 you wrote: > From: Vladimir Oltean > > Upon a quick inspection, it seems that there is some code in the generic > DSA layer that is somehow specific to the Broadcom SYSTEMPORT driver. >

  1   2   3   4   >