> > diff --git a/Documentation/networking/ethtool-netlink.rst 
> > b/Documentation/networking/ethtool-netlink.rst
> > index 05073482db05..c21e71e0c0e8 100644
> > --- a/Documentation/networking/ethtool-netlink.rst
> > +++ b/Documentation/networking/ethtool-netlink.rst
> > @@ -406,6 +406,7 @@ Kernel response contents:
> >    ``ETHTOOL_A_LINKMODES_PEER``                bitset  partner link modes
> >    ``ETHTOOL_A_LINKMODES_SPEED``               u32     link speed (Mb/s)
> >    ``ETHTOOL_A_LINKMODES_DUPLEX``              u8      duplex mode
> > +  ``ETHTOOL_A_LINKMODES_LINK_MODE``           u8      link mode
> 
> Are there other places in the uapi we already limit ourselves to 
> u8 / max 255? Otherwise u32 is better, the nlattr will be padded,
> anyway.

Only allowing 255 values might be too limiting. We already have 91 of
them. It was initially thought that 32 would be enough, and fixing
that limitation was a lot of work.

     Andrew

Reply via email to