> On Wed, 6 Jan 2021 18:56:23 +0800 (GMT+08:00) dinghao@zju.edu.cn
> wrote:
> > > I used this one for a test:
> > >
> > > https://patchwork.kernel.org/project/netdevbpf/patch/1609312994-121032-1-git-send-email-abaci-bug...@linux.alibaba.com/
> > >
> > > I'm not getting the Fixes tag when I do
Hello Florian,
On Wed, Jan 06, 2021 at 00:15:23 +0100, Florian Westphal wrote:
> Force refragmentation as per original sizes unconditionally so ip tunnel
> will encapsulate the fragments instead.
[...]
> diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
> index 89fff5f59eea..2ed0b01f72f0 1
On Tue Jan 05 2021, Randy Dunlap wrote:
> Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y.
> This limits the latter to =m when LEDS_CLASS=m.
>
> microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function
> `hellcreek_ptp_setup':
> (.text+0xf80): undefined re
map_direct_mr() assumed that the number of scatter/gather entries
returned by dma_map_sg_attrs() was equal to the number of segments in
the sgl list. This led to wrong population of the mkey object. Fix this
by properly referring to the returned value.
The hardware expects each MTT entry to contai
On Thu Jan 07 2021, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> The call path of a switchdev VLAN addition to the bridge looks something
> like this today:
>
> nbp_vlan_init
> | __br_vlan_set_default_pvid
> | | |
> | |br_afspec
Since moving get_rate() and get_size() from tc to lib, on some
systems we fail to link because of missing math lib.
Move the functions that require math lib to their own c file
and add -lm to dcb that now use those functions.
../lib/libutil.a(utils.o): In function `get_rate':
utils.c:(.text+0x10dc
On 2021-01-06 4:24 PM, Petr Machata wrote:
Roi Dayan writes:
On 2021-01-06 3:16 PM, Petr Machata wrote:
Regarding the publishing, the _jw reference can be changed to a call to
is_json_context(), which does the same thing. Then _jw can stay private
in json_print.c.
Exposing an _IS_JSON_CON
On Wed, Aug 5, 2020 at 7:24 PM Kai-Heng Feng
wrote:
>
> Hi Tony,
>
> > On Aug 5, 2020, at 19:18, Tony Chuang wrote:
> >
> >> 8821CE with RFE 2 isn't supported:
> >> [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported
> >> [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efus
This driver supports the ethernet retimers (C827) for the Intel PAC
(Programmable Acceleration Card) N3000, which is a FPGA based Smart NIC.
C827 is an Intel(R) Ethernet serdes transceiver chip that supports
up to 100G transfer. On Intel PAC N3000 there are 2 C827 chips
managed by the Intel MAX 10
I resend this patchset to loop in networking developers for comments. This
is the previous thread. I'll fix other comments when I have a v2.
https://lore.kernel.org/lkml/x%2fv9hvxyluot9...@kroah.com/
The patchset is for the retimers connected to Intel MAX 10 BMC on Intel
PAC (Programmable Accele
The patch specifies the 2 retimer sub devices and their resources in the
parent driver's mfd_cell. It also adds the register definition of the
retimer sub devices.
There are 2 ethernet retimer chips (C827) connected to the Intel MAX 10
BMC. They are managed by the BMC firmware, and host could quer
Check return value from ret_val to make error check actually work.
Fixes: 4eb8080143a9 ("igc: Add setup link functionality")
Signed-off-by: Kevin Lo
---
diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c
b/drivers/net/ethernet/intel/igc/igc_mac.c
index 09cd0ec7ee87..67b8ffd21d8a 100644
--- a/
On Thu, Jan 07, 2021 at 12:15:53PM +0800, Jason Wang wrote:
>
> On 2021/1/6 下午5:05, Eli Cohen wrote:
> > map_direct_mr() assumed that the number of scatter/gather entries
> > returned by dma_map_sg_attrs() was equal to the number of segments in
> > the sgl list. This led to wrong population of the
On Thu, Jan 7, 2021 at 12:11 AM Baptiste Lepers
wrote:
>
> reuse->socks[] is modified concurrently by reuseport_add_sock. To
> prevent reading values that have not been fully initialized, only read
> the array up until the last known safe index instead of incorrectly
> re-reading the last index of
The call state may be changed at any time by the data-ready routine in
response to received packets, so if the call state is to be read and acted
upon several times in a function, READ_ONCE() must be used unless the call
state lock is held.
Signed-off-by: Baptiste Lepers
---
net/rxrpc/input.c |
reuse->socks[] is modified concurrently by reuseport_add_sock. To
prevent reading values that have not been fully initialized, only read
the array up until the last known safe index instead of incorrectly
re-reading the last index of the array.
Fixes: acdcecc61285f ("udp: correct reuseport selecti
Thanks. I will submit a patch.
Baptiste.
On Thu, Jan 7, 2021 at 3:57 PM Willem de Bruijn
wrote:
>
> On Wed, Jan 6, 2021 at 10:54 PM Baptiste Lepers
> wrote:
> >
> > Hello,
> >
> > While reading the code of net/core/sock_reuseport.c, I think I found a
> > possible race in reuseport_select_sock.
On Wed, Jan 6, 2021 at 10:54 PM Baptiste Lepers
wrote:
>
> Hello,
>
> While reading the code of net/core/sock_reuseport.c, I think I found a
> possible race in reuseport_select_sock. The current code has the
> following pattern:
>
>socks = READ_ONCE(reuse->num_socks);
>smp_rmb(); // paired
On 2021/1/6 下午5:05, Eli Cohen wrote:
map_direct_mr() assumed that the number of scatter/gather entries
returned by dma_map_sg_attrs() was equal to the number of segments in
the sgl list. This led to wrong population of the mkey object. Fix this
by properly referring to the returned value.
In a
Hello,
While reading the code of net/core/sock_reuseport.c, I think I found a
possible race in reuseport_select_sock. The current code has the
following pattern:
socks = READ_ONCE(reuse->num_socks);
smp_rmb(); // paired with reuseport_add_sock to make sure
reuse->socks[i < num_socks] are in
The page recycle code, incorrectly, relied on that a page fragment
could not be freed inside xdp_do_redirect(). This assumption leads to
that page fragments that are used by the stack/XDP redirect can be
reused and overwritten.
To avoid this, store the page count prior invoking xdp_do_redirect().
> From: Michael S. Tsirkin
> Sent: Tuesday, January 5, 2021 6:53 PM
>
> On Tue, Jan 05, 2021 at 12:30:15PM +, Parav Pandit wrote:
> >
> >
> > > From: Michael S. Tsirkin
> > > Sent: Tuesday, January 5, 2021 5:45 PM
> > >
> > > On Tue, Jan 05, 2021 at 12:02:33PM +, Parav Pandit wrote:
>
From: Hoang Le
The buffer list can have zero skb as following path:
tipc_named_node_up()->tipc_node_xmit()->tipc_link_xmit(), so
we need to check the list before casting an &sk_buff.
Fault report:
[] tipc: Bulk publication failure
[] general protection fault, probably for non-canonical [#1] PR
2.
>
> Tune markup and formatting for better presentation in the HTML view.
>
> Signed-off-by: Lukas Bulwahn
> ---
> v1 -> v2: minor stylistic tuning as suggested by Randy
>
> applies cleanly on current master (v5.11-rc2) and next-20210106
>
> George, please ack.
On Wed, Dec 09, 2020 at 01:20:51PM +0100, Oleksij Rempel wrote:
> Remove board specific PHY fixup introduced by commit:
>
> | 709bc0657fe6f9f5 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup
> init")
>
> This fixup addresses boards with a specific configuration: a KSZ8081RNA
> PHY with a
在 2020/12/19 8:46, Jakub Kicinski 写道:
> On Fri, 18 Dec 2020 14:11:16 +0800 lyl wrote:
>> Remove tcp_low_latency, since it is not functional After commit
>> e7942d0633c4 (tcp: remove prequeue support)
>>
>> Signed-off-by: lyl
>
> I don't think we can remove sysctls, even if they no longer contro
The print format of this parameter does not match, because it is defined
as int type, so modify the matching format of this parameter to %d format.
Signed-off-by: Jiapeng Zhong
Reported-by: Abaci
---
net/ipv6/proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/pr
With NOPs padding, x64 jit now can handle the jump cases like
bpf_fill_maxinsns11().
Signed-off-by: Gary Lin
---
lib/test_bpf.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/lib/test_bpf.c b/lib/test_bpf.c
index ca7d635bccd9..272a9fd143ab 100644
--- a/lib/test_bpf.c
+
There are two tests added into verifier's jit tests to trigger x64
jit jump padding. The first test can be represented as the following
assembly code:
1: bpf_call bpf_get_prandom_u32
2: if r0 == 0 goto pc+128
3: if r0 == 1 goto pc+128
...
129: if r0 == 127 goto pc+12
The x64 bpf jit expects bpf images converge within the given passes, but
it could fail to do so with some corner cases. For example:
l0: ja 40
l1: ja 40
[... repeated ja 40 ]
l39:ja 40
l40:ret #0
This bpf program contains 40 "ja 40" instructions w
This patch series implements jump padding to x64 jit to cover some
corner cases that used to consume more than 20 passes and caused
failure.
v2:
- Simplify the sample code in the commit description and provide the
jit code
- Check the expected padding bytes with WARN_ONCE
- Move the 'pad
> + /* hwmon interface needs to access 16bit registers in atomic way to
> + * guarantee coherency of the diagnostic monitoring data. If it is not
> + * possible to guarantee coherency because EEPROM is broken in such way
> + * that does not support atomic 16bit read operation the
On Wed, 6 Jan 2021 17:03:48 -0800
Linus Torvalds wrote:
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -366,7 +366,7 @@ static inline void skb_frag_size_sub(skb_frag_t *frag,
> int delta)
> static inline bool skb_frag_must_loop(struct page *p)
> {
> #if defined(CONFIG_HIGH
On Wed, 6 Jan 2021 17:03:48 -0800 Linus Torvalds wrote:
> I wonder whether there is other code that "knows" about kmap() only
> affecting PageHighmem() pages thing that is no longer true.
>
> Looking at some other code, skb_gro_reset_offset() looks suspiciously
> like it also thinks highmem pages
On Wed, Jan 06, 2021 at 02:45:56PM -0800, s...@google.com wrote:
> On 01/06, Martin KaFai Lau wrote:
> > On Tue, Jan 05, 2021 at 01:43:50PM -0800, Stanislav Fomichev wrote:
> > > Add custom implementation of getsockopt hook for TCP_ZEROCOPY_RECEIVE.
> > > We skip generic hooks for TCP_ZEROCOPY_RECE
From: Vladimir Oltean
This effectively reverts commit 60724d4bae14 ("net: dsa: Add support for
DSA specific notifiers"). The reason is that since commit 2f1e8ea726e9
("net: dsa: link interfaces with the DSA master to get rid of lockdep
warnings"), it appears that there is a generic way to achieve
From: Vladimir Oltean
Using the NETDEV_CHANGEUPPER notifications, drivers can be aware when
they are enslaved to e.g. a bridge by calling netif_is_bridge_master().
Export this helper from DSA to get the equivalent functionality of
determining whether the upper interface of a CHANGEUPPER notifier
From: Vladimir Oltean
The SYSTEMPORT driver maps each port of the embedded Broadcom DSA switch
port to a certain queue of the master Ethernet controller. For that it
currently uses a dedicated notifier infrastructure which was added in
commit 60724d4bae14 ("net: dsa: Add support for DSA specific
From: Vladimir Oltean
It is a bit strange to see something as specific as Broadcom SYSTEMPORT
bits in the main DSA include file. Move these away into a separate
header, and have the tagger and the SYSTEMPORT driver include them.
Signed-off-by: Vladimir Oltean
Acked-by: Florian Fainelli
---
Cha
From: Vladimir Oltean
Upon a quick inspection, it seems that there is some code in the generic
DSA layer that is somehow specific to the Broadcom SYSTEMPORT driver.
The challenge there is that the hardware integration is very tight between
the switch and the DSA master interface. However this doe
On Wed, 6 Jan 2021 21:41:24 +0100, Geert Uytterhoeven
wrote:
>> > Is that sufficient to keep it?
>>
>> for me it is. But now we probaly need some reverts then...
>
> Indeed. Fortunately not all of it, as some removals were TX4938-only.
These patches should not break RBTX4927:
net: tc35815: D
ping
On 2020/12/31 17:03, Guangbin Huang wrote:
To increase methods to dump more tm info, adds three debugfs commands
to dump tm info of nodes, priority and qset. And a new tm file of debugfs
is created for only dumping tm info.
Unlike previous debugfs commands, to dump each tm information, use
On Wed, 6 Jan 2021 17:03:48 -0800
Linus Torvalds wrote:
> (although I wonder how/why the heck you've enabled
> CC_OPTIMIZE_FOR_SIZE=y, which is what causes "memcpy()" to be done as
> that "rep movsb". I thought we disabled it because it's so bad on most
> cpus).
Why?
Because to test x86_32, I h
On Wed, Jan 6, 2021 at 3:01 PM Steven Rostedt wrote:
>
> I triggered the following crash on x86_32 by simply doing a:
>
> (ssh'ing into the box)
>
> # head -100 /tmp/output-file
>
> Where the /tmp/output-file was the output of a trace-cmd report.
> Even after rebooting and not running the tracin
skbs in fraglist could be shared by a BPF filter loaded at TC. It
triggers skb_ensure_writable -> pskb_expand_head ->
skb_clone_fraglist -> skb_get on each skb in the fraglist.
While tcpdump, sk_receive_queue of PF_PACKET has the original fraglist.
But the same fraglist is queued to PF_INET (or PF
On Wed, 06 Jan 2021 20:40:28 + Alexander Lobakin wrote:
> 'net_header' is not used outside of this function, so can be moved
> from BSS onto the stack.
> Declarations of one-element arrays are discouraged, and there's no
> need to store 'empty' in BSS. Simply allocate it from heap at init.
Are
On Wed, 6 Jan 2021 23:33:07 +0100 Andrew Lunn wrote:
> On Wed, Jan 06, 2021 at 10:09:15AM +0100, Rafał Miłecki wrote:
> > From: Rafał Miłecki
> >
> > Looking for an -EINVAL all over the dsa code could take hours for
> > inexperienced DSA users.
>
> Following this argument, you should add dev_e
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 5 Jan 2021 18:18:15 -0800 you wrote:
> Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y.
> This limits the latter to =m when LEDS_CLASS=m.
>
> microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcr
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 5 Jan 2021 20:25:31 -0800 you wrote:
> ptp_ines.c uses devm_platform_ioremap_resource(), which is only
> built/available when CONFIG_HAS_IOMEM is enabled.
> CONFIG_HAS_IOMEM is not enabled for arch/s390/, so builds on S
On 1/6/21 2:17 AM, Zhi Han wrote:
> It should be a typing error ('-' instead of '_'), as no mdio-bus.c but
> just mdio_bus.c exists.
>
> Just find it when inspecting these code. Tried to compile to test, but
> failed to construct an applicable .config file for that. Maybe someone
> can do that mor
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 5 Jan 2021 18:23:33 +0100 you wrote:
> The error message says that "Jumbo frames are not supported on XDP", but
> the code checks for mtu > MVNETA_MAX_RX_BUF_SIZE, not mtu > 1500.
>
> Fix this error message.
>
> Signe
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 5 Jan 2021 11:07:25 -0800 you wrote:
> .dellink does not get called after .newlink fails,
> bareudp_newlink() must undo what bareudp_configure()
> has done if bareudp_link_config() fails.
>
> v2: call bareudp_dellink()
7C0
> %7C637455042608753098%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&s
> data=uge6PX2NyAe%2BjRtvgOhR5xzN2ltBctZXeZwn0hoYco0%3D&reser
> ved=0
> git fetch --no-tags linux-review Long-Li/hv_netvsc-Check-VF-datapat
On Tue, 5 Jan 2021 15:43:21 +0200 Aya Levin wrote:
> There are cases where GSO segment's length exceeds the egress MTU.
Please name same for posterity.
Please widen the CC list.
> If so:
> - Consume the SKB and its segments.
> - Issue an ICMP packet with 'Packet Too Big' message containing th
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
On Wed, 6 Jan 2021 15:59:06 + you wrote:
> For older glibc ~2.17, #include'ing both linux/if.h and net/if.h
> fails due to complaints about redefinition of interface flags:
>
> CC net.o
> In file included from net.c:1
On Wed, Jan 6, 2021 at 2:10 AM Gilad Reti wrote:
>
> On Wed, Jan 6, 2021 at 8:09 AM Alexei Starovoitov
> wrote:
> >
> > On Tue, Jan 05, 2021 at 01:03:47PM -0800, Andrii Nakryiko wrote:
> > > > >
> > > > > - handling 32-bit vs 64-bit UAPI structs uniformly;
> > > >
> > > > what do you mean?
> >
On Wed, 6 Jan 2021 11:17:12 +0100 Zhi Han wrote:
> It should be a typing error ('-' instead of '_'), as no mdio-bus.c but
> just mdio_bus.c exists.
>
> Just find it when inspecting these code. Tried to compile to test, but
> failed to construct an applicable .config file for that. Maybe someone
>
Hi Johannes,
On Wed, 06 Jan 2021 23:46:45 +0100 Johannes Berg
wrote:
>
> > > Right, thanks. I believe I also fixed it in the patch I sent a few days
> > > ago that fixed the other documentation warning related to SAR that you
> > > reported.
> >
> > I don't think so :-( I did a htmldocs buil
On Tue, 5 Jan 2021 22:49:17 -0800 wangyingji...@126.com wrote:
> From: Yingjie Wang
>
> In rvu_mbox_handler_cgx_mac_addr_get()
> and rvu_mbox_handler_cgx_mac_addr_set(),
> the msg is expected only from PFs that are mapped to CGX LMACs.
> It should be checked before mapping,
> so we add the is_cg
On 06.01.2021 23:39, Andrew Lunn wrote:
> On Wed, Jan 06, 2021 at 02:03:40PM +0100, Heiner Kallweit wrote:
>> Switch to lockdep_assert_held(_once), similar to what is being done
>> in other subsystems. One advantage is that there's zero runtime
>> overhead if lockdep support isn't enabled.
>
> Hi
From: Vladimir Oltean
As of commit 457e20d65924 ("mlxsw: spectrum_switchdev: Avoid returning
errors in commit phase"), the mlxsw driver performs the VLAN object
offloading during the prepare phase. So conversion just seems to be a
matter of removing the code that was running in the commit phase.
From: Vladimir Oltean
Now that all port object notifiers were converted to be non-transactional,
we can remove the comments that say otherwise.
Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
Acked-by: Linus Walleij
Acked-by: Jiri Pirko
---
Changes in v3:
None.
Changes in v2:
N
From: Vladimir Oltean
Now that all users of struct switchdev_trans have been modified to do
without it, we can remove this structure and the two helpers to determine
the phase.
Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
Reviewed-by: Ido Schimmel
Acked-by: Linus Walleij
Acke
From: Vladimir Oltean
It should be the driver's business to logically separate its VLAN
offloading into a preparation and a commit phase, and some drivers don't
need / can't do this.
So remove the transactional shim from DSA and let drivers propagate
errors directly from the .port_vlan_add callb
On 06.01.2021 23:18, Alexander Duyck wrote:
> On Wed, Jan 6, 2021 at 5:32 AM Heiner Kallweit wrote:
>>
>> Use WARN here to avoid stopping the system. In addition print the addr
>> and mask values that triggered the warning.
>>
>> Signed-off-by: Heiner Kallweit
>> ---
>> drivers/net/ethernet/real
From: Vladimir Oltean
Remove the shim introduced in DSA for offloading the bridge ageing time
from switchdev, by first checking whether the ageing time is within the
range limits requested by the driver.
Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
Acked-by: Linus Walleij
Acke
From: Vladimir Oltean
For many drivers, the .port_mdb_prepare callback was not a good opportunity
to avoid any error condition, and they would suppress errors found during
the actual commit phase.
Where a logical separation between the prepare and the commit phase
existed, the function that used
From: Vladimir Oltean
Since the introduction of the switchdev API, port attributes were
transmitted to drivers for offloading using a two-step transactional
model, with a prepare phase that was supposed to catch all errors, and a
commit phase that was supposed to never fail.
Some classes of fail
From: Vladimir Oltean
After the removal of the transactional model inside
switchdev_port_obj_add_now, it has no added value and we can just call
switchdev_port_obj_notify directly, bypassing this function. Let's
delete it.
Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
Reviewed-b
mv88e6xxx apparently has a problem offloading VID 0, which the 8021q
module tries to install as part of commit ad1afb003939 ("vlan_dev: VLAN
0 should be treated as "no vlan tag" (802.1p packet)"). That mv88e6xxx
restriction seems to have been introduced by the "VTU GetNext VID-1
trick to retrieve a
From: Vladimir Oltean
Since the introduction of the switchdev API, port objects were
transmitted to drivers for offloading using a two-step transactional
model, with a prepare phase that was supposed to catch all errors, and a
commit phase that was supposed to never fail.
Some classes of failure
From: Vladimir Oltean
The call path of a switchdev VLAN addition to the bridge looks something
like this today:
nbp_vlan_init
| __br_vlan_set_default_pvid
| | |
| |br_afspec |
| || |
| |
From: Vladimir Oltean
Changes in v3:
- Resolved a build warning in mv88e6xxx and tested that it actually
works properly, which resulted in an extra patch (02/11.
- Addressed Ido's minor feedback in commit 10/11 relating to a comment.
Changes in v2:
- Got rid of the vid_begin -> vid_end range t
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Hello,
I've been trying out the latest CentOS 8 Stream kernel and found that I
get kernel panic (https://bugzilla.redhat.com/show_bug.cgi?id=1913481)
when trying to reboot the server. With debug kernel I've got following:
[ 531.818434]
===
Hi Stephen,
> > Right, thanks. I believe I also fixed it in the patch I sent a few days
> > ago that fixed the other documentation warning related to SAR that you
> > reported.
>
> I don't think so :-( I did a htmldocs build with your patch ([PATCH
> v2] cfg80211/mac80211: fix kernel-doc for SAR
Hi Johannes,
On Wed, 06 Jan 2021 23:23:42 +0100 Johannes Berg
wrote:
>
> On Thu, 2021-01-07 at 09:05 +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > Building Linus' tree, today's linux-next build (htmldocs) produced
> > this warning:
> >
> > include/net/mac80211.h:4200: warning: Function pa
On Wed, Jan 06, 2021 at 02:03:40PM +0100, Heiner Kallweit wrote:
> Switch to lockdep_assert_held(_once), similar to what is being done
> in other subsystems. One advantage is that there's zero runtime
> overhead if lockdep support isn't enabled.
Hi Heiner
I'm not sure we are bothered about perfor
On Wed, Jan 06, 2021 at 10:09:15AM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki
>
> Looking for an -EINVAL all over the dsa code could take hours for
> inexperienced DSA users.
Following this argument, you should add dev_err() by every -EINVAL.
> Signed-off-by: Rafał Miłecki
Reviewed-by:
Hi Stephen,
On Thu, 2021-01-07 at 09:05 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Building Linus' tree, today's linux-next build (htmldocs) produced
> this warning:
>
> include/net/mac80211.h:4200: warning: Function parameter or member
> 'set_sar_specs' not described in 'ieee80211_ops'
>
>
[resending to fix From: lines]
This is set of cleanup patches for zerocopy which are intended
to allow a introduction of a different zerocopy implementation.
The top level API will use the skb_zcopy_*() functions, while
the current TCP specific zerocopy ends up using msg_zerocopy_*()
calls.
Ther
On Wed, Jan 6, 2021 at 5:32 AM Heiner Kallweit wrote:
>
> Use WARN here to avoid stopping the system. In addition print the addr
> and mask values that triggered the warning.
>
> Signed-off-by: Heiner Kallweit
> ---
> drivers/net/ethernet/realtek/r8169_main.c | 2 +-
> 1 file changed, 1 insertio
The sock_zerocopy_put_abort function contains logic which is
specific to the current zerocopy implementation. Add a wrapper
which checks the callback and dispatches apppropriately.
Signed-off-by: Jonathan Lemon
---
include/linux/skbuff.h | 10 ++
net/core/skbuff.c | 12 +---
RX zerocopy fragment pages which are not allocated from the
system page pool require special handling. Give the callback
in skb_zcopy_clear() a chance to process them first.
Signed-off-by: Jonathan Lemon
---
net/core/skbuff.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
Replace sock_zerocopy_put with the generic skb_zcopy_put()
function. Pass 'true' as the success argument, as this
is identical to no change.
Signed-off-by: Jonathan Lemon
---
include/linux/skbuff.h | 7 ++-
net/core/skbuff.c | 9 +
net/ipv4/tcp.c | 2 +-
3 files changed
Replace direct assignments with skb_zcopy_init() for zerocopy
cases where a new skb is initialized, without changing the
reference counts.
Signed-off-by: Jonathan Lemon
---
drivers/net/tap.c | 3 +--
drivers/net/tun.c | 3 +--
drivers/vhost/net.c| 1 +
include/linux/skbuff.h | 9 ++
All 'struct ubuf_info' users should have a callback defined
as of commit 0a4a060bb204 ("sock: fix zerocopy_success regression
with msg_zerocopy").
Remove the dead code path to consume_skb(), which makes
assumptions about how the structure was allocated.
Signed-off-by: Jonathan Lemon
Acked-by: Wi
At Willem's suggestion, rename the sock_zerocopy_* functions
so that they match the MSG_ZEROCOPY flag, which makes it clear
they are specific to this zerocopy implementation.
Signed-off-by: Jonathan Lemon
Acked-by: Willem de Bruijn
---
include/linux/skbuff.h | 16
net/core/skbu
In preparation for expanded zerocopy (TX and RX), move
the zerocopy related bits out of tx_flags into their own
flag word.
Signed-off-by: Jonathan Lemon
---
drivers/net/tap.c | 3 +--
drivers/net/tun.c | 3 +--
drivers/net/xen-netback/interface.c | 4 +--
i
Add an optional skb parameter to the zerocopy callback parameter,
which is passed down from skb_zcopy_clear(). This gives access
to the original skb, which is needed for upcoming RX zero-copy
error handling.
Signed-off-by: Jonathan Lemon
---
drivers/net/tap.c | 2 +-
drivers/ne
Unlike the rest of the skb_zcopy_ functions, these routines
operate on a 'struct ubuf', not a skb. Remove the 'skb_'
prefix from the naming to make things clearer.
Suggested-by: Willem de Bruijn
Signed-off-by: Jonathan Lemon
---
include/linux/skbuff.h | 10 +-
net/core/skbuff.c |
skb_zcopy_abort() has no in-tree consumers, remove it.
Signed-off-by: Jonathan Lemon
Acked-by: Willem de Bruijn
---
include/linux/skbuff.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 333bcdc39635..3ca8d7c7b30c 100644
---
Currently, when an ubuf is attached to a new skb, the shared
flags word is initialized to a fixed value. Instead of doing
this, set the default flags in the ubuf, and have new skbs
inherit from this default.
This is needed when setting up different zerocopy types.
Signed-off-by: Jonathan Lemon
Before this change, the caller of sock_zerocopy_callback would
need to save the zerocopy status, decrement and check the refcount,
and then call the callback function - the callback was only invoked
when the refcount reached zero.
Now, the caller just passes the status into the callback function,
Rename the get routines for consistency.
Signed-off-by: Jonathan Lemon
---
include/linux/skbuff.h | 12 ++--
net/core/skbuff.c | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index a6c86839035b..5b8a53ab51fd 100
On 1/6/21 1:09 PM, David Howells wrote:
> Tom Rix wrote:
>
>> On 1/6/21 11:44 AM, David Howells wrote:
>>> Tom Rix wrote:
>>>
These two loops iterate over the same data, i believe returning here is all
that is needed.
>>> But if the first loop is made to support a new type, but the se
Hi all,
Building Linus' tree, today's linux-next build (htmldocs) produced
this warning:
include/net/mac80211.h:4200: warning: Function parameter or member
'set_sar_specs' not described in 'ieee80211_ops'
Introduced by commit
c534e093d865 ("mac80211: add ieee80211_set_sar_specs")
Sorry, I m
The driver was counting GRO drops but now that the stack
does it with the previous patch, the driver can drop
all the logic. The driver keeps the dev_dbg message in order
to do optional detailed tracing.
This mostly undoes commit a8fffd7ae9a5 ("ice: add useful statistics").
Signed-off-by: Jesse
Add some accounting for when the stack drops a packet
that a driver tried to indicate with a gro* call. This
helps users track where packets might have disappeared
to and will show up in the netdevice stats that already
exist.
After that, remove the driver specific workaround
that was added to do
When drivers call the various receive upcalls to receive an skb
to the stack, sometimes that stack can drop the packet. The good
news is that the return code is given to all the drivers of
NET_RX_DROP or GRO_DROP. The bad news is that no drivers except
the one "ice" driver that I changed, check the
On Wed, Jan 6, 2021 at 1:07 PM Jakub Kicinski wrote:
>
> It has been two releases since we added the common infra for UDP
> tunnel port offload, and we have not heard of any major issues.
> Remove the old direct driver NDOs completely, and perform minor
> simplifications in the tunnel drivers.
>
>
1 - 100 of 320 matches
Mail list logo
