Re: [PATCH 1/2] net: stmmac: retain PTP-clock at hwtstamp_set

2020-12-26 Thread kernel test robot
Hi Holger, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 3db1a3fa98808aa90f95ec3e0fa2fc7abf28f5c9] url: https://github.com/0day-ci/linux/commits/Holger-Assmann/net-stmmac-retain-PTP-clock-at-hwtstamp_set/20201216-194127 base:3db1a3fa98808aa90f95ec3e0f

"ethtool" missing "master-slave" args in "do_sset" function.[TEXT/PLAIN]

2020-12-26 Thread Bruce LIU
Hi Michal Kubecek and Network dev team, Good day! Hope you are doing well. This is Bruce from China, and please allow me to cc Rudy from Cisco Systems in China team. We are facing a weird behavior about "master-slave configuration" function in ethtool. Please correct me if I am wrong As

[PATCH] mac80211_hwsim: indicate support for 6GHz (11ax) Advertise 6GHz Capabilities and channels to mac80211.

2020-12-26 Thread Ramon Fontes
Requires a few fixups to account for missing capabilities to actually enable 6GHz channels Signed-off-by: Ramon Fontes --- drivers/net/wireless/mac80211_hwsim.c | 74 ++- 1 file changed, 73 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mac80211_hwsim.c

[Patch net] af_key: relax availability checks for skb size calculation

2020-12-26 Thread Cong Wang
From: Cong Wang xfrm_probe_algs() probes kernel crypto modules and changes the availability of struct xfrm_algo_desc. But there is a small window where ealg->available and aalg->available get changed between count_ah_combs()/count_esp_combs() and dump_ah_combs()/dump_esp_combs(), in this case we

[Patch net] erspan: fix version 1 check in gre_parse_header()

2020-12-26 Thread Cong Wang
From: Cong Wang Both version 0 and version 1 use ETH_P_ERSPAN, but version 0 does not have an erspan header. So the check in gre_parse_header() is wrong, we have to distinguish version 1 from version 0. We can just check the gre header length like is_erspan_type1(). Fixes: cb73ee40b1b3 ("net: i

Re: Fwd: Solidrun ClearFog Base and Huawei MA5671A SFP

2020-12-26 Thread Russell King - ARM Linux admin
Sorry, this will not work. The MA5671A modules are configured to use dying gasp on pin 7, and pin 7 is grounded on the Armada 388 Clearfog platforms, resulting in the module not booting. I'm sorry, I can't recommend a module; I don't use SFP GPON modules myself. On Sat, Dec 26, 2020 at 11:15:18PM

Solidrun ClearFog Base and Huawei MA5671A SFP

2020-12-26 Thread Hamza Mahfooz
Hey, has anyone got the ClearFog (ARMADA 388 SoC) to work with the MA5671A? I've to been trying to get the ClearFog to read the MA5671A's EEPROM however it always throws the following error: > # dmesg | grep sfp > [ 4.550651] sfp sfp: Host maximum power 2.0W > [ 5.875047] sfp sfp: please wait,

[PATCH net 0/2] net: ipa: fix some new build warnings

2020-12-26 Thread Alex Elder
I got a super friendly message from the Intel kernel test robot that pointed out that two patches I posted last week caused new build warnings. I already had these problems fixed in my own tree but the fix was not included in what I sent out last week. I regret the error.

[PATCH net 2/2] net: ipa: don't return a value from evt_ring_command()

2020-12-26 Thread Alex Elder
Callers of evt_ring_command() no longer care whether the command times out, and don't use what evt_ring_command() returns. Redefine that function to have void return type. Reported-by: kernel test robot Fixes: 428b448ee764a ("net: ipa: use state to determine event ring command success") Signed-

[PATCH net 1/2] net: ipa: don't return a value from gsi_channel_command()

2020-12-26 Thread Alex Elder
Callers of gsi_channel_command() no longer care whether the command times out, and don't use what gsi_channel_command() returns. Redefine that function to have void return type. Reported-by: kernel test robot Fixes: 6ffddf3b3d182 ("net: ipa: use state to determine channel command success") Sign

RE: [PATCH] nfp: remove h from printk format specifier

2020-12-26 Thread David Laight
From: Tom Rix > Sent: 25 December 2020 14:57 ... > > Kernel code doesn't use a signed char or short with %hx or %hu very often > > but in case you didn't already know, any signed char/short emitted with > > anything like %hx or %hu needs to be left alone as sign extension occurs so: > > Yes, this

Re: [PATCH net] mld: fix panic in mld_newpack()

2020-12-26 Thread Cong Wang
On Wed, Dec 23, 2020 at 8:55 AM Taehee Yoo wrote: > > mld_newpack() doesn't allow to allocate high order page, > just order-0 allocation is allowed. > If headroom size is too large, a kernel panic could occur in skb_put(). ... > Allowing high order page allocation could fix this problem. > > Fixes

Re: [PATCH net 2/3] net: ipa: use state to determine channel command success

2020-12-26 Thread kernel test robot
Hi Alex, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Alex-Elder/net-ipa-GSI-interrupt-handling-fixes/20201223-020409 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 2575bc1aa9d52

Re: [PATCH iproute2 5.11 2/2] iplink_can: fix format output for details with statistics

2020-12-26 Thread Stephen Hemminger
On Fri, 25 Dec 2020 20:10:15 +0100 Oliver Hartkopp wrote: > @@ -315,10 +320,12 @@ static void can_print_opt(struct link_util *lu, FILE > *f, struct rtattr *tb[]) > "restart_ms", > "restart-ms %d ", > *restart_ms); > }

Re: [PATCH] ethernet: Remove invalid trailers after %pI4

2020-12-26 Thread Joe Perches
On Sat, 2020-12-26 at 09:10 -0800, Joe Perches wrote: > Alphanumeric characters after vsprintf pointer extension %pI4 are > not valid and are not emitted. > > Remove the invalid characters from the %pI4 uses. self-nak. I believe I misunderstood the format specifier.

[PATCH net 2/2] bareudp: Fix use of incorrect min_headroom size

2020-12-26 Thread Taehee Yoo
In the bareudp6_xmit_skb(), it calculates min_headroom. At that point, it uses struct iphdr, but it's not correct. So panic could occur. The struct ipv6hdr should be used. Test commands: ip netns add A ip netns add B ip link add veth0 type veth peer name veth1 ip link set veth0 net

[PATCH net 1/2] bareudp: set NETIF_F_LLTX flag

2020-12-26 Thread Taehee Yoo
Like other tunneling interfaces, the bareudp doesn't need TXLOCK. So, It is good to set the NETIF_F_LLTX flag to improve performance and to avoid lockdep's false-positive warning. Test commands: ip netns add A ip netns add B ip link add veth0 type veth peer name veth1 ip link set v

[PATCH net 0/2] bareudp: fix several issues

2020-12-26 Thread Taehee Yoo
This patchset is to fix problems when bareudp is used nestedly. 1. If the NETIF_F_LLTX flag is not set, the lockdep warns about a possible deadlock scenario when bareudp interfaces are used nestedly. But, like other tunneling interfaces, bareudp doesn't need xmit lock. So, it sets NETIF_F_LLTTX. L

[PATCH] ethernet: Remove invalid trailers after %pI4

2020-12-26 Thread Joe Perches
Alphanumeric characters after vsprintf pointer extension %pI4 are not valid and are not emitted. Remove the invalid characters from the %pI4 uses. Signed-off-by: Joe Perches --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 6 +++--- drivers/net/ethernet/intel/i40e/i40e_main.c

[PATCH] fsl/fman: Add MII mode support.

2020-12-26 Thread Maxim Kochetkov
Set proper value to IF_MODE register for MII mode. Signed-off-by: Maxim Kochetkov --- drivers/net/ethernet/freescale/fman/fman_memac.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c inde

[PATCH net v2] net: hns: fix return value check in __lb_other_process()

2020-12-26 Thread wangyunjian
From: Yunjian Wang The function skb_copy() could return NULL, the return value need to be checked. Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet support") Signed-off-by: Yunjian Wang --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 4 1 file changed, 4 i