Re: [PATCH net-next] net: sched: remove redundant 'rtnl_held' argument

2020-11-30 Thread Vlad Buslov
On Tue 01 Dec 2020 at 04:52, Jakub Kicinski wrote: > On Fri, 27 Nov 2020 17:12:05 +0200 Vlad Buslov wrote: >> @@ -2262,7 +2260,7 @@ static int tc_del_tfilter(struct sk_buff *skb, struct >> nlmsghdr *n, >> >> if (prio == 0) { >> tfilter_notify_chain(net, skb, block, q, parent,

[PATCH] dpaa_eth: copy timestamp fields to new skb in A-050385 workaround

2020-11-30 Thread Yangbo Lu
The timestamp fields should be copied to new skb too in A-050385 workaround for later TX timestamping handling. Fixes: 3c68b8fffb48 ("dpaa_eth: FMan erratum A050385 workaround") Signed-off-by: Yangbo Lu --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 10 +- 1 file changed, 9 inserti

回复: INFO: task hung in ath6kl_usb_destroy (3)

2020-11-30 Thread Zhang, Qiang
发件人: syzbot 发送时间: 2020年11月30日 23:31 收件人: andreyk...@google.com; da...@davemloft.net; k...@kernel.org; kv...@codeaurora.org; linux-ker...@vger.kernel.org; linux-...@vger.kernel.org; linux-wirel...@vger.kernel.org; netdev@vger.kernel.org; syzkaller-b...@

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-30 Thread Ido Schimmel
On Mon, Nov 30, 2020 at 05:52:48PM -0800, Jakub Kicinski wrote: > On Sat, 21 Nov 2020 18:09:41 +0200 Ido Schimmel wrote: > > + Florian > > > > On Thu, Oct 29, 2020 at 05:36:19PM +, Aleksandr Nogikh wrote: > > > From: Aleksandr Nogikh > > > > > > Remote KCOV coverage collection enables covera

RE: [PATCH v4 5/6] igb: use xdp_do_flush

2020-11-30 Thread Penigalapati, Sandeep
> From: sven.auha...@voleatech.de > Sent: Wednesday, November 11, 2020 10:35 PM > To: Nguyen, Anthony L ; Fijalkowski, Maciej > ; k...@kernel.org > Cc: da...@davemloft.net; intel-wired-...@lists.osuosl.org; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Penigalapati, Sandeep

Re: [PATCH v2 bpf-next 0/8] Support BTF-powered BPF tracing programs for kernel modules

2020-11-30 Thread Yonghong Song
On 11/30/20 7:55 PM, Andrii Nakryiko wrote: Building on top of two previous patch sets ([0] and not yet landed [1]), this patch sets extends kernel and libbpf with support for attaching BTF-powered raw tracepoint (tp_btf) and tracing (fentry/fexit/fmod_ret/lsm) BPF programs to BPF hooks define

Re: [PATCH net] net/x25: prevent a couple of overflows

2020-11-30 Thread Martin Schiller
On 2020-11-30 11:04, Dan Carpenter wrote: From: "kiyin(尹亮)" The .x25_addr[] address comes from the user and is not necessarily NUL terminated. This leads to a couple problems. The first problem is that the strlen() in x25_bind() can read beyond the end of the buffer. The second problem is mo

Re: [External] Re: [PATCH 0/7] Introduce vdpa management tool

2020-11-30 Thread Jason Wang
On 2020/11/30 下午3:07, Yongji Xie wrote: Thanks for adding me, Jason! Now I'm working on a v2 patchset for VDUSE (vDPA Device in Userspace) [1]. This tool is very useful for the vduse device. So I'm considering integrating this into my v2 patchset. But there is one problem: In this tool, vdpa

[PATCH ethtool] Improve error message when SFP module is missing

2020-11-30 Thread Baruch Siach
ETHTOOL_GMODULEINFO request success indicates that SFP cage is present. Failure of ETHTOOL_GMODULEEEPROM is most likely because SFP module is not plugged in. Add an indication to the user as to what might be the reason for the failure. Signed-off-by: Baruch Siach --- ethtool.c | 1 + 1 file chan

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-30 Thread Martin K. Petersen
Gustavo, > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks. -- Martin K. Petersen Oracle Linux Engineering

RE: [PATCHv5 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-30 Thread George Cherian
> -Original Message- > From: George Cherian > Sent: Tuesday, December 1, 2020 10:49 AM > To: 'Jakub Kicinski' > Cc: 'netdev@vger.kernel.org' ; 'linux- > ker...@vger.kernel.org' ; > 'da...@davemloft.net' ; Sunil Kovvuri Goutham > ; Linu Cherian ; > Geethasowjanya Akula ; 'masahi...@kerne

RE: [PATCHv5 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-30 Thread George Cherian
Jakub, > -Original Message- > From: George Cherian > Sent: Tuesday, December 1, 2020 9:06 AM > To: Jakub Kicinski > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > da...@davemloft.net; Sunil Kovvuri Goutham ; > Linu Cherian ; Geethasowjanya Akula > ; masahi...@kernel.org; > wi

[PATCH v2 bpf-next 6/8] selftests/bpf: add tp_btf CO-RE reloc test for modules

2020-11-30 Thread Andrii Nakryiko
Add another CO-RE relocation test for kernel module relocations. This time for tp_btf with direct memory reads. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 3 +- .../bpf/progs/test_core_reloc_module.c| 32 ++- 2 files changed, 33 in

[PATCH v2 bpf-next 7/8] selftests/bpf: make bpf_testmod's traceable function global

2020-11-30 Thread Andrii Nakryiko
Pahole currently isn't able to generate BTF for static functions in kernel modules, so make sure traced sidecar function is global. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools

[PATCH v2 bpf-next 8/8] selftests/bpf: add fentry/fexit/fmod_ret selftest for kernel module

2020-11-30 Thread Andrii Nakryiko
Add new selftest checking attachment of fentry/fexit/fmod_ret (and raw tracepoint ones for completeness) BPF programs to kernel module function. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/module_attach.c | 53 +++ .../selftests/bpf/progs/test_module_attach.c |

[PATCH v2 bpf-next 0/8] Support BTF-powered BPF tracing programs for kernel modules

2020-11-30 Thread Andrii Nakryiko
Building on top of two previous patch sets ([0] and not yet landed [1]), this patch sets extends kernel and libbpf with support for attaching BTF-powered raw tracepoint (tp_btf) and tracing (fentry/fexit/fmod_ret/lsm) BPF programs to BPF hooks defined in kernel modules. Kernel UAPI for BPF_PROG_LO

[PATCH v2 bpf-next 5/8] libbpf: support attachment of BPF tracing programs to kernel modules

2020-11-30 Thread Andrii Nakryiko
Teach libbpf to search for BTF types in kernel modules for tracing BPF programs. This allows attachment of raw_tp/fentry/fexit/fmod_ret/etc BPF program types to tracepoints and functions in kernel modules. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/bpf.c | 1 + tools/lib/bpf

[PATCH v2 bpf-next 2/8] bpf: remove hard-coded btf_vmlinux assumption from BPF verifier

2020-11-30 Thread Andrii Nakryiko
Remove a permeating assumption thoughout BPF verifier of vmlinux BTF. Instead, wherever BTF type IDs are involved, also track the instance of struct btf that goes along with the type ID. This allows to gradually add support for kernel module BTFs and using/tracking module types across BPF helper ca

[PATCH v2 bpf-next 4/8] libbpf: factor out low-level BPF program loading helper

2020-11-30 Thread Andrii Nakryiko
Refactor low-level API for BPF program loading to not rely on public API types. This allows painless extension without constant efforts to cleverly not break backwards compatibility. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/bpf.c | 100 ++-- tools/

[PATCH v2 bpf-next 3/8] bpf: allow to specify kernel module BTFs when attaching BPF programs

2020-11-30 Thread Andrii Nakryiko
Add ability for user-space programs to specify non-vmlinux BTF when attaching BTF-powered BPF programs: raw_tp, fentry/fexit/fmod_ret, LSM, etc. For this, add attach_btf_obj_id field which contains BTF object ID for either vmlinux or module. For backwards compatibility (and simplicity) reasons, 0 d

[PATCH v2 bpf-next 1/8] bpf: keep module's btf_data_size intact after load

2020-11-30 Thread Andrii Nakryiko
Having real btf_data_size stored in struct module is benefitial to quickly determine which kernel modules have associated BTF object and which don't. There is no harm in keeping this info, as opposed to keeping invalid pointer. Fixes: 607c543f939d ("bpf: Sanitize BTF data pointer after module is l

[PATCH v3 bpf-next 7/7] selftests/bpf: add CO-RE relocs selftest relying on kernel module BTF

2020-11-30 Thread Andrii Nakryiko
Add a self-tests validating libbpf is able to perform CO-RE relocations against the type defined in kernel module BTF. if bpf_testmod.o is not supported by the kernel (e.g., due to version mismatch), skip tests, instead of failing. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/

[PATCH v3 bpf-next 5/7] selftests/bpf: add bpf_testmod kernel module for testing

2020-11-30 Thread Andrii Nakryiko
Add bpf_testmod module, which is conceptually out-of-tree module and provides ways for selftests/bpf to test various kernel module-related functionality: raw tracepoint, fentry/fexit/fmod_ret, etc. This module will be auto-loaded by test_progs test runner and expected by some of selftests to be pre

[PATCH v3 bpf-next 6/7] selftests/bpf: add support for marking sub-tests as skipped

2020-11-30 Thread Andrii Nakryiko
Previously skipped sub-tests would be counted as passing with ":OK" appened in the log. Change that to be accounted as ":SKIP". Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/test_progs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/self

[PATCH v3 bpf-next 3/7] libbpf: refactor CO-RE relocs to not assume a single BTF object

2020-11-30 Thread Andrii Nakryiko
Refactor CO-RE relocation candidate search to not expect a single BTF, rather return all candidate types with their corresponding BTF objects. This will allow to extend CO-RE relocations to accommodate kernel module BTFs. Acked-by: Martin KaFai Lau Signed-off-by: Andrii Nakryiko --- tools/lib/b

[PATCH v3 bpf-next 4/7] libbpf: add kernel module BTF support for CO-RE relocations

2020-11-30 Thread Andrii Nakryiko
Teach libbpf to search for candidate types for CO-RE relocations across kernel modules BTFs, in addition to vmlinux BTF. If at least one candidate type is found in vmlinux BTF, kernel module BTFs are not iterated. If vmlinux BTF has no matching candidates, then find all kernel module BTFs and searc

[PATCH v3 bpf-next 0/7] libbpf: add support for kernel module BTF CO-RE relocations

2020-11-30 Thread Andrii Nakryiko
Implement libbpf support for performing CO-RE relocations against types in kernel module BTFs, in addition to existing vmlinux BTF support. This is a first step towards fully supporting kernel module BTFs. Subsequent patch sets will expand kernel and libbpf sides to allow using other BTF-powered c

[PATCH v3 bpf-next 1/7] bpf: fix bpf_put_raw_tracepoint()'s use of __module_address()

2020-11-30 Thread Andrii Nakryiko
__module_address() needs to be called with preemption disabled or with module_mutex taken. preempt_disable() is enough for read-only uses, which is what this fix does. Also, module_put() does internal check for NULL, so drop it as well. Fixes: a38d1107f937 ("bpf: support raw tracepoints in modules

[PATCH v3 bpf-next 2/7] libbpf: add internal helper to load BTF data by FD

2020-11-30 Thread Andrii Nakryiko
Add a btf_get_from_fd() helper, which constructs struct btf from in-kernel BTF data by FD. This is used for loading module BTFs. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/btf.c | 61 +++-- tools/lib/bpf/libbpf_internal.h | 1 + 2 files changed, 36

Re: [PATCHv5 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-30 Thread George Cherian
Hi Jakub, > -Original Message- > From: Jakub Kicinski > Sent: Tuesday, December 1, 2020 7:59 AM > To: George Cherian > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > da...@davemloft.net; Sunil Kovvuri Goutham ; > Linu Cherian ; Geethasowjanya Akula > ; masahi...@kernel.org;

Re: pull-request: can 2020-11-30

2020-11-30 Thread Jakub Kicinski
On Mon, 30 Nov 2020 13:53:02 +0100 Marc Kleine-Budde wrote: > Hello Jakub, hello David, > > here's a pull request of 5 patches for net/master. > > The first patch is by me an target the tcan4x5x bindings for the m_can driver. > It fixes the error path in the tcan4x5x_can_probe() function. > > Th

Re: pull-request: can-next 2020-11-30

2020-11-30 Thread Jakub Kicinski
On Mon, 30 Nov 2020 15:14:18 +0100 Marc Kleine-Budde wrote: > Hello Jakub, hello David, > > here's a pull request of 14 patches for net-next/master. > > Gustavo A. R. Silva's patch for the pcan_usb driver fixes fall-through > warnings > for Clang. > > The next 5 patches target the mcp251xfd dr

RE: [net-next 1/4] e1000e: allow turning s0ix flows on for systems with ME

2020-11-30 Thread Limonciello, Mario
> On Mon, Nov 30, 2020 at 2:16 PM Limonciello, Mario > wrote: > > > > > > > > Generally the use of module parameters and sysfs usage are frowned > > > upon. > > > > I was trying to build on the existing module parameters that existed > > already for e1000e. So I guess I would ask, why are those

Re: [PATCH] net: wan: remove trailing semicolon in macro definition

2020-11-30 Thread Jakub Kicinski
On Fri, 27 Nov 2020 08:57:34 -0800 t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix This one looks fine, applied, thanks.

Re: [PATCH] net: bna: remove trailing semicolon in macro definition

2020-11-30 Thread Jakub Kicinski
On Fri, 27 Nov 2020 08:55:50 -0800 t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > --- > drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net

Re: [PATCH net-next] net: sched: remove redundant 'rtnl_held' argument

2020-11-30 Thread Jakub Kicinski
On Fri, 27 Nov 2020 17:12:05 +0200 Vlad Buslov wrote: > @@ -2262,7 +2260,7 @@ static int tc_del_tfilter(struct sk_buff *skb, struct > nlmsghdr *n, > > if (prio == 0) { > tfilter_notify_chain(net, skb, block, q, parent, n, > - chain, RTM_DELTFI

Re: [PATCH net-next v3] net/nfc/nci: Support NCI 2.x initial sequence

2020-11-30 Thread Jakub Kicinski
On Fri, 27 Nov 2020 22:36:31 +0900 bongsu.je...@gmail.com wrote: > From: Bongsu Jeon > > implement the NCI 2.x initial sequence to support NCI 2.x NFCC. > Since NCI 2.0, CORE_RESET and CORE_INIT sequence have been changed. > If NFCEE supports NCI 2.x, then NCI 2.x initial sequence will work. > >

Re: [PATCH net-next 0/6] mptcp: avoid workqueue usage for data

2020-11-30 Thread Jakub Kicinski
On Fri, 27 Nov 2020 11:10:21 +0100 Paolo Abeni wrote: > The current locking schema used to protect the MPTCP data-path > requires the usage of the MPTCP workqueue to process the incoming > data, depending on trylock result. > > The above poses scalability limits and introduces random delays > in M

Re: [PATCH 1/2] vxlan: Add needed_headroom for lower device

2020-11-30 Thread Jakub Kicinski
On Thu, 26 Nov 2020 13:52:46 +0100 Sven Eckelmann wrote: > It was observed that sending data via batadv over vxlan (on top of > wireguard) reduced the performance massively compared to raw ethernet or > batadv on raw ethernet. A check of perf data showed that the > vxlan_build_skb was calling all t

Re: [PATCHv5 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-30 Thread Jakub Kicinski
On Thu, 26 Nov 2020 19:32:50 +0530 George Cherian wrote: > Add health reporters for RVU NPA block. > NPA Health reporters handle following HW event groups > - GENERAL events > - ERROR events > - RAS events > - RVU event > An event counter per event is maintained in SW. > > Output: > # devlink

Re: [PATCHv5 net-next 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-11-30 Thread Jakub Kicinski
On Thu, 26 Nov 2020 19:32:49 +0530 George Cherian wrote: > Add devlink support to AF driver. Basic devlink support is added. > Currently info_get is the only supported devlink ops. > > devlink ouptput looks like this > # devlink dev > pci/0002:01:00.0 > # devlink dev info > pci/0002:01:00.0: >

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-30 Thread Jakub Kicinski
On Sat, 21 Nov 2020 18:09:41 +0200 Ido Schimmel wrote: > + Florian > > On Thu, Oct 29, 2020 at 05:36:19PM +, Aleksandr Nogikh wrote: > > From: Aleksandr Nogikh > > > > Remote KCOV coverage collection enables coverage-guided fuzzing of the > > code that is not reachable during normal system c

Re: [PATCH net] chelsio/chtls: fix panic during unload reload chtls

2020-11-30 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 26 Nov 2020 03:19:14 +0530 you wrote: > there is kernel panic in inet_twsk_free() while chtls > module unload when socket is in TIME_WAIT state because > sk_prot_creator was not preserved on connection socket. > > Fixes

Re: [PATCH v2 net-next 2/4] net: dsa: Link aggregation support

2020-11-30 Thread Vladimir Oltean
Hi Tobias, On Mon, Nov 30, 2020 at 03:06:08PM +0100, Tobias Waldekranz wrote: > Monitor the following events and notify the driver when: > > - A DSA port joins/leaves a LAG. > - A LAG, made up of DSA ports, joins/leaves a bridge. > - A DSA port in a LAG is enabled/disabled (enabled meaning > "d

Re: [PATCH net-next v5 0/7] dpaa_eth: add XDP support

2020-11-30 Thread Jakub Kicinski
On Sat, 28 Nov 2020 23:59:57 +0100 Maciej Fijalkowski wrote: > On Wed, Nov 25, 2020 at 06:53:29PM +0200, Camelia Groza wrote: > > Enable XDP support for the QorIQ DPAA1 platforms. > > > > Implement all the current actions (DROP, ABORTED, PASS, TX, REDIRECT). No > > Tx batching is added at this tim

Re: [PATCH bpf-next 1/2] bpf: Adds support for setting window clamp

2020-11-30 Thread Alexei Starovoitov
On Mon, Nov 30, 2020 at 4:07 PM Prankur gupta wrote: > > Adds a new bpf_setsockopt for TCP sockets, TCP_BPF_WINDOW_CLAMP, > which sets the maximum receiver window size. It will be useful for > limiting receiver window based on RTT. > > Signed-off-by: Prankur gupta > --- > net/core/filter.c | 8 +

Re: [PATCH v2] net/af_unix: don't create a path for a binded socket

2020-11-30 Thread Jakub Kicinski
On Mon, 30 Nov 2020 16:27:47 +0300 Denis Kirjanov wrote: > in the case of the socket which is bound to an adress > there is no sense to create a path in the next attempts > > here is a program that shows the issue: > > int main() > { > int s; > struct sockaddr_un a; > > s = socket(AF

[PATCH 2/2][v3] e1000e: Remove the runtime suspend restriction on CNP+

2020-11-30 Thread Chen Yu
Although there is platform issue of runtime suspend support on CNP, it would be more flexible to let the user decide whether to disable runtime or not because: 1. This can be done in userspace via echo on > /sys/devices/pci\:00/\:00\:1f.d/power/control 2. More and more NICs would support

[PATCH 1/2][v3] e1000e: Leverage direct_complete to speed up s2ram

2020-11-30 Thread Chen Yu
The NIC is put in runtime suspend status when there is no cable connected. As a result, it is safe to keep non-wakeup NIC in runtime suspended during s2ram because the system does not rely on the NIC plug event nor WoL to wake up the system. Besides that, unlike the s2idle, s2ram does not need to m

Re: [PATCH bpf-next 1/7] bpf: remove hard-coded btf_vmlinux assumption from BPF verifier

2020-11-30 Thread Alexei Starovoitov
On Mon, Nov 30, 2020 at 3:04 PM Andrii Nakryiko wrote: > > No more holes, but the same overall size. Does that work? Thanks. That's a good idea.

[PATCH 0/2][v3] Put the NIC in runtime suspended during s2ram

2020-11-30 Thread Chen Yu
The NIC is put in runtime suspend status when there is no cable connected. As a result, it is safe to keep non-wakeup NIC in runtime suspended during s2ram because the system does not rely on the NIC plug event nor WoL to wake up the system. Besides that, unlike the s2idle, s2ram does not need to m

Re: [PATCH v13 4/4] bus: mhi: Add userspace client interface driver

2020-11-30 Thread Hemant Kumar
Hi Loic, On 11/30/20 10:22 AM, Loic Poulain wrote: On Sat, 28 Nov 2020 at 04:26, Hemant Kumar wrote: This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device object which is associated to de

Re: VRF NS for lladdr sent on the wrong interface

2020-11-30 Thread David Ahern
On 11/23/20 5:23 PM, Stephen Suryaputra wrote: > Hi, > > I'm running into a problem with lladdr pinging all-host mcast all nodes > addr. The ping intially works but after cycling the interface that > receives the ping, the echo request packet causes a neigh solicitation > being sent on a different

Re: [PATCH net v2 0/2] ibmvnic: Bug fixes for queue descriptor processing

2020-11-30 Thread Jakub Kicinski
On Mon, 30 Nov 2020 13:07:22 -0600 Thomas Falcon wrote: > This series resolves a few issues in the ibmvnic driver's > RX buffer and TX completion processing. The first patch > includes memory barriers to synchronize queue descriptor > reads. The second patch fixes a memory leak that could > occur i

Re: [PATCH v13 4/4] bus: mhi: Add userspace client interface driver

2020-11-30 Thread Hemant Kumar
Hi Mani, On 11/27/20 10:11 PM, Manivannan Sadhasivam wrote: Hi Hemant, On Fri, Nov 27, 2020 at 07:26:06PM -0800, Hemant Kumar wrote: This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device o

Re: [net-next 1/4] e1000e: allow turning s0ix flows on for systems with ME

2020-11-30 Thread Jakub Kicinski
On Mon, 30 Nov 2020 13:29:04 -0800 Tony Nguyen wrote: > From: Mario Limonciello > > S0ix for GBE flows are needed for allowing the system to get into deepest > power state, but these require coordination of components outside of > control of Linux kernel. For systems that have confirmed to coord

RE: [PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-30 Thread Tristram.Ha
> Hi Microchip, > > as ACL based blocking of PTP traffic seems not to work, I tried to install MAC > based static lookup rules on the switch I successfully managed to block other > non-PTP traffic, but for PTP the lookup table entry (see below) seems not to > work. Incoming SYNC messages on port a

[PATCH net-next 2/2] net: ipa: add support for inline checksum offload

2020-11-30 Thread Alex Elder
Starting with IPA v4.5, IP payload checksum offload is implemented differently. Prior to v4.5, the IPA hardware appends an rmnet_map_dl_csum_trailer structure to each packet if checksum offload is enabled in the download direction (modem->AP). In the upload direction (AP->modem) a rmnet_map_ul_cs

[PATCH net-next 0/2] net: ipa: IPA v4.5 inline checksum offload

2020-11-30 Thread Alex Elder
This series includes one changed destined for a central header file and a second (dependent on the first) that applies to the IPA driver. If these should be posted a different way, please let me know. The first patch introduces a new data structure defining the format of a header that's used for "

[PATCH net-next 1/2] if_rmnet.h: define struct rmnet_map_v5_csum_header

2020-11-30 Thread Alex Elder
Define a new rmnet_map_v5_csum_header structure type. It will be used for inline checksum offload, supported with version 5 of the QMAP protocol. Signed-off-by: Alex Elder --- include/linux/if_rmnet.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/include/li

Re: [PATCH iproute2-next 3/6] lib: Move sprint_size() from tc here, add print_size()

2020-11-30 Thread Stephen Hemminger
On Mon, 30 Nov 2020 23:59:39 +0100 Petr Machata wrote: > +char *sprint_size(__u32 sz, char *buf) > +{ > + size_t len = SPRINT_BSIZE - 1; > + double tmp = sz; > + > + if (sz >= 1024*1024 && fabs(1024*1024*rint(tmp/(1024*1024)) - sz) < > 1024) > + snprintf(buf, len, "%gMb",

Re: [PATCH iproute2-next 2/6] lib: Move print_rate() from tc here; modernize

2020-11-30 Thread Stephen Hemminger
On Mon, 30 Nov 2020 23:59:38 +0100 Petr Machata wrote: > The functions print_rate() and sprint_rate() are useful for formatting > rate-like values. The DCB tool would find these useful in the maxrate > subtool. However, the current interface to these functions uses a global > variable use_iec as

[PATCH v2 bpf-next 7/7] selftests/bpf: add CO-RE relocs selftest relying on kernel module BTF

2020-11-30 Thread Andrii Nakryiko
Add a self-tests validating libbpf is able to perform CO-RE relocations against the type defined in kernel module BTF. if bpf_testmod.o is not supported by the kernel (e.g., due to version mismatch), skip tests, instead of failing. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/

[PATCH v2 bpf-next 5/7] selftests/bpf: add bpf_testmod kernel module for testing

2020-11-30 Thread Andrii Nakryiko
Add bpf_testmod module, which is conceptually out-of-tree module and provides ways for selftests/bpf to test various kernel module-related functionality: raw tracepoint, fentry/fexit/fmod_ret, etc. This module will be auto-loaded by test_progs test runner and expected by some of selftests to be pre

[PATCH v2 bpf-next 6/7] selftests/bpf: add support for marking sub-tests as skipped

2020-11-30 Thread Andrii Nakryiko
Previously skipped sub-tests would be counted as passing with ":OK" appened in the log. Change that to be accounted as ":SKIP". Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/test_progs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/self

[PATCH v2 bpf-next 4/7] libbpf: add kernel module BTF support for CO-RE relocations

2020-11-30 Thread Andrii Nakryiko
Teach libbpf to search for candidate types for CO-RE relocations across kernel modules BTFs, in addition to vmlinux BTF. If at least one candidate type is found in vmlinux BTF, kernel module BTFs are not iterated. If vmlinux BTF has no matching candidates, then find all kernel module BTFs and searc

[PATCH v2 bpf-next 3/7] libbpf: refactor CO-RE relocs to not assume a single BTF object

2020-11-30 Thread Andrii Nakryiko
Refactor CO-RE relocation candidate search to not expect a single BTF, rather return all candidate types with their corresponding BTF objects. This will allow to extend CO-RE relocations to accommodate kernel module BTFs. Acked-by: Martin KaFai Lau Signed-off-by: Andrii Nakryiko --- tools/lib/b

[PATCH v2 bpf-next 1/7] bpf: fix bpf_put_raw_tracepoint()'s use of __module_address()

2020-11-30 Thread Andrii Nakryiko
__module_address() needs to be called with preemption disabled or with module_mutex taken. preempt_disable() is enough for read-only uses, which is what this fix does. Also, module_put() does internal check for NULL, so drop it as well. Fixes: a38d1107f937 ("bpf: support raw tracepoints in modules

[PATCH v2 bpf-next 2/7] libbpf: add internal helper to load BTF data by FD

2020-11-30 Thread Andrii Nakryiko
Add a btf_get_from_fd() helper, which constructs struct btf from in-kernel BTF data by FD. This is used for loading module BTFs. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/btf.c | 61 +++-- tools/lib/bpf/libbpf_internal.h | 1 + 2 files changed, 36

[PATCH v2 bpf-next 0/7] libbpf: add support for kernel module BTF CO-RE relocations

2020-11-30 Thread Andrii Nakryiko
Implement libbpf support for performing CO-RE relocations against types in kernel module BTFs, in addition to existing vmlinux BTF support. This is a first step towards fully supporting kernel module BTFs. Subsequent patch sets will expand kernel and libbpf sides to allow using other BTF-powered c

[PATCH net-next 1/2] ionic: remove some unnecessary oom messages

2020-11-30 Thread Shannon Nelson
Remove memory allocation fail messages where the OOM stack trace will make it obvious which allocation request failed. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_dev.c | 2 +- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 8 +++- drivers/net/ethernet/pe

[PATCH net-next 2/2] ionic: change mtu after queues are stopped

2020-11-30 Thread Shannon Nelson
Order of operations is slightly more correct in the driver to change the netdev->mtu after the queues have been stopped rather than before. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/

[PATCH net-next 0/2] ionic updates

2020-11-30 Thread Shannon Nelson
These are a pair of small code cleanups. Shannon Nelson (2): ionic: remove some unnecessary oom messages ionic: change mtu after queues are stopped drivers/net/ethernet/pensando/ionic/ionic_dev.c | 2 +- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 14 +++--- drivers/net/ethe

Re: [PATCH net-next v2 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-30 Thread Vladimir Oltean
On Mon, Nov 30, 2020 at 05:58:17PM -0600, George McCollister wrote: > On Mon, Nov 30, 2020 at 5:50 PM Vladimir Oltean wrote: > > > > On Mon, Nov 30, 2020 at 10:52:35AM -0600, George McCollister wrote: > > > Another possible option could be replacing for_each_netdev_rcu with > > > for_each_netdev_s

Re: [PATCH bpf] libbpf: reset errno after probing kernel features

2020-11-30 Thread Andrii Nakryiko
On Mon, Nov 30, 2020 at 2:41 PM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Mon, Nov 30, 2020 at 7:42 AM Toke Høiland-Jørgensen > > wrote: > >> > >> The kernel feature probing results in 'errno' being set if the probing > >> fails (as is often the case). This can stick ar

Re: [PATCH net-next v4 3/4] dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY

2020-11-30 Thread Rob Herring
On Tue, Nov 17, 2020 at 02:15:54PM -0600, Dan Murphy wrote: > The DP83TD510 is a 10M single twisted pair Ethernet PHY > > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/net/ti,dp83td510.yaml | 64 +++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentati

[PATCH bpf-next 2/2] selftests/bpf: Add Userspace tests for TCP_WINDOW_CLAMP

2020-11-30 Thread Prankur gupta
Adding selftests for new added functionality to set TCP_WINDOW_CLAMP from bpf setsockopt. Signed-off-by: Prankur gupta --- tools/testing/selftests/bpf/bpf_tcp_helpers.h | 1 + .../selftests/bpf/prog_tests/tcpbpf_user.c| 4 +++ .../selftests/bpf/progs/test_tcpbpf_kern.c| 33

[PATCH bpf-next 0/2] Add support to set window_clamp from bpf setsockops

2020-11-30 Thread Prankur gupta
This patch contains support to set tcp window_field field from bpf setsockops. Prankur gupta (2): bpf: Adds support for setting window clamp selftests/bpf: Add Userspace tests for TCP_WINDOW_CLAMP net/core/filter.c | 8 + tools/testing/selftests/bpf/bpf_tcp_h

[PATCH bpf-next 1/2] bpf: Adds support for setting window clamp

2020-11-30 Thread Prankur gupta
Adds a new bpf_setsockopt for TCP sockets, TCP_BPF_WINDOW_CLAMP, which sets the maximum receiver window size. It will be useful for limiting receiver window based on RTT. Signed-off-by: Prankur gupta --- net/core/filter.c | 8 1 file changed, 8 insertions(+) diff --git a/net/core/filte

Re: [PATCH net-next v4 2/4] dt-bindings: net: Add Rx/Tx output configuration for 10base T1L

2020-11-30 Thread Rob Herring
On Tue, Nov 17, 2020 at 02:15:53PM -0600, Dan Murphy wrote: > Per the 802.3cg spec the 10base T1L can operate at 2 different > differential voltages 1v p2p and 2.4v p2p. The abiility of the PHY to 1.1V? > drive that output is dependent on the PHY's on board power supply. > This common feature is

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

2020-11-30 Thread Sasha Levin
On Mon, Nov 30, 2020 at 09:29:02PM +0100, Paolo Bonzini wrote: On 30/11/20 20:44, Mike Christie wrote: I have never seen a public/open-source vhost-scsi testsuite. For patch 23 (the one that adds the lun reset support which is built on patch 22), we can't add it to stable right now if you wante

Re: [PATCH net-next v2 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-30 Thread George McCollister
On Mon, Nov 30, 2020 at 5:50 PM Vladimir Oltean wrote: > > On Mon, Nov 30, 2020 at 10:52:35AM -0600, George McCollister wrote: > > Another possible option could be replacing for_each_netdev_rcu with > > for_each_netdev_srcu and using list_for_each_entry_srcu (though it's > > currently used nowhere

Re: [PATCH net-next v2 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-30 Thread Vladimir Oltean
On Mon, Nov 30, 2020 at 10:52:35AM -0600, George McCollister wrote: > Another possible option could be replacing for_each_netdev_rcu with > for_each_netdev_srcu and using list_for_each_entry_srcu (though it's > currently used nowhere else in the kernel). Has anyone considered > using sleepable RCUs

Re: [PATCH net-next 5/6] mptcp: avoid a few atomic ops in the rx path

2020-11-30 Thread Mat Martineau
On Fri, 27 Nov 2020, Paolo Abeni wrote: Extending the data_lock scope in mptcp_incoming_option we can use that to protect both snd_una and wnd_end. In the typical case, we will have a single atomic op instead of 2 Acked-by: Florian Westphal Signed-off-by: Paolo Abeni --- net/mptcp/mptcp_diag.

Re: [PATCH net-next 4/6] mptcp: allocate TX skbs in msk context

2020-11-30 Thread Mat Martineau
On Fri, 27 Nov 2020, Paolo Abeni wrote: Move the TX skbs allocation in mptcp_sendmsg() scope, and tentatively pre-allocate a skbs number proportional to the sendmsg() length. Use the ssk tx skb cache to prevent the subflow allocation. This allows removing the msk skb extension cache and will m

Re: [PATCH net-next 6/6] mptcp: use mptcp release_cb for delayed tasks

2020-11-30 Thread Mat Martineau
On Fri, 27 Nov 2020, Paolo Abeni wrote: We have some tasks triggered by the subflow receive path which require to access the msk socket status, specifically: mptcp_clean_una() and mptcp_push_pending() We have almost everything in place to defer to the msk release_cb such tasks when the msk sock

Re: [PATCH net-next 3/6] mptcp: protect the rx path with the msk socket spinlock

2020-11-30 Thread Mat Martineau
On Fri, 27 Nov 2020, Paolo Abeni wrote: Such spinlock is currently used only to protect the 'owned' flag inside the socket lock itself. With this patch, we extend its scope to protect the whole msk receive path and sk_forward_memory. Given the above, we can always move data into the msk receive

Re: [PATCH net-next 1/6] mptcp: open code mptcp variant for lock_sock

2020-11-30 Thread Mat Martineau
On Fri, 27 Nov 2020, Paolo Abeni wrote: This allows invoking an additional callback under the socket spin lock. Will be used by the next patches to avoid additional spin lock contention. Acked-by: Florian Westphal Signed-off-by: Paolo Abeni --- include/net/sock.h | 1 + net/core/sock.c

Re: [PATCH net-next 2/6] mptcp: implement wmem reservation

2020-11-30 Thread Mat Martineau
On Fri, 27 Nov 2020, Paolo Abeni wrote: This leverages the previous commit to reserve the wmem required for the sendmsg() operation when the msk socket lock is first acquired. Some heuristics are used to get a reasonable [over] estimation of the whole memory required. If we can't forward alloc s

Re: warnings from MTU setting on switch ports

2020-11-30 Thread Andrew Lunn
> > A thought: Shouldn't the initialization of slave_dev->max_mtu in > > dsa_slave_create() be capped by master->max_mtu minus tag overhead? > > Talk to Andrew: > https://www.spinics.net/lists/netdev/msg645810.html Yes, this is historic. DSA started life with Marvell switches connected to Marvell

[PATCH net-next 2/4] net: ipa: set up IPA v4.5 Qtime configuration

2020-11-30 Thread Alex Elder
IPA v4.5 introduces a new unified timer architecture driven on the 19.2 MHz SoC crystal oscillator (XO). It is independent of the IPA core clock and avoids some duplication. Lower-resolution time stamps are derived from this by using only the high-order bits of the 19.2 MHz Qtime clock. And time

[PATCH net-next 3/4] net: ipa: use Qtime for IPA v4.5 aggregation time limit

2020-11-30 Thread Alex Elder
Change aggr_time_limit_encoded() to properly calculate the aggregation time limit to use for IPA v4.5. Older IPA versions program the AGGR_GRANULARITY field of the of the COUNTER_CFG register to set the granularity of the aggregation timer, which we configure to be 500 microseconds. Instead, IPA

[PATCH net-next 4/4] net: ipa: use Qtime for IPA v4.5 head-of-line time limit

2020-11-30 Thread Alex Elder
Extend ipa_reg_init_hol_block_timer_val() so it properly calculates the head-of-line block timeout to use for IPA v4.5. Introduce hol_block_timer_qtime_val() to compute the value to use for IPA v4.5, where Qtime is used as the basis of the timer. Call that function from hol_block_timer_val() for

[PATCH net-next 0/4] net: ipa: IPA v4.5 aggregation and Qtime

2020-11-30 Thread Alex Elder
This series updates some IPA register definitions that change in substantive ways for IPA v4.5. One register defines parameters used by an endpoint to aggregate multiple packets into a buffer. The size and position of most fields in that register have changed with this new hardware version, and c

[PATCH net-next 1/4] net: ipa: update IPA aggregation registers for IPA v4.5

2020-11-30 Thread Alex Elder
IPA v4.5 significantly changes the format of the configuration register used for endpoint aggregation. The AGGR_BYTE_LIMIT field is now larger, and the positions of other fields are shifted. This complicates the way we have to access this register because functions like u32_encode_bits() require

[PATCH iproute2-next 0/2] Implement action terse dump

2020-11-30 Thread Vlad Buslov
Refactor action flags according to recommended kernel upstream naming using TCA_ACT_ prefix. Implement support for new action terse dump flag. Vlad Buslov (2): tc: use TCA_ACT_ prefix for action flags tc: implement support for action terse dump include/uapi/linux/rtnetlink.h | 12 +++

[PATCH iproute2-next 2/2] tc: implement support for action terse dump

2020-11-30 Thread Vlad Buslov
Implement support for action terse dump using new TCA_ACT_FLAG_TERSE_DUMP value of TCA_ROOT_FLAGS tlv. Set the flag when user requested it with following example CLI (-br for 'brief'): $ tc -s -br actions ls action tunnel_key total acts 2 action order 0: tunnel_key index 1 A

[PATCH iproute2-next 1/2] tc: use TCA_ACT_ prefix for action flags

2020-11-30 Thread Vlad Buslov
Use TCA_ACT_FLAG_LARGE_DUMP_ON alias according to new preferred naming for action flags. Signed-off-by: Vlad Buslov --- include/uapi/linux/rtnetlink.h | 12 +++- tc/m_action.c | 4 ++-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/include/uapi/linux/rt

Re: [PATCH bpf-next v4 00/10] Introduce preferred busy-polling

2020-11-30 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 30 Nov 2020 19:51:55 +0100 you wrote: > This series introduces three new features: > > 1. A new "heavy traffic" busy-polling variant that works in concert >with the existing napi_defer_hard_irqs and gro_flush_tim

Re: [PATCH 3/5] tc: fix compiler warnings in ip6 pedit

2020-11-30 Thread Petr Machata
Stephen Hemminger writes: > Gcc-10 complains about referencing a zero size array. > This occurs because the array of keys is actually in the following > structure which is part of the overall selector. > > The original code was safe, but better to just use the key > array directly. > > Fixes: 2

  1   2   3   4   >