Order of operations is slightly more correct in the driver
to change the netdev->mtu after the queues have been stopped
rather than before.

Signed-off-by: Shannon Nelson <snel...@pensando.io>
---
 drivers/net/ethernet/pensando/ionic/ionic_lif.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c 
b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
index 0b7f2def423c..11140915c2da 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
@@ -1465,12 +1465,14 @@ static int ionic_change_mtu(struct net_device *netdev, 
int new_mtu)
        if (err)
                return err;
 
-       netdev->mtu = new_mtu;
        /* if we're not running, nothing more to do */
-       if (!netif_running(netdev))
+       if (!netif_running(netdev)) {
+               netdev->mtu = new_mtu;
                return 0;
+       }
 
        ionic_stop_queues_reconfig(lif);
+       netdev->mtu = new_mtu;
        return ionic_start_queues_reconfig(lif);
 }
 
-- 
2.17.1

Reply via email to