Re: [PATCHv2 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

On Thu, Nov 26, 2020 at 10:31:56PM -0800, Yonghong Song wrote: > > index 35e16dee613e..8bdec0865e1d 100644 > > --- a/samples/bpf/xdp_redirect_map_user.c > > +++ b/samples/bpf/xdp_redirect_map_user.c > > @@ -21,12 +21,13 @@ > > static int ifindex_in; > > static int ifindex_out; > > -static bool

Re: [PATCH net-next 0/2] TLS TX HW offload for Bond

On 23/11/2020 20:20, Jakub Kicinski wrote: > On Sun, 22 Nov 2020 14:48:04 +0200 Tariq Toukan wrote: >> >> As I understand it, best if we can even generalize this to apply to all >> kinds of traffic: bond driver won't do the xmit itself anymore, it just >> picks an egress dev and returns it. Th

Re: [External] Re: [PATCH 0/7] Introduce vdpa management tool

On Mon, Nov 30, 2020 at 11:36 AM Jason Wang wrote: > > > On 2020/11/27 下午1:52, Yongji Xie wrote: > > On Fri, Nov 27, 2020 at 11:53 AM Jason Wang > > wrote: > > > > > > On 2020/11/12 下午2:39, Parav Pandit wrote: > > > This patchset covers user requirements for ma

general protection fault in l2cap_chan_timeout

Hello, syzbot found the following issue on: HEAD commit:fa02fcd9 Merge tag 'media/v5.10-2' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14a36fa550 kernel config: https://syzkaller.appspot.com/x/.config?x=7be70951fca93701 das

Re: Correct usage of dev_base_lock in 2020

On Sun, 29 Nov 2020 22:58:17 +0200 Vladimir Oltean wrote: > [ resent, had forgot to copy the list ] > > Hi, > > net/core/dev.c has this to say about the locking rules around the network > interface lists (dev_base_head, and I can only assume that it also applies to > the per-ifindex hash table

Re: [PATCH net] net: fix memory leak in register_netdevice() on error path

On Thu, 26 Nov 2020 21:23:12 +0800 Yang Yingliang wrote: > I got a memleak report when doing fault-inject test: > > unreferenced object 0x88810ace9000 (size 1024): > comm "ip", pid 4622, jiffies 4295457037 (age 43.378s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 00 00 00

Re: [External] Re: [PATCH 0/7] Introduce vdpa management tool

On 2020/11/27 下午1:52, Yongji Xie wrote: On Fri, Nov 27, 2020 at 11:53 AM Jason Wang > wrote: On 2020/11/12 下午2:39, Parav Pandit wrote: > This patchset covers user requirements for managing existing vdpa devices, > using a tool and its internal desig

[net] tipc: fix incompatible mtu of transmission

From: Hoang Le In commit 682cd3cf946b6 ("tipc: confgiure and apply UDP bearer MTU on running links"), we introduced a function to change UDP bearer MTU and applied this new value across existing per-link. However, we did not apply this new MTU value at node level. This lead to packet dropped at l

Re: [PATCH v4] vdpa: mlx5: fix vdpa/vhost dependencies

On 2020/11/29 上午5:39, Randy Dunlap wrote: drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so select VHOST_IOTLB to make them be built. However, if VHOST_IOTLB is the only VHOST symbol that is set/enabled, the object file still won't be built because drivers/Makefile won't descend into drive

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/ibm/ibmvnic.c between commit: 9281cf2d5840 ("ibmvnic: avoid memset null scrq msgs") from the net tree and commit: f019fb6392e5 ("ibmvnic: Introduce indirect subordinate Command Response Queue

Re: [PATCH bpf-next 2/3] bpf: allow bpf_{s,g}etsockopt from cgroup bind{4,6} hooks

Alexei Starovoitov [Tue, 2020-11-17 20:05 -0800]: > On Tue, Nov 17, 2020 at 4:17 PM Stanislav Fomichev wrote: > > > > I have to now lock/unlock socket for the bind hook execution. > > That shouldn't cause any overhead because the socket is unbound > > and shouldn't receive any traffic. > > > > Si

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

On Sun, Nov 29, 2020 at 04:33:35AM +0900, Masahiro Yamada wrote: > Revert commit cebc04ba9aeb ("add CONFIG_ENABLE_MUST_CHECK"). > > A lot of warn_unused_result warnings existed in 2006, but until now > they have been fixed thanks to people doing allmodconfig tests. > > Our goal is to always enabl

Re: [PATCH] powerpc: fix the allyesconfig build

On 2020/11/29 3:36, Jakub Kicinski wrote: > On Sat, 28 Nov 2020 16:20:54 +1100 Stephen Rothwell wrote: >> On Fri, 27 Nov 2020 17:56:42 -0800 Jakub Kicinski wrote: >>> >>> What's the offending structure in hisilicon? I'd rather have a look >>> packing structs with pointers in 'em sounds questionabl

RE: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

> -Original Message- > From: Lee Jones [mailto:lee.jo...@linaro.org] > Sent: Friday, November 27, 2020 4:57 PM > To: Pkshih > Cc: Tony Chuang; kv...@codeaurora.org; linux-ker...@vger.kernel.org; > linux-wirel...@vger.kernel.org; > da...@davemloft.net; netdev@vger.kernel.org; k...@kernel.

[PATCH 5/5] f_u32: fix compiler gcc-10 compiler warning

With gcc-10 it complains about array subscript error. f_u32.c: In function ‘u32_parse_opt’: f_u32.c:1113:24: warning: array subscript 0 is outside the bounds of an interior zero-length array ‘struct tc_u32_key[0]’ [-Wzero-length-bounds] 1113 |hash = sel2.sel.keys[0].val & sel2.sel.keys[0].ma

[PATCH 3/5] tc: fix compiler warnings in ip6 pedit

Gcc-10 complains about referencing a zero size array. This occurs because the array of keys is actually in the following structure which is part of the overall selector. The original code was safe, but better to just use the key array directly. Fixes: 2d9a8dc439ee ("tc: p_ip6: Support pedit of IP

[PATCH 2/5] bridge: fix string length warning

Gcc-10 complains about possible string length overflow. This can't happen Ethernet address format is always limited to 18 characters or less. Just resize the temp buffer. Fixes: 70dfb0b8836d ("iplink: bridge: export bridge_id and designated_root") Cc: niko...@cumulusnetworks.com Signed-off-by: Ste

[PATCH 4/5] misc: fix compiler warning in ifstat and nstat

The code here was doing strncpy() in a way that causes gcc 10 warning about possible string overflow. Just use strlcpy() which will null terminate and bound the string as expected. This has existed since start of git era so no Fixes tag. Signed-off-by: Stephen Hemminger --- misc/ifstat.c | 2 +-

[PATCH 1/5] devlink: fix uninitialized warning

GCC-10 complains about uninitialized variable. devlink.c: In function ‘cmd_dev’: devlink.c:2803:12: warning: ‘val_u32’ may be used uninitialized in this function [-Wmaybe-uninitialized] 2803 |val_u16 = val_u32; |^ devlink.c:2747:11: note: ‘val_u32’ was declared here

[PATCH 0/5] Fix compiler warnings from GCC-10

Update to GCC-10 and it starts warning about some new things. Stephen Hemminger (5): devlink: fix uninitialized warning bridge: fix string length warning tc: fix compiler warnings in ip6 pedit misc: fix compiler warning in ifstat and nstat f_u32: fix compiler gcc-10 compiler warning de

[net-next PATCH] net: freescale: ucc_geth: remove unused SKB_ALLOC_TIMEOUT

This was added in commit ce973b141dfa ("[PATCH] Freescale QE UCC gigabit ethernet driver") but doesn't appear to have been used. Remove it now. Signed-off-by: Chris Packham --- drivers/net/ethernet/freescale/ucc_geth.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/frees

Re: [PATCH v2 1/3] dt-bindings: net: fsl-fec add mdc/mdio bitbang option

On Sun, Nov 29, 2020 at 11:51:43PM +0100, Adrien Grassein wrote: > Hi Andrew, > > Please find my answers below. > > Le dim. 29 nov. 2020 à 23:41, Andrew Lunn a écrit : > > On Sun, Nov 29, 2020 at 10:59:58PM +0100, Adrien Grassein wrote: > > Add dt-bindings explanation for the two new gp

[PATCH v2 3/3] net: fsl: fec: add imx8mq support.

This patch adds the imx8mq support to the fsl fec driver. Quirks are extracted from the NXP driver (5.4). Signed-off-by: Adrien Grassein --- drivers/net/ethernet/freescale/fec_main.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c

[PATCH v2 2/3] net: fsl: fec: add mdc/mdio bitbang option

This patch adds the ability for the fec to use the mdc/mdio bitbang protocol to communicate with its phy. It adds two new optional parameters in the devicetree definition for the two needed GPIO (mdc and mdio). It uses the mdio-bitbang generic implementation. Signed-off-by: Adrien Grassein ---

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

Hi Florian, > On 11/27/2020 4:33 PM, Lukasz Majewski wrote: > >> So why use DSA at all? What benefit does it bring you? Why not do > >> the entire switch configuration from within FEC, or a separate > >> driver very closely related to it? > > > > Mine rationale to use DSA and FEC: > > - Make as

[PATCH v2 1/3] dt-bindings: net: fsl-fec add mdc/mdio bitbang option

Add dt-bindings explanation for the two new gpios (mdio and mdc) used for bitbanging. Signed-off-by: Adrien Grassein --- Documentation/devicetree/bindings/net/fsl-fec.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/de

Re: [PATCH] mlxsw: switch from 'pci_' to 'dma_' API

Am 29.11.2020 um 22:17 schrieb Christophe JAILLET: > he wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is a

Re: [PATCH iproute2-net 3/3] devlink: Add reload stats to dev show

On 11/26/20 4:14 AM, Moshe Shemesh wrote: > @@ -2975,17 +2996,93 @@ static int cmd_dev_param(struct dl *dl) > return -ENOENT; > } > > -static void pr_out_dev(struct dl *dl, struct nlattr **tb) > +static void pr_out_action_stats(struct dl *dl, struct nlattr *action_stats) > +{ > + struc

[PATCH] mlxsw: switch from 'pci_' to 'dma_' API

he wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'mlxsw_pci_queue_init()' and 'mlxsw_pci_fw_area_init(

Re: [PATCH iproute2-net 2/3] devlink: Add pr_out_dev() helper function

On 11/26/20 4:14 AM, Moshe Shemesh wrote: > diff --git a/devlink/devlink.c b/devlink/devlink.c > index a9ba0072..bd588869 100644 > --- a/devlink/devlink.c > +++ b/devlink/devlink.c > @@ -2974,17 +2974,11 @@ static int cmd_dev_param(struct dl *dl) > pr_err("Command \"%s\" not found\n", dl_argv

Re: [PATCH iproute2-net 1/3] devlink: Add devlink reload action and limit options

On 11/26/20 4:14 AM, Moshe Shemesh wrote: > @@ -1997,7 +2066,7 @@ static void cmd_dev_help(void) > pr_err(" devlink dev eswitch show DEV\n"); > pr_err(" devlink dev param set DEV name PARAMETER value VALUE > cmode { permanent | driverinit | runtime }\n"); > pr_err("

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On Sun, Nov 29, 2020 at 06:34:01PM +0100, Paolo Bonzini wrote: On 29/11/20 05:13, Sasha Levin wrote: Which doesn't seem to be suitable for stable either...  Patch 3/5 in Why not? It was sent as a fix to Linus. Dunno, 120 lines of new code? Even if it's okay for an rc, I don't see why it is

Re: Correct usage of dev_base_lock in 2020

[ resent, had forgot to copy the list ] Hi, net/core/dev.c has this to say about the locking rules around the network interface lists (dev_base_head, and I can only assume that it also applies to the per-ifindex hash table dev_index_head and the per-name hash table dev_name_head): /* * The @dev

Re: [PATCH v3 iproute2] bridge: add support for L2 multicast groups

On 11/25/20 7:36 AM, Vladimir Oltean wrote: > Extend the 'bridge mdb' command for the following syntax: > bridge mdb add dev br0 port swp0 grp 01:02:03:04:05:06 permanent > > Signed-off-by: Vladimir Oltean > --- > Changes in v3: > - Using rt_addr_n2a_r instead of inet_ntop/ll_addr_n2a directly. >

Re: [PATCH iproute2] Add dcb/.gitignore

On 11/27/20 8:27 AM, Luca Boccassi wrote: > Signed-off-by: Luca Boccassi > --- > dcb/.gitignore | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 dcb/.gitignore > > diff --git a/dcb/.gitignore b/dcb/.gitignore > new file mode 100644 > index ..3f26856c > --- /dev/null > +++ b/

[PATCH net-next] net: delete __dev_getfirstbyhwtype

The last user of the RTNL brother of dev_getfirstbyhwtype (the latter being synchronized under RCU) has been deleted in commit b4db2b35fc44 ("afs: Use core kernel UUID generation"). Cc: Arnd Bergmann Cc: David Howells Cc: Eric Dumazet Signed-off-by: Vladimir Oltean --- include/linux/netdevice

Re: [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission

Andrew, On Sun, Nov 29, 2020 at 8:38 PM Andrew Lunn wrote: > > On Sun, Nov 29, 2020 at 08:34:27PM +0100, Jean Pihet wrote: > > Hi Andrew, > > > > On Sun, Nov 29, 2020 at 5:56 PM Andrew Lunn wrote: > > > > > > On Sun, Nov 29, 2020 at 11:23:59AM +0100, Jean Pihet wrote: > > > > Some ethernet contr

Re: [PATCH iproute2-next 0/5] iproute2: add libbpf support

On 11/28/20 11:16 PM, Stephen Hemminger wrote: > Luca wants to put this in Debian 11 (good idea), but that means: > > 1. It has to work with 5.10 release and kernel. > 2. Someone has to test it. > 3. The 5.10 is a LTS kernel release which means BPF developers have >to agree to supporting LTS r

Re: [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission

On Sun, Nov 29, 2020 at 08:34:27PM +0100, Jean Pihet wrote: > Hi Andrew, > > On Sun, Nov 29, 2020 at 5:56 PM Andrew Lunn wrote: > > > > On Sun, Nov 29, 2020 at 11:23:59AM +0100, Jean Pihet wrote: > > > Some ethernet controllers (e.g. TI CPSW) pad the frames to a minimum > > > of 64 bytes before t

Re: [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission

Hi Andrew, On Sun, Nov 29, 2020 at 5:56 PM Andrew Lunn wrote: > > On Sun, Nov 29, 2020 at 11:23:59AM +0100, Jean Pihet wrote: > > Some ethernet controllers (e.g. TI CPSW) pad the frames to a minimum > > of 64 bytes before the FCS is appended. This causes an issue with the > > KSZ tail tag which c

Re: [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission

Andrew, On Sun, Nov 29, 2020 at 5:57 PM Andrew Lunn wrote: > > Hi Jean > > Please also include a patch 0/X which describes the patchset as a > whole. This will be used as the branch merge commit. Sure, will submit a v2 asap. Thx, Jean > >Andrew

Re: [PATCH 8/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues

On Thu, Nov 26, 2020 at 01:38:53PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > from drivers/net/ethernet/ibm/ibmvnic.c:35: > inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: > drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Functio

Re: [PATCH 7/8] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters

On Thu, Nov 26, 2020 at 01:38:52PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/toshiba/spider_net.c:263: warning: Function parameter > or member 'hwdescr' not described in 'spider_net_get_descr_status' > drivers/net/ethernet/toshiba/spider

Re: [PATCH 6/8] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours

On Thu, Nov 26, 2020 at 01:38:51PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function > parameter or member 'irq' not described in 'gelic_card_interrupt' > drivers/net/ethernet/toshiba/ps3_gelic_net

Re: [PATCH 5/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours

Hi Lee > /** > * build_hdr_data - creates L2/L3/L4 header data buffer > - * @hdr_field - bitfield determining needed headers > - * @skb - socket buffer > - * @hdr_len - array of header lengths > - * @tot_len - total length of data > + * @hdr_field: bitfield determining needed headers > + * @skb

Re: [PATCH 4/8] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter

On Thu, Nov 26, 2020 at 01:38:49PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/ti/am65-cpts.c:736: warning: Function parameter or > member 'en' not described in 'am65_cpts_rx_enable' > drivers/net/ethernet/ti/am65-cpts.c:736: warning: Exce

Re: [PATCH 3/8] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header

On Thu, Nov 26, 2020 at 01:38:48PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or > member 'ndev' not described in 'am65_cpsw_timer_set' > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: war

Re: [PATCH 2/8] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers

On Thu, Nov 26, 2020 at 01:38:47PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member > 'dev' not described in 'frontend_changed' > drivers/net/xen-netback/xenbus.c:419: warning: Function par

[PATCH 10/10 net-next v2] net/tipc: add TIPC chapter to networking Documentation

Add a TIPC chapter to the networking docbook. Signed-off-by: Randy Dunlap Cc: Jon Maloy Cc: Ying Xue Cc: tipc-discuss...@lists.sourceforge.net Cc: "David S. Miller" Cc: Jakub Kicinski --- v2: rebase to current net-next Documentation/networking/index.rst |1 Documentation/networking/tip

[PATCH 02/10 net-next v2] net/tipc: fix various kernel-doc warnings

kernel-doc and Sphinx fixes to eliminate lots of warnings in preparation for adding to the networking docbook. ../net/tipc/crypto.c:57: warning: cannot understand function prototype: 'enum ' ../net/tipc/crypto.c:69: warning: cannot understand function prototype: 'enum ' ../net/tipc/crypto.c:130: w

[PATCH 08/10 net-next v2] net/tipc: fix socket.c kernel-doc

Fix socket.c kernel-doc warnings in preparation for adding to the networking docbook. Also, for rcvbuf_limit(), use bullet notation so that the lines do not run together. ../net/tipc/socket.c:130: warning: Function parameter or member 'cong_links' not described in 'tipc_sock' ../net/tipc/socket.

[PATCH 07/10 net-next v2] net/tipc: fix node.c kernel-doc

Fix node.c kernel-doc warnings in preparation for adding to the networking docbook. ../net/tipc/node.c:141: warning: Function parameter or member 'kref' not described in 'tipc_node' ../net/tipc/node.c:141: warning: Function parameter or member 'bc_entry' not described in 'tipc_node' ../net/tipc/

[PATCH 09/10 net-next v2] net/tipc: fix all function Return: notation

Fix Return: kernel-doc notation in all net/tipc/ source files. Also keep ReST list notation intact for output formatting. Fix a few typos in comments. Signed-off-by: Randy Dunlap Cc: Jon Maloy Cc: Ying Xue Cc: tipc-discuss...@lists.sourceforge.net Cc: "David S. Miller" Cc: Jakub Kicinski ---

[PATCH 05/10 net-next v2] net/tipc: fix name_distr.c kernel-doc

Fix name_distr.c kernel-doc warnings in preparation for adding to the networking docbook. ../net/tipc/name_distr.c:55: warning: Function parameter or member 'i' not described in 'publ_to_item' ../net/tipc/name_distr.c:55: warning: Function parameter or member 'p' not described in 'publ_to_item'

[PATCH 06/10 net-next v2] net/tipc: fix name_table.c kernel-doc

Fix name_table.c kernel-doc warnings in preparation for adding to the networking docbook. ../net/tipc/name_table.c:115: warning: Function parameter or member 'start' not described in 'service_range_foreach_match' ../net/tipc/name_table.c:115: warning: Function parameter or member 'end' not descr

Re: [PATCH 1/8] net: ethernet: smsc: smc91x: Demote non-conformant kernel function header

On Thu, Nov 26, 2020 at 01:38:46PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or > member 'dev' not described in 'try_toggle_control_gpio' > drivers/net/ethernet/smsc/smc91x.c:2200: warning:

[PATCH 01/10 net-next v2] net/tipc: fix tipc header files for kernel-doc

Fix tipc header files for adding to the networking docbook. Remove some uses of "/**" that were not kernel-doc notation. Fix some source formatting to eliminate Sphinx warnings. Add missing struct member and function argument kernel-doc descriptions. Correct the description of a couple of struc

[PATCH 03/10 net-next v2] net/tipc: fix bearer.c for kernel-doc

Fix kernel-doc warnings in bearer.c: ../net/tipc/bearer.c:77: warning: Function parameter or member 'name' not described in 'tipc_media_find' ../net/tipc/bearer.c:91: warning: Function parameter or member 'type' not described in 'media_find_id' ../net/tipc/bearer.c:105: warning: Function paramet

[PATCH 04/10 net-next v2] net/tipc: fix link.c kernel-doc

Fix link.c kernel-doc warnings in preparation for adding to the networking docbook. ../net/tipc/link.c:200: warning: Function parameter or member 'session' not described in 'tipc_link' ../net/tipc/link.c:200: warning: Function parameter or member 'snd_nxt_state' not described in 'tipc_link' ../n

[PATCH 00/10 net-next v2] net/tipc: fix all kernel-doc and add TIPC networking chapter

Fix lots of net/tipc/ kernel-doc warnings. Add many struct field and function parameter descriptions. Then add a TIPC chapter to the networking documentation book. All patches have been rebased to current net-next. Note: some of the struct members and function parameters are marked with "FIXME"

Re: [PATCH 00/10 net-next] net/tipc: fix all kernel-doc and add TIPC networking chapter

On 11/28/20 11:37 PM, Ying Xue wrote: > On 11/25/20 12:20 PM, Randy Dunlap wrote: >> >> Question: is net/tipc/discover.c, in tipc_disc_delete() kernel-doc, >> what is the word "duest"? Should it be changed? > > The "duest" is a typo, and it should be "dest" defined as below: > struct tipc_discove

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

> +#define SPX5_RD_(sparx5, id, tinst, tcnt,\ > + gbase, ginst, gcnt, gwidth,\ > + raddr, rinst, rcnt, rwidth)\ > + readl(spx5_addr((sparx5)->regs, id, tinst, tcnt,\ > + gbase, gins

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On 29/11/20 05:13, Sasha Levin wrote: Which doesn't seem to be suitable for stable either...  Patch 3/5 in Why not? It was sent as a fix to Linus. Dunno, 120 lines of new code? Even if it's okay for an rc, I don't see why it is would be backported to stable releases and release it without

Re: [PATCH iproute2-next 0/5] iproute2: add libbpf support

On Sat, Nov 28, 2020 at 10:16 PM Stephen Hemminger wrote: > > On Fri, 23 Oct 2020 11:38:50 +0800 > Hangbin Liu wrote: > > > This series converts iproute2 to use libbpf for loading and attaching > > BPF programs when it is available. This means that iproute2 will > > correctly process BTF informat

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

Hello Michael, On Sat, Nov 28, 2020 at 09:48:30AM +0100, Takashi Iwai wrote: > On Thu, 26 Nov 2020 17:59:50 +0100, > Uwe Kleine-König wrote: > > > > The driver core ignores the return value of struct device_driver::remove > > because there is only little that can be done. For the shutdown callbac

Re: [PATCH] bpf: remove trailing semicolon in macro definition

On 11/27/20 4:54 PM, Daniel Borkmann wrote: > On 11/27/20 8:27 PM, t...@redhat.com wrote: >> From: Tom Rix >> >> The macro use will already have a semicolon. >> >> Signed-off-by: Tom Rix >> --- >>   include/trace/events/xdp.h | 4 ++-- >>   1 file changed, 2 insertions(+), 2 deletions(-) >> >> d

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

> +static void sparx5_hw_lock(struct sparx5 *sparx5) > +{ > + mutex_lock(&sparx5->lock); > +} > + > +static void sparx5_hw_unlock(struct sparx5 *sparx5) > +{ > + mutex_unlock(&sparx5->lock); > +} Why is this mutex special and gets a wrapper where as the other two don't? If there is no reas

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c > b/drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c > new file mode 100644 > index ..a91dd9532f1c > --- /dev/null > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c > @@ -0,0 +1,1027 @@ > +// SPDX-

Re: [PATCH] NFS: remove trailing semicolon in macro definition

On 11/29/20 8:50 AM, Trond Myklebust wrote: > On Sun, 2020-11-29 at 16:42 +, Trond Myklebust wrote: >> Hi Tom, >> >> On Fri, 2020-11-27 at 11:43 -0800, t...@redhat.com wrote: >>> From: Tom Rix >>> >>> The macro use will already have a semicolon. >>> >>> Signed-off-by: Tom Rix >>> --- >>>  n

Re: [PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface

On Sun, Nov 29, 2020 at 11:24:00AM +0100, Jean Pihet wrote: > Add support for RGMII in 100 and 1000 Mbps. > > Adjust the CPU port based on the host interface settings: interface > MII type, speed, duplex. Please could you add some extra information here why this is needed. I suspect you have back

Re: [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission

Hi Jean Please also include a patch 0/X which describes the patchset as a whole. This will be used as the branch merge commit. Andrew

Re: [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission

On Sun, Nov 29, 2020 at 11:23:59AM +0100, Jean Pihet wrote: > Some ethernet controllers (e.g. TI CPSW) pad the frames to a minimum > of 64 bytes before the FCS is appended. This causes an issue with the > KSZ tail tag which could not be the last byte before the FCS. > Solve this by padding the fram

Re: [PATCH] NFS: remove trailing semicolon in macro definition

On Sun, 2020-11-29 at 16:42 +, Trond Myklebust wrote: > Hi Tom, > > On Fri, 2020-11-27 at 11:43 -0800, t...@redhat.com wrote: > > From: Tom Rix > > > > The macro use will already have a semicolon. > > > > Signed-off-by: Tom Rix > > --- > >  net/sunrpc/auth_gss/gss_generic_token.c | 2 +- >

Re: [PATCH] NFS: remove trailing semicolon in macro definition

Hi Tom, On Fri, 2020-11-27 at 11:43 -0800, t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > --- >  net/sunrpc/auth_gss/gss_generic_token.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sunrpc/au

Re: [PATCH] can: don't count arbitration lose as an error

Hello Oliver, On 11/28/20 6:23 PM, Oliver Hartkopp wrote: On 27.11.20 12:09, Jeroen Hofstee wrote: Hi, On 11/27/20 11:30 AM, Marc Kleine-Budde wrote: On 11/27/20 10:59 AM, Jeroen Hofstee wrote: Losing arbitration is normal in a CAN-bus network, it means that a higher priority frame is bein

[PATCH] mwl8k: switch from 'pci_' to 'dma_' API

he wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'mwl8k_rxq_init()' and 'mwl8k_txq_init()' GFP_KERNEL

RE: net: dsa: mv88e6xxx : linux v5.4 crash

Hi Andrew, Your last reply is attached bellow. > So either of_phy_is_fixed_link(np) is returning false, or of_node_get(np) > returns NULL. > You need to do some debugging and figure out which and why. I did some testing as you suggested. zynq-7000 switch1 switch2 (cpu) mv88e

Re: [PATCH net] net: fix memory leak in register_netdevice() on error path

On 2020/11/26 22:23, Yang Yingliang wrote: ... Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- net/core/dev.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index 82dc6b48e45f..907204395b64 100644 --- a/net/core/dev.c +++ b/net/core

Re: [PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface

submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jean-Pihet/net-dsa-ksz-pad-frame-to-64-bytes-for-transmission/20201129-182750 base: https://git.kernel.org/pub/scm/linux/kernel

[no subject]

Hallo Mein Name ist George Mike. Ich bin von Beruf Rechtsanwalt. Ich möchte Ihnen anbieten der nächste Verwandte meines Klienten. Sie erben die Summe von (8,5 Millionen US-Dollar) Dollar, die mein Kunde vor seinem Tod auf der Bank gelassen hat. Mein Kunde ist ein Staatsbürger Ihres Landes, der mi

[PATCH net-next 3/9] mlxsw: spectrum: Only treat 802.1q packets as tagged packets

From: Amit Cohen By default, the device considers both 802.1ad and 802.1q packets as tagged, but this is not supported by the driver. It only supports VLAN and bridge devices that use 802.1q protocol. Instead, configure the device to only treat 802.1q packets as tagged packets. Signed-off-by: A

[PATCH net-next 9/9] selftests: forwarding: Add QinQ veto testing

From: Danielle Ratson Test that each veto that was added in the previous patch, is indeed vetoed. $ ./q_in_q_veto.sh TEST: create 802.1ad vlan upper on top of a front panel [ OK ] TEST: create 802.1ad vlan upper on top of a bridge port [ OK ] TEST: create 802.1ad vlan up

[PATCH net-next 7/9] bridge: switchdev: Notify about VLAN protocol changes

From: Danielle Ratson Drivers that support bridge offload need to be notified about changes to the bridge's VLAN protocol so that they could react accordingly and potentially veto the change. Add a new switchdev attribute to communicate the change to drivers. Signed-off-by: Danielle Ratson Rev

[PATCH net-next 8/9] mlxsw: Add QinQ configuration vetoes

From: Danielle Ratson After adding support for QinQ, a.k.a 802.1ad protocol, there are a few scenarios that should be vetoed. The vetoes are motivated by various ASIC limitations. For example, a port that is member in a 802.1ad bridge cannot have 802.1q uppers as the port needs to be configured

[PATCH net-next 4/9] mlxsw: Make EtherType configurable when pushing VLAN at ingress

From: Amit Cohen Currently, when pushing a PVID at ingress, mlxsw always uses 802.1q EtherType. Make this EtherType configurable by extending mlxsw_sp_port_pvid_set() with an EtherType argument. This is a preparation for QinQ support, that needs to push a PVID with 802.1ad EtherType. Signed-of

[PATCH net-next 5/9] mlxsw: spectrum_switchdev: Create common functions for VLAN-aware bridge

From: Amit Cohen The code in mlxsw_sp_bridge_8021q_port_{join, leave}() can be used also for 802.1ad bridge. Move the code to functions called mlxsw_sp_bridge_vlan_aware_port_{join, leave}() and call them from mlxsw_sp_bridge_8021q_port_{join, leave}() respectively to enable code reuse. Signed-

[PATCH net-next 6/9] mlxsw: spectrum_switchdev: Add support of QinQ traffic

From: Amit Cohen 802.1ad, also known as QinQ is an extension to the 802.1q standard, which is concerned with passing possibly 802.1q-tagged packets through another VLAN-like tunnel. The format of 802.1ad tag is the same as 802.1q, except it uses the EtherType of 0x88a8, unlike 802.1q's 0x8100. A

Re: [PATCH net] ipv4: Fix tos mask in inet_rtm_getroute()

On Sat, Nov 28, 2020 at 01:17:16PM -0800, Jakub Kicinski wrote: > On Sat, 28 Nov 2020 10:03:42 -0700 David Ahern wrote: > > On 11/26/20 11:09 AM, Guillaume Nault wrote: > > > When inet_rtm_getroute() was converted to use the RCU variants of > > > ip_route_input() and ip_route_output_key(), the TOS

[PATCH net-next 1/9] mlxsw: reg: Add Switch Port VLAN Classification Register

From: Amit Cohen SPVC configures the port to identify packets as untagged / single tagged / double tagged packets based on the packet EtherTypes. It will be used to classify 802.1q packets as untagged and 802.1ad packets as tagged when received by ports member in a 802.1ad bridge. Signed-off-by

[PATCH net-next 0/9] mlxsw: Add support for 802.1ad bridging

From: Ido Schimmel 802.1ad, also known as QinQ, is an extension to the 802.1q standard, which is concerned with passing possibly 802.1q-tagged packets through another VLAN-like tunnel. The format of 802.1ad tag is the same as 802.1q, except it uses the EtherType of 0x88a8, unlike 802.1q's 0x8100.

[PATCH net-next 2/9] mlxsw: reg: Add et_vlan field to SPVID register

From: Amit Cohen et_vlan field is used to configure which EtherType is used when VLAN is pushed at ingress (for untagged packets or for QinQ push mode). It will be used to configure tagging with ether_type1 (i.e., 0x88A8) for QinQ mode. Signed-off-by: Amit Cohen Reviewed-by: Petr Machata Sign

[RFC PATCH] net: dsa: ksz8795: ksz8795_adjust_link() can be static

Reported-by: kernel test robot Signed-off-by: kernel test robot --- ksz8795.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz8795.c b/drivers/net/dsa/microchip/ksz8795.c index 09c1173cc6073c..834a8dc251adba 100644 --- a/drivers/net/dsa/micr

Re: [PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface

submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jean-Pihet/net-dsa-ksz-pad-frame-to-64-bytes-for-transmission/20201129-182750 base: https://git.kernel.org/pub/scm/linux/kernel

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

On Sun, Nov 29, 2020 at 10:52:45AM +, Russell King - ARM Linux admin wrote: > There are other issues too. This is also wrong: + if (port->ndev && port->ndev->phydev) + status->link = port->ndev->phydev->link; phylink already deals with that situation. --

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

On Sun, Nov 29, 2020 at 10:52:45AM +, Russell King - ARM Linux admin wrote: > On Sat, Nov 28, 2020 at 10:28:28PM +, Russell King - ARM Linux admin > wrote: > > On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote: > > > > +static void sparx5_phylink_mac_config(struct phylink_config

WARNING: suspicious RCU usage in get_counters

Hello, syzbot found the following issue on: HEAD commit:127c501a Merge tag '5.10-rc5-smb3-fixes' of git://git.samb.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17f4912d50 kernel config: https://syzkaller.appspot.com/x/.config?x=6d1e98d0b97781e4 das

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

On Sat, Nov 28, 2020 at 10:28:28PM +, Russell King - ARM Linux admin wrote: > On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote: > > > +static void sparx5_phylink_mac_config(struct phylink_config *config, > > > + unsigned int mode, > > > +

[PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface

Add support for RGMII in 100 and 1000 Mbps. Adjust the CPU port based on the host interface settings: interface MII type, speed, duplex. Signed-off-by: Jean Pihet --- drivers/net/dsa/microchip/ksz8795.c | 93 ++--- 1 file changed, 57 insertions(+), 36 deletions(-) diff

[PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission

Some ethernet controllers (e.g. TI CPSW) pad the frames to a minimum of 64 bytes before the FCS is appended. This causes an issue with the KSZ tail tag which could not be the last byte before the FCS. Solve this by padding the frame to 64 bytes minus the tail tag size, before the tail tag is added

Re: [PATCH v2 net-next 3/3] nfc: s3fwrn5: extract the common phy blocks

On Sat, Nov 28, 2020 at 9:49 PM Krzysztof Kozlowski wrote: > > On Fri, Nov 27, 2020 at 08:22:18PM +0900, bongsu.je...@gmail.com wrote: > > From: Bongsu Jeon > > > > Extract the common phy blocks to reuse it. > > The UART module will use the common blocks. > > > > Signed-off-by: Bongsu Jeon > > -

  1   2   >