Re: [PATCH 00/10 net-next] net/tipc: fix all kernel-doc and add TIPC networking chapter

2020-11-28 Thread Ying Xue
On 11/25/20 12:20 PM, Randy Dunlap wrote: > > Question: is net/tipc/discover.c, in tipc_disc_delete() kernel-doc, > what is the word "duest"? Should it be changed? The "duest" is a typo, and it should be "dest" defined as below: struct tipc_discoverer { u32 bearer_id; struct tipc

[PATCH] net: broadcom CNIC: requires MMU

2020-11-28 Thread Randy Dunlap
The CNIC kconfig symbol selects UIO and UIO depends on MMU. Since 'select' does not follow dependency chains, add the same MMU dependency to CNIC. Quietens this kconfig warning: WARNING: unmet direct dependencies detected for UIO Depends on [n]: MMU [=n] Selected by [m]: - CNIC [=m] && NETD

Re: NETDEV WATCHDOG: s1p1 (bnxt_en): transmit queue 2 timed out

2020-11-28 Thread Michael Chan
On Wed, Nov 25, 2020 at 11:39 AM Marc Smith wrote: > [17879.279213] bnxt_en :01:09.0 s1p1: TX timeout detected, > starting reset task! > [17883.075299] bnxt_en :01:09.0 s1p1: Resp cmpl intr err msg: 0x51 > [17883.075302] bnxt_en :01:09.0 s1p1: hwrm_ring_free type 1 > failed. rc:ff

Re: [PATCH iproute2-next 0/5] iproute2: add libbpf support

2020-11-28 Thread Greg KH
On Sat, Nov 28, 2020 at 10:16:35PM -0800, Stephen Hemminger wrote: > On Fri, 23 Oct 2020 11:38:50 +0800 > Hangbin Liu wrote: > > > This series converts iproute2 to use libbpf for loading and attaching > > BPF programs when it is available. This means that iproute2 will > > correctly process BTF i

Re: [PATCH iproute2-next 0/5] iproute2: add libbpf support

2020-11-28 Thread Stephen Hemminger
On Fri, 23 Oct 2020 11:38:50 +0800 Hangbin Liu wrote: > This series converts iproute2 to use libbpf for loading and attaching > BPF programs when it is available. This means that iproute2 will > correctly process BTF information and support the new-style BTF-defined > maps, while keeping compatib

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

2020-11-28 Thread Sasha Levin
On Wed, Nov 25, 2020 at 07:08:54PM +0100, Paolo Bonzini wrote: On 25/11/20 19:01, Sasha Levin wrote: On Wed, Nov 25, 2020 at 06:48:21PM +0100, Paolo Bonzini wrote: On 25/11/20 16:35, Sasha Levin wrote: From: Mike Christie [ Upstream commit 18f1becb6948cd411fd01968a0a54af63732e73c ] Move cod

Re: [PATCH bpf-next 5/7] selftests/bpf: add tp_btf CO-RE reloc test for modules

2020-11-28 Thread Alexei Starovoitov
On Fri, Nov 20, 2020 at 06:46:14PM -0800, Andrii Nakryiko wrote: > > SEC("raw_tp/bpf_sidecar_test_read") > -int BPF_PROG(test_core_module, > +int BPF_PROG(test_core_module_probed, >struct task_struct *task, >struct bpf_sidecar_test_read_ctx *read_ctx) > { > @@ -64,3 +64,

Re: [PATCH bpf-next 1/7] bpf: remove hard-coded btf_vmlinux assumption from BPF verifier

2020-11-28 Thread Alexei Starovoitov
On Fri, Nov 20, 2020 at 06:46:10PM -0800, Andrii Nakryiko wrote: > > @@ -52,12 +53,19 @@ struct bpf_reg_state { >*/ > struct bpf_map *map_ptr; > > - u32 btf_id; /* for PTR_TO_BTF_ID */ > + /* for PTR_TO_BTF_ID */ > + struct { > +

Re: [PATCH net-next v4 7/7] dpaa_eth: implement the A050385 erratum workaround for XDP

2020-11-28 Thread Maciej Fijalkowski
On Fri, Nov 27, 2020 at 05:35:00PM +, Camelia Alexandra Groza wrote: > > -Original Message- > > From: Maciej Fijalkowski > > Sent: Friday, November 27, 2020 16:44 > > To: Camelia Alexandra Groza > > Cc: k...@kernel.org; bro...@redhat.com; sa...@kernel.org; > > da...@davemloft.net; Mad

Re: [PATCH net-next v5 0/7] dpaa_eth: add XDP support

2020-11-28 Thread Maciej Fijalkowski
On Wed, Nov 25, 2020 at 06:53:29PM +0200, Camelia Groza wrote: > Enable XDP support for the QorIQ DPAA1 platforms. > > Implement all the current actions (DROP, ABORTED, PASS, TX, REDIRECT). No > Tx batching is added at this time. > > Additional XDP_PACKET_HEADROOM bytes are reserved in each frame

[PATCH 3/3] net: fsl: fec: add imx8mq support.

2020-11-28 Thread Adrien Grassein
This patch adds the imx8mq support to the fsl fec driver. Quirks are extracted from the NXP driver (5.4). Signed-off-by: Adrien Grassein --- drivers/net/ethernet/freescale/fec_main.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c

[PATCH 2/3] net: fsl: fec: add mdc/mdio bitbang option

2020-11-28 Thread Adrien Grassein
This patch adds the ability for the fec to use the mdc/mdio bitbang protocol to communicate with its phy. It adds two new optional parameters in the devicetree definition for the two needed GPIO (mdc and mdio). It uses the mdio-bitbang generic implementation. Signed-off-by: Adrien Grassein ---

[PATCH 1/3] dt-bindings: net: fsl-fec add mdc/mdio bitbang option

2020-11-28 Thread Adrien Grassein
Add dt-bindings explanation for the two new gpios (mdio and mdc) used for bitbanging. Signed-off-by: Adrien Grassein --- Documentation/devicetree/bindings/net/fsl-fec.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/de

Re: [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples

2020-11-28 Thread Jakub Kicinski
On Fri, 27 Nov 2020 20:35:55 +0100 Marc Kleine-Budde wrote: > On 11/27/20 5:27 PM, Jakub Kicinski wrote: > > On Fri, 27 Nov 2020 10:13:01 +0100 Marc Kleine-Budde wrote: > >> On 10/26/20 4:36 PM, Krzysztof Kozlowski wrote: > >>> GPIO_ACTIVE_x flags are not correct in the context of interrupt fla

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-28 Thread Russell King - ARM Linux admin
On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote: > > +static void sparx5_phylink_mac_config(struct phylink_config *config, > > + unsigned int mode, > > + const struct phylink_link_state *state) > > +{ > > + struct sparx5_

Re: [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples

2020-11-28 Thread Marc Kleine-Budde
On 11/27/20 5:27 PM, Jakub Kicinski wrote: > On Fri, 27 Nov 2020 10:13:01 +0100 Marc Kleine-Budde wrote: >> On 10/26/20 4:36 PM, Krzysztof Kozlowski wrote: >>> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. >>> These are simple defines so they could be used in DTS but they w

[PATCH] net: flow_offload: remove trailing semicolon in macro definition

2020-11-28 Thread trix
From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- net/core/flow_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c index d4474c812b64..59ddfd3f3876 100644 --- a/net/core/flow_offloa

[PATCH] NFS: remove trailing semicolon in macro definition

2020-11-28 Thread trix
From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- net/sunrpc/auth_gss/gss_generic_token.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/auth_gss/gss_generic_token.c b/net/sunrpc/auth_gss/gss_generic_token.c index fe97f310653

Re: [PATCH net v2] net: openvswitch: fix TTL decrement action netlink message format

2020-11-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 24 Nov 2020 07:34:44 -0500 you wrote: > Currently, the openvswitch module is not accepting the correctly formated > netlink message for the TTL decrement action. For both setting and getting > the dec_ttl action, the act

[PATCH] mac80211: remove trailing semicolon in macro definition

2020-11-28 Thread trix
From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- net/mac80211/debugfs.c| 2 +- net/mac80211/debugfs_key.c| 2 +- net/mac80211/debugfs_netdev.c | 6 +++--- net/mac80211/debugfs_sta.c| 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) di

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-11-28 Thread Geoff Levand
On 11/26/20 8:59 AM, Uwe Kleine-König wrote: > The driver core ignores the return value of struct device_driver::remove > because there is only little that can be done. For the shutdown callback > it's ps3_system_bus_shutdown() which ignores the return value. > > To simplify the quest to make stru

Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

2020-11-28 Thread Geoff Levand
Hi Uwe, On 11/26/20 8:59 AM, Uwe Kleine-König wrote: > The remove callback is only called for devices that were probed > successfully before. As the matching probe function cannot complete > without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to > check this here. > > Signed-off-b

Re: pull-request: can 2020-11-27

2020-11-28 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Fri, 27 Nov 2020 11:02:55 +0100 you wrote: > Hello Jakub, hello David, > > here's a pull request of 6 patches for net/master. > > The first patch is by me and target the gs_usb driver and fixes the endianess > proble

[PATCH v13 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file

2020-11-28 Thread Hemant Kumar
Currently this macro is defined in internal MHI header as a TRE length mask. Moving it to external header allows MHI client drivers to set this upper bound for the transmit buffer size. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi

[PATCH v13 4/4] bus: mhi: Add userspace client interface driver

2020-11-28 Thread Hemant Kumar
This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device object which is associated to device file node. UCI device object instantiates UCI channel object when device file node is opened. UCI chan

[PATCH v13 3/4] docs: Add documentation for userspace client interface

2020-11-28 Thread Hemant Kumar
MHI userspace client driver is creating device file node for user application to perform file operations. File operations are handled by MHI core driver. Currently QMI MHI channel is supported by this driver. Signed-off-by: Hemant Kumar --- Documentation/mhi/index.rst | 1 + Documentation/mhi/u

KMSAN: uninit-value in validate_beacon_head

2020-11-28 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:73d62e81 kmsan: random: prevent boot-time reports in _mix_.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=164bda9550 kernel config: https://syzkaller.appspot.co

Re: [RFC iproute2] tc/mqprio: json-ify output

2020-11-28 Thread Luca Boccassi
On Sat, 2020-11-28 at 09:34 -0800, Stephen Hemminger wrote: > On Sat, 28 Nov 2020 12:17:00 + > Luca Boccassi wrote: > > > On Fri, 2020-11-27 at 21:21 -0800, Stephen Hemminger wrote: > > > On Fri, 27 Nov 2020 15:26:25 + > > > Luca Boccassi wrote: > > >   > > > > As reported by a Debian u

Re: [PATCH] can: don't count arbitration lose as an error

2020-11-28 Thread Oliver Hartkopp
On 27.11.20 12:09, Jeroen Hofstee wrote: Hi, On 11/27/20 11:30 AM, Marc Kleine-Budde wrote: On 11/27/20 10:59 AM, Jeroen Hofstee wrote: Losing arbitration is normal in a CAN-bus network, it means that a higher priority frame is being send and the pending message will be retried later. Hence

Re: [PATCH iproute2 v2] tc/mqprio: json-ify output

2020-11-28 Thread Luca Boccassi
On Sat, 2020-11-28 at 12:21 +, Luca Boccassi wrote: > As reported by a Debian user, mqprio output in json mode is > invalid: > > { > "kind": "mqprio", > "handle": "8021:", > "dev": "enp1s0f0", > "root": true, > "options": { tc 2 map 0 0 0 1 0 1 0 0 0 0 0 0 0 0 0 0 >   

Re: [PATCH net-next 2/4] net: dsa: Link aggregation support

2020-11-28 Thread Andrew Lunn
> > OK I think I finally see what you are saying. Sorry it took me this > > long. I do not mean to be difficult, I just want to understand. Not a problem. This is a bit different to normal, the complexity of the stack means you need to handle this different to most drivers. If you have done any de

Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

2020-11-28 Thread Takashi Iwai
On Thu, 26 Nov 2020 17:59:49 +0100, Uwe Kleine-König wrote: > > The remove callback is only called for devices that were probed > successfully before. As the matching probe function cannot complete > without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to > check this here. > > Sig

Re: [PATCH v2] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-11-28 Thread Jason A. Donenfeld
On Sat, Nov 28, 2020 at 9:48 AM Masahiro Yamada wrote: > > Revert commit cebc04ba9aeb ("add CONFIG_ENABLE_MUST_CHECK"). > > A lot of warn_unused_result wearings existed in 2006, but until now > they have been fixed thanks to people doing allmodconfig tests. > > Our goal is to always enable __must_

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-28 Thread Andrew Lunn
> +/* Add a potentially wrapping 32 bit value to a 64 bit counter */ > +static inline void sparx5_update_counter(u64 *cnt, u32 val) > +{ > + if (val < (*cnt & U32_MAX)) > + *cnt += (u64)1 << 32; /* value has wrapped */ > + > + *cnt = (*cnt & ~(u64)U32_MAX) + val; > +} I don't f

Re: [Patch stable] netfilter: clear skb->next in NF_HOOK_LIST()

2020-11-28 Thread Greg Kroah-Hartman
On Sat, Nov 28, 2020 at 05:09:18PM +0800, 刘志旭 wrote: > I still didn't see this patch in stable queue yet. Since we've a working POC > to panic the  > system (see https://bugzilla.kernel.org/show_bug.cgi?id=209823), I think it's > necessary > to merge this patch ASAP, thanks. Odd, I don't think S

[PATCH iproute2 v2] tc/mqprio: json-ify output

2020-11-28 Thread Luca Boccassi
As reported by a Debian user, mqprio output in json mode is invalid: { "kind": "mqprio", "handle": "8021:", "dev": "enp1s0f0", "root": true, "options": { tc 2 map 0 0 0 1 0 1 0 0 0 0 0 0 0 0 0 0 queues:(0:3) (4:7) mode:channel shaper:dcb} } j

[PATCH v2] PM: runtime: replace pm_runtime_resume_and_get with pm_runtime_resume_and_get_sync

2020-11-28 Thread Zhang Qilong
In the pm_runtime_resume_and_get, pm_runtime_resume() is synchronous. Caller had to look into the implementation to verify that a change for pm_runtime_resume_and_get [0]. So we use pm_rauntime_resume_and_get_sync to replace it to avoid making the same mistake while fixing pm_runtime_get_sync. [0]

Re: [PATCH net-next] netfilter: bridge: reset skb->pkt_type after NF_INET_POST_ROUTING traversal

2020-11-28 Thread Florian Westphal
Jakub Kicinski wrote: > On Mon, 23 Nov 2020 19:32:53 +0100 Florian Westphal wrote: > > That comment is 18 years old, safe bet noone thought of > > ipv6-in-tunnel-interface-added-as-bridge-port back then. > > > > Reviewed-by: Florian Westphal > > Sounds like a fix. Probably hard to pin point whi

[PATCH 2/2] can: kvaser_pciefd: Fix error handling in kvaser_pciefd_open

2020-11-28 Thread Zhang Qilong
If kvaser_pciefd_bus_on failed, we should call close_candev to avoid reference leak. Fixes: 26ad340e582d3 ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices") Signed-off-by: Zhang Qilong --- drivers/net/can/kvaser_pciefd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [PATCH net] ipv4: Fix tos mask in inet_rtm_getroute()

2020-11-28 Thread David Ahern
On 11/26/20 11:09 AM, Guillaume Nault wrote: > When inet_rtm_getroute() was converted to use the RCU variants of > ip_route_input() and ip_route_output_key(), the TOS parameters > stopped being masked with IPTOS_RT_MASK before doing the route lookup. > > As a result, "ip route get" can return a di

[PATCH 1/2] can: c_can: Fix error handling in c_can_power_up

2020-11-28 Thread Zhang Qilong
In the error handling in c_can_power_up, There are two bugs: 1) c_can_pm_runtime_get_sync will increase usage counter if device is not empty. Forgetting to call c_can_pm_runtime_put_sync will result in a reference leak here. 2) c_can_reset_ram operation will set start

[PATCH 0/2] can: Fix the error handling in c_can_power_up and kvaser_pciefd_open

2020-11-28 Thread Zhang Qilong
The patch series fix the error handling to avoid the reference leak and wrong state for the net device. Zhang Qilong (2): can: c_can: Fix error handling in c_can_power_up can: kvaser_pciefd: Fix error handling in kvaser_pciefd_open drivers/net/can/c_can/c_can.c | 18 ++ dri

Re: [PATCH v2 net-next 3/3] nfc: s3fwrn5: extract the common phy blocks

2020-11-28 Thread Krzysztof Kozlowski
On Fri, Nov 27, 2020 at 08:22:18PM +0900, bongsu.je...@gmail.com wrote: > From: Bongsu Jeon > > Extract the common phy blocks to reuse it. > The UART module will use the common blocks. > > Signed-off-by: Bongsu Jeon > --- > Changes in v2: > - remove the common function's definition in common h

Re: [RFC iproute2] tc/mqprio: json-ify output

2020-11-28 Thread Stephen Hemminger
On Sat, 28 Nov 2020 12:17:00 + Luca Boccassi wrote: > On Fri, 2020-11-27 at 21:21 -0800, Stephen Hemminger wrote: > > On Fri, 27 Nov 2020 15:26:25 + > > Luca Boccassi wrote: > > > > > As reported by a Debian user, mqprio output in json mode is > > > invalid: > > > > > > { > > >

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-11-28 Thread Takashi Iwai
On Thu, 26 Nov 2020 17:59:50 +0100, Uwe Kleine-König wrote: > > The driver core ignores the return value of struct device_driver::remove > because there is only little that can be done. For the shutdown callback > it's ps3_system_bus_shutdown() which ignores the return value. > > To simplify the

Re: [PATCH v12 1/5] bus: mhi: core: Add helper API to return number of free TREs

2020-11-28 Thread Greg Kroah-Hartman
On Sat, Nov 28, 2020 at 11:59:46AM +0530, Manivannan Sadhasivam wrote: > On Wed, Nov 18, 2020 at 10:32:45AM +0100, Loic Poulain wrote: > > On Mon, 16 Nov 2020 at 23:46, Hemant Kumar wrote: > > > > > > Introduce mhi_get_free_desc_count() API to return number > > > of TREs available to queue buffer.

Re: [PATCH v12 1/5] bus: mhi: core: Add helper API to return number of free TREs

2020-11-28 Thread Manivannan Sadhasivam
On Wed, Nov 18, 2020 at 10:32:45AM +0100, Loic Poulain wrote: > On Mon, 16 Nov 2020 at 23:46, Hemant Kumar wrote: > > > > Introduce mhi_get_free_desc_count() API to return number > > of TREs available to queue buffer. MHI clients can use this > > API to know before hand if ring is full without cal

Я смиренно ищу ваш ответ на мое предыдущее письмо. Спасибо.

2020-11-28 Thread Edwin Clark
Я смиренно ищу ваш ответ на мое предыдущее письмо. Спасибо.

Re: [PATCH v13 4/4] bus: mhi: Add userspace client interface driver

2020-11-28 Thread Manivannan Sadhasivam
Hi Hemant, On Fri, Nov 27, 2020 at 07:26:06PM -0800, Hemant Kumar wrote: > This MHI client driver allows userspace clients to transfer > raw data between MHI device and host using standard file operations. > Driver instantiates UCI device object which is associated to device > file node. UCI devic

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-28 Thread Andrew Lunn
> +static int sparx5_port_open(struct net_device *ndev) > +{ > + struct sparx5_port *port = netdev_priv(ndev); > + int err = 0; > + > + sparx5_port_enable(port, true); > + if (port->conf.phy_mode != PHY_INTERFACE_MODE_NA) { > + err = phylink_of_phy_connect(port->phylink,

Re: [PATCH net] net: dsa: reference count the host mdb addresses

2020-11-28 Thread Tobias Waldekranz
On Sat, Nov 28, 2020 at 00:27, Vladimir Oltean wrote: > On Sat, Nov 28, 2020 at 12:58:10AM +0100, Tobias Waldekranz wrote: >> That sounds like a good idea. We have run into another issue with the >> MDB that maybe could be worked into this changeset. This is what we have >> observed on 4.19, but f

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-28 Thread Andrew Lunn
> +static void sparx5_phylink_mac_config(struct phylink_config *config, > + unsigned int mode, > + const struct phylink_link_state *state) > +{ > + struct sparx5_port *port = netdev_priv(to_net_dev(config->dev)); > + struct

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-28 Thread Andrew Lunn
> > Maybe if I was copied on the patch submission... I don't have the > > patches, and searching google for them is a faff, especially > > when > > > > site:kernel.org 20201127133307.2969817-1-steen.hegel...@microchip.com > > > > gives: > > > >Your search - site:kernel.org > >20201127133

Re: [PATCH net-next v6 08/14] net/smc: Introduce generic netlink interface for diagnostic purposes

2020-11-28 Thread Jakub Kicinski
On Thu, 26 Nov 2020 21:39:10 +0100 Karsten Graul wrote: > +/* SMC_GENL family definition */ > +struct genl_family smc_gen_nl_family __ro_after_init = { > + .hdrsize = 0, > + .name = SMC_GENL_FAMILY_NAME, > + .version = SMC_GENL_FAMILY_VERSION, > + .maxattr = SMC_GEN_MAX, > + .ne

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-28 Thread Alexandre Belloni
Hi Russell, On 28/11/2020 19:37:07+, Russell King - ARM Linux admin wrote: > On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote: > > > +static void sparx5_phylink_mac_config(struct phylink_config *config, > > > + unsigned int mode, > > > +

Re: [PATCH 0/3] pull request for net: batman-adv 2020-11-27

2020-11-28 Thread Jakub Kicinski
On Fri, 27 Nov 2020 18:38:46 +0100 Simon Wunderlich wrote: > here are some more bugfixes for batman-adv which we would like to have > integrated into net. > > Please pull or let me know of any problem!> > > Here are some batman-adv

Re: [PATCH net-next 2/4] net: dsa: Link aggregation support

2020-11-28 Thread Tobias Waldekranz
On Sat Nov 28, 2020 at 6:38 PM CET, Andrew Lunn wrote: > > > OK I think I finally see what you are saying. Sorry it took me this > > > long. I do not mean to be difficult, I just want to understand. > > Not a problem. This is a bit different to normal, the complexity of > the stack means you need t

Re: [PATCH net-next 0/6] net: ipa: start adding IPA v4.5 support

2020-11-28 Thread Jakub Kicinski
On Wed, 25 Nov 2020 14:45:16 -0600 Alex Elder wrote: > This series starts updating the IPA code to support IPA hardware > version 4.5. > > The first patch fixes a problem found while preparing these updates. > Testing shows the code works with or without the change, and with > the fix the code mat

Re: [PATCH net-next] netfilter: bridge: reset skb->pkt_type after NF_INET_POST_ROUTING traversal

2020-11-28 Thread Jakub Kicinski
On Sat, 28 Nov 2020 10:59:29 +0100 Florian Westphal wrote: > Jakub Kicinski wrote: > > On Mon, 23 Nov 2020 19:32:53 +0100 Florian Westphal wrote: > > > That comment is 18 years old, safe bet noone thought of > > > ipv6-in-tunnel-interface-added-as-bridge-port back then. > > > > > > Reviewed-by:

Re: [PATCH net-next] net/sched: act_ct: enable stats for HW offloaded entries

2020-11-28 Thread Jakub Kicinski
On Fri, 27 Nov 2020 23:31:44 -0300 Marcelo Ricardo Leitner wrote: > On Fri, Nov 27, 2020 at 06:00:32PM -0800, Jakub Kicinski wrote: > > On Thu, 26 Nov 2020 15:40:49 -0300 Marcelo Ricardo Leitner wrote: > > > By setting NF_FLOWTABLE_COUNTER. Otherwise, the updates added by > > > commit ef803b3cf96

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-28 Thread Russell King - ARM Linux admin
On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote: > > +static void sparx5_phylink_mac_config(struct phylink_config *config, > > + unsigned int mode, > > + const struct phylink_link_state *state) > > +{ > > + struct sparx5_

Re: [PATCH] powerpc: fix the allyesconfig build

2020-11-28 Thread Jakub Kicinski
On Sat, 28 Nov 2020 16:20:54 +1100 Stephen Rothwell wrote: > On Fri, 27 Nov 2020 17:56:42 -0800 Jakub Kicinski wrote: > > > > What's the offending structure in hisilicon? I'd rather have a look > > packing structs with pointers in 'em sounds questionable. > > > > I only see these two: > > > > $

[PATCH 1/2] selftests/bpf: Avoid errno clobbering

2020-11-28 Thread Florian Lehner
Commit 8184d44c9a57 ("selftests/bpf: skip verifier tests for unsupported program types") added a check to skip unsupported program types. As bpf_probe_prog_type can change errno, do_single_test should save it before printing a reason why a supported BPF program type failed to load. Fixes: 8184d44c

Re: [RFC iproute2] tc/mqprio: json-ify output

2020-11-28 Thread Luca Boccassi
On Fri, 2020-11-27 at 21:21 -0800, Stephen Hemminger wrote: > On Fri, 27 Nov 2020 15:26:25 + > Luca Boccassi wrote: > > > As reported by a Debian user, mqprio output in json mode is > > invalid: > > > > { > > "kind": "mqprio", > > "handle": "8021:", > > "dev": "enp1s0f0", > >

[PATCH 2/2] selftests/bpf: Print reason when a tester could not run a program

2020-11-28 Thread Florian Lehner
Print a message when the returned error is about a program type being not supported or because of permission problems. These messages are expected if the program to test was actually executed. Cc: Krzesimir Nowak Signed-off-by: Florian Lehner --- tools/testing/selftests/bpf/test_verifier.c | 24

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-28 Thread Andrew Lunn
> +static void sparx5_attr_stp_state_set(struct sparx5_port *port, > + struct switchdev_trans *trans, > + u8 state) > +{ > + struct sparx5 *sparx5 = port->sparx5; > + > + if (!test_bit(port->portno, sparx5->bridge_mask)) {

[PATCH 0/2] Improve error handling of verifier tests

2020-11-28 Thread Florian Lehner
These patches improve the error handling for verifier tests. With "Test the 32bit narrow read" Krzesimir Nowak provided these patches first, but they were never merged. The improved error handling helps to implement and test BPF program types that are not supported yet. Florian Lehner (2): selft

[PATCH iproute2 v2] tc/mqprio: json-ify output

2020-11-28 Thread Luca Boccassi
As reported by a Debian user, mqprio output in json mode is invalid: { "kind": "mqprio", "handle": "8021:", "dev": "enp1s0f0", "root": true, "options": { tc 2 map 0 0 0 1 0 1 0 0 0 0 0 0 0 0 0 0 queues:(0:3) (4:7) mode:channel shaper:dcb} } j

Re: [PATCH net-next 3/3] nfc: s3fwrn5: extract the common phy blocks

2020-11-28 Thread Krzysztof Kozlowski
On Fri, Nov 27, 2020 at 08:09:24AM +0900, Bongsu Jeon wrote: > On Fri, Nov 27, 2020 at 2:13 AM Krzysztof Kozlowski wrote: > > > > On Fri, Nov 27, 2020 at 12:33:39AM +0900, bongsu.je...@gmail.com wrote: > > > From: Bongsu Jeon > > > > > > Extract the common phy blocks to reuse it. > > > The UART m

Re: [PATCH net-next v6 09/14] net/smc: Add support for obtaining system information

2020-11-28 Thread Jakub Kicinski
On Thu, 26 Nov 2020 21:39:11 +0100 Karsten Graul wrote: > + attrs = nla_nest_start_noflag(skb, SMC_GEN_SYS_INFO); Missed this, nla_nest_start(), the _noflag() is for legacy code. New families should not use it.

Re: pull-request: bpf 2020-11-28

2020-11-28 Thread Jakub Kicinski
On Sat, 28 Nov 2020 01:51:04 +0100 Daniel Borkmann wrote: > 1) Do not reference the skb for xsk's generic TX side since when looped >back into RX it might crash in generic XDP, from Björn Töpel. > > 2) Fix umem cleanup on a partially set up xsk socket when being destroyed, >from Magnus Kar

Re: [PATCH net-next] selftests: tc-testing: enable CONFIG_NET_SCH_RED as a module

2020-11-28 Thread Jakub Kicinski
On Thu, 26 Nov 2020 19:47:47 +0100 Davide Caratti wrote: > a proper kernel configuration for running kselftest can be obtained with: > > $ yes | make kselftest-merge > > enable compile support for the 'red' qdisc: otherwise, tdc kselftest fail > when trying to run tdc test items contained in red

Re: [PATCH net] ipv4: Fix tos mask in inet_rtm_getroute()

2020-11-28 Thread Jakub Kicinski
On Sat, 28 Nov 2020 10:03:42 -0700 David Ahern wrote: > On 11/26/20 11:09 AM, Guillaume Nault wrote: > > When inet_rtm_getroute() was converted to use the RCU variants of > > ip_route_input() and ip_route_output_key(), the TOS parameters > > stopped being masked with IPTOS_RT_MASK before doing the

Re: [PATCH net 0/5] Netfilter fixes for net

2020-11-28 Thread Jakub Kicinski
On Fri, 27 Nov 2020 20:03:08 +0100 Pablo Neira Ayuso wrote: > 1) Fix insufficient validation of IPSET_ATTR_IPADDR_IPV6 reported >by syzbot. > > 2) Remove spurious reports on nf_tables when lockdep gets disabled, >from Florian Westphal. > > 3) Fix memleak in the error path of error path of

Re: [PATCH net v3 0/9] ibmvnic: assorted bug fixes

2020-11-28 Thread Jakub Kicinski
On Wed, 25 Nov 2020 18:04:23 -0600 Dany Madden wrote: > Assorted fixes for ibmvnic originated from "[PATCH net 00/15] ibmvnic: > assorted bug fixes" sent by Lijun Pan. Applied, thanks!

[PATCH v4] vdpa: mlx5: fix vdpa/vhost dependencies

2020-11-28 Thread Randy Dunlap
drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so select VHOST_IOTLB to make them be built. However, if VHOST_IOTLB is the only VHOST symbol that is set/enabled, the object file still won't be built because drivers/Makefile won't descend into drivers/vhost/ to build it, so make drivers/Makefil

[PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-11-28 Thread Masahiro Yamada
Revert commit cebc04ba9aeb ("add CONFIG_ENABLE_MUST_CHECK"). A lot of warn_unused_result warnings existed in 2006, but until now they have been fixed thanks to people doing allmodconfig tests. Our goal is to always enable __must_check where appropriate, so this CONFIG option is no longer needed.

Re: pull-request: can 2020-11-27

2020-11-28 Thread Jakub Kicinski
On Fri, 27 Nov 2020 11:02:55 +0100 Marc Kleine-Budde wrote: > The first patch is by me and target the gs_usb driver and fixes the endianess > problem with candleLight firmware. > > Another patch by me for the mcp251xfd driver add sanity checking to bail out > if > no IRQ is configured. > > The n

[PATCH V2 net-next 5/7] net: hns3: add more info to hns3_dbg_bd_info()

2020-11-28 Thread Huazhong Tan
Since TX hardware checksum and RX completion checksum have been supported now, so add related information in hns3_dbg_bd_info(). Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 50 +- 1 file changed, 40 insertions(+), 10 deletions(-) diff

[PATCH V2 net-next 4/7] net: hns3: add udp tunnel checksum segmentation support

2020-11-28 Thread Huazhong Tan
For the device who has the capability to handle udp tunnel checksum segmentation, add support for it. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 1 + drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 6 +- drivers/net/ethernet/hisilicon/hns3/hns

[PATCH V2 net-next 2/7] net: hns3: add support for TX hardware checksum offload

2020-11-28 Thread Huazhong Tan
For the device that supports TX hardware checksum, the hardware can calculate the checksum from the start and fill the checksum to the offset position, which reduces the operations of calculating the type and header length of L3/L4. So add this feature for the HNS3 ethernet driver. The previous si

Re: [RFC iproute2] tc/mqprio: json-ify output

2020-11-28 Thread Stephen Hemminger
On Fri, 27 Nov 2020 15:26:25 + Luca Boccassi wrote: > As reported by a Debian user, mqprio output in json mode is > invalid: > > { > "kind": "mqprio", > "handle": "8021:", > "dev": "enp1s0f0", > "root": true, > "options": { tc 2 map 0 0 0 1 0 1 0 0 0 0 0 0 0 0 0 0 >

[PATCH V2 net-next 7/7] net: hns3: keep MAC pause mode when multiple TCs are enabled

2020-11-28 Thread Huazhong Tan
From: Yonglong Liu Bellow HNAE3_DEVICE_VERSION_V3, MAC pause mode just support one TC, when enabled multiple TCs, force enable PFC mode. HNAE3_DEVICE_VERSION_V3 can support MAC pause mode on multiple TCs, so when enable multiple TCs, just keep MAC pause mode, and enable PFC mode just according t

[PATCH V2 net-next 3/7] net: hns3: remove unsupported NETIF_F_GSO_UDP_TUNNEL_CSUM

2020-11-28 Thread Huazhong Tan
Currently, device V1 and V2 do not support segmentation offload for UDP based tunnel packet who needs outer UDP checksum offload, so there is a workaround in the driver to set the checksum of the outer UDP checksum as zero. This is not what the user wants, so remove this feature for device V1 and V

[PATCH v2] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-11-28 Thread Masahiro Yamada
Revert commit cebc04ba9aeb ("add CONFIG_ENABLE_MUST_CHECK"). A lot of warn_unused_result wearings existed in 2006, but until now they have been fixed thanks to people doing allmodconfig tests. Our goal is to always enable __must_check where appropriate, so this CONFIG option is no longer needed.

Re: [PATCH] powerpc: fix the allyesconfig build

2020-11-28 Thread Stephen Rothwell
Hi Jakub, On Fri, 27 Nov 2020 17:56:42 -0800 Jakub Kicinski wrote: > > What's the offending structure in hisilicon? I'd rather have a look > packing structs with pointers in 'em sounds questionable. > > I only see these two: > > $ git grep packed drivers/net/ethernet/hisilicon/ > drivers/net/et

Re: [PATCH net-next 2/4] net: dsa: Link aggregation support

2020-11-28 Thread Florian Fainelli
On 11/27/2020 3:19 PM, Tobias Waldekranz wrote: >> The initial design of switchdev was transactions. First there was a >> prepare call, where you validated the requested action is possible, >> and allocate resources needed, but don't actually do it. This prepare >> call is allowed to fail. Then

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-28 Thread Florian Fainelli
On 11/27/2020 4:33 PM, Lukasz Majewski wrote: >> So why use DSA at all? What benefit does it bring you? Why not do the >> entire switch configuration from within FEC, or a separate driver very >> closely related to it? > > Mine rationale to use DSA and FEC: > - Make as little changes to FEC as

[PATCH V2 net-next 1/7] net: hns3: add support for RX completion checksum

2020-11-28 Thread Huazhong Tan
In some cases (for example ip fragment), hardware will calculate the checksum of whole packet in RX, and setup the HNS3_RXD_L2_CSUM_B flag in the descriptor, so add support to utilize this checksum. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 21 +

[PATCH V2 net-next 6/7] net: hns3: add a check for devcie's verion in hns3_tunnel_csum_bug()

2020-11-28 Thread Huazhong Tan
For the device whose version is above V3(include V3), the hardware can do checksum offload for the non-tunnel udp packet, who has a dest port as the IANA assigned. So add a check for devcie's verion in hns3_tunnel_csum_bug(). Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hn