> +static void sparx5_phylink_mac_config(struct phylink_config *config,
> + unsigned int mode,
> + const struct phylink_link_state *state)
> +{
> + struct sparx5_port *port = netdev_priv(to_net_dev(config->dev));
> + struct sparx5_port_config conf;
> + int err = 0;
> +
> + conf = port->conf;
> + conf.autoneg = state->an_enabled;
> + conf.pause = state->pause;
> + conf.duplex = state->duplex;
> + conf.power_down = false;
> + conf.portmode = state->interface;
> +
> + if (state->speed == SPEED_UNKNOWN) {
> + /* When a SFP is plugged in we use capabilities to
> + * default to the highest supported speed
> + */
This looks suspicious.
Russell, please could you look through this?
Andrew
