Re: [EXT] Re: Fwd: net: fec: rx descriptor ring out of order

2020-11-19 Thread Kegl Rohit
On Sun, Nov 15, 2020 at 8:48 AM Andy Duan wrote: > > From: Kegl Rohit Sent: Sunday, November 15, 2020 1:37 AM > > On Sat, Nov 14, 2020 at 2:58 AM Andy Duan wrote: > > > > > > From: Kegl Rohit Sent: Friday, November 13, 2020 > > > 8:21 PM > > > > On Fri, Nov 13, 2020 at 8:33 AM Kegl Rohit wrote

Re: [EXT] [PATCH] aquantia: Remove the build_skb path

2020-11-19 Thread Igor Russkikh
On 20/11/2020 1:01 am, Ramsay, Lincoln wrote: > External Email > > -- > The build_skb path fails to allow for an SKB header, but the hardware > buffer it is built around won't allow for this anyway. > > Just always use the slo

[PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-19 Thread xiakaixu1987
From: Kaixu Xia The body of the if statement can be executed only when the variable vlan_count equals to 32, so the condition of the while statement can not be true and the while statement is dead code. Remove it. Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- drivers/net/ethernet/adapt

[PATCH net] bnxt_en: Release PCI regions when DMA mask setup fails during probe.

2020-11-19 Thread Michael Chan
Jump to init_err_release to cleanup. bnxt_unmap_bars() will also be called but it will do nothing if the BARs are not mapped yet. Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") Reported-by: Jakub Kicinski Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c

RE: [EXT] Re: [RFC, net-next] net: qos: introduce a redundancy flow action

2020-11-19 Thread Xiaoliang Yang
Hi Jamal, On 2020-11-19 0:11, Jamal Hadi Salim wrote: > The 11/17/2020 14:30, Xiaoliang Yang wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you >> know the content is safe >> >> This patch introduce a redundancy flow action to implement frame >> replication and eliminati

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread Michal Kubecek
On Fri, Nov 20, 2020 at 10:59:59AM +0800, tanhuazhong wrote: > On 2020/11/20 6:02, Michal Kubecek wrote: > > > > We could use a similar approach as struct ethtool_link_ksettings, e.g. > > > > struct kernel_ethtool_coalesce { > > struct ethtool_coalesce base; > > /* new

Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_board()

2020-11-19 Thread Michael Chan
On Thu, Nov 19, 2020 at 9:53 PM Jakub Kicinski wrote: > > On Thu, 19 Nov 2020 10:53:23 -0800 Edwin Peer wrote: > > > Fix to return a negative error code from the error handling > > > case instead of 0, as done elsewhere in this function. > > > > > > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethe

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Joe Perches
On Thu, 2020-11-19 at 21:21 -0800, Jakub Kicinski wrote: > We do have our own comment style rule in networking since the beginning > of time, and reverse xmas tree, so it's not completely crazy. reverse xmas tree is completely crazy. But I posted a patch to checkpatch to suggest it for net/ and d

Re: Wifi hangs

2020-11-19 Thread Coelho, Luciano
Adding Guy Damary Guy, can you help with this one? I believe there is a bugzilla issue for this already... -- Cheers, Luca. On Thu, 2020-11-19 at 17:42 +0100, Gonsolo wrote: > Hi! > > Sporadically my wifi hangs. Any idea why? > This is on a 5.10.0-051000rc2-lowlatency kernel from > https://ker

Re: [PATCH] cxbgb4: Fix build failure when CHELSIO_TLS_DEVICE=n

2020-11-19 Thread Tom Seewald
On Thu, Nov 19, 2020 at 11:37 AM Jakub Kicinski wrote: > > On Wed, 18 Nov 2020 23:40:40 -0600 Tom Seewald wrote: > > On Tue, Nov 17, 2020 at 4:26 PM Jakub Kicinski wrote: > > > > > > On Sun, 15 Nov 2020 20:31:40 -0600 Tom Seewald wrote: > > > > After commit 9d2e5e9eeb59 ("cxgb4/ch_ktls: decrypted

Re: [PATCH net-next v2] net: openvswitch: Be liberal in tcp conntrack.

2020-11-19 Thread Florian Westphal
Jakub Kicinski wrote: > On Mon, 16 Nov 2020 18:31:26 +0530 nusid...@redhat.com wrote: > > From: Numan Siddique > > > > There is no easy way to distinguish if a conntracked tcp packet is > > marked invalid because of tcp_in_window() check error or because > > it doesn't belong to an existing conn

[PATCHv3 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-19 Thread George Cherian
Add health reporters for RVU NPA block. NPA Health reporters handle following HW event groups - GENERAL events - ERROR events - RAS events - RVU event An event counter per event is maintained in SW. Output: # devlink health pci/0002:01:00.0: reporter npa state healthy error 0 recover

[PATCHv3 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-19 Thread George Cherian
Add health reporters for RVU NIX block. NIX Health reporter handle following HW event groups - GENERAL events - RAS events - RVU event An event counter per event is maintained in SW. Output: # ./devlink health pci/0002:01:00.0: reporter npa state healthy error 0 recover 0 reporter

[PATCHv3 net-next 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-11-19 Thread George Cherian
Add devlink support to AF driver. Basic devlink support is added. Currently info_get is the only supported devlink ops. devlink ouptput looks like this # devlink dev pci/0002:01:00.0 # devlink dev info pci/0002:01:00.0: driver octeontx2-af versions: fixed: mbox version: 9 Si

[PATCHv3 net-next 0/3] Add devlink and devlink health reporters to

2020-11-19 Thread George Cherian
Add basic devlink and devlink health reporters. Devlink health reporters are added for NPA and NIX blocks. These reporters report the error count in respective blocks. Address Jakub's comment to add devlink support for error reporting. https://www.spinics.net/lists/netdev/msg670712.html Change-lo

[RFC V2 net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread Huazhong Tan
Since the information whether the adaptive behavior is implemented by DIM or driver custom is useful, so add new attribute to ETHTOOL_MSG_COALESCE_GET/ETHTOOL_MSG_COALESCE_SET commands to control the type of adaptive coalescing. In order to compatible with ioctl code, add a extended coalescing han

[RFC V2 net-next 2/2] net: hns3: add support for dynamic interrupt moderation

2020-11-19 Thread Huazhong Tan
Add dynamic interrupt moderation support for the HNS3 driver, and add ethtool support for controlling the type of adaptive. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/Kconfig | 1 + drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 87 +- d

[RFC V2 net-next 0/2] net: updates for -next

2020-11-19 Thread Huazhong Tan
#2 will add DIM for the HNS3 ethernet driver, then there will be two implemation of IRQ adaptive coalescing (DIM and driver custiom, so #1 adds a new netlink attribute to the ETHTOOL_MSG_COALESCE_GET/ETHTOOL_MSG_COALESCE_SET commands which controls the type of adaptive coalescing. change log: V2:

Re: [PATCH] net: qrtr: Unprepare MHI channels during remove

2020-11-19 Thread Manivannan Sadhasivam
On Thu, Nov 19, 2020 at 10:18:28PM -0800, Jakub Kicinski wrote: > On Fri, 20 Nov 2020 11:45:12 +0530 Manivannan Sadhasivam wrote: > > Jakub, can you please provide your ack so that I can take it? > > Sure: > > Acked-by: Jakub Kicinski Patch applied to mhi-ath11k-immutable. Thanks, Mani

Re: [PATCH] net: qrtr: Unprepare MHI channels during remove

2020-11-19 Thread Jakub Kicinski
On Fri, 20 Nov 2020 11:45:12 +0530 Manivannan Sadhasivam wrote: > Jakub, can you please provide your ack so that I can take it? Sure: Acked-by: Jakub Kicinski

Re: [PATCH] net: qrtr: Unprepare MHI channels during remove

2020-11-19 Thread Manivannan Sadhasivam
On Thu, Nov 19, 2020 at 09:10:46PM -0800, Jakub Kicinski wrote: > On Wed, 18 Nov 2020 10:20:25 -0800 Bhaumik Bhatt wrote: > > Reset MHI device channels when driver remove is called due to > > module unload or any crash scenario. This will make sure that > > MHI channels no longer remain enabled for

Re: [PATCH v12 5/5] selftest: mhi: Add support to test MHI LOOPBACK channel

2020-11-19 Thread Manivannan Sadhasivam
On Mon, Nov 16, 2020 at 02:46:22PM -0800, Hemant Kumar wrote: > Loopback test opens the MHI device file node and writes > a data buffer to it. MHI UCI kernel space driver copies > the data and sends it to MHI uplink (Tx) LOOPBACK channel. > MHI device loops back the same data to MHI downlink (Rx) >

Re: [PATCH v4] IPv6: RTM_GETROUTE: Add RTA_ENCAP to result

2020-11-19 Thread Jakub Kicinski
On Wed, 18 Nov 2020 17:29:52 -0700 David Ahern wrote: > On 11/18/20 4:06 PM, Oliver Herms wrote: > > This patch adds an IPv6 routes encapsulation attribute > > to the result of netlink RTM_GETROUTE requests > > (i.e. ip route get 2001:db8::). > > > > Signed-off-by: Oliver Herms > > --- > > net/i

Re: [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if required.

2020-11-19 Thread Jakub Kicinski
On Thu, 19 Nov 2020 19:49:16 +0530 Naresh Kamboju wrote: > > > We must start the retransmission timer only there are > > > pending data in the rtx queue. > > > Otherwise we can hit a WARN_ON in mptcp_reset_timer(), > > > as syzbot demonstrated. > > > > > > Reported-and-tested-by: > > > syzbot+42aa

Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_one()

2020-11-19 Thread Jakub Kicinski
On Thu, 19 Nov 2020 10:53:47 -0800 Edwin Peer wrote: > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Fixes: c213eae8d3cd ("bnxt_en: Improve VF/PF link change logic.") > > Reported-by: Hulk Robot > > Signed-off-by: Z

Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_board()

2020-11-19 Thread Jakub Kicinski
On Thu, 19 Nov 2020 10:53:23 -0800 Edwin Peer wrote: > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") > > Reported-by: Hulk Robot > > Signed-off-by: Zhan

[PATCH net-next v4 5/5] net/x25: remove x25_kill_by_device()

2020-11-19 Thread Martin Schiller
Remove obsolete function x25_kill_by_device(). It's not used any more. Signed-off-by: Martin Schiller --- net/x25/af_x25.c | 16 1 file changed, 16 deletions(-) diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c index 313a6222ded9..1432a05805ab 100644 --- a/net/x25/af_x25.c +++ b

Re: [net-next v4 0/2] devlink: move common flash_update calls to core

2020-11-19 Thread Jakub Kicinski
On Wed, 18 Nov 2020 11:06:34 -0800 Jacob Keller wrote: > This series moves a couple common pieces done by all drivers of the > ->flash_update interface into devlink.c flash update handler. Specifically, > the core code will now request_firmware and > devlink_flash_update_(begin|end)_notify. > >

[PATCH net-next v4 4/5] net/x25: fix restart request/confirm handling

2020-11-19 Thread Martin Schiller
We have to take the actual link state into account to handle restart requests/confirms well. Signed-off-by: Martin Schiller --- net/x25/x25_link.c | 41 + 1 file changed, 33 insertions(+), 8 deletions(-) diff --git a/net/x25/x25_link.c b/net/x25/x25_link.

[PATCH net-next v4 3/5] net/lapb: fix t1 timer handling for LAPB_STATE_0

2020-11-19 Thread Martin Schiller
1. DTE interface changes immediately to LAPB_STATE_1 and start sending SABM(E). 2. DCE interface sends N2-times DM and changes to LAPB_STATE_1 afterwards if there is no response in the meantime. Signed-off-by: Martin Schiller --- net/lapb/lapb_timer.c | 11 +-- 1 file changed, 9 i

[PATCH net-next v4 2/5] net/lapb: support netdev events

2020-11-19 Thread Martin Schiller
This patch allows layer2 (LAPB) to react to netdev events itself and avoids the detour via layer3 (X.25). 1. Call lapb_disconnect_request() on NETDEV_GOING_DOWN events. 2. When a NETDEV_DOWN event occur, clear all queues, enter state LAPB_STATE_0 and stop all timers. 3. The NETDEV_CHANGE even

[PATCH net-next v4 1/5] net/x25: handle additional netdev events

2020-11-19 Thread Martin Schiller
1. Add / remove x25_link_device by NETDEV_REGISTER/UNREGISTER and also by NETDEV_POST_TYPE_CHANGE/NETDEV_PRE_TYPE_CHANGE. This change is needed so that the x25_neigh struct for an interface is already created when it shows up and is kept independently if the interface goes UP or DOWN.

[PATCH net-next v4 0/5] net/x25: netdev event handling

2020-11-19 Thread Martin Schiller
--- Changes to v3: o another complete rework of the patch-set to split event handling for layer2 (LAPB) and layer3 (X.25) Changes to v2: o restructure complete patch-set o keep netdev event handling in layer3 (X.25) o add patch to fix lapb_connect_request() for DCE o add patch to handle carrier

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Jakub Kicinski
On Thu, 19 Nov 2020 23:09:52 +0100 Heiner Kallweit wrote: > Am 19.11.2020 um 22:41 schrieb Andrew Lunn: > Doesn't checkpatch complain about line length > 80 here? > >>> > >>> :) > >>> > >>> commit bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > >>> Author: Joe Perches > >>> Date:   Fri May 29 16

Re: [PATCH] net: qrtr: Unprepare MHI channels during remove

2020-11-19 Thread Jakub Kicinski
On Wed, 18 Nov 2020 10:20:25 -0800 Bhaumik Bhatt wrote: > Reset MHI device channels when driver remove is called due to > module unload or any crash scenario. This will make sure that > MHI channels no longer remain enabled for transfers since the > MHI stack does not take care of this anymore afte

Re: [PATCH net-next v2] net: openvswitch: Be liberal in tcp conntrack.

2020-11-19 Thread Jakub Kicinski
On Mon, 16 Nov 2020 18:31:26 +0530 nusid...@redhat.com wrote: > From: Numan Siddique > > There is no easy way to distinguish if a conntracked tcp packet is > marked invalid because of tcp_in_window() check error or because > it doesn't belong to an existing connection. With this patch, > openvswi

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

2020-11-19 Thread Jakub Kicinski
On Thu, 19 Nov 2020 19:55:08 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > On Thu, Nov 19, 2020 at 12:03 AM Nicolas Dichtel > > Le 18/11/2020 à 18:39, Mahesh Bandewar (महेश बंडेवार) a écrit : > > > netns but would create problems for workloads that create netns to > > > disable networking. One ca

Re: [PATCH v4 net-next 0/3] add support for sending RFC8335 PROBE

2020-11-19 Thread David Ahern
On 11/19/20 8:51 PM, David Ahern wrote: > On 11/17/20 5:46 PM, Andreas Roeseler wrote: >> The popular utility ping has several severe limitations such as the >> inability to query specific interfaces on a node and requiring >> bidirectional connectivity between the probing and the probed >> interf

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

2020-11-19 Thread महेश बंडेवार
On Thu, Nov 19, 2020 at 12:03 AM Nicolas Dichtel wrote: > > Le 18/11/2020 à 18:39, Mahesh Bandewar (महेश बंडेवार) a écrit : > > On Wed, Nov 18, 2020 at 8:58 AM Nicolas Dichtel > > wrote: > >> > >> Le 18/11/2020 à 02:12, David Ahern a écrit : > >> [snip] > >>> If there is no harm in just creating

Re: [PATCH v4 net-next 0/3] add support for sending RFC8335 PROBE

2020-11-19 Thread David Ahern
On 11/17/20 5:46 PM, Andreas Roeseler wrote: > The popular utility ping has several severe limitations such as the > inability to query specific interfaces on a node and requiring > bidirectional connectivity between the probing and the probed > interfaces. RFC8335 attempts to solve these limitati

RE: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Friday, November 20, 2020 9:05 AM > > On Thu, 19 Nov 2020 10:00:17 -0400 Jason Gunthorpe wrote: > > Finally, in the mlx5 model VDPA is just an "application". It asks the > > device to create a 'RDMA' raw ethernet packet QP that is uses rings > > formed in the virtio

Re: [RFC PATCH net-next] net: dsa: mt7530: support setting ageing time

2020-11-19 Thread DENG Qingfang
On Fri, Nov 20, 2020 at 10:26 AM Andrew Lunn wrote: > The bridge code will default to 300 seconds. And after a topology > change, it sets it to 2 * the forwarding delay, which defaults to 15 > seconds. So maybe you can look for these two values, and use > pre-computed values? 15 and 300 are not l

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Jakub Kicinski
On Thu, 19 Nov 2020 10:00:17 -0400 Jason Gunthorpe wrote: > Finally, in the mlx5 model VDPA is just an "application". It asks the > device to create a 'RDMA' raw ethernet packet QP that is uses rings > formed in the virtio-net specification. We can create it in the kernel > using mlx5_vdpa, and we

RE: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Friday, November 20, 2020 7:05 AM > > On Wed, 18 Nov 2020 22:12:22 -0800 Saeed Mahameed wrote: > > > Right, devices of other subsystems are fine, I don't care. > > > > But a netdev will be loaded on SF automatically just through the > > current driver design and m

Re: [PATCH bpf-next 4/6] libbpf: add kernel module BTF support for CO-RE relocations

2020-11-19 Thread Andrii Nakryiko
On Thu, Nov 19, 2020 at 6:14 PM Maciej Fijalkowski wrote: > > On Thu, Nov 19, 2020 at 05:24:43PM -0800, Andrii Nakryiko wrote: > > On Thu, Nov 19, 2020 at 4:55 PM Maciej Fijalkowski > > wrote: > > > > > > On Thu, Nov 19, 2020 at 03:22:42PM -0800, Andrii Nakryiko wrote: > > > > Teach libbpf to sea

Re: [GIT PULL] Networking

2020-11-19 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Thu, 19 Nov 2020 13:15:31 -0800 you wrote: > The following changes since commit db7c953555388571a96ed8783ff6c5745ba18ab9: > > Merge tag 'net-5.10-rc4' of > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (

[net] net/packet: fix incoming receive for L3 devices without visible hard header

2020-11-19 Thread Eyal Birger
In the patchset merged by commit b9fcf0a0d826 ("Merge branch 'support-AF_PACKET-for-layer-3-devices'") L3 devices which did not have header_ops were given one for the purpose of protocol parsing on af_packet transmit path. That change made af_packet receive path regard these devices as having a vi

Re: [PATCH] lsm,selinux: pass flowi_common instead of flowi to the LSM hooks

2020-11-19 Thread James Morris
On Thu, 19 Nov 2020, Paul Moore wrote: > As pointed out by Herbert in a recent related patch, the LSM hooks do > not have the necessary address family information to use the flowi > struct safely. As none of the LSMs currently use any of the protocol > specific flowi information, replace the flow

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread tanhuazhong
On 2020/11/20 6:02, Michal Kubecek wrote: On Thu, Nov 19, 2020 at 04:56:42PM +0800, tanhuazhong wrote: On 2020/11/19 12:15, Andrew Lunn wrote: diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 9ca87bc..afd8de2 100644 --- a/include/uapi/linux/ethtool.h +++ b/inclu

Re: [PATCH net-next 2/4] net: dsa: Link aggregation support

2020-11-19 Thread Florian Fainelli
On 11/19/2020 4:30 PM, Andrew Lunn wrote: >> +static struct dsa_lag *dsa_lag_get(struct dsa_switch_tree *dst, >> + struct net_device *dev) >> +{ >> +unsigned long busy = 0; >> +struct dsa_lag *lag; >> +int id; >> + >> +list_for_each_entry(lag, &dst->

Re: [RFC PATCH bpf-next 0/8] Socket migration for SO_REUSEPORT.

2020-11-19 Thread Martin KaFai Lau
On Fri, Nov 20, 2020 at 07:17:49AM +0900, Kuniyuki Iwashima wrote: > From: Martin KaFai Lau > Date: Wed, 18 Nov 2020 17:49:13 -0800 > > On Tue, Nov 17, 2020 at 06:40:15PM +0900, Kuniyuki Iwashima wrote: > > > The SO_REUSEPORT option allows sockets to listen on the same port and to > > > accept

Re: [RFC PATCH net-next] net: dsa: mt7530: support setting ageing time

2020-11-19 Thread Andrew Lunn
On Thu, Nov 19, 2020 at 02:40:20PM +0800, DENG Qingfang wrote: > MT7530 has a global address age control register, so use it to set > ageing time. > > The applied timer is (AGE_CNT + 1) * (AGE_UNIT + 1) seconds > > Signed-off-by: DENG Qingfang > --- > drivers/net/dsa/mt7530.c | 41 +

Re: [PATCH v3 06/11] dt-bindings: phy: convert HDMI PHY binding to YAML schema

2020-11-19 Thread Chunfeng Yun
On Fri, 2020-11-20 at 07:42 +0800, Chun-Kuang Hu wrote: > Hi, Chunfeng: > > Chunfeng Yun 於 2020年11月18日 週三 下午4:21寫道: > > > > Convert HDMI PHY binding to YAML schema mediatek,hdmi-phy.yaml > > > > Cc: Chun-Kuang Hu > > Signed-off-by: Chunfeng Yun > > Reviewed-by: Rob Herring > > --- > > v3: add

Re: [PATCH v3 07/11] dt-bindings: phy: convert MIP DSI PHY binding to YAML schema

2020-11-19 Thread Chunfeng Yun
On Fri, 2020-11-20 at 07:38 +0800, Chun-Kuang Hu wrote: > Hi, Chunfeng: > > Chunfeng Yun 於 2020年11月18日 週三 下午4:21寫道: > > > > Convert MIPI DSI PHY binding to YAML schema mediatek,dsi-phy.yaml > > > > Cc: Chun-Kuang Hu > > Signed-off-by: Chunfeng Yun > > --- > > v3: new patch > > --- > > .../disp

Re: [PATCH bpf-next 4/6] libbpf: add kernel module BTF support for CO-RE relocations

2020-11-19 Thread Maciej Fijalkowski
On Thu, Nov 19, 2020 at 05:24:43PM -0800, Andrii Nakryiko wrote: > On Thu, Nov 19, 2020 at 4:55 PM Maciej Fijalkowski > wrote: > > > > On Thu, Nov 19, 2020 at 03:22:42PM -0800, Andrii Nakryiko wrote: > > > Teach libbpf to search for candidate types for CO-RE relocations across > > > kernel > > >

Re: [PATCH net-next v7 1/4] gve: Add support for raw addressing device option

2020-11-19 Thread Maciej Fijalkowski
On Thu, Nov 19, 2020 at 04:22:24PM -0800, David Awogbemila wrote: > On Thu, Nov 19, 2020 at 12:21 PM Saeed Mahameed wrote: > > > > On Wed, 2020-11-18 at 15:20 -0800, David Awogbemila wrote: > > > From: Catherine Sullivan > > > > > > Add support to describe device for parsing device options. As >

Re: [PATCH v10 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-11-19 Thread Andrew Lunn
On Fri, Nov 20, 2020 at 02:43:11AM +0100, Marek Behun wrote: > Hi Andrew, > > On Fri, 20 Nov 2020 02:29:06 +0100 > Andrew Lunn wrote: > > > > + if (speed >= 2500 && port > 0 && port < 9) > > > + return -EOPNOTSUPP; > > > > Maybe i'm missing something, but it looks like at this point y

Re: [RFC PATCH bpf-next 3/8] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-11-19 Thread Martin KaFai Lau
On Fri, Nov 20, 2020 at 07:09:22AM +0900, Kuniyuki Iwashima wrote: > From: Martin KaFai Lau > Date: Wed, 18 Nov 2020 15:50:17 -0800 > > On Tue, Nov 17, 2020 at 06:40:18PM +0900, Kuniyuki Iwashima wrote: > > > This patch lets reuseport_detach_sock() return a pointer of struct sock, > > > which is u

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread tanhuazhong
On 2020/11/20 6:02, Michal Kubecek wrote: On Thu, Nov 19, 2020 at 04:56:42PM +0800, tanhuazhong wrote: On 2020/11/19 12:15, Andrew Lunn wrote: diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 9ca87bc..afd8de2 100644 --- a/include/uapi/linux/ethtool.h +++ b/inclu

Re: [PATCH net-next v4 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-11-19 Thread Andrew Lunn
> +static int dp83td510_config_init(struct phy_device *phydev) > +{ > + struct dp83td510_private *dp83td510 = phydev->priv; > + int ret = 0; > + > + if (phy_interface_is_rgmii(phydev)) { > + if (dp83td510->rgmii_delay) { > + ret = phy_set_bits_mmd(phydev

Re: [PATCH bpf-next v7 16/34] bpf: refine memcg-based memory accounting for sockmap and sockhash maps

2020-11-19 Thread Song Liu
> On Nov 19, 2020, at 9:37 AM, Roman Gushchin wrote: > > Include internal metadata into the memcg-based memory accounting. > Also include the memory allocated on updating an element. > > Signed-off-by: Roman Gushchin Acked-by: Song Liu

Re: [PATCH bpf-next v7 17/34] bpf: refine memcg-based memory accounting for xskmap maps

2020-11-19 Thread Song Liu
> On Nov 19, 2020, at 9:37 AM, Roman Gushchin wrote: > > Extend xskmap memory accounting to include the memory taken by > the xsk_map_node structure. > > Signed-off-by: Roman Gushchin Acked-by: Song Liu

Re: [PATCH bpf-next v7 15/34] bpf: memcg-based memory accounting for bpf local storage maps

2020-11-19 Thread Song Liu
> On Nov 19, 2020, at 9:37 AM, Roman Gushchin wrote: > > Account memory used by bpf local storage maps: > per-socket, per-inode and per-task storages. > > Signed-off-by: Roman Gushchin Acked-by: Song Liu

Re: [PATCH v10 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-11-19 Thread Marek Behun
Hi Andrew, On Fri, 20 Nov 2020 02:29:06 +0100 Andrew Lunn wrote: > > + if (speed >= 2500 && port > 0 && port < 9) > > + return -EOPNOTSUPP; > > Maybe i'm missing something, but it looks like at this point you can > call > > return mv88e6xxx_port_set_speed_duplex(chip, port,

Re: [PATCH bpf-next v7 12/34] bpf: refine memcg-based memory accounting for hashtab maps

2020-11-19 Thread Song Liu
> On Nov 19, 2020, at 9:37 AM, Roman Gushchin wrote: > > Include percpu objects and the size of map metadata into the > accounting. > > Signed-off-by: Roman Gushchin Acked-by: Song Liu

Re: [PATCH bpf-next v7 13/34] bpf: memcg-based memory accounting for lpm_trie maps

2020-11-19 Thread Song Liu
> On Nov 19, 2020, at 9:37 AM, Roman Gushchin wrote: > > Include lpm trie and lpm trie node objects into the memcg-based memory > accounting. > > Signed-off-by: Roman Gushchin Acked-by: Song Liu

Re: [PATCH bpf-next v7 11/34] bpf: refine memcg-based memory accounting for devmap maps

2020-11-19 Thread Song Liu
> On Nov 19, 2020, at 9:37 AM, Roman Gushchin wrote: > > Include map metadata and the node size (struct bpf_dtab_netdev) > into the accounting. > > Signed-off-by: Roman Gushchin Acked-by: Song Liu

Re: [PATCH bpf-next v7 10/34] bpf: memcg-based memory accounting for cgroup storage maps

2020-11-19 Thread Song Liu
> On Nov 19, 2020, at 9:37 AM, Roman Gushchin wrote: > > Account memory used by cgroup storage maps including metadata > structures. > > Account the percpu memory for the percpu flavor of cgroup storage. > > Signed-off-by: Roman Gushchin > Acked-by: Song Liu

LRO: creating vlan subports affects parent port's LRO settings

2020-11-19 Thread Limin Wang
Under relatively recent kernels (v4.4+), creating a vlan subport on a LRO supported parent NIC may turn LRO off on the parent port and further render its LRO feature practically unchangeable. This can be easily reproduced on different distros, and independent of NIC vendors. Hopefully, this is not

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Jakub Kicinski
On Wed, 18 Nov 2020 22:12:22 -0800 Saeed Mahameed wrote: > > Right, devices of other subsystems are fine, I don't care. > > But a netdev will be loaded on SF automatically just through the > current driver design and modularity, since SF == VF and our netdev is > abstract and doesn't know if it ru

Re: [PATCH bpf-next v7 09/34] bpf: refine memcg-based memory accounting for cpumap maps

2020-11-19 Thread Song Liu
> On Nov 19, 2020, at 9:37 AM, Roman Gushchin wrote: > > Include metadata and percpu data into the memcg-based memory > accounting. Switch allocations made from an update path to > new bpf_map_* allocation helpers to make the accounting work > properly from an interrupt context. > > Signed-of

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Jakub Kicinski
On Wed, 18 Nov 2020 21:57:57 -0800 Saeed Mahameed wrote: > On Wed, 2020-11-18 at 21:35 -0700, David Ahern wrote: > > On 11/18/20 7:14 PM, Jakub Kicinski wrote: > > > On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: > > > > On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote:

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Jakub Kicinski
On Wed, 18 Nov 2020 21:35:29 -0700 David Ahern wrote: > On 11/18/20 7:14 PM, Jakub Kicinski wrote: > > On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: > >> On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote: > >> > Just to refresh all our memory, we discussed and sett

Re: [PATCH v10 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-11-19 Thread Andrew Lunn
> @@ -222,8 +231,8 @@ static int mv88e6xxx_port_set_speed_duplex(struct > mv88e6xxx_chip *chip, > return err; > > reg &= ~(MV88E6XXX_PORT_MAC_CTL_SPEED_MASK | > - MV88E6XXX_PORT_MAC_CTL_FORCE_DUPLEX | > - MV88E6XXX_PORT_MAC_CTL_DUPLEX_FULL); > +

Re: [PATCH bpf-next 4/6] libbpf: add kernel module BTF support for CO-RE relocations

2020-11-19 Thread Andrii Nakryiko
On Thu, Nov 19, 2020 at 4:55 PM Maciej Fijalkowski wrote: > > On Thu, Nov 19, 2020 at 03:22:42PM -0800, Andrii Nakryiko wrote: > > Teach libbpf to search for candidate types for CO-RE relocations across > > kernel > > modules BTFs, in addition to vmlinux BTF. If at least one candidate type is > >

Re: [PATCH net-next V6] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-19 Thread Jakub Kicinski
On Thu, 19 Nov 2020 20:31:41 +0100 Dmytro Shytyi wrote: > > Thanks for adding the helper! Looks like it needs a touch up: > > Understood. Thank you for pointing this out. I think I did not catch this > warning as my Makefile didn't include "-Wmissing-prototypes" > > > net/ipv6/addrconf.c:2

Re: [RFC PATCH 0/2] add ppp_generic ioctl to bridge channels

2020-11-19 Thread Jakub Kicinski
On Wed, 18 Nov 2020 21:24:53 +0100 Guillaume Nault wrote: > Here's a high level view of: > * the protocol, > * the kernel implementation, > * the context of this RFC, > * and a few pointers at the end :) > > Hope this helps. I've tried to keep it short. Feel free to ask for > clarification

Re: Hardware time stamping support for AF_XDP applications

2020-11-19 Thread Patel, Vedang
> On Nov 18, 2020, at 4:57 PM, Patel, Vedang wrote: > > Hi Saeed, > >> On Nov 13, 2020, at 10:02 AM, Patel, Vedang wrote: >> >> Hi Saeed, >> >>> On Nov 12, 2020, at 11:31 AM, Saeed Mahameed wrote: >>> >>> On Tue, 2020-11-10 at 23:53 +, Patel, Vedang wrote: > With BTF formatted met

Re: [PATCH bpf-next v7 06/34] bpf: prepare for memcg-based memory accounting for bpf maps

2020-11-19 Thread Song Liu
> On Nov 19, 2020, at 9:37 AM, Roman Gushchin wrote: > > In the absolute majority of cases if a process is making a kernel > allocation, it's memory cgroup is getting charged. > > Bpf maps can be updated from an interrupt context and in such > case there is no process which can be charged. It

Re: [PATCH v10 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int

2020-11-19 Thread Andrew Lunn
> @@ -459,7 +459,7 @@ static int mv88e6xxx_port_set_cmode(struct mv88e6xxx_chip > *chip, int port, > chip->ports[port].cmode = cmode; > > lane = mv88e6xxx_serdes_get_lane(chip, port); > - if (!lane) > + if (lane < 0) > ret

Re: [PATCH v10 2/4] net: phy: Add 5GBASER interface mode

2020-11-19 Thread Andrew Lunn
On Fri, Nov 20, 2020 at 10:25:33AM +1000, Pavana Sharma wrote: > Add 5GBASE-R phy interface mode > > Signed-off-by: Pavana Sharma > --- > include/linux/phy.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/phy.h b/include/linux/phy.h > index eb3cb1a98b45..71e280059ec

Re: [PATCH bpf-next 4/6] libbpf: add kernel module BTF support for CO-RE relocations

2020-11-19 Thread Maciej Fijalkowski
On Thu, Nov 19, 2020 at 03:22:42PM -0800, Andrii Nakryiko wrote: > Teach libbpf to search for candidate types for CO-RE relocations across kernel > modules BTFs, in addition to vmlinux BTF. If at least one candidate type is > found in vmlinux BTF, kernel module BTFs are not iterated. If vmlinux BTF

Re: [PATCH v2 5/5] bpf: Add an iterator selftest for bpf_sk_storage_get

2020-11-19 Thread KP Singh
On Fri, Nov 20, 2020 at 1:32 AM Martin KaFai Lau wrote: > > On Thu, Nov 19, 2020 at 05:26:54PM +0100, Florent Revest wrote: > > From: Florent Revest > > > > The eBPF program iterates over all files and tasks. For all socket > > files, it stores the tgid of the last task it encountered with a hand

Re: [PATCH v10 1/4] dt-bindings: net: Add 5GBASER phy interface mode

2020-11-19 Thread Andrew Lunn
On Fri, Nov 20, 2020 at 10:25:01AM +1000, Pavana Sharma wrote: > Add 5gbase-r PHY interface mode. > > Signed-off-by: Pavana Sharma > --- > Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-19 Thread Russell King - ARM Linux admin
On Fri, Nov 20, 2020 at 01:11:12AM +0100, Tobias Waldekranz wrote: > On Thu, Nov 19, 2020 at 23:16, Russell King - ARM Linux admin > wrote: > > On Thu, Nov 19, 2020 at 11:43:39PM +0100, Tobias Waldekranz wrote: > >> On Thu, Nov 19, 2020 at 16:24, Maxime Chevallier > >> wrote: > >> > I don't thi

Re: [PATCH net-next 2/4] net: dsa: Link aggregation support

2020-11-19 Thread Andrew Lunn
> +static struct dsa_lag *dsa_lag_get(struct dsa_switch_tree *dst, > +struct net_device *dev) > +{ > + unsigned long busy = 0; > + struct dsa_lag *lag; > + int id; > + > + list_for_each_entry(lag, &dst->lags, list) { > + set_bit(lag->id, &

Re: [PATCH v2 5/5] bpf: Add an iterator selftest for bpf_sk_storage_get

2020-11-19 Thread Martin KaFai Lau
On Thu, Nov 19, 2020 at 05:26:54PM +0100, Florent Revest wrote: > From: Florent Revest > > The eBPF program iterates over all files and tasks. For all socket > files, it stores the tgid of the last task it encountered with a handle > to that socket. This is a heuristic for finding the "owner" of

[PATCH bpf-next] bpf: simplify task_file_seq_get_next()

2020-11-19 Thread Song Liu
Simplify task_file_seq_get_next() by removing two in/out arguments: task and fstruct. Use info->task and info->files instead. Cc: Yonghong Song Signed-off-by: Song Liu --- kernel/bpf/task_iter.c | 53 ++ 1 file changed, 17 insertions(+), 36 deletions(-)

Re: [PATCH net-next v3 2/7] dpaa_eth: add basic XDP support

2020-11-19 Thread Maciej Fijalkowski
On Thu, Nov 19, 2020 at 06:29:31PM +0200, Camelia Groza wrote: > Implement the XDP_DROP and XDP_PASS actions. > > Avoid draining and reconfiguring the buffer pool at each XDP > setup/teardown by increasing the frame headroom and reserving > XDP_PACKET_HEADROOM bytes from the start. Since we always

[PATCH v10 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-11-19 Thread Pavana Sharma
The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family (88E6393X, 88E6193X and 88E6191X) Co-developed-by: Ashkan

[PATCH v10 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int

2020-11-19 Thread Pavana Sharma
Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or -errno (-ENODEV or -EOPNOTSUPP). Signed-off-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chip.c | 28 ++-- drivers/net

[PATCH v10 2/4] net: phy: Add 5GBASER interface mode

2020-11-19 Thread Pavana Sharma
Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma --- include/linux/phy.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index eb3cb1a98b45..71e280059ec5 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -106,6 +106,7 @@

[PATCH v10 1/4] dt-bindings: net: Add 5GBASER phy interface mode

2020-11-19 Thread Pavana Sharma
Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-

Re: [PATCH v4] aquantia: Remove the build_skb path

2020-11-19 Thread Ramsay, Lincoln
> > I don't know about benefits/feasibility, but I did wonder if (in the event > > that the "fast path" is possible), the dma_mapping could use an offset? The > > page would include the skb header but the dma mapping would not. If that > > was done though, only 1 RX frame would fit into the page

[PATCH v10 0/4] Add support for mv88e6393x family of Marvell

2020-11-19 Thread Pavana Sharma
Updated patchset after fixing a warning. Pavana Sharma (4): dt-bindings: net: Add 5GBASER phy interface mode net: phy: Add 5GBASER interface mode net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell .../

Re: [PATCH v2 4/5] bpf: Add an iterator selftest for bpf_sk_storage_delete

2020-11-19 Thread Martin KaFai Lau
On Thu, Nov 19, 2020 at 05:26:53PM +0100, Florent Revest wrote: > From: Florent Revest > > The eBPF program iterates over all entries (well, only one) of a socket > local storage map and deletes them all. The test makes sure that the > entry is indeed deleted. Note that if there are many entries

Re: [PATCH v4] aquantia: Remove the build_skb path

2020-11-19 Thread Florian Westphal
Ramsay, Lincoln wrote: [ patch looks good to me, I have no further comments ] > > For build_skb path to work the buffer scheme would need to be changed > > to reserve headroom, so yes, I think that the proposed patch is the > > most convenient solution. > > I don't know about benefits/feasibili

[PATCH v3 net-next 3/3] net/sched: sch_frag: add generic packet fragment support.

2020-11-19 Thread wenxu
From: wenxu Currently kernel tc subsystem can do conntrack in cat_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last action will redirect mirred to a device which maybe lead the reassembly big packet ove

[PATCH v3 net-next 0/3] net/sched: fix over mtu packet of defrag in

2020-11-19 Thread wenxu
From: wenxu Currently kernel tc subsystem can do conntrack in act_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last action will redirect mirred to a device which maybe lead the reassembly big packet ove

[PATCH v3 net-next 1/3] net/sched: fix miss init the mru in qdisc_skb_cb

2020-11-19 Thread wenxu
From: wenxu The mru in the qdisc_skb_cb should be init as 0. Only defrag packets in the act_ct will set the value. Fixes: 038ebb1a713d ("net/sched: act_ct: fix miss set mru for ovs after defrag in act_ct") Signed-off-by: wenxu --- v3: no change net/core/dev.c | 2 ++ 1 file changed, 2 insert

  1   2   3   4   >