On Thu, 19 Nov 2020 23:09:52 +0100 Heiner Kallweit wrote: > Am 19.11.2020 um 22:41 schrieb Andrew Lunn: > >>>> Doesn't checkpatch complain about line length > 80 here? > >>> > >>> :) > >>> > >>> commit bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > >>> Author: Joe Perches <j...@perches.com> > >>> Date: Fri May 29 16:12:21 2020 -0700 > >>> > >>> checkpatch/coding-style: deprecate 80-column warning > >>> > >> > >> Ah, again something learnt. Thanks for the reference. > > > > But it then got revoked for netdev. Or at least it was planned to > > re-impose 80 for netdev. I don't know if checkpatch got patched yet.
FWIW I had a patch for it but before I sent it Dave suggested I ask around and Alexei was opposed. And I don't have the strength to argue :) I'll just tell people case by case when they have 4+ indentation levels in their code or use 40+ character variables/defines, in my copious spare time. > At a first glance it sounds strange that subsystems may define own > rules for such basic things. But supposedly there has been a longer > emotional disucssion about this already .. We do have our own comment style rule in networking since the beginning of time, and reverse xmas tree, so it's not completely crazy.
