Hi Rob, Bjorn, Kalle,
On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson
wrote:
>
> On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote:
>
> > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote:
> > > There are firmware versions which do not support host capability
> > > QMI request. We suspect e
The ADIN1300/ADIN1200 support cable diagnostics using TDR.
The cable fault detection is automatically run on all four pairs looking at
all combinations of pair faults by first putting the PHY in standby (clear
the LINK_EN bit, PHY_CTRL_3 register, Address 0x0017) and then enabling the
diagnostic c
When the PHY powers up, the diagnostics clock isn't enabled (bit 2 in
register PHY_CTRL_1 (0x0012)).
Also, the PHY is not in standby mode, so bit 13 in PHY_CTRL_3 (0x0017) is
always set at power up.
The standby mode and the diagnostics clock are both meant to be for the
cable diagnostics feature o
Dear Jakub,
Am 03.11.20 um 01:19 schrieb Jakub Kicinski:
On Tue, 3 Nov 2020 00:13:07 +0100 Paul Menzel wrote:
From: Jeffrey Townsend
The ops field might no be defined, so add a check.
This change should be first, otherwise AFAIU if someone builds the
kernel in between the commits (e.g. fo
This series converts the remaining drivers to use new
tasklet_setup() API.
The patches are based on wireless-drivers-next (c2568c8c9e63)
Is this series queue? I haven't seen any email. This is the last
series as part of the tasklet conversion effort.
Thanks.
v2:
Split mt76 and mt76
@@ -815,7 +815,7 @@ int cdc_ncm_bind_common(struct usbnet *dev, struct
usb_interface *intf, u8 data_
hrtimer_init(&ctx->tx_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
ctx->tx_timer.function = &cdc_ncm_tx_timer_cb;
- tasklet_init(&ctx->bh, cdc_ncm_txpath_bh, (unsigned long
Hi George,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/George-Cherian/Add-devlink-and-devlink-health-reporters-to/20201102-130844
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net
Hi George,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/George-Cherian/Add-devlink-and-devlink-health-reporters-to/20201102-130844
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net
On 2020/11/3 0:55, Cong Wang wrote:
> On Fri, Oct 30, 2020 at 12:38 AM Yunsheng Lin wrote:
>>
>> On 2020/10/30 3:05, Cong Wang wrote:
>>>
>>> I do not see how and why it should. synchronize_net() is merely an optimized
>>> version of synchronize_rcu(), it should wait for RCU readers, softirqs are
On Tue, Nov 03, 2020 at 08:10:54AM +0100, Kurt Kanzenbach wrote:
> The Hirschmann Hellcreek TSN switches have a special tagging protocol for
> frames
> exchanged between the CPU port and the master interface. The format is a one
> byte trailer indicating the destination or origin port.
>
> It's q
Add basic documentation and example.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Rob Herring
Reviewed-by: Florian Fainelli
---
.../net/dsa/hirschmann,hellcreek.yaml | 127 ++
1 file changed, 127 insertions(+)
create mode 100644
Documentation/devicetree/bindings/net/ds
Hirschmann is building devices for automation and networking. Add them to the
vendor prefixes.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Florian Fainelli
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Doc
The switch has two controllable I/Os which are usually connected to LEDs. This
is useful to immediately visually see the PTP status.
These provide two signals:
* is_gm
This LED can be activated if the current device is the grand master in that
PTP domain.
* sync_good
This LED can be
From: Kamil Alkhouri
The switch has the ability to take hardware generated time stamps per port for
PTPv2 event messages in Rx and Tx direction. That is useful for achieving needed
time synchronization precision for TSN devices/switches. So add support for it.
There are two directions:
* RX
From: Kamil Alkhouri
The switch has internal PTP hardware clocks. Add support for it. There are three
clocks:
* Synchronized
* Syntonized
* Free running
Currently the synchronized clock is exported to user space which is a good
default for the beginning. The free running clock might be expor
On 2020-11-01 10:15 PM, Leon Romanovsky wrote:
From: Leon Romanovsky
Delete dead code.
Signed-off-by: Leon Romanovsky
---
drivers/infiniband/hw/mlx5/ib_rep.c | 31 +++--
drivers/infiniband/hw/mlx5/ib_rep.h | 31 -
2 files changed, 7 i
Hi,
this series adds a DSA driver for the Hirschmann Hellcreek TSN switch
IP. Characteristics of that IP:
* Full duplex Ethernet interface at 100/1000 Mbps on three ports
* IEEE 802.1Q-compliant Ethernet Switch
* IEEE 802.1Qbv Time-Aware scheduling support
* IEEE 1588 and IEEE 802.1AS support
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/xfrm/xfrm_i
The Hirschmann Hellcreek TSN switches have a special tagging protocol for frames
exchanged between the CPU port and the master interface. The format is a one
byte trailer indicating the destination or origin port.
It's quite similar to the Micrel KSZ tagging. That's why the implementation is
based
Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are
implementing features needed for Time Sensitive Networking (TSN) such as support
for the Time Precision Protocol and various shapers like the Time Aware Shaper.
This driver includes basic support for networking:
* VLAN
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/smc/smc_cdc
From: Vladimir Oltean
Some switches rely on unique pvids to ensure port separation in
standalone mode, because they don't have a port forwarding matrix
configurable in hardware. So, setups like a group of 2 uppers with the
same VLAN, swp0.100 and swp1.100, will cause traffic tagged with VLAN
100
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/rds/ib_cm.c
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/ipv4/tcp_ou
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/sched/sch_a
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Reviewed-by: Johannes Berg
Signed-off-by: Romain Perier
Signed-off-by: Alle
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Acked-by: Stefan Schmidt
Signed-off-by: Romain Perier
Signed-off-by: Allen
From: Allen Pais
ommit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
introduced a new tasklet initialization API. This series converts
all the net/* drivers to use the new tasklet_setup() API
The following series is based on net-next (9faebeb2d)
v2:
get rid of QDISC_ALIGN()
v1:
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/dccp/timer.
On Mon, Nov 2, 2020 at 7:47 AM David Ahern wrote:
>
> On 10/29/20 9:11 AM, Hangbin Liu wrote:
> > This series converts iproute2 to use libbpf for loading and attaching
> > BPF programs when it is available. This means that iproute2 will
> > correctly process BTF information and support the new-sty
On Mon, Nov 2, 2020 at 9:59 PM Song Liu wrote:
>
>
>
> > On Nov 2, 2020, at 9:25 PM, Andrii Nakryiko
> > wrote:
> >
> > On Mon, Nov 2, 2020 at 6:49 PM Song Liu wrote:
> >>
> >>
> >>
> >>> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
> >>>
> >>> Add support for deduplication split BTFs.
> On Nov 2, 2020, at 10:05 PM, Andrii Nakryiko
> wrote:
>
> On Mon, Nov 2, 2020 at 9:35 PM Song Liu wrote:
>>
>>
>>
>>> On Oct 28, 2020, at 5:59 PM, Andrii Nakryiko wrote:
>>>
>>> Add selftests validating BTF deduplication for split BTF case. Add a helper
>>> macro that allows to valida
On Mon, Nov 2, 2020 at 9:10 PM Alexei Starovoitov
wrote:
>
> On Wed, Oct 28, 2020 at 05:58:59PM -0700, Andrii Nakryiko wrote:
> > @@ -2942,6 +2948,13 @@ struct btf_dedup {
> > __u32 *hypot_list;
> > size_t hypot_cnt;
> > size_t hypot_cap;
> > + /* Whether hypothethical mappin
On Tue, Nov 03, 2020 at 12:05:20AM +0100, Petr Machata wrote:
>
> Leon Romanovsky writes:
>
> > On Sun, Nov 01, 2020 at 04:55:42PM -0700, David Ahern wrote:
> >> On 10/31/20 3:23 PM, Petr Machata wrote:
> >> >
> >> > David Ahern writes:
> >> >
> >> >> On 10/30/20 6:29 AM, Petr Machata wrote:
> >>
On Mon, Nov 2, 2020 at 9:35 PM Song Liu wrote:
>
>
>
> > On Oct 28, 2020, at 5:59 PM, Andrii Nakryiko wrote:
> >
> > Add selftests validating BTF deduplication for split BTF case. Add a helper
> > macro that allows to validate entire BTF with raw BTF dump, not just
> > type-by-type. This saves to
> On Oct 28, 2020, at 5:59 PM, Andrii Nakryiko wrote:
>
> Add ability to work with split BTF by providing extra -B flag, which allows to
> specify the path to the base BTF file.
>
> Signed-off-by: Andrii Nakryiko
Acked-by: Song Liu
> ---
> tools/bpf/bpftool/btf.c | 9 ++---
> tools/b
On Mon, Nov 2, 2020 at 8:59 PM Alexei Starovoitov
wrote:
>
> On Wed, Oct 28, 2020 at 05:58:54PM -0700, Andrii Nakryiko wrote:
> > From: Andrii Nakryiko
> >
> > Revamp BTF dedup's string deduplication to match the approach of writable
> > BTF
> > string management. This allows to transfer dedupli
> On Nov 2, 2020, at 9:25 PM, Andrii Nakryiko wrote:
>
> On Mon, Nov 2, 2020 at 6:49 PM Song Liu wrote:
>>
>>
>>
>>> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
>>>
>>> Add support for deduplication split BTFs. When deduplicating split BTF, base
>>> BTF is considered to be immuta
On Mon, Nov 02, 2020 at 08:37:37AM -0700, David Ahern wrote:
> On 10/29/20 9:11 AM, Hangbin Liu wrote:
> > This patch adds a check to see if we support libbpf. By default the
> > system libbpf will be used, but static linking against a custom libbpf
> > version can be achieved by passing LIBBPF_DIR
On Mon, Nov 02, 2020 at 08:41:09AM -0700, David Ahern wrote:
>
> I would prefer to have these #ifdef .. #endif checks consolidated in the
> lib code. Create a bpf_compat file for these. e.g.,
>
> int bpf_program_load(enum bpf_prog_type type, const struct bpf_insn *insns,
> si
> On Nov 2, 2020, at 9:18 PM, Andrii Nakryiko wrote:
>
> On Mon, Nov 2, 2020 at 4:51 PM Song Liu wrote:
>>
>>
>>
>>> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
>>>
>>> Make data section layout checks stricter, disallowing overlap of types and
>>> strings data.
>>>
>>> Additiona
On Mon, Nov 2, 2020 at 9:39 PM Kenny Ho wrote:
>
> Thanks for the reply.
pls don't top post.
> Cgroup awareness is desired because the intent
> is to use this for resource management as well (potentially along with
> other cgroup controlled resources.) I will dig into bpf_lsm and learn
> more a
> On Nov 2, 2020, at 9:02 PM, Andrii Nakryiko wrote:
>
> On Mon, Nov 2, 2020 at 3:24 PM Song Liu wrote:
>>
>>
>>
>>> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
>>>
>>
>> [...]
>>
>>>
>>> BTF deduplication is not yet supported for split BTF and support for it will
>>> be added
Thanks for the reply. Cgroup awareness is desired because the intent
is to use this for resource management as well (potentially along with
other cgroup controlled resources.) I will dig into bpf_lsm and learn
more about it.
Regards,
Kenny
On Tue, Nov 3, 2020 at 12:32 AM Alexei Starovoitov
wr
> On Oct 28, 2020, at 5:59 PM, Andrii Nakryiko wrote:
>
> Add selftests validating BTF deduplication for split BTF case. Add a helper
> macro that allows to validate entire BTF with raw BTF dump, not just
> type-by-type. This saves tons of code and complexity.
>
> Signed-off-by: Andrii Nakryi
On 10/29/2020 2:53 PM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote:
On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote:
On 2020/10/14 上午7:42, si-wei liu wrote:
So what I suggest is to fix the p
On Mon, Nov 02, 2020 at 02:23:02PM -0500, Kenny Ho wrote:
> Adding a few more emails from get_maintainer.pl and bumping this
> thread since there hasn't been any comments so far. Is this too
> crazy? Am I missing something fundamental?
sorry for delay. Missed it earlier. Feel free to ping the ma
On Mon, Nov 2, 2020 at 6:49 PM Song Liu wrote:
>
>
>
> > On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
> >
> > Add support for deduplication split BTFs. When deduplicating split BTF, base
> > BTF is considered to be immutable and can't be modified or adjusted. 99% of
> > BTF deduplication l
On Mon, Nov 2, 2020 at 4:51 PM Song Liu wrote:
>
>
>
> > On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
> >
> > Make data section layout checks stricter, disallowing overlap of types and
> > strings data.
> >
> > Additionally, allow BTFs with no type data. There is nothing inherently
> > wr
On Mon, Nov 2, 2020 at 4:08 PM Song Liu wrote:
>
>
>
> > On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
> >
> > From: Andrii Nakryiko
> >
> > Add re-usable btf_helpers.{c,h} to provide BTF-related testing routines.
> > Start
> > with adding a raw BTF dumping helpers.
> >
> > Raw BTF dump i
Hi Jakub,
> -Original Message-
> From: Jakub Kicinski
> Sent: Monday, November 2, 2020 11:25 PM
> To: Naveen Mamindlapalli
> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org;
> da...@davemloft.net; Sunil Kovvuri Goutham ; Linu
> Cherian ; Geethasowjanya Akula
> ; Jerin Jacob Koll
On Wed, Oct 28, 2020 at 05:58:59PM -0700, Andrii Nakryiko wrote:
> @@ -2942,6 +2948,13 @@ struct btf_dedup {
> __u32 *hypot_list;
> size_t hypot_cnt;
> size_t hypot_cap;
> + /* Whether hypothethical mapping, if successful, would need to adjust
> + * already canonicalized
On Mon, Nov 2, 2020 at 3:36 PM Song Liu wrote:
>
>
>
> > On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
> >
> > Add selftest validating ability to programmatically generate and then dump
> > split BTF.
> >
> > Signed-off-by: Andrii Nakryiko
>
> Acked-by: Song Liu
>
> With a nit:
>
> [...]
Hi Jakub,
> -Original Message-
> From: Jakub Kicinski
> Sent: Monday, November 2, 2020 11:24 PM
> To: Naveen Mamindlapalli
> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org;
> da...@davemloft.net; Sunil Kovvuri Goutham ; Linu
> Cherian ; Geethasowjanya Akula
> ; Jerin Jacob Koll
Hi Jakub,
> -Original Message-
> From: Jakub Kicinski
> Sent: Monday, November 2, 2020 11:23 PM
> To: Naveen Mamindlapalli
> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org;
> da...@davemloft.net; Sunil Kovvuri Goutham ; Linu
> Cherian ; Geethasowjanya Akula
> ; Jerin Jacob Koll
MT7530/7531 has a global RX packet length register, which can be used
to set MTU.
Supported packet length values are 1522 (1518 if untagged), 1536,
1552, and multiple of 1024 (from 2048 to 15360).
Signed-off-by: DENG Qingfang
---
v2 -> v3:
Fix checkpatch.pl warning
v1 -> v2:
Avoi
On Mon, Nov 2, 2020 at 3:24 PM Song Liu wrote:
>
>
>
> > On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
> >
>
> [...]
>
> >
> > BTF deduplication is not yet supported for split BTF and support for it will
> > be added in separate patch.
> >
> > Signed-off-by: Andrii Nakryiko
>
> Acked-by: S
On Wed, Oct 28, 2020 at 05:58:54PM -0700, Andrii Nakryiko wrote:
> From: Andrii Nakryiko
>
> Revamp BTF dedup's string deduplication to match the approach of writable BTF
> string management. This allows to transfer deduplicated strings index back to
> BTF object after deduplication without expen
On Fri, Oct 30, 2020 at 4:33 PM Song Liu wrote:
>
>
>
> > On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
> >
> > From: Andrii Nakryiko
> >
> > Revamp BTF dedup's string deduplication to match the approach of writable
> > BTF
> > string management. This allows to transfer deduplicated strin
In comment 173ca26e9b51 ("samples/bpf: add comprehensive ipip, ipip6,
ip6ip6 test") we added some bpf tunnel tests. In commit 933a741e3b82
("selftests/bpf: bpf tunnel test.") when we moved it to the current
folder, we missed some points:
1. ip6ip6 test is not added
2. forgot to remove test_ipip.sh
In comment 173ca26e9b51 ("samples/bpf: add comprehensive ipip, ipip6,
ip6ip6 test") we added some bpf tunnel tests. In commit 933a741e3b82
("selftests/bpf: bpf tunnel test.") when we moved it to the current
folder, we forgot to remove test_ipip.sh in sample folder.
Since we simplify the original i
In comment 173ca26e9b51 ("samples/bpf: add comprehensive ipip, ipip6,
ip6ip6 test") we added ip6ip6 test for bpf tunnel testing. But in commit
933a741e3b82 ("selftests/bpf: bpf tunnel test.") when we moved it to
the current folder, we didn't add it.
This patch add the ip6ip6 test back to bpf tunne
On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski
>
> Andy brought to my attention the fact that users allocating an array of
> equally sized elements should check if the size multiplication doesn't
> overflow. This is why we have helpers like kmalloc_array
Hi Willem,
Thanks for the review.
> -Original Message-
> From: Willem de Bruijn
> Sent: Monday, November 2, 2020 7:12 PM
> To: George Cherian
> Cc: Network Development ; linux-kernel ker...@vger.kernel.org>; Jakub Kicinski ; David Miller
> ; Sunil Kovvuri Goutham
> ; Linu Cherian ;
> G
Hi Willem,
Thanks for the review.
> -Original Message-
> From: Willem de Bruijn
> Sent: Monday, November 2, 2020 7:01 PM
> To: George Cherian
> Cc: Network Development ; linux-kernel ker...@vger.kernel.org>; Jakub Kicinski ; David Miller
> ; Sunil Kovvuri Goutham
> ; Linu Cherian ;
> G
commit 2fb541c862c9 ("net: sch_generic: aviod concurrent reset and enqueue op
for lockless qdisc")
When the above upstream commit is backported to stable kernel,
one assignment is missing, which causes two problems reported
by Joakim and Vishwanath, see [1] and [2].
So add the assignment back to
On Mon, Nov 02, 2020 at 06:12:32PM -0800, Florian Fainelli wrote:
>
>
> On 11/2/2020 5:34 PM, Pavana Sharma wrote:
> >> How many times have i asked for you to add kerneldoc for this new
> >> value? How many times have you not done so?
> >
> > I have added kerneldoc comment for the new value adde
On Thu, 29 Oct 2020 17:36:17 + Aleksandr Nogikh wrote:
> From: Aleksandr Nogikh
>
> This patch series enables remote KCOV coverage collection during
> 802.11 frames processing. These changes make it possible to perform
> coverage-guided fuzzing in search of remotely triggerable bugs.
>
> Nor
This fixes a regression where valid selectors are incorrectly skipped
when xfrm_state_find is called with a non-matching address family (e.g.
when using IPv6-in-IPv4 ESP in transport mode).
The state's address family is matched against the template's family
(encap_family) in xfrm_state_find before
For older versions of gcc, the array = {0}; will cause warnings:
drivers/net/ethernet/mscc/ocelot_vcap.c: In function 'is1_entry_set':
drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: missing braces around
initializer [-Wmissing-braces]
struct ocelot_vcap_u16 etype = {0};
^
> On Oct 28, 2020, at 5:59 PM, Andrii Nakryiko wrote:
>
> In some cases compiler seems to generate distinct DWARF types for identical
> arrays within the same CU. That seems like a bug, but it's already out there
> and breaks type graph equivalence checks, so accommodate it anyway by checking
> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
>
> Add support for deduplication split BTFs. When deduplicating split BTF, base
> BTF is considered to be immutable and can't be modified or adjusted. 99% of
> BTF deduplication logic is left intact (module some type numbering
> adjustmen
-next.git
c43fd36f7fec6c227c5e8a8ddd7d3fe97472182f
config: x86_64-randconfig-a012-20201102 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/e4b66f234e85d211cd81aa99c901035874ebc469
git remote
On 11/2/2020 5:34 PM, Pavana Sharma wrote:
>> How many times have i asked for you to add kerneldoc for this new
>> value? How many times have you not done so?
>
> I have added kerneldoc comment for the new value added.
>
>> NACK.
>
>> If you don't understand a comment, please ask.
>
> Ok, ex
On Mon, 2 Nov 2020 11:31:57 +0200 Tariq Toukan wrote:
> On 11/1/2020 4:05 PM, t...@redhat.com wrote:
> > From: Tom Rix
> >
> > A semicolon is not needed after a switch statement.
> >
> > Signed-off-by: Tom Rix
>
> Reviewed-by: Tariq Toukan
Applied.
On Sun, 1 Nov 2020 07:36:47 -0800 t...@redhat.com wrote:
> From: Tom Rix
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix
Applied...
On Sun, 1 Nov 2020 06:07:20 -0800 t...@redhat.com wrote:
> From: Tom Rix
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix
Applied..
On Sun, 1 Nov 2020 07:56:01 -0800 t...@redhat.com wrote:
> From: Tom Rix
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix
Applied
On Sun, 1 Nov 2020 07:58:22 -0800 t...@redhat.com wrote:
> From: Tom Rix
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix
... and applied. Thanks! :)
On Sat, 31 Oct 2020 08:30:47 -0700 t...@redhat.com wrote:
> From: Tom Rix
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix
Applied.
On 10/31/20 2:25 PM, Vlad Buslov wrote:
> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
> index 5ad84e663d01..b486f52900f0 100644
> --- a/include/uapi/linux/rtnetlink.h
> +++ b/include/uapi/linux/rtnetlink.h
> @@ -768,8 +768,12 @@ enum {
> * actions in a dump. All d
On 11/1/20 4:39 AM, Ido Schimmel wrote:
> From: Ido Schimmel
>
> The nexthop notification chain is a per-namespace chain and not a global
> one like the netdev notification chain.
>
> Therefore, a single (global) listener cannot be registered to all these
> chains simultaneously as it will resul
On Sun, 1 Nov 2020 21:16:08 +0200 Vladimir Oltean wrote:
> Christian has reported buggy usage of skb_put() in tag_ksz.c, which is
> only triggerable in real life using his not-yet-published patches for
> IEEE 1588 timestamping on Micrel KSZ switches.
>
> The concrete problem there is that the dri
On Mon, Nov 02, 2020 at 04:56:37PM -0800, Alexander Duyck wrote:
> On Mon, Nov 2, 2020 at 4:42 PM Martin KaFai Lau wrote:
> >
> > On Sat, Oct 31, 2020 at 11:52:24AM -0700, Alexander Duyck wrote:
> > > From: Alexander Duyck
> > >
> > > There is already logic in test_progs.h for asserting that a va
On Sat, 31 Oct 2020 10:49:40 +0800 YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing
Applied, thanks!
On Sat, 31 Oct 2020 14:01:53 +0800 YueHaibing wrote:
> Fix smatch warning:
>
> net/openvswitch/meter.c:427 ovs_meter_cmd_set() warn: passing zero to
> 'PTR_ERR'
>
> dp_meter_create() never returns NULL, use IS_ERR
> instead of IS_ERR_OR_NULL to fix this.
>
> Signed-off-by: YueHaibing
Applied,
On Sat, 31 Oct 2020 10:47:44 +0800 YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing
Applied, thanks!
> How many times have i asked for you to add kerneldoc for this new
> value? How many times have you not done so?
I have added kerneldoc comment for the new value added.
> NACK.
> If you don't understand a comment, please ask.
Ok, explain what do you expect by that comment.
On Mon, Nov 02, 2020 at 04:49:42PM -0800, Alexander Duyck wrote:
> On Mon, Nov 2, 2020 at 4:38 PM Martin KaFai Lau wrote:
> >
> > On Sat, Oct 31, 2020 at 11:52:18AM -0700, Alexander Duyck wrote:
> > > From: Alexander Duyck
> > >
> > > Drop the tcp_client/server.py files in favor of using a client
On Sat, 31 Oct 2020 18:54:18 +0800 Yu Kuai wrote:
> if of_find_device_by_node() succeed, fman_port_probe() doesn't have a
> corresponding put_device(). Thus add jump target to fix the exception
> handling for this function implementation.
>
> Fixes: 0572054617f3 ("fsl/fman: fix dereference null re
On Fri, 30 Oct 2020 18:34:12 -0700 Yuchung Cheng wrote:
> During TCP fast recovery, the congestion control in charge is by
> default the Proportional Rate Reduction (PRR) unless the congestion
> control module specified otherwise (e.g. BBR).
>
> Previously when tcp_packets_in_flight() is below snd
From: Jeff Vander Stoep
[ Upstream commit af545bb5ee53f5261db631db2ac4cde54038bdaf ]
During __vsock_create() CAP_NET_ADMIN is used to determine if the
vsock_sock->trusted should be set to true. This value is used later
for determing if a remote connection should be allowed to connect
to a restri
On Sat, Oct 31, 2020 at 11:52:37AM -0700, Alexander Duyck wrote:
[ ... ]
> +struct tcpbpf_globals global = { 0 };
> int _version SEC("version") = 1;
>
> SEC("sockops")
> @@ -105,29 +72,15 @@ int bpf_testcb(struct bpf_sock_ops *skops)
>
> op = (int) skops->op;
>
> - update_event_m
From: Jeff Vander Stoep
[ Upstream commit af545bb5ee53f5261db631db2ac4cde54038bdaf ]
During __vsock_create() CAP_NET_ADMIN is used to determine if the
vsock_sock->trusted should be set to true. This value is used later
for determing if a remote connection should be allowed to connect
to a restri
From: Jeff Vander Stoep
[ Upstream commit af545bb5ee53f5261db631db2ac4cde54038bdaf ]
During __vsock_create() CAP_NET_ADMIN is used to determine if the
vsock_sock->trusted should be set to true. This value is used later
for determing if a remote connection should be allowed to connect
to a restri
On Sat, 31 Oct 2020 19:56:05 +0100 Andrew Lunn wrote:
> On Sat, Oct 31, 2020 at 11:10:53AM +0800, YueHaibing wrote:
> > gpiod_to_irq() never return 0, but returns negative in
> > case of error, check it and set gpio_irq to 0.
> >
> > Fixes: 73970055450e ("sfp: add SFP module support")
> > Signed-o
From: Jeff Vander Stoep
[ Upstream commit af545bb5ee53f5261db631db2ac4cde54038bdaf ]
During __vsock_create() CAP_NET_ADMIN is used to determine if the
vsock_sock->trusted should be set to true. This value is used later
for determing if a remote connection should be allowed to connect
to a restri
From: Jeff Vander Stoep
[ Upstream commit af545bb5ee53f5261db631db2ac4cde54038bdaf ]
During __vsock_create() CAP_NET_ADMIN is used to determine if the
vsock_sock->trusted should be set to true. This value is used later
for determing if a remote connection should be allowed to connect
to a restri
From: Jeff Vander Stoep
[ Upstream commit af545bb5ee53f5261db631db2ac4cde54038bdaf ]
During __vsock_create() CAP_NET_ADMIN is used to determine if the
vsock_sock->trusted should be set to true. This value is used later
for determing if a remote connection should be allowed to connect
to a restri
From: Jeff Vander Stoep
[ Upstream commit af545bb5ee53f5261db631db2ac4cde54038bdaf ]
During __vsock_create() CAP_NET_ADMIN is used to determine if the
vsock_sock->trusted should be set to true. This value is used later
for determing if a remote connection should be allowed to connect
to a restri
1 - 100 of 438 matches
Mail list logo
