On 11/2/2020 5:34 PM, Pavana Sharma wrote: >> How many times have i asked for you to add kerneldoc for this new >> value? How many times have you not done so? > > I have added kerneldoc comment for the new value added. > >> NACK. > >> If you don't understand a comment, please ask. > > Ok, explain what do you expect by that comment. What Andrew wants you to do is add a comment like this: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/include/linux/phy.h#n88 -- Florian
- Re: [PATCH v5 3/3] net: dsa: mv88e6xxx: Add support for m... Andrew Lunn
- [PATCH v6 0/4] Add support for mv88e6393x family of ... Pavana Sharma
- Re: [PATCH v6 0/4] Add support for mv88e6393x fa... Marek Behun
- [PATCH v6 3/4] net: dsa: mv88e6xxx: Add support ... Pavana Sharma
- Re: [PATCH v6 3/4] net: dsa: mv88e6xxx: Add ... Marek Behun
- [PATCH v7 0/4] Add support for mv88e6393... Pavana Sharma
- [PATCH v7 1/4] dt-bindings: net: Ad... Pavana Sharma
- [PATCH v7 2/4] net: phy: Add 5GBASE... Pavana Sharma
- Re: [PATCH v7 2/4] net: phy: Add 5G... Andrew Lunn
- [PATCH v7 2/4] net: phy: Add 5GBASE... Pavana Sharma
- Re: [PATCH v7 2/4] net: phy: Add 5G... Florian Fainelli
- Re: [PATCH v7 2/4] net: phy: Add 5G... Andrew Lunn
- [PATCH v8 0/4] Add support for mv88... Pavana Sharma
- [PATCH v8 1/4] dt-bindings: net: Ad... Pavana Sharma
- Re: [PATCH v8 1/4] dt-bindings: net... Jakub Kicinski
- [PATCH v8 3/4] net: dsa: mv88e6xxx:... Pavana Sharma
- Re: [PATCH v8 3/4] net: dsa: mv88e6... Jakub Kicinski
- [PATCH v8 2/4] net: phy: Add 5GBASE... Pavana Sharma
- [PATCH v8 4/4] net: dsa: mv88e6xxx:... Pavana Sharma
- Re: [PATCH v8 4/4] net: dsa: mv88e6... Jakub Kicinski
- [PATCH v7 3/4] net: dsa: mv88e6xxx:... Pavana Sharma