Re: [PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support

2020-10-22 Thread Greg KH
On Fri, Oct 23, 2020 at 09:49:46AM +0300, Leon Romanovsky wrote: > On Thu, Oct 22, 2020 at 05:33:28PM -0700, Dave Ertman wrote: > > <...> > > > Dave Ertman (1): > > Add auxiliary bus support > > We are in merge window now and both netdev and RDMA are closed for > submissions. So I'll send my m

Re: [PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support

2020-10-22 Thread Leon Romanovsky
On Thu, Oct 22, 2020 at 05:33:28PM -0700, Dave Ertman wrote: <...> > Dave Ertman (1): > Add auxiliary bus support We are in merge window now and both netdev and RDMA are closed for submissions. So I'll send my mlx5 conversion patches once -rc1 will be tagged. However, It is important that thi

[PATCHv3 net 1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition

2020-10-22 Thread Hangbin Liu
Based on RFC7112, Section 6: IANA has added the following "Type 4 - Parameter Problem" message to the "Internet Control Message Protocol version 6 (ICMPv6) Parameters" registry: CODE NAME/DESCRIPTION 3 IPv6 First Fragment has incomplete IPv6 Header Chain Signed-of

[PATCHv3 net 2/2] IPv6: reply ICMP error if the first fragment doesn't include all headers

2020-10-22 Thread Hangbin Liu
Based on RFC 8200, Section 4.5 Fragment Header: - If the first fragment does not include all headers through an Upper-Layer header, then that fragment should be discarded and an ICMP Parameter Problem, Code 3, message should be sent to the source of the fragment, with the Pointer

[PATCHv3 net 0/2] IPv6: reply ICMP error if fragment doesn't contain all headers

2020-10-22 Thread Hangbin Liu
When our Engineer run latest IPv6 Core Conformance test, test v6LC.1.3.6: First Fragment Doesn’t Contain All Headers[1] failed. The test purpose is to verify that the node(Linux for example) should properly process IPv6 packets that don’t include all the headers through the Upper-Layer header. Bas

Re: lan78xx: /sys/class/net/eth0/carrier stuck at 1

2020-10-22 Thread Juerg Haefliger
On Wed, 21 Oct 2020 21:35:48 +0200 Andrew Lunn wrote: > On Wed, Oct 21, 2020 at 05:00:53PM +0200, Juerg Haefliger wrote: > > Hi, > > > > If the lan78xx driver is compiled into the kernel and the network cable is > > plugged in at boot, /sys/class/net/eth0/carrier is stuck at 1 and doesn't > > to

Re: [PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-22 Thread Yunsheng Lin
On 2020/10/23 13:15, Zenghui Yu wrote: > When unbinding the hns3 driver with the HNS3 VF, I got the following > kernel panic: > > [ 265.709989] Unable to handle kernel paging request at virtual address > 800054627000 > [ 265.717928] Mem abort info: > [ 265.720740] ESR = 0x9647 > [ 2

Re: [RFC bpf-next 00/16] bpf: Speed up trampoline attach

2020-10-22 Thread Jiri Olsa
On Thu, Oct 22, 2020 at 04:52:29PM -0400, Steven Rostedt wrote: > On Thu, 22 Oct 2020 12:21:50 -0400 > Steven Rostedt wrote: > > > On Thu, 22 Oct 2020 10:42:05 -0400 > > Steven Rostedt wrote: > > > > > I'd like to see how batch functions will work. I guess I need to start > > > looking at the b

[net v2 7/7] ch_ktls: tcb update fails sometimes

2020-10-22 Thread Rohit Maheshwari
context id and port id should be filled while sending tcb update. Signed-off-by: Rohit Maheshwari --- .../chelsio/inline_crypto/ch_ktls/chcr_ktls.c| 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls

[net v2 0/7] cxgb4/ch_ktls: Fixes in nic tls code

2020-10-22 Thread Rohit Maheshwari
This series helps in fixing multiple nic ktls issues. Series is broken into 7 patches. Patch 1 avoids deciding tls packet based on decrypted bit. If its a retransmit packet which has tls handshake and finish (for encryption), decrypted bit won't be set there, and so we can't rely on decrypted bit.

[net v2 2/7] ch_ktls: Correction in finding correct length

2020-10-22 Thread Rohit Maheshwari
There is a possibility of linear skbs coming in. Correcting the length extraction logic. Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling") Signed-off-by: Rohit Maheshwari --- .../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 62 +++ 1 file changed, 37 insertions(+), 2

[net v2 5/7] ch_ktls: packet handling prior to start marker

2020-10-22 Thread Rohit Maheshwari
There could be a case where ACK for tls exchanges prior to start marker is missed out, and by the time tls is offloaded. This pkt should not be discarded and handled carefully. It could be plaintext alone or plaintext + finish as well. Signed-off-by: Rohit Maheshwari --- .../chelsio/inline_crypt

[net v2 6/7] ch_ktls/cxgb4: handle partial tag alone SKBs

2020-10-22 Thread Rohit Maheshwari
If TCP congestion caused a very small packets which only has some part fo the TAG, and that too is not till the end. HW can't handle such case, so falling back to sw crypto in such cases. v1->v2: - Marked chcr_ktls_sw_fallback() static. Signed-off-by: Rohit Maheshwari --- .../ethernet/chelsio/c

[net v2 4/7] ch_ktls: Correction in middle record handling

2020-10-22 Thread Rohit Maheshwari
If a record starts in middle, reset TCB UNA so that we could avoid sending out extra packet which is needed to make it 16 byte aligned to start AES CTR. Signed-off-by: Rohit Maheshwari --- .../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 21 +-- 1 file changed, 15 insertions(+), 6

[net v2 3/7] cxgb4/ch_ktls: creating skbs causes panic

2020-10-22 Thread Rohit Maheshwari
Creating SKB per tls record and freeing the original one causes panic. There will be race if connection reset is requested. By freeing original skb, refcnt will be decremented and that means, there is no pending record to send, and so tls_dev_del will be requested in control path while SKB of relat

[net v2 1/7] cxgb4/ch_ktls: decrypted bit is not enough

2020-10-22 Thread Rohit Maheshwari
If skb has retransmit data starting before start marker, e.g. ccs, decrypted bit won't be set for that, and if it has some data to encrypt, then it must be given to crypto ULD. So in place of decrypted, check if socket is tls offloaded. Also, unless skb has some data to encrypt, no need to give it

[PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-22 Thread Zenghui Yu
When unbinding the hns3 driver with the HNS3 VF, I got the following kernel panic: [ 265.709989] Unable to handle kernel paging request at virtual address 800054627000 [ 265.717928] Mem abort info: [ 265.720740] ESR = 0x9647 [ 265.723810] EC = 0x25: DABT (current EL), IL = 32 bits

[PATCHv4 net-next] dropwatch: Support monitoring of dropped frames

2020-10-22 Thread izabela . bakollari
From: Izabela Bakollari Dropwatch is a utility that monitors dropped frames by having userspace record them over the dropwatch protocol over a file. This augument allows live monitoring of dropped frames using tools like tcpdump. With this feature, dropwatch allows two additional commands (start

[PATCH iproute2-next 5/5] examples/bpf: add bpf examples with BTF defined maps

2020-10-22 Thread Hangbin Liu
Users should try use the new BTF defined maps instead of struct bpf_elf_map defined maps. The tail call examples are not added yet as libbpf doesn't currently support declaratively populating tail call maps. Reviewed-by: Toke Høiland-Jørgensen Signed-off-by: Hangbin Liu --- examples/bpf/README

[PATCH iproute2-next 2/5] lib: rename bpf.c to bpf_legacy.c

2020-10-22 Thread Hangbin Liu
This is a preparation for later libbpf support in iproute2. Function bpf_prog_load() is also renamed to bpf_prog_load_buf() as there is a conflict with libbpf. Reviewed-by: Toke Høiland-Jørgensen Signed-off-by: Hangbin Liu --- include/bpf_util.h | 6 +++--- ip/ipvrf.c

[PATCH iproute2-next 3/5] lib: add libbpf support

2020-10-22 Thread Hangbin Liu
This patch converts iproute2 to use libbpf for loading and attaching BPF programs when it is available, which is started by Toke's implementation[1]. With libbpf iproute2 could correctly process BTF information and support the new-style BTF-defined maps, while keeping compatibility with the old int

[PATCH iproute2-next 1/5] configure: add check_libbpf() for later libbpf support

2020-10-22 Thread Hangbin Liu
This patch adds a check to see if we support libbpf. By default the system libbpf will be used, but static linking against a custom libbpf version can be achieved by passing LIBBPF_DIR to configure. FORCE_LIBBPF can be set to force configure to abort if no suitable libbpf is found, which is useful

[PATCH iproute2-next 4/5] examples/bpf: move struct bpf_elf_map defined maps to legacy folder

2020-10-22 Thread Hangbin Liu
Reviewed-by: Toke Høiland-Jørgensen Signed-off-by: Hangbin Liu --- examples/bpf/README| 14 +- examples/bpf/{ => legacy}/bpf_cyclic.c | 2 +- examples/bpf/{ => legacy}/bpf_graft.c | 2 +- examples/bpf/{ => legacy}/bpf_map_in_map.c | 2 +- examples/

[PATCH iproute2-next 0/5] iproute2: add libbpf support

2020-10-22 Thread Hangbin Liu
This series converts iproute2 to use libbpf for loading and attaching BPF programs when it is available. This means that iproute2 will correctly process BTF information and support the new-style BTF-defined maps, while keeping compatibility with the old internal map definition syntax. This is achi

[PATCH] net: ucc_geth: Drop extraneous parentheses in comparison

2020-10-22 Thread Michael Ellerman
Clang warns about the extra parentheses in this comparison: drivers/net/ethernet/freescale/ucc_geth.c:1361:28: warning: equality comparison with extraneous parentheses if ((ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII)) ~^~~ It seem

Re: [PATCH v6 1/2] bus: mhi: Add mhi_queue_is_full function

2020-10-22 Thread Hemant Kumar
Hi Loic, On 10/16/20 2:20 AM, Loic Poulain wrote: This function can be used by client driver to determine whether it's possible to queue new elements in a channel ring. Signed-off-by: Loic Poulain [..] +static inline bool mhi_is_ring_full(struct mhi_controller *mhi_cntrl, +

Re: [PATCH net] gianfar: Account for Tx PTP timestamp in the skb headroom

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 12:09:00 + Claudiu Manoil wrote: > >-Original Message- > >From: Jakub Kicinski > >Sent: Wednesday, October 21, 2020 9:00 PM > >To: Claudiu Manoil > >Cc: netdev@vger.kernel.org; David S . Miller ; > >james.jur...@ametek.com > >Subject: Re: [PATCH net] gianfar: Accou

[PATCH/RFC net v2] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-22 Thread Moritz Fischer
The driver does not implement a shutdown handler which leads to issues when using kexec in certain scenarios. The NIC keeps on fetching descriptors which gets flagged by the IOMMU with errors like this: DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request

Re: [PATCH net RFC] net: Clear IFF_TX_SKB_SHARING for all Ethernet devices using skb_padto

2020-10-22 Thread Xie He
On Thu, Oct 22, 2020 at 6:56 PM Xie He wrote: > > My patch isn't complete. Because there are so many drivers with this > problem, I feel it's hard to solve them all at once. So I only grepped > "skb_padto" under "drivers/net/ethernet". There are other drivers > under "ethernet" using "skb_pad", "s

Re: [PATCH net RFC] net: Clear IFF_TX_SKB_SHARING for all Ethernet devices using skb_padto

2020-10-22 Thread Xie He
On Thu, Oct 22, 2020 at 5:44 PM Jakub Kicinski wrote: > > On Thu, 22 Oct 2020 12:59:45 -0700 Xie He wrote: > > > > But I also see some drivers that want to pad the skb to a strange > > length, and don't set their special min_mtu to match this length. For > > example: > > > > drivers/net/ethernet/p

Re: [PATCH ghak90 V9 05/13] audit: log container info of syscalls

2020-10-22 Thread Paul Moore
On Wed, Oct 21, 2020 at 12:39 PM Richard Guy Briggs wrote: > Here is an exmple I was able to generate after updating the testsuite > script to include a signalling example of a nested audit container > identifier: > > > type=PROCTITLE msg=audit(2020-10-21 10:31:16.655:6731) : > proctitle=/us

Re: [PATCH net RFC] net: Clear IFF_TX_SKB_SHARING for all Ethernet devices using skb_padto

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 12:59:45 -0700 Xie He wrote: > On Thu, Oct 22, 2020 at 8:22 AM Jakub Kicinski wrote: > > > > Are most of these drivers using skb_padto()? Is that the reason they > > can't be sharing the SKB? > > Yes, I think if a driver calls skb_pad / skb_padto / skb_put_padto / > eth_skb_

[PATCH v3 06/10] ASoC: SOF: Intel: Remove IPC flood test support in SOF core

2020-10-22 Thread Dave Ertman
From: Ranjani Sridharan Remove the IPC flood test support in the SOF core as it is now added in the IPC flood test client. Reviewed-by: Pierre-Louis Bossart Signed-off-by: Fred Oh Signed-off-by: Ranjani Sridharan Signed-off-by: Dave Ertman --- sound/soc/sof/Kconfig| 8 -- sound/soc/so

[PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support

2020-10-22 Thread Dave Ertman
Brief history of Auxiliary Bus == The auxiliary bus code was originally submitted upstream as virtual bus, and was submitted through the netdev tree.  This process generated up to v4.  This discussion can be found here: https://lore.kernel.org/netdev/2019192219.30259

[PATCH v3 07/10] ASoC: SOF: sof-client: Add client APIs to access probes ops

2020-10-22 Thread Dave Ertman
From: Ranjani Sridharan Add client APIs to invoke the platform-specific DSP probes ops. Also, add a new API to get the SOF core device pointer which will be used for DMA buffer allocation. Reviewed-by: Pierre-Louis Bossart Tested-by: Fred Oh Signed-off-by: Ranjani Sridharan Signed-off-by: Dav

[PATCH v3 08/10] ASoC: SOF: compress: move and export sof_probe_compr_ops

2020-10-22 Thread Dave Ertman
From: Ranjani Sridharan sof_probe_compr_ops are not platform-specific. So move it to common compress code and export the symbol. The compilation of the common compress code is already dependent on the selection of CONFIG_SND_SOC_SOF_DEBUG_PROBES, so no need to check the Kconfig section for defini

[PATCH v3 10/10] ASoC: SOF: Intel: CNL: register probes client

2020-10-22 Thread Dave Ertman
From: Ranjani Sridharan Register the client device for probes support on the CNL platform. Creating this client device alleviates the need for modifying the sound card definitions in the existing machine drivers to add support for the new probes feature in the FW. This will result in the creation

[PATCH v3 02/10] ASoC: SOF: Introduce descriptors for SOF client

2020-10-22 Thread Dave Ertman
From: Ranjani Sridharan A client in the SOF (Sound Open Firmware) context is a device that needs to communicate with the DSP via IPC messages. The SOF core is responsible for serializing the IPC messages to the DSP from the different clients. One example of an SOF client would be an IPC test clie

[PATCH v3 03/10] ASoC: SOF: Create client driver for IPC test

2020-10-22 Thread Dave Ertman
From: Ranjani Sridharan Create an SOF client driver for IPC flood test. This driver is used to set up the debugfs entries and the read/write ops for initiating the IPC flood test that would be used to measure the min/max/avg response times for sending IPCs to the DSP. The debugfs ops definitions

[PATCH v3 09/10] ASoC: SOF: Add new client driver for probes support

2020-10-22 Thread Dave Ertman
From: Ranjani Sridharan Add a new client driver for probes support and move all the probes-related code from the core to the client driver. The probes client driver registers a component driver with one CPU DAI driver for extraction and creates a new sound card with one DUMMY DAI link with a dum

[PATCH v3 05/10] ASoC: SOF: Intel: Define ops for client registration

2020-10-22 Thread Dave Ertman
From: Ranjani Sridharan Define client ops for Intel platforms. For now, we only add 2 IPC test clients that will be used for run tandem IPC flood tests for. For ACPI platforms, change the Kconfig to select SND_SOC_SOF_PROBE_WORK_QUEUE to allow the ancillary driver to probe when the client is reg

[PATCH v3 01/10] Add auxiliary bus support

2020-10-22 Thread Dave Ertman
Add support for the Auxiliary Bus, auxiliary_device and auxiliary_driver. It enables drivers to create an auxiliary_device and bind an auxiliary_driver to it. The bus supports probe/remove shutdown and suspend/resume callbacks. Each auxiliary_device has a unique string based id; driver binds to an

[PATCH v3 04/10] ASoC: SOF: ops: Add ops for client registration

2020-10-22 Thread Dave Ertman
From: Ranjani Sridharan Add new ops for registering/unregistering clients based on DSP capabilities and/or DT information. Reviewed-by: Pierre-Louis Bossart Signed-off-by: Ranjani Sridharan Signed-off-by: Dave Ertman --- sound/soc/sof/core.c | 10 ++ sound/soc/sof/ops.h | 14

Re: [PATCH/RFC net] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-22 Thread Moritz Fischer
On Thu, Oct 22, 2020 at 04:04:16PM -0700, James Bottomley wrote: > On Thu, 2020-10-22 at 15:06 -0700, Moritz Fischer wrote: > > The driver does not implement a shutdown handler which leads to > > issues > > when using kexec in certain scenarios. The NIC keeps on fetching > > descriptors which gets

Re: [PATCH v2 2/2] net: phy: adin: implement cable-test support

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 10:45:51 +0300 Alexandru Ardelean wrote: > The ADIN1300/ADIN1200 support cable diagnostics using TDR. > > The cable fault detection is automatically run on all four pairs looking at > all combinations of pair faults by first putting the PHY in standby (clear > the LINK_EN bit,

[PATCH net 1/3] ionic: clean up sparse complaints

2020-10-22 Thread Shannon Nelson
The sparse complaints around the static_asserts were obscuring more useful complaints. So, don't check the static_asserts, and fix the remaining sparse complaints. Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_dev.c | 4 +-- .../net/ethernet/pensando/ionic/ionic_dev

[PATCH net 0/3] ionic: memory usage fixes

2020-10-22 Thread Shannon Nelson
This patchset addresses some memory leaks and incorrect io reads. Shannon Nelson (3): ionic: clean up sparse complaints ionic: no rx flush in deinit ionic: fix mem leak in rx_empty .../net/ethernet/pensando/ionic/ionic_dev.c | 4 +- .../net/ethernet/pensando/ionic/ionic_dev.h | 2 +

[PATCH net 2/3] ionic: no rx flush in deinit

2020-10-22 Thread Shannon Nelson
Kmemleak pointed out to us that ionic_rx_flush() is sending skbs into napi_gro_XXX with a disabled napi context, and these end up getting lost and leaked. We can safely remove the flush. Fixes: 0f3154e6bcb3 ("ionic: Add Tx and Rx handling") Signed-off-by: Shannon Nelson --- drivers/net/ethernet

[PATCH net 3/3] ionic: fix mem leak in rx_empty

2020-10-22 Thread Shannon Nelson
The sentinel descriptor entry was getting missed in the traverse of the ring from head to tail, so change to a loop of 0 to the end. Fixes: f1d2e894f1b7 ("ionic: use index not pointer for queue tracking") Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_txrx.c | 24 ++

Re: [net 3/7] cxgb4/ch_ktls: creating skbs causes panic

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 15:40:15 +0530 Rohit Maheshwari wrote: > Creating SKB per tls record and freeing the original one causes > panic. There will be race if connection reset is requested. By > freeing original skb, refcnt will be decremented and that means, > there is no pending record to send, and

Re: [net 6/7] ch_ktls/cxgb4: handle partial tag alone SKBs

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 15:40:18 +0530 Rohit Maheshwari wrote: > If TCP congestion caused a very small packets which only has some > part fo the TAG, and that too is not till the end. HW can't handle > such case, so falling back to sw crypto in such cases. > > Signed-off-by: Rohit Maheshwari drivers

Re: [RFC][PATCH v3 3/3] Rename nla_strlcpy to nla_strscpy.

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 13:04:32 -0700 Kees Cook wrote: > > > > From: Francis Laniel > > > > > > > > Calls to nla_strlcpy are now replaced by calls to nla_strscpy which is > > > > the > > > > new name of this function. > > > > > > > > Signed-off-by: Francis Laniel > > > > > > The Subject could

Re: [PATCH/RFC net] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-22 Thread James Bottomley
On Thu, 2020-10-22 at 15:06 -0700, Moritz Fischer wrote: > The driver does not implement a shutdown handler which leads to > issues > when using kexec in certain scenarios. The NIC keeps on fetching > descriptors which gets flagged by the IOMMU with errors like this: > > DMAR: DMAR:[DMA read] Requ

Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-10-22 Thread Thomas Gleixner
On Thu, Oct 22 2020 at 09:28, Marcelo Tosatti wrote: > On Wed, Oct 21, 2020 at 10:25:48PM +0200, Thomas Gleixner wrote: >> The right answer to this is to utilize managed interrupts and have >> according logic in your network driver to handle CPU hotplug. When a CPU >> goes down, then the queue whic

RE: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread David Laight
From: Al Viro > Sent: 22 October 2020 20:25 > > On Thu, Oct 22, 2020 at 12:04:52PM -0700, Nick Desaulniers wrote: > > > Passing an `unsigned long` as an `unsigned int` does no such > > narrowing: https://godbolt.org/z/TvfMxe (same vice-versa, just tail > > calls, no masking instructions). > > So

[PATCH/RFC net] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-22 Thread Moritz Fischer
The driver does not implement a shutdown handler which leads to issues when using kexec in certain scenarios. The NIC keeps on fetching descriptors which gets flagged by the IOMMU with errors like this: DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request

RE: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread David Laight
From: Nick Desaulniers > Sent: 22 October 2020 20:05 > ... > Passing an `unsigned long` as an `unsigned int` does no such > narrowing: https://godbolt.org/z/TvfMxe (same vice-versa, just tail > calls, no masking instructions). Right but is the called function going to use 32bit ops and/or mask th

Re: [PATCH net] chelsio/chtls: fix memory leak

2020-10-22 Thread kernel test robot
287d35405989cfe0090e3059f7788dc531879a8d config: arm64-randconfig-r001-20201022 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ee6abef5323d59b983129bf3514ef6775d1d6cd5) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests

[GIT PULL] Networking

2020-10-22 Thread Jakub Kicinski
Hi Linus! Latest fixes from the networking tree. Experimenting with the format of the description further, I'll find out if you liked it based on how it ends up looking in the tree :) The following changes since commit 9ff9b0d392ea08090cd1780fb196f36dbb586529: Merge tag 'net-next-5.10' of g

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Al Viro
On Thu, Oct 22, 2020 at 01:59:32PM -0700, Eric Biggers wrote: > Also note the following program succeeds on Linux 5.9 on x86_64. On kernels > that have this bug, it should fail. (I couldn't get it to actually fail, so > it > must depend on the compiler and/or the kernel config...) It doesn't.

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Eric Biggers
On Thu, Oct 22, 2020 at 10:00:44AM -0700, Nick Desaulniers wrote: > On Thu, Oct 22, 2020 at 9:40 AM Matthew Wilcox wrote: > > > > On Thu, Oct 22, 2020 at 04:35:17PM +, David Laight wrote: > > > Wait... > > > readv(2) defines: > > > ssize_t readv(int fd, const struct iovec *iov, int iovcn

Re: [RFC bpf-next 00/16] bpf: Speed up trampoline attach

2020-10-22 Thread Steven Rostedt
On Thu, 22 Oct 2020 12:21:50 -0400 Steven Rostedt wrote: > On Thu, 22 Oct 2020 10:42:05 -0400 > Steven Rostedt wrote: > > > I'd like to see how batch functions will work. I guess I need to start > > looking at the bpf trampoline, to see if we can modify the ftrace > > trampoline to have a quick

Re: [PATCH v6 5/6] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support.

2020-10-22 Thread Pavel Machek
Hi! > > > +++ b/drivers/net/can/ctucanfd/Kconfig > > > @@ -21,4 +21,15 @@ config CAN_CTUCANFD_PCI > > > PCIe board with PiKRON.com designed transceiver riser shield is > > > available at https://gitlab.fel.cvut.cz/canbus/pcie-ctu_can_fd . > > > > > > +config CAN_CTUCANFD_PLATFORM > > > + trist

[PATCH bpf] selftest/bpf: fix profiler test using CO-RE relocation for enums

2020-10-22 Thread Andrii Nakryiko
Instead of hard-coding invalid pids_cgrp_id, use Kconfig to detect the presence of that enum value and CO-RE to capture its actual value in the hosts's kernel. Tested-by: Song Liu Fixes: 03d4d13fab3f ("selftests/bpf: Add profiler test") Signed-off-by: Andrii Nakryiko --- tools/testing/selftests

Re: [PATCH v6 3/6] can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part.

2020-10-22 Thread Pavel Pisa
Hello Pavel, thanks for review. For everybody: the amount of code, analyses etc. is really huge. If you do not have time and consider this discussion as lost of your time and or badwidth send me a note. I will remove your from the recipients list and if you think that some lists should be omitted

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Al Viro
On Thu, Oct 22, 2020 at 09:06:29PM +0100, Al Viro wrote: > On Thu, Oct 22, 2020 at 08:24:58PM +0100, Al Viro wrote: > > > Depending upon the calling conventions, compiler might do truncation in > > caller or > > in a callee, but it must be done _somewhere_. > > Unless I'm misreading AAPCS64, >

Re: [RFC][PATCH v3 3/3] Rename nla_strlcpy to nla_strscpy.

2020-10-22 Thread Kees Cook
On Thu, Oct 22, 2020 at 11:41:31AM +0200, Francis Laniel wrote: > Le jeudi 22 octobre 2020, 01:49:59 CEST Kees Cook a écrit : > > On Tue, Oct 20, 2020 at 06:47:07PM +0200, > > laniel_fran...@privacyrequired.com > wrote: > > > From: Francis Laniel > > > > > > Calls to nla_strlcpy are now replace

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Al Viro
On Thu, Oct 22, 2020 at 08:24:58PM +0100, Al Viro wrote: > Depending upon the calling conventions, compiler might do truncation in > caller or > in a callee, but it must be done _somewhere_. Unless I'm misreading AAPCS64, "Unlike in the 32-bit AAPCS, named integral values must be narrowe

Re: [PATCH net RFC] net: Clear IFF_TX_SKB_SHARING for all Ethernet devices using skb_padto

2020-10-22 Thread Xie He
On Thu, Oct 22, 2020 at 8:22 AM Jakub Kicinski wrote: > > Are most of these drivers using skb_padto()? Is that the reason they > can't be sharing the SKB? Yes, I think if a driver calls skb_pad / skb_padto / skb_put_padto / eth_skb_pad, the driver can't accept shared skbs because it may modify th

Re: [RFC PATCH iproute2] bridge: add support for L2 multicast groups

2020-10-22 Thread Stephen Hemminger
On Sat, 17 Oct 2020 21:45:26 +0300 Vladimir Oltean wrote: > Extend the 'bridge mdb' command for the following syntax: > bridge mdb add dev br0 port swp0 grp 01:02:03:04:05:06 permanent > > Signed-off-by: Vladimir Oltean > --- > bridge/mdb.c | 54 ++

Re: [PATCH net] tcp: fix to update snd_wl1 in bulk receiver fast path

2020-10-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 22 Oct 2020 10:33:31 -0400 you wrote: > From: Neal Cardwell > > In the header prediction fast path for a bulk data receiver, if no > data is newly acknowledged then we do not call tcp_ack() and do not > call tcp_ack_up

Re: [PATCH net] tcp: fix to update snd_wl1 in bulk receiver fast path

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 10:33:31 -0400 Neal Cardwell wrote: > From: Neal Cardwell > > In the header prediction fast path for a bulk data receiver, if no > data is newly acknowledged then we do not call tcp_ack() and do not > call tcp_ack_update_window(). This means that a bulk receiver that > receive

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Al Viro
On Thu, Oct 22, 2020 at 08:24:58PM +0100, Al Viro wrote: > On Thu, Oct 22, 2020 at 12:04:52PM -0700, Nick Desaulniers wrote: > > > Passing an `unsigned long` as an `unsigned int` does no such > > narrowing: https://godbolt.org/z/TvfMxe (same vice-versa, just tail > > calls, no masking instructions

Re: [PATCH net v2] net: Properly typecast int values to set sk_max_pacing_rate

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 09:48:48 +0200 Eric Dumazet wrote: > On Thu, Oct 22, 2020 at 8:42 AM Ke Li wrote: > > > > In setsockopt(SO_MAX_PACING_RATE) on 64bit systems, sk_max_pacing_rate, > > after extended from 'u32' to 'unsigned long', takes unintentionally > > hiked value whenever assigned from an 'i

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Al Viro
On Thu, Oct 22, 2020 at 12:04:52PM -0700, Nick Desaulniers wrote: > Passing an `unsigned long` as an `unsigned int` does no such > narrowing: https://godbolt.org/z/TvfMxe (same vice-versa, just tail > calls, no masking instructions). > So if rw_copy_check_uvector() is inlined into import_iovec() (

Re: [PATCH 1/7] ipvs: adjust the debug info in function set_tcp_state

2020-10-22 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 22 Oct 2020 19:29:19 +0200 you wrote: > From: "longguang.yue" > > Outputting client,virtual,dst addresses info when tcp state changes, > which makes the connection debug more clear > > Signed-off-by: longguang.yue >

Re: [RFC PATCH net-next 1/9] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-10-22 Thread Florian Fainelli
On 10/22/20 5:37 AM, Vladimir Oltean wrote: > On Thu, Oct 22, 2020 at 12:54:52PM +0200, Kurt Kanzenbach wrote: >> On Wed Oct 21 2020, Florian Fainelli wrote: >>> On 10/21/2020 5:16 PM, Vladimir Oltean wrote: On Wed, Oct 21, 2020 at 08:52:01AM +0200, Kurt Kanzenbach wrote: > On Mon Oct 19 2

Re: [PATCH 0/7] Netfilter fixes for net

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 19:29:18 +0200 Pablo Neira Ayuso wrote: > Hi Jakub, > > The following patchset contains Netfilter fixes for net: > > 1) Update debugging in IPVS tcp protocol handler to make it easier >to understand, from longguang.yue > > 2) Update TCP tracker to deal with keepalive pack

Re: pull-request: bpf 2020-10-22

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 16:17:24 +0200 Daniel Borkmann wrote: > Hi David, hi Jakub, > > The following pull-request contains BPF updates for your *net* tree. > > We've added 8 non-merge commits during the last 4 day(s) which contain > a total of 16 files changed, 426 insertions(+), 102 deletions(-). >

[PATCH net] chelsio/chtls: fix memory leak

2020-10-22 Thread Vinay Kumar Yadav
Correct skb refcount in alloc_ctrl_skb(), causing skb memleak when chtls_send_abort() called with NULL skb. Also race between user context and softirq causing memleak, consider the call sequence scenario chtls_setkey() //user context chtls_peer_close() chtls_abort_req_rss() chtls_setkey()

[PATCH net,v2] chelsio/chtls: fix tls record info to user

2020-10-22 Thread Vinay Kumar Yadav
chtls_pt_recvmsg() receives a skb with tls header and subsequent skb with data, need to finalize the data copy whenever next skb with tls header is available. but here current tls header is overwritten by next available tls header, ends up corrupting user buffer data. fixing it by finalizing curren

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Al Viro
On Thu, Oct 22, 2020 at 05:40:40PM +0100, Matthew Wilcox wrote: > On Thu, Oct 22, 2020 at 04:35:17PM +, David Laight wrote: > > Wait... > > readv(2) defines: > > ssize_t readv(int fd, const struct iovec *iov, int iovcnt); > > It doesn't really matter what the manpage says. What does the A

Re: [GIT PULL] 9p update for 5.10-rc1

2020-10-22 Thread pr-tracker-bot
The pull request you sent on Thu, 22 Oct 2020 14:08:26 +0200: > https://github.com/martinetd/linux tags/9p-for-5.10-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/334d431f65f05d3412c921875717b8c4ec6da71c Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs

Re: [PATCH net v2] net: Properly typecast int values to set sk_max_pacing_rate

2020-10-22 Thread Li, Ke
Thanks for the info, Eric! That explains why checkpatch.pl hadn't complained with v1 patch. Best, -Ke On 10/22/20, 7:19 AM, "Eric Dumazet" wrote: On Thu, Oct 22, 2020 at 10:43 AM Li, Ke wrote: > > Thank you, Eric! > > Nice to know the recent change to wrap-at-100. Will th

Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-10-22 Thread Nitesh Narayan Lal
On 10/20/20 10:39 AM, Nitesh Narayan Lal wrote: > On 10/20/20 9:41 AM, Peter Zijlstra wrote: >> On Tue, Oct 20, 2020 at 09:00:01AM -0400, Nitesh Narayan Lal wrote: >>> On 10/20/20 3:30 AM, Peter Zijlstra wrote: On Mon, Oct 19, 2020 at 11:00:05AM -0300, Marcelo Tosatti wrote: >> So I think

Re: [PATCH net] tcp: fix to update snd_wl1 in bulk receiver fast path

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 13:04:04 -0400 Neal Cardwell wrote: > > In that case - can I slap: > > > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > > > on it? > > Yes, slapping that Fixes footer on it sounds fine to me. I see > that it does apply cleanly to 1da177e4c3f4. FWIW even if it didn't - my mod

Re: [PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-22 Thread Marc Kleine-Budde
On 10/22/20 7:34 PM, Oliver Hartkopp wrote: > @Marc: Can you please make sure that it doesn't get into upstream? Tnx! Ok, I've removed can: vxcan: Fix memleak in vxcan_newlink [Dinghao Liu] from my linux-can/testing. Marc -- Pengutronix e.K. | Marc Kleine-Budde

Re: [RFC PATCH net-next 0/3] sock: Fix sock queue mapping to include device

2020-10-22 Thread Willem de Bruijn
On Wed, Oct 21, 2020 at 3:51 PM Harshitha Ramamurthy wrote: > > In XPS, the transmit queue selected for a packet is saved in the associated > sock for the packet and is then used to avoid recalculating the queue > on subsequent sends. The problem is that the corresponding device is not > also reco

Re: [PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-22 Thread Oliver Hartkopp
On 22.10.20 18:14, Jakub Kicinski wrote: On Wed, 21 Oct 2020 13:20:16 +0200 Oliver Hartkopp wrote: On 21.10.20 07:21, Dinghao Liu wrote: When rtnl_configure_link() fails, peer needs to be freed just like when register_netdevice() fails. Signed-off-by: Dinghao Liu Acked-by: Oliver Hartkop

[PATCH 5/7] docs: nf_flowtable: fix typo.

2020-10-22 Thread Pablo Neira Ayuso
From: Jeremy Sowden "mailined" should be "mainlined." Signed-off-by: Jeremy Sowden Signed-off-by: Pablo Neira Ayuso --- Documentation/networking/nf_flowtable.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/nf_flowtable.rst b/Documentation/netw

[PATCH 4/7] netfilter: ebtables: Fixes dropping of small packets in bridge nat

2020-10-22 Thread Pablo Neira Ayuso
From: Timothée COCAULT Fixes an error causing small packets to get dropped. skb_ensure_writable expects the second parameter to be a length in the ethernet payload.=20 If we want to write the ethernet header (src, dst), we should pass 0. Otherwise, packets with small payloads (< ETH_ALEN) will ge

[PATCH 1/7] ipvs: adjust the debug info in function set_tcp_state

2020-10-22 Thread Pablo Neira Ayuso
From: "longguang.yue" Outputting client,virtual,dst addresses info when tcp state changes, which makes the connection debug more clear Signed-off-by: longguang.yue Acked-by: Julian Anastasov Signed-off-by: Pablo Neira Ayuso --- net/netfilter/ipvs/ip_vs_proto_tcp.c | 10 ++ 1 file cha

[PATCH 2/7] netfilter: conntrack: connection timeout after re-register

2020-10-22 Thread Pablo Neira Ayuso
From: Francesco Ruggeri If the first packet conntrack sees after a re-register is an outgoing keepalive packet with no data (SEG.SEQ = SND.NXT-1), td_end is set to SND.NXT-1. When the peer correctly acknowledges SND.NXT, tcp_in_window fails check III (Upper bound for valid (s)ack: sack <= receive

[PATCH 3/7] netfilter: Drop fragmented ndisc packets assembled in netfilter

2020-10-22 Thread Pablo Neira Ayuso
From: Georg Kohmann Fragmented ndisc packets assembled in netfilter not dropped as specified in RFC 6980, section 5. This behaviour breaks TAHI IPv6 Core Conformance Tests v6LC.2.1.22/23, V6LC.2.2.26/27 and V6LC.2.3.18. Setting IP6SKB_FRAGMENTED flag during reassembly. References: commit b800c3

[PATCH 6/7] netfilter: nftables_offload: KASAN slab-out-of-bounds Read in nft_flow_rule_create

2020-10-22 Thread Pablo Neira Ayuso
From: Saeed Mirzamohammadi This patch fixes the issue due to: BUG: KASAN: slab-out-of-bounds in nft_flow_rule_create+0x622/0x6a2 net/netfilter/nf_tables_offload.c:40 Read of size 8 at addr 888103910b58 by task syz-executor227/16244 The error happens when expr->ops is accessed early on befor

[PATCH 7/7] netfilter: nf_fwd_netdev: clear timestamp in forwarding path

2020-10-22 Thread Pablo Neira Ayuso
Similar to 7980d2eabde8 ("ipvs: clear skb->tstamp in forwarding path"). fq qdisc requires tstamp to be cleared in forwarding path. Fixes: 8203e2d844d3 ("net: clear skb->tstamp in forwarding paths") Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC") Fixes: 80b14dee2bea ("net: Add a new so

[PATCH 0/7] Netfilter fixes for net

2020-10-22 Thread Pablo Neira Ayuso
Hi Jakub, The following patchset contains Netfilter fixes for net: 1) Update debugging in IPVS tcp protocol handler to make it easier to understand, from longguang.yue 2) Update TCP tracker to deal with keepalive packet after re-registration, from Franceso Ruggeri. 3) Missing IP6SKB_FRAGM

RE: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread David Laight
From: Matthew Wilcox > Sent: 22 October 2020 17:41 > > On Thu, Oct 22, 2020 at 04:35:17PM +, David Laight wrote: > > Wait... > > readv(2) defines: > > ssize_t readv(int fd, const struct iovec *iov, int iovcnt); > > It doesn't really matter what the manpage says. What does the AOSP > lib

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Matthew Wilcox
On Thu, Oct 22, 2020 at 04:35:17PM +, David Laight wrote: > Wait... > readv(2) defines: > ssize_t readv(int fd, const struct iovec *iov, int iovcnt); It doesn't really matter what the manpage says. What does the AOSP libc header say? > But the syscall is defined as: > > SYSCALL_DEFINE

Re: [GIT PULL] 9p update for 5.10-rc1

2020-10-22 Thread Linus Torvalds
On Thu, Oct 22, 2020 at 5:08 AM Dominique Martinet wrote: > > another harmless cycle. Quick note: your email got marked as spam for me. It's probably just gmail doing another round of spam changes, but I do note that while your smtp setup does spf, it doesn't do dkim. Which I think makes gmail m

  1   2   3   >