Re: [PATCH net-next 02/16] devlink: Add reload action option to devlink reload command

2020-10-03 Thread Moshe Shemesh
On 10/3/2020 10:52 AM, Jiri Pirko wrote: Thu, Oct 01, 2020 at 03:59:05PM CEST, mo...@mellanox.com wrote: [...] +static int +devlink_nl_reload_actions_performed_snd(struct devlink *devlink, + unsigned long actions_performed, +

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-03 Thread Moshe Shemesh
On 10/3/2020 10:51 AM, Jiri Pirko wrote: Thu, Oct 01, 2020 at 03:59:06PM CEST, mo...@mellanox.com wrote: [...] enum devlink_attr { /* don't change the order or add anything between, this is ABI! */ DEVLINK_ATTR_UNSPEC, @@ -507,6 +524,7 @@ enum devlink_attr { DEVLINK_

Re: [PATCH net-next 02/16] devlink: Add reload action option to devlink reload command

2020-10-03 Thread Moshe Shemesh
On 10/2/2020 6:19 PM, Jiri Pirko wrote: Thu, Oct 01, 2020 at 03:59:05PM CEST, mo...@mellanox.com wrote: [...] diff --git a/include/net/devlink.h b/include/net/devlink.h index 1c286e9a3590..ddba63bce7ad 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h @@ -1077,10 +1077,11 @@ st

Re: [PATCH v10 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers

2020-10-03 Thread Coly Li
On 2020/10/3 06:28, David Miller wrote: > From: Coly Li > Date: Fri, 2 Oct 2020 16:27:27 +0800 > >> As Sagi Grimberg suggested, the original fix is refind to a more common >> inline routine: >> static inline bool sendpage_ok(struct page *page) >> { >> return (!PageSlab(page) &&

[PATCH net] drivers/net/wan: lapb: Replace the skb->len checks with pskb_may_pull

2020-10-03 Thread Xie He
The purpose of these skb->len checks in these drivers is to ensure that there is a header in the skb available to be read and pulled. However, we already have the pskb_may_pull function for this purpose. The pskb_may_pull function also correctly handles non-linear skbs. (Also delete the word "ch

Re: [PATCH net-next] mptcp: ADD_ADDRs with echo bit are smaller

2020-10-03 Thread David Miller
From: Matthieu Baerts Date: Sat, 3 Oct 2020 17:36:56 +0200 > The MPTCP ADD_ADDR suboption with echo-flag=1 has no HMAC, the size is > smaller than the one initially sent without echo-flag=1. We then need to > use the correct size everywhere when we need this echo bit. > > Before this patch, the

Re: [PATCH net-next 1/2] dt-bindings: net: dsa: b53: Specify unit address in hex

2020-10-03 Thread David Miller
From: Kurt Kanzenbach Date: Sat, 3 Oct 2020 11:30:50 +0200 > The unit address should be 1e, because the unit address is supposed > to be in hexadecimal. > > Suggested-by: Florian Fainelli > Signed-off-by: Kurt Kanzenbach Applied.

Re: [PATCH net-next 2/2] dt-bindings: net: dsa: b53: Fix full duplex in example

2020-10-03 Thread David Miller
From: Kurt Kanzenbach Date: Sat, 3 Oct 2020 11:30:51 +0200 > There is no such property as duplex-full. It's called full-duplex. Leading to > reduced speed when using the example as base for a real device tree. > > Signed-off-by: Kurt Kanzenbach Applied.

Re: [PATCH net-next] net: dsa: sja1105: remove duplicate prefix for VL Lookup dynamic config

2020-10-03 Thread David Miller
From: Vladimir Oltean Date: Sat, 3 Oct 2020 11:18:36 +0300 > This is a strictly cosmetic change that renames some macros in > sja1105_dynamic_config.c. They were copy-pasted in haste and this has > resulted in them having the driver prefix twice. > > Signed-off-by: Vladimir Oltean Applied.

Re: [PATCH][next] net: ksz884x: Use fallthrough pseudo-keyword

2020-10-03 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 2 Oct 2020 18:02:59 -0500 > Replace /* Fallthrough... */ comment with the new pseudo-keyword macro > fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-

Re: [PATCH][next] bnx2x: Use fallthrough pseudo-keyword

2020-10-03 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 2 Oct 2020 18:26:11 -0500 > Replace /* no break */ comments with the new pseudo-keyword macro > fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-b

Re: [PATCH][next] net: bna: Use fallthrough pseudo-keyword

2020-10-03 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 2 Oct 2020 18:00:01 -0500 > Replace /* !!! fall through !!! */ comments with the new pseudo-keyword > macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > >

Re: [PATCH net-next 0/2] net/sched: Add actions for MPLS L2 VPNs

2020-10-03 Thread David Miller
From: Guillaume Nault Date: Sat, 3 Oct 2020 00:44:25 +0200 > This patch series adds the necessary TC actions for supporting layer 2 > MPLS VPNs (VPLS). ... Series applied, thank you.

Re: [PATCH][next] usbnet: Use fallthrough pseudo-keyword

2020-10-03 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 2 Oct 2020 17:53:15 -0500 > Replace // FALLTHROUGH comment with the new pseudo-keyword macro > fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by

Re: [PATCH 1/1] net/rds: suppress page allocation failure error in recv buffer refill

2020-10-03 Thread David Miller
From: Manjunath Patil Date: Fri, 2 Oct 2020 13:05:45 -0700 > RDS/IB tries to refill the recv buffer in softirq context using > GFP_NOWAIT flag. However alloc failure is handled by queueing a work to > refill the recv buffer with GFP_KERNEL flag. This means failure to > allocate with GFP_NOWAIT i

Re: [PATCH] net: typhoon: Fix a typo Typoon --> Typhoon

2020-10-03 Thread David Miller
From: Christophe JAILLET Date: Fri, 2 Oct 2020 21:47:43 +0200 > s/Typoon/Typhoon/ > > Signed-off-by: Christophe JAILLET Applied, thank you.

Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values

2020-10-03 Thread David Miller
From: Colin King Date: Fri, 2 Oct 2020 17:54:22 +0100 > From: Colin Ian King > > Currently the comparisons of u16 integers value and sopass_val with > less than zero for error checking is always false because the values > are unsigned. Fix this by making these variables int. This does not > a

Re: [PATCH net-next 1/2] net/smc: send ISM devices with unique chid in CLC proposal

2020-10-03 Thread David Miller
From: Karsten Graul Date: Fri, 2 Oct 2020 17:09:26 +0200 > When building a CLC proposal message then the list of ISM devices does > not need to contain multiple devices that have the same chid value, > all these devices use the same function at the end. > Improve smc_find_ism_v2_device_clnt() to

Re: [PATCH v4 net-next 0/2] Add Seville Ethernet switch to T1040RDB

2020-10-03 Thread David Miller
From: Vladimir Oltean Date: Fri, 2 Oct 2020 16:41:04 +0300 > Seville is a DSA switch that is embedded inside the T1040 SoC, and > supported by the mscc_seville DSA driver inside drivers/net/dsa/ocelot. > > This series adds this switch to the SoC's dtsi files and to the T1040RDB > board file. >

Re: [PATCH v2] net: hso: do not call unregister if not registered

2020-10-03 Thread David Miller
From: Greg KH Date: Fri, 2 Oct 2020 13:43:23 +0200 > @@ -2366,7 +2366,8 @@ static void hso_free_net_device(struct hso_device > *hso_dev, bool bailout) > > remove_net_device(hso_net->parent); > > - if (hso_net->net) > + if (hso_net->net && > + hso_net->net->reg_state ==

Re: [PATCH net-next] tcp: account total lost packets properly

2020-10-03 Thread David Miller
From: Yuchung Cheng Date: Thu, 1 Oct 2020 14:05:18 -0700 > The retransmission refactoring patch > 686989700cab ("tcp: simplify tcp_mark_skb_lost") > does not properly update the total lost packet counter which may > break the policer mode in BBR. This patch fixes it. > > Fixes: 686989700cab ("t

Re: [PATCH net] net: hinic: fix DEVLINK build errors

2020-10-03 Thread David Miller
From: Randy Dunlap Date: Thu, 1 Oct 2020 10:54:49 -0700 > Fix many (lots deleted here) build errors in hinic by selecting NET_DEVLINK. ... > Fixes: 51ba902a16e6 ("net-next/hinic: Initialize hw interface") > Signed-off-by: Randy Dunlap Applied, thank you.

Re: [PATCH net-next 0/2] net/iucv: updates 2020-10-01

2020-10-03 Thread David Miller
From: Julian Wiedmann Date: Thu, 1 Oct 2020 19:21:25 +0200 > please apply the following patch series for iucv to netdev's net-next > tree. > > Just two (rare) patches, and both deal with smatch warnings. Series applied, thanks.

Re: [PATCH net-next] net: remove NETDEV_HW_ADDR_T_SLAVE

2020-10-03 Thread David Miller
From: Taehee Yoo Date: Thu, 1 Oct 2020 17:12:50 + > NETDEV_HW_ADDR_T_SLAVE is not used anymore, remove it. > > Signed-off-by: Taehee Yoo Looks like this was never used at all. Applied, thank you.

Re: [PATCH v2 net] net: stmmac: Modify configuration method of EEE timers

2020-10-03 Thread David Miller
From: Voon Weifeng Date: Thu, 1 Oct 2020 23:56:09 +0800 > From: "Vineetha G. Jaya Kumaran" > > Ethtool manual stated that the tx-timer is the "the amount of time the > device should stay in idle mode prior to asserting its Tx LPI". The > previous implementation for "ethtool --set-eee tx-timer"

[PATCH net-next] drivers/net/wan/hdlc_fr: Improvements to the code of pvc_xmit

2020-10-03 Thread Xie He
1. Keep the code for the normal (non-error) flow at the lowest indentation level. And use "goto drop" for all error handling. 2. Replace code that pads short Ethernet frames with a "__skb_pad" call. 3. Change "dev_kfree_skb" to "kfree_skb" in error handling code. "kfree_skb" is the correct functi

Re: [PATCH v3] net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails

2020-10-03 Thread Anant Thazhemadam
On 04/10/20 3:05 am, Joe Perches wrote: > On Sun, 2020-10-04 at 02:49 +0530, Anant Thazhemadam wrote: >> When get_registers() fails, in set_ethernet_addr(),the uninitialized >> value of node_id gets copied as the address. This can be considered as >> set_ethernet_addr() itself failing. > [] >> di

Re: [PATCH v3] net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails

2020-10-03 Thread Joe Perches
On Sun, 2020-10-04 at 02:49 +0530, Anant Thazhemadam wrote: > When get_registers() fails, in set_ethernet_addr(),the uninitialized > value of node_id gets copied as the address. This can be considered as > set_ethernet_addr() itself failing. [] > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net

Re: [PATCH net-next 00/23] rxrpc: Fixes and preparation for RxGK

2020-10-03 Thread David Miller
From: David Howells Date: Sat, 03 Oct 2020 22:24:55 +0100 > David Miller wrote: > >> > Since the fixes in the set need to go after the patches in net-next, >> > should I >> > resubmit just those for net-next, or sit on them till -rc1? >> >> My 'net' tree is always open for bug fixes, and that

Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Reduce indentation in pvc_xmit

2020-10-03 Thread Xie He
On Sat, Oct 3, 2020 at 11:10 AM Stephen Hemminger wrote: > > This code snippet is basically an version of skb_pad(). > Probably it is very old and pre-dates that. > Could the code use skb_pad? Oh! Yes! I looked at the skb_pad function and I think we can use it in this code. Since it doesn't do s

Re: [PATCH net-next 00/23] rxrpc: Fixes and preparation for RxGK

2020-10-03 Thread David Howells
David Miller wrote: > > Since the fixes in the set need to go after the patches in net-next, should > > I > > resubmit just those for net-next, or sit on them till -rc1? > > My 'net' tree is always open for bug fixes, and that's where bug fixes > belong. Not 'net-next'. "Need to go after the

[PATCH v3] net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails

2020-10-03 Thread Anant Thazhemadam
When get_registers() fails, in set_ethernet_addr(),the uninitialized value of node_id gets copied as the address. This can be considered as set_ethernet_addr() itself failing. The return type of set_ethernet_addr() is modified to indicate if it failed or not, and return values are appropriately ch

Re: [PATCH v3 0/5] genetlink per-op policy export

2020-10-03 Thread David Miller
From: Jakub Kicinski Date: Sat, 3 Oct 2020 08:15:26 -0700 > On Sat, 3 Oct 2020 10:44:41 +0200 Johannes Berg wrote: >> Here's a respin, now including Jakub's patch last so that it will >> do the right thing from the start. >> >> The first patch remains the same, of course; the others have mostly

Re: [PATCH net-next 00/23] rxrpc: Fixes and preparation for RxGK

2020-10-03 Thread David Miller
From: David Howells Date: Sat, 03 Oct 2020 21:01:49 +0100 > Since the fixes in the set need to go after the patches in net-next, should I > resubmit just those for net-next, or sit on them till -rc1? My 'net' tree is always open for bug fixes, and that's where bug fixes belong. Not 'net-next'.

Re: [PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address

2020-10-03 Thread Anant Thazhemadam
On 04/10/20 1:08 am, Joe Perches wrote: > On Thu, 2020-10-01 at 13:02 +0530, Anant Thazhemadam wrote: >> When get_registers() fails (which happens when usb_control_msg() fails) >> in set_ethernet_addr(), the uninitialized value of node_id gets copied >> as the address. > unrelated trivia: > >> di

Re: [PATCH net-next 00/23] rxrpc: Fixes and preparation for RxGK

2020-10-03 Thread David Howells
David Miller wrote: > > The patches are tagged here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > > rxrpc-next-20201010 > > No, they aren't. oops. I transposed the last two digits. I really need to make my script check the cover message. > Also, you

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-03 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 6:42 PM Stephen Hemminger wrote: > > On Fri, 2 Oct 2020 16:23:46 -0400 > Jarod Wilson wrote: > > > On Fri, Oct 2, 2020 at 3:13 PM Stephen Hemminger > > wrote: > > > > > > On Fri, 2 Oct 2020 13:40:01 -0400 > > > Jarod Wilson wrote: > > > > > > > By default, enable retaini

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-03 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 6:57 PM David Miller wrote: > > From: Jarod Wilson > Date: Fri, 2 Oct 2020 16:23:46 -0400 > > > I'd had a bit of feedback that people would rather see both, and be > > able to toggle off the old ones, rather than only having one or the > > other, depending on the toggle, so

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-03 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 6:55 PM David Miller wrote: > > From: Jarod Wilson > Date: Fri, 2 Oct 2020 16:12:49 -0400 > > > The documentation was updated to point to the new names, but the old > > ones still exist across the board, there should be no userspace > > breakage here. (My lnst bonding tests

Re: [Linux-kernel-mentees][PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address

2020-10-03 Thread Joe Perches
On Thu, 2020-10-01 at 13:02 +0530, Anant Thazhemadam wrote: > When get_registers() fails (which happens when usb_control_msg() fails) > in set_ethernet_addr(), the uninitialized value of node_id gets copied > as the address. unrelated trivia: > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net

[PATCH] net: mvneta: fix double free of txq->buf

2020-10-03 Thread trix
From: Tom Rix clang static analysis reports this problem: drivers/net/ethernet/marvell/mvneta.c:3465:2: warning: Attempt to free released memory kfree(txq->buf); ^~~ When mvneta_txq_sw_init() fails to alloc txq->tso_hdrs, it frees without poisoning txq->buf. The e

Re: [Linux-kernel-mentees][PATCH 0/2] reorder members of structures in virtio_net for optimization

2020-10-03 Thread Michael S. Tsirkin
On Fri, Oct 02, 2020 at 07:06:38PM -0700, David Miller wrote: > From: Anant Thazhemadam > Date: Wed, 30 Sep 2020 10:47:20 +0530 > > > The structures virtnet_info and receive_queue have byte holes in > > middle, and their members could do with some rearranging > > (order-of-declaration wise) in

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-03 Thread Marcel Holtmann
Hi Greg, >>> This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it >>> breaks all bluetooth connections on my machine. >>> >>> Cc: Marcel Holtmann >>> Cc: Sathish Narsimman >>> Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating >>> whitelist") >>> Signed-off-by:

Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Reduce indentation in pvc_xmit

2020-10-03 Thread Stephen Hemminger
On Sat, 3 Oct 2020 10:35:28 -0700 Xie He wrote: > + if (dev->type == ARPHRD_ETHER) { > + int pad = ETH_ZLEN - skb->len; > + > + if (pad > 0) { /* Pad the frame with zeros */ > + int len = skb->len; > + > + if (skb_tailroom(skb)

Re: [net-next PATCH v1 3/7] net: phy: Introduce fwnode_get_phy_id()

2020-10-03 Thread Calvin Johnson
Hi Russell and Florian, On Fri, Oct 02, 2020 at 04:50:26PM +0100, Russell King - ARM Linux admin wrote: > On Fri, Oct 02, 2020 at 08:14:07AM -0700, Florian Fainelli wrote: > > On 10/2/2020 4:05 AM, Grant Likely wrote: > > > On 30/09/2020 17:04, Calvin Johnson wrote: > > > > Extract phy_id from com

Re: [net-next PATCH v1 3/7] net: phy: Introduce fwnode_get_phy_id()

2020-10-03 Thread Calvin Johnson
On Fri, Oct 02, 2020 at 12:05:14PM +0100, Grant Likely wrote: > > > On 30/09/2020 17:04, Calvin Johnson wrote: > > Extract phy_id from compatible string. This will be used by > > fwnode_mdiobus_register_phy() to create phy device using the > > phy_id. > > > > Signed-off-by: Calvin Johnson > > -

Re: [net-next PATCH v1 6/7] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-10-03 Thread Calvin Johnson
Hi Grant, On Fri, Oct 02, 2020 at 12:22:37PM +0100, Grant Likely wrote: > > > On 30/09/2020 17:04, Calvin Johnson wrote: > > Modify dpaa2_mac_connect() to support ACPI along with DT. > > Modify dpaa2_mac_get_node() to get the dpmac fwnode from either > > DT or ACPI. > > > > Replace of_get_phy_m

[PATCH net-next] drivers/net/wan/hdlc_fr: Reduce indentation in pvc_xmit

2020-10-03 Thread Xie He
1. Keep the code for the normal (non-error) flow at the lowest indentation level. This reduces indentation and makes the code feels more natural to read. 2. Use "goto drop" for all error handling. This reduces duplicate code. 3. Change "dev_kfree_skb" to "kfree_skb" in error handling code. "kfree

Re: [net-next PATCH v1 6/7] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-10-03 Thread Calvin Johnson
Hi Andy, On Thu, Oct 01, 2020 at 06:36:06PM +0300, Andy Shevchenko wrote: > On Wed, Sep 30, 2020 at 7:06 PM Calvin Johnson > wrote: > > > > Modify dpaa2_mac_connect() to support ACPI along with DT. > > Modify dpaa2_mac_get_node() to get the dpmac fwnode from either > > DT or ACPI. > > > > Replace

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-03 Thread Greg Kroah-Hartman
On Sat, Oct 03, 2020 at 05:51:03PM +0200, Marcel Holtmann wrote: > Hi Greg, > > > This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it > > breaks all bluetooth connections on my machine. > > > > Cc: Marcel Holtmann > > Cc: Sathish Narsimman > > Fixes: 0eee35bdfa3b ("Bluetooth: Upd

Re: [PATCH net-next 2/2] dt-bindings: net: dsa: b53: Fix full duplex in example

2020-10-03 Thread Florian Fainelli
On 10/3/2020 2:30 AM, Kurt Kanzenbach wrote: There is no such property as duplex-full. It's called full-duplex. Leading to reduced speed when using the example as base for a real device tree. Doh, thanks for correcting this. Would you want to make this a YAML binding at some point? I can ta

Re: [PATCH net-next 1/2] dt-bindings: net: dsa: b53: Specify unit address in hex

2020-10-03 Thread Florian Fainelli
On 10/3/2020 2:30 AM, Kurt Kanzenbach wrote: The unit address should be 1e, because the unit address is supposed to be in hexadecimal. Suggested-by: Florian Fainelli Signed-off-by: Kurt Kanzenbach Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-03 Thread Marcel Holtmann
Hi Greg, > This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it > breaks all bluetooth connections on my machine. > > Cc: Marcel Holtmann > Cc: Sathish Narsimman > Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating > whitelist") > Signed-off-by: Greg Kroah-Hartm

[PATCH net-next] mptcp: ADD_ADDRs with echo bit are smaller

2020-10-03 Thread Matthieu Baerts
The MPTCP ADD_ADDR suboption with echo-flag=1 has no HMAC, the size is smaller than the one initially sent without echo-flag=1. We then need to use the correct size everywhere when we need this echo bit. Before this patch, the wrong size was reserved but the correct amount of bytes were written (a

Re: [PATCH v3 0/5] genetlink per-op policy export

2020-10-03 Thread Jakub Kicinski
On Sat, 3 Oct 2020 10:44:41 +0200 Johannes Berg wrote: > Here's a respin, now including Jakub's patch last so that it will > do the right thing from the start. > > The first patch remains the same, of course; the others have mostly > some rebasing going on, except for the actual export patch (pat

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-03 Thread Jakub Kicinski
On Sat, 3 Oct 2020 09:51:00 +0200 Jiri Pirko wrote: > > enum devlink_attr { > > /* don't change the order or add anything between, this is ABI! */ > > DEVLINK_ATTR_UNSPEC, > >@@ -507,6 +524,7 @@ enum devlink_attr { > > > > DEVLINK_ATTR_RELOAD_ACTION, /* u8 */ > > DEVLIN

[PATCH] iproute2: ip addr: Fix noprefixroute and autojoin for IPv4

2020-10-03 Thread Adel Belhouane
These were reported as IPv6-only and ignored: # ip address add 192.0.2.2/24 dev dummy5 noprefixroute Warning: noprefixroute option can be set only for IPv6 addresses # ip address add 224.1.1.10/24 dev dummy5 autojoin Warning: autojoin option can be set only for IPv6 addresses Thi

[PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-03 Thread Greg Kroah-Hartman
This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine. Cc: Marcel Holtmann Cc: Sathish Narsimman Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist") Signed-off-by: Greg Kroah-Hartman --- net/bluetooth/hci_

Re: [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-03 Thread Heiner Kallweit
On 02.10.2020 21:22, Łukasz Stelmach wrote: > ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > connected to a CPU with a 8/16-bit bus or with an SPI. This driver > supports SPI connection. > > The driver has been ported from the vendor kernel for ARTIK5[2] > boards. Several chan

Re: WARNING in drv_bss_info_changed

2020-10-03 Thread syzbot
syzbot has bisected this issue to: commit 489b30b53f0540b9f8e391cbb2839cea48b5d1c1 Author: Kirill Tkhai Date: Thu Mar 15 09:10:57 2018 + net: Convert l2tp_net_ops bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=175b598f90 start commit: fcadab74 Merge tag 'drm-fixes-

Re: [PATCH net-next 11/15] sctp: add udphdr to overhead when udp_port is set

2020-10-03 Thread Xin Long
On Sat, Oct 3, 2020 at 7:23 PM Xin Long wrote: > > On Sat, Oct 3, 2020 at 4:12 PM Xin Long wrote: > > > > On Sat, Oct 3, 2020 at 12:08 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Wed, Sep 30, 2020 at 03:00:42AM +0800, kernel test robot wrote: > > > > Hi Xin, > > > > > > > > Thank you fo

Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

2020-10-03 Thread Corey Minyard
On Fri, Oct 02, 2020 at 06:41:43PM -0500, Rob Herring wrote: > Another round of wack-a-mole. The json-schema default is additional > unknown properties are allowed, but for DT all properties should be > defined. > > Cc: Thierry Reding > Cc: Linus Walleij > Cc: Stephen Boyd > Cc: Shawn Guo > Cc

Re: [PATCH net-next 11/15] sctp: add udphdr to overhead when udp_port is set

2020-10-03 Thread Xin Long
On Sat, Oct 3, 2020 at 4:12 PM Xin Long wrote: > > On Sat, Oct 3, 2020 at 12:08 PM Marcelo Ricardo Leitner > wrote: > > > > On Wed, Sep 30, 2020 at 03:00:42AM +0800, kernel test robot wrote: > > > Hi Xin, > > > > > > Thank you for the patch! Yet something to improve: > > > > I wonder how are you

[PATCH] net/mlx5e: Fix freeing of unassigned pointer

2020-10-03 Thread Alex Dewar
Commit ff7ea04ad579 ("net/mlx5e: Fix potential null pointer dereference") added some missing null checks but the error handling in mlx5e_alloc_flow() was left broken: the variable attr is passed to kfree although it is never assigned to and never needs to be freed in this function. Fix this. Addre

RE: [PATCH net-next v2 0/5] implement kthread based napi poll

2020-10-03 Thread David Laight
From: Wei Wang > Sent: 02 October 2020 23:25 > > The idea of moving the napi poll process out of softirq context to a > kernel thread based context is not new. > Paolo Abeni and Hannes Frederic Sowa have proposed patches to move napi > poll to kthread back in 2016. And Felix Fietkau has also propo

...

2020-10-03 Thread Coly Li
On 2020/10/3 06:28, David Miller wrote: > From: Coly Li > Date: Fri, 2 Oct 2020 16:27:27 +0800 > >> As Sagi Grimberg suggested, the original fix is refind to a more common >> inline routine: >> static inline bool sendpage_ok(struct page *page) >> { >> return (!PageSlab(page) &&

Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board

2020-10-03 Thread Krzysztof Kozlowski
On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach wrote: > > Add node for ax88796c ethernet chip. > > Signed-off-by: Łukasz Stelmach > --- > arch/arm/boot/dts/exynos3250-artik5-eval.dts | 21 > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250-artik5-

Re: [PATCH v2 1/4] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2020-10-03 Thread Krzysztof Kozlowski
On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach wrote: > > Add bindings for AX88796C SPI Ethernet Adapter. > > Signed-off-by: Łukasz Stelmach > --- > .../bindings/net/asix,ax88796c-spi.yaml | 76 +++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > 2 files changed, 78

[PATCH v3 2/3] vhost: Use vhost_get_used_size() in vhost_vring_set_addr()

2020-10-03 Thread Greg Kurz
The open-coded computation of the used size doesn't take the event into account when the VIRTIO_RING_F_EVENT_IDX feature is present. Fix that by using vhost_get_used_size(). Signed-off-by: Greg Kurz --- drivers/vhost/vhost.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH v3 3/3] vhost: Don't call log_access_ok() when using IOTLB

2020-10-03 Thread Greg Kurz
When the IOTLB device is enabled, the log_guest_addr that is passed by userspace to the VHOST_SET_VRING_ADDR ioctl, and which is then written to vq->log_addr, is a GIOVA. All writes to this address are translated by log_user() to writes to an HVA, and then ultimately logged through the correspondin

[PATCH v3 1/3] vhost: Don't call access_ok() when using IOTLB

2020-10-03 Thread Greg Kurz
When the IOTLB device is enabled, the vring addresses we get from userspace are GIOVAs. It is thus wrong to pass them down to access_ok() which only takes HVAs. Access validation is done at prefetch time with IOTLB. Teach vq_access_ok() about that by moving the (vq->iotlb) check from vhost_vq_acce

[PATCH v3 0/3] vhost: Skip access checks on GIOVAs

2020-10-03 Thread Greg Kurz
This series addresses some misuse around vring addresses provided by userspace when using an IOTLB device. The misuse cause failures of the VHOST_SET_VRING_ADDR ioctl on POWER, which in turn causes QEMU to crash at migration time. Jason suggested that we should use vhost_get_used_size() during the

RE: [PATCH net-next v2 0/5] implement kthread based napi poll

2020-10-03 Thread David Laight
From: Wei Wang > Sent: 02 October 2020 23:25 > > The idea of moving the napi poll process out of softirq context to a > kernel thread based context is not new. > Paolo Abeni and Hannes Frederic Sowa have proposed patches to move napi > poll to kthread back in 2016. And Felix Fietkau has also propo

Re: [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default

2020-10-03 Thread Kurt Kanzenbach
Hi Vladimir, On Sat Oct 03 2020, Vladimir Oltean wrote: > Hi Kurt, > > On Fri, Oct 02, 2020 at 11:15:27AM +0300, Vladimir Oltean wrote: >> > Is this merged? I don't see it. Do I have to set >> > `configure_vlan_while_not_filtering' explicitly to true for the next >> > hellcreek version? >> >> Yes

Re: KASAN: use-after-free Read in tipc_mcast_xmit (2)

2020-10-03 Thread Xin Long
On Fri, Oct 2, 2020 at 11:38 PM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:a59cf619 Merge branch 'Fix-bugs-in-Octeontx2-netdev-driver' > git tree: bpf > console output: https://syzkaller.appspot.com/x/log.txt?x=163c246790 > kernel config: https

[PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card

2020-10-03 Thread Wilken Gottwalt
Add usb ids of the Cellient MPL200 card. Signed-off-by: Wilken Gottwalt --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 07c42c0719f5..0bf2b19d5d54 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/driver

[PATCH 2/2] usb: serial: option: add Cellient MPL200 card

2020-10-03 Thread Wilken Gottwalt
Add usb ids of the Cellient MPL200 card. Signed-off-by: Wilken Gottwalt --- drivers/usb/serial/option.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 0c6f160a214a..a65e620b2277 100644 --- a/drivers/usb/serial/option.c +++ b

[PATCH 0/2] add Cellient MPL200 card

2020-10-03 Thread Wilken Gottwalt
Add the Cellient MPL200 card to usb/qmi_wwan and serial/option. Wilken Gottwalt (2): usb: serial: qmi_wwan: add Cellient MPL200 card usb: serial: option: add Cellient MPL200 card drivers/net/usb/qmi_wwan.c | 1 + drivers/usb/serial/option.c | 3 +++ 2 files changed, 4 insertions(+) -- 2.2

Re: [PATCH 0/6] Ancillary bus implementation and SOF multi-client support

2020-10-03 Thread Greg KH
On Sat, Oct 03, 2020 at 12:24:07PM +0300, Leon Romanovsky wrote: > On Sat, Oct 03, 2020 at 11:10:36AM +0200, Greg KH wrote: > > On Sat, Oct 03, 2020 at 12:04:52PM +0300, Leon Romanovsky wrote: > > > Hi Dave, > > > > > > I don't know why did you send this series separately to every mailing > > > lis

[PATCH net-next 1/2] dt-bindings: net: dsa: b53: Specify unit address in hex

2020-10-03 Thread Kurt Kanzenbach
The unit address should be 1e, because the unit address is supposed to be in hexadecimal. Suggested-by: Florian Fainelli Signed-off-by: Kurt Kanzenbach --- Documentation/devicetree/bindings/net/dsa/b53.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicet

[PATCH net-next 2/2] dt-bindings: net: dsa: b53: Fix full duplex in example

2020-10-03 Thread Kurt Kanzenbach
There is no such property as duplex-full. It's called full-duplex. Leading to reduced speed when using the example as base for a real device tree. Signed-off-by: Kurt Kanzenbach --- Documentation/devicetree/bindings/net/dsa/b53.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

Re: [PATCH 10/19] xfrm: interface: support IP6IP6 and IP6IP tunnels processing with .cb_handler

2020-10-03 Thread Xin Long
On Fri, Oct 2, 2020 at 10:44 PM Nicolas Dichtel wrote: > > Le 30/07/2020 à 07:41, Steffen Klassert a écrit : > > From: Xin Long > > > > Similar to ip6_vti, IP6IP6 and IP6IP tunnels processing can easily > > be done with .cb_handler for xfrm interface. > > > > v1->v2: > > - no change. > > v2-v3:

Re: [PATCH 0/6] Ancillary bus implementation and SOF multi-client support

2020-10-03 Thread Leon Romanovsky
On Sat, Oct 03, 2020 at 11:10:36AM +0200, Greg KH wrote: > On Sat, Oct 03, 2020 at 12:04:52PM +0300, Leon Romanovsky wrote: > > Hi Dave, > > > > I don't know why did you send this series separately to every mailing > > list, but it is not correct thing to do. > > > > RDMA ML and discussion: > > htt

Re: [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example

2020-10-03 Thread Kurt Kanzenbach
On Fri Oct 02 2020, Florian Fainelli wrote: > On 10/1/2020 11:20 PM, Kurt Kanzenbach wrote: >> The switch has a certain MDIO address and this needs to be specified using >> the >> reg property. Add it to the example. >> >> Signed-off-by: Kurt Kanzenbach >> --- >> Documentation/devicetree/bindi

Re: [PATCH net-next 16/16] devlink: Add Documentation/networking/devlink/devlink-reload.rst

2020-10-03 Thread Jiri Pirko
Thu, Oct 01, 2020 at 03:59:19PM CEST, mo...@mellanox.com wrote: >Add devlink reload rst documentation file. >Update index file to include it. > >Signed-off-by: Moshe Shemesh >--- >RFCv5 -> v1: >- Rename reload_action_limit_level to reload_limit >RFCv4 -> RFCv5: >- Rephrase namespace chnage section

Re: [PATCH 0/6] Ancillary bus implementation and SOF multi-client support

2020-10-03 Thread Greg KH
On Sat, Oct 03, 2020 at 12:04:52PM +0300, Leon Romanovsky wrote: > Hi Dave, > > I don't know why did you send this series separately to every mailing > list, but it is not correct thing to do. > > RDMA ML and discussion: > https://lore.kernel.org/linux-rdma/20201001050534.890666-1-david.m.ert...@

Re: [PATCH net-next 05/16] devlink: Add remote reload stats

2020-10-03 Thread Jiri Pirko
Thu, Oct 01, 2020 at 03:59:08PM CEST, mo...@mellanox.com wrote: >Add remote reload stats to hold the history of actions performed due >devlink reload commands initiated by remote host. For example, in case >firmware activation with reset finished successfully but was initiated >by remote host. > >T

Re: [PATCH 0/6] Ancillary bus implementation and SOF multi-client support

2020-10-03 Thread Leon Romanovsky
Hi Dave, I don't know why did you send this series separately to every mailing list, but it is not correct thing to do. RDMA ML and discussion: https://lore.kernel.org/linux-rdma/20201001050534.890666-1-david.m.ert...@intel.com/T/#t Netdev ML (completely separated): https://lore.kernel.org/netdev

BUG: corrupted list in rxrpc_put_call

2020-10-03 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:fcadab74 Merge tag 'drm-fixes-2020-10-01-1' of git://anong.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=143340a390 kernel config: https://syzkaller.appspot.com/x/.config?x=89ab6a0c48f30b49 das

Re: [PATCH net-next 04/16] devlink: Add reload stats

2020-10-03 Thread Jiri Pirko
Thu, Oct 01, 2020 at 03:59:07PM CEST, mo...@mellanox.com wrote: >Add reload stats to hold the history per reload action type and limit. > >For example, the number of times fw_activate has been performed on this >device since the driver module was added or if the firmware activation >was performed w

[PATCHv2 bpf 3/3] selftest/bpf: test pinning map with reused map fd

2020-10-03 Thread Hangbin Liu
This add a test to make sure that we can still pin maps with reused map fd. Signed-off-by: Hangbin Liu --- .../selftests/bpf/prog_tests/pinning.c| 46 ++- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/prog_tests/pinning.c b/too

[PATCHv2 bpf 2/3] libbpf: check if pin_path was set even map fd exist

2020-10-03 Thread Hangbin Liu
Say a user reuse map fd after creating a map manually and set the pin_path, then load the object via libbpf. In libbpf bpf_object__create_maps(), bpf_object__reuse_map() will return 0 if there is no pinned map in map->pin_path. Then after checking if map fd exist, we should also check if pin_path

[PATCHv2 bpf 0/3] Fix pining maps after reuse map fd

2020-10-03 Thread Hangbin Liu
When a user reuse map fd after creating a map manually and set the pin_path, then load the object via libbpf. bpf_object__create_maps() will skip pinning map if map fd exist. Fix it by add moving bpf creation to else condition and go on checking map pin_path after that. v2: a) close map fd if init

[PATCHv2 bpf 1/3] libbpf: close map fd if init map slots failed

2020-10-03 Thread Hangbin Liu
Previously we forgot to close the map fd if bpf_map_update_elem() failed during map slot init, which will leak map fd. Let's move map slot initialization to new function init_map_slots() to simplify the code. And close the map fd if init slot failed. Reported-by: Andrii Nakryiko Signed-off-by: H

[PATCH v3 0/5] genetlink per-op policy export

2020-10-03 Thread Johannes Berg
Hi, Here's a respin, now including Jakub's patch last so that it will do the right thing from the start. The first patch remains the same, of course; the others have mostly some rebasing going on, except for the actual export patch (patch 4) which is adjusted per Jakub's review comments about exp

[PATCH v3 3/5] genetlink: factor skb preparation out of ctrl_dumppolicy()

2020-10-03 Thread Johannes Berg
From: Johannes Berg We'll need this later for the per-op policy index dump. Reviewed-by: Jakub Kicinski Signed-off-by: Johannes Berg --- net/netlink/genetlink.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/net/netlink/genetlink.c b/net/netlink

[PATCH v3] genl: ctrl: print op -> policy idx mapping

2020-10-03 Thread Johannes Berg
Newer kernels can dump per-op policies, so print out the new mapping attribute to indicate which op has which policy. v2: * print out both do/dump policy idx v3: * fix userspace API which renumbered after patch rebasing Signed-off-by: Johannes Berg --- genl/ctrl.c| 27

[PATCH v3 2/5] netlink: rework policy dump to support multiple policies

2020-10-03 Thread Johannes Berg
From: Johannes Berg Rework the policy dump code a bit to support adding multiple policies to a single dump, in order to e.g. support per-op policies in generic netlink. v2: - move kernel-doc to implementation [Jakub] - squash the first patch to not flip-flop on the prototype [Jakub] - merg

[PATCH v3 1/5] netlink: compare policy more accurately

2020-10-03 Thread Johannes Berg
From: Johannes Berg The maxtype is really an integral part of the policy, and while we haven't gotten into a situation yet where this happens, it seems that some developer might eventually have two places pointing to identical policies, with different maxattr to exclude some attrs in one of the p

[PATCH v3 4/5] genetlink: properly support per-op policy dumping

2020-10-03 Thread Johannes Berg
From: Johannes Berg Add support for per-op policy dumping. The data is pretty much as before, except that now the assumption that the policy with index 0 is "the" policy no longer holds - you now need to look at the new CTRL_ATTR_OP_POLICY attribute which is a nested attr (indexed by op) containi

  1   2   >