The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'alloc_ringdesc()' GFP_KERNEL can be used
because it
On Sun, Sep 13, 2020 at 08:14:17AM +0200, Christophe JAILLET wrote:
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
>
On 13/09/20 11:43 am, Greg KH wrote:
> On Sun, Sep 13, 2020 at 11:26:39AM +0530, Anant Thazhemadam wrote:
>> The crash report showed that there was a local variable;
>>
>> iovstack.i@__sys_sendmmsg created at:
>> ___sys_sendmsg net/socket.c:2388 [inline]
>> __sys_sendmmsg+0x6db/0xc90 net/so
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'rio_probe1()' GFP_KERNEL can be used because
it is
On Sun, Sep 13, 2020 at 11:26:39AM +0530, Anant Thazhemadam wrote:
> The crash report showed that there was a local variable;
>
> iovstack.i@__sys_sendmmsg created at:
> ___sys_sendmsg net/socket.c:2388 [inline]
> __sys_sendmmsg+0x6db/0xc90 net/socket.c:2480
>
> that was left uninitialize
The crash report showed that there was a local variable;
iovstack.i@__sys_sendmmsg created at:
___sys_sendmsg net/socket.c:2388 [inline]
__sys_sendmmsg+0x6db/0xc90 net/socket.c:2480
that was left uninitialized.
The contents of iovstack are of interest, since the respective pointer
is pas
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'alloc_ring()' (natsemi.c) GFP_KERNEL can be
used be
On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote:
> We now trigger a system resume when we receive an IPA SUSPEND
> interrupt. We should *not* wake up on GSI interrupts.
>
Reviewed-by: Bjorn Andersson
> Signed-off-by: Alex Elder
> ---
> drivers/net/ipa/gsi.c | 17 -
> drivers/
On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote:
> Now that we handle wakeup interrupts properly, arrange for the IPA
> interrupt to be treated as a wakeup interrupt.
>
Reviewed-by: Bjorn Andersson
> Signed-off-by: Alex Elder
> ---
> drivers/net/ipa/ipa_interrupt.c | 14 ++
> 1 fi
On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote:
> Currently, when (before) the last IPA clock reference is dropped,
> all endpoints are suspended. And whenever the first IPA clock
> reference is taken, all endpoints are resumed (or started).
>
> In most cases there's no need to start endpoints w
On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote:
> The call to wakeup_source_register() in ipa_probe() does not do what
> it was intended to do. Call device_init_wakeup() in ipa_setup()
> instead, to set the IPA device as wakeup-capable and to initially
> enable wakeup capability.
>
> When we rec
On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote:
> We take a single IPA clock reference to keep the clock running until
> we get a system suspend operation, and maintain a flag indicating
> whether that reference has been taken. When a suspend request
> arrives, we drop that reference and clear th
From: Geert Uytterhoeven
Date: Sat, 12 Sep 2020 14:33:59 +0200
> "dev" is not the bridge device, but the physical Ethernet interface, which
> may already be suspended during s2ram.
Hmmm, ok.
Looking more deeply NETDEV_CHANGE causes br_port_carrier_check() to run which
exits early if netif_runni
From: Christophe JAILLET
Date: Sat, 12 Sep 2020 13:44:18 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> W
From: Christophe JAILLET
Date: Sat, 12 Sep 2020 16:12:32 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> W
From: Christophe JAILLET
Date: Sat, 12 Sep 2020 13:28:58 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> W
From: Christophe JAILLET
Date: Sat, 12 Sep 2020 09:43:58 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> W
From: Peilin Ye
Date: Sat, 12 Sep 2020 06:22:30 -0400
> @@ -291,10 +291,11 @@ static void tipc_group_add_to_tree(struct tipc_group
> *grp,
> else if (key > nkey)
> n = &(*n)->rb_right;
> else
> - return;
> +
From: Luo Jiaxing
Date: Sat, 12 Sep 2020 16:08:15 +0800
> We found a set but not used variable 'ring_cons' in mlx4_en_xmit(), it will
> cause a warning when build the kernel. And after checking the commit record
> of this function, we found that it was introduced by a previous patch.
>
> So, We
On Fri, Sep 11, 2020 at 07:56:51PM -0700, Ian Rogers wrote:
> Some fixes that address issues for regular and pfm4 events with 2
> additional perf_event_attr tests. Various authors, David Sharp isn't
> currently at Google.
>
> v3. moved a loop into a helper following Adrian Hunter's suggestion.
>
Hi Hauke,
On Sat, Sep 12, 2020 at 9:36 PM Hauke Mehrtens wrote:
>
> This fixes multiple bugs in the NAPI handling.
many thanks!
These fix the TX hang that I could reproduce by simply starting iperf3
on a lantiq board.
Is the plan to have these patches applied to net or net-next?
Having them in t
From: Boqun Feng Sent: Thursday, September 10, 2020 7:35
AM
>
> Hyper-V always use 4k page size (HV_HYP_PAGE_SIZE), so when
> communicating with Hyper-V, a guest should always use HV_HYP_PAGE_SIZE
> as the unit for page related data. For storvsc, the data is
> vmbus_packet_mpb_array. And since i
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'alloc_ring()' (natsemi.c) GFP_KERNEL can be
used be
From: Boqun Feng Sent: Thursday, September 10, 2020 7:35
AM
>
> When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at
> least 2 * PAGE_SIZE: one page for the header and at least one page of
> the data part (because of the alignment requirement for double mapping).
>
> So make
On 9/11/2020 11:56 PM, Nikolay Aleksandrov wrote:
On Sat, 2020-09-12 at 02:16 +0300, Vladimir Oltean wrote:
Currently the bridge untags VLANs from its VLAN group in
__allowed_ingress() only when VLAN filtering is enabled.
When installing a pvid in egress-tagged mode, DSA switches have a
prob
From: Boqun Feng Sent: Thursday, September 10, 2020 7:35
AM
>
> When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at
> least 2 * PAGE_SIZE: one page for the header and at least one page of
> the data part (because of the alignment requirement for double mapping).
>
> So make
From: Boqun Feng Sent: Thursday, September 10, 2020 7:35
AM
>
> When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at
> least 2 * PAGE_SIZE: one page for the header and at least one page of
> the data part (because of the alignment requirement for double mapping).
>
> So make
The napi_schedule() call will only schedule the NAPI if it is not
already running. To make sure that we do not deactivate interrupts
without scheduling NAPI only deactivate the interrupts in case NAPI also
gets scheduled.
Signed-off-by: Hauke Mehrtens
---
drivers/net/ethernet/lantiq_xrx200.c | 8
Use napi_complete_done() and activate the interrupts when this function
returns true. This way the generic NAPI code can take care of activating
the interrupts.
Signed-off-by: Hauke Mehrtens
---
drivers/net/ethernet/lantiq_xrx200.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
d
The call to netif_wake_queue() when the TX descriptors were freed was
missing. When there are no TX buffers available the TX queue will be
stopped, but it was not started again when they are available again,
this is fixed in this patch.
Fixes: fe1a56420cf2 ("net: lantiq: Add Lantiq / Intel VRX200
This fixes multiple bugs in the NAPI handling.
Changes since:
v1:
- removed stable tag from "net: lantiq: use netif_tx_napi_add() for TX NAPI"
- Check the NAPI budged in "net: lantiq: Use napi_complete_done()"
- Add extra fix "net: lantiq: Disable IRQs only if NAPI gets scheduled"
Hauke Mehrte
From: Boqun Feng Sent: Thursday, September 10, 2020 7:35
AM
>
> When communicating with Hyper-V, HV_HYP_PAGE_SIZE should be used since
> that's the page size used by Hyper-V and Hyper-V expects all
> page-related data using the unit of HY_HYP_PAGE_SIZE, for example, the
> "pfn" in hv_page_buffer
netif_tx_napi_add() should be used for NAPI in the TX direction instead
of the netif_napi_add() function.
Signed-off-by: Hauke Mehrtens
---
drivers/net/ethernet/lantiq_xrx200.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/lantiq_xrx200.c
b/drivers/net
From: Boqun Feng Sent: Thursday, September 10, 2020 7:35
AM
>
> When a guest communicate with the hypervisor, it must use HV_HYP_PAGE to
> calculate PFN, so introduce a few hvpfn helper functions as the
> counterpart of the page helper functions. This is the preparation for
> supporting guest wh
From: Boqun Feng Sent: Thursday, September 10, 2020 7:35
AM
>
> There will be more places other than vmbus where we need to calculate
> the Hyper-V page PFN from a virtual address, so move virt_to_hvpfn() to
> hyperv generic header.
>
> Signed-off-by: Boqun Feng
> ---
> drivers/hv/channel.c
From: Boqun Feng Sent: Thursday, September 10, 2020 7:35
AM
>
> Both the base_*_gpa should use the guest page number in Hyper-V page, so
> use HV_HYP_PAGE instead of PAGE.
>
> Signed-off-by: Boqun Feng
> ---
> drivers/hv/hv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Rev
From: Boqun Feng Sent: Thursday, September 10, 2020 7:35
AM
>
> This patch introduces two types of GPADL: HV_GPADL_{BUFFER, RING}. The
> types of GPADL are purely the concept in the guest, IOW the hypervisor
> treat them as the same.
>
> The reason of introducing the types for GPADL is to supp
From: Boqun Feng Sent: Thursday, September 10, 2020 7:35
AM
>
> Pure function movement, no functional changes. The move is made, because
> in a later change, __vmbus_open() will rely on some static functions
> afterwards, so we separate the move and the modification of
> __vmbus_open() in two pa
From: Boqun Feng Sent: Thursday, September 10, 2020 7:35
AM
>
> Since the hypervisor always uses 4K as its page size, the size of PFNs
> used for gpadl should be HV_HYP_PAGE_SIZE rather than PAGE_SIZE, so
> adjust this accordingly as the preparation for supporting 16K/64K page
> size guests. No
On Thu, Sep 3, 2015 at 11:31 AM, Linus Torvalds
wrote:
>> [-Wsizeof-array-argument]
> Ahh. Google shows that it's an old clang warning that gcc has recently
> picked up.
> But even clang doesn't seem to have any way for a project to say
> "please warn about arrays in function argument decl
On Sat, Sep 12, 2020 at 11:30:06AM +0800, Yangbo Lu wrote:
> The FIPER3 (fixed interval period pulse generator) is supported on
> DPAA2 and ENETC network controller hardware. This patch is to support
> it in ptp_qoriq driver.
>
> Signed-off-by: Yangbo Lu
> ---
Would you also want to add the debu
On 9/12/20 8:19 AM, Oded Gabbay wrote:
> On Sat, Sep 12, 2020 at 6:07 PM Randy Dunlap wrote:
>>
>> Hi,
>>
>> On 9/12/20 7:41 AM, Oded Gabbay wrote:
>>> +#define HL_IOCTL_NIC _IOWR('H', 0x07, struct hl_nic_args)
>>
>>
>> ioctl numbers ('H') should be documented in
>> Documentation/userspace-api/ioc
On Sat, Sep 12, 2020 at 6:07 PM Randy Dunlap wrote:
>
> Hi,
>
> On 9/12/20 7:41 AM, Oded Gabbay wrote:
> > +#define HL_IOCTL_NIC _IOWR('H', 0x07, struct hl_nic_args)
>
>
> ioctl numbers ('H') should be documented in
> Documentation/userspace-api/ioctl/ioctl-number.rst
>
> Sorry if I missed seeing
Hi,
On 9/12/20 7:41 AM, Oded Gabbay wrote:
> +#define HL_IOCTL_NIC _IOWR('H', 0x07, struct hl_nic_args)
ioctl numbers ('H') should be documented in
Documentation/userspace-api/ioctl/ioctl-number.rst
Sorry if I missed seeing that. (I scanned quickly.)
thanks.
--
~Randy
From: Omer Shpigelman
Initialize the QMANs that are responsible to submit doorbells to the NIC
engines. Add support for stopping and disabling them, and reset them as
part of the hard-reset procedure of GAUDI. This will allow the user to
submit work to the NICs.
Add support for receiving events
From: Omer Shpigelman
Basic NIC driver which handles Ethernet packet of several types like IPv4,
IPv6, LLDP, VLAN and ARP.
The NIC HW is composed of 5 NIC macros, in each macro 2 NIC engines of
100GbE each. Each engine exposes a single port of 100GbE, so in total we
have 10 ports per GAUDI devic
From: Omer Shpigelman
Add new structures and messages that the driver use to interact with the
firmware to receive information and events (errors) about GAUDI's NIC.
Signed-off-by: Omer Shpigelman
Reviewed-by: Oded Gabbay
Signed-off-by: Oded Gabbay
---
.../misc/habanalabs/include/common/cpuc
From: Omer Shpigelman
The user needs this information when working in a distributed environment
with master/slave configuration. All the slaves get their MAC addresses
from the driver and send them to the master.
Signed-off-by: Omer Shpigelman
Reviewed-by: Oded Gabbay
Signed-off-by: Oded Gabba
From: Omer Shpigelman
Add Work Queue (WQ) opcodes to NIC ioctl. A WQ contains entries (WQEs)
where each WQE represents a packet that should be sent or received.
Each WQ has two types: requester (sender) and responder (receiver).
The added opcodes are:
- Set WQ: set the WQ configuration in the H
From: Omer Shpigelman
Add NIC Completion Queue (CQ) opcodes to NIC ioctl. The CQ is used by the
user-space process to get notification of a completed work.
A CQ entry (CQE) has three types: requester (sender), responder
(receiver) and error. Each type has unique fields as well as shared ones.
C
From: Omer Shpigelman
The driver supports ethtool callbacks and provides statistics using the
device's profiling infrastructure (coresight).
We support the basic ethtool functionality and counters, as far as our H/W
provides support.
A summary of the supported callbacks:
- get_drvinfo: fill so
From: Omer Shpigelman
Finally, enable the NIC engines. Initialize the NIC ports mask variable
with full mask so all ports will be initialized.
Call the NIC init/fini from the common code.
Signed-off-by: Omer Shpigelman
Reviewed-by: Oded Gabbay
Signed-off-by: Oded Gabbay
---
drivers/misc/hab
From: Omer Shpigelman
Add Queue Pair (QP) error notification to the user e.g. security violation,
too many retransmissions, invalid QP etc.
Whenever a QP caused an error, the firmware will send an event to the
driver which will push the error as an error entry to the Completion Queue
(if exists)
From: Omer Shpigelman
Add DCB support to configure the NIC's Priority Flow Control (PFC).
The added support is minimal because a full support is not
currently required.
A summary of the supported callbacks:
- ieee_getpfc: get the current PFC configuration. PFC is enabled by
defau
From: Omer Shpigelman
Add Queue Pair (QP) opcodes to the NIC ioctl.
A QP represents a connection between two Gaudi ports. Each port currently
supports 1024 QPs where QP 0 is reserved for the driver for Ethernet.
User-space process needs to create a QP in order to communicate with other
Gaudis.
Hello,
This is the second version of the patch-set to upstream the GAUDI NIC code
into the habanalabs driver.
Modifications were made following reviews of the first version and are
detailed in the commit message of each patch that was changed.
A general note I want to write here is that I remove
From: Omer Shpigelman
Configure the NIC PHY (physical layer). The PHY is configured with the
correct polarity and Tx taps depending on the card type.
After the initial configuration, the PHY flow contains the following:
- Auto-negotiation (if enabled)
- PHY F/W tuning
- Physical Coding Sublayer
Hi Jakub,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Jakub-Kicinski/ethtool-add-standard-pause-stats/20200912-045257
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
Le 12/09/2020 à 12:25, Christophe JAILLET a écrit :
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated i
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'bdx_fifo_init()' GFP_ATOMIC must be used
because it
syzbot has bisected this issue to:
commit 135b8b37bd91cc82f83e98fca109b80375f5317e
Author: Kenny Yu
Date: Tue Jun 21 18:04:36 2016 +
cgroup: Add pids controller event when fork fails because of pid limit
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12f6d80d90
start
Hi David,
On Sat, Sep 12, 2020 at 2:44 AM David Miller wrote:
> From: Geert Uytterhoeven
> Date: Fri, 11 Sep 2020 08:32:55 +0200
>
> > On Thu, Sep 10, 2020 at 9:20 PM David Miller wrote:
> >> From: Geert Uytterhoeven
> >> Date: Tue, 1 Sep 2020 17:02:37 +0200
> >>
> >> > This reverts commit 12
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'rocker_dma_ring_create()' GFP_KERNEL can be
used be
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'sc92031_open()' GFP_KERNEL can be used
because it i
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'tlan_init()' GFP_KERNEL can be used because
it is o
tipc_group_add_to_tree() returns silently if `key` matches `nkey` of an
existing node, causing tipc_group_create_member() to leak memory. Let
tipc_group_add_to_tree() return an error in such a case, so that
tipc_group_create_member() can handle it properly.
Fixes: 75da2163dbb6 ("tipc: introduce co
On Fri, Sep 11, 2020 at 09:19:14PM +0300, Vadym Kochan wrote:
> Hi,
>
> I'd like to discuss a concept of introduction additional entity into SFP
> subsystem called SFP controller. But lets start with the issue.
>
> Issue
> =
>
> There are boards with SFP ports whose GPIO pins are not connect
On Thu, Sep 10, 2020 at 01:49:18PM +0300, Dan Carpenter wrote:
> On Thu, Sep 10, 2020 at 10:04:24AM +0530, Anmol Karn wrote:
> > Prevent hci_phy_link_complete_evt() from dereferencing 'hcon->amp_mgr'
> > as NULL. Fix it by adding pointer check for it.
> >
> > Reported-and-tested-by:
> > syzbot+0b
We found a set but not used variable 'ring_cons' in mlx4_en_xmit(), it will
cause a warning when build the kernel. And after checking the commit record
of this function, we found that it was introduced by a previous patch.
So, We delete this redundant assignment code.
Fixes: 488a9b48e398 ("net/ml
Hello,
syzbot found the following issue on:
HEAD commit:3b3ea602 x86: add failure injection to get/put/clear_user
git tree: https://github.com/google/kmsan.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=1357bd3e90
kernel config: https://syzkaller.appspot.com/x
On Sat, Sep 12, 2020 at 07:37:42AM +, Nikolay Aleksandrov wrote:
> On Sat, 2020-09-12 at 10:23 +0300, Vladimir Oltean wrote:
> > On Sat, Sep 12, 2020 at 06:56:12AM +, Nikolay Aleksandrov wrote:
> > > Could you point me to a thread where these problems were discussed and why
> > > they could
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'tlan_init()' GFP_KERNEL can be used because
it is o
On Sat, 2020-09-12 at 10:23 +0300, Vladimir Oltean wrote:
> On Sat, Sep 12, 2020 at 06:56:12AM +, Nikolay Aleksandrov wrote:
> > Could you point me to a thread where these problems were discussed and why
> > they couldn't be resolved within DSA in detail ?
>
> See my discussion with Florian in
Hi Yangbo,
On Sat, Sep 12, 2020 at 11:30:06AM +0800, Yangbo Lu wrote:
> The FIPER3 (fixed interval period pulse generator) is supported on
> DPAA2 and ENETC network controller hardware. This patch is to support
> it in ptp_qoriq driver.
>
> Signed-off-by: Yangbo Lu
> ---
> drivers/ptp/ptp_qoriq
On 11-09-2020 15:20, Dmitry Vyukov wrote:
> On Sat, Aug 8, 2020 at 8:56 AM syzbot
> wrote:
>> Hello,
>>
>> syzbot found the following issue on:
>>
>> HEAD commit:d6efb3ac Merge tag 'tty-5.9-rc1' of git://git.kernel.org/p..
>> git tree: upstream
>> console output: https://syzkaller.apps
On Sat, Sep 12, 2020 at 06:56:12AM +, Nikolay Aleksandrov wrote:
> Could you point me to a thread where these problems were discussed and why
> they couldn't be resolved within DSA in detail ?
See my discussion with Florian in this thread:
http://patchwork.ozlabs.org/project/netdev/patch/20200
On Fri, Sep 11, 2020 at 05:42:46PM -0700, Jakub Kicinski wrote:
> > The ethtool -S framework was nice because you could append to the
> > counters of the master interface while not losing them.
> > As for "ethtool -A", those parameters are fixed as part of the
> > fixed-link device tree node corres
77 matches
Mail list logo
