Hi Hillf,
> Let’s see if TCQ_F_NOLOC is making fq_codel different in your testing.
I assume you meant disabling NOLOCK for pfifo_fast.
Here is the modification,
--- ./net/sched/sch_generic.c.orig 2020-08-24 22:02:04.589830751 +0800
+++ ./net/sched/sch_generic.c 2020-08-27 10:17:10.148977
On Wed, Aug 26, 2020 at 06:26:36PM +0200, Heiner Kallweit wrote:
> On 26.08.2020 11:51, Sascha Hauer wrote:
> > __mdiobus_register() can fail between calling device_register() and
> > setting bus->state to MDIOBUS_REGISTERED. When this happens the caller
> > will call mdiobus_free() which then free
The buffer size is 2 Bytes and we expect to receive the same amount of
data. But sometimes we receive less data and run into uninit-was-stored
issue upon read. Hence modify the error check on the return value to match
with the buffer size as a prevention.
Reported-and-tested by: syzbot+a7e220df5a8
Since commit aab8cc3630e32
("vxlan: add support for underlay in non-default VRF")
vxlan_find_sock() also checks if socket is assigned to the right
level 3 master device when lower device is not in the default VRF.
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 5 +++--
1 file changed
Sort flag assignment to add readability.
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index e9b561b9d23e1..1501a5633a97e 100644
--- a/drivers/net
Replace common flag assignment with a macro.
This could yet be simplified with changelink/supported but it would
remove clarity
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 113 +---
include/net/vxlan.h | 10
2 files changed, 23 insertio
rtnl_configure_link is always checked if < 0 for error code.
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 14f903d09c010..1e9ab1002281c 100644
--- a/drivers/net/vxlan.c
+
vxlan_xmit_one() was only called from vxlan_xmit() without rdst and
info was already tested. Emit warning in that function instead
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/ne
small optimization around checking as it's being done in all
receptions
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 47c762f7f5b11..cc904f003f158 100644
--- a/drivers/ne
call vxlan_remcsum() before md filling in vxlan_rcv()
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index b9fefe27e3e89..47c762f7f5b11 100644
--- a/drivers/net/vxlan.c
+
On Wed, 26 Aug 2020, Kalle Valo wrote:
> Lee Jones wrote:
>
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function parameter or
> > member 'ptr_' not described in 'wmi_buffer_block'
> > drivers/net/wireless/ath/wil6210/wmi.c
On Wed, 26 Aug 2020, Kalle Valo wrote:
> Lee Jones wrote:
>
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/net/wireless/ath/wil6210/wmi.c:52: warning: Incorrect use of
> > kernel-doc format: * Addressing - theory of operations
> > drivers/net/wireless/ath/wil6210/wmi.c
On Wed, Aug 26, 2020 at 6:31 PM Greg KH wrote:
>
> On Tue, Aug 25, 2020 at 01:25:32PM +0800, xiangxia.m@gmail.com wrote:
> > From: Tonghao Zhang
> >
> > [ Upstream commit 77b981c82c1df7c7ad32a046f17f007450b46954 ]
>
> That is not what this commit is :(
>
> Please fix up and resend with the co
From: Tonghao Zhang
[ Upstream commit 1f3a090b9033f69de380c03db3ea1a1015c850cf ]
Backport this commit to 5.5 - 5.8.3.
To avoid some issues, for example RCU usage warning and double free,
we should flush the flows under ovs_lock. This patch refactors
table_instance_destroy and introduces table_i
27.08.2020 09:23, Gustavo A. R. Silva пишет:
> Hi,
>
> There is a patch that address this, already:
>
> https://lore.kernel.org/lkml/20200821063758.GA17783@embeddedor/
>
> Thanks
Okay, then my patch is unnecessary. Thank you!
Hi,
There is a patch that address this, already:
https://lore.kernel.org/lkml/20200821063758.GA17783@embeddedor/
Thanks
--
Gustavo
On 8/27/20 01:04, Dmitry Osipenko wrote:
> There is no need to insert the "fallthrough" comment if there is nothing
> in-between of case switches. Hence let's remov
27.08.2020 09:04, Dmitry Osipenko пишет:
> This patch fixes SDHCI CRC errors during of RX throughput testing on
> BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the
> checksum problem is observed on NVIDIA Tegra20 SoCs. The good watermark
> value is borrowed from downstream BCMDHD d
There is no need to insert the "fallthrough" comment if there is nothing
in-between of case switches. Hence let's remove the unnecessary comments
in order to make code cleaner a tad.
Signed-off-by: Dmitry Osipenko
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 --
drivers/net/
This patch fixes SDHCI CRC errors during of RX throughput testing on
BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the
checksum problem is observed on NVIDIA Tegra20 SoCs. The good watermark
value is borrowed from downstream BCMDHD driver and it's matching to the
value that is alre
Hello!
Recently I was debugging WiFi performance problems on Acer A500 tablet
device that got upstreamed recently. This is an older Android device from
2011-2012 that is powered by NVIDIA Tegra20 SoC and it has BCM4329 chip
that provides WiFi (SDIO) and Bluetooth (UART). I noticed that WiFi
throug
The chip ID was already printed out at the time when debug message about
the changed F2 watermark is printed, hence let's drop the unnecessary part
of the debug messages. This cleans code a tad and also allows to re-use
the F2 watermark debug messages by multiple chips.
Suggested-by: Arend van Spr
Setting F2 block size to 128 bytes for BCM4329 allows to significantly
improve RX throughput on NVIDIA Tegra20. Before this change the throughput
was capped to 30 Mbit/s on Tegra, now throughput is at 40 Mbit/s, which is
a maximum throughput for the BCM4329 chip. The F2 block size is borrowed
from
On Tue, Aug 25, 2020 at 4:21 PM Udip Pant wrote:
>
> This adds a selftest that tests the behavior when a freplace target program
> attempts to make a write access on a packet. The expectation is that the read
> or write
> access is granted based on the program type of the linked program and
> not
Hello,
syzbot found the following issue on:
HEAD commit:85eb5bc3 net: atheros: switch from 'pci_' to 'dma_' API
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=14e3213990
kernel config: https://syzkaller.appspot.com/x/.config?x=a0437fdd630bee11
dashboar
On Wed, Aug 26, 2020 at 9:06 AM Carlos Neira wrote:
>
> In multi-threaded applications bpf_get_current_comm is returning per-thread
> names, this helper will return comm from real_parent.
> This makes a difference for some Java applications, where get_current_comm is
> returning per-thread names,
On Wed, Aug 26, 2020 at 5:07 PM Yonghong Song wrote:
>
> Added support for link_query for main_thread_only information
> with task/task_file iterators.
>
> Signed-off-by: Yonghong Song
> ---
> include/uapi/linux/bpf.h | 5 +
> kernel/bpf/task_iter.c | 17 +
> t
On Wed, Aug 26, 2020 at 9:13 PM Andrii Nakryiko wrote:
>
> Fix compilation warnings due to __u64 defined differently as `unsigned long`
> or `unsigned long long` on different architectures (e.g., ppc64le differs from
> x86-64). Also cast one argument to size_t to fix printf warning of similar
> na
On Wed, Aug 26, 2020 at 5:07 PM Yonghong Song wrote:
>
> Currently, task and task_file by default iterates through
> all tasks. For task_file, by default, all files from all tasks
> will be traversed.
>
> But for a user process, the file_table is shared by all threads
> of that process. So travers
On Wed, Aug 26, 2020 at 5:07 PM Yonghong Song wrote:
>
> bpf_link_info.iter is used by link_query to return
> bpf_iter_link_info to user space. Fields may be different
> ,e.g., map_fd vs. map_id, so we cannot reuse
> the exact structure. But make them similar, e.g.,
> struct bpf_link_info {
>
Hi Tetsuo,
> > "grep -FrB1 'del_timer' drivers/ | grep -FA1 '.function)'" says that
> > currently there are 28 locations which call del_timer[_sync]() only if
> > that timer's function field was initialized (because timer_setup()
> > sets that timer's function field). Therefore, let's use same app
> From: Jakub Kicinski
> Sent: Thursday, August 27, 2020 1:38 AM
>
> On Wed, 26 Aug 2020 04:27:35 + Parav Pandit wrote:
> > > On Tue, 25 Aug 2020 16:58:38 +0300 Parav Pandit wrote:
> > > > A devlink port may be for a controller consist of PCI device.
> > > > A devlink instance holds ports o
On Wed, Aug 26, 2020 at 9:08 AM Alexei Starovoitov
wrote:
>
> On Tue, Aug 25, 2020 at 08:09:21PM -0700, Andrii Nakryiko wrote:
> > Add __pu64 and __ps64 (sort of like "printf u64 and s64") for
> > libbpf-internal
> > use only in printf-like situations to avoid compilation warnings due to
> > %lld
Fix compilation warnings due to __u64 defined differently as `unsigned long`
or `unsigned long long` on different architectures (e.g., ppc64le differs from
x86-64). Also cast one argument to size_t to fix printf warning of similar
nature.
Reported-by: Naresh Kamboju
Fixes: eacaaed784e2 ("libbpf:
On 8/25/2020 11:33 PM, Marcelo Ricardo Leitner wrote:
> On Tue, Aug 25, 2020 at 02:07:43PM +0800, we...@ucloud.cn wrote:
> ...
>> +static LIST_HEAD(ct_output_list);
>> +static DEFINE_SPINLOCK(ct_output_list_lock);
>> +
>> +#define CT_OUTPUT_RECURSION_LIMIT4
>> +static DEFINE_PER_CPU(unsigned
Syzbot has reported those issues as:
==
BUG: KASAN: use-after-free in tipc_bcast_get_mode+0x3ab/0x400
net/tipc/bcast.c:759
Read of size 1 at addr 88805e6b3571 by task kworker/0:6/3850
CPU: 0 PID: 3850 Comm: kworker/0:6 Not taint
When kcalloc() on rx_rings fails, we should free tx_rings
and xdp_rings to prevent memleak. Similarly, when
ice_alloc_rx_bufs() fails, we should free xdp_rings.
Signed-off-by: Dinghao Liu
---
drivers/net/ethernet/intel/ice/ice_ethtool.c | 13 +++--
1 file changed, 11 insertions(+), 2 del
From: Hoang Le
Problem:
In kernel upstream, we add the support to set node identity with
128bit. However, we are still using legacy format in command tipc
peer removing. Then, we got a problem when trying to remove
offline node i.e:
$ tipc node list
Node IdentityHash Stat
In preparation for moving all MDIO drivers into drivers/net/mdio, move
the mdio-i2c header file into include/linux/mdio so it can be used by
both the MDIO driver and the SFP code which instantiates I2C MDIO
busses.
v2:
Add include/linux/mdio
Reviewed-by: Florian Fainelli
Signed-off-by: Andrew Lu
Create drivers/net/pcs and move the Synopsys DesignWare XPCS into the
new directory. Move the header file into a subdirectory
include/linux/pcs
Start a naming convention of all PCS files use the prefix pcs-, and
rename the XPCS files to fit.
v2:
Add include/linux/pcs
v4:
Fix include path in stmm
This header file is currently included into the ethernet driver via a
relative path into the PHY subsystem. This is bad practice, and causes
issues for the upcoming move of the MDIO driver. Move the header file
into include/linux to clean this up.
v2:
Move header to include/linux/mdio
Reviewed-by
Sort the Kconfig based on the text shown in make menuconfig and sort
the Makefile by CONFIG symbol.
Acked-by: Florian Fainelli
Signed-off-by: Andrew Lunn
---
drivers/net/phy/Kconfig | 164 +++
drivers/net/phy/Makefile | 10 +--
2 files changed, 87 insertion
Move all the MDIO drivers and multiplexers into drivers/net/mdio. The
mdio core is however left in the phy directory, due to mutual
dependencies between the MDIO core and the PHY core.
Take this opportunity to sort the Kconfig based on the menuconfig
strings, and move the multiplexers to the end
The phy subdirectory is getting cluttered. It has both PHY drivers and
MDIO drivers, plus a stray switch driver. Soon more PCS drivers are
likely to appear.
Move MDIO and PCS drivers into new directories. This requires fixing
up the xgene driver which uses a relative include path.
v2:
Move the su
Attention To Email : netdev@vger.kernel.org
Good Day Sir,
Our Group have the financial capability to finance any investment portfolio as
far as is genuine, all we need is a capable business partner that possesses
investment strategies for profitable business information for good turn over
within
On Wed, Aug 26, 2020 at 8:43 PM Kees Cook wrote:
>
> On Wed, Aug 26, 2020 at 12:55:28PM +0300, Dan Carpenter wrote:
> > On Wed, Aug 26, 2020 at 07:21:35AM +0530, Allen Pais wrote:
> > > On Thu, Aug 20, 2020 at 3:09 AM James Bottomley
> > > wrote:
> > > >
> > > > On Wed, 2020-08-19 at 21:54 +0530,
Hi Amit,
On Thu, Aug 27, 2020 at 02:06:39AM +0300, Amit Klein wrote:
> Hi
>
> Is there an ETA for this patch then?
No particular ETA on my side, I was waiting for potential criticisms
before going further. I suspect that if nobody complains anymore, it's
an implicit voucher and I'll have to clea
On Wed, Aug 26, 2020 at 09:33:29AM -0700, David Miller wrote:
> From: Mira Ressel
> Date: Wed, 26 Aug 2020 16:29:01 +
>
> > On Wed, Aug 26, 2020 at 08:28:57AM -0700, David Miller wrote:
> >> From: Mira Ressel
> >> Date: Wed, 26 Aug 2020 15:20:00 +
> >>
> >> > I'm setting the peer->perm_
On 2020-08-27 07:27 +0800, Coiby Xu wrote:
> This fixes commit 0107635e15ac
> ("staging: qlge: replace pr_err with netdev_err") which introduced an
> build breakage of missing `struct ql_adapter *qdev` for some functions
> and a warning of type mismatch with dumping enabled, i.e.,
>
> $ make CFLAG
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
drivers/net/ethernet/ibm/ibmvnic.c
between commit:
9f1345737790 ("ibmvnic fix NULL tx_pools and rx_tools issue at do_reset")
from the net tree and commit:
507ebe6444a4 ("ibmvnic: Fix use-after-free of VNIC login re
On 8/26/20 2:14 PM, Jakub Kicinski wrote:
On Wed, 26 Aug 2020 09:42:13 -0700 Shannon Nelson wrote:
+ if (qparam->nxqs != lif->nxqs) {
+ err = netif_set_real_num_tx_queues(lif->netdev, lif->nxqs);
+ if (err)
+ goto err_out;
+ e
bpf_link_info.iter is used by link_query to return
bpf_iter_link_info to user space. Fields may be different
,e.g., map_fd vs. map_id, so we cannot reuse
the exact structure. But make them similar, e.g.,
struct bpf_link_info {
/* common fields */
union {
struct { ... } raw_trace
Currently, task and task_file by default iterates through
all tasks. For task_file, by default, all files from all tasks
will be traversed.
But for a user process, the file_table is shared by all threads
of that process. So traversing the main thread per process should
be enough to traverse all fi
For task and task_file bpf iterators, optional 'task main_thread_only'
can signal the kernel to only iterate through main threads of each
process. link_query will also print out main_thread_only value for
task/task_file iterators.
This patch also fixed the issue where if the additional arguments
a
Commit e679654a704e ("bpf: Fix a rcu_sched stall issue with
bpf task/task_file iterator") introduced rate limiting in
bpf_seq_read() to fix a case where traversing too many tasks
and files (tens of millions of files) may cause kernel rcu stall.
But rate limiting won't reduce the amount of work to t
Added support for link_query for main_thread_only information
with task/task_file iterators.
Signed-off-by: Yonghong Song
---
include/uapi/linux/bpf.h | 5 +
kernel/bpf/task_iter.c | 17 +
tools/include/uapi/linux/bpf.h | 5 +
3 files changed, 27 insertion
Modified existing bpf_iter_test_file program to check
whether all accessed files from the main thread or not.
$ ./test_progs -n 4
...
#4/7 task_file:OK
...
#4 bpf_iter:OK
Summary: 1/24 PASSED, 0 SKIPPED, 0 FAILED
Signed-off-by: Yonghong Song
---
.../selftests/bpf/prog_tests/bpf_iter.
On 8/26/20 2:09 PM, Jakub Kicinski wrote:
On Wed, 26 Aug 2020 09:42:11 -0700 Shannon Nelson wrote:
+ mutex_lock(&lif->queue_lock);
+ netif_device_detach(lif->netdev);
+ ionic_stop_queues(lif);
+ ionic_txrx_deinit(lif);
+ err = ionic_txrx_init(lif);
+ if (err)
+
On 8/26/20 2:01 PM, Jakub Kicinski wrote:
On Wed, 26 Aug 2020 09:42:09 -0700 Shannon Nelson wrote:
+ q_base = (void *)ALIGN((uintptr_t)new->q_base, PAGE_SIZE);
PTR_ALIGN()
Sure,
sln
This fixes commit 0107635e15ac
("staging: qlge: replace pr_err with netdev_err") which introduced an
build breakage of missing `struct ql_adapter *qdev` for some functions
and a warning of type mismatch with dumping enabled, i.e.,
$ make CFLAGS_MODULE="QL_ALL_DUMP=1 QL_OB_DUMP=1 QL_CB_DUMP=1 \
Q
> From: Bixuan Cui
> Sent: Friday, July 31, 2020 3:08 AM
> To: da...@davemloft.net; k...@kernel.org
> Cc: Kirsher, Jeffrey T ; intel-wired-
> l...@lists.osuosl.org; netdev@vger.kernel.org; linux-n...@vger.kernel.org
> Subject: [PATCH -next v2] net: ice: Fix pointer cast warnings
>
> pointers shou
From: Rikard Falkeborn
Date: Thu, 27 Aug 2020 00:56:02 +0200
> This series constifies a number of static ops variables, to allow the
> compiler to put them in read-only memory. Compile-tested only.
Series applied, thank you.
From: Jakub Kicinski
Date: Wed, 26 Aug 2020 12:40:05 -0700
> Rob run into crashes when using XDP on bnxt. Upon investigation
> it turns out that during driver reconfig irq core produces
> a warning message when IRQs are requested. This triggers netpoll,
> which in turn accesses uninitialized driv
From: Ido Schimmel
Date: Wed, 26 Aug 2020 19:48:50 +0300
> This patch set contains various improvements that I made to the nexthop
> object code while studying it towards my upcoming changes.
>
> While patches #4 and #6 fix bugs, they are not regressions (never
> worked). They also do not occur
From: Ido Schimmel
Date: Wed, 26 Aug 2020 19:48:10 +0300
> From: Ido Schimmel
>
> fib_info_notify_update() is always called with RTNL held, but not from
> an RCU read-side critical section. This leads to the following warning
> [1] when the FIB table list is traversed with
> hlist_for_each_entr
The only usage of qca_serdev_ops is to pass its address to
serdev_device_set_client_ops() which takes a const pointer. Make it
const to allow the compiler to put it in read-only memory.
Signed-off-by: Rikard Falkeborn
---
drivers/net/ethernet/qualcomm/qca_uart.c | 2 +-
1 file changed, 1 inserti
This series constifies a number of static ops variables, to allow the
compiler to put them in read-only memory. Compile-tested only.
Rikard Falkeborn (6):
net: ethernet: qualcomm: constify qca_serdev_ops
net: ethernet: ravb: constify bb_ops
net: renesas: sh_eth: constify bb_ops
net: phy: a
The only usage of bb_ops is to assign its address to the ops field in
the mdiobb_ctrl struct, which is a const pointer. Make it const to allow
the compiler to put it in read-only memory.
Signed-off-by: Rikard Falkeborn
---
drivers/net/ethernet/renesas/sh_eth.c | 2 +-
1 file changed, 1 insertion
The only usage of vddio_regulator_ops and vddh_regulator_ops is to
assign their address to the ops field in the regulator_desc struct,
which is a const pointer. Make them const to allow the compiler to
put them in read-only memory.
Signed-off-by: Rikard Falkeborn
---
drivers/net/phy/at803x.c | 4
The only usage of vsc8584_macsec_ops is to assign its address to the
macsec_ops field in the phydev struct, which is a const pointer. Make it
const to allow the compiler to put it in read-only memory.
Signed-off-by: Rikard Falkeborn
---
drivers/net/phy/mscc/mscc_macsec.c | 2 +-
1 file changed,
The only usage of ath11k_thermal_ops is to pass its address to
thermal_cooling_device_register() which takes a const pointer. Make it
const to allow the compiler to put it in read-only memory.
Signed-off-by: Rikard Falkeborn
---
drivers/net/wireless/ath/ath11k/thermal.c | 2 +-
1 file changed, 1
The only usage of bb_ops is to assign its address to the ops field in
the mdiobb_ctrl struct, which is a const pointer. Make it const to allow
the compiler to put it in read-only memory.
Signed-off-by: Rikard Falkeborn
---
drivers/net/ethernet/renesas/ravb_main.c | 2 +-
1 file changed, 1 insert
From: Tariq Toukan
Date: Wed, 26 Aug 2020 15:54:15 +0300
> This patchset adds a common net API for L1 cacheline size-aware prefetch.
>
> Patch 1 introduces the common API in net and aligns the drivers to use it.
> Patches 2 and 3 add usage in mlx4 and mlx5 Eth drivers.
>
> Series generated agai
From: vineetha.g.jaya.kuma...@intel.com
Date: Wed, 26 Aug 2020 12:33:40 +0800
> This patch set enables support for Ethernet on the Intel Keem Bay SoC.
> The first patch contains the required Device Tree bindings documentation,
> while the second patch adds the Intel platform glue layer for the st
From: Xie He
Date: Tue, 25 Aug 2020 20:03:53 -0700
> Set the skb's network_header before it is passed to the underlying
> Ethernet device for transmission.
>
> This patch fixes the following issue:
>
> When we use this driver with AF_PACKET sockets, there would be error
> messages of:
>prot
From: Florian Westphal
Date: Wed, 26 Aug 2020 01:31:05 +0200
> After subflow lock is dropped, more wmem might have been made available.
>
> This fixes a deadlock in mptcp_connect.sh 'mmap' mode: wmem is exhausted.
> But as the mptcp socket holds on to already-acked data (for retransmit)
> no wak
Please disregard this earlier email without the Fixes tag.
On Wed, Aug 26, 2020 at 3:26 PM Abhishek Pandit-Subedi
wrote:
>
> While unregistering, make sure to clear the suspend tasks before
> cancelling the work. If the unregister is called during resume from
> suspend, this will unnecessarily ad
While unregistering, make sure to clear the suspend tasks before
cancelling the work. If the unregister is called during resume from
suspend, this will unnecessarily add 2s to the resume time otherwise.
Fixes: 4e8c36c3b0d73d (Bluetooth: Fix suspend notifier race)
Signed-off-by: Abhishek Pandit-Sub
From: Vinicius Costa Gomes
Date: Tue, 25 Aug 2020 10:44:04 -0700
> Since commit 9c66d1564676 ("taprio: Add support for hardware
> offloading") there's a bit of inconsistency when offloading schedules
> to the hardware:
>
> In software mode, the gate masks are specified in terms of traffic
> clas
From: we...@ucloud.cn
Date: Tue, 25 Aug 2020 14:07:43 +0800
> From: wenxu
>
> The fragment packets do defrag in act_ct module. If the reassembled
> packet should send out to another net device. This over mtu big packet
> should be fragmented to send out. This patch add the act ct_output to
> arc
Hello,
syzbot found the following issue on:
HEAD commit:4af7b32f Merge git://git.kernel.org/pub/scm/linux/kernel/g..
git tree: bpf
console output: https://syzkaller.appspot.com/x/log.txt?x=1425b64990
kernel config: https://syzkaller.appspot.com/x/.config?x=3d400a47d1416652
dashboar
Le 26/08/2020 à 20:52, Harald Welte a écrit :
> Hi Nicolas,
>
> On Wed, Aug 26, 2020 at 09:47:54AM +0200, Nicolas Dichtel wrote:
>>> Sending (unsolicited) notifications about all of those seems quite
>>> heavyweight to me.
>>
>> There is no 'unsolicited' notifications with this patch. Notificatio
While unregistering, make sure to clear the suspend tasks before
cancelling the work. If the unregister is called during resume from
suspend, this will unnecessarily add 2s to the resume time otherwise.
Signed-off-by: Abhishek Pandit-Subedi
---
This was discovered with RT8822CE using the btusb dr
> -Original Message-
> From: Shannon Nelson
> Sent: Tuesday, August 25, 2020 9:32 AM
> To: Wyborny, Carolyn ;
> netdev@vger.kernel.org
> Cc: da...@davemloft.net; k...@kernel.org; Brandeburg, Jesse
> ; Herbert, Tom
> Subject: Re: [RFC PATCH net-next 0/2] Granular VF Trust Flags for SR-IOV
On Wed, Aug 26, 2020 at 12:56 AM Alex Gartrell wrote:
>
> There are code paths where EINVAL is returned directly without setting
> errno. In that case, errno could be 0, which would mask the
> failure. For example, if a careless programmer set log_level to 1
> out of laziness, they would have
On Fri, Aug 21, 2020 at 07:38:15PM +0200, Maciej Fijalkowski wrote:
> On Mon, Aug 03, 2020 at 04:00:10PM +0200, Daniel Borkmann wrote:
> > On 8/2/20 5:07 AM, Alexei Starovoitov wrote:
> > > On Sat, Aug 01, 2020 at 09:13:57AM +0200, Maciej Fijalkowski wrote:
> > > > On Sat, Aug 01, 2020 at 03:03:19A
On Wed, 26 Aug 2020 09:42:13 -0700 Shannon Nelson wrote:
> + if (qparam->nxqs != lif->nxqs) {
> + err = netif_set_real_num_tx_queues(lif->netdev, lif->nxqs);
> + if (err)
> + goto err_out;
> + err = netif_set_real_num_rx_queues(lif->netdev
On Wed, 26 Aug 2020 09:42:11 -0700 Shannon Nelson wrote:
> + mutex_lock(&lif->queue_lock);
> + netif_device_detach(lif->netdev);
> + ionic_stop_queues(lif);
> + ionic_txrx_deinit(lif);
>
> + err = ionic_txrx_init(lif);
> + if (err)
> + goto err_out;
> +
> +
On Wed, 26 Aug 2020 09:42:09 -0700 Shannon Nelson wrote:
> + q_base = (void *)ALIGN((uintptr_t)new->q_base, PAGE_SIZE);
PTR_ALIGN()
On Wed, Aug 26, 2020 at 12:40 PM Jakub Kicinski wrote:
>
> Netpoll can try to poll napi as soon as napi_enable() is called.
> It crashes trying to access a doorbell which is still NULL:
>
> BUG: kernel NULL pointer dereference, address:
> CPU: 59 PID: 6039 Comm: ethtool Kdump: l
On Wed, 26 Aug 2020 04:27:35 + Parav Pandit wrote:
> > On Tue, 25 Aug 2020 16:58:38 +0300 Parav Pandit wrote:
> > > A devlink port may be for a controller consist of PCI device.
> > > A devlink instance holds ports of two types of controllers.
> > > (1) controller discovered on same system wh
On Tue, Aug 25, 2020 at 04:19:59PM -0700, Udip Pant wrote:
> This patch series adds changes in verifier to make decisions such as granting
> of read / write access or enforcement of return code status based on
> the program type of the target program while using dynamic program
> extension (of type
On 8/26/20 6:12 AM, Ahmed Abdelsalam wrote:
>
> On 26/08/2020 02:45, David Ahern wrote:
>> On 8/25/20 5:45 PM, Ahmed Abdelsalam wrote:
>>>
>>> Hi David
>>>
>>> The seg6 encap is implemented through the seg6_lwt rather than
>>> seg6_local_lwt.
>>
>> ok. I don't know the seg6 code; just taking a gue
When we clone state only add_time was cloned. It missed values like
bytes, packets. Now clone the all members of the structure.
Fixes: 80c9abaabf42 ("[XFRM]: Extension for dynamic update of endpoint
address(es)")
Signed-off-by: Antony Antony
---
net/xfrm/xfrm_state.c | 2 +-
1 file changed, 1
napi_disable() makes sure to set the NAPI_STATE_NPSVC bit to prevent
netpoll from accessing rings before init is complete. However, the
same is not done for fresh napi instances in netif_napi_add(),
even though we expect NAPI instances to be added as disabled.
This causes crashes during driver rec
Netpoll can try to poll napi as soon as napi_enable() is called.
It crashes trying to access a doorbell which is still NULL:
BUG: kernel NULL pointer dereference, address:
CPU: 59 PID: 6039 Comm: ethtool Kdump: loaded Tainted: G S
5.9.0-rc1-00469-g5fd99b5d9950-di
XFRMA_SEC_CTX was not cloned from the old to the new.
Migrate this attribute during XFRMA_MSG_MIGRATE
v1->v2:
- return -ENOMEM on error
Fixes: 80c9abaabf42 ("[XFRM]: Extension for dynamic update of endpoint
address(es)")
Signed-off-by: Antony Antony
---
net/xfrm/xfrm_state.c | 28
Hi!
Rob run into crashes when using XDP on bnxt. Upon investigation
it turns out that during driver reconfig irq core produces
a warning message when IRQs are requested. This triggers netpoll,
which in turn accesses uninitialized driver state. Same crash can
also be triggered on this platform by c
XFRMA_REPLAY_ESN_VAL was not cloned completely from the old to the new.
Migrate this attribute during XFRMA_MSG_MIGRATE
v1->v2:
- move curleft cloning to a seperate patch
Fixes: af2f464e326e ("xfrm: Assign esn pointers when cloning a state")
Signed-off-by: Antony Antony
---
include/net/xfrm.h
XFRMA_SET_MARK and XFRMA_SET_MARK_MASK was not cloned from the old
to the new. Migrate these two attributes during XFRMA_MSG_MIGRATE
Fixes: 9b42c1f179a6 ("xfrm: Extend the output_mark to support input direction
and masking.")
Signed-off-by: Antony Antony
---
net/xfrm/xfrm_state.c | 1 +
1 file
On Mon, Aug 24, 2020 at 10:08 PM wrote:
>
> From: Tonghao Zhang
>
> Decrease table->count and ufid_count unconditionally,
> because we only don't use count or ufid_count to count
> when flushing the flows. To simplify the codes, we
> remove the "count" argument of table_instance_flow_free.
>
> To
1 - 100 of 255 matches
Mail list logo
