On 8/26/20 2:14 PM, Jakub Kicinski wrote:
On Wed, 26 Aug 2020 09:42:13 -0700 Shannon Nelson wrote:
+ if (qparam->nxqs != lif->nxqs) {
+ err = netif_set_real_num_tx_queues(lif->netdev, lif->nxqs);
+ if (err)
+ goto err_out;
+ err = netif_set_real_num_rx_queues(lif->netdev, lif->nxqs);
+ if (err)
+ goto err_out;
does error handling reset real_num_tx_queues to previous value?
+ }
No, the point was to not change the real_num values until we knew that
everything else was sorted out and swapped. However, it looks like that
could be put right after the queues are stopped and before the swap, so
that if the real_num change fails we can reactivate everything as it was
and dump all the new allocations.
I'll work that up and see what it looks like.
Thanks,
sln
