Re: [PATCH net V2] Crypto/chcr: Registering cxgb4 to xfrmdev_ops

2020-07-24 Thread Herbert Xu
On Fri, Jul 24, 2020 at 05:01:08PM -0700, David Miller wrote: > > Please start submitting chcr patches to the crypto subsystem, where it > belongs, instead of the networking GIT trees. Hi Dave: I think this patch belongs to the networking tree. The reason is that it's related to xfrm offload wh

Re: UDP data corruption in v4.4

2020-07-24 Thread Greg KH
On Sat, Jul 25, 2020 at 02:21:06AM +, Dexuan Cui wrote: > Hi, > The v4.4 stable kernel (currently it's v4.4.231) lacks this bugfix: > 327868212381 ("make skb_copy_datagram_msg() et.al. preserve ->msg_iter on > error") > , as a result, the v4.4 kernel can deliver corrupt data to the application

Re: Re: [PATCH] octeontx2-af: Fix use of uninitialized pointer bmap

2020-07-24 Thread dinghao . liu
> From: Dinghao Liu > Date: Fri, 24 Jul 2020 16:06:57 +0800 > > > If req->ctype does not match any of NIX_AQ_CTYPE_CQ, > > NIX_AQ_CTYPE_SQ or NIX_AQ_CTYPE_RQ, pointer bmap will remain > > uninitialized and be accessed in test_bit(), which can lead > > to kernal crash. > > This can never happen.

[GIT] Networking

2020-07-24 Thread David Miller
1) Fix RCU locaking in iwlwifi, from Johannes Berg. 2) mt76 can access uninitialized NAPI struct, from Felix Fietkau. 3) Fix race in updating pause settings in bnxt_en, from Vasundhara Volam. 4) Propagate error return properly during unbind failures in ax88172a, from George Kennedy. 5) Fix

Re: INFO: task hung in synchronize_rcu (3)

2020-07-24 Thread syzbot
syzbot has bisected this issue to: commit 5a781ccbd19e4664babcbe4b4ead7aa2b9283d22 Author: Vinicius Costa Gomes Date: Sat Sep 29 00:59:43 2018 + tc: Add support for configuring the taprio scheduler bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=149057ef10 start commi

INFO: task hung in ovs_dp_cmd_del

2020-07-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e0145983 Merge branch 'fix-bpf_get_stack-with-PEBS' git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=16ce401f10 kernel config: https://syzkaller.appspot.com/x/.config?x=2b7b67c0c1819c87 dashboard li

[PATCH net v2 2/3] octeontx2-pf: cancel reset_task work

2020-07-24 Thread sundeep . lkml
From: Subbaraya Sundeep During driver exit cancel the queued reset_task work in VF driver. Fixes: 3184fb5ba96e ("octeontx2-vf: Virtual function driver support") Signed-off-by: Subbaraya Sundeep Signed-off-by: Sunil Goutham --- v2 changes: None drivers/net/ethernet/marvell/octeontx2/

[PATCH net v2 3/3] octeontx2-pf: Unregister netdev at driver remove

2020-07-24 Thread sundeep . lkml
From: Subbaraya Sundeep Added unregister_netdev in the driver remove function. Generally unregister_netdev is called after disabling all the device interrupts but here it is called before disabling device mailbox interrupts. The reason behind this is VF needs mailbox interrupt to communicate with

[PATCH net v2 1/3] octeontx2-pf: Fix reset_task bugs

2020-07-24 Thread sundeep . lkml
From: Subbaraya Sundeep Two bugs exist in the code related to reset_task in PF driver one is the missing protection against network stack ndo_open and ndo_close. Other one is the missing cancel_work. This patch fixes those problems. Fixes: 4ff7d1488a84 ("octeontx2-pf: Error handling support") Si

[PATCH net v2 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-24 Thread sundeep . lkml
From: Subbaraya Sundeep Hi, There are problems in the existing Octeontx2 netdev drivers like missing cancel_work for the reset task, missing lock in reset task and missing unergister_netdev in driver remove. This patch set fixes the above problems. Thanks, Sundeep Subbaraya Sundeep (3): oct

Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-24 Thread sundeep subbaraya
Hi David, On Sat, Jul 25, 2020 at 8:40 AM David Miller wrote: > > From: sundeep subbaraya > Date: Fri, 24 Jul 2020 08:40:44 +0530 > > > On Fri, Jul 24, 2020 at 12:43 AM David Miller wrote: > >> > >> If you leave interrupts on then an interrupt can arrive after the software > >> state has been r

Re: [PATCH] drivers/net/wan: lapb: Corrected the usage of skb_cow

2020-07-24 Thread David Miller
From: Xie He Date: Fri, 24 Jul 2020 09:33:47 -0700 > This patch fixed 2 issues with the usage of skb_cow in LAPB drivers > "lapbether" and "hdlc_x25": > > 1) After skb_cow fails, kfree_skb should be called to drop a reference > to the skb. But in both drivers, kfree_skb is not called. > > 2) sk

Re: [PATCH 2/4] drivers: crypto: add support for OCTEONTX2 CPT engine

2020-07-24 Thread David Miller
From: Srujana Challa Date: Fri, 24 Jul 2020 18:38:02 +0530 > diff --git a/drivers/crypto/marvell/octeontx2/otx2_cpt_common.h > b/drivers/crypto/marvell/octeontx2/otx2_cpt_common.h > new file mode 100644 > index 000..00cd534 > --- /dev/null > +++ b/drivers/crypto/marvell/octeontx2/otx2_cpt_co

Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-24 Thread David Miller
From: sundeep subbaraya Date: Fri, 24 Jul 2020 08:40:44 +0530 > On Fri, Jul 24, 2020 at 12:43 AM David Miller wrote: >> >> If you leave interrupts on then an interrupt can arrive after the software >> state has been released by unregister_netdev. >> >> Sounds like you need to resolve this some o

Re: [PATCH net] udp: Remove an unnecessary variable in udp[46]_lib_lookup2().

2020-07-24 Thread Willem de Bruijn
On Fri, Jul 24, 2020 at 3:13 PM Alexei Starovoitov wrote: > > On Fri, Jul 24, 2020 at 6:38 AM Willem de Bruijn > wrote: > > > > On Fri, Jul 24, 2020 at 2:13 AM Kuniyuki Iwashima > > wrote: > > > > > > From: David Miller > > > Date: Thu, 23 Jul 2020 15:10:51 -0700 (PDT) > > > > From: Kuniyu

Re: [PATCH v2 0/3] net: dsa: mv88e6xxx: port mtu support

2020-07-24 Thread David Miller
From: Chris Packham Date: Fri, 24 Jul 2020 11:21:19 +1200 > This series connects up the mv88e6xxx switches to the dsa infrastructure for > configuring the port MTU. The first patch is also a bug fix which might be a > candiatate for stable. > > I've rebased this series on top of net-next/master

Re: [PATCH net] dev: Defer free of skbs in flush_backlog

2020-07-24 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Thu, 23 Jul 2020 11:31:48 -0600 > IRQs are disabled when freeing skbs in input queue. > Use the IRQ safe variant to free skbs here. > > Fixes: 145dd5f9c88f ("net: flush the softnet backlog in process context") > Signed-off-by: Subash Abhinov Kasiviswana

Re: [PATCH] net: cdc_ncm: USB_NET_CDC_NCM selects USB_NET_CDCETHER

2020-07-24 Thread David Miller
From: t...@redhat.com Date: Thu, 23 Jul 2020 07:22:10 -0700 > From: Tom Rix > > A link error > > ld: drivers/net/usb/cdc_ncm.o: > undefined reference to `usbnet_cdc_update_filter' > > usbnet_cdc_update_filter is defined in cdc_ether.c > Building of cdc_ether.o is controlled by USB_NET_CDCETH

[PATCH bpf-next] udp: reduce merge conflict on udp[46]_lib_lookup2

2020-07-24 Thread Willem de Bruijn
From: Willem de Bruijn Commit efc6b6f6c311 ("udp: Improve load balancing for SO_REUSEPORT.") in net conflicts with Commit 72f7e9440e9b ("udp: Run SK_LOOKUP BPF program on socket lookup") in bpf-next. Commit 4a0e87bb1836 ("udp: Don't discard reuseport selection when group has connections") al

[PATCH net-next 2/2] mlx5: convert to new udp_tunnel infrastructure

2020-07-24 Thread Jakub Kicinski
Allocate nic_info dynamically - n_entries is not constant. Drop the ndo callbacks from the reprs, those should be local to the same netns as the main netdev, no need to get the same callbacks multiple times. Drop the udp_tunnel_drop_rx_info() call, it was not there until commit b3c2ed21c0bd ("net

[PATCH net-next 0/2] udp_tunnel: convert mlx5 to the new udp_tunnel infrastructure

2020-07-24 Thread Jakub Kicinski
This set converts mlx5 to the new infrastructure. We need a small amount of special handling as mlx5 expects IANA VXLAN port to always be programmed into the device. ethtool will show such ports in a separate, type-less, fake table, at the end: Tunnel information for eth0: UDP port table 0:

[PATCH net-next 1/2] udp_tunnel: add the ability to hard-code IANA VXLAN

2020-07-24 Thread Jakub Kicinski
mlx5 has the IANA VXLAN port (4789) hard coded by the device, instead of being added dynamically when tunnels are created. To support this add a workaround flag to struct udp_tunnel_nic_info. Skipping updates for the port is fairly trivial, dumping the hard coded port via ethtool requires some cod

Re: [PATCH net-next 2/4] ionic: recover from ringsize change failure

2020-07-24 Thread David Miller
From: Shannon Nelson Date: Fri, 24 Jul 2020 17:23:24 -0700 > If the ringsize change fails, try restoring the previous setting. > > Signed-off-by: Shannon Nelson You really can't recover properly, or reliably, with the way all of this is structured in the ionic driver. This is at best a half a

UDP data corruption in v4.4

2020-07-24 Thread Dexuan Cui
Hi, The v4.4 stable kernel (currently it's v4.4.231) lacks this bugfix: 327868212381 ("make skb_copy_datagram_msg() et.al. preserve ->msg_iter on error") , as a result, the v4.4 kernel can deliver corrupt data to the application when a corrupt UDP packet is closely followed by a valid UDP packet:

Re: [PATCH net-next v4 1/2] hinic: add support to handle hw abnormal event

2020-07-24 Thread luobin (L)
On 2020/7/25 8:04, David Miller wrote: > From: Luo bin > Date: Fri, 24 Jul 2020 17:17:31 +0800 > >> +static int hinic_fw_reporter_dump(struct devlink_health_reporter *reporter, >> + struct devlink_fmsg *fmsg, void *priv_ctx, >> + struct ne

Re: [PATCH net-next v3 1/2] hinic: add support to handle hw abnormal event

2020-07-24 Thread luobin (L)
On 2020/7/24 17:57, Edward Cree wrote: > On 23/07/2020 20:08, David Miller wrote: >> From: Luo bin >> Date: Thu, 23 Jul 2020 22:40:37 +0800 >> >>> +static int hinic_fw_reporter_dump(struct devlink_health_reporter *reporter, >>> + struct devlink_fmsg *fmsg, void *priv_ct

Re: [PATCH net-next 4/4] ionic: separate interrupt for Tx and Rx

2020-07-24 Thread Jakub Kicinski
On Fri, 24 Jul 2020 17:23:26 -0700 Shannon Nelson wrote: > Add the capability to split the Tx queues onto their own > interrupts with their own napi contexts. This gives the > opportunity for more direct control of Tx interrupt > handling, such as CPU affinity and interrupt coalescing, > useful fo

Re: [PATCH 4/4] crypto: marvell: enable OcteonTX2 cpt options for build

2020-07-24 Thread kernel test robot
Hi Srujana, I love your patch! Yet something to improve: [auto build test ERROR on cryptodev/master] [also build test ERROR on crypto/master sparc-next/master linus/master v5.8-rc6 next-20200724] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [PATCH 1/2] net: ipa: new notification infrastructure

2020-07-24 Thread David Miller
From: Alex Elder Date: Fri, 24 Jul 2020 13:11:41 -0500 > Use the new SSR notifier infrastructure to request notifications of > modem events, rather than the remoteproc IPA notification system. > The latter was put in place temporarily with the knowledge that the > new mechanism would become avail

Re: [Patch net v2] qrtr: orphan socket in qrtr_release()

2020-07-24 Thread David Miller
From: Cong Wang Date: Fri, 24 Jul 2020 09:45:51 -0700 > We have to detach sock from socket in qrtr_release(), > otherwise skb->sk may still reference to this socket > when the skb is released in tun->queue, particularly > sk->sk_wq still points to &sock->wq, which leads to > a UAF. > > Reported-

Re: [RFT iproute2] iplink_bridge: scale all time values by USER_HZ

2020-07-24 Thread David Miller
From: niko...@cumulusnetworks.com Date: Fri, 24 Jul 2020 19:24:35 +0300 > While I agree this should have been done from the start, it's too late to > change. Agreed.

Re: [net-next v2 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-07-24 Thread David Miller
From: Vadym Kochan Date: Fri, 24 Jul 2020 17:19:52 +0300 > +int prestera_dsa_parse(struct prestera_dsa *dsa, const u8 *dsa_buf) > +{ > + u32 *dsa_words = (u32 *)dsa_buf; ... > + words[0] = ntohl((__force __be32)dsa_words[0]); > + words[1] = ntohl((__force __be32)dsa_words[1]); > +

Re: pull-request: wireless-drivers-2020-07-24

2020-07-24 Thread David Miller
From: Kalle Valo Date: Fri, 24 Jul 2020 14:03:02 + (UTC) > here's a pull request to net tree, more info below. Please let me know if > there > are any problems. ... > git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git > tags/wireless-drivers-2020-07-24 Pulled, than

[PATCH net-next 0/4] ionic txrx updates

2020-07-24 Thread Shannon Nelson
These are a few patches to do some cleanup in the packet handling and give us more flexibility in tuning performance by allowing us to put Tx handling on separate interrupts when it makes sense for particular traffic loads. Shannon Nelson (4): ionic: use fewer firmware doorbells on rx fill ion

[PATCH net-next 4/4] ionic: separate interrupt for Tx and Rx

2020-07-24 Thread Shannon Nelson
Add the capability to split the Tx queues onto their own interrupts with their own napi contexts. This gives the opportunity for more direct control of Tx interrupt handling, such as CPU affinity and interrupt coalescing, useful for some traffic loads. To enable, use the ethtool private flag:

[PATCH net-next 3/4] ionic: tx separate servicing

2020-07-24 Thread Shannon Nelson
We give the tx clean path its own budget and service routine in order to give a little more leeway to be more aggressive, and in preparation for coming changes. We've found this gives us a little better performance in some packet processing scenarios without hurting other scenarios. Signed-off-by

[PATCH net-next 2/4] ionic: recover from ringsize change failure

2020-07-24 Thread Shannon Nelson
If the ringsize change fails, try restoring the previous setting. Signed-off-by: Shannon Nelson --- .../ethernet/pensando/ionic/ionic_ethtool.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers

[PATCH net-next 1/4] ionic: use fewer firmware doorbells on rx fill

2020-07-24 Thread Shannon Nelson
We really don't need to hit the Rx queue doorbell so many times, we can wait to the end and cause a little less thrash. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/

Re: [PATCH net-next 0/9] l2tp: avoid multiple assignment, remove BUG_ON

2020-07-24 Thread David Miller
From: Tom Parkin Date: Fri, 24 Jul 2020 16:31:48 +0100 > l2tp hasn't been kept up to date with the static analysis checks offered > by checkpatch.pl. > > This patchset builds on the series: "l2tp: cleanup checkpatch.pl > warnings" and "l2tp: further checkpatch.pl cleanups" to resolve some of > t

Re: [PATCH v2] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

2020-07-24 Thread David Christensen
The driver function tg3_io_error_detected() calls napi_disable twice, without an intervening napi_enable, when the number of EEH errors exceeds eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock. Add check for pcierr_recovery which skips code already executed for the "Froze

Re: [PATCH net-next v2 0/3] icmp6: support rfc 4884

2020-07-24 Thread David Miller
From: Willem de Bruijn Date: Fri, 24 Jul 2020 09:03:07 -0400 > From: Willem de Bruijn > > Extend the feature merged earlier this week for IPv4 to IPv6. > > I expected this to be a single patch, but patch 1 seemed better to be > stand-alone > > patch 1: small fix in length calculation > patch

Re: [PATCH][V2] sctp: remove redundant initialization of variable status

2020-07-24 Thread David Miller
From: Colin King Date: Fri, 24 Jul 2020 14:09:19 +0100 > From: Colin Ian King > > The variable status is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. Also put the variable declarations

[PATCH bpf-next 16/35] bpf: eliminate rlimit-based memory accounting for cgroup storage maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for cgroup storage maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/local_storage.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/kernel/bpf/local_

[PATCH bpf-next 00/35] bpf: switch to memcg-based memory accounting

2020-07-24 Thread Roman Gushchin
Currently bpf is using the memlock rlimit for the memory accounting. This approach has its downsides and over time has created a significant amount of problems: 1) The limit is per-user, but because most bpf operations are performed as root, the limit has a little value. 2) It's hard to come u

[PATCH bpf-next 13/35] bpf: eliminate rlimit-based memory accounting for arraymap maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for arraymap maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/arraymap.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/kernel/bpf/arraymap.c b/

[PATCH bpf-next 01/35] bpf: memcg-based memory accounting for bpf progs

2020-07-24 Thread Roman Gushchin
Include memory used by bpf programs into the memcg-based accounting. This includes the memory used by programs itself, auxiliary data and statistics. Signed-off-by: Roman Gushchin --- kernel/bpf/core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/bpf/core.c

[PATCH bpf-next 07/35] bpf: refine memcg-based memory accounting for hashtab maps

2020-07-24 Thread Roman Gushchin
Include percpu objects and the size of map metadata into the accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/hashtab.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/kernel/bpf/hashtab.c b/kernel/bpf/hashtab.c index 024276787055..9d0432170812 100644 -

[PATCH bpf-next 11/35] bpf: refine memcg-based memory accounting for sockmap maps

2020-07-24 Thread Roman Gushchin
Include sockmap internal metadata into the memcg-based memory accounting. Also include the memory allocated on updating an element. Signed-off-by: Roman Gushchin --- net/core/sock_map.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/core/sock_map.c b/net/core/sock

[PATCH bpf-next 03/35] bpf: refine memcg-based memory accounting for arraymap maps

2020-07-24 Thread Roman Gushchin
Include percpu arrays and auxiliary data into the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/arraymap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c index 8ff419b632a6..9597fecff8da 100644

[PATCH bpf-next 19/35] bpf: eliminate rlimit-based memory accounting for lpm_trie maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for lpm_trie maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/lpm_trie.c | 13 - 1 file changed, 13 deletions(-) diff --git a/kernel/bpf/lpm_trie.c b/kernel/bpf/lpm_trie.c index

[PATCH bpf-next 10/35] bpf: memcg-based memory accounting for socket storage maps

2020-07-24 Thread Roman Gushchin
Account memory used by the socket storage. Signed-off-by: Roman Gushchin --- net/core/bpf_sk_storage.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/net/core/bpf_sk_storage.c b/net/core/bpf_sk_storage.c index eafcd15e7dfd..fbcd03cd00d3 100644 --- a/net/core/bpf

[PATCH bpf-next 20/35] bpf: eliminate rlimit-based memory accounting for queue_stack_maps maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for queue_stack maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/queue_stack_maps.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/kernel/bpf/queue_stac

[PATCH bpf-next 04/35] bpf: refine memcg-based memory accounting for cpumap maps

2020-07-24 Thread Roman Gushchin
Include metadata and percpu data into the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/cpumap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpumap.c index f1c46529929b..74ae9fcbe82e 100644 --- a/kernel/bp

[PATCH bpf-next 18/35] bpf: eliminate rlimit-based memory accounting for hashtab maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for hashtab maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/hashtab.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/kernel/bpf/hashtab.c b/kernel/bp

[PATCH bpf-next 08/35] bpf: memcg-based memory accounting for lpm_trie maps

2020-07-24 Thread Roman Gushchin
Include lpm trie and lpm trie node objects into the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/lpm_trie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/lpm_trie.c b/kernel/bpf/lpm_trie.c index 44474bf3ab7a..d85e0fc2cafc 100644

[PATCH bpf-next 12/35] bpf: refine memcg-based memory accounting for xskmap maps

2020-07-24 Thread Roman Gushchin
Extend xskmap memory accounting to include the memory taken by the xsk_map_node structure. Signed-off-by: Roman Gushchin --- net/xdp/xskmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/xdp/xskmap.c b/net/xdp/xskmap.c index 8367adbbe9df..e574b22defe5 100644 --- a/ne

[PATCH bpf-next 28/35] bpf: eliminate rlimit-based memory accounting for bpf progs

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for bpf progs. It has been replaced with memcg-based memory accounting. Signed-off-by: Roman Gushchin --- include/linux/bpf.h | 11 -- kernel/bpf/core.c| 12 ++- kernel/bpf/syscall.c | 86 ++-- 3 files

[PATCH bpf-next 26/35] bpf: eliminate rlimit-based memory accounting for xskmap maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for xskmap maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- net/xdp/xskmap.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/net/xdp/xskmap.c b/net/xdp/xskmap.c index e574b

[PATCH bpf-next 24/35] bpf: eliminate rlimit-based memory accounting for stackmap maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for stackmap maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/stackmap.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/kernel/bpf/stackmap.c b/kernel/b

[PATCH bpf-next 15/35] bpf: eliminate rlimit-based memory accounting for cpumap maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for cpumap maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/cpumap.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpum

[PATCH bpf-next 06/35] bpf: refine memcg-based memory accounting for devmap maps

2020-07-24 Thread Roman Gushchin
Include map metadata and the node size (struct bpf_dtab_netdev) on element update into the accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/devmap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c index 10abb06065bb..05bf

[PATCH bpf-next 35/35] perf: don't touch RLIMIT_MEMLOCK

2020-07-24 Thread Roman Gushchin
Since bpf stopped using memlock rlimit to limit the memory usage, there is no more reason for perf to alter its own limit. Signed-off-by: Roman Gushchin --- tools/perf/builtin-trace.c | 10 -- tools/perf/tests/builtin-test.c | 6 -- tools/perf/util/Build | 1 - tools

[PATCH bpf-next 14/35] bpf: eliminate rlimit-based memory accounting for bpf_struct_ops maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for bpf_struct_ops maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/bpf_struct_ops.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/kernel/bpf/bpf_st

[PATCH bpf-next 17/35] bpf: eliminate rlimit-based memory accounting for devmap maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for devmap maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/devmap.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/kernel/bpf/devmap.c b/kernel/bpf/d

[PATCH bpf-next 25/35] bpf: eliminate rlimit-based memory accounting for socket storage maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for socket storage maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- net/core/bpf_sk_storage.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/net/core/bpf_sk_storage.c b/net/core/bpf_sk_

[PATCH bpf-next 09/35] bpf: memcg-based memory accounting for bpf ringbuffer

2020-07-24 Thread Roman Gushchin
Enable the memcg-based memory accounting for the memory used by the bpf ringbuffer. Signed-off-by: Roman Gushchin --- kernel/bpf/ringbuf.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/kernel/bpf/ringbuf.c b/kernel/bpf/ringbuf.c index 002f8a5c9e51..e8e2c39cbdc9 100

[PATCH bpf-next 29/35] bpf: libbpf: cleanup RLIMIT_MEMLOCK usage

2020-07-24 Thread Roman Gushchin
As bpf is not using memlock rlimit for memory accounting anymore, let's remove the related code from libbpf. Bpf operations can't fail because of exceeding the limit anymore. Signed-off-by: Roman Gushchin --- tools/lib/bpf/libbpf.c | 31 +-- tools/lib/bpf/libbpf.h |

[PATCH bpf-next 31/35] bpf: runqslower: don't touch RLIMIT_MEMLOCK

2020-07-24 Thread Roman Gushchin
Since bpf is not using memlock rlimit for memory accounting, there are no more reasons to bump the limit. Signed-off-by: Roman Gushchin --- tools/bpf/runqslower/runqslower.c | 16 1 file changed, 16 deletions(-) diff --git a/tools/bpf/runqslower/runqslower.c b/tools/bpf/runqsl

[PATCH bpf-next 23/35] bpf: eliminate rlimit-based memory accounting for sock_map maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for sock_map maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- net/core/sock_map.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/net/core/sock_map.c b/net/cor

[PATCH bpf-next 33/35] bpf: selftests: don't touch RLIMIT_MEMLOCK

2020-07-24 Thread Roman Gushchin
Since bpf is not using memlock rlimit for memory accounting, there are no more reasons to bump the limit. Signed-off-by: Roman Gushchin --- tools/testing/selftests/bpf/bench.c | 16 --- .../selftests/bpf/progs/bpf_iter_bpf_map.c| 5 ++--- tools/testing/selftests/bpf/xd

[PATCH bpf-next 30/35] bpf: bpftool: do not touch RLIMIT_MEMLOCK

2020-07-24 Thread Roman Gushchin
Since bpf stopped using memlock rlimit to limit the memory usage, there is no more reason for bpftool to alter its own limits. Signed-off-by: Roman Gushchin --- tools/bpf/bpftool/common.c | 7 --- tools/bpf/bpftool/feature.c| 2 -- tools/bpf/bpftool/main.h | 2 -- tools/bpf/bpf

[PATCH bpf-next 21/35] bpf: eliminate rlimit-based memory accounting for reuseport_array maps

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for reuseport_array maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/reuseport_array.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/kernel/bpf/reuseport_a

[PATCH bpf-next 32/35] bpf: selftests: delete bpf_rlimit.h

2020-07-24 Thread Roman Gushchin
As rlimit-based memory accounting is not used by bpf anymore, there are no more reasons to play with memlock rlimit. Delete bpf_rlimit.h which contained a code to bump the limit. Signed-off-by: Roman Gushchin --- samples/bpf/hbm.c | 1 - tools/testing/selftests/bpf/

[PATCH bpf-next 22/35] bpf: eliminate rlimit-based memory accounting for bpf ringbuffer

2020-07-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for bpf ringbuffer. It has been replaced with the memcg-based memory accounting. bpf_ringbuf_alloc() can't return anything except ERR_PTR(-ENOMEM) and a valid pointer, so to simplify the code make it return NULL in the first case. This allows to drop a cou

[PATCH bpf-next 05/35] bpf: memcg-based memory accounting for cgroup storage maps

2020-07-24 Thread Roman Gushchin
Account memory used by cgroup storage maps including the percpu memory for the percpu flavor of cgroup storage and map metadata. Signed-off-by: Roman Gushchin --- kernel/bpf/local_storage.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/kernel/bpf/local_sto

[PATCH bpf-next 34/35] bpf: samples: do not touch RLIMIT_MEMLOCK

2020-07-24 Thread Roman Gushchin
Since bpf is not using rlimit memlock for the memory accounting and control, do not change the limit in sample applications. Signed-off-by: Roman Gushchin --- samples/bpf/map_perf_test_user.c| 11 --- samples/bpf/offwaketime_user.c | 2 -- samples/bpf/sockex2_user.c |

[PATCH bpf-next 27/35] bpf: eliminate rlimit-based memory accounting infra for bpf maps

2020-07-24 Thread Roman Gushchin
Remove rlimit-based accounting infrastructure code, which is not used anymore. Signed-off-by: Roman Gushchin --- include/linux/bpf.h | 12 kernel/bpf/syscall.c | 64 +-- .../selftests/bpf/progs/map_ptr_kern.c| 5 --

[PATCH bpf-next 02/35] bpf: memcg-based memory accounting for bpf maps

2020-07-24 Thread Roman Gushchin
This patch enables memcg-based memory accounting for memory allocated by __bpf_map_area_alloc(), which is used by most map types for large allocations. Following patches in the series will refine the accounting for some map types. Signed-off-by: Roman Gushchin --- kernel/bpf/syscall.c | 2 +- 1

Re: [PATCH net-next v4 1/2] hinic: add support to handle hw abnormal event

2020-07-24 Thread David Miller
From: Luo bin Date: Fri, 24 Jul 2020 17:17:31 +0800 > +static int hinic_fw_reporter_dump(struct devlink_health_reporter *reporter, > + struct devlink_fmsg *fmsg, void *priv_ctx, > + struct netlink_ext_ack *extack) > +{ > + int err; >

RE: [Intel-wired-lan] [PATCH] ixgbe: use eth_zero_addr() to clear mac address

2020-07-24 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan On Behalf Of > linmiaohe > Sent: Monday, July 20, 2020 1:28 AM > To: Kirsher, Jeffrey T ; da...@davemloft.net; > k...@kernel.org > Cc: linmia...@huawei.com; netdev@vger.kernel.org; intel-wired- > l...@lists.osuosl.org; linux-ker...@vger.kernel.o

Re: [PATCH v2] xen-netfront: fix potential deadlock in xennet_remove()

2020-07-24 Thread David Miller
From: Andrea Righi Date: Fri, 24 Jul 2020 10:59:10 +0200 > There's a potential race in xennet_remove(); this is what the driver is > doing upon unregistering a network device: > > 1. state = read bus state > 2. if state is not "Closed": > 3.request to set state to "Closing" > 4.w

Re: [PATCH net V2] Crypto/chcr: Registering cxgb4 to xfrmdev_ops

2020-07-24 Thread David Miller
Please start submitting chcr patches to the crypto subsystem, where it belongs, instead of the networking GIT trees. This has been going on for far too long. Thank you.

Re: [PATCH net-next] net: openvswitch: fixes potential deadlock in dp cleanup code

2020-07-24 Thread David Miller
From: Eelco Chaudron Date: Fri, 24 Jul 2020 10:20:59 +0200 > The previous patch introduced a deadlock, this patch fixes it by making > sure the work is canceled without holding the global ovs lock. This is > done by moving the reorder processing one layer up to the netns level. > > Fixes: eac87c

Re: [PATCH] octeontx2-af: Fix use of uninitialized pointer bmap

2020-07-24 Thread David Miller
From: Dinghao Liu Date: Fri, 24 Jul 2020 16:06:57 +0800 > If req->ctype does not match any of NIX_AQ_CTYPE_CQ, > NIX_AQ_CTYPE_SQ or NIX_AQ_CTYPE_RQ, pointer bmap will remain > uninitialized and be accessed in test_bit(), which can lead > to kernal crash. This can never happen. > Fix this by ret

Re: [PATCH v2 net-next] sctp: fix slab-out-of-bounds in SCTP_DELAYED_SACK processing

2020-07-24 Thread David Miller
From: Christoph Hellwig Date: Fri, 24 Jul 2020 08:48:55 +0200 > This sockopt accepts two kinds of parameters, using struct > sctp_sack_info and struct sctp_assoc_value. The mentioned commit didn't > notice an implicit cast from the smaller (latter) struct to the bigger > one (former) when copying

Re: [PATCH net] udp: Remove an unnecessary variable in udp[46]_lib_lookup2().

2020-07-24 Thread David Miller
From: Kuniyuki Iwashima Date: Fri, 24 Jul 2020 15:13:04 +0900 > Yes. I think this kind of patch should be submitted to net-next, but > this is for the net tree. Please let me add more description. This does not fix a bug, therefore 'net' is not appropriate. The merge conflicts should be handled

Re: [PATCH v2 0/8] Hirschmann Hellcreek DSA driver

2020-07-24 Thread David Miller
From: Kurt Kanzenbach Date: Fri, 24 Jul 2020 08:04:10 +0200 > On Thu Jul 23 2020, Jakub Kicinski wrote: >> Appears not to build: >> > > Yeah, i know. This patch series depends on two other ones: > > * https://lkml.kernel.org/netdev/20200723074946.14253-1-k...@linutronix.de/ > * https://lkml.k

Re: 答复: [PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-24 Thread David Miller
From: "Guodeqing (A)" Date: Fri, 24 Jul 2020 03:35:02 + > The ihl check maybe not suitable in ip_fast_csum, the correct of the > ihl value can be checked before calling the ip_fast_csum. ip_fast_csum() must be able to handle any value that could fit in the ihl field of the ip protocol header

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-07-23

2020-07-24 Thread David Miller
From: Tony Nguyen Date: Thu, 23 Jul 2020 16:47:05 -0700 > This series contains updates to ice driver only. ... > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue 100GbE Pulled, thank you.

Re: [Linux-kernel-mentees] [PATCH net] AX.25: Prevent out-of-bounds read in ax25_sendmsg()

2020-07-24 Thread David Ranch
I need to ask the following question to the Linux kernel community as the AX25 amateur radio community is already having to work around a few broken commits that were committed 4.1.22+: Is anyone actually _*testing*_ these proposed changes to make sure the AX.25 and related ecosystem still

Re: [PATCH net] bareudp: forbid mixing IP and MPLS in multiproto mode

2020-07-24 Thread Jakub Kicinski
On Fri, 24 Jul 2020 23:03:26 +0200 Guillaume Nault wrote: > In multiproto mode, bareudp_xmit() accepts sending multicast MPLS and > IPv6 packets regardless of the bareudp ethertype. In practice, this > let an IP tunnel send multicast MPLS packets, or an MPLS tunnel send > IPv6 packets. > > We need

Re: [RFT iproute2] iplink_bridge: scale all time values by USER_HZ

2020-07-24 Thread Vladimir Oltean
On Sat, Jul 25, 2020 at 01:51:02AM +0300, Nikolay Aleksandrov wrote: > On 24/07/2020 22:05, Stephen Hemminger wrote: > > On Fri, 24 Jul 2020 19:24:35 +0300 > > niko...@cumulusnetworks.com wrote: > > > >> On 24 July 2020 19:15:17 EEST, Stephen Hemminger > >> wrote: > >>> > >>> The bridge portion

[PATCH net] mlx4: disable device on shutdown

2020-07-24 Thread Jakub Kicinski
It appears that not disabling a PCI device on .shutdown may lead to a Hardware Error with particular (perhaps buggy) BIOS versions: mlx4_en: eth0: Close port called mlx4_en :04:00.0: removed PHC reboot: Restarting system {1}[Hardware Error]: Hardware error from APEI Generic Har

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

2020-07-24 Thread Jacob Keller
On 7/23/2020 11:25 AM, Rakesh Pillai wrote: > Hi Rajkumar, > In linux, the IRQs are directed to the first core which is booted. > I see that all the IRQs are getting routed to CORE0 even if its heavily > loaded. > You should be able to configure the initial IRQ setup so that they don't all go

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-07-24 Thread Stefano Stabellini
On Thu, 23 Jul 2020, Anchal Agarwal wrote: > On Wed, Jul 22, 2020 at 04:49:16PM -0700, Stefano Stabellini wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the content is safe. > >

Re: [RFT iproute2] iplink_bridge: scale all time values by USER_HZ

2020-07-24 Thread Nikolay Aleksandrov
On 24/07/2020 22:05, Stephen Hemminger wrote: > On Fri, 24 Jul 2020 19:24:35 +0300 > niko...@cumulusnetworks.com wrote: > >> On 24 July 2020 19:15:17 EEST, Stephen Hemminger >> wrote: >>> >>> The bridge portion of ip command was not scaling so the >>> values were off. >>> >>> The netlink API's f

Re: [PATCH v4 net-next 04/16] sfc: skeleton EF100 PF driver

2020-07-24 Thread kernel test robot
Hi Edward, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Edward-Cree/sfc-driver-for-EF100-family-NICs-part-1/20200725-000401 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1b6

Re: get rid of the address_space override in setsockopt v2

2020-07-24 Thread David Miller
From: Christoph Hellwig Date: Thu, 23 Jul 2020 08:08:42 +0200 > setsockopt is the last place in architecture-independ code that still > uses set_fs to force the uaccess routines to operate on kernel pointers. > > This series adds a new sockptr_t type that can contained either a kernel > or user

Re: [PATCH RFC leds + net-next v2 0/1] Add support for LEDs on Marvell PHYs

2020-07-24 Thread Pavel Machek
On Fri 2020-07-24 15:12:33, Marek Behún wrote: > On Fri, 24 Jul 2020 12:29:01 +0200 > Pavel Machek wrote: > > > In future, would you expect having software "1000/100/10/nolink" > > triggers I could activate on my scrollock LED (or on GPIO controlled > > LEDs) to indicate network activity? > > Lo

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-24 Thread Florian Fainelli
On 7/23/20 11:20 PM, Rakesh Pillai wrote: > > >> -Original Message- >> From: Florian Fainelli >> Sent: Friday, July 24, 2020 12:33 AM >> To: Rakesh Pillai ; 'Andrew Lunn' >> >> Cc: ath...@lists.infradead.org; linux-wirel...@vger.kernel.org; linux- >> ker...@vger.kernel.org; kv...@codeau

  1   2   3   >