Re: [PATCH net-next v4 1/2] hinic: add support to handle hw abnormal event

[David Miller]

From: Luo bin <luob...@huawei.com>
Date: Fri, 24 Jul 2020 17:17:31 +0800

> +static int hinic_fw_reporter_dump(struct devlink_health_reporter *reporter,
> +                               struct devlink_fmsg *fmsg, void *priv_ctx,
> +                               struct netlink_ext_ack *extack)
> +{
> +     int err;
> +
> +     if (priv_ctx) {
> +             err = mgmt_watchdog_report_show(fmsg, priv_ctx);
> +             if (err)
> +                     return err;
> +     }
> +
> +     return 0;
> +}

As Edward Cree pointed out for v3 of this patch series, this 'err' is not
necessary at all.