On Fri, Jul 24, 2020 at 10:18:07AM +0530, Madhuparna Bhowmik wrote:
> On Thu, Jul 23, 2020 at 03:11:58PM -0700, David Miller wrote:
> > From: madhuparnabhowmi...@gmail.com
> > Date: Wed, 22 Jul 2020 22:53:29 +0530
> >
> > > From: Madhuparna Bhowmik
> > >
> > > In capi_init(), after register_chrd
Hi Bryan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Bryan-Whitehead/mscc-Add-LCPLL-Reset-to-VSC8574-Family-of-phy-drivers/20200724-043103
base: https://git.kernel.org/pub/scm/linux/kernel/git/
This sockopt accepts two kinds of parameters, using struct
sctp_sack_info and struct sctp_assoc_value. The mentioned commit didn't
notice an implicit cast from the smaller (latter) struct to the bigger
one (former) when copying the data from the user space, which now leads
to an attempt to write be
On Thu, Jul 23, 2020 at 12:30:25PM -0300, Marcelo Ricardo Leitner wrote:
> On Thu, Jul 23, 2020 at 11:22:38AM +0200, Christoph Hellwig wrote:
> > On Wed, Jul 22, 2020 at 05:42:31PM -0300, Marcelo Ricardo Leitner wrote:
> > > Cc'ing linux-s...@vger.kernel.org.
> >
> > What do you think of this vers
On Thu, Jul 23, 2020 at 02:57:22PM -0700, David Miller wrote:
> From: Andrea Righi
> Date: Wed, 22 Jul 2020 08:52:11 +0200
>
> > +static int xennet_remove(struct xenbus_device *dev)
> > +{
> > + struct netfront_info *info = dev_get_drvdata(&dev->dev);
> > +
> > + dev_dbg(&dev->dev, "%s\n", de
On Thu Jul 23 2020, Richard Cochran wrote:
> Kurt,
>
> On Thu, Jul 23, 2020 at 09:49:44AM +0200, Kurt Kanzenbach wrote:
>> in order to reduce code duplication in the ptp code of DSA drivers, move the
>> header parsing function to ptp_classify. This way the Marvell and the
>> hellcreek
>> drivers c
> -Original Message-
> From: Johannes Berg
> Sent: Friday, July 24, 2020 1:37 AM
> To: Rakesh Pillai ; ath...@lists.infradead.org
> Cc: linux-wirel...@vger.kernel.org; linux-ker...@vger.kernel.org;
> kv...@codeaurora.org; da...@davemloft.net; k...@kernel.org;
> netdev@vger.kernel.org; d
> -Original Message-
> From: Florian Fainelli
> Sent: Friday, July 24, 2020 12:33 AM
> To: Rakesh Pillai ; 'Andrew Lunn'
>
> Cc: ath...@lists.infradead.org; linux-wirel...@vger.kernel.org; linux-
> ker...@vger.kernel.org; kv...@codeaurora.org; johan...@sipsolutions.net;
> da...@davemlo
> -Original Message-
> From: Sebastian Gottschall
> Sent: Friday, July 24, 2020 4:36 AM
> To: Rakesh Pillai ; ath...@lists.infradead.org
> Cc: linux-wirel...@vger.kernel.org; linux-ker...@vger.kernel.org;
> kv...@codeaurora.org; johan...@sipsolutions.net; da...@davemloft.net;
> k...@ker
From: David Miller
Date: Thu, 23 Jul 2020 15:10:51 -0700 (PDT)
> From: Kuniyuki Iwashima
> Date: Thu, 23 Jul 2020 01:52:27 +0900
>
> > This patch removes an unnecessary variable in udp[46]_lib_lookup2() and
> > makes it easier to resolve a merge conflict with bpf-next reported in
> > the lin
On 7/23/20 11:00 PM, Cong Wang wrote:
> On Thu, Jul 23, 2020 at 10:35 PM Eric Dumazet wrote:
>>
>>
>>
>> On 7/23/20 9:50 PM, Cong Wang wrote:
>>> Similar to tun_net_xmit(), we have to orphan the skb
>>> before queuing it, otherwise we may use the socket when
>>> purging the queue after it is fr
On Thu Jul 23 2020, Richard Cochran wrote:
> On Thu, Jul 23, 2020 at 09:49:46AM +0200, Kurt Kanzenbach wrote:
>> @@ -26,6 +26,7 @@ config NET_DSA_MV88E6XXX_PTP
>> depends on NET_DSA_MV88E6XXX_GLOBAL2
>> depends on PTP_1588_CLOCK
>> imply NETWORK_PHY_TIMESTAMPING
>> +select NET_PT
On Thu Jul 23 2020, Jakub Kicinski wrote:
> Appears not to build:
>
Yeah, i know. This patch series depends on two other ones:
* https://lkml.kernel.org/netdev/20200723074946.14253-1-k...@linutronix.de/
* https://lkml.kernel.org/netdev/20200720124939.4359-1-k...@linutronix.de/
One of them has
On Thu, Jul 23, 2020 at 11:00 PM Cong Wang wrote:
>
> I said socket, not sock. I believe the socket can be gone while the sock is
> still there.
Hmm, looks llike sock_orphan() should be called...
On Thu, Jul 23, 2020 at 10:35 PM Eric Dumazet wrote:
>
>
>
> On 7/23/20 9:50 PM, Cong Wang wrote:
> > Similar to tun_net_xmit(), we have to orphan the skb
> > before queuing it, otherwise we may use the socket when
> > purging the queue after it is freed by user-space.
>
> Which socket ?
sk->sk_w
From: Alexei Starovoitov
Refactor the code a bit to extract bpf_link_get_by_id() helper.
It's similar to existing bpf_prog_by_id().
Signed-off-by: Alexei Starovoitov
Acked-by: Andrii Nakryiko
---
include/linux/bpf.h | 1 +
kernel/bpf/syscall.c | 46 +++---
From: Alexei Starovoitov
The program and map iterators work similar to seq_file-s.
Once the program is pinned in bpffs it can be read with "cat" tool
to print human readable output. In this case about BPF programs and maps.
For example:
$ cat /sys/fs/bpf/progs.debug
id namepages att
From: Alexei Starovoitov
Add kernel module with user mode driver that populates bpffs with
BPF iterators.
$ mount bpffs /my/bpffs/ -t bpf
$ ls -la /my/bpffs/
total 4
drwxrwxrwt 2 root root0 Jul 2 00:27 .
drwxr-xr-x 19 root root 4096 Jul 2 00:09 ..
-rw--- 1 root root0 Jul 2 00:27
From: Alexei Starovoitov
v2->v3:
- fixed module unload race (Daniel)
- added selftest (Daniel)
- fixed build bot warning
v1->v2:
- changed names to 'progs.debug' and 'maps.debug' to hopefully better indicate
instability of the text output. Having dot in the name also guarantees
that these sp
From: Alexei Starovoitov
Add a test that mounts two bpffs instances and checks progs.debug
and maps.debug for sanity data.
Signed-off-by: Alexei Starovoitov
---
.../selftests/bpf/prog_tests/test_bpffs.c | 94 +++
1 file changed, 94 insertions(+)
create mode 100644 tools/te
Hello,
syzbot found the following issue on:
HEAD commit:e6827d1a cxgb4: add missing release on skb in uld_send()
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=17a227b490
kernel config: https://syzkaller.appspot.com/x/.config?x=dddbcb5a9f4192db
dashboard li
On 7/23/20 9:50 PM, Cong Wang wrote:
> Similar to tun_net_xmit(), we have to orphan the skb
> before queuing it, otherwise we may use the socket when
> purging the queue after it is freed by user-space.
Which socket ?
By not calling skb_orphan(skb), this skb should own a reference on skb->sk
On Thu, Jul 23, 2020 at 11:06:48AM -0700, Song Liu wrote:
> + pmu_fd = syscall(__NR_perf_event_open, &attr, -1 /* pid */,
> + 0 /* cpu 0 */, -1 /* group id */,
> + 0 /* flags */);
> + if (pmu_fd < 0 && errno == ENOENT) {
> + printf("%s:S
On Fri, Jul 17, 2020 at 10:35:32AM +0200, Steffen Klassert wrote:
> We forgot to support the xfrm policy hold queue when
> VTI was implemented. This patch adds everything we
> need so that we can use the policy hold queue together
> with VTI interfaces.
>
> Signed-off-by: Steffen Klassert
This i
On Fri, Jul 17, 2020 at 10:34:27AM +0200, Steffen Klassert wrote:
> The commits "xfrm: Move dst->path into struct xfrm_dst"
> and "net: Create and use new helper xfrm_dst_child()."
> changed xfrm bundle handling under the assumption
> that xdst->path and dst->child are not a NULL pointer
> only if
On Wed, Jul 22, 2020 at 04:00:53AM -0700, Mark Salyzyn wrote:
> In pfkey_dump() dplen and splen can both be specified to access the
> xfrm_address_t structure out of bounds in__xfrm_state_filter_match()
> when it calls addr_match() with the indexes. Return EINVAL if either
> are out of range.
>
>
On Thu, 2020-07-23 at 17:32 +0100, Colin King wrote:
> From: Colin Ian King
>
> The variables ant_num and single_ant_path are being initialized with a
> value that is never read and are being updated later with a new value.
> The initializations are redundant and can be removed.
>
> Addresses-Co
Please do not top-post on netdev / lkml (
https://www.mediawiki.org/wiki/Mailing_list_etiquette )
On 7/23/20 8:35 PM, Guodeqing (A) wrote:
> The ihl check maybe not suitable in ip_fast_csum, the correct of the ihl
> value can be checked before calling the ip_fast_csum.
>
> The implementation
On Thu, Jul 23, 2020 at 11:41:08AM -0700, Yonghong Song wrote:
> Bpf iterator has been implemented for task, task_file,
> bpf_map, ipv6_route, netlink, tcp and udp so far.
>
> For map elements, there are two ways to traverse all elements from
> user space:
> 1. using BPF_MAP_GET_NEXT_KEY bpf sub
Similar to tun_net_xmit(), we have to orphan the skb
before queuing it, otherwise we may use the socket when
purging the queue after it is freed by user-space.
Reported-and-tested-by: syzbot+6720d64f31c081c2f...@syzkaller.appspotmail.com
Fixes: 28fb4e59a47d ("net: qrtr: Expose tunneling endpoint t
On Thu, Jul 23, 2020 at 03:11:58PM -0700, David Miller wrote:
> From: madhuparnabhowmi...@gmail.com
> Date: Wed, 22 Jul 2020 22:53:29 +0530
>
> > From: Madhuparna Bhowmik
> >
> > In capi_init(), after register_chrdev() the file operation callbacks
> > can be called. However capinc_tty_init() is
Hi Willem,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Willem-de-Bruijn/icmp6-support-rfc-4884/20200723-223533
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
Signed-off-by: kernel test robot
---
datagram.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/datagram.c b/net/ipv6/datagram.c
index dd1d71e12b61a5..cc8ad7ddecdaa3 100644
--- a/net/ipv6/datagram.c
+++ b/net/ipv6/datagram.c
@@ -285,8 +285,8 @@ int ip6_datagr
An imbalanced TX indirection table causes netvsc to have low
performance. This table is created and managed during runtime. To help
better diagnose performance issues caused by imbalanced tables, it needs
make TX indirection tables visible.
Because TX indirection table is driver specified informat
The ihl check maybe not suitable in ip_fast_csum, the correct of the ihl value
can be checked before calling the ip_fast_csum.
The implementation of ip_fast_csum is different in different cpu architecture.
the IP packet will do ip forward in the ipvlan l3/l3s mode and the corrupted ip
packet
s
syzbot has bisected this issue to:
commit 5a781ccbd19e4664babcbe4b4ead7aa2b9283d22
Author: Vinicius Costa Gomes
Date: Sat Sep 29 00:59:43 2018 +
tc: Add support for configuring the taprio scheduler
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16d46e1b10
start commi
Hi David,
On Fri, Jul 24, 2020 at 12:43 AM David Miller wrote:
>
> From: sundeep subbaraya
> Date: Thu, 23 Jul 2020 20:29:03 +0530
>
> > Hi David,
> >
> > On Wed, Jul 22, 2020 at 7:34 PM sundeep subbaraya
> > wrote:
> >>
> >> Hi David,
> >>
> >> On Wed, Jul 22, 2020 at 4:47 AM David Miller wro
On Thu, 2020-07-23 at 23:44 +0200, Thomas Gleixner wrote:
> External Email
>
> ---
> ---
> Alex Belits writes:
> > On Thu, 2020-07-23 at 17:49 +0200, Peter Zijlstra wrote:
> > > 'What does noinstr mean? and why do we have it" -- don
On Thu, Jul 23, 2020 at 8:58 PM Eelco Chaudron wrote:
>
> Add a counter that counts the number of masks cache hits, and
> export it through the megaflow netlink statistics.
>
> Reviewed-by: Paolo Abeni
> Signed-off-by: Eelco Chaudron
LGTM
Reviewed-by: Tonghao Zhang
> ---
> include/uapi/linux/
Hi Kurt,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on next-20200723]
[cannot apply to robh/for-next sparc-next/master net/master linus/master
v5.8-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
drivers/net/geneve.c
between commit:
32818c075c54 ("geneve: fix an uninitialized value in geneve_changelink()")
from the net tree and commit:
9e06e8596bc8 ("geneve: move all configuration under struct geneve_config
Hi Willem,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Willem-de-Bruijn/icmp6-support-rfc-4884/20200723-223533
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
drivers/net/ethernet/freescale/enetc/enetc_pf.c
between commit:
26cb7085c898 ("enetc: Remove the mdio bus on PF probe bailout")
from the net tree and commits:
07095c025ac2 ("net: enetc: Use DT protocol information
Hi Ayush,
I love your patch! Yet something to improve:
[auto build test ERROR on net/master]
url:
https://github.com/0day-ci/linux/commits/Ayush-Sawal/Crypto-chcr-Registering-cxgb4-to-xfrmdev_ops/20200724-002940
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
e6827d1ab
On 23.07.2020 21:59, Florian Fainelli wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On 7/21/20 10:13 AM, Codrin Ciubotariu wrote:
>> The MACB embeds an MDIO bus controller. For this reason, the PHY nodes
>> were represented as sub-nodes
This patch restores the RCU marking on bucket_table->buckets as
it really does need RCU protection. Its removal had led to a fatal
bug.
Signed-off-by: Herbert Xu
diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h
index e3def7bbe932..9a8d4b9dde50 100644
--- a/include/linux/rhas
Add test validating that all inner maps are released properly after skeleton
is destroyed. To ensure determinism, trigger kernel-size synchronize_rcu()
before checking map existence by their IDs.
Signed-off-by: Andrii Nakryiko
---
.../selftests/bpf/prog_tests/btf_map_in_map.c | 104 +
Fix HASH_OF_MAPS bug of not putting inner map pointer on bpf_map_elem_update()
operation. This is due to per-cpu extra_elems optimization, which bypassed
free_htab_elem() logic doing proper clean ups. Make sure that inner map is put
properly in optimized case as well.
Fixes: 8c290e60fa2a ("bpf: fi
The rcu_dereference call in rht_ptr_rcu is completely bogus because
we've already dereferenced the value in __rht_ptr and operated on it.
This causes potential double readings which could be fatal. The RCU
dereference must occur prior to the comparison in __rht_ptr.
This patch changes the order
This patch series fixes an unprotected dereference in __rht_ptr.
The first patch is a minimal fix that does not use the correct
RCU markings but is suitable for backport, and the second patch
cleans up the RCU markings.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
On 2020/7/24 3:08, David Miller wrote:
> From: Luo bin
> Date: Thu, 23 Jul 2020 22:40:37 +0800
>
>> +static int hinic_fw_reporter_dump(struct devlink_health_reporter *reporter,
>> + struct devlink_fmsg *fmsg, void *priv_ctx,
>> + struct ne
On Thu, Jul 23, 2020 at 05:34:15PM -0700, Eric Dumazet wrote:
>
> Sure, but __rht_ptr() is used with different RCU checks,
> I guess a that adding these lockdep conditions will make
> a patch more invasive.
Yes it is large but the only substantial change is to __rht_ptr
and its callers. Everythin
From: David Ahern
Date: Thu, 23 Jul 2020 17:23:09 -0600
> Randy reported compile failure when CONFIG_SYSCTL is not set/enabled:
>
> ERROR: modpost: "sysctl_vals" [drivers/net/vrf.ko] undefined!
>
> Fix by splitting out the sysctl init and cleanup into helpers that
> can be set to do nothing whe
I noticed that touching linux/rhashtable.h causes lib/vsprintf.c to
be rebuilt. This dependency came through a bogus inclusion in the
file net/flow_offload.h. This patch moves it to the right place.
This patch also removes a lingering rhashtable inclusion in cls_api
created by the same commit.
syzbot has found a reproducer for the following issue on:
HEAD commit:4f5baedd Add linux-next specific files for 20200723
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=12e497b490
kernel config: https://syzkaller.appspot.com/x/.config?x
On Thu, Jul 23, 2020 at 03:58:24PM -0700, Florian Fainelli wrote:
> On 7/23/20 3:11 PM, Vladimir Oltean wrote:
> > On Wed, Jul 22, 2020 at 03:52:53PM -0700, Florian Fainelli wrote:
> >> This patch provides details on the expected behavior of switchdev
> >> enabled network devices when operating in
On 7/23/20 5:09 PM, Herbert Xu wrote:
> On Thu, Jul 23, 2020 at 03:32:05PM -0700, Eric Dumazet wrote:
>>
>> Thanks for the report/analysis.
>
> Thanks indeed.
>
>> READ_ONCE() should help here, can you test/submit an official patch ?
>
> This is basically a hand-rolled RCU access. So we sho
The LCPLL Reset sequence is added to the initialization path
of the VSC8574 Family of phy drivers.
The LCPLL Reset sequence is known to reduce hardware inter-op
issues when using the QSGMII MAC interface.
This patch is submitted to net-next to avoid merging conflicts that
may arise if submitted t
Use the newly added pldmfw library to implement device flash update for
the Intel ice networking device driver. This support uses the devlink
flash update interface.
The main parts of the flash include the Option ROM, the netlist module,
and the main NVM data. The PLDM firmware file contains modul
On 7/23/20 4:23 PM, David Ahern wrote:
> Randy reported compile failure when CONFIG_SYSCTL is not set/enabled:
>
> ERROR: modpost: "sysctl_vals" [drivers/net/vrf.ko] undefined!
>
> Fix by splitting out the sysctl init and cleanup into helpers that
> can be set to do nothing when CONFIG_SYSCTL is
The pldmfw library is used to implement common logic needed to flash
devices based on firmware files using the format described by the PLDM
for Firmware Update standard.
This library consists of logic to parse the PLDM file format from
a firmware file object, as well as common logic for sending th
After a flash update, the pending status of the update can be determined
from the device capabilities.
Read the appropriate device capability and store whether there is
a pending update awaiting a reboot.
Signed-off-by: Jacob Keller
---
drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 6 +
From: Pablo Neira Ayuso
Date: Fri, 24 Jul 2020 00:35:06 +0200
> The following patchset contains Netfilter/IPVS fixes for net:
>
> 1) Fix NAT hook deletion when table is dormant, from Florian Westphal.
>
> 2) Fix IPVS sync stalls, from guodeqing.
>
> Please, pull these changes from:
>
> git:
From: Jacek Naczyk
Extends function parsing response from Discover Device
Capability AQC to check if the device supports unified NVM update flow.
Signed-off-by: Jacek Naczyk
---
drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 1 +
drivers/net/ethernet/intel/ice/ice_common.c | 7 +++
From: "Cudzilo, Szymon T"
Add structures, identifiers, and helper functions for several AdminQ
commands related to performing a firmware update for the ice hardware.
These will be used in future code for implementing the devlink
.flash_update handler.
Signed-off-by: Cudzilo, Szymon T
Signed-off
This series goal is to enable support for updating the ice hardware flash
using the devlink flash command.
The ice firmware update files are distributed using the file format
described by the "PLDM for Firmware Update" standard:
https://www.dmtf.org/documents/pmci/pldm-firmware-update-specificati
On Thu, Jul 23, 2020 at 03:32:05PM -0700, Eric Dumazet wrote:
>
> Thanks for the report/analysis.
Thanks indeed.
> READ_ONCE() should help here, can you test/submit an official patch ?
This is basically a hand-rolled RCU access. So we should instead
use proper RCU operators if possible. Let m
Ack, thanks!
Paul
> -Original Message-
> From: Nguyen, Anthony L
> Sent: Thursday, July 23, 2020 4:47 PM
> To: da...@davemloft.net
> Cc: Stillwell Jr, Paul M ;
> netdev@vger.kernel.org;
> nhor...@redhat.com; sassm...@redhat.com; Kirsher, Jeffrey T
> ; Nguyen, Anthony L
> ; Bowers, Andre
From: Akeem G Abodunrin
Add callbacks needed to support advanced power management for Wake on LAN.
Also make ice_pf_state_is_nominal function available for all configurations
not just CONFIG_PCI_IOV.
Signed-off-by: Akeem G Abodunrin
Signed-off-by: Jesse Brandeburg
Tested-by: Andrew Bowers
Sig
From: Paul M Stillwell Jr
There isn't a case for 1G SGMII in ice_get_media_type() so add
the handling for it.
Also handle the special case where some direct attach
cables may report that they support 1G SGMII, but
that is erroneous since SGMII is supposed to be a
backplane media type (between a
From: Lev Faerman
Rename the low_power_ctrl field to low_power_ctrl_an to be properly
descriptive of it being an autoneg field.
Signed-off-by: Lev Faerman
Tested-by: Andrew Bowers
Signed-off-by: Tony Nguyen
---
.../net/ethernet/intel/ice/ice_adminq_cmd.h| 4 ++--
drivers/net/ethernet/in
From: Paul Greenwalt
Add debug logs for ice_aq_get_phy_caps(), and format
ice_aq_set_phy_cfg() and ice_aq_get_link_info() debug logs to make them
more readable.
Signed-off-by: Paul Greenwalt
Signed-off-by: Paul M Stillwell Jr
Tested-by: Andrew Bowers
Signed-off-by: Tony Nguyen
---
drivers/n
From: Jacob Keller
Using the new ice_aq_list_caps and ice_parse_(dev|func)_caps functions,
replace ice_discover_caps with two functions that each take a pointer to
the dev_caps and func_caps structures respectively.
This makes the side effect of updating the hw->dev_caps and
hw->func_caps obviou
This series contains updates to ice driver only.
Jake refactors ice_discover_caps() to reduce the number of AdminQ calls
made. Splits ice_parse_caps() to separate functions to update function
and device capabilities separately to allow for updating outside of
initialization.
Akeem adds power mana
From: Paul Greenwalt
Create a helper function for configuring requested flow control so that it
can be utilized by other functions looking to configure flow control
settings. Utilize the existing helper ice_copy_phy_caps_to_cfg() to copy a
PHY capability to configuration instead duplicating the c
From: Paul Greenwalt
After the transition from no media to media FW will clear the
set-phy-cfg data set by the user. Save initial PHY settings and any
settings later requested by the user and use that data to restore PHY
settings on media insertion. Since PHY configuration is now being stored,
re
From: Jacob Keller
The ice_discover_caps function is used to read the device and function
capabilities, updating the hardware capabilities structures with
relevant data.
The exact number of capabilities returned by the hardware is unknown
ahead of time. The AdminQ command will report the total n
From: Bruce Allan
When the Port Disable bit is set in the Link Default Override Mask TLV PFA
module in the NVM, Total Port Shutdown mode is supported and enabled. In
this mode, the driver should act as if the link-down-on-close ethtool
private flag is always enabled and dis-allow any change to t
From: Paul Greenwalt
Firmware now reports AN28, AN32, and AN73. Add a helper and check these new
values and report PHY autoneg capability.
Signed-off-by: Paul Greenwalt
Tested-by: Andrew Bowers
Signed-off-by: Tony Nguyen
---
drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 3 +++
drivers/n
From: Paul Greenwalt
The call to ice_cfg_phy_fec() requires the caller to perform certain
actions before calling it. Instead of imposing these preconditions move
the operations into the function and perform them ourselves.
Also, fix some style issues in nearby touched code.
Signed-off-by: Paul
From: Paul Greenwalt
Adds functions to check for link override firmware support and get
the override settings for a port. The previously supported/default link
mode was strict mode.
In strict mode link is configured based on get PHY capabilities PHY types
with media.
Lenient mode is now the def
From: Paul Greenwalt
Add AQC get link topology handle support. This is needed to determine
Direct Attach (DA) or backplane media type for PHY types that support
either. Get link topology handle cage node type request can be used to
determine if a cage is present or not. If a cage is present for P
From: Doug Dziggel
Report AOC types as fiber instead of unknown.
Signed-off-by: Doug Dziggel
Tested-by: Andrew Bowers
Signed-off-by: Tony Nguyen
---
drivers/net/ethernet/intel/ice/ice_common.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/net/ethernet/intel/ice/ice
From: Jacob Keller
The ice_parse_caps function is used to convert the capability block data
coming from firmware into a structured format used by other parts of the
code.
The current implementation directly updates the hw->func_caps and
hw->dev_caps structures. It is directly called from within
On 7/17/2020 11:35 AM, Jacob Keller wrote:
> + devlink_flash_update_begin_notify(devlink);
> + devlink_flash_update_status_notify(devlink, "Preparing to flash",
> +component, 0, 0);
> + err = ice_flash_pldm_image(pf, fw, extack);
> + devli
Hi,
On 7/15/20 4:03 AM, Calvin Johnson wrote:
Introduce ACPI mechanism to get PHYs registered on a MDIO bus and
provide them to be connected to MAC.
An ACPI node property "mdio-handle" is introduced to reference the
MDIO bus on which PHYs are registered with autoprobing method used
by mdiobus_r
Lost track of time for this commit. This should go to net-next, not net.
Sorry. I can re-send if necessary.
Randy reported compile failure when CONFIG_SYSCTL is not set/enabled:
ERROR: modpost: "sysctl_vals" [drivers/net/vrf.ko] undefined!
Fix by splitting out the sysctl init and cleanup into helpers that
can be set to do nothing when CONFIG_SYSCTL is disabled. In addition,
move vrf_strict_mode and vrf
Some of the chips in the mv88e6xxx family don't support jumbo
configuration per port. But they do have a chip-wide max frame size that
can be used. Use this to approximate the behaviour of configuring a port
based MTU.
Signed-off-by: Chris Packham
---
The only hardware I have access to uses a 88E
The MV88E6097 chip does not support configuring jumbo frames. Prior to
commit 5f430d65 only the 6352, 6351, 6165 and 6320 chips configured
jumbo mode. The refactor accidentally added the function for the 6097.
Remove the erroneous function pointer assignment.
Fixes: 5f430d65 ("net: dsa: mv
This series connects up the mv88e6xxx switches to the dsa infrastructure for
configuring the port MTU. The first patch is also a bug fix which might be a
candiatate for stable.
I've rebased this series on top of net-next/master to pick up Andrew's change
for the gigabit switches. Patch 1 and 2 are
The MV88E6190 and MV88E6190X both support per port jumbo configuration
just like the other GE switches. Install the appropriate ops.
Signed-off-by: Chris Packham
Reviewed-by: Andrew Lunn
---
I'm including this change in my series for completeness. Looking at the
datasheets I think this is an uni
your patch seem to only affect the WCN3990 chipset. all other ath10k
supported chipset are not supported here. so you see a chance to
implement this more generic?
Sebastian
Am 21.07.2020 um 19:14 schrieb Rakesh Pillai:
During the system suspend or resume, the rx thread
also needs to be suspen
On 7/23/20 3:11 PM, Vladimir Oltean wrote:
> On Wed, Jul 22, 2020 at 03:52:53PM -0700, Florian Fainelli wrote:
>> This patch provides details on the expected behavior of switchdev
>> enabled network devices when operating in a "stand alone" mode, as well
>> as when being bridge members. This clarif
On Wed, Jul 22, 2020 at 04:49:16PM -0700, Stefano Stabellini wrote:
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
>
>
>
> On Wed, 22 Jul 2020, Anchal Agarwal wrote:
>
On Thu, 23 Jul 2020 23:35:31 +0200
Andrew Lunn wrote:
> Hi Marek
>
> I expect some of this should be moved into the phylib core. We don't
> want each PHY inventing its own way to do this. The core should
> provide a framework and the PHY driver fills in the gaps.
>
> Take a look at for example
On Thu, Jul 23, 2020 at 01:55:03PM +0200, Andre Edich wrote:
> Using `void *driver_priv` instead of `unsigned long data[]` is more
> straightforward way to recover the `struct smsc95xx_priv *` from the
> `struct net_device *`.
>
> Signed-off-by: Andre Edich
Reviewed-by: Andrew Lunn
Andrew
On Thu, Jul 23, 2020 at 01:55:05PM +0200, Andre Edich wrote:
> Current driver supports PAL that does link status checking anyway.
>
> Signed-off-by: Andre Edich
Reviewed-by: Andrew Lunn
Andrew
On Thu, Jul 23, 2020 at 01:55:04PM +0200, Andre Edich wrote:
> Generally, each PHY has their own configuration and it can be done
> through an external PHY driver. The smsc95xx driver uses only the
> hard-coded internal PHY configuration.
>
> This patch adds PAL (PHY Abstraction Layer) support to
From: Florian Westphal
sybot came up with following transaction:
add table ip syz0
add chain ip syz0 syz2 { type nat hook prerouting priority 0; policy accept; }
add table ip syz0 { flags dormant; }
delete chain ip syz0 syz2
delete table ip syz0
which yields:
hook not found, pf 2 num 0
WARN
1 - 100 of 363 matches
Mail list logo