Hi Ayush,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    
https://github.com/0day-ci/linux/commits/Ayush-Sawal/Crypto-chcr-Registering-cxgb4-to-xfrmdev_ops/20200724-002940
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 
e6827d1abdc9b061a57d7b7d3019c4e99fabea2f
config: x86_64-rhel-7.6-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function 
'chcr_offload_state':
>> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:6081:35: error: 'struct 
>> cxgb4_uld_info' has no member named 'tlsdev_ops'
    6081 |   if (!adap->uld[CXGB4_ULD_CRYPTO].tlsdev_ops) {
         |                                   ^
>> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:6088:35: error: 'struct 
>> cxgb4_uld_info' has no member named 'xfrmdev_ops'
    6088 |   if (!adap->uld[CXGB4_ULD_CRYPTO].xfrmdev_ops) {
         |                                   ^
   At top level:
   drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:6071:12: warning: 
'chcr_offload_state' defined but not used [-Wunused-function]
    6071 | static int chcr_offload_state(struct adapter *adap,
         |            ^~~~~~~~~~~~~~~~~~
   In file included from drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.h:11,
                    from drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:92:
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:513:18: warning: 
't6_hma_ireg_array' defined but not used [-Wunused-const-variable=]
     513 | static const u32 t6_hma_ireg_array[][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:497:18: warning: 
't5_up_cim_reg_array' defined but not used [-Wunused-const-variable=]
     497 | static const u32 t5_up_cim_reg_array[][IREG_NUM_ELEM + 1] = {
         |                  ^~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:472:18: warning: 
't6_up_cim_reg_array' defined but not used [-Wunused-const-variable=]
     472 | static const u32 t6_up_cim_reg_array[][IREG_NUM_ELEM + 1] = {
         |                  ^~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:467:18: warning: 
't6_ma_ireg_array2' defined but not used [-Wunused-const-variable=]
     467 | static const u32 t6_ma_ireg_array2[][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:461:18: warning: 
't6_ma_ireg_array' defined but not used [-Wunused-const-variable=]
     461 | static const u32 t6_ma_ireg_array[][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:444:18: warning: 
't5_pcie_config_array' defined but not used [-Wunused-const-variable=]
     444 | static const u32 t5_pcie_config_array[][2] = {
         |                  ^~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:437:18: warning: 
't5_pm_tx_array' defined but not used [-Wunused-const-variable=]
     437 | static const u32 t5_pm_tx_array[][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:432:18: warning: 
't5_pm_rx_array' defined but not used [-Wunused-const-variable=]
     432 | static const u32 t5_pm_rx_array[][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:427:18: warning: 
't5_pcie_cdbg_array' defined but not used [-Wunused-const-variable=]
     427 | static const u32 t5_pcie_cdbg_array[][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:421:18: warning: 
't5_pcie_pdbg_array' defined but not used [-Wunused-const-variable=]
     421 | static const u32 t5_pcie_pdbg_array[][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:416:18: warning: 
't6_sge_qbase_index_array' defined but not used [-Wunused-const-variable=]
     416 | static const u32 t6_sge_qbase_index_array[] = {
         |                  ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:411:18: warning: 
't5_sge_dbg_index_array' defined but not used [-Wunused-const-variable=]
     411 | static const u32 t5_sge_dbg_index_array[2][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:399:18: warning: 
't5_tp_mib_index_array' defined but not used [-Wunused-const-variable=]
     399 | static const u32 t5_tp_mib_index_array[9][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:390:18: warning: 
't6_tp_mib_index_array' defined but not used [-Wunused-const-variable=]
     390 | static const u32 t6_tp_mib_index_array[6][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:386:18: warning: 
't5_tp_tm_pio_array' defined but not used [-Wunused-const-variable=]
     386 | static const u32 t5_tp_tm_pio_array[][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:382:18: warning: 
't6_tp_tm_pio_array' defined but not used [-Wunused-const-variable=]
     382 | static const u32 t6_tp_tm_pio_array[][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:368:18: warning: 
't5_tp_pio_array' defined but not used [-Wunused-const-variable=]
     368 | static const u32 t5_tp_pio_array[][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~~
   drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h:353:18: warning: 
't6_tp_pio_array' defined but not used [-Wunused-const-variable=]
     353 | static const u32 t6_tp_pio_array[][IREG_NUM_ELEM] = {
         |                  ^~~~~~~~~~~~~~~

vim +6081 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

  6070  
  6071  static int chcr_offload_state(struct adapter *adap,
  6072                                enum cxgb4_netdev_tls_ops op_val)
  6073  {
  6074          if (!adap->uld[CXGB4_ULD_CRYPTO].handle) {
  6075                  dev_dbg(adap->pdev_dev, "chcr driver is not loaded\n");
  6076                          return -EOPNOTSUPP;
  6077          }
  6078  
  6079          switch (op_val) {
  6080          case CXGB4_TLSDEV_OPS:
> 6081                  if (!adap->uld[CXGB4_ULD_CRYPTO].tlsdev_ops) {
  6082                          dev_dbg(adap->pdev_dev,
  6083                                  "chcr driver has no registered 
tlsdev_ops\n");
  6084                          return -EOPNOTSUPP;
  6085                  }
  6086                  break;
  6087          case CXGB4_XFRMDEV_OPS:
> 6088                  if (!adap->uld[CXGB4_ULD_CRYPTO].xfrmdev_ops) {
  6089                          dev_dbg(adap->pdev_dev,
  6090                                  "chcr driver has no registered 
xfrmdev_ops\n");
  6091                          return -EOPNOTSUPP;
  6092                  }
  6093                  break;
  6094          default:
  6095                  dev_dbg(adap->pdev_dev,
  6096                          "chcr driver has no support for offload %d\n", 
op_val);
  6097                  return -EOPNOTSUPP;
  6098          }
  6099  
  6100          return 0;
  6101  }
  6102  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to