[net-next PATCH v6 4/6] net: phy: introduce phy_find_by_mdio_handle()

2020-07-10 Thread Calvin Johnson
The PHYs on an mdiobus are probed and registered using mdiobus_register(). Later, for connecting these PHYs to MAC, the PHYs registered on the mdiobus have to be referenced. For each MAC node, a property "mdio-handle" is used to reference the MDIO bus on which the PHYs are registered. On getting h

BUG: stack guard page was hit in __bad_area_nosemaphore

2020-07-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7cc2a8ea Merge tag 'block-5.8-2020-07-01' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=135403a310 kernel config: https://syzkaller.appspot.com/x/.config?x=7be693511b29b338 das

[net-next PATCH v6 1/6] Documentation: ACPI: DSD: Document MDIO PHY

2020-07-10 Thread Calvin Johnson
Introduce ACPI mechanism to get PHYs registered on a MDIO bus and provide them to be connected to MAC. An ACPI node property "mdio-handle" is introduced to reference the MDIO bus on which PHYs are registered with autoprobing method used by mdiobus_register(). Describe properties "phy-channel" and

[net-next PATCH v6 2/6] net: phy: introduce device_mdiobus_register()

2020-07-10 Thread Calvin Johnson
Introduce device_mdiobus_register() to register mdiobus in cases of either DT or ACPI. Signed-off-by: Calvin Johnson --- Changes in v6: - change device_mdiobus_register() parameter position - improve documentation Changes in v5: - add description - clean up if else Changes in v4: None Changes

[net-next PATCH v6 6/6] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-07-10 Thread Calvin Johnson
Modify dpaa2_mac_connect() to support ACPI along with DT. Modify dpaa2_mac_get_node() to get the dpmac fwnode from either DT or ACPI. Replace of_get_phy_mode with fwnode_get_phy_mode to get phy-mode for a dpmac_node. Define and use helper function find_phy_device() to find phy_dev that is later con

[net-next PATCH v6 0/6] ACPI support for dpaa2 MAC driver.

2020-07-10 Thread Calvin Johnson
This patch series provides ACPI support for dpaa2 MAC driver. This also introduces ACPI mechanism to get PHYs registered on a MDIO bus and provide them to be connected to MAC. This patchset is dependent on the review patches available on: https://git.kernel.org/pub/scm/linux/kernel/git/lpieral

[net-next PATCH v6 5/6] phylink: introduce phylink_fwnode_phy_connect()

2020-07-10 Thread Calvin Johnson
Define phylink_fwnode_phy_connect() to connect phy specified by a fwnode to a phylink instance. Signed-off-by: Calvin Johnson --- Changes in v6: - clean up phylink_fwnode_phy_connect() Changes in v5: - return -EINVAL for invalid fwnode Changes in v4: None Changes in v3: None Changes in v2: No

[net-next PATCH v6 3/6] net/fsl: use device_mdiobus_register()

2020-07-10 Thread Calvin Johnson
Replace of_mdiobus_register() with device_mdiobus_register() to take care of both DT and ACPI mdiobus_register. Remove unused device_node pointer. Signed-off-by: Calvin Johnson --- Changes in v6: - change device_mdiobus_register() parameter position Changes in v5: None Changes in v4: None Cha

BUG: stack guard page was hit in no_context

2020-07-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7cc2a8ea Merge tag 'block-5.8-2020-07-01' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15dd7d8310 kernel config: https://syzkaller.appspot.com/x/.config?x=7be693511b29b338 das

Re: [PATCH bpf-next 1/5] bpf: block bpf_get_[stack|stackid] on perf_event with PEBS entries

2020-07-10 Thread Song Liu
> On Jul 10, 2020, at 8:53 PM, Andrii Nakryiko > wrote: > > On Fri, Jul 10, 2020 at 6:30 PM Song Liu wrote: >> >> Calling get_perf_callchain() on perf_events from PEBS entries may cause >> unwinder errors. To fix this issue, the callchain is fetched early. Such >> perf_events are marked wit

[PATCH v4] fs/epoll: Enable non-blocking busypoll when epoll timeout is 0

2020-07-10 Thread Sridhar Samudrala
This patch triggers non-blocking busy poll when busy_poll is enabled, epoll is called with a timeout of 0 and is associated with a napi_id. This enables an app thread to go through napi poll routine once by calling epoll with a 0 timeout. poll/select with a 0 timeout behave in a similar manner. S

WARNING in submit_bio_checks

2020-07-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:9e50b94b Add linux-next specific files for 20200703 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=112aaa1f10 kernel config: https://syzkaller.appspot.com/x/.config?x=f99cc0faa1476ed6 dashboard

Re: [GIT] Networking

2020-07-10 Thread pr-tracker-bot
The pull request you sent on Fri, 10 Jul 2020 16:58:15 -0700 (PDT): > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/5a764898afec0bc097003e8c3e727792289f76d6 Thank you! -- Deet-doot-dot,

Re: [PATCH bpf-next 1/5] bpf: block bpf_get_[stack|stackid] on perf_event with PEBS entries

2020-07-10 Thread Andrii Nakryiko
On Fri, Jul 10, 2020 at 6:30 PM Song Liu wrote: > > Calling get_perf_callchain() on perf_events from PEBS entries may cause > unwinder errors. To fix this issue, the callchain is fetched early. Such > perf_events are marked with __PERF_SAMPLE_CALLCHAIN_EARLY. > > Similarly, calling bpf_get_[stack|

Re: [PATCH bpf-next 1/2] bpf, x86: Factor common x86 JIT code

2020-07-10 Thread kernel test robot
master config: x86_64-randconfig-s022-20200710 (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-37-gc9676a3b-dirty # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagn

Re: [RFC PATCH bpf-next 4/5] bpf, x64: rework pro/epilogue and tailcall handling in JIT

2020-07-10 Thread Alexei Starovoitov
On Fri, Jul 10, 2020 at 8:20 PM Alexei Starovoitov wrote: > > Of course you are right. > pop+nop+push is incorrect. > > How about the following instead: > - during JIT: > emit_jump(to_skip_below) <- poke->tailcall_bypass > pop_callee_regs > emit_jump(to_tailcall_target) <- poke->tailcall_target >

Re: [RFC PATCH bpf-next 4/5] bpf, x64: rework pro/epilogue and tailcall handling in JIT

2020-07-10 Thread Alexei Starovoitov
On Fri, Jul 10, 2020 at 4:56 PM Alexei Starovoitov wrote: > > On Thu, Jul 02, 2020 at 03:49:29PM +0200, Maciej Fijalkowski wrote: > > This commit serves two things: > > 1) it optimizes BPF prologue/epilogue generation > > 2) it makes possible to have tailcalls within BPF subprogram > > > > Both po

Re: [PATCH bpf-next] tools/bpftool: remove warning about PID iterator support

2020-07-10 Thread Yonghong Song
On 7/10/20 4:26 PM, Andrii Nakryiko wrote: Don't emit warning that bpftool was built without PID iterator support. This error garbles JSON output of otherwise perfectly valid show commands. Reported-by: Andrey Ignatov Signed-off-by: Andrii Nakryiko Thanks for the fix. Acked-by: Yonghong S

Re: [PATCH] stmmac: pci: Add support for LS7A bridge chip

2020-07-10 Thread Jiaxun Yang
在 2020/7/11 9:35, Jiaxun Yang 写道: 在 2020/7/10 16:51, Zhi Li 写道: Add gmac platform data to support LS7A bridge chip. Co-developed-by: Hongbin Li Signed-off-by: Hongbin Li Signed-off-by: Zhi Li ---   drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 22 ++   1 file c

Re: [PATCH] stmmac: pci: Add support for LS7A bridge chip

2020-07-10 Thread Jiaxun Yang
在 2020/7/10 16:51, Zhi Li 写道: Add gmac platform data to support LS7A bridge chip. Co-developed-by: Hongbin Li Signed-off-by: Hongbin Li Signed-off-by: Zhi Li --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/

Re: [PATCHv6 bpf-next 1/3] xdp: add a new helper for dev map multicast support

2020-07-10 Thread Hangbin Liu
On Fri, Jul 10, 2020 at 07:46:18AM -0600, David Ahern wrote: > >> > >> I'm probably missing something fundamental, but why do you need to walk > >> the keys? Why not just do a lookup on the device index? > > > > This functions is to check if the device index is in exclude map. > > > > The device

Re: [PATCHv6 bpf-next 2/3] sample/bpf: add xdp_redirect_map_multicast test

2020-07-10 Thread Hangbin Liu
On Fri, Jul 10, 2020 at 04:32:35PM +0200, Daniel Borkmann wrote: > On 7/10/20 8:41 AM, Hangbin Liu wrote: > > On Fri, Jul 10, 2020 at 12:40:11AM +0200, Daniel Borkmann wrote: > > > > +SEC("xdp_redirect_map_multi") > > > > +int xdp_redirect_map_multi_prog(struct xdp_md *ctx) > > > > +{ > > > > +

Re: [RFC PATCH bpf-next 0/5] bpf: tailcalls in BPF subprograms

2020-07-10 Thread Alexei Starovoitov
On Thu, Jul 02, 2020 at 03:49:25PM +0200, Maciej Fijalkowski wrote: > Hello, > > today bpf2bpf calls and tailcalls exclude each other. This set is a > proposal to make them work together. It is still a RFC because we need > to decide if the performance impact for BPF programs with tailcalls is > a

[GIT] Networking

2020-07-10 Thread David Miller
It's been about two weeks since the last batch of fixes, and it shows as we clock in here at 146 non-merge commits: 1) Restore previous behavior of CAP_SYS_ADMIN wrt. loading networking BPF programs, from Maciej Żenczykowski. 2) Fix dropped broadcasts in mac80211 code, from Seevalamuthu Maria

Re: [RFC PATCH bpf-next 4/5] bpf, x64: rework pro/epilogue and tailcall handling in JIT

2020-07-10 Thread Alexei Starovoitov
On Thu, Jul 02, 2020 at 03:49:29PM +0200, Maciej Fijalkowski wrote: > This commit serves two things: > 1) it optimizes BPF prologue/epilogue generation > 2) it makes possible to have tailcalls within BPF subprogram > > Both points are related to each other since without 1), 2) could not be > achie

Re: [PATCH bpf] selftests/bpf: Fix cgroup sockopt verifier test

2020-07-10 Thread Daniel Borkmann
On 7/10/20 5:04 PM, Jean-Philippe Brucker wrote: Since the BPF_PROG_TYPE_CGROUP_SOCKOPT verifier test does not set an attach type, bpf_prog_load_check_attach() disallows loading the program and the test is always skipped: #434/p perfevent for cgroup sockopt SKIP (unsupported program type 25)

Re: [PATCH] net/9p: validate fds in p9_fd_open

2020-07-10 Thread Doug Nazar
On 2020-07-10 04:57, Christoph Hellwig wrote: diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c index 13cd683a658ab6..1cd8ea0e493617 100644 --- a/net/9p/trans_fd.c +++ b/net/9p/trans_fd.c @@ -803,20 +803,28 @@ static int p9_fd_open(struct p9_client *client, int rfd, int wfd) re

[PATCH bpf-next] tools/bpftool: remove warning about PID iterator support

2020-07-10 Thread Andrii Nakryiko
Don't emit warning that bpftool was built without PID iterator support. This error garbles JSON output of otherwise perfectly valid show commands. Reported-by: Andrey Ignatov Signed-off-by: Andrii Nakryiko --- tools/bpf/bpftool/pids.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/bpf

Re: [PATCH bpf v2] xsk: fix memory leak and packet loss in Tx skb path

2020-07-10 Thread Daniel Borkmann
Hi Magnus, On 7/10/20 8:45 AM, Magnus Karlsson wrote: In the skb Tx path, transmission of a packet is performed with dev_direct_xmit(). When QUEUE_STATE_FROZEN is set in the transmit routines, it returns NETDEV_TX_BUSY signifying that it was not possible to send the packet now, please try later.

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-07-10 Thread Alexandre Belloni
On 11/07/2020 00:54:53+0200, Andrew Lunn wrote: > On Sat, Jul 11, 2020 at 12:36:10AM +0200, Alexandre Belloni wrote: > > Hi Oleksij, > > > > This patch breaks Ethernet on the sama5d3 Xplained and I have not been > > able to unbreak it. > > Hi Alexandre > > macb0: ethernet

Re: [PATCH v2 bpf-next 1/2] bpf: use dedicated bpf_trace_printk event instead of trace_printk()

2020-07-10 Thread Daniel Borkmann
On 7/10/20 4:22 PM, Alan Maguire wrote: The bpf helper bpf_trace_printk() uses trace_printk() under the hood. This leads to an alarming warning message originating from trace buffer allocation which occurs the first time a program using bpf_trace_printk() is loaded. We can instead create a trace

Re: [PATCH v5 bpf-next 2/5] bpf: Introduce sleepable BPF programs

2020-07-10 Thread Alexei Starovoitov
On Fri, Jul 10, 2020 at 10:00 AM Arnaldo Carvalho de Melo wrote: > > Em Wed, Jul 01, 2020 at 08:21:13AM -0700, Alexei Starovoitov escreveu: > > On Wed, Jul 1, 2020 at 2:34 AM Daniel Borkmann wrote: > > > > > > +1, I think augmenting mid-term would be the best given > > > check_sleepable_blacklis

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-07-10 Thread Andrew Lunn
On Sat, Jul 11, 2020 at 12:36:10AM +0200, Alexandre Belloni wrote: > Hi Oleksij, > > This patch breaks Ethernet on the sama5d3 Xplained and I have not been > able to unbreak it. Hi Alexandre macb0: ethernet@f0028000 { phy-mode = "rgmii";

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-07-10 Thread Alexandre Belloni
Hi Oleksij, This patch breaks Ethernet on the sama5d3 Xplained and I have not been able to unbreak it. Note tat If you want to test, networking has been further broken in v5.8-rc1 but should be properly working in v5.8-rc4 after reverting this patch. On 22/04/2020 09:21:37+0200, Oleksij Rempel wr

[PATCH 14/14 v3] PCI: Remove '*val = 0' from pcie_capability_read_*()

2020-07-10 Thread Saheed Olayemi Bolarinwa
From: Bolarinwa Olayemi Saheed There are several reasons why a PCI capability read may fail whether the device is present or not. If this happens, pcie_capability_read_*() will return -EINVAL/PCIBIOS_BAD_REGISTER_NUMBER or PCIBIOS_DEVICE_NOT_FOUND and *val is set to 0. This behaviour if further

[PATCH 0/14 v3] PCI: Remove '*val = 0' from pcie_capability_read_*()

2020-07-10 Thread Saheed Olayemi Bolarinwa
From: Bolarinwa Olayemi Saheed v3 CHANGES: - Split previous PATCH 6/13 into two : PATCH 6/14 and PATCH 7/14 - Fix commit message of PATCH 5/14 - Update Patch numbering and Commit messages - Add 'Acked by Greg KH' to PATCH 2/14 - Add PATCH version v2 CHANGES: - Fix missing comma, causing the emai

[PATCH net-next v2 13/13] selftests: mlxsw: RED: Test offload of mirror on RED early_drop qevent

2020-07-10 Thread Petr Machata
Add a selftest for offloading a mirror action attached to the block associated with RED early_drop qevent. Signed-off-by: Petr Machata --- .../drivers/net/mlxsw/sch_red_core.sh | 106 +- .../drivers/net/mlxsw/sch_red_ets.sh | 11 ++ .../drivers/net/mlxsw/sch_red

[PATCH net-next v2 04/13] mlxsw: spectrum_span: Move SPAN operations out of global file

2020-07-10 Thread Petr Machata
From: Ido Schimmel The per-ASIC SPAN operations are relevant to the SPAN module and therefore should be implemented there and not in the main driver file. Move them. These operations will be extended later on. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko Reviewed-by: Petr Machata Sign

[PATCH net-next v2 06/13] mlxsw: spectrum_span: Add support for global mirroring triggers

2020-07-10 Thread Petr Machata
From: Ido Schimmel Global mirroring triggers are triggers that are only keyed by their trigger, as opposed to per-port triggers, which are keyed by their trigger and port. Such triggers allow mirroring packets that were tail/early dropped or ECN marked to a SPAN agent. Implement the previously

[PATCH net-next v2 03/13] mlxsw: reg: Add Monitoring Port Analyzer Global Register

2020-07-10 Thread Petr Machata
From: Amit Cohen This register is used for global port analyzer configurations. Signed-off-by: Amit Cohen Reviewed-by: Jiri Pirko Reviewed-by: Petr Machata Signed-off-by: Petr Machata --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 52 +++ 1 file changed, 52 insertions(+

[PATCH net-next v2 12/13] mlxsw: spectrum_qdisc: Offload mirroring on RED qevent early_drop

2020-07-10 Thread Petr Machata
The RED qevents early_drop and mark can be offloaded under the following fairly strict conditions: - At most one filter is configured at the qevent block - The protocol is "any" - The classifier is matchall - The action is trap, sample, or mirror with the same conditions as with other SPAN offlo

[PATCH net-next v2 05/13] mlxsw: spectrum_span: Prepare for global mirroring triggers

2020-07-10 Thread Petr Machata
From: Ido Schimmel Currently, a SPAN agent can only be bound to a per-port trigger where the trigger is either an incoming packet (INGRESS) or an outgoing packet (EGRESS) to / from the port. The subsequent patch will introduce the concept of global mirroring triggers. The binding / unbinding of

[PATCH net-next v2 11/13] mlxsw: spectrum_flow: Promote binder-type dispatch to spectrum.c

2020-07-10 Thread Petr Machata
Two RED qevents have been introduced recently. From the point of view of a driver, qevents are simply blocks with unusual binder types. However they need to be handled by different logic than ACL-like flows. Thus rename mlxsw_sp_setup_tc_block() to mlxsw_sp_setup_tc_block_clsact() and move the bin

[PATCH net-next v2 01/13] net: sched: Pass qdisc reference in struct flow_block_offload

2020-07-10 Thread Petr Machata
Previously, shared blocks were only relevant for the pseudo-qdiscs ingress and clsact. Recently, a qevent facility was introduced, which allows to bind blocks to well-defined slots of a qdisc instance. RED in particular got two qevents: early_drop and mark. Drivers that wish to offload these blocks

[PATCH net-next v2 08/13] mlxsw: spectrum_flow: Convert a goto to a return

2020-07-10 Thread Petr Machata
No clean-up is performed at the target label of this goto. Convert it to a direct return. Signed-off-by: Petr Machata Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mella

[PATCH net-next v2 09/13] mlxsw: spectrum_flow: Drop an unused field

2020-07-10 Thread Petr Machata
The field "dev" in struct mlxsw_sp_flow_block_binding is not used. Drop it. Signed-off-by: Petr Machata Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.h b/drivers/net/eth

[PATCH net-next v2 00/13] mlxsw: Add support for buffer drops mirroring

2020-07-10 Thread Petr Machata
This set offloads the recently introduced qevent infrastructure in TC and allows mlxsw to support mirroring of packets that were dropped due to buffer related reasons (e.g., early drops) during forwarding. Up until now mlxsw only supported mirroring that was either triggered by per-port triggers (

[PATCH net-next v2 02/13] mlxsw: reg: Add Monitoring Mirror Trigger Enable Register

2020-07-10 Thread Petr Machata
From: Amit Cohen This register is used to configure the mirror enable for different mirror reasons. Signed-off-by: Amit Cohen Reviewed-by: Jiri Pirko Reviewed-by: Petr Machata Signed-off-by: Petr Machata --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 50 +++ 1 file chan

[PATCH net-next v2 10/13] mlxsw: spectrum_matchall: Publish matchall data structures

2020-07-10 Thread Petr Machata
A following patch introduces offloading of filters attached to blocks bound to the RED tail_drop qevent. The only classifier that mlxsw will permit in this role is matchall. mlxsw currently offloads matchall filters used with clsact qdisc. The data structures used for that offload will come handy f

[PATCH net-next v2 07/13] mlxsw: spectrum_span: Add APIs to enable / disable global mirroring triggers

2020-07-10 Thread Petr Machata
From: Ido Schimmel While the binding of global mirroring triggers to a SPAN agent is global, packets are only mirrored if they belong to a port and TC on which the trigger was enabled. This allows, for example, to mirror packets that were tail-dropped on a specific netdev. Implement the operatio

[Linux-kernel-mentees] [PATCH 2/2] net/bluetooth: Prevent out-of-bounds read in hci_inquiry_result_with_rssi_evt()

2020-07-10 Thread Peilin Ye
Check `num_rsp` before using it as for-loop counter. Add `unlock` label. Cc: sta...@vger.kernel.org Signed-off-by: Peilin Ye --- net/bluetooth/hci_event.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index 8b3736c83b8e..f9f42624

Re: [PATCH net] cgroup: Fix sock_cgroup_data on big-endian.

2020-07-10 Thread David Miller
From: Jakub Kicinski Date: Fri, 10 Jul 2020 13:54:24 -0700 > On Fri, 10 Jul 2020 13:47:47 -0700 (PDT) David Miller wrote: >> From: Jakub Kicinski >> Date: Thu, 9 Jul 2020 17:03:20 -0700 >> >> > On Thu, 09 Jul 2020 16:32:35 -0700 (PDT) David Miller wrote: >> >> From: Cong Wang >> >> >> >> In

[Linux-kernel-mentees] [PATCH 1/2] net/bluetooth: Prevent out-of-bounds read in hci_inquiry_result_evt()

2020-07-10 Thread Peilin Ye
Check `num_rsp` before using it as for-loop counter. Cc: sta...@vger.kernel.org Signed-off-by: Peilin Ye --- net/bluetooth/hci_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index 03a0759f2fc2..8b3736c83b8e 100644

Re: [PATCH v4 net-next] inet: Remove an unnecessary argument of syn_ack_recalc().

2020-07-10 Thread David Miller
From: Kuniyuki Iwashima Date: Sat, 11 Jul 2020 00:57:59 +0900 > Commit 0c3d79bce48034018e840468ac5a642894a521a3 ("tcp: reduce SYN-ACK > retrans for TCP_DEFER_ACCEPT") introduces syn_ack_recalc() which decides > if a minisock is held and a SYN+ACK is retransmitted or not. > > If rskq_defer_accept

Re: [PATCH V1 net-next 2/8] net: ena: add reserved PCI device ID

2020-07-10 Thread Machulsky, Zorik
On 7/9/20, 1:01 PM, "David Miller" wrote: From: Date: Thu, 9 Jul 2020 22:04:57 +0300 > From: Arthur Kiyanovski > > Add a reserved PCI device ID to the driver's table > > Signed-off-by: Arthur Kiyanovski No explanation whatsoever what this reserved ID is, wh

Re: [PATCH net 0/2] mlxsw: Various fixes

2020-07-10 Thread David Miller
From: Ido Schimmel Date: Fri, 10 Jul 2020 16:41:37 +0300 > From: Ido Schimmel > > Fix two issues found by syzkaller. > > Patch #1 removes inappropriate usage of WARN_ON() following memory > allocation failure. Constantly triggered when syzkaller injects faults. > > Patch #2 fixes a use-after-

Re: [PATCH net-next v3 0/7] Add devlink-health support for devlink ports

2020-07-10 Thread David Miller
From: Moshe Shemesh Date: Fri, 10 Jul 2020 15:25:06 +0300 > Implement support for devlink health reporters on per-port basis. Series applied, thank you.

Re: [PATCH v5 0/5] net: macb: Wake-on-Lan magic packet fixes and GEM handling

2020-07-10 Thread David Miller
From: Date: Fri, 10 Jul 2020 14:46:40 +0200 > Here is a split series to fix WoL magic-packet on the current macb driver. > Only > fixes in this one based on current net/master. Series applied, thank you.

Re: [PATCH net] bnxt_en: fix NULL dereference in case SR-IOV configuration fails

2020-07-10 Thread David Miller
From: Davide Caratti Date: Fri, 10 Jul 2020 12:55:08 +0200 > we need to set 'active_vfs' back to 0, if something goes wrong during the > allocation of SR-IOV resources: otherwise, further VF configurations will > wrongly assume that bp->pf.vf[x] are valid memory locations, and commands > like the

Re: [PATCH net-next] net: make symbol 'flush_works' static

2020-07-10 Thread David Miller
From: Wei Yongjun Date: Fri, 10 Jul 2020 15:31:04 +0800 > The sparse tool complains as follows: > > net/core/dev.c:5594:1: warning: > symbol '__pcpu_scope_flush_works' was not declared. Should it be static? > > 'flush_works' is not used outside of dev.c, so marks > it static. > > Reported-by:

Re: [pull request][net-next 00/13] Mellanox, mlx5 CT updates 2020-07-09

2020-07-10 Thread David Miller
From: Saeed Mahameed Date: Thu, 9 Jul 2020 20:44:19 -0700 > This series provides updates to mlx5 CT (connection tracking) offloads > For more information please see tag log below. > > Please pull and let me know if there is any problem. Pulled. > The following conflict is expected when net is

Re: [PATCH net-next v3 0/7] Add devlink-health support for devlink ports

2020-07-10 Thread Jakub Kicinski
On Fri, 10 Jul 2020 15:25:06 +0300 Moshe Shemesh wrote: > Changes v2 -> v3: > Added motivation to cover letter and note on uAPI. I guess this will be a test of how many production users this API has... Acked-by: Jakub Kicinski

Re: pull-request: bpf 2020-07-09

2020-07-10 Thread David Miller
From: Alexei Starovoitov Date: Thu, 9 Jul 2020 19:48:24 -0700 > The following pull-request contains BPF updates for your *net* tree. > > We've added 4 non-merge commits during the last 1 day(s) which contain > a total of 4 files changed, 26 insertions(+), 15 deletions(-). > > The main changes

Re: [pull request][net V2 0/9] mlx5 fixes 2020-07-02

2020-07-10 Thread David Miller
From: Saeed Mahameed Date: Thu, 9 Jul 2020 19:30:09 -0700 > This series introduces some fixes to mlx5 driver. > > V1->v2: > - Drop "ip -s" patch and mirred device hold reference patch. > - Will revise them in a later submission. > > Please pull and let me know if there is any problem. Pulle

Re: [pull request][net V2 0/9] mlx5 fixes 2020-07-02

2020-07-10 Thread Jakub Kicinski
On Thu, 9 Jul 2020 19:30:09 -0700 Saeed Mahameed wrote: > V1->v2: > - Drop "ip -s" patch and mirred device hold reference patch. > - Will revise them in a later submission. Acked-by: Jakub Kicinski

Re: [net-next PATCH v5 5/6] phylink: introduce phylink_fwnode_phy_connect()

2020-07-10 Thread Andy Shevchenko
On Fri, Jul 10, 2020 at 7:32 PM Calvin Johnson wrote: > > Define phylink_fwnode_phy_connect() to connect phy specified by > a fwnode to a phylink instance. ... > +int phylink_fwnode_phy_connect(struct phylink *pl, > + struct fwnode_handle *fwnode, > +

Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-10 Thread Jakub Kicinski
On Fri, 10 Jul 2020 11:41:25 -0400 min.li...@renesas.com wrote: > From: Min Li > > This patch is to add debugfs support for ptp_clockmatrix and ptp_idt82p33. > It will create a debugfs directory called idtptp{x} and x is the ptp index. > Three inerfaces are present, which are cmd, help and regs.

Re: [net-next PATCH v5 2/6] net: phy: introduce device_mdiobus_register()

2020-07-10 Thread Andy Shevchenko
On Fri, Jul 10, 2020 at 7:31 PM Calvin Johnson wrote: > > Introduce device_mdiobus_register() to register mdiobus > in cases of either DT or ACPI. ... > +/** > + * device_mdiobus_register - bring up all the PHYs on a given bus and > + * attach them to bus. This handles both DT and ACPI methods.

Re: [PATCH v2 bpf-next 1/2] bpf: use dedicated bpf_trace_printk event instead of trace_printk()

2020-07-10 Thread Andrii Nakryiko
On Fri, Jul 10, 2020 at 7:25 AM Alan Maguire wrote: > > The bpf helper bpf_trace_printk() uses trace_printk() under the hood. > This leads to an alarming warning message originating from trace > buffer allocation which occurs the first time a program using > bpf_trace_printk() is loaded. > > We ca

Re: [PATCH net-next v4 00/10] udp_tunnel: add NIC RX port offload infrastructure

2020-07-10 Thread David Miller
From: Jakub Kicinski Date: Thu, 9 Jul 2020 17:42:43 -0700 ... > This work tries to improve the situation by pulling the UDP tunnel > port table maintenance out of the drivers. It turns out that almost > all drivers maintain a fixed size table of ports (in most cases one > per tunnel type), so w

Re: [RFC v2 net-next] devlink: Add reset subcommand.

2020-07-10 Thread Jacob Keller
On 7/10/2020 1:39 PM, Jakub Kicinski wrote: > On Fri, 10 Jul 2020 11:16:51 -0700 Jacob Keller wrote: >>> We already have notion of "a component" in "devlink dev flash". I think >>> that the reset component name should be in-sync with the flash. >> >> Right. We should re-use the component names from

Re: [PATCH v2 bpf-next 2/2] selftests/bpf: add selftests verifying bpf_trace_printk() behaviour

2020-07-10 Thread Andrii Nakryiko
On Fri, Jul 10, 2020 at 7:25 AM Alan Maguire wrote: > > Simple selftests that verifies bpf_trace_printk() returns a sensible > value and tracing messages appear. > > Signed-off-by: Alan Maguire > --- see pedantic note below, but I don't think that's an issue in practice Acked-by: Andrii Nakryik

Re: [PATCH net] cgroup: Fix sock_cgroup_data on big-endian.

2020-07-10 Thread Jakub Kicinski
On Fri, 10 Jul 2020 13:47:47 -0700 (PDT) David Miller wrote: > From: Jakub Kicinski > Date: Thu, 9 Jul 2020 17:03:20 -0700 > > > On Thu, 09 Jul 2020 16:32:35 -0700 (PDT) David Miller wrote: > >> From: Cong Wang > >> > >> In order for no_refcnt and is_data to be the lowest order two > >> bits

Re: [PATCH net] cgroup: Fix sock_cgroup_data on big-endian.

2020-07-10 Thread David Miller
From: Jakub Kicinski Date: Thu, 9 Jul 2020 17:03:20 -0700 > On Thu, 09 Jul 2020 16:32:35 -0700 (PDT) David Miller wrote: >> From: Cong Wang >> >> In order for no_refcnt and is_data to be the lowest order two >> bits in the 'val' we have to pad out the bitfield of the u8. >> >> Fixes: ad0f75e5f

Re: [PATCH v6 bpf-next 0/9] bpf: Add d_path helper - preparation changes

2020-07-10 Thread Andrii Nakryiko
On Fri, Jul 10, 2020 at 12:38 PM Jiri Olsa wrote: > > hi, > this patchset does preparation work for adding d_path helper, > which still needs more work, but the initial set of patches > is ready and useful to have. > > This patchset adds: > - support to generate BTF ID lists that are resolved du

Re: [RFC v2 net-next] devlink: Add reset subcommand.

2020-07-10 Thread Jakub Kicinski
On Fri, 10 Jul 2020 11:16:51 -0700 Jacob Keller wrote: > > We already have notion of "a component" in "devlink dev flash". I think > > that the reset component name should be in-sync with the flash. > > Right. We should re-use the component names from devlink dev info here > (just as we do in devl

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-10 Thread Jacob Keller
On 7/10/2020 1:25 PM, Jakub Kicinski wrote: > On Fri, 10 Jul 2020 10:32:24 -0700 Jacob Keller wrote: >> On 7/9/2020 5:19 PM, Jakub Kicinski wrote: >>> On Thu, 9 Jul 2020 14:26:52 -0700 Jacob Keller wrote: The flash update for the ice hardware currently supports a single fixed config

Re: [PATCH V1 net-next 6/8] net: ena: enable support of rss hash key and function changes

2020-07-10 Thread Machulsky, Zorik
On 7/10/20, 1:05 PM, "Jakub Kicinski" wrote: On Fri, 10 Jul 2020 19:53:46 + Machulsky, Zorik wrote: > On 7/9/20, 1:24 PM, "Jakub Kicinski" wrote: > > On Thu, 9 Jul 2020 22:05:01 +0300 akiy...@amazon.com wrote: > > From: Arthur Kiyanovski > > >

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-10 Thread Jakub Kicinski
On Fri, 10 Jul 2020 10:32:24 -0700 Jacob Keller wrote: > On 7/9/2020 5:19 PM, Jakub Kicinski wrote: > > On Thu, 9 Jul 2020 14:26:52 -0700 Jacob Keller wrote: > >> The flash update for the ice hardware currently supports a single fixed > >> configuration: > >> > >> * Firmware is always asked to p

RE: [net-next v3 13/15] iecm: Add ethtool

2020-07-10 Thread Brady, Alan
> -Original Message- > From: Jakub Kicinski > Sent: Friday, June 26, 2020 12:30 PM > To: Kirsher, Jeffrey T > Cc: da...@davemloft.net; Michael, Alice ; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Brady, Alan ; Burra, Phani R ; > Hay, Joshua A ; Chittim, Madhu > ;

Re: [PATCH V1 net-next 6/8] net: ena: enable support of rss hash key and function changes

2020-07-10 Thread Jakub Kicinski
On Fri, 10 Jul 2020 19:53:46 + Machulsky, Zorik wrote: > On 7/9/20, 1:24 PM, "Jakub Kicinski" wrote: > > On Thu, 9 Jul 2020 22:05:01 +0300 akiy...@amazon.com wrote: > > From: Arthur Kiyanovski > > > > Add the rss_configurable_function_key bit to driver_supported_feature. >

Re: [PATCH V1 net-next 6/8] net: ena: enable support of rss hash key and function changes

2020-07-10 Thread Machulsky, Zorik
On 7/9/20, 1:24 PM, "Jakub Kicinski" wrote: On Thu, 9 Jul 2020 22:05:01 +0300 akiy...@amazon.com wrote: > From: Arthur Kiyanovski > > Add the rss_configurable_function_key bit to driver_supported_feature. > > This bit tells the device that the driver in question suppor

Re: [PATCH v1 1/1] dt-bindings: net: dsa: Add DSA yaml binding

2020-07-10 Thread Rob Herring
On Fri, Jul 10, 2020 at 11:20 AM Florian Fainelli wrote: > > > > On 7/10/2020 9:45 AM, Rob Herring wrote: > > On Fri, Jul 10, 2020 at 11:06:18AM +0200, Kurt Kanzenbach wrote: > >> For future DSA drivers it makes sense to add a generic DSA yaml binding > >> which > >> can be used then. This was cr

[PATCH v6 bpf-next 3/9] bpf: Add BTF_ID_LIST/BTF_ID/BTF_ID_UNUSED macros

2020-07-10 Thread Jiri Olsa
Adding support to generate .BTF_ids section that will hold BTF ID lists for verifier. Adding macros that will help to define lists of BTF ID values placed in .BTF_ids section. They are initially filled with zeros (during compilation) and resolved later during the linking phase by resolve_btfids to

[PATCH v6 bpf-next 9/9] selftests/bpf: Add test for resolve_btfids

2020-07-10 Thread Jiri Olsa
Adding resolve_btfids test under test_progs suite. It's possible to use btf_ids.h header and its logic in user space application, so we can add easy test for it. The test defines BTF_ID_LIST and checks it gets properly resolved. For this reason the test_progs binary (and other binaries that use

[PATCH v6 bpf-next 5/9] bpf: Remove btf_id helpers resolving

2020-07-10 Thread Jiri Olsa
Now when we moved the helpers btf_id arrays into .BTF_ids section, we can remove the code that resolve those IDs in runtime. Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- kernel/bpf/btf.c | 89 +++- 1 file changed, 5 insertions(+), 84 deletio

[PATCH v6 bpf-next 0/9] bpf: Add d_path helper - preparation changes

2020-07-10 Thread Jiri Olsa
hi, this patchset does preparation work for adding d_path helper, which still needs more work, but the initial set of patches is ready and useful to have. This patchset adds: - support to generate BTF ID lists that are resolved during kernel linking and usable within kernel code with followi

[PATCH v6 bpf-next 7/9] bpf: Add info about .BTF_ids section to btf.rst

2020-07-10 Thread Jiri Olsa
Updating btf.rst doc with info about .BTF_ids section Signed-off-by: Jiri Olsa --- Documentation/bpf/btf.rst | 36 1 file changed, 36 insertions(+) diff --git a/Documentation/bpf/btf.rst b/Documentation/bpf/btf.rst index 4d565d202ce3..c9dec7a565e8 100644 ---

[PATCH v6 bpf-next 6/9] bpf: Use BTF_ID to resolve bpf_ctx_convert struct

2020-07-10 Thread Jiri Olsa
This way the ID is resolved during compile time, and we can remove the runtime name search. Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- kernel/bpf/btf.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index 71140b

[PATCH v6 bpf-next 1/9] bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object

2020-07-10 Thread Jiri Olsa
The resolve_btfids tool scans elf object for .BTF_ids section and resolves its symbols with BTF ID values. It will be used to during linking time to resolve arrays of BTF ID values used in verifier, so these IDs do not need to be resolved in runtime. The expected layout of .BTF_ids section is des

[PATCH v6 bpf-next 8/9] tools headers: Adopt verbatim copy of btf_ids.h from kernel sources

2020-07-10 Thread Jiri Olsa
It will be needed by bpf selftest for resolve_btfids tool. Also adding __PASTE macro as btf_ids.h dependency, which is defined in: include/linux/compiler_types.h but because tools/include do not have this header, I'm putting the macro into linux/compiler.h header. Acked-by: Andrii Nakryiko S

[PATCH v6 bpf-next 4/9] bpf: Resolve BTF IDs in vmlinux image

2020-07-10 Thread Jiri Olsa
Using BTF_ID_LIST macro to define lists for several helpers using BTF arguments. And running resolve_btfids on vmlinux elf object during linking, so the .BTF_ids section gets the IDs resolved. Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- Makefile | 3 ++- kernel/trace

[PATCH v6 bpf-next 2/9] bpf: Compile resolve_btfids tool at kernel compilation start

2020-07-10 Thread Jiri Olsa
The resolve_btfids tool will be used during the vmlinux linking, so it's necessary it's ready for it. Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- Makefile | 22 ++ tools/Makefile | 3 +++ tools/bpf/Makefile | 9 - 3 files changed, 29 insert

Re: [PATCH v2] MAINTAINERS: XDP: restrict N: and K:

2020-07-10 Thread Joe Perches
On Fri, 2020-07-10 at 21:04 +0200, Alexander A. Klimov wrote: > Rationale: > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465" > which has nothing to do with XDP. > > Signed-off-by: Alexander A. Klimov > --- > Better? > > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [PATCH v4 net-next] inet: Remove an unnecessary argument of syn_ack_recalc().

2020-07-10 Thread Eric Dumazet
On 7/10/20 8:57 AM, Kuniyuki Iwashima wrote: > Commit 0c3d79bce48034018e840468ac5a642894a521a3 ("tcp: reduce SYN-ACK > retrans for TCP_DEFER_ACCEPT") introduces syn_ack_recalc() which decides > if a minisock is held and a SYN+ACK is retransmitted or not. > > If rskq_defer_accept is not zero in

Re: [PATCH bpf-next v3 12/16] libbpf: Add support for SK_LOOKUP program type

2020-07-10 Thread Jakub Sitnicki
On Fri, Jul 10, 2020 at 08:55 PM CEST, Andrii Nakryiko wrote: > On Fri, Jul 10, 2020 at 1:37 AM Jakub Sitnicki wrote: [...] >> I've been happily using the part of section name following "sk_lookup" >> prefix to name the programs just to make section names in ELF object >> unique: >> >> SEC("sk

Re: [PATCH bpf-next v3 01/16] bpf, netns: Handle multiple link attachments

2020-07-10 Thread Jakub Sitnicki
On Fri, Jul 10, 2020 at 12:02 AM CEST, Andrii Nakryiko wrote: > On Thu, Jul 9, 2020 at 5:49 AM Jakub Sitnicki wrote: >> >> On Thu, Jul 09, 2020 at 05:44 AM CEST, Andrii Nakryiko wrote: >> > On Thu, Jul 2, 2020 at 2:24 AM Jakub Sitnicki wrote: >> >> >> >> Extend the BPF netns link callbacks to reb

[PATCH v2] MAINTAINERS: XDP: restrict N: and K:

2020-07-10 Thread Alexander A. Klimov
Rationale: Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465" which has nothing to do with XDP. Signed-off-by: Alexander A. Klimov --- Better? MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1d4aa7f942de..735e247

Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

2020-07-10 Thread Toke Høiland-Jørgensen
Joe Perches writes: > On Fri, 2020-07-10 at 20:18 +0200, Alexander A. Klimov wrote: >> >> Am 10.07.20 um 18:12 schrieb Toke Høiland-Jørgensen: >> > Joe Perches writes: >> > >> > > On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote: >> > > > On 7/10/20 8:17 AM, Alexander A. Klimov wrote:

Re: [PATCH bpf-next v3 12/16] libbpf: Add support for SK_LOOKUP program type

2020-07-10 Thread Andrii Nakryiko
On Fri, Jul 10, 2020 at 1:37 AM Jakub Sitnicki wrote: > > On Fri, Jul 10, 2020 at 01:13 AM CEST, Andrii Nakryiko wrote: > > On Thu, Jul 9, 2020 at 8:51 AM Jakub Sitnicki wrote: > >> > >> On Thu, Jul 09, 2020 at 06:23 AM CEST, Andrii Nakryiko wrote: > >> > On Thu, Jul 2, 2020 at 2:25 AM Jakub Sitn

  1   2   3   >