No clean-up is performed at the target label of this goto. Convert it to a
direct return.

Signed-off-by: Petr Machata <pe...@mellanox.com>
Reviewed-by: Jiri Pirko <j...@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c 
b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c
index 47b66f347ff1..421581a85cd6 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c
@@ -219,8 +219,7 @@ static int mlxsw_sp_setup_tc_block_bind(struct 
mlxsw_sp_port *mlxsw_sp_port,
                                               mlxsw_sp_tc_block_release);
                if (IS_ERR(block_cb)) {
                        mlxsw_sp_flow_block_destroy(flow_block);
-                       err = PTR_ERR(block_cb);
-                       goto err_cb_register;
+                       return PTR_ERR(block_cb);
                }
                register_block = true;
        } else {
@@ -247,7 +246,6 @@ static int mlxsw_sp_setup_tc_block_bind(struct 
mlxsw_sp_port *mlxsw_sp_port,
 err_block_bind:
        if (!flow_block_cb_decref(block_cb))
                flow_block_cb_free(block_cb);
-err_cb_register:
        return err;
 }
 
-- 
2.20.1

Reply via email to