Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client

2020-06-30 Thread Greg KH
On Tue, Jun 30, 2020 at 10:24:04AM -0700, Ranjani Sridharan wrote: > On Tue, 2020-06-30 at 08:32 -0300, Jason Gunthorpe wrote: > > On Tue, Jun 30, 2020 at 11:31:41AM +0100, Mark Brown wrote: > > > On Mon, Jun 29, 2020 at 07:59:59PM -0300, Jason Gunthorpe wrote: > > > > On Mon, Jun 29, 2020 at 09:33

Re: [PATCHv5 bpf-next 1/3] xdp: add a new helper for dev map multicast support

2020-06-30 Thread Hangbin Liu
On Tue, Jun 30, 2020 at 10:09:39PM -0700, Andrii Nakryiko wrote: > > diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h > > index 0cb8ec948816..d7de6c0b32e4 100644 > > --- a/tools/include/uapi/linux/bpf.h > > +++ b/tools/include/uapi/linux/bpf.h > > @@ -3285,6 +3285,23 @@

Re: [PATCH bpf-next 2/3] selftests/bpf: add selftest testin btf_dump's mod-stripping output

2020-06-30 Thread Andrii Nakryiko
On Tue, Jun 30, 2020 at 11:45 PM Andrii Nakryiko wrote: > > Add selftest validating that .strip_mods=true works. > > Signed-off-by: Andrii Nakryiko > --- Please ignore this patch, it is a stale copy with a typo in the subject. [...]

[PATCH bpf-next 1/3] libbpf: support stripping modifiers for btf_dump

2020-06-30 Thread Andrii Nakryiko
One important use case when emitting const/volatile/restrict is undesirable is BPF skeleton generation of DATASEC layout. These are further memory-mapped and can be written/read from user-space directly. For important case of .rodata variables, bpftool strips away first-level modifiers, to make th

[PATCH bpf-next 0/3] Strip away modifiers from BPF skeleton global variables

2020-06-30 Thread Andrii Nakryiko
Fix bpftool logic of stripping away const/volatile modifiers for all global variables during BPF skeleton generation. See patch #1 for details on when existing logic breaks and why it's important. Support special .strip_mods=true mode in btf_dump. Add selftests validating that everything works as e

[PATCH bpf-next 3/3] tools/bpftool: strip away modifiers from global variables

2020-06-30 Thread Andrii Nakryiko
Reliably remove all the type modifiers from global variable definitions, including cases of inner field const modifiers and arrays of const values. Also modify one of selftests to ensure that const volatile struct doesn't prevent user-space from modifying .rodata variable. Signed-off-by: Andrii N

[PATCH bpf-next 2/3] selftests/bpf: add selftest validating btf_dump's mod-stripping output

2020-06-30 Thread Andrii Nakryiko
Add selftest validating that .strip_mods=true mode works correctly. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/btf_dump.c | 5 +- .../bpf/progs/btf_dump_test_case_strip_mods.c | 50 +++ 2 files changed, 54 insertions(+), 1 deletion(-) create mode 1006

[PATCH bpf-next 2/3] selftests/bpf: add selftest testin btf_dump's mod-stripping output

2020-06-30 Thread Andrii Nakryiko
Add selftest validating that .strip_mods=true works. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/btf_dump.c | 5 +- .../bpf/progs/btf_dump_test_case_strip_mods.c | 50 +++ 2 files changed, 54 insertions(+), 1 deletion(-) create mode 100644 tools/testi

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread wenxu
On 7/1/2020 2:12 PM, Cong Wang wrote: > On Tue, Jun 30, 2020 at 11:03 PM wenxu wrote: >> Only forward packet case need do fragment again and there is no need do >> defrag explicit. > Same question: why act_mirred? You have to explain why act_mirred > has the responsibility to do this job. The

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread Cong Wang
On Tue, Jun 30, 2020 at 11:03 PM wenxu wrote: > > Only forward packet case need do fragment again and there is no need do > defrag explicit. Same question: why act_mirred? You have to explain why act_mirred has the responsibility to do this job. Thanks.

[net-next PATCH v2 2/3] Documentation: ACPI: DSD: Document MDIO PHY

2020-06-30 Thread Calvin Johnson
Introduce ACPI mechanism to get PHYs registered on a MDIO bus and provide them to be connected to MAC. An ACPI node property "mdio-handle" is introduced to reference the MDIO bus on which PHYs are registered with autoprobing method used by mdiobus_register(). Signed-off-by: Calvin Johnson --- C

[net-next PATCH v2 3/3] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-06-30 Thread Calvin Johnson
Modify dpaa2_mac_connect() to support ACPI along with DT. Modify dpaa2_mac_get_node() to get the dpmac fwnode from either DT or ACPI. Replace of_get_phy_mode with fwnode_get_phy_mode to get phy-mode for a dpmac_node. Define and use helper function find_phy_device() to find phy_dev that is later con

[net-next PATCH v2 0/3] ACPI support for dpaa2 MAC driver.

2020-06-30 Thread Calvin Johnson
This patch series provides ACPI support for dpaa2 MAC driver. This also introduces ACPI mechanism to get PHYs registered on a MDIO bus and provide them to be connected to MAC. This patchset is dependent on the review patches available on: https://git.kernel.org/pub/scm/linux/kernel/git/lpieral

[net-next PATCH v2 1/3] net: phy: introduce find_phy_device()

2020-06-30 Thread Calvin Johnson
The PHYs on a mdiobus are probed and registered using mdiobus_register(). Later, for connecting these PHYs to MAC, the PHYs registered on the mdiobus have to be referenced. For each MAC node, a property "mdio-handle" is used to reference the MDIO bus on which the PHYs are registered. On getting ho

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread wenxu
On 7/1/2020 1:52 PM, Cong Wang wrote: > On Tue, Jun 30, 2020 at 7:36 PM wenxu wrote: >> >> On 7/1/2020 3:02 AM, Cong Wang wrote: >>> On Mon, Jun 29, 2020 at 7:55 PM wrote: From: wenxu The fragment packets do defrag in act_ct module. The reassembled packet over the mtu in th

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread Cong Wang
On Tue, Jun 30, 2020 at 7:36 PM wenxu wrote: > > > On 7/1/2020 3:02 AM, Cong Wang wrote: > > On Mon, Jun 29, 2020 at 7:55 PM wrote: > >> From: wenxu > >> > >> The fragment packets do defrag in act_ct module. The reassembled packet > >> over the mtu in the act_mirred. This big packet should be fr

Re: [RFC v2 net-next] devlink: Add reset subcommand.

2020-06-30 Thread Jiri Pirko
Tue, Jun 30, 2020 at 05:15:18PM CEST, vasundhara-v.vo...@broadcom.com wrote: >On Tue, Jun 30, 2020 at 6:23 PM Jiri Pirko wrote: >> >> Tue, Jun 30, 2020 at 01:34:06PM CEST, vasundhara-v.vo...@broadcom.com wrote: >> >Advanced NICs support live reset of some of the hardware >> >components, that reset

Re: [PATCH v1] orinoco: use generic power management

2020-06-30 Thread Vaibhav Gupta
On Wed, 24 Jun 2020 at 23:14, Vaibhav Gupta wrote: > > With the support of generic PM callbacks, drivers no longer need to use > legacy .suspend() and .resume() in which they had to maintain PCI states > changes and device's power state themselves. The required operations are > done by PCI core. >

Re: [PATCHv5 bpf-next 1/3] xdp: add a new helper for dev map multicast support

2020-06-30 Thread Andrii Nakryiko
On Tue, Jun 30, 2020 at 9:21 PM Hangbin Liu wrote: > > This patch is for xdp multicast support. In this implementation we > add a new helper to accept two maps: forward map and exclude map. > We will redirect the packet to all the interfaces in *forward map*, but > exclude the interfaces that in *

[PATCHv5 bpf-next 3/3] selftests/bpf: add xdp_redirect_multi test

2020-06-30 Thread Hangbin Liu
Add a bpf selftest for new helper xdp_redirect_map_multi(). In this test we have 3 forward groups groups and 1 exclude group. The test will redirect each interface's packets to all the interfaces in the forward group, and exclude the interface in exclude map. We will also test both DEVMAP and DEVMA

[PATCHv5 bpf-next 0/3] xdp: add a new helper for dev map multicast support

2020-06-30 Thread Hangbin Liu
This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

[PATCHv5 bpf-next 2/3] sample/bpf: add xdp_redirect_map_multicast test

2020-06-30 Thread Hangbin Liu
This is a sample for xdp multicast. In the sample we could forward all packets between given interfaces. v5: add a null_map as we have strict the arg2 to ARG_CONST_MAP_PTR. Move the testing part to bpf selftest in next patch. v4: no update. v3: add rxcnt map to show the packet transmit speed.

[PATCHv5 bpf-next 1/3] xdp: add a new helper for dev map multicast support

2020-06-30 Thread Hangbin Liu
This patch is for xdp multicast support. In this implementation we add a new helper to accept two maps: forward map and exclude map. We will redirect the packet to all the interfaces in *forward map*, but exclude the interfaces that in *exclude map*. To achive this I add a new ex_map for struct bp

Re: [regression] TCP_MD5SIG on established sockets

2020-06-30 Thread Herbert Xu
On Tue, Jun 30, 2020 at 08:36:51PM -0700, Eric Dumazet wrote: > > If I knew so many people were excited about TCP / MD5, I would have > posted all my patches on lkml ;) > > Without the smp_wmb() we would still need something to prevent KMSAN > from detecting that we read uninitialized bytes, > if

RE: [EXT] Re: [PATCH net] net: ethernet: fec: prevent tx starvation under high rx load

2020-06-30 Thread Andy Duan
From: David Miller Sent: Wednesday, July 1, 2020 3:58 AM > From: "Tobias Waldekranz" > Date: Tue, 30 Jun 2020 08:39:58 +0200 > > > On Mon Jun 29, 2020 at 3:07 PM CEST, David Miller wrote: > >> I don't see how this can happen since you process the TX queue > >> unconditionally every NAPI pass, re

[PATCH net v1] hinic: fix passing non negative value to ERR_PTR

2020-06-30 Thread Luo bin
get_dev_cap and set_resources_state functions may return a positive value because of hardware failure, and the positive return value can not be passed to ERR_PTR directly. Fixes: 7dd29ee12865 ("hinic: add sriov feature support") Signed-off-by: Luo bin --- drivers/net/ethernet/huawei/hinic/hinic_

Re: wireguard: problem sending via libpcap's packet socket

2020-06-30 Thread Jason A. Donenfeld
On Sun, Jun 28, 2020 at 2:04 PM Willem de Bruijn wrote: > > On Sat, Jun 27, 2020 at 1:58 AM Jason A. Donenfeld wrote: > > > > Hi again Hans, > > > > A few remarks: although gre implements header_ops, it looks like > > various parts of the networking stack change behavior based on it. I'm > > stil

Re: [regression] TCP_MD5SIG on established sockets

2020-06-30 Thread Herbert Xu
On Tue, Jun 30, 2020 at 07:30:43PM -0700, Eric Dumazet wrote: > > I made this clear in the changelog, do we want comments all over the places ? > Do not get me wrong, we had this bug for years and suddenly this is a > big deal... I thought you were adding a new pair of smp_rmb/smp_wmb. If they al

Re: [PATCH net] hinic: fix passing non negative value to ERR_PTR

2020-06-30 Thread luobin (L)
On 2020/7/1 0:20, Jakub Kicinski wrote: > On Tue, 30 Jun 2020 14:35:54 +0800 Luo bin wrote: >> get_dev_cap and set_resources_state functions may return a positive >> value because of hardware failure, and the positive return value >> can not be passed to ERR_PTR directly. >> >> Fixes: 7dd29ee12865

Re: [regression] TCP_MD5SIG on established sockets

2020-06-30 Thread Joe Perches
On Tue, 2020-06-30 at 19:30 -0700, Eric Dumazet wrote: > On Tue, Jun 30, 2020 at 7:23 PM Herbert Xu > wrote: > > On Tue, Jun 30, 2020 at 07:17:46PM -0700, Eric Dumazet wrote: > > > The main issue of the prior code was the double read of key->keylen in > > > tcp_md5_hash_key(), not that few bytes

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread wenxu
On 7/1/2020 3:02 AM, Cong Wang wrote: > On Mon, Jun 29, 2020 at 7:55 PM wrote: >> From: wenxu >> >> The fragment packets do defrag in act_ct module. The reassembled packet >> over the mtu in the act_mirred. This big packet should be fragmented >> to send out. > This is too brief. Why act_mirred

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread wenxu
On 6/30/2020 11:57 PM, Eric Dumazet wrote: > > On 6/29/20 7:54 PM, we...@ucloud.cn wrote: >> From: wenxu >> >> The fragment packets do defrag in act_ct module. The reassembled packet >> over the mtu in the act_mirred. This big packet should be fragmented >> to send out. >> >> Fixes: b57dc7c13ea9

Re: [PATCH bpf-next] selftests/bpf: Switch test_vmlinux to use hrtimer_range_start_ns.

2020-06-30 Thread Yonghong Song
On 6/30/20 5:10 PM, Hao Luo wrote: Ok, with the help of my colleague Ian Rogers, I think we solved the mystery. Clang actually inlined hrtimer_nanosleep() inside SyS_nanosleep(), so there is no call to that function throughout the path of the nanosleep syscall. I've been looking at the functio

Re: [regression] TCP_MD5SIG on established sockets

2020-06-30 Thread Herbert Xu
On Tue, Jun 30, 2020 at 07:17:46PM -0700, Eric Dumazet wrote: > > The main issue of the prior code was the double read of key->keylen in > tcp_md5_hash_key(), not that few bytes could change under us. > > I used smp_rmb() to ease backports, since old kernels had no > READ_ONCE()/WRITE_ONCE(), but A

Re: [regression] TCP_MD5SIG on established sockets

2020-06-30 Thread Herbert Xu
Eric Dumazet wrote: > > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index > 810cc164f795f8e1e8ca747ed5df51bb20fec8a2..ecc0e3fabce8b03bef823cbfc5c1b0a9e24df124 > 100644 > --- a/net/ipv4/tcp.c > +++ b/net/ipv4/tcp.c > @@ -4034,9 +4034,12 @@ EXPORT_SYMBOL(tcp_md5_hash_skb_data); > int tcp_md5_has

Re: [PATCH net] tcp: md5: add missing memory barriers in tcp_md5_do_add()/tcp_md5_hash_key()

2020-06-30 Thread Mathieu Desnoyers
- On Jun 30, 2020, at 8:55 PM, Eric Dumazet eduma...@google.com wrote: > On Tue, Jun 30, 2020 at 5:53 PM Hideaki Yoshifuji > wrote: >> >> Hi, >> >> 2020年7月1日(水) 8:41 Eric Dumazet : >> : >> > We only want to make sure that in the case key->keylen >> > is changed, cpus in tcp_md5_hash_key() won

RE: [PATCH] igb: reinit_locked() should be called with rtnl_lock

2020-06-30 Thread Kirsher, Jeffrey T
> -Original Message- > From: Francesco Ruggeri > Sent: Monday, June 29, 2020 21:51 > To: Jakub Kicinski > Cc: open list ; netdev > ; intel-wired-...@lists.osuosl.org; David Miller > ; Kirsher, Jeffrey T > Subject: Re: [PATCH] igb: reinit_locked() should be called with rtnl_lock > > > Wo

Re: [PATCH net] net: qrtr: Fix an out of bounds read qrtr_endpoint_post()

2020-06-30 Thread David Miller
From: Dan Carpenter Date: Tue, 30 Jun 2020 14:46:15 +0300 > This code assumes that the user passed in enough data for a > qrtr_hdr_v1 or qrtr_hdr_v2 struct, but it's not necessarily true. If > the buffer is too small then it will read beyond the end. > > Reported-by: Manivannan Sadhasivam > Re

Re: [PATCH net-next v3 0/3] cxgb4: add mirror action support for TC-MATCHALL

2020-06-30 Thread David Miller
From: Rahul Lakkireddy Date: Tue, 30 Jun 2020 18:41:27 +0530 > This series of patches add support to mirror all ingress traffic > for TC-MATCHALL ingress offload. > > Patch 1 adds support to dynamically create a mirror Virtual Interface > (VI) that accepts all mirror ingress traffic when mirror

RE: [EXT] Re: [PATCH net-next] net: ethernet: fec: prevent tx starvation under high rx load

2020-06-30 Thread Andy Duan
From: Tobias Waldekranz Sent: Tuesday, June 30, 2020 7:02 PM > On Tue Jun 30, 2020 at 11:47 AM CEST, Andy Duan wrote: > > Tobias, sorry, I am not running the net tree, I run the linux-imx tree: > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour > > > ce.codeaurora.org%2Fex

Re: [PATCH net] ipv4: tcp: Fix SO_MARK in RST and ACK packet

2020-06-30 Thread Martin KaFai Lau
On Tue, Jun 30, 2020 at 08:45:13PM -0400, Willem de Bruijn wrote: > On Tue, Jun 30, 2020 at 7:46 PM Martin KaFai Lau wrote: > > > > On Tue, Jun 30, 2020 at 07:20:46PM -0400, Willem de Bruijn wrote: > > > On Tue, Jun 30, 2020 at 6:18 PM Martin KaFai Lau wrote: > > > > > > > > When testing a recent

Re: [Patch net] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-06-30 Thread Zefan Li
On 2020/7/1 6:48, Roman Gushchin wrote: > On Tue, Jun 30, 2020 at 03:22:34PM -0700, Cong Wang wrote: >> On Sat, Jun 27, 2020 at 4:41 PM Roman Gushchin wrote: >>> >>> On Fri, Jun 26, 2020 at 10:58:14AM -0700, Cong Wang wrote: On Thu, Jun 25, 2020 at 10:23 PM Cameron Berkenpas wrote: >>>

Re: [PATCH net-next 1/2] amd8111e: Mark PM functions as __maybe_unused

2020-06-30 Thread David Miller
From: Nathan Chancellor Date: Tue, 30 Jun 2020 14:00:33 -0700 > In certain configurations without power management support, the > following warnings happen: > > ../drivers/net/ethernet/amd/amd8111e.c:1623:12: warning: > 'amd8111e_resume' defined but not used [-Wunused-function] > 1623 | static

Re: [PATCH net-next 2/2] pcnet32: Mark PM functions as __maybe_unused

2020-06-30 Thread David Miller
From: Nathan Chancellor Date: Tue, 30 Jun 2020 14:00:34 -0700 > In certain configurations without power management support, the > following warnings happen: > > ../drivers/net/ethernet/amd/pcnet32.c:2928:12: warning: > 'pcnet32_pm_resume' defined but not used [-Wunused-function] > 2928 | static

Re: [PATCH net] tcp: md5: add missing memory barriers in tcp_md5_do_add()/tcp_md5_hash_key()

2020-06-30 Thread David Miller
From: Eric Dumazet Date: Tue, 30 Jun 2020 16:41:01 -0700 > MD5 keys are read with RCU protection, and tcp_md5_do_add() > might update in-place a prior key. > > Normally, typical RCU updates would allocate a new piece > of memory. In this case only key->key and key->keylen might > be updated, and

RE: [net-next v3 15/15] idpf: Introduce idpf driver

2020-06-30 Thread Kirsher, Jeffrey T
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, June 30, 2020 17:59 > To: Kirsher, Jeffrey T > Cc: da...@davemloft.net; Brady, Alan ; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Michael, Alice ; Burra, Phani R > ; Hay, Joshua A ; > Chittim, Madhu ; Li

[PATCH ethtool v4 4/6] Add --json command line argument parsing

2020-06-30 Thread Andrew Lunn
Allow --json to be passed as an option to select JSON output. The option is handled in the same way as --debug, setting a variable in the command context, which can then later be used per option to select JSON outputters. Signed-off-by: Andrew Lunn v3: Make use of json_print to simplify the code.

[PATCH ethtool v4 0/6] ethtool(1) cable test support

2020-06-30 Thread Andrew Lunn
Add the user space side of the ethtool cable test. The TDR output is most useful when fed to some other tool which can visualize the data. So add JSON support, by borrowing code from iproute2. v2: man page fixes. v3: More man page fixes. Use json_print from iproute2. v4: checkpatch cleanup etht

[PATCH ethtool v4 3/6] json_writer/json_print: Import the iproute2 helper code for JSON output

2020-06-30 Thread Andrew Lunn
In general, Linux network tools use JSON for machine readable output. See for example -json for iproute2 and devlink. In order to support JSON output from ethtool, import the iproute2 helper code. Acked-by: Stephen Hemminger Signed-off-by: Andrew Lunn --- Makefile.am | 3 +- json_print.c |

[PATCH ethtool v4 1/6] Add cable test support

2020-06-30 Thread Andrew Lunn
Add support for starting a cable test, and report the results. This code does not follow the usual patterns because of the way the kernel reports the results of the cable test. It can take a number of seconds for cable testing to occur. So the action request messages is immediately acknowledges, a

[PATCH ethtool v4 6/6] ethtool.8.in: Add --json option

2020-06-30 Thread Andrew Lunn
Document the --json option, which the --cable-test and --cable-test-tdr options support. Signed-off-by: Andrew Lunn --- ethtool.8.in | 8 1 file changed, 8 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index 60ca37c..689822e 100644 --- a/ethtool.8.in +++ b/ethtool.8.in @@ -137

[PATCH ethtool v4 2/6] Add cable test TDR support

2020-06-30 Thread Andrew Lunn
Add support for accessing the cable test time domain reflectromatry data. Add a new command --cable-test-tdr, and support for dumping the data which is returned. Signed-off-by: Andrew Lunn --- ethtool.c| 8 ++ netlink/cable_test.c | 296 +++

[PATCH ethtool v4 5/6] ethtool.8.in: Document the cable test commands

2020-06-30 Thread Andrew Lunn
Extend the man page with --cable-test and --cable-test-tdr commands. Reviewed-by: Chris Healy Signed-off-by: Andrew Lunn --- v2: Fixup some grammar/English errors. v3: More grammar/English errors fixed. --- ethtool.8.in | 45 + 1 file changed, 45 ins

Re: [net-next v3 15/15] idpf: Introduce idpf driver

2020-06-30 Thread Jakub Kicinski
On Tue, 30 Jun 2020 23:48:34 + Kirsher, Jeffrey T wrote: > > On Thu, 25 Jun 2020 19:07:37 -0700 Jeff Kirsher wrote: > > > +MODULE_AUTHOR("Intel Corporation, "); > > > > Corporations do not author things, people do. Please drop this. > > Your statement makes sense and I know that we have

Re: [PATCH net] tcp: md5: add missing memory barriers in tcp_md5_do_add()/tcp_md5_hash_key()

2020-06-30 Thread Hideaki Yoshifuji
Hi, 2020年7月1日(水) 8:41 Eric Dumazet : : > We only want to make sure that in the case key->keylen > is changed, cpus in tcp_md5_hash_key() wont try to use > uninitialized data, or crash because key->keylen was > read twice to feed sg_init_one() and ahash_request_set_crypt() > > Fixes: 9ea88a153001 (

Re: [PATCH net] ipv4: tcp: Fix SO_MARK in RST and ACK packet

2020-06-30 Thread Willem de Bruijn
On Tue, Jun 30, 2020 at 7:46 PM Martin KaFai Lau wrote: > > On Tue, Jun 30, 2020 at 07:20:46PM -0400, Willem de Bruijn wrote: > > On Tue, Jun 30, 2020 at 6:18 PM Martin KaFai Lau wrote: > > > > > > When testing a recent kernel (5.6 in our case), the skb->mark of the > > > IPv4 TCP RST pkt does no

Re: [PATCH net] tcp: md5: add missing memory barriers in tcp_md5_do_add()/tcp_md5_hash_key()

2020-06-30 Thread Mathieu Desnoyers
- On Jun 30, 2020, at 8:34 PM, Eric Dumazet eduma...@google.com wrote: > On Tue, Jun 30, 2020 at 5:27 PM Mathieu Desnoyers > wrote: >> >> - On Jun 30, 2020, at 7:50 PM, Eric Dumazet eduma...@google.com wrote: >> >> > On Tue, Jun 30, 2020 at 4:47 PM Mathieu Desnoyers >> > wrote: >> >> >>

Re: [PATCH net] tcp: md5: add missing memory barriers in tcp_md5_do_add()/tcp_md5_hash_key()

2020-06-30 Thread Mathieu Desnoyers
- On Jun 30, 2020, at 7:50 PM, Eric Dumazet eduma...@google.com wrote: > On Tue, Jun 30, 2020 at 4:47 PM Mathieu Desnoyers > wrote: >> >> - On Jun 30, 2020, at 7:41 PM, Eric Dumazet eduma...@google.com wrote: >> >> > MD5 keys are read with RCU protection, and tcp_md5_do_add() >> > might u

Re: ADQ - comparison to aRFS, clarifications on NAPI ID, binding with busy-polling

2020-06-30 Thread Samudrala, Sridhar
On 6/26/2020 5:48 AM, Maxim Mikityanskiy wrote: Thanks a lot for your reply! It was really helpful. I have a few comments, please see below. On 2020-06-24 23:21, Samudrala, Sridhar wrote: On 6/17/2020 6:15 AM, Maxim Mikityanskiy wrote: Hi, I discovered Intel ADQ feature [1] that allows t

[PATCH v4 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

2020-06-30 Thread Andres Beltran
Currently, pointers to guest memory are passed to Hyper-V as transaction IDs in netvsc. In the face of errors or malicious behavior in Hyper-V, netvsc should not expose or trust the transaction IDs returned by Hyper-V to be valid guest memory addresses. Instead, use small integers generated by vmbu

Re: [PATCH RFC net-next] net: mtk_eth_soc: use resolved link config for PCS PHY

2020-06-30 Thread Russell King - ARM Linux admin
On Tue, Jun 30, 2020 at 10:13:08PM +, René van Dorst wrote: > Hi Russel and Sean, > > Quoting Russell King - ARM Linux admin : > > > On Tue, Jun 30, 2020 at 11:15:42AM +0100, Russell King wrote: > > > The SGMII PCS PHY needs to be updated with the link configuration in > > > the mac_link_up()

RE: [net-next v3 15/15] idpf: Introduce idpf driver

2020-06-30 Thread Kirsher, Jeffrey T
> -Original Message- > From: Jakub Kicinski > Sent: Friday, June 26, 2020 11:53 > To: Kirsher, Jeffrey T > Cc: da...@davemloft.net; Brady, Alan ; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Michael, Alice ; Burra, Phani R > ; Hay, Joshua A ; > Chittim, Madhu ; Lin

Re: [PATCH net] tcp: md5: add missing memory barriers in tcp_md5_do_add()/tcp_md5_hash_key()

2020-06-30 Thread Mathieu Desnoyers
- On Jun 30, 2020, at 7:41 PM, Eric Dumazet eduma...@google.com wrote: > MD5 keys are read with RCU protection, and tcp_md5_do_add() > might update in-place a prior key. > > Normally, typical RCU updates would allocate a new piece > of memory. In this case only key->key and key->keylen might

Re: [PATCH net] ipv4: tcp: Fix SO_MARK in RST and ACK packet

2020-06-30 Thread Martin KaFai Lau
On Tue, Jun 30, 2020 at 07:20:46PM -0400, Willem de Bruijn wrote: > On Tue, Jun 30, 2020 at 6:18 PM Martin KaFai Lau wrote: > > > > When testing a recent kernel (5.6 in our case), the skb->mark of the > > IPv4 TCP RST pkt does not carry the mark from sk->sk_mark. It is > > discovered by the bpf@t

Re: [regression] TCP_MD5SIG on established sockets

2020-06-30 Thread Mathieu Desnoyers
- On Jun 30, 2020, at 6:38 PM, Eric Dumazet eduma...@google.com wrote: [...] > > For updates of keys, it seems existing code lacks some RCU care. > > MD5 keys use RCU for lookups/hashes, but the replacement of a key does > not allocate a new piece of memory. How is that RCU-safe ? Based on

Re: [PATCH v5 bpf-next 2/5] bpf: Introduce sleepable BPF programs

2020-06-30 Thread Alexei Starovoitov
On Wed, Jul 01, 2020 at 01:26:44AM +0200, Daniel Borkmann wrote: > On 6/30/20 6:33 AM, Alexei Starovoitov wrote: > [...] > > +/* list of non-sleepable kernel functions that are otherwise > > + * available to attach by bpf_lsm or fmod_ret progs. > > + */ > > +static int check_sleepable_blacklist(uns

Re: [PATCH v2] net: qrtr: free flow in __qrtr_node_release

2020-06-30 Thread David Miller
From: Carl Huang Date: Tue, 30 Jun 2020 14:52:51 +0800 > The flow is allocated in qrtr_tx_wait, but not freed when qrtr node > is released. (*slot) becomes NULL after radix_tree_iter_delete is > called in __qrtr_node_release. The fix is to save (*slot) to a > vairable and then free it. > > This

Re: [PATCH v5 bpf-next 2/5] bpf: Introduce sleepable BPF programs

2020-06-30 Thread Daniel Borkmann
On 6/30/20 6:33 AM, Alexei Starovoitov wrote: [...] +/* list of non-sleepable kernel functions that are otherwise + * available to attach by bpf_lsm or fmod_ret progs. + */ +static int check_sleepable_blacklist(unsigned long addr) +{ +#ifdef CONFIG_BPF_LSM + if (addr == (long)bpf_lsm_tas

Re: [PATCH bpf-next 01/10] tcp: Use a struct to represent a saved_syn

2020-06-30 Thread Martin KaFai Lau
On Sat, Jun 27, 2020 at 10:41:32AM -0700, Eric Dumazet wrote: > On Fri, Jun 26, 2020 at 10:55 AM Martin KaFai Lau wrote: > > > > The total length of the saved syn packet is currently stored in > > the first 4 bytes (u32) and the actual packet data is stored after that. > > > > A latter patch will

Re: [PATCH net] ipv4: tcp: Fix SO_MARK in RST and ACK packet

2020-06-30 Thread Willem de Bruijn
On Tue, Jun 30, 2020 at 6:18 PM Martin KaFai Lau wrote: > > When testing a recent kernel (5.6 in our case), the skb->mark of the > IPv4 TCP RST pkt does not carry the mark from sk->sk_mark. It is > discovered by the bpf@tc that depends on skb->mark to work properly. > The same bpf prog has been w

Re: Maintainers / Kernel Summit 2020 planning kick-off

2020-06-30 Thread Dave Airlie
On Sat, 16 May 2020 at 02:41, Theodore Y. Ts'o wrote: > > [ Feel free to forward this to other Linux kernel mailing lists as > appropriate -- Ted ] > > This year, the Maintainers and Kernel Summit will NOT be held in > Halifax, August 25 -- 28th, as a result of the COVID-19 pandemic. > Instead,

Re: [PATCH net-next 4/8] smsc95xx: remove redundant link status checking

2020-06-30 Thread David Miller
From: Date: Mon, 29 Jun 2020 13:11:47 + > @@ -51,8 +51,6 @@ > #define SUSPEND_ALLMODES (SUSPEND_SUSPEND0 | > SUSPEND_SUSPEND1 | \ Your email client is mangling these patches.

Re: [PATCH v2 00/10] net: improve devres helpers

2020-06-30 Thread David Miller
From: Bartosz Golaszewski Date: Mon, 29 Jun 2020 14:03:36 +0200 > From: Bartosz Golaszewski > > So it seems like there's no support for relaxing certain networking devres > helpers to not require previously allocated structures to also be managed. > However the way mdio devres variants are impl

Re: [PATCH net-next] cxgb4vf: configure ports accessible by the VF

2020-06-30 Thread David Miller
From: Nirranjan Kirubaharan Date: Mon, 29 Jun 2020 17:25:13 +0530 > Find ports accessible by the VF, based on the index of the > mac address stored for the VF in the adapter. If no mac address > is stored for the VF, use the port mask provided by firmware. > > Signed-off-by: Nirranjan Kirubahara

Re: [PATCH] net: cxgb4: fix return error value in t4_prep_fw

2020-06-30 Thread David Miller
From: Li Heng Date: Mon, 29 Jun 2020 18:49:51 +0800 > t4_prep_fw goto bye tag with positive return value when something > bad happened and which can not free resource in adap_init0. > so fix it to return negative value. > > Fixes: 16e47624e76b ("cxgb4: Add new scheme to update T4/T5 firmware") >

Re: [PATCH net-next 0/6] net: qed/qede: license cleanup

2020-06-30 Thread David Miller
From: Alexander Lobakin Date: Mon, 29 Jun 2020 14:05:06 +0300 > QLogic QED drivers source code is dual licensed under > GPL-2.0/BSD-3-Clause. > > Correct already existing but wrong SPDX tags to match the actual > license. > Remove the license boilerplates and replace them with the correct > SPDX

[PATCH net-next] sfc: remove udp_tnl_has_port

2020-06-30 Thread Jakub Kicinski
Nothing seems to have ever been calling this. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/sfc/ef10.c | 23 --- drivers/net/ethernet/sfc/net_driver.h | 2 -- 2 files changed, 25 deletions(-) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet

Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-30 Thread David Miller
From: Alex Elder Date: Tue, 30 Jun 2020 17:41:44 -0500 > My point was to try to isolate the damage done to the IPA device and > driver, rather than killing the system. Excellent, then we are both on the same page.

Re: [Patch net] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-06-30 Thread Roman Gushchin
On Tue, Jun 30, 2020 at 03:22:34PM -0700, Cong Wang wrote: > On Sat, Jun 27, 2020 at 4:41 PM Roman Gushchin wrote: > > > > On Fri, Jun 26, 2020 at 10:58:14AM -0700, Cong Wang wrote: > > > On Thu, Jun 25, 2020 at 10:23 PM Cameron Berkenpas > > > wrote: > > > > > > > > Hello, > > > > > > > > Somew

Re: [PATCH net-next 2/3] bridge: mrp: Add br_mrp_fill_info

2020-06-30 Thread Horatiu Vultur
The 06/30/2020 09:12, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Tue, 30 Jun 2020 15:44:23 +0200 Horatiu Vultur wrote: > > Add the function br_mrp_fill_info which populates the MRP attributes > > regarding the status

Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-30 Thread Alex Elder
On 6/30/20 2:21 PM, David Miller wrote: > From: Alex Elder > Date: Mon, 29 Jun 2020 20:09:58 -0500 > >> But the reason I was >> considering it conditional on a config option is that Qualcomm >> has a crash analysis tool that expects a BUG() call to stop the >> system so its instant state can be c

Re: [PATCH v3] IPv4: Tunnel: Fix effective path mtu calculation

2020-06-30 Thread Nicolas Dichtel
Le 30/06/2020 à 19:33, Jakub Kicinski a écrit : > On Tue, 30 Jun 2020 17:51:41 +0200 Nicolas Dichtel wrote: >> Le 30/06/2020 à 08:22, Jakub Kicinski a écrit : >> [snip] >>> My understanding is that for a while now tunnels are not supposed to use >>> dev->hard_header_len to reserve skb space, and us

Re: [Patch net] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-06-30 Thread Cong Wang
On Sat, Jun 27, 2020 at 4:41 PM Roman Gushchin wrote: > > On Fri, Jun 26, 2020 at 10:58:14AM -0700, Cong Wang wrote: > > On Thu, Jun 25, 2020 at 10:23 PM Cameron Berkenpas wrote: > > > > > > Hello, > > > > > > Somewhere along the way I got the impression that it generally takes > > > those affect

[PATCH net] ipv4: tcp: Fix SO_MARK in RST and ACK packet

2020-06-30 Thread Martin KaFai Lau
When testing a recent kernel (5.6 in our case), the skb->mark of the IPv4 TCP RST pkt does not carry the mark from sk->sk_mark. It is discovered by the bpf@tc that depends on skb->mark to work properly. The same bpf prog has been working in the earlier kernel version. After reverting commit c6af0c

Re: [PATCH RFC net-next] net: mtk_eth_soc: use resolved link config for PCS PHY

2020-06-30 Thread René van Dorst
Hi Russel and Sean, Quoting Russell King - ARM Linux admin : On Tue, Jun 30, 2020 at 11:15:42AM +0100, Russell King wrote: The SGMII PCS PHY needs to be updated with the link configuration in the mac_link_up() call rather than in mac_config(). However, mtk_sgmii_setup_mode_force() programs th

Re: [Patch net] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-06-30 Thread Cong Wang
On Sat, Jun 27, 2020 at 3:59 PM Cameron Berkenpas wrote: > > The box has been up without issue for over 25 hours now. The patch seems > solid. That's great! Thanks for testing!

Re: [PATCH v2 bpf-next] fold test_current_pid_tgid_new_ns into into test_progs

2020-06-30 Thread Carlos Antonio Neira Bustos
On Tue, Jun 23, 2020 at 11:10:51AM -0700, Andrii Nakryiko wrote: > On Tue, Jun 23, 2020 at 5:48 AM Carlos Neira wrote: > > > > folds tests from test_current_pid_tgid_new_ns into test_progs. > > > > Signed-off-by: Carlos Neira > > --- > > tools/testing/selftests/bpf/Makefile | 3 +- > >

Re: [PATCH v5 bpf-next 2/5] bpf: Introduce sleepable BPF programs

2020-06-30 Thread Paul E. McKenney
On Mon, Jun 29, 2020 at 09:33:40PM -0700, Alexei Starovoitov wrote: > From: Alexei Starovoitov > > Introduce sleepable BPF programs that can request such property for themselves > via BPF_F_SLEEPABLE flag at program load time. In such case they will be able > to use helpers like bpf_copy_from_use

Re: [PATCH v1] Bluetooth: Fix kernel oops triggered by hci_adv_monitors_clear()

2020-06-30 Thread Miao-chen Chou
Hi Marcel, hci_unregister_dev() is invoked when the controller is intended to be removed by btusb driver. In other words, there should not be any activity on hdev's workqueue, so the destruction of the workqueue should be the first thing to do to prevent the clear helpers from issuing any work. So

Re: [PATCH bpf-next] selftests/bpf: Switch test_vmlinux to use hrtimer_range_start_ns.

2020-06-30 Thread Andrii Nakryiko
On Tue, Jun 30, 2020 at 1:47 PM Hao Luo wrote: > > The test_vmlinux test uses hrtimer_nanosleep as hook to test tracing > programs. But it seems Clang may have done an aggressive optimization, > causing fentry and kprobe to not hook on this function properly on a > Clang build kernel. > > A possib

Re: pull-request: bpf 2020-06-30

2020-06-30 Thread David Miller
From: Daniel Borkmann Date: Tue, 30 Jun 2020 23:00:08 +0200 > The following pull-request contains BPF updates for your *net* tree. > > We've added 28 non-merge commits during the last 9 day(s) which contain > a total of 35 files changed, 486 insertions(+), 232 deletions(-). > > The main changes

Re: [regression] TCP_MD5SIG on established sockets

2020-06-30 Thread Mathieu Desnoyers
- On Jun 30, 2020, at 4:56 PM, Eric Dumazet eduma...@google.com wrote: > On Tue, Jun 30, 2020 at 1:44 PM David Miller wrote: >> >> From: Eric Dumazet >> Date: Tue, 30 Jun 2020 13:39:27 -0700 >> >> > The (C) & (B) case are certainly doable. >> > >> > A) case is more complex, I have no idea of

[PATCH net-next 1/2] amd8111e: Mark PM functions as __maybe_unused

2020-06-30 Thread Nathan Chancellor
In certain configurations without power management support, the following warnings happen: ../drivers/net/ethernet/amd/amd8111e.c:1623:12: warning: 'amd8111e_resume' defined but not used [-Wunused-function] 1623 | static int amd8111e_resume(struct device *dev_d) |^~~

Re: [RFC PATCH 07/11] net: Introduce global queues

2020-06-30 Thread Jonathan Lemon
On Wed, Jun 24, 2020 at 10:17:46AM -0700, Tom Herbert wrote: > Global queues, or gqids, are an abstract representation of NIC > device queues. They are global in the sense that the each gqid > can be map to a queue in each device, i.e. if there are multiple > devices in the system, a gqid can map t

[PATCH net-next 2/2] pcnet32: Mark PM functions as __maybe_unused

2020-06-30 Thread Nathan Chancellor
In certain configurations without power management support, the following warnings happen: ../drivers/net/ethernet/amd/pcnet32.c:2928:12: warning: 'pcnet32_pm_resume' defined but not used [-Wunused-function] 2928 | static int pcnet32_pm_resume(struct device *device_d) |^

pull-request: bpf 2020-06-30

2020-06-30 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. We've added 28 non-merge commits during the last 9 day(s) which contain a total of 35 files changed, 486 insertions(+), 232 deletions(-). The main changes are: 1) Fix an incorrect verifier branch elimination for PTR_

Re: [PATCH v5 bpf-next 1/5] bpf: Remove redundant synchronize_rcu.

2020-06-30 Thread Paul E. McKenney
On Mon, Jun 29, 2020 at 09:33:39PM -0700, Alexei Starovoitov wrote: > From: Alexei Starovoitov > > bpf_free_used_maps() or close(map_fd) will trigger map_free callback. > bpf_free_used_maps() is called after bpf prog is no longer executing: > bpf_prog_put->call_rcu->bpf_prog_free->bpf_free_used_m

Re: [regression] TCP_MD5SIG on established sockets

2020-06-30 Thread David Miller
From: Eric Dumazet Date: Tue, 30 Jun 2020 13:39:27 -0700 > The (C) & (B) case are certainly doable. > > A) case is more complex, I have no idea of breakages of various TCP > stacks if a flow got SACK > at some point (in 3WHS) but suddenly becomes Reno. I agree that C and B are the easiest to im

Re: [PATCH net-next v2] tcp: call tcp_ack_tstamp() when not fully acked

2020-06-30 Thread David Miller
From: Yousuk Seung Date: Tue, 30 Jun 2020 09:49:33 -0700 > When skb is coalesced tcp_ack_tstamp() still needs to be called when not > fully acked in tcp_clean_rtx_queue(), otherwise SCM_TSTAMP_ACK > timestamps may never be fired. Since the original patch series had > dependent commits, this patch

Re: [regression] TCP_MD5SIG on established sockets

2020-06-30 Thread Mathieu Desnoyers
- On Jun 30, 2020, at 4:30 PM, Eric Dumazet eduma...@google.com wrote: > On Tue, Jun 30, 2020 at 1:21 PM David Miller wrote: >> >> From: Linus Torvalds >> Date: Tue, 30 Jun 2020 12:43:21 -0700 >> >> > If you're not willing to do the work to fix it, I will revert that >> > commit. >> >> Pleas

  1   2   3   4   >