[net-next v3 7/8] i40e: Add support for 5Gbps cards

2020-06-25 Thread Jeff Kirsher
From: Aleksandr Loktionov Make possible for the i40e driver to bind to the new v710 for 5GBASE-T NICs. Signed-off-by: Aleksandr Loktionov Signed-off-by: Arkadiusz Kubalewski Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_common.c | 3 +++ drive

[net-next v3 0/8][pull request] 40GbE Intel Wired LAN Driver Updates 2020-06-25

2020-06-25 Thread Jeff Kirsher
This series contains updates to i40e driver and removes the individual driver versions from all of the Intel wired LAN drivers. Shiraz moves the client header so that it can easily be shared between the i40e LAN driver and i40iw RDMA driver. Jesse cleans up the unused defines, since they are just

[net-next v3 1/8] i40e: Move client header location

2020-06-25 Thread Jeff Kirsher
From: Shiraz Saleem Move i40e_client.h to include/linux/net/intel/* since its shared between i40iw and i40e. Signed-off-by: Shiraz Saleem Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/infiniband/hw/i40iw/Makefile| 1 - drivers/infiniband/hw/i40i

[net-next v3 8/8] i40e: Remove scheduling while atomic possibility

2020-06-25 Thread Jeff Kirsher
From: Aleksandr Loktionov In some occasions task held spinlock (mac_filter_hash_lock), while being rescheduled due to admin queue mutex_lock. The struct i40e_spinlock asq_spinlock, which later expands to struct mutex spinlock. Moved i40e_aq_set_vsi_multicast_promiscuous(), i40e_aq_set_vsi_unica

[net-next v3 4/8] i40e: detect and log info about pre-recovery mode

2020-06-25 Thread Jeff Kirsher
From: Piotr Kwapulinski Detect and log information about pre-recovery mode when firmware transitions to a recovery mode. When a firmware transitions to a recovery mode it stores a number of unexpected EMP resets in one of its registers. The number of EMP resets ranging from 0x21 to 0x2A indicates

[net-next v3 5/8] i40e: Add a check to see if MFS is set

2020-06-25 Thread Jeff Kirsher
From: Todd Fujinaka A customer was chain-booting to provision his systems and one of the steps was setting MFS. MFS isn't cleared by normal warm reboots (clearing requires a GLOBR) and there was no indication of why Jumbo Frame receives were failing. Add a warning if MFS is set to anything lower

[net-next v3 3/8] i40e: make PF wait reset loop reliable

2020-06-25 Thread Jeff Kirsher
From: Piotr Kwapulinski Use jiffies to limit max waiting time for PF reset to succeed. Previous wait loop was unreliable. It required unreasonably long time to wait for PF reset after reboot when NIC was about to enter recovery mode Reviewed-by: Aleksandr Loktionov Signed-off-by: Piotr Kwapulin

[net-next v3 6/8] net/intel: remove driver versions from Intel drivers

2020-06-25 Thread Jeff Kirsher
As with other networking drivers, remove the unnecessary driver version from the Intel drivers. The ethtool driver information and module version will then report the kernel version instead. For ixgbe, i40e and ice drivers, the driver passes the driver version to the firmware to confirm that we ar

Re: [bpf PATCH v2 3/3] bpf, sockmap: Add ingres skb tests that utilize merge skbs

2020-06-25 Thread Martin KaFai Lau
On Thu, Jun 25, 2020 at 04:13:38PM -0700, John Fastabend wrote: > Add a test to check strparser merging skbs is working. Acked-by: Martin KaFai Lau

Re: [bpf PATCH v2 2/3] bpf, sockmap: RCU dereferenced psock may be used outside RCU block

2020-06-25 Thread Martin KaFai Lau
On Thu, Jun 25, 2020 at 04:13:18PM -0700, John Fastabend wrote: > If an ingress verdict program specifies message sizes greater than > skb->len and there is an ENOMEM error due to memory pressure we > may call the rcv_msg handler outside the strp_data_ready() caller > context. This is because on an

Re: [bpf PATCH v2 1/3] bpf, sockmap: RCU splat with redirect and strparser error or TLS

2020-06-25 Thread Martin KaFai Lau
On Thu, Jun 25, 2020 at 04:12:59PM -0700, John Fastabend wrote: > There are two paths to generate the below RCU splat the first and > most obvious is the result of the BPF verdict program issuing a > redirect on a TLS socket (This is the splat shown below). Unlike > the non-TLS case the caller of t

[PATCH mlx5-next 3/3] net/mlx5: kTLS, Improve TLS params layout structures

2020-06-25 Thread Saeed Mahameed
From: Tariq Toukan Add explicit WQE segment structures for the TLS static and progress params. According to the HW spec, TISN is not part of the progress params context, take it out of it. Rename the control segment tisn field as it could hold either a TIS or a TIR number. Signed-off-by: Tariq T

[PATCH mlx5-next 2/3] net/mlx5: Avoid eswitch header inclusion in fs core layer

2020-06-25 Thread Saeed Mahameed
From: Parav Pandit Flow steering core layer is independent of the eswitch layer. Hence avoid fs_core dependency on eswitch. Fixes: 328edb499f99 ("net/mlx5: Split FDB fast path prio to multiple namespaces") Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mel

[PATCH mlx5-next 1/3] net/mlx5: Avoid RDMA file inclusion in core driver

2020-06-25 Thread Saeed Mahameed
From: Parav Pandit mlx5 cq.h does not depend on RDMA verbs. Remove RDMA verbs file inclusion. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- include/linux/mlx5/cq.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/mlx5/cq.h b/include/linux/mlx5/cq.h index b5a939

[PATCH v2 net] ionic: update the queue count on open

2020-06-25 Thread Shannon Nelson
Let the network stack know the real number of queues that we are using. v2: added error checking Fixes: 49d3b493673a ("ionic: disable the queues on link down") Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 8 1 file changed, 8 insertions(+) diff -

[PATCH mlx5-next 0/3] mlx5 next updates 2020-06-25

2020-06-25 Thread Saeed Mahameed
This small patchset includes 3 patches to mlx5-next branch. 1) Include directives cleanup from Parav. 2) TLS Hardware layouts improvements from Tariq. Thanks, Saeed. -- Parav Pandit (2): net/mlx5: Avoid RDMA file inclusion in core driver net/mlx5: Avoid eswitch header inclusion in fs core l

Re: [PATCH bpf-next v3 4/4] selftests/bpf: Test updating flow_dissector link with same program

2020-06-25 Thread Martin KaFai Lau
On Thu, Jun 25, 2020 at 04:13:57PM +0200, Jakub Sitnicki wrote: > This case, while not particularly useful, is worth covering because we > expect the operation to succeed as opposed when re-attaching the same > program directly with PROG_ATTACH. > > While at it, update the tests summary that fell

Re: [PATCH bpf-next v3 3/4] bpf, netns: Keep a list of attached bpf_link's

2020-06-25 Thread Martin KaFai Lau
On Thu, Jun 25, 2020 at 04:13:56PM +0200, Jakub Sitnicki wrote: > To support multi-prog link-based attachments for new netns attach types, we > need to keep track of more than one bpf_link per attach type. Hence, > convert net->bpf.links into a list, that currently can be either empty or > have jus

Re: [PATCH bpf-next v3 2/4] bpf, netns: Keep attached programs in bpf_prog_array

2020-06-25 Thread Martin KaFai Lau
On Thu, Jun 25, 2020 at 04:13:55PM +0200, Jakub Sitnicki wrote: > Prepare for having multi-prog attachments for new netns attach types by > storing programs to run in a bpf_prog_array, which is well suited for > iterating over programs and running them in sequence. > > After this change bpf(PROG_Q

Re: [Patch net] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-06-25 Thread Cameron Berkenpas
Hello, Somewhere along the way I got the impression that it generally takes those affected hours before their systems lock up. I'm (generally) able to reproduce this issue much faster than that. Regardless, I can help test. Are there any patches that need testing or is this all still pending

Re: [PATCH net-next v2] xfrm: introduce oseq-may-wrap flag

2020-06-25 Thread Steffen Klassert
On Sat, May 30, 2020 at 02:39:12PM +0200, Petr Vaněk wrote: > RFC 4303 in section 3.3.3 suggests to disable anti-replay for manually > distributed ICVs in which case the sender does not need to monitor or > reset the counter. However, the sender still increments the counter and > when it reaches th

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-25 Thread Christian Borntraeger
On 26.06.20 04:54, Luis Chamberlain wrote: > On Wed, Jun 24, 2020 at 08:37:55PM +0200, Christian Borntraeger wrote: >> >> >> On 24.06.20 20:32, Christian Borntraeger wrote: >> [...]> >>> So the translations look correct. But your change is actually a sematic >>> change >>> if(ret) will only tr

Re: [PATCHv2 ipsec] xfrm: policy: match with both mark and mask on user interfaces

2020-06-25 Thread Steffen Klassert
On Mon, Jun 22, 2020 at 04:40:29PM +0800, Xin Long wrote: > In commit ed17b8d377ea ("xfrm: fix a warning in xfrm_policy_insert_list"), > it would take 'priority' to make a policy unique, and allow duplicated > policies with different 'priority' to be added, which is not expected > by userland, as T

RE: [PATCH iproute2-next 0/4] devlink: Support get,set mac address of a port function

2020-06-25 Thread Parav Pandit
Hi David, > From: Parav Pandit > Sent: Tuesday, June 23, 2020 4:14 PM > > Currently ip link set dev vfhas few below > limitations. > > 1. Command is limited to set VF parameters only. > It cannot set the default MAC address for the PCI PF. > > 2. It can be set only on system where PCI SR-

Re: [PATCH iproute2-next v1 1/4] rdma: update uapi headers

2020-06-25 Thread David Ahern
On 6/25/20 1:15 AM, Leon Romanovsky wrote: > On Wed, Jun 24, 2020 at 01:40:09PM +0300, Leon Romanovsky wrote: >> From: Maor Gottlieb >> >> Update rdma_netlink.h file upto kernel commit ba1f4991cc55 >> ("RDMA: Add support to dump resource tracker in RAW format") > > David, > > The SHA was changed

[PATCH net-next] bonding: Remove extraneous parentheses in bond_setup

2020-06-25 Thread Nathan Chancellor
Clang warns: drivers/net/bonding/bond_main.c:4657:23: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP)) ^ drivers/net/bonding/bond_main.c:4681:23: warning:

Re: [net-next v3 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-06-25

2020-06-25 Thread Joe Perches
On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > This series introduces both the Intel Ethernet Common Module and the Intel > Data Plane Function. The patches also incorporate extended features and > functionality added in the virtchnl.h file. Overall, perhaps the code wraps rather a lot

Re: [net-next v3 15/15] idpf: Introduce idpf driver

2020-06-25 Thread Joe Perches
On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alan Brady > > Utilizes the Intel Ethernet Common Module and provides > a device specific implementation for data plane devices. [] > diff --git a/drivers/net/ethernet/intel/idpf/idpf_main.c > b/drivers/net/ethernet/intel/idpf/idpf_m

Re: [net-next v3 14/15] iecm: Add iecm to the kernel build system

2020-06-25 Thread Joe Perches
On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alice Michael [] > diff --git a/Documentation/networking/device_drivers/intel/iecm.rst > b/Documentation/networking/device_drivers/intel/iecm.rst [] > @@ -0,0 +1,93 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + > +

Re: [net-next v3 13/15] iecm: Add ethtool

2020-06-25 Thread Joe Perches
On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alice Michael > > Implement ethtool interface for the common module. [] > diff --git a/drivers/net/ethernet/intel/iecm/iecm_ethtool.c > b/drivers/net/ethernet/intel/iecm/iecm_ethtool.c [] > +/* Stats associated with a Tx queue */ > +

Re: [net-next v3 12/15] iecm: Add singleq TX/RX

2020-06-25 Thread Joe Perches
On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alice Michael > > Implement legacy single queue model for TX/RX flows. [] > diff --git a/drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c > b/drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c [] > @@ -145,7 +508,63 @@ static voi

Re: [net-next v3 07/15] iecm: Implement virtchnl commands

2020-06-25 Thread Joe Perches
On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alice Michael > > Implement various virtchnl commands that enable > communication with hardware. [] > diff --git a/drivers/net/ethernet/intel/iecm/iecm_virtchnl.c > b/drivers/net/ethernet/intel/iecm/iecm_virtchnl.c [] > @@ -751,7 +14

Re: [net-next v3 06/15] iecm: Implement mailbox functionality

2020-06-25 Thread Joe Perches
On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alice Michael > > Implement mailbox setup, take down, and commands. [] > diff --git a/drivers/net/ethernet/intel/iecm/iecm_controlq.c > b/drivers/net/ethernet/intel/iecm/iecm_controlq.c [] > @@ -73,7 +142,74 @@ enum iecm_status iecm_

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-25 Thread Luis Chamberlain
On Wed, Jun 24, 2020 at 08:37:55PM +0200, Christian Borntraeger wrote: > > > On 24.06.20 20:32, Christian Borntraeger wrote: > [...]> > > So the translations look correct. But your change is actually a sematic > > change > > if(ret) will only trigger if there is an error > > if (KWIFEXITED(ret)

Re: Request for net merge into net-next

2020-06-25 Thread David Miller
From: David Miller Date: Thu, 25 Jun 2020 12:21:37 -0700 (PDT) > From: Paolo Abeni > Date: Thu, 25 Jun 2020 11:16:47 +0200 > >> We have a few net-next MPTCP changes depending on: >> >> commit 9e365ff576b7c1623bbc5ef31ec652c533e2f65e >> mptcp: drop MP_JOIN request sock on syn cookies >> >>

Re: [net-next v3 05/15] iecm: Add basic netdevice functionality

2020-06-25 Thread Joe Perches
On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alice Michael > > This implements probe, interface up/down, and netdev_ops. trivial notes: > diff --git a/drivers/net/ethernet/intel/iecm/iecm_lib.c > b/drivers/net/ethernet/intel/iecm/iecm_lib.c [] > @@ -194,7 +298,24 @@ static in

Re: [PATCH bpf-next 1/4] bpf: add BPF_CGROUP_INET_SOCK_RELEASE hook

2020-06-25 Thread kernel test robot
Hi Stanislav, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf/master] [also build test ERROR on net/master net-next/master v5.8-rc2 next-20200625] [cannot apply to bpf-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [net-next v3 04/15] iecm: Common module introduction and function stubs

2020-06-25 Thread Joe Perches
On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alice Michael > > This introduces function stubs for the framework of the common > module. trivia: > diff --git a/drivers/net/ethernet/intel/iecm/iecm_lib.c > b/drivers/net/ethernet/intel/iecm/iecm_lib.c [] > @@ -0,0 +1,407 @@ > +/

[net-next v3 02/15] iecm: Add framework set of header files

2020-06-25 Thread Jeff Kirsher
From: Alice Michael Introduces the framework of data for the driver common module. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald Skidmore Reviewe

[net-next v3 14/15] iecm: Add iecm to the kernel build system

2020-06-25 Thread Jeff Kirsher
From: Alice Michael This introduces iecm as a module to the kernel, and adds relevant documentation. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald

[net-next v3 11/15] iecm: Add splitq TX/RX

2020-06-25 Thread Jeff Kirsher
From: Alice Michael Implement main TX/RX flows for split queue model. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald Skidmore Reviewed-by: Jesse B

[net-next v3 12/15] iecm: Add singleq TX/RX

2020-06-25 Thread Jeff Kirsher
From: Alice Michael Implement legacy single queue model for TX/RX flows. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald Skidmore Reviewed-by: Jess

[net-next v3 15/15] idpf: Introduce idpf driver

2020-06-25 Thread Jeff Kirsher
From: Alan Brady Utilizes the Intel Ethernet Common Module and provides a device specific implementation for data plane devices. Signed-off-by: Alan Brady Signed-off-by: Alice Michael Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kuma

[net-next v3 10/15] iecm: Deinit vport

2020-06-25 Thread Jeff Kirsher
From: Alice Michael Implement vport take down and release its queue resources. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald Skidmore Reviewed-by

[net-next v3 08/15] iecm: Implement vector allocation

2020-06-25 Thread Jeff Kirsher
From: Alice Michael This allocates PCI vectors and maps to interrupt routines. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald Skidmore Reviewed-by

[net-next v3 09/15] iecm: Init and allocate vport

2020-06-25 Thread Jeff Kirsher
From: Alice Michael Initialize vport and allocate queue resources. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald Skidmore Reviewed-by: Jesse Bran

[net-next v3 13/15] iecm: Add ethtool

2020-06-25 Thread Jeff Kirsher
From: Alice Michael Implement ethtool interface for the common module. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald Skidmore Reviewed-by: Jesse

[net-next v3 03/15] iecm: Add TX/RX header files

2020-06-25 Thread Jeff Kirsher
From: Alice Michael Introduces the data for the TX/RX paths for use by the common module. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald Skidmore

[net-next v3 05/15] iecm: Add basic netdevice functionality

2020-06-25 Thread Jeff Kirsher
From: Alice Michael This implements probe, interface up/down, and netdev_ops. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald Skidmore Reviewed-by:

[net-next v3 07/15] iecm: Implement virtchnl commands

2020-06-25 Thread Jeff Kirsher
From: Alice Michael Implement various virtchnl commands that enable communication with hardware. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald Ski

[net-next v3 04/15] iecm: Common module introduction and function stubs

2020-06-25 Thread Jeff Kirsher
From: Alice Michael This introduces function stubs for the framework of the common module. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald Skidmore

[net-next v3 01/15] virtchnl: Extend AVF ops

2020-06-25 Thread Jeff Kirsher
From: Alice Michael This implements the next generation of virtchnl ops which enable greater functionality and capabilities. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Li

[net-next v3 06/15] iecm: Implement mailbox functionality

2020-06-25 Thread Jeff Kirsher
From: Alice Michael Implement mailbox setup, take down, and commands. Signed-off-by: Alice Michael Signed-off-by: Alan Brady Signed-off-by: Phani Burra Signed-off-by: Joshua Hay Signed-off-by: Madhu Chittim Signed-off-by: Pavan Kumar Linga Reviewed-by: Donald Skidmore Reviewed-by: Jesse B

[net-next v3 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-06-25

2020-06-25 Thread Jeff Kirsher
This series introduces both the Intel Ethernet Common Module and the Intel Data Plane Function. The patches also incorporate extended features and functionality added in the virtchnl.h file. The format of the series flow is to add the data set, then introduce function stubs and finally introduce

Re: [GIT] Networking

2020-06-25 Thread pr-tracker-bot
The pull request you sent on Thu, 25 Jun 2020 16:43:48 -0700 (PDT): > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4a21185cda0fbb860580eeeb4f1a70a9cda332a4 Thank you! -- Deet-doot-dot, I am

Re: [PATCH bpf-next v3 1/4] flow_dissector: Pull BPF program assignment up to bpf-netns

2020-06-25 Thread Martin KaFai Lau
On Thu, Jun 25, 2020 at 04:13:54PM +0200, Jakub Sitnicki wrote: > Prepare for using bpf_prog_array to store attached programs by moving out > code that updates the attached program out of flow dissector. > > Managing bpf_prog_array is more involved than updating a single bpf_prog > pointer. This w

[PATCH] net: phy: mscc: fix ptr_ret.cocci warnings

2020-06-25 Thread kernel test robot
From: kernel test robot drivers/net/phy/mscc/mscc_ptp.c:1496:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 7d272e63e097 ("net: phy: mscc: timestamping and PHC support") CC: Antoine

Re: [PATCH net-next 2/5] ipv6: IOAM tunnel decapsulation

2020-06-25 Thread Tom Herbert
On Thu, Jun 25, 2020 at 10:56 AM Justin Iurman wrote: > > >> Implement the IOAM egress behavior. > >> > >> According to RFC 8200: > >> "Extension headers (except for the Hop-by-Hop Options header) are not > >> processed, inserted, or deleted by any node along a packet's delivery > >> path, until

[PATCH v2 bpf-next 3/4] bpf: allow %pB in bpf_seq_printf() and bpf_trace_printk()

2020-06-25 Thread Song Liu
This makes it easy to dump stack trace in text. Signed-off-by: Song Liu --- kernel/trace/bpf_trace.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 65fa62723e2f8..1cb90b0868817 100644 --- a/kernel/trace/b

[PATCH v2 bpf-next 0/4] bpf: introduce bpf_get_task_stack()

2020-06-25 Thread Song Liu
This set introduces a new helper bpf_get_task_stack(). The primary use case is to dump all /proc/*/stack to seq_file via bpf_iter__task. A few different approaches have been explored and compared: 1. A simple wrapper around stack_trace_save_tsk(), as v1 [1]. This approach introduces new s

[PATCH v2 bpf-next 1/4] perf: export get/put_chain_entry()

2020-06-25 Thread Song Liu
This would be used by bpf stack mapo. Signed-off-by: Song Liu --- include/linux/perf_event.h | 2 ++ kernel/events/callchain.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index b4bb32082342c..00ab5efa38334 1006

[PATCH v2 bpf-next 2/4] bpf: introduce helper bpf_get_task_stak()

2020-06-25 Thread Song Liu
Introduce helper bpf_get_task_stack(), which dumps stack trace of given task. This is different to bpf_get_stack(), which gets stack track of current task. One potential use case of bpf_get_task_stack() is to call it from bpf_iter__task and dump all /proc//stack to a seq_file. bpf_get_task_stack()

[PATCH v2 bpf-next 4/4] selftests/bpf: add bpf_iter test with bpf_get_task_stack()

2020-06-25 Thread Song Liu
The new test is similar to other bpf_iter tests. Signed-off-by: Song Liu --- .../selftests/bpf/prog_tests/bpf_iter.c | 17 ++ .../selftests/bpf/progs/bpf_iter_task_stack.c | 60 +++ 2 files changed, 77 insertions(+) create mode 100644 tools/testing/selftests/bpf/progs/

linux-next: manual merge of the bpf-next tree with the bpf tree

2020-06-25 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the bpf-next tree got a conflict in: tools/testing/selftests/bpf/progs/bpf_iter_netlink.c between commits: 9c82a63cf370 ("libbpf: Fix CO-RE relocs against .text section") 647b502e3d54 ("selftests/bpf: Refactor some net macros to bpf_tracing_net.h") fro

[GIT] Networking

2020-06-25 Thread David Miller
1) Don't insert ESP trailer twice in IPSEC code, from Huy Nguyen. 2) The default crypto algorithm selection in Kconfig for IPSEC is out of touch with modern reality, fix this up. From Eric Biggers. 3) bpftool is missing an entry for BPF_MAP_TYPE_RINGBUF, from Andrii Nakryiko. 4) Missing

Re: [PATCH RESEND net-next] sch_cake: add RFC 8622 LE PHB support to CAKE diffserv handling

2020-06-25 Thread David Miller
From: Toke Høiland-Jørgensen Date: Thu, 25 Jun 2020 22:18:00 +0200 > From: Kevin Darbyshire-Bryant > > Change tin mapping on diffserv3, 4 & 8 for LE PHB support, in essence > making LE a member of the Bulk tin. > > Bulk has the least priority and minimum of 1/16th total bandwidth in the > face

Re: [PATCH v2] rds: transport module should be auto loaded when transport is set

2020-06-25 Thread David Miller
From: rao.sho...@oracle.com Date: Thu, 25 Jun 2020 13:46:00 -0700 > From: Rao Shoaib > > This enhancement auto loads transport module when the transport > is set via SO_RDS_TRANSPORT socket option. > > Reviewed-by: Ka-Cheong Poon > Reviewed-by: Håkon Bugge > Signed-off-by: Rao Shoaib > Signe

[PATCH bpf-next 2/2] selftests/bpf: test auto-load disabling logic for BPF programs

2020-06-25 Thread Andrii Nakryiko
Validate that BPF object with broken (in multiple ways) BPF program can still be successfully loaded, if that broken BPF program is disabled. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/autoload.c | 41 +++ .../selftests/bpf/progs/test_autoload.c |

[PATCH bpf-next 0/2] Support disabling auto-loading of BPF programs

2020-06-25 Thread Andrii Nakryiko
Add ability to turn off default auto-loading of each BPF program by libbpf on BPF object load. This is the feature that allows BPF applications to have optional functionality, which is only excercised on kernel that support necessary features, while falling back to reduced/less performant functiona

[PATCH bpf-next 1/2] libbpf: support disabling auto-loading BPF programs

2020-06-25 Thread Andrii Nakryiko
Currently, bpf_object__load() (and by induction skeleton's load), will always attempt to prepare, relocate, and load into kernel every single BPF program found inside the BPF object file. This is often convenient and the right thing to do and what users expect. But there are plenty of cases (espec

Re: [PATCH net 0/3] sched: A couple of fixes for sch_cake

2020-06-25 Thread David Miller
From: Toke Høiland-Jørgensen Date: Thu, 25 Jun 2020 22:12:06 +0200 > This series contains a couple of fixes for diffserv handling in sch_cake that > provide a nice speedup (with a somewhat pedantic nit fix tacked on to the > end). > > Not quite sure about whether this should go to stable; it do

Re: [PATCH net-next 0/8] net: phy: mscc: multiple improvements

2020-06-25 Thread David Miller
From: Antoine Tenart Date: Thu, 25 Jun 2020 17:42:03 +0200 > This series contains various improvements to the MSCC PHY driver, fixing > sparse and smatch warnings, using functions provided by the PHY core, > and improving the driver consistency and maintenance. > > I don't think any of those imp

Re: [PATCH net] ethtool: fix error handling in linkstate_prepare_data()

2020-06-25 Thread David Miller
From: Michal Kubecek Date: Thu, 25 Jun 2020 00:09:08 +0200 (CEST) > When getting SQI or maximum SQI value fails in linkstate_prepare_data(), we > must not return without calling ethnl_ops_complete(dev) as that could > result in imbalance between ethtool_ops ->begin() and ->complete() calls. > >

Re: [PATCH net 0/4] napi_gro_receive caller return value cleanups

2020-06-25 Thread David Miller
From: "Jason A. Donenfeld" Date: Wed, 24 Jun 2020 16:06:02 -0600 > In 6570bc79c0df ("net: core: use listified Rx for GRO_NORMAL in > napi_gro_receive()"), the GRO_NORMAL case stopped calling > netif_receive_skb_internal, checking its return value, and returning > GRO_DROP in case it failed. Inste

[bpf PATCH v2 3/3] bpf, sockmap: Add ingres skb tests that utilize merge skbs

2020-06-25 Thread John Fastabend
Add a test to check strparser merging skbs is working. Signed-off-by: John Fastabend --- .../selftests/bpf/progs/test_sockmap_kern.h|8 +++- tools/testing/selftests/bpf/test_sockmap.c | 18 ++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git

[bpf PATCH v2 2/3] bpf, sockmap: RCU dereferenced psock may be used outside RCU block

2020-06-25 Thread John Fastabend
If an ingress verdict program specifies message sizes greater than skb->len and there is an ENOMEM error due to memory pressure we may call the rcv_msg handler outside the strp_data_ready() caller context. This is because on an ENOMEM error the strparser will retry from a workqueue. The caller curr

[bpf PATCH v2 1/3] bpf, sockmap: RCU splat with redirect and strparser error or TLS

2020-06-25 Thread John Fastabend
There are two paths to generate the below RCU splat the first and most obvious is the result of the BPF verdict program issuing a redirect on a TLS socket (This is the splat shown below). Unlike the non-TLS case the caller of the *strp_read() hooks does not wrap the call in a rcu_read_lock/unlock.

[bpf PATCH v2 0/3] Sockmap RCU splat fix

2020-06-25 Thread John Fastabend
Fix a splat introduced by recent changes to avoid skipping ingress policy when kTLS is enabled. The RCU splat was introduced because in the non-TLS case the caller is wrapped in an rcu_read_lock/unlock. But, in the TLS case we have a reference to the psock and the caller did not wrap its call in rc

Re: [PATCH net] vxlan: fix last fdb index during dump of fdb with nhid

2020-06-25 Thread David Miller
From: Roopa Prabhu Date: Wed, 24 Jun 2020 14:02:36 -0700 > From: Roopa Prabhu > > This patch fixes last saved fdb index in fdb dump handler when > handling fdb's with nhid. > > Fixes: 1274e1cc4226 ("vxlan: ecmp support for mac fdb entries") > Signed-off-by: Roopa Prabhu Applied, thanks Roopa

Re: [PATCH net] sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket

2020-06-25 Thread David Miller
From: Marcelo Ricardo Leitner Date: Wed, 24 Jun 2020 17:34:18 -0300 > If a socket is set ipv6only, it will still send IPv4 addresses in the > INIT and INIT_ACK packets. This potentially misleads the peer into using > them, which then would cause association termination. > > The fix is to not add

Re: [PATCH net] tc-testing: avoid action cookies with odd length.

2020-06-25 Thread David Miller
From: Briana Oursler Date: Wed, 24 Jun 2020 12:29:14 -0700 > Update odd length cookie hexstrings in csum.json, tunnel_key.json and > bpf.json to be even length to comply with check enforced in commit > 0149dabf2a1b ("tc: m_actions: check cookie hexstring len") in iproute2. > > Signed-off-by: Bri

Re: [PATCH net 0/2] tcp_cubic: fix spurious HYSTART_DELAY on RTT decrease

2020-06-25 Thread David Miller
From: Neal Cardwell Date: Wed, 24 Jun 2020 12:42:01 -0400 > This series fixes a long-standing bug in the TCP CUBIC > HYSTART_DELAY mechanim recently reported by Mirja Kuehlewind. The > code can cause a spurious exit of slow start in some particular > cases: upon an RTT decrease that happens on th

Re: [PATCH net] ionic: update the queue count on open

2020-06-25 Thread Shannon Nelson
On 6/25/20 3:57 PM, Jakub Kicinski wrote: On Thu, 25 Jun 2020 13:12:15 -0700 Shannon Nelson wrote: Let the network stack know the real number of queues that we are using. Fixes: 49d3b493673a ("ionic: disable the queues on link down") Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pen

Re: [PATCH net 0/4] Fixes for SJA1105 DSA tc-gate action

2020-06-25 Thread David Miller
From: Vladimir Oltean Date: Wed, 24 Jun 2020 16:54:43 +0300 > From: Vladimir Oltean > > This small series fixes 2 bugs in the tc-gate implementation: > 1. The TAS state machine keeps getting rescheduled even after removing >tc-gate actions on all ports. > 2. tc-gate actions with only one ga

Re: [PATCH net-next v11 0/5] RGMII Internal delay common property

2020-06-25 Thread David Miller
From: Dan Murphy Date: Wed, 24 Jun 2020 07:16:00 -0500 > The RGMII internal delay is a common setting found in most RGMII capable PHY > devices. It was found that many vendor specific device tree properties exist > to do the same function. This creates a common property to be used for PHY's > th

Re: [PATCH net-next 0/5] dpaa2-eth: small updates

2020-06-25 Thread David Miller
From: Ioana Ciornei Date: Wed, 24 Jun 2020 14:34:16 +0300 > This patch set adds some updates to the dpaa2-eth driver: trimming of > the frame queue debugfs counters, cleanup of the remaining sparse > warnings and some other small fixes such as a recursive header include. Series applied, thank yo

Re: [PATCH net-next] net: phylink: only restart AN if the link mode is using in-band AN

2020-06-25 Thread David Miller
From: Russell King Date: Wed, 24 Jun 2020 12:30:04 +0100 > If we are not using in-band autonegotiation, there is no point passing > the request to restart autonegotiation on to the driver. > > Signed-off-by: Russell King Applied, thank you.

Re: [PATCH net-next] net: dsa/ar9331: convert to mac_link_up()

2020-06-25 Thread David Miller
From: Russell King Date: Wed, 24 Jun 2020 11:21:32 +0100 > Convert the ar9331 DSA driver to use the finalised link parameters in > mac_link_up() rather than the parameters in mac_config(). > > Tested-by: Oleksij Rempel > Signed-off-by: Russell King Applied.

Re: [PATCH net-next] net: phylink: add phylink_speed_(up|down) interface

2020-06-25 Thread David Miller
From: Russell King Date: Wed, 24 Jun 2020 11:04:18 +0100 > Add an interface for the phy_speed_(up|down) functions when a driver > makes use of phylink. These pass the call through to phylib when we > have a normal PHY attached (i.o.w., not a PHY on a SFP module.) > > Signed-off-by: Russell King

Re: [PATCH v2 2/2] net: macb: free resources on failure path of at91ether_open()

2020-06-25 Thread David Miller
From: Claudiu Beznea Date: Wed, 24 Jun 2020 13:08:18 +0300 > DMA buffers were not freed on failure path of at91ether_open(). > Along with changes for freeing the DMA buffers the enable/disable > interrupt instructions were moved to at91ether_start()/at91ether_stop() > functions and the operations

Re: [RFC PATCH 11/11] doc: Documentation for Per Thread Queues

2020-06-25 Thread Jacob Keller
On 6/24/2020 10:17 AM, Tom Herbert wrote: > Add a section on Per Thread Queues to scaling.rst. > --- > Documentation/networking/scaling.rst | 195 ++- > 1 file changed, 194 insertions(+), 1 deletion(-) > > diff --git a/Documentation/networking/scaling.rst > b/Documenta

Re: [PATCH v2 1/2] net: macb: call pm_runtime_put_sync on failure path

2020-06-25 Thread David Miller
From: Claudiu Beznea Date: Wed, 24 Jun 2020 13:08:17 +0300 > Call pm_runtime_put_sync() on failure path of at91ether_open. > > Fixes: e6a41c23df0d ("net: macb: ensure interface is not suspended on > at91rm9200") > Signed-off-by: Claudiu Beznea Applied and queued up for -stable.

RE: [PATCH net-next 04/10] Documentation: networking: ethtool-netlink: Add link extended state

2020-06-25 Thread Keller, Jacob E
> -Original Message- > From: Amit Cohen > Sent: Thursday, June 25, 2020 6:35 AM > To: Keller, Jacob E > Cc: Ido Schimmel ; netdev@vger.kernel.org; > da...@davemloft.net; k...@kernel.org; j...@mellanox.com; > pe...@mellanox.com; ml...@mellanox.com; mkube...@suse.cz; > and...@lunn.ch; f.f

Re: [PATCH net] ionic: update the queue count on open

2020-06-25 Thread Jakub Kicinski
On Thu, 25 Jun 2020 13:12:15 -0700 Shannon Nelson wrote: > Let the network stack know the real number of queues that > we are using. > > Fixes: 49d3b493673a ("ionic: disable the queues on link down") > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/pensando/ionic/ionic_lif.c | 3 +++

Re: [PATCH net-next 0/3] cxgb4: add mirror action support for TC-MATCHALL

2020-06-25 Thread Jakub Kicinski
On Thu, 25 Jun 2020 17:28:40 +0530 Rahul Lakkireddy wrote: > This series of patches add support to mirror all ingress traffic > for TC-MATCHALL ingress offload. > > Patch 1 adds support to dynamically create a mirror Virtual Interface > (VI) that accepts all mirror ingress traffic when mirror acti

[PATCH v3] IPv4: Tunnel: Fix effective path mtu calculation

2020-06-25 Thread Oliver Herms
The calculation of the effective tunnel mtu, that is used to create mtu exceptions if necessary, is currently not done correctly. This leads to unnecessary entries in the IPv6 route cache for any packet send through the tunnel. The root cause is, that "dev->hard_header_len" is subtracted from the

[PATCH v4 bpf-next 14/14] selftests/bpf: Add test for resolve_btfids

2020-06-25 Thread Jiri Olsa
Adding test to resolve_btfids tool, that: - creates binary with BTF IDs list and set - process the binary with resolve_btfids tool - verifies that correct BTF ID values are in place Signed-off-by: Jiri Olsa --- tools/testing/selftests/bpf/Makefile | 20 +- .../selftests/bpf/test_

[PATCH v4 bpf-next 10/14] bpf: Add d_path helper

2020-06-25 Thread Jiri Olsa
Adding d_path helper function that returns full path for give 'struct path' object, which needs to be the kernel BTF 'path' object. The helper calls directly d_path function. Updating also bpf.h tools uapi header and adding 'path' to bpf_helpers_doc.py script. Signed-off-by: Jiri Olsa --- incl

[PATCH v4 bpf-next 12/14] selftests/bpf: Add verifier test for d_path helper

2020-06-25 Thread Jiri Olsa
Adding verifier test for attaching tracing program and calling d_path helper from within and testing that it's allowed for dentry_open function and denied for 'd_path' function with appropriate error. Signed-off-by: Jiri Olsa --- tools/testing/selftests/bpf/test_verifier.c | 19 +- too

[PATCH v4 bpf-next 09/14] bpf: Add info about .BTF.ids section to btf.rst

2020-06-25 Thread Jiri Olsa
Updating btf.rst doc with info about .BTF.ids section Signed-off-by: Jiri Olsa --- Documentation/bpf/btf.rst | 53 +++ 1 file changed, 53 insertions(+) diff --git a/Documentation/bpf/btf.rst b/Documentation/bpf/btf.rst index 4d565d202ce3..60cfb3b06f34 100644

  1   2   3   >