Hi Stanislav, Thank you for the patch! Yet something to improve:
[auto build test ERROR on bpf/master] [also build test ERROR on net/master net-next/master v5.8-rc2 next-20200625] [cannot apply to bpf-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Stanislav-Fomichev/bpf-add-BPF_CGROUP_INET_SOCK_RELEASE-hook/20200626-081210 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master config: nds32-defconfig (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): In file included from ./arch/nds32/include/generated/asm/bug.h:1, from include/linux/bug.h:5, from include/linux/thread_info.h:12, from include/linux/uio.h:9, from include/linux/socket.h:8, from net/ipv4/af_inet.c:69: include/linux/dma-mapping.h: In function 'dma_map_resource': arch/nds32/include/asm/memory.h:82:32: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 82 | #define pfn_valid(pfn) ((pfn) >= PHYS_PFN_OFFSET && (pfn) < (PHYS_PFN_OFFSET + max_mapnr)) | ^~ include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE' 144 | int __ret_warn_once = !!(condition); \ | ^~~~~~~~~ include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid' 352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr)))) | ^~~~~~~~~ net/ipv4/af_inet.c: In function 'inet_release': >> net/ipv4/af_inet.c:415:4: error: implicit declaration of function >> 'BPF_CGROUP_RUN_PROG_INET_SOCK_RELEASE'; did you mean >> 'BPF_CGROUP_RUN_PROG_INET_SOCK'? [-Werror=implicit-function-declaration] 415 | BPF_CGROUP_RUN_PROG_INET_SOCK_RELEASE(sk); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | BPF_CGROUP_RUN_PROG_INET_SOCK cc1: some warnings being treated as errors vim +415 net/ipv4/af_inet.c 400 401 402 /* 403 * The peer socket should always be NULL (or else). When we call this 404 * function we are destroying the object and from then on nobody 405 * should refer to it. 406 */ 407 int inet_release(struct socket *sock) 408 { 409 struct sock *sk = sock->sk; 410 411 if (sk) { 412 long timeout; 413 414 if (!sk->sk_kern_sock) > 415 BPF_CGROUP_RUN_PROG_INET_SOCK_RELEASE(sk); 416 417 /* Applications forget to leave groups before exiting */ 418 ip_mc_drop_socket(sk); 419 420 /* If linger is set, we don't return until the close 421 * is complete. Otherwise we return immediately. The 422 * actually closing is done the same either way. 423 * 424 * If the close is due to the process exiting, we never 425 * linger.. 426 */ 427 timeout = 0; 428 if (sock_flag(sk, SOCK_LINGER) && 429 !(current->flags & PF_EXITING)) 430 timeout = sk->sk_lingertime; 431 sk->sk_prot->close(sk, timeout); 432 sock->sk = NULL; 433 } 434 return 0; 435 } 436 EXPORT_SYMBOL(inet_release); 437 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
